[06:36:18] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1097034 (owner: 10L10n-bot) [07:26:09] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1097207 (owner: 10L10n-bot) [08:48:50] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1097207 (owner: 10L10n-bot) [12:52:09] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Fix "The 'timeZoneOffset' field is invalid" bug - https://phabricator.wikimedia.org/T380741 (10jgleeson) 03NEW [12:59:12] (03PS1) 10Jgleeson: Ensure timeZoneOffset is always integer [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1097371 (https://phabricator.wikimedia.org/T380741) [13:01:29] (03CR) 10CI reject: [V:04-1] Ensure timeZoneOffset is always integer [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1097371 (https://phabricator.wikimedia.org/T380741) (owner: 10Jgleeson) [13:03:15] I could have sworn we added a shorthand script for eslint [13:03:25] I remember running into this before [13:03:57] maybe we proxy on to grunt [13:05:00] yep https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/94acd3dd83017c702d8ef93f5577fdc311af5cc4/Gruntfile.js#L18 [13:23:25] (03PS2) 10Jgleeson: Ensure timeZoneOffset is always integer [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1097371 (https://phabricator.wikimedia.org/T380741) [13:27:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy dupe contributions cleanup - https://phabricator.wikimedia.org/T379941#10352921 (10jgleeson) @Cstone, should we delete these using your new Searchkit now that we're fairly confident we've got the right batch? [14:41:20] (03PS3) 10Jgleeson: Ensure timeZoneOffset is always integer [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1097371 (https://phabricator.wikimedia.org/T380741) [16:59:33] 06Fundraising-Backlog, 06secscrum, 07SecTeam-Processed, 07Security: Review of CSP change for SMS support in banners - https://phabricator.wikimedia.org/T380486#10354321 (10greg) btw, to see how this flow works, this is a test banner: https://en.wikipedia.org/wiki/NASA?banner=pcoombe_rml_sms_1&country=US c... [17:10:50] fr-tech I'm going to do a civi deploy [17:11:54] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097443 [17:12:31] (03CR) 10CI reject: [V:04-1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097443 (owner: 10Ejegg) [17:26:12] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097443 (owner: 10Ejegg) [17:26:30] oops, didn't notice the v-1 [17:26:42] (03CR) 10CI reject: [V:04-1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097443 (owner: 10Ejegg) [17:27:22] ahhh The .git directory is missing from /src/vendor/wikimedia/omnimail-silverpop [17:27:37] got checked in as a submodule by mistake? [17:28:36] weird, though I don't see it in the git log [17:46:10] 06Fundraising-Backlog, 06secscrum, 07SecTeam-Processed, 07Security: Review of CSP change for SMS support in banners - https://phabricator.wikimedia.org/T380486#10354569 (10sbassett) >>! In T380486#10354321, @greg wrote: > btw, to see how this flow works, this is a test banner: https://en.wikipedia.org/wiki... [18:07:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Fundraiseup donations imported without attribution - https://phabricator.wikimedia.org/T380766#10354671 (10Pcoombe) Ah, shoot. Thanks Damilare. I've added them for the Portal campaign we're hoping to run next week. cc @ppenloglou [18:09:41] grr, can anyone else see why CI is getting that error? [18:29:58] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Fundraiseup donations imported without attribution - https://phabricator.wikimedia.org/T380766#10354809 (10Damilare) Thanks @Pcoombe [18:51:20] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Fundraiseup donations imported without attribution - https://phabricator.wikimedia.org/T380766#10354917 (10ppenloglou) Thank you @Damilare ! I wasn't aware we had to add this in the FundraiseUp Campaign. For the Email Campaign they look like this now: {F... [18:58:30] (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097443 [19:02:50] ejegg: I wonder if it's to do with this not being merged into deployment https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1092962 that's the lock bump to 1.10 [19:04:27] oh I see you are merging it [19:11:10] I get the same error locally [19:12:09] git submodule update --init fixes it which suggests vendor isn't in the right state [19:13:41] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Fundraiseup donations imported without attribution - https://phabricator.wikimedia.org/T380766#10354999 (10Pcoombe) Yeah it's my fault @ppenloglou. Last time we did FRU we were still using utm_ parameters for tracking, which they handle automatically. I f... [19:15:21] ah I see PS1 was missing the vendor submodule ejegg [19:15:31] and you fixed it between [19:15:43] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: Populating both_funds_latest_donation_source field - https://phabricator.wikimedia.org/T379700#10355010 (10Eileenmcnaughton) @JMando I think at a high level they are treating anything that is not... [19:22:38] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097443 (owner: 10Ejegg) [19:23:31] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097443 (owner: 10Ejegg) [19:23:36] (03CR) 10Ejegg: "Ah, good point. I've just rebased it over an intermediate patch to remove it from the dependencies so we can disable it." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1093430 (owner: 10Ejegg) [19:24:59] (03PS4) 10Ejegg: Remove wmf_communication and twig/twig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1093430 [19:28:44] woohoo, there are a bunch of emailpreferences-* strings translated now :) [19:30:13] argh, though there are some duplicated messages there [19:30:31] ok, we need to fix that, per Raimond's comments on https://gerrit.wikimedia.org/r/c/translatewiki/+/1090566 [19:30:52] I guess we delete them from wherever has fewer transalations [19:33:10] ejegg: this disable twig - we need to roll out & deploy your other patch, then disable the module & then we push through the full patch? [19:35:10] yep eileen, the other patch has just merged to deployment [19:35:20] I'll push it out and disable the module now [19:35:37] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07fr-acoustic: Investigate how deceased donors are handled between Civi - Acoustic - https://phabricator.wikimedia.org/T379114#10355073 (10jgleeson) @NNgu-WMF I also don't see an easy way in Acoustic to determine if a contact is deceased, either... [19:37:55] !log fundraising civicrm upgraded from 3311520a to b7bd670f [19:37:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:40:53] ok, looks like the FundraisingEmailUnsubscribe extension is deployed on donorwiki, so we can delete those messages from the email_forms directory [19:41:23] cstone: I'm gonna delete those 2470 paypal dupes caught in https://phabricator.wikimedia.org/T379941 in to reduce the change of confusion for DR if they need to refund any and wonder why there's two. [19:41:38] Oh yeah sorry jgleeson [19:41:58] thanks jgleeson [19:42:08] i read your msg earlier and was going to then got distracted [19:43:14] this searchkit bulk action tool is really handy [19:43:47] (03PS1) 10Ejegg: Delete duplicate messages from email_forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1097480 (https://phabricator.wikimedia.org/T376514) [19:43:59] hmmmm, is that the right direction to go? ^^^^ [19:44:14] I was thinking we should delete the duplicates from the place which has fewer translations [19:44:22] yeah! jgleeson [19:45:01] but now I'm thinking we should just move the translations into the new place [19:45:14] into the preference center area ejegg ? [19:45:26] yeah [19:45:35] yeah might as well if we are moving them? [19:45:44] ok, i'll redo that [19:47:06] right, just a lot of languages to copypaste, and some new files to make [20:00:36] (03CR) 10Eileen: [C:03+2] Remove wmf_communication and twig/twig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1093430 (owner: 10Ejegg) [20:03:55] hmm cstone I think I'm going to rename them in the new place too [20:04:06] but I'll try to copy over the existing ones [20:04:08] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07fr-acoustic: Investigate how deceased donors are handled between Civi - Acoustic - https://phabricator.wikimedia.org/T379114#10355163 (10Eileenmcnaughton) @jgleeson ah yes - that makes sense - we have a small extension that does that [20:04:42] +1 for better names [20:23:33] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337#10355214 (10Eileenmcnaughton) @MDemosWMF I think we had the banners on full for 24 hours at the end of... [20:25:13] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337#10355221 (10EMartin) @AKanji-WMF @dkozlowski. Could we treat as urgent? This has high impact on the... [20:26:40] (03Merged) 10jenkins-bot: Remove wmf_communication and twig/twig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1093430 (owner: 10Ejegg) [20:27:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10355225 (10SHust) CID 54625032 was snoozed on 10/2 and received another email on 11/25. The Acoustic log doesn't show CID as snoozed and shows instead t... [20:29:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Increase batch entry size limit - https://phabricator.wikimedia.org/T380305#10355227 (10EMartin) p:05Triage→03High @AKanji-WMF @dkozlowski. This is causing the data entry team to get behind. [20:36:23] (03PS1) 10Ejegg: Remove duplicated messages [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1097498 (https://phabricator.wikimedia.org/T376514) [20:36:49] (03Abandoned) 10Ejegg: Delete duplicate messages from email_forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1097480 (https://phabricator.wikimedia.org/T376514) (owner: 10Ejegg) [20:39:55] (03CR) 10CI reject: [V:04-1] Remove duplicated messages [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1097498 (https://phabricator.wikimedia.org/T376514) (owner: 10Ejegg) [20:46:56] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 10FR-email-preferences, 07fr-acoustic: Email pref centre - Solve email overwrite issue from recurring - https://phabricator.wikimedia.org/T353376#10355259 (10Damilare) a:05Damilare→03None [20:51:18] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337#10355265 (10Eileenmcnaughton) So this is about managing server load - in general we expect lags in get... [20:51:23] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog: 2024 Sprint W- Priorities - https://phabricator.wikimedia.org/T376751#10355263 (10AKanji-WMF) [21:05:42] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 10Wikimedia-Fundraising-CiviCRM: Batch Imports Tool - Scope Feature list - https://phabricator.wikimedia.org/T377890#10355308 (10MDemosWMF) @Eileenmcnaughton Great! Let me know if you need anything from me in the meantime. [21:20:17] (03PS4) 10Jgleeson: Ensure timeZoneOffset is always integer [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1097371 (https://phabricator.wikimedia.org/T380741) [21:27:06] 06Fundraising-Backlog: Save PayerID for gravy paypal - https://phabricator.wikimedia.org/T380588#10355349 (10Cstone) [21:30:09] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Civi merge is not saving the state when a mailing address is present. - https://phabricator.wikimedia.org/T379684#10355359 (10jgleeson) a:03jgleeson [21:31:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Civi merge is not saving the state when a mailing address is present. - https://phabricator.wikimedia.org/T379684#10355365 (10AKanji-WMF) p:05Triage→03Medium * deduper extension, wmf extension [21:32:23] (03PS2) 10Ejegg: Remove duplicated messages [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1097498 (https://phabricator.wikimedia.org/T376514) [21:36:41] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: Populating both_funds_latest_donation_source field - https://phabricator.wikimedia.org/T379700#10355385 (10MDemosWMF) Looping in @EMartin as she has asked to know if there are open threads from N... [21:51:56] 10 minutes in Jack 1, my attention 0 [21:52:33] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07fr-acoustic: Investigate how deceased donors are handled between Civi - Acoustic - https://phabricator.wikimedia.org/T379114#10355438 (10NNgu-WMF) Thanks all! I think I had also looked into specific deceased CIDs and seen that they were all op... [22:04:49] (03PS1) 10Eileen: Relabel new fields to reduce confusiong [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1097528 (https://phabricator.wikimedia.org/T374720) [22:23:54] if anyone wants to tackle a few this chain starts super gently - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1094568/1 [22:25:16] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097536 [22:25:40] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097536 (owner: 10Eileen) [22:26:39] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1097536 (owner: 10Eileen) [22:32:19] !log civicrm upgraded from b7bd670f to 190ea417 [22:32:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:34:53] i can look eileen [22:35:13] (03CR) 10Cstone: [C:03+2] "gentle indeed" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094568 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen) [22:40:18] (03CR) 10Cstone: [C:03+2] Remove commented out boilerplate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094566 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen) [22:46:20] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: Populating both_funds_latest_donation_source field - https://phabricator.wikimedia.org/T379700#10355586 (10EMartin) @IAckerman-WMF + Ilse for awareness. This is something that will fall to the n... [22:51:23] thanks cstone [22:57:43] (03Merged) 10jenkins-bot: Port schema support for bigint [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094568 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen) [23:03:01] (03Merged) 10jenkins-bot: Remove commented out boilerplate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094566 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen) [23:20:37] 06Fundraising-Backlog: Error due to decimal in Stock Quantity amount - https://phabricator.wikimedia.org/T380804 (10MDemosWMF) 03NEW [23:20:52] 06Fundraising-Backlog: Error due to decimal in Stock Quantity amount - https://phabricator.wikimedia.org/T380804#10355673 (10MDemosWMF) p:05Triage→03High [23:25:40] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337#10355691 (10EMartin) I'll confirm with the team but we previously didn't experience such lags in prior... [23:28:46] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337#10355694 (10Eileenmcnaughton) Yes, there is a difference - the imports are set to lower priority compa... [23:29:29] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337#10355695 (10Eileenmcnaughton) (However, we did used to tell people not to do imports when big english... [23:35:18] (03CR) 10Cstone: [C:03+2] Civix Update civicrm-extendedmailingstats to Entity 2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094565 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen) [23:35:30] (03CR) 10Cstone: [C:03+2] Whitespace fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094571 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen) [23:35:53] (03CR) 10Cstone: [C:03+2] Superficial layout changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094572 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen) [23:45:38] 03Fundraising Sprint: wwwwwwwwwwwwwww(), 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337#10355801 (10EMartin) Well, my team works 8-5 and we certainly never had to plan for low volume events... [23:57:00] (03Merged) 10jenkins-bot: Civix Update civicrm-extendedmailingstats to Entity 2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094565 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen) [23:58:57] (03Merged) 10jenkins-bot: Whitespace fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094571 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen) [23:58:59] (03Merged) 10jenkins-bot: Superficial layout changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1094572 (https://phabricator.wikimedia.org/T361621) (owner: 10Eileen)