[06:05:34] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1101280 (owner: 10L10n-bot) [14:01:52] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10390227 (10jgleeson) a:03jgleeson [14:45:57] (03PS2) 10Damilare Adedoyin: WIP: Add ApplePay for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1100584 (https://phabricator.wikimedia.org/T367785) (owner: 10Cstone) [14:46:32] (03CR) 10CI reject: [V:04-1] WIP: Add ApplePay for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1100584 (https://phabricator.wikimedia.org/T367785) (owner: 10Cstone) [15:45:28] 06Fundraising-Backlog, 10FR-donorservices: Suppress One-time-transactions from ty email receipt - https://phabricator.wikimedia.org/T380403#10390526 (10AKanji-WMF) There are a high volume of donations like this (Sandra has included a few examples above). These are cases where an unintentional recurring donati... [15:58:23] 06Fundraising-Backlog, 10FR-donorservices: Request to please begin the deployment of the Auto TY email receipt ("End of Year Receipt") on January 6th - https://phabricator.wikimedia.org/T381781 (10SHust) 03NEW [15:58:45] 06Fundraising-Backlog, 10FR-donorservices: Request to please begin the deployment of the Auto TY email receipt ("End of Year Receipt") on January 6th - https://phabricator.wikimedia.org/T381781#10390564 (10SHust) [16:48:56] (03PS2) 10Jgleeson: WIP: Add testMergeRetainsStateInAddress to confirm bug in T379684 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1098513 (https://phabricator.wikimedia.org/T379684) [17:09:18] (03PS3) 10Damilare Adedoyin: WIP: Add ApplePay for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1100584 (https://phabricator.wikimedia.org/T367785) (owner: 10Cstone) [17:09:43] (03CR) 10CI reject: [V:04-1] WIP: Add ApplePay for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1100584 (https://phabricator.wikimedia.org/T367785) (owner: 10Cstone) [17:19:32] hmm cstone, I'd rebase over your patch so you don't get disturbed with the pings when I push to your patch. [17:22:12] Sure it's really not much too I did figure out Thursday night that my payment sheet wasn't popping up because apple pay at turned itself off on my Mac... [17:37:31] ahh were you able to get it back on? yh I was able to work from where you stopped to the payment sheet on mine. Thanks for all the work on that. [17:37:44] just need to get gravy to add one endpoint to the sdk [17:39:22] Yeah I got it back but it was so confusing hah and nice ! [17:42:14] (03PS1) 10Damilare Adedoyin: WIP: Gravy apple pay [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) [17:42:41] (03CR) 10CI reject: [V:04-1] WIP: Gravy apple pay [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [17:45:20] (03PS2) 10Damilare Adedoyin: WIP: Gravy apple pay [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) [18:19:15] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10391096 (10NNgu-WMF) >>! In T376959#10382642, @krobinson wrote: > - One related to donors sig... [18:21:10] (03CR) 10Jgleeson: [C:04-1] "Hi Dami. As mentioned re: the new validateInput() method noticed in the the other patch, I think we can rework the design by injecting the" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [18:28:22] (03CR) 10Jgleeson: [C:04-1] WIP: Gravy apple pay (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [18:28:48] damilare: i planned to write that up on friday but ran out of time ^ [18:30:40] thanks jgleeson, I'd look at that soon as I wrap up the task e2e. Would need a follow on patch to refactor the other classes too, so as not to muddle this up. [18:31:26] I don't think we want to +2 those new public methods to the class [18:31:43] I don't think they are called by the calling code right? [18:32:00] they could be private I think? [18:33:13] what do you mean wrap up the task e2e? [18:33:44] I'm working on the DonationInterface side now to complete the payment flow [18:34:13] hmm [18:34:18] yes, the validators can be made private. [18:46:43] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10391252 (10bsisolak) Snooze is not a field you can query on. [19:13:49] (03PS1) 10Jgleeson: Refactor Gravy request mapper code. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101579 [19:14:16] (03CR) 10CI reject: [V:04-1] Refactor Gravy request mapper code. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101579 (owner: 10Jgleeson) [19:15:48] (03PS2) 10Jgleeson: Refactor Gravy request mapper code. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101579 [19:18:35] damilare: ^ that was another refactor I was going to suggest but figured it would be quicker to write. It's to keep the way we manage different request mapping consistent and also building on allowing us to inject request mappers, that you added in the BankPaymentProvider, by pulling it up to the base class and making the other concrete classes use that design [19:18:45] (03PS1) 10Damilare Adedoyin: Remove unused fields from gravy google and apple pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101582 [19:18:50] you can see where I'm going with that [19:20:26] basically, once we can inject validators, request mappers and response mappers, we can easily swap out each for payment-method specific implementations. Also having the additional code seams (https://martinfowler.com/bliki/LegacySeam.html) means we can more easily mock those parts of the codes in tests [19:20:36] injectable* [19:21:34] (03PS3) 10Jgleeson: Refactor Gravy request mapper code. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101579 [19:22:33] that design would be a huge improvement over the old adyen/paypal/other code in terms of encapsulation [19:23:16] nice jgleeson, that's similar to the initial idea I had in mind. Do we create new request mappers for each provider then? [19:24:09] that way we can eliminate this mapToGoogleCreatePaymentRequest type of methods [19:24:23] and just use mapToCreatePaymentRequest [19:24:42] I guess it's up to you. If it feels like the current request mapper is feeling bloated or contains methods specific to one provider and not the other, then splitting them out would make sense to me [19:24:48] ya! [19:24:51] sounds good [19:25:01] thanks [19:25:10] make sense [19:25:12] thank you! for writing all the code [19:25:47] saves us a lot of lines to not have to define the same createPayment method for all the provider classes [19:25:58] and also probably easier to debug too [19:26:32] yup. also makes the code nicer to open up and read and think, isn't this nice :D [19:28:33] (03PS1) 10Damilare Adedoyin: WIP: Gravy Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 [19:29:17] (03PS4) 10Jgleeson: Refactor Gravy request mapper code. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101579 [19:30:30] (03CR) 10CI reject: [V:04-1] WIP: Gravy Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (owner: 10Damilare Adedoyin) [19:32:11] damilare: My thoughts on createPayment() one, is that it does feel like that's one of the few methods that each concrete class should/could implement in its own custom way as it's the main method on the paymentprovider interface so I imagine when you open those payment-method-specific providers, you kinda expect to see a custom implementation of it [19:33:46] it's also conceivable that we might want to have custom exception messages instead of sending back our current generic "Processor failed to create new payment with response:" [19:33:51] in this case the expectation (given gravy) is for it to not have that many custom implementations in the flow. [19:34:19] hmm, the log message [19:34:48] oh yeah sorry log message [19:34:55] I guess that makes it less important [19:35:09] I see what you mean about the sharing of the body of that method [19:35:20] maybe that could be broken up to submethods too [19:36:05] although looking at it now, it's not doing much if you strip out the comments [19:36:54] yea exactly, I think if we have to start making custom implementation of the providers, we would need to reassess if the orchestrator is of much benefit. lol [19:37:31] well I guess they are all slightly different [19:38:13] to make it easier to discuss, here's a trimmed down copy https://phabricator.wikimedia.org/P71646 [19:38:25] so I think lines 5-9 could be a method [19:38:52] esepcially once we add injectable vaidators [19:39:05] true [19:39:50] and then the rest of the code reads pretty expressively I think [19:40:09] lots of step1 = getStep1Thing, step2 = getStepTwoThing [19:40:14] as long as the mappers are also injectable the rest can be inherited [19:40:16] yep [19:40:41] the difference in the methods are mostly handled within the request/response mappers [19:41:01] yeah that makes sense [19:41:24] everything else is pretty much standard across board. [19:41:38] brb goign to get dinner before standup [19:41:45] cool cool [19:41:50] for when you get back [19:43:58] re:inheritence. So, are you thinking you might be able to come up with a base class for the mappers such as RequestMappper::mapToCreatePaymentRequest() and ResponseMapper::mapFromPaymentResponse() which the payment-method-mappers implement? that could hide a lot of the detail [19:44:14] inheritance* [19:45:04] scratch that, not hide the detail, I meant to say "make it consistent and better" [19:45:44] oh wow [19:46:08] TIL you can select code lines for linkable highlighting in phab pastes e.g. https://phabricator.wikimedia.org/P71646$6-9 [19:46:28] pretty sweet [20:25:33] (03PS2) 10Damilare Adedoyin: WIP: Gravy Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 [20:27:26] (03CR) 10CI reject: [V:04-1] WIP: Gravy Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (owner: 10Damilare Adedoyin) [20:27:52] (03PS3) 10Damilare Adedoyin: WIP: Gravy apple pay [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) [20:28:14] (03CR) 10CI reject: [V:04-1] WIP: Gravy apple pay [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [20:45:34] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: 2024 Sprint X- Priorities - https://phabricator.wikimedia.org/T376751#10391548 (10AKanji-WMF) [20:46:55] 06Fundraising-Backlog, 10FR-Batch-Data-Entry: Batch data entry feature request: Tabbing through fields - https://phabricator.wikimedia.org/T371543#10391556 (10XenoRyet) [20:47:56] 06Fundraising-Backlog: FundraiseUp testing Q2 - 2425 - https://phabricator.wikimedia.org/T377732#10391558 (10XenoRyet) [20:51:35] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10FR-donorservices: Add additional cancellation reason to Civi and Acoustic - https://phabricator.wikimedia.org/T380425#10391564 (10Eileenmcnaughton) a:03Eileenmcnaughton [20:51:51] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10FR-donorservices: Add additional cancellation reason to Civi and Acoustic - https://phabricator.wikimedia.org/T380425#10391565 (10Eileenmcnaughton) [20:52:40] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM: Omnimail entities not loading well after entity update pushed out - https://phabricator.wikimedia.org/T381059#10391569 (10AKanji-WMF) [20:52:41] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Auto retry for DB deadlock in imports - https://phabricator.wikimedia.org/T381054#10391570 (10AKanji-WMF) [20:52:42] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Civimail users require permissions - review required - https://phabricator.wikimedia.org/T380935#10391571 (10AKanji-WMF) [20:52:48] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Recurring-Donations: Change annual recurrings to get thank you emails on the 2+ charge - https://phabricator.wikimedia.org/T380321#10391572 (10AKanji-WMF) [20:52:52] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 07payments-orchestration: Set up recurring charge for venmo - https://phabricator.wikimedia.org/T376122#10391573 (10AKanji-WMF) [20:52:56] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 07Epic, 07payments-orchestration: Gravy Braintree implementation: Venmo - https://phabricator.wikimedia.org/T375267#10391574 (10AKanji-WMF) [20:53:07] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Add comms preferences footer to all Civi-generated emails - https://phabricator.wikimedia.org/T359445#10391577 (10AKanji-WMF) [20:53:11] 14Fundraising Sprint: justWork(), 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 13Patch-For-Review: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#10391576 (10AKanji-WMF) [20:53:20] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, and 4 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#10391579 (10AKanji-WMF) [20:53:47] 06Fundraising-Backlog, 10FR-donorservices: Request to please begin the deployment of the Auto TY email receipt ("End of Year Receipt") on January 6th - https://phabricator.wikimedia.org/T381781#10391582 (10AKanji-WMF) this year's version of {https://phabricator.wikimedia.org/T326155} [20:56:59] 06Fundraising-Backlog: SMS testing - https://phabricator.wikimedia.org/T381809 (10Cstone) 03NEW [21:05:16] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: SMS testing - https://phabricator.wikimedia.org/T381809#10391608 (10Cstone) [21:07:31] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10391613 (10AKanji-WMF) p:05Triage→03High [21:10:38] 06Fundraising-Backlog: 2nd Recurring Failure Email in Civi - https://phabricator.wikimedia.org/T365488#10391618 (10AKanji-WMF) [21:10:53] 06Fundraising-Backlog, 10FR-email-preferences, 07fr-acoustic: Email pref centre - Solve email overwrite issue from recurring - https://phabricator.wikimedia.org/T353376#10391619 (10AKanji-WMF) [21:10:55] (03PS1) 10Eileen: Port apiv4 getMergedTo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1101590 (https://phabricator.wikimedia.org/T381633) [21:11:06] 06Fundraising-Backlog, 10FR-email-preferences, 10Recurring-Donations, 10MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), 13Patch-For-Review: For donor prefs pages, offer to send a new link when checksum is expired - https://phabricator.wikimedia.org/T352337#10391621 (10AKanji-WMF) [21:11:24] jgleeson: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1101590 - might be better to write with v4 [21:13:10] 06Fundraising-Backlog, 10FR-donorservices: Request to please begin the deployment of the Auto TY email receipt ("End of Year Receipt") on January 6th - https://phabricator.wikimedia.org/T381781#10391636 (10Eileenmcnaughton) [21:14:49] 06Fundraising-Backlog, 10FR-donorservices: Request to please begin the deployment of the Auto TY email receipt ("End of Year Receipt") on January 6th - https://phabricator.wikimedia.org/T381781#10391652 (10Damilare) [21:16:42] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Batch-Data-Entry: Upstream batch data entry soft credit fix - https://phabricator.wikimedia.org/T381328#10391666 (10Damilare) [21:18:17] 06Fundraising-Backlog, 10FR-donorservices: Suppress new in december recurring donations from ty email receipt - https://phabricator.wikimedia.org/T380403#10391681 (10Cstone) [21:19:53] 06Fundraising-Backlog, 10FR-donorservices: Suppress recurrings with only one charge from ty email receipt - https://phabricator.wikimedia.org/T380403#10391683 (10Cstone) [21:20:31] 06Fundraising-Backlog, 10FR-donorservices: Suppress recurrings with only one charge from ty email receipt - https://phabricator.wikimedia.org/T380403#10391684 (10Cstone) [21:21:48] 06Fundraising-Backlog, 10FR-donorservices: Suppress recurrings with only one charge from ty email receipt - https://phabricator.wikimedia.org/T380403#10391686 (10Damilare) [21:24:38] 06Fundraising-Backlog: 2nd Recurring Failure Email in Civi - https://phabricator.wikimedia.org/T365488#10391704 (10Damilare) [21:33:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2556 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [21:34:14] ^^ that's from testing i was doing. should clear shortly. [21:38:15] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 663 Threads: 4 Questions: 1343397 Slow queries: 0 Opens: 1203 Open tables: 1185 Queries per second avg: 2026.239 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [21:42:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [21:46:50] lgtm eileen [21:47:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [21:52:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [21:57:11] RECOVERY - check_mysql on frdb1003 is OK: Uptime: 1724928 Threads: 9 Questions: 2820257165 Slow queries: 409 Opens: 19065 Open tables: 1951 Queries per second avg: 1634.999 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [22:10:52] 06Fundraising-Backlog, 10fundraising-tech-ops, 06Data Products, 06Data-Platform, 10FR-Tech-Analytics: Allow Fundraising Supserset to connect to Production Druid - https://phabricator.wikimedia.org/T370944#10391981 (10VirginiaPoundstone) [22:40:17] cstone: so where is the test at for SMS - did it work end to end for you yet? [22:41:33] So no end to end yet as donate wiki needs to be updated to pass the param through [22:41:47] So my test earlier lost the recipient id [22:46:27] cstone: ok - is there a patch for donate wiki - I thought I +2d one from Elliott a while back but maybe that was payment wiki [22:47:37] Oh this is on peters end [22:47:42] Sam said they would fix it tomorrow [22:47:50] Yeah the payments wiki one is good [23:00:45] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10392118 (10Eileenmcnaughton) @bsisolak so with contact [[ https://civicrm.wikimedia.org/civicr... [23:04:20] ah OK [23:08:06] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10392137 (10bsisolak) When you search a record, you click Contact Insights on the right side. O... [23:27:19] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10392145 (10Eileenmcnaughton) @SHust so that example does seem to have worked correctly - do we... [23:27:49] 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337#10392146 (10Eileenmcnaughton) [23:28:35] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: Update any changes to fr-tech documentation - https://phabricator.wikimedia.org/T379208#10392149 (10Eileenmcnaughton) [23:30:34] anilk: I dragged all the phabs we dropped out of the sprint into +1 cos it seems like sometimes they get accidentally rolled back in next sprint [23:32:15] thanks eileen - XenoRyet we should come up with an approach in case those are brought into office hours tomorrow [23:43:46] Yea, sounds like a good idea.