[00:03:33] <wikibugs>	 10fundraising-tech-ops, 10BDC-Implementation, 07Epic: Package and install starburst metabase driver - https://phabricator.wikimedia.org/T382386 (10Jgreen) 03NEW
[00:18:48] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Move monthly convert to its own example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1101625 (owner: 10Cstone)
[02:42:12] <cstone>	 how are these tests breaking hah 
[04:23:47] <eileen>	  Undefined property: Civi\WorkflowMessage\MonthlyConvert::$contactId
[04:23:57] <eileen>	 in RecurringMessage it needs to be contactID
[04:29:52] <wikibugs>	 06Fundraising-Backlog: FundraiseUp testing Q2 - 2425 - https://phabricator.wikimedia.org/T377732#10411575 (10MSuijkerbuijk_WMF) Next steps are completing reporting, so no asks from FR Tech.
[04:33:26] <eileen>	 cstone: if you feel up for a lazy +2 on this (& it's prequel) I can see what it returns - it looks like I could do a follow up -re-snooze' https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1100579
[04:34:45] <cstone>	 With the tests though why is it even getting into the monthly convert message I had to stop halfway through my stepping through 
[04:35:05] <cstone>	 And yeah Eileen sorry I got distracted from reviewing 
[04:35:31] <eileen>	 I got distracted too - should never have looked at those prefixes & suffixes
[04:35:32] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Test extraction in preparation for new test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100578 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen)
[04:35:55] <eileen>	 I suspect what is cached might affect the tests?
[04:36:21] <cstone>	 Snoozy duck 
[04:37:06] <cstone>	 Even caching on ci though ? 
[04:38:23] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Add new Omnicontact.AuditSnooze v4 api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100579 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen)
[04:38:34] <eileen>	 thanks cstone 
[04:38:43] <cstone>	 Np eileen 
[04:39:19] <eileen>	 cstone: so what I see is 13:18:36 Undefined property: Civi\WorkflowMessage\MonthlyConvert::$contactId
[04:39:55] <cstone>	 Yeah I saw that too and stepping through it it was erroring in the API queue consume call
[04:40:00] <eileen>	 and on /src/wikimedia/fundraising/crm/drupal/sites/default/civicrm/extensions/wmf-thankyou/Civi/WorkflowMessage/RecurringMessage.php:56 I see it should be contactID not contactId (pre-exising issue)
[04:40:44] <eileen>	 but surfaced here ....
[04:40:49] <cstone>	 Ah hah 
[04:41:36] <cstone>	 I was trying to figure out why that ingenico recurring test was even getting to it but thinking about it now if we are making a new recurring each time I guess that gives it a path to have a monthly convert 
[04:41:45] <cstone>	 Er no wait hmm 
[04:42:02] <cstone>	 If it had been one time 
[04:50:02] <eileen>	 it does look like sendSuccessThankYouMail is meaning to send a monthly convert & would have been doing that already
[04:52:42] <cstone>	 now theres a bunch of missing properties
[04:53:14] <cstone>	 i guess cause the ty workflow has all these
[04:53:24] <cstone>	 but the test isn't explictally looking for them so what is
[04:53:39] <cstone>	 the recurring queue consumer i guess
[04:57:28] <cstone>	 hmm now the test is missing the amount so its not using the one in the example
[04:58:03] <wikibugs>	 (03Merged) 10jenkins-bot: Test extraction in preparation for new test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100578 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen)
[05:00:37] <eileen>	 it lives to vex
[05:00:42] <cstone>	 haha
[05:00:46] <cstone>	 it just keeps going deeper
[05:00:59] <cstone>	 where is Mickey and his 3 CAD coming from
[05:01:43] <wikibugs>	 (03Merged) 10jenkins-bot: Add new Omnicontact.AuditSnooze v4 api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100579 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen)
[05:03:53] <cstone>	 its losing all the variables
[05:05:34] <eileen>	 this is local or on jenkins
[05:06:04] <cstone>	 local
[05:06:13] <cstone>	 i can push it up though so jenkins does it too hah
[05:06:32] <wikibugs>	 (03PS4) 10Cstone: Move monthly convert to its own example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1101625
[05:06:42] <cstone>	 its late for me im going to pause here
[05:06:51] <cstone>	 maybe it will make sense to me tomorrow
[05:07:18] <eileen>	 :-)
[05:08:40] <cstone>	 have a good rest of your day eileen 
[05:08:56] <wikibugs>	 (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1105105
[05:10:01] <wikibugs>	 (03CR) 10Eileen: [C:03+2] "I need to get out the api add & at some point the annual fix - nothing in the rest warrants the confusion of cherry-pick vs merge" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1105105 (owner: 10Eileen)
[05:11:13] <eileen>	 !log civicrm upgraded from 0d7f2866 to 8163be0d
[05:11:15] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[05:18:53] <wikibugs>	 (03PS1) 10Eileen: Add try-catch to try to finish [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105106 (https://phabricator.wikimedia.org/T376959)
[05:19:42] <wikibugs>	 (03CR) 10Eileen: [C:03+2] "I'm possibly butchering our new 'can self-merge additional logging rule' - but this is also an api that is never called except in my curre" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105106 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen)
[05:28:05] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Move monthly convert to its own example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1101625 (owner: 10Cstone)
[05:40:45] <wikibugs>	 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Normalize names of prefixes and suffixes - https://phabricator.wikimedia.org/T320582#10411603 (10Eileenmcnaughton) This caught my eye for triage but I would up doing a clean up round as I got sucked in. Some of the duplicates will come back but things lik...
[05:41:39] <wikibugs>	 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Normalize names of prefixes and suffixes - https://phabricator.wikimedia.org/T320582#10411604 (10Eileenmcnaughton) a:03Eileenmcnaughton
[05:42:04] <wikibugs>	 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Normalize names of prefixes and suffixes - https://phabricator.wikimedia.org/T320582#10411607 (10Eileenmcnaughton) 05Open→03Resolved
[05:42:13] <wikibugs>	 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Normalize names of prefixes and suffixes - https://phabricator.wikimedia.org/T320582#10411608 (10Eileenmcnaughton)
[05:48:18] <wikibugs>	 (03Merged) 10jenkins-bot: Add try-catch to try to finish [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105106 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen)
[05:54:35] <wikibugs>	 (03PS1) 10Eileen: Make sure some of our Smarty variables are assigned [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105108
[05:54:57] <wikibugs>	 (03PS2) 10Eileen: Make sure some of our Smarty variables are assigned [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105108
[05:55:55] <wikibugs>	 (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1105109
[05:56:23] <wikibugs>	 (03CR) 10Eileen: "I added a follow on that at least points to what is happening" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1101625 (owner: 10Cstone)
[05:56:46] <wikibugs>	 (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1105109 (owner: 10Eileen)
[05:57:35] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1105109 (owner: 10Eileen)
[05:59:08] <eileen>	 !log civicrm upgraded from 8163be0d to 47cddc15
[05:59:10] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[06:18:15] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Make sure some of our Smarty variables are assigned [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105108 (owner: 10Eileen)
[11:20:15] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10412106 (10Eileenmcnaughton) I realised I can do chaining to use the existing api to re-snooze - like this  ` echo '{"fromDateTime":"50 days ago","toDat...
[11:31:20] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10412132 (10Eileenmcnaughton) I ran a few variants of ^^ manually & queued re-snoozing for 615 & counting
[14:53:58] <wikibugs>	 (03CR) 10Jgleeson: "Thanks for this! It looks like a clever solution, and I appreciate the work you've put into it. I do have one small concern, the use of th" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100579 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen)
[15:42:11] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: New recurring donations that have the contribution_recur info but are missing the contribution info - https://phabricator.wikimedia.org/T381937#10412881 (10SHust) CID 66359626 is another record that Adri found through Zendesk with a PayPal recurring donat...
[16:33:44] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Civi cancelation button not working on two PayPal donations. - https://phabricator.wikimedia.org/T382426 (10SBorriello) 03NEW
[18:11:42] <wikibugs>	 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: Add ncreasy to gerrit group wikimedia-fundraising-analytics - https://phabricator.wikimedia.org/T382431 (10Dwisehaupt) 03NEW
[18:19:33] <wikibugs>	 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: Add ncreasy to gerrit group wikimedia-fundraising-analytics - https://phabricator.wikimedia.org/T382431#10413468 (10Dwisehaupt) a:03Dwisehaupt ncreasy added to the group. awaiting verification.
[18:41:19] <wikibugs>	 14Fundraising Sprint: UnusedFunctionButDontDeleteItIncaseItsUsed(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Civi "thank you letter summary" feature request - https://phabricator.wikimedia.org/T299096#10413573 (10AKanji-WMF) 05Resolved→03Open @Eileenmcnaughton: @ppenl...
[18:56:18] <wikibugs>	 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: Check that end of year (EOY) email receipt templates are ready for January 2025 and send them - https://phabricator.wikimedia.org/T380330#10413689 (10AKanji-WMF) Adding @ppenloglou to help ensure Ramon's draft moves to current for our TY email template....
[18:57:05] <wikibugs>	 10fundraising-tech-ops, 10BDC-Implementation, 06Privacy Engineering, 10Security Preview, 07SecTeam-Processed: [Trino] Investigate install, operation and maintenance, and security monitoring. - https://phabricator.wikimedia.org/T367818#10413690 (10Irisbdc)
[18:57:11] <wikibugs>	 10fundraising-tech-ops, 10BDC-Implementation, 06Data-Platform-SRE: [Hive] Investigate packaging, install, security monitoring. - https://phabricator.wikimedia.org/T377635#10413691 (10Irisbdc)
[18:59:25] <wikibugs>	 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: Add ncreasy to gerrit group wikimedia-fundraising-analytics - https://phabricator.wikimedia.org/T382431#10413702 (10Dwisehaupt) 05Open→03Resolved verified that ncreasy can clone the repo.
[18:59:48] <wikibugs>	 10fundraising-tech-ops, 10BDC-Implementation, 07Epic: [Metabase] Package and install starburst metabase driver - https://phabricator.wikimedia.org/T382386#10413706 (10Irisbdc)
[19:10:24] <wikibugs>	 10fundraising-tech-ops, 10BDC-Implementation, 07Epic: EPIC: Metabase Implementation - https://phabricator.wikimedia.org/T377363#10413759 (10Irisbdc)
[19:59:51] <wikibugs>	 (03CR) 10Eileen: "I will quote a very wise woman (aka cstone) "naming is hard" - but I can see that we already use Audit so yes - one of your alternatives m" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100579 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen)
[20:00:50] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-donorservices: Donation history in a single email feature request - https://phabricator.wikimedia.org/T368668#10413914 (10Eileenmcnaughton) @AKanji-WMF - did you mean to re-open this?
[20:03:24] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-donorservices: Donation history in a single email feature request - https://phabricator.wikimedia.org/T368668#10413926 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF No - maybe it re-opened because I re-opened this {https://phabricator.wikime...
[20:03:41] <wikibugs>	 14Fundraising Sprint: UnusedFunctionButDontDeleteItIncaseItsUsed(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Civi "thank you letter summary" feature request - https://phabricator.wikimedia.org/T299096#10413930 (10Eileenmcnaughton) The on demand receipt uses the same work...
[20:27:47] <wikibugs>	 (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.15.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1104007 (owner: 10Libraryupgrader)
[20:35:32] <eileen>	 dwisehaupt: do we push any environment vars into coworker?  We have this civicrm.settings.php but in coworker context it seems to be set to 500
[20:35:32] <eileen>	 in if (!defined('busy_threshold')) {
[20:35:32] <eileen>	   define('busy_threshold', 100);
[20:35:32] <eileen>	 }
[20:37:00] <dwisehaupt>	 hmmm... dunno. let me see if we have anything in puppet.
[20:38:25] <dwisehaupt>	 in the firejail profile we just pass: /srv/coworker/bin/coworker run --pipe='/srv/cv/bin/cv ev "Civi::pipe();"'
[20:38:37] <dwisehaupt>	 not seeing anything we are passing.
[20:46:30] <eileen>	 hmm - I wonder why it is not getting the same busy_threshold
[20:52:33] <dwisehaupt>	 it's using www-data:www-data with a service_dir of /srv/org.wikimedia.civicrm/drupal/sites/default in case that makes any difference.
[20:53:10] <eileen>	 seems right - I'm curious if restarting the process would change anything
[20:54:39] <dwisehaupt>	 easy enough to try if you want.
[21:02:42] <eileen>	 please do then
[21:03:05] <dwisehaupt>	 restarted.
[21:06:30] <eileen>	 dwisehaupt: yep that did it
[21:06:50] <dwisehaupt>	 ok cool. is coworker something we want to restart on certain config changes?
[21:07:09] <dwisehaupt>	 it's possible we could do something in puppet depending on where the file changes come from.
[21:09:57] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10414170 (10Eileenmcnaughton) Seems like we need check permissions  ` echo '{"fromDateTime":"1 days ago","toDateTime": "now",  "checkPermissions": 0, "ch...
[21:11:15] <eileen>	 dwisehaupt: yeah - let's chalk it up to learning for now
[21:12:45] <eileen>	 but also - I have another request - can we alter wmf-cv  to include --user=root - we thought about doing this when we set up wmf-cv but hesitated but it turns out it trips us up
[21:12:45] <eileen>	 /usr/local/bin/wmf-cv api4 --user=root
[21:13:55] <dwisehaupt>	 i'll have a look.
[21:29:26] <eileen>	 it looks like most of the snoozes have the correct checkPermissions - not sure why - but after the first 60 it should improve
[21:30:21] <eileen>	 I guess I did the first lot in api explorer & the second lot in drush & drush implictly added checkPermissions=0 (yay drush) - which I guess wmf-cv would not have done
[21:33:22] <eileen>	 maybe that is an argument for not changing wmf-cv - hmm
[21:40:53] <dwisehaupt>	 ok. i haven't changed it yet, but if we want to, we can just update the cv puppet manifest to add that cli argument.
[21:42:56] <eileen>	 ok cool - I'll think more
[21:43:25] <eileen>	 actually no - go ahead & do it - just looking - the wmf-cv was what I used & it worked ok
[21:48:11] <dwisehaupt>	 ok. just a sec.
[21:51:30] <dwisehaupt>	 alright, so right now it calls: sudo -u www-data /srv/cv/bin/cv --cwd=/srv/org.wikimedia.civicrm/drupal/ "$@"
[21:52:18] <dwisehaupt>	 and we just want to add the --user=root to that, and not apiv4, correct?
[21:52:59] <dwisehaupt>	 if we add apiv4 it will force that as an argument all the time.
[22:23:58] <eileen>	 dwisehaupt: yeah - just the user
[22:49:16] <dwisehaupt>	 eileen: ok. done and pushed out. you should be clear to test
[23:22:10] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10414423 (10Eileenmcnaughton) @bsisolak I have downloaded data using https://developer.goacoustic.com/acoustic-campaign/reference/webtrackingdataexport w...
[23:22:36] <eileen>	 thanks dwisehaupt 
[23:54:20] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10414533 (10bsisolak) The ways a user can unsubscribe are (1) by clicking the linking and opting out on the page, (2) hitting Spam in Yahoo/Comcast (whic...