[06:40:17] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1122750 (owner: 10L10n-bot) [08:21:02] 06Fundraising-Backlog, 05FY2024-25 WE3.2 Donation Entry Points: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587#10581707 (10ovasileva) 05Open→03Resolved Resolving, thanks all! [09:12:53] 03Fundraising Sprint: Dodos, 06Fundraising-Backlog: Year 2 Upgrading active recurring - landing page enhancement, QA confirmation email, TY pages - https://phabricator.wikimedia.org/T386693#10581828 (10MSuijkerbuijk_WMF) Hi @ejegg Sharing that we would need this landing page link updated to share with the [[ h... [11:24:27] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy PayPal recurring charge failures (INVALID_PARAMETER_SYNTAX) - https://phabricator.wikimedia.org/T387289 (10jgleeson) 03NEW [12:20:08] (03CR) 10Damilare Adedoyin: "Thanks for the CR jgleeson, I pushed this patch to add the suggested refactor:" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119554 (owner: 10Damilare Adedoyin) [13:27:40] damilare: if you wanna make that casting update a separate patch it would be better to remove the strval() from the initial patch or rebase it over your new patch so the git log never has a commit with just the str casting, which might causes errors. I noticed you didn't hit the int expected failure but I do remember seeing that so I'll see if I can dig it out in my local logs [13:28:19] what's the error message it returns when you dont cast it to string? [13:28:30] I can search for that locally to find the int example [13:28:39] yh jgleeson I was thinking it's better to rebase after that patch is merged incase any additional patch is needed to avoid further rebases on the bcp patch [13:28:54] ok let me find one [13:29:11] the problem with that approach is we'd merge something first with a potentially breaking change [13:29:44] {"type":"error","code":"bad_request","status":400,"message":"Request failed validation","details":[{"location":"body","message":"str type expected","pointer":"\/buyer\/billing_details\/tax_id\/value","type":"type_error.str"}]} [13:30:13] lemme see if I can find it [13:31:26] np I'd rebase over it [13:33:00] actually does that mean the ones you aren't casting to a string (the ones where numeric is true) are failing? [13:33:53] (03PS11) 10Damilare Adedoyin: Add BCP Bank Transfer in Gravy Dlocal for Peru. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119554 [13:34:55] yea if you change it to true, it fails [13:35:04] they're all false right now [13:36:42] I think the one I ran into the errors on was an id with a period '.' separator [13:36:51] e.g. 123456.123 [13:37:37] also that means we have another issue if they are all set to numeric=> false which is they don't reflect the actual type [13:37:57] I think there are some numeric=>true in the old transformer [13:38:00] I'll check now [13:38:12] albeit gravy is not respecting them [13:38:28] I guess from an accuracy pov we might need to think about that [13:39:51] we don't need to change anything as I guess they are going to gravy but it does raise the question about whether we should document the apparent discrepancy [13:40:52] ok so originally the IDs we were sending over for Argentina, Brazil and Colombia are numeric only [13:40:56] which old transformer is tha? [13:40:59] that* [13:41:13] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/d49e69c2c0abae489717968afdb1e6921917c147/gateway_common/FiscalNumber.php#L16 [13:42:11] so we're sending them over as numeric on the frontend and then mapping them all to strings and flagging numeric=> false on the backend [13:42:29] which might not be ideal from a readability & consistency standpoint [13:42:58] maybe we should rename that flag to gravy_needs_them_as_string lol [13:43:15] hmm I don't see that same error for the int failure I hit [13:43:21] but since the frontend conversion is from a shared library between two processors with differen asks [13:43:22] lemme see if I can trigger that [13:44:14] damilare: I think it got moved specifically for gravy [13:44:19] so it was always just dlocal [13:44:32] I vaguely remember doing that [13:45:10] what do you mean different asks? [13:45:27] yea I remember too, but we don't have to change it in my opinion. We can just specify the cast at the point of api call [13:46:07] but that country identifiers component shouldn't care about the gravy API format [13:46:08] Gravy is asking for the fiscal_numbers as a string, so we validate using the rules on the frontend and give them what they want. [13:46:28] oh I see [13:46:53] I can confirm from gravy if they want all the tax ids to be sent as a string [13:46:59] this evening [13:47:30] I'm just looking at the docs now to see if I can remember how i hit the int required error [13:47:31] so we probably wouldn't need the numeric key in the country identifier [13:51:22] the api specifies the value as a string property [13:51:30] ok I just confirmed, and sorry, but it looks like I must have been getting up [13:51:38] yes I just read that now https://docs.gr4vy.com/reference/transactions/new-transaction#response-buyer-billing-details-tax-id-value [13:51:47] getting mixed* up [13:52:01] it must have been another field. [13:52:33] I should have checked the API docs yesterday [13:53:01] no worries, I'd just pull out that patch and rebase on master [13:53:02] I definitely hit the int error and I could have sworn it over for the tax_id when I was writing the country identifier stuff hmm [13:53:22] gravy might have done a sneak stuff also [13:53:50] (03PS12) 10Damilare Adedoyin: Add BCP Bank Transfer in Gravy Dlocal for Peru. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119554 [13:54:05] I wonder if I've hit it on the front [13:54:20] due to the actual numeric=>true cases [13:54:38] I'd add the strval casting back, so it's consistently all strings [13:55:43] (03CR) 10Jgleeson: [C:03+2] "Sorry about the mix up on field casting. this LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119554 (owner: 10Damilare Adedoyin) [13:55:51] thanks damilare [13:55:55] (03PS13) 10Damilare Adedoyin: Add BCP Bank Transfer in Gravy Dlocal for Peru. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119554 [13:56:34] sorry jgleeson the initial rebase took out the strval, last patchset adds it back [13:57:15] I'll re+2 it [13:57:23] (03CR) 10Jgleeson: [C:03+2] Add BCP Bank Transfer in Gravy Dlocal for Peru. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119554 (owner: 10Damilare Adedoyin) [13:57:31] thank you! [13:57:48] np. hmm I now want to find what the int failure was its bugging me [13:57:55] (03Merged) 10jenkins-bot: Add BCP Bank Transfer in Gravy Dlocal for Peru. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119554 (owner: 10Damilare Adedoyin) [13:58:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy PayPal recurring charge failures (INVALID_PARAMETER_SYNTAX) - https://phabricator.wikimedia.org/T387289#10582952 (10MBeat33) Thanks for the follow up and for making this Task, @jgleeson. Credit where due, I was escalating what @AMJohnson discovered. [13:59:31] also, that teaches me that I should do better when reviewing code and actually confirm something does break with new code at the point of reviewing it and not just recall an old memory, which is this case appears to be inaccurate [14:06:46] yeah I don't see any int failures in the logs relating to the tax_id.value locally [14:07:35] I see this one [14:07:35] logs/payments-syslog:2025-01-30T18:53:23+00:00 ce2512e7d868 gravy_gateway: 258:258.18 Unsuccessful createPayment response from gateway: failed : {"type":"error","code":"bad_request","status":400,"message":"Request failed validation","details":[{"location":"body","message":"extra fields not permitted","pointer":"\/buyer\/tax_id","type":"value_error.extra"}]} [14:09:13] "only give what we asked" [14:09:44] it doesn't even say what the extra fields were [14:11:24] im not sure if that was the int one I was thinking about tho [14:11:33] I seem to remember seeing the word "int" [14:14:58] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Incorrect amount formatting on paymentswiki with uselang=es-419 - https://phabricator.wikimedia.org/T387137#10583011 (10Damilare) a:03Damilare [14:41:18] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Backfill recurring payments missing Gravy backend processor info. - https://phabricator.wikimedia.org/T385115#10583200 (10jgleeson) So it looks like 3632 recurring charges were affected by this bug. I confirmed this using the following query: ` MariaDB... [14:43:25] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Backfill recurring payments missing Gravy backend processor info. - https://phabricator.wikimedia.org/T385115#10583204 (10jgleeson) The same query inverted shows 7297 records containing values for those fields, which suggests the previous query yields a v... [14:43:59] argh. I was hoping that count would be much lower so I could manually update them [14:44:42] 3k+ means we are gonna have to write something that is committed meaning we'll need to pull in that new library for a one-off process :| [15:00:42] 10fundraising-tech-ops: Fundraising access request for Chris Lauron - https://phabricator.wikimedia.org/T387353 (10IAckerman-WMF) 03NEW [16:22:40] (03PS1) 10Damilare Adedoyin: Fix amount formatting for locales with hyphens [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1122984 (https://phabricator.wikimedia.org/T387137) [19:02:29] 10fundraising-tech-ops: Fundraising access request for cvlauron - https://phabricator.wikimedia.org/T387353#10584486 (10Dwisehaupt) [19:03:39] 10fundraising-tech-ops: Fundraising access request for cvlauron - https://phabricator.wikimedia.org/T387353#10584491 (10Dwisehaupt) Access request approved. ` Date: Fri, 14 Feb 2025 09:10:29 From: Lisa Seitz Gruwell To: Ilse Ackerman Cc: Dallas Wisehaupt Subject: Re: Superset access for Chris Lauron -----------... [19:25:29] 06Fundraising-Backlog: Direct Mail Activity Import - February 2025 List - https://phabricator.wikimedia.org/T387247#10584532 (10MDemosWMF) @Eileenmcnaughton has completed this task, it can be closed out [20:22:32] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Pending transaction resolver resolving multiple donations per donor per run - https://phabricator.wikimedia.org/T353089#10584697 (10Cstone) This is old I don't remember enough to add more helpful context, we can mak... [20:25:55] 10fundraising-tech-ops: Fundraising access request for cvlauron - https://phabricator.wikimedia.org/T387353#10584704 (10Dwisehaupt) [20:28:14] 10fundraising-tech-ops: Fundraising access request for cvlauron - https://phabricator.wikimedia.org/T387353#10584707 (10Dwisehaupt) [20:29:50] 10fundraising-tech-ops: Fundraising access request for cvlauron - https://phabricator.wikimedia.org/T387353#10584709 (10Dwisehaupt) a:03Dwisehaupt SSL cert created and sent via email. Password sent via SMS. Superset account created and set with random password. Password sent via SMS. Instructions sent on how t... [20:42:41] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Something is causing JPY Refunds that are separate line items in civi - https://phabricator.wikimedia.org/T360974#10584727 (10Cstone) Let's close this, I can't find an example of this issue right now and past me did... [20:52:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Something is causing a lot of paypal (auto) User Cancelled via Gateway cancellations of already cancelled recurrings - https://phabricator.wikimedia.org/T373355#10584744 (10Cstone) [20:56:25] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 07Documentation: Complete Adyen Checkout documentation to include donation statuses for all stages/permutations - https://phabricator.wikimedia.org/T316583#10584753 (10Damilare) 05Open→03Declined [21:55:36] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07PHP 8.1 support: Merge master into wmf_deploy - https://phabricator.wikimedia.org/T387395 (10Reedy) 03NEW [21:55:41] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07PHP 8.1 support: Merge master into wmf_deploy - https://phabricator.wikimedia.org/T387395#10584893 (10Reedy) p:05Triage→03High [21:56:55] (03Abandoned) 10Reedy: Track bundlesizes for modules loaded on page load [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1116806 (https://phabricator.wikimedia.org/T373017) (owner: 10Reedy) [21:56:57] (03Abandoned) 10Reedy: SpecialCentralNoticeBanner: Null-coalescence $par [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1116232 (https://phabricator.wikimedia.org/T385335) (owner: 10Reedy) [21:56:59] (03Abandoned) 10Reedy: CNCampaignPager: Protect against some more null columns [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1116231 (https://phabricator.wikimedia.org/T385061) (owner: 10Reedy) [21:57:03] (03Abandoned) 10Reedy: Fix Phan error related to message parameters [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1116807 (owner: 10Reedy) [23:46:39] (03PS14) 10Cstone: WIP: Update gravy paypal to get donor info [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1119595 (https://phabricator.wikimedia.org/T385738) [23:49:31] (03CR) 10CI reject: [V:04-1] WIP: Update gravy paypal to get donor info [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1119595 (https://phabricator.wikimedia.org/T385738) (owner: 10Cstone) [23:54:52] 06Fundraising-Backlog: How will we expose payment processor errors/issues with gravy - https://phabricator.wikimedia.org/T387411 (10Cstone) 03NEW