[01:44:18] (03PS4) 10Eileen: Swap out apiv3 to apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187105 [01:44:20] (03CR) 10Ejegg: [C:03+2] Swap out apiv3 to apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187105 (owner: 10Eileen) [01:50:19] (03PS1) 10Eileen: Make moving completed optional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189378 [01:50:19] (03PS1) 10Eileen: Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379 [01:57:23] (03CR) 10Ejegg: [C:03+2] build: Handle excluded CommentBeforeClass sniff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189272 (owner: 10Umherirrender) [01:59:53] (03Merged) 10jenkins-bot: build: Handle excluded CommentBeforeClass sniff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189272 (owner: 10Umherirrender) [02:00:13] (03CR) 10Ejegg: "With this change you can shrink the next if condition since we know both are truthy" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189300 (owner: 10Eileen) [02:01:07] (03CR) 10Eileen: Build on auth fix (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189300 (owner: 10Eileen) [02:01:16] (03Merged) 10jenkins-bot: Swap out apiv3 to apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187105 (owner: 10Eileen) [02:03:00] eileen is it possible that the authenticatorTarget has either userId or contactId falsy ? [02:04:03] They are cast to a string for the comparison... I think we can hack it for now & maybe tomorrow I can check with Tim/ Ben [02:06:25] looks like AuthenticatorTarget::setPrincipal allows just one or the other [02:06:38] https://phabricator.wikimedia.org/diffusion/WFCG/browse/master/core/ext/authx/Civi/Authx/Authenticator.php$464 [02:06:53] oh i see, but then it looks up the missing onefrom UFMatch [02:08:23] ok, back to looking at the settlement fields for now [02:11:22] (03CR) 10CI reject: [V:04-1] Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379 (owner: 10Eileen) [02:13:02] eileen: so the getSettlementFields class on the message doesn't populate any of the fields if there's no settled date? [02:13:38] ejegg: no - it's still a bit WIP - but the current thinking is no settlement without a date [02:13:44] k [02:14:38] ok, and we have different settlement fields for settled amount and settled reversal amount [02:14:53] in case the refund doesn't match the original amount [02:15:41] so should there also be a settled_reversal_date? [02:18:14] (03CR) 10Ejegg: [C:03+2] "Looks pretty solid! Couple of questions inline" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187106 (owner: 10Eileen) [02:18:28] (03PS6) 10Eileen: Start to populate settlement fields on refund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187106 [02:18:37] (03CR) 10Ejegg: [C:03+2] Start to populate settlement fields on refund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187106 (owner: 10Eileen) [02:19:05] (03PS6) 10Eileen: Remove obsolete comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187119 [02:19:08] (03CR) 10Ejegg: [C:03+2] Remove obsolete comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187119 (owner: 10Eileen) [02:19:54] ejegg: we can possibly wrap up this one too? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1179992 [02:30:48] right, that way looks safe enough [02:32:27] (03PS12) 10Eileen: Add order_id to fields normalized in the AuditMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1179992 [02:32:34] (03CR) 10Ejegg: [C:03+2] Add order_id to fields normalized in the AuditMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1179992 (owner: 10Eileen) [02:35:19] (03Merged) 10jenkins-bot: Start to populate settlement fields on refund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187106 (owner: 10Eileen) [02:35:31] (03Merged) 10jenkins-bot: Remove obsolete comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187119 (owner: 10Eileen) [02:37:06] k, i can see where in coworker it's calling login with the runAs params [02:37:22] but i'm still a little foggy as to what the existing code is doing wrong [02:37:29] lemme read that upstream pull request again [02:40:00] eileen: ah so coworker was hitting the same bug as https://lab.civicrm.org/dev/core/-/issues/4463, i guess when running the second task? [02:40:48] ejegg: well I'm not sure - I feel like it was failing to go from no user to having a user [02:40:49] oh huh, those are a bit old [02:48:01] shoot, I can't quite understand that enough to merge changes to auth logic right now [02:48:25] but that does leave the opt-in backfill un-deployable, huh? [02:48:50] eileen: did you need to deploy other stuff tonight/today? [02:49:26] (03Merged) 10jenkins-bot: Add order_id to fields normalized in the AuditMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1179992 (owner: 10Eileen) [02:49:33] ejegg: I think that auth logic is just loosening the login in a possibly hacky way - so might not be blocking... [02:51:25] but ejegg I'm around tomorrow so can leave overnight [02:52:26] cool cool, i need to get some sleep [02:52:34] cya later! [03:39:35] (03PS1) 10Eileen: Update Audit message due to fundraise_up, ingenico removal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189382 [03:40:06] if someone can +2 ^^ (or I will self-do-it)- the order one turns out to have references to since-removed fundraise up, ingenico [04:20:21] (03CR) 10Eileen: [C:03+2] "self-merging to avoid fall out from functions removed after the initial patch was put up" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189382 (owner: 10Eileen) [04:37:43] (03Merged) 10jenkins-bot: Update Audit message due to fundraise_up, ingenico removal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189382 (owner: 10Eileen) [05:02:48] (03PS2) 10Eileen: Make moving completed optional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189378 [05:02:48] (03PS2) 10Eileen: Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379 [05:18:15] (03PS6) 10Eileen: Minor tidy ups - move currency handling to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187120 [05:24:21] (03CR) 10CI reject: [V:04-1] Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379 (owner: 10Eileen) [05:29:43] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic requests / questions - https://phabricator.wikimedia.org/T378974#11192460 (10MSuijkerbuijk_WMF) Sounds good [05:33:50] (03PS3) 10Eileen: Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379 [08:48:07] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] build: Remove unused suppression of LowerCamelFunctionsName [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1189343 (owner: 10Umherirrender) [08:59:53] (03CR) 10Thiemo Kreuz (WMDE): [C:04-1] build: Handle excluded ClassAnnotations and CommentBeforeClass sniff (032 comments) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1189271 (owner: 10Umherirrender) [09:50:35] (03Merged) 10jenkins-bot: build: Remove unused suppression of LowerCamelFunctionsName [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1189343 (owner: 10Umherirrender) [12:11:27] (03PS12) 10Damilare Adedoyin: Donor Portal main page with CSS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) [14:15:38] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic requests / questions - https://phabricator.wikimedia.org/T378974#11193834 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF [14:38:03] (03PS1) 10Damilare Adedoyin: Add Styles for recurring pause page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189508 [14:53:16] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add contribution search Searchkit/Formbuilder for DR - https://phabricator.wikimedia.org/T404987 (10Lars) 03NEW [14:57:15] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add contribution search Searchkit/Formbuilder for DR - https://phabricator.wikimedia.org/T404987#11194101 (10Lars) [14:58:29] (03CR) 10Ejegg: [C:04-1] "Exciting to see this looking so good! Just a few i18n nitpicks and one image filename to fix the casing." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) (owner: 10Damilare Adedoyin) [15:00:28] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add global Do not contact button to contact summary - https://phabricator.wikimedia.org/T404989 (10Lars) 03NEW [15:32:01] (03PS13) 10Damilare Adedoyin: Donor Portal main page with CSS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) [15:37:53] (03CR) 10Damilare Adedoyin: "Thanks ejegg for all the review, I've made updates on your suggestions." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) (owner: 10Damilare Adedoyin) [15:43:26] (03CR) 10Ejegg: "One teeny typo in qqq.json, and the file case change didn't seem to take. Guessing it's a Mac filesystem thing?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) (owner: 10Damilare Adedoyin) [15:43:28] (03CR) 10Ejegg: [C:03+2] Donor Portal main page with CSS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) (owner: 10Damilare Adedoyin) [15:43:45] (03CR) 10Ejegg: "Oops, didn't mean to C+2 just yet" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) (owner: 10Damilare Adedoyin) [15:44:00] damilare: oh I can just fix those in the UI [15:44:18] ohh I'd push that up soon [15:44:47] hmm not sure why the image didn't get updated [15:45:13] (03PS14) 10Ejegg: Donor Portal main page with CSS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) (owner: 10Damilare Adedoyin) [15:45:23] (03CR) 10Ejegg: [C:03+2] Donor Portal main page with CSS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) (owner: 10Damilare Adedoyin) [15:45:48] damilare: I think MacOS is still kind of case-insensitive for filenames, right? [15:46:23] TIL actually, never took notice of that [15:46:49] yeah, not frequently an issue but when it is, it's really annoying! [15:48:12] (03Merged) 10jenkins-bot: Donor Portal main page with CSS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1184896 (https://phabricator.wikimedia.org/T402224) (owner: 10Damilare Adedoyin) [15:48:44] interesting, thanks for bringing this to my attention [15:59:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations, 07Transaction-missing-in-CiviCRM: recent Gravy / PayPal donations missing PII in Civi - https://phabricator.wikimedia.org/T402841#11194377 (10MBeat33) | CID | Gravy trxn | date | 9973589 | bffb44ad-cfa3-47fa-b75f-112e353b80c6 | S... [16:53:23] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Exempt imports from Coworker pause due to high donation traffic - https://phabricator.wikimedia.org/T405006 (10Lars) 03NEW [17:24:27] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 07FR-Audience-Dev, 07fr-current-sprint, 13Patch-For-Review: Pre-renewal notice to Active Annual recurring donors - https://phabricator.wikimedia.org/T393432#11194808 (10Lars) [17:25:10] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Add two tag options to preferences_tags CIvi > Acoustic import - https://phabricator.wikimedia.org/T390216#11194810 (10Lars) [17:26:34] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 07FR-Audience-Dev: Change URL in WMF Recurring Failure template - https://phabricator.wikimedia.org/T354185#11194816 (10Lars) @MSuijkerbuijk_WMF It looks like this task has been resolved, just checking if we can close this up? [17:26:48] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 10fundraising-tech-ops, 07fr-current-sprint: FR-Tech FY2526Q1 maintenance window - https://phabricator.wikimedia.org/T364182#11194818 (10Jgreen) [17:27:05] 06Fundraising-Backlog, 07FR-Audience-Dev: [low priority] Investigate conditional Google's script addition for Google Ads Grant (fundraising) - https://phabricator.wikimedia.org/T374079#11194824 (10Lars) [17:28:49] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 10fundraising-tech-ops, 07fr-current-sprint: FR-Tech FY2526Q1 maintenance window - https://phabricator.wikimedia.org/T364182#11194831 (10Jgreen) [17:28:59] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 10fundraising-tech-ops, 07fr-current-sprint: FR-Tech FY2526Q1 maintenance window - https://phabricator.wikimedia.org/T364182#11194832 (10Jgreen) [17:41:03] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 10fundraising-tech-ops, 07fr-current-sprint: FR-Tech FY2526Q1 maintenance window - https://phabricator.wikimedia.org/T364182#11194928 (10Jgreen) [17:41:07] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Is RPOW helping us at all under standalone? - https://phabricator.wikimedia.org/T403849#11194929 (10AKanji-WMF) [17:43:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Recurring options on donation form are sticking? - https://phabricator.wikimedia.org/T403206#11194938 (10AKanji-WMF) p:05Low→03Medium In talking to Sandra - escalating this to Medium [17:48:12] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New batch data entry update: Vague error description - https://phabricator.wikimedia.org/T404644#11194991 (10Lars) [[ https://lab.civicrm.org/dev/core/-/issues/6099 | Upstream issue ]] [17:58:09] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Batch data entry - import not submitting (allow blank time for contribution date) - https://phabricator.wikimedia.org/T404646#11195094 (10Lars) [[ https://lab.civicrm.org/dev/core/-/issues/6100 | Upstream issue ]] [18:02:23] fr-tech, I'm going to deploy the DonorPortal main page css that was merged today [18:04:26] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189541 [18:05:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Annual Recurring Statuses implementation in Civi (Audience Framework update) - https://phabricator.wikimedia.org/T377438#11195143 (10Lars) [18:05:59] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189541 (owner: 10Damilare Adedoyin) [18:06:27] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 10fundraising-tech-ops, 07fr-current-sprint: FR-Tech FY2526Q1 maintenance window - https://phabricator.wikimedia.org/T364182#11195150 (10Lars) [18:08:53] (03PS2) 10Umherirrender: build: Handle excluded ClassAnnotations and CommentBeforeClass sniff [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1189271 [18:08:56] (03CR) 10Umherirrender: build: Handle excluded ClassAnnotations and CommentBeforeClass sniff (032 comments) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1189271 (owner: 10Umherirrender) [18:11:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Check AVS declines - https://phabricator.wikimedia.org/T404769#11195182 (10Cstone) [18:21:19] (03PS1) 10Ejegg: Allow wmf_token on recurring convert API call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189546 [18:21:37] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189541 (owner: 10Damilare Adedoyin) [18:21:59] ACKNOWLEDGEMENT - check_mysql on payments2004 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) Dwisehaupt known from origin server reboot https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments2004&service=check_mysql [18:22:14] (03PS3) 10Ejegg: Add new annual post recurring popup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1188848 (https://phabricator.wikimedia.org/T403078) (owner: 10Wfan) [18:22:14] (03PS2) 10Ejegg: Allow wmf_token on recurring convert API call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189546 [18:22:20] (03CR) 10CI reject: [V:04-1] Allow wmf_token on recurring convert API call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189546 (owner: 10Ejegg) [18:22:42] (03CR) 10Ejegg: [C:03+2] Add new annual post recurring popup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1188848 (https://phabricator.wikimedia.org/T403078) (owner: 10Wfan) [18:23:21] Thanks ejegg! [18:24:00] !log donorwiki upgraded from 10d200b1 to df2482ce [18:24:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:26:32] (03Merged) 10jenkins-bot: Add new annual post recurring popup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1188848 (https://phabricator.wikimedia.org/T403078) (owner: 10Wfan) [18:26:33] wfan: TY for implementing that! I had to add an allowed API parameter to avoid some scattered errors, though it seems like that should affect ALL monthly converts: https://gerrit.wikimedia.org/r/1189546 [18:32:11] Gotcha checking [18:32:30] (03CR) 10Wfan: [C:03+2] Allow wmf_token on recurring convert API call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189546 (owner: 10Ejegg) [18:34:56] thanks wfan [18:36:30] fr-tech can someone else help me test the opt-in backfill? [18:36:44] I'll still not seeing the issue that eileen sees locally [18:36:58] and i'm curious whether we really need those auth changes [18:40:02] so you'll just need to create a file like this: [18:40:47] scripts/civicrm.sh [18:42:40] echo jwales@example.com,1758220927,1 > /tmp/optins_to_backfill.csv [18:42:49] then run the ext upgrades [18:42:59] cv ext:upgrade-db [18:43:15] it should add something to the civicrm_queue_item table [18:43:21] then run coworker run [18:43:25] and check the jwales contact [18:43:28] (03Merged) 10jenkins-bot: Allow wmf_token on recurring convert API call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189546 (owner: 10Ejegg) [18:45:59] ok, I'll deploy donation interface [18:47:44] Ok donor portal styled main page has now been deployed and looks good. [18:50:17] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189553 [18:50:21] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189553 (owner: 10Ejegg) [18:53:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Payment Submethods by Country sections on Special:PaymentSettings are broken - https://phabricator.wikimedia.org/T404377#11195362 (10AKanji-WMF) p:05Triage→03Medium [18:59:48] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189553 (owner: 10Ejegg) [19:05:30] (03PS1) 10Cstone: Add insufficient_funds and incorrect_cvv to ignore list [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189555 [19:06:19] (03CR) 10Jgleeson: [C:03+2] Add insufficient_funds and incorrect_cvv to ignore list [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189555 (owner: 10Cstone) [19:06:54] (03Merged) 10jenkins-bot: Add insufficient_funds and incorrect_cvv to ignore list [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189555 (owner: 10Cstone) [19:12:29] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Add batch size param to Gravy Pending Transaction job - https://phabricator.wikimedia.org/T404861#11195429 (10AKanji-WMF) [19:13:20] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 07fr-current-sprint, 10MW-1.45-notes (1.45.0-wmf.20; 2025-09-23): 2025 Update - Post Payment Annual Recurring - https://phabricator.wikimedia.org/T403078#11195431 (10Ejegg) OK, this is set up! To test, please make a donation with variant=monthlyConver... [19:17:41] !log payments-wiki upgraded from 1b7a47a6 to a31d7db6 [19:17:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:18:21] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 07fr-current-sprint, 10MW-1.45-notes (1.45.0-wmf.20; 2025-09-23): 2025 Update - Post Payment Annual Recurring - https://phabricator.wikimedia.org/T403078#11195445 (10KMorrow-WMF) Thanks @Ejegg! We're sort of blocked on getting test donations for any p... [19:24:06] 06Fundraising-Backlog, 07Epic: Epic: Support retrieval of page and banner view data for FR Analytics - https://phabricator.wikimedia.org/T369773#11195472 (10AKanji-WMF) [19:24:53] 06Fundraising-Backlog, 07Epic, 07fr-current-sprint: Setting up consolidated settlement reporting for all PSPs via Gr4vy for new recon process - https://phabricator.wikimedia.org/T391496#11195473 (10AKanji-WMF) [19:24:54] 06Fundraising-Backlog, 07Epic, 07fr-current-sprint: Gravy Dlocal - https://phabricator.wikimedia.org/T384967#11195474 (10AKanji-WMF) [19:24:56] 06Fundraising-Backlog, 10FR-Batch-Data-Entry, 07Epic: Epic - Batch Import tool in Civi - https://phabricator.wikimedia.org/T375126#11195475 (10AKanji-WMF) [19:25:34] hmm fr-tech do we not have a getAmountInMajorUnits or like a reverse of getAmountInMinorUnits or my searching has failed me [19:26:33] cstone there is something like that! [19:26:42] in the front end there was a staging helper [19:26:57] but now we do a lot of that mapping in SmashPig, let's see where [19:28:12] yeah i just looked through smashpig but could be searching fail [19:28:12] CurrencyRoundingHelper::getAmountInMinorUnits [19:28:18] yeah i want the oppoisite [19:28:27] hah yeah not finding it [19:28:35] okie [19:29:43] oh man, adyenMessage::constructFromJSON is just dividing by 100 for all currencies [19:29:47] pretty sure that's wrong [19:30:28] gravy responseMapper too [19:30:35] have we used gravy for japan yet? [19:31:12] so do you want to create that function and check for all the instances of "/ 100" in the smashpig code? [19:32:28] yeah working on making it [19:32:34] thanks! [19:32:47] i know once dami and I were debugging something and found some currency weirdness but since it was working properly we didnt want to touch it hah [19:33:42] but maybe that was in the ipn code [19:33:56] we have gravy JPY ejegg and it looks right [19:34:00] looks like that adyen IPN message needs it [19:34:16] cstone: hmm, I wonder if it's right just from us to gravy [19:34:24] but wrong e.g. in audit files? [19:34:36] hmm lets see in the audit [19:34:48] the audit code just divides by 100 [19:34:58] ahh [19:35:04] so if the file doesn't do that, we're doing something silly [19:35:18] looking in the file [19:35:21] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic, 07FR-Audience-Dev: Add most recent direct mail appeal to Acoustic - https://phabricator.wikimedia.org/T405033 (10Lars) 03NEW [19:35:47] now my irc alerts work [19:36:08] 321,JPY [19:36:11] yeah, looks like not multiplied [19:36:15] 335, 1040 [19:36:45] i look forward to your new fn fixing that! [19:39:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Enable post-payment monthly convert for Apple/Google/ACH on Gr4vy - https://phabricator.wikimedia.org/T404380#11195512 (10AKanji-WMF) p:05Triage→03High [19:41:55] (03PS1) 10Ejegg: Show convert for more methods in Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189563 (https://phabricator.wikimedia.org/T404380) [19:42:33] fr-tech anyone want to do a quick review on ^^^ ? [19:42:59] Just adding some more values to gravy's getPaymentMethodsSupportingRecurringConversion [19:43:46] (03CR) 10CI reject: [V:04-1] Show convert for more methods in Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189563 (https://phabricator.wikimedia.org/T404380) (owner: 10Ejegg) [19:43:52] Hmm? [19:44:19] oh lol, class name conflict [19:47:39] (03PS2) 10Ejegg: Show convert for more methods in Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189563 (https://phabricator.wikimedia.org/T404380) [19:48:21] ok, let's get rid of those duplicate constants [19:55:14] ejegg: we've got a PaymentMethods enum in the gravy code somewhere [19:55:38] PHP's new answer to those class constants we've had to use previously [19:56:04] 06Fundraising-Backlog: New batch data entry update: Soft credit amount auto-populate - https://phabricator.wikimedia.org/T404640#11195547 (10MDemosWMF) @Lars Yes, thank you for checking! We will leave the field blank moving forward. cc @BJordan-WMF [19:57:07] (03PS3) 10Ejegg: Show convert for more methods in Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189563 (https://phabricator.wikimedia.org/T404380) [19:57:07] (03PS1) 10Ejegg: Remove duplicate PaymentMethod constants [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189565 [19:58:12] jgleeson: ah, there's another gravy-specific one? [19:58:23] ok, let's point that code at the common one too... [19:58:56] anyway, that 'Show convert for more methods in Gravy' is working now [19:59:00] ejegg: how about we try and stick with the enum for type safety? [19:59:25] jgleeson: it's still using the enum, just the SmashPig enum [19:59:31] (03CR) 10CI reject: [V:04-1] Remove duplicate PaymentMethod constants [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189565 (owner: 10Ejegg) [19:59:45] SmashPig\PaymentData\PaymentMethod [20:00:05] that one's not an enum [20:00:09] it's a constant class [20:00:28] oh, but so was the one I switched away from, right? [20:00:43] the one in the gravy folder holds the gravy-specific ones [20:00:49] I'll link to it [20:01:21] https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/d9330a7781efbc3f9f74b0313fa2b12cefb825ce/PaymentProviders/Gravy/PaymentMethod.php#L5 [20:01:43] ah i see [20:02:34] OK, I'll update the SmashPig common one to be an enum [20:02:42] let's see if we can make the gravy one inherit from that [20:04:13] enum I don't think enums support inheritance [20:04:19] but yeah that would have been nice [20:04:34] maybe park if it's not straightforward and gonna waste your time [20:05:54] ejegg: * not enum ha [20:06:52] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1189567 [20:08:21] (03PS1) 10Jgleeson: Update SmashPig to v0.9.9.9 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189569 [20:08:33] jgleeson: ah hmm, the gravy one also mixes method and submethod [20:09:31] so I can change it to an enum with the same const names easily enough [20:09:51] does it make sense to break out PaymntSubmethods too? [20:10:04] that could be a long list [20:11:47] (03PS1) 10Ejegg: Convert PaymentMethod to an enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189570 [20:12:11] (03CR) 10CI reject: [V:04-1] Convert PaymentMethod to an enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189570 (owner: 10Ejegg) [20:12:16] yeah, submethods should be in their own field [20:12:29] I mean own enum [20:13:28] ahhh dang, ok, enums don't automatically convert to string, right [20:14:19] so I think the idea with them ejegg is so that we always send in an object [20:14:41] because that then allows us to set a type hint which ensures it's a known method [20:15:04] the issue with the current constant classes is that they can be bypassed by passing in strings e.g. 'card' [20:15:18] whereas enums force us to be more consistent [20:15:21] Hmm, yeah, I can see the advantage there [20:15:32] been a while since I worked in Java or C# :) [20:15:55] just makes it a much bigger change than I think I want to try to make right now [20:16:03] so... [20:16:05] (03Abandoned) 10Ejegg: Convert PaymentMethod to an enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189570 (owner: 10Ejegg) [20:16:06] yeah I though that. sorry [20:16:10] :) [20:16:12] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Exempt imports from Coworker pause due to high donation traffic - https://phabricator.wikimedia.org/T405006#11195596 (10MDemosWMF) @Lars @Eileenmcnaughton During our busiest times December - January we can get up to around 1K transactions in an import fi... [20:16:13] no worries [20:16:15] maybe we should ticket that up [20:17:35] jgleeson: anyway, for the immediate future, they really want to try Gravy recurring convert with non-cc method, and I think this is all the code change we need: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1189563?usp=dashboard [20:20:24] looking ejegg [20:23:27] I'm in the middle of a deploy so do you want this to go out now or afterwards ejegg [20:23:33] I can merge it to DI [20:23:41] and end it out with the smashpig bump [20:25:12] (03CR) 10Jgleeson: [C:03+2] Update SmashPig to v0.9.9.9 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189569 (owner: 10Jgleeson) [20:25:36] (03CR) 10Jgleeson: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1189567 (owner: 10Jgleeson) [20:25:57] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1189567 (owner: 10Jgleeson) [20:27:02] (03CR) 10Jgleeson: [C:03+2] Show convert for more methods in Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189563 (https://phabricator.wikimedia.org/T404380) (owner: 10Ejegg) [20:28:54] ok nvm there's a patch infront of it failing on CI [20:29:17] (03Merged) 10jenkins-bot: Show convert for more methods in Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189563 (https://phabricator.wikimedia.org/T404380) (owner: 10Ejegg) [20:29:35] 06Fundraising-Backlog: New batch data entry update: Soft credit amount auto-populate - https://phabricator.wikimedia.org/T404640#11195675 (10Lars) 05Open→03Resolved a:03Lars [20:29:44] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189572 [20:31:19] (03CR) 10Jgleeson: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189572 (owner: 10Jgleeson) [20:32:29] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189572 (owner: 10Jgleeson) [20:33:46] (03PS1) 10Jgleeson: Update composer.lock for SmashPig 0.9.9.9 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1189573 [20:38:15] thanks jgleeson ! [20:38:23] np [20:38:24] 3 nines! [20:38:31] @_@ [20:39:37] should we just be managing that error tracker config in deployed config while it's still in flux? [20:40:14] seems like a lot of overhead to tag etc for each new string in the list [20:45:13] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New batch data entry update: Tabbing after selecting gift date/postmark date - https://phabricator.wikimedia.org/T404642#11195722 (10Lars) @MDemosWMF and @BJordan-WMF: A couple workarounds for you in the meantime that might make this more bearable (if you... [20:46:29] (03CR) 10Jgleeson: [C:03+2] Update composer.lock for SmashPig 0.9.9.9 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1189573 (owner: 10Jgleeson) [20:55:49] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Queue Runner page prevents use of main menu - https://phabricator.wikimedia.org/T405042 (10Lars) 03NEW [20:56:43] (03PS1) 10Ejegg: Explicitly log out of Silverpop after API calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189578 [20:57:02] fr-tech we don't have a ticket for those omnimail failmails, do we? [20:57:16] I think that ticket may be worth trying ^^^ [20:58:16] ejegg: yeah ejegg I've been meaning to do add that to config this week to avoid the need for code changes. [20:58:24] (03Merged) 10jenkins-bot: Update composer.lock for SmashPig 0.9.9.9 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1189573 (owner: 10Jgleeson) [21:00:41] eileen: did you say you were around today? [21:01:08] I haven't been able to replicate the auth problem with coworker locally [21:01:09] 06Fundraising-Backlog: Chariot DAFpay button integration - donation form - https://phabricator.wikimedia.org/T405043 (10MDemosWMF) 03NEW [21:01:27] so I'm still pretty torn on merging those auth changes [21:02:07] !log payments-wiki upgraded from a31d7db6 to 7fe92797 [21:02:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:03:36] (03PS2) 10Ejegg: Remove duplicate PaymentMethod constants [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189565 [21:04:44] !log SmashPig upgraded from 9d901f99 to f805ba74 [21:04:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:05:08] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189580 [21:05:10] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189580 (owner: 10Ejegg) [21:06:23] (03CR) 10CI reject: [V:04-1] Remove duplicate PaymentMethod constants [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189565 (owner: 10Ejegg) [21:06:35] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1189580 (owner: 10Ejegg) [21:07:39] bah, needs alias I guess [21:08:07] (03CR) 10Eileen: [C:03+2] "Looks fine - I think you might have an upcoming test fight" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189578 (owner: 10Ejegg) [21:08:42] !log payments-wiki upgraded from 7fe92797 to 3e13fadf [21:08:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:09:09] (03CR) 10Ejegg: "lol, unless that catch() suppresses it all :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189578 (owner: 10Ejegg) [21:11:20] 03Fundraising Sprint: rich, the, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.45-notes (1.45.0-wmf.20; 2025-09-23): Enable post-payment monthly convert for Apple/Google/ACH on Gr4vy - https://phabricator.wikimedia.org/T404380#11195781 (10Ejegg) Oh hey, that code change turned out to be tr... [21:12:51] 03Fundraising Sprint: rich, the, 06Fundraising-Backlog, 10fundraising-tech-ops, 07fr-current-sprint: FR-Tech FY2526Q1 maintenance window - https://phabricator.wikimedia.org/T364182#11195785 (10Dwisehaupt) [21:13:37] 03Fundraising Sprint: rich, the, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.45-notes (1.45.0-wmf.20; 2025-09-23): Enable post-payment monthly convert for Apple/Google/ACH on Gr4vy - https://phabricator.wikimedia.org/T404380#11195786 (10KMorrow-WMF) Amazing! Thanks so much. We're running... [21:23:41] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New batch data entry update: Tabbing after selecting gift date/postmark date - https://phabricator.wikimedia.org/T404642#11195793 (10MDemosWMF) Thank you, I didn't know about the ESC one which could be helpful! [21:24:45] (03Merged) 10jenkins-bot: Explicitly log out of Silverpop after API calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189578 (owner: 10Ejegg) [21:36:10] I'll deploy that silverpop in the hope it helps [21:36:31] I got this one passing now... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1189379 - cstone if you have a chance to look & see what I might have missed... [21:36:59] thanks eileen ill look in a bit [21:51:06] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1189586 [21:51:28] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1189586 (owner: 10Eileen) [21:52:19] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1189586 (owner: 10Eileen) [21:53:11] !log civicrm upgraded from 1448ace2 to d2f459cb [21:53:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:53:26] upgrade script not yet run though - will wait for ejegg to be back [21:56:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Batch data entry feature request: error notification + show completed batch - https://phabricator.wikimedia.org/T371540#11195821 (10MDemosWMF) @Lars I ran a batch with 3 transa... [22:13:19] PROBLEM - check_load on franio2001 is CRITICAL: LOAD CRITICAL - total load average: 134.86, 103.96, 51.35 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=franio2001&service=check_load [22:14:06] ^^ that's me testing a sync. host is running fine, just a boatload of syscalls [22:14:55] ACKNOWLEDGEMENT - check_load on franio2001 is CRITICAL: LOAD CRITICAL - total load average: 134.86, 103.96, 51.35 Dwisehaupt known - testing local syncs https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=franio2001&service=check_load [22:25:53] (03PS1) 10Cstone: Add getInMajorUnits to CurrencyRoundingHelper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189590 [22:26:20] (03CR) 10CI reject: [V:04-1] Add getInMajorUnits to CurrencyRoundingHelper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189590 (owner: 10Cstone) [22:27:47] (03PS2) 10Cstone: Add getInMajorUnits to CurrencyRoundingHelper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189590 [22:28:29] (03PS3) 10Cstone: Add getAmountInMajorUnits to CurrencyRoundingHelper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189590 [22:34:49] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Exempt imports from Coworker pause due to high donation traffic - https://phabricator.wikimedia.org/T405006#11195917 (10Eileenmcnaughton) So imports DO have a history of causing deadlocks for our import queues (the snooze jobs don't which is a different i... [22:36:03] (03PS1) 10Cstone: Show the currency in major units in the email [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189592 [22:36:36] (03CR) 10CI reject: [V:04-1] Show the currency in major units in the email [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189592 (owner: 10Cstone) [22:37:32] (03PS2) 10Cstone: Show the currency in major units in the email [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1189592 [22:39:35] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Exempt imports from Coworker pause due to high donation traffic - https://phabricator.wikimedia.org/T405006#11195924 (10Lars) Thanks for the context, @Eileenmcnaughton. In that case, it sounds like we don't want to change anything here. But if that is th... [22:48:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add double opt-in wiki page to record link clicks from email and create activities - https://phabricator.wikimedia.org/T405047 (10Lars) 03NEW [23:03:08] RECOVERY - check_load on franio2001 is OK: LOAD OK - total load average: 0.27, 1.39, 7.60 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=franio2001&service=check_load [23:05:59] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: Bring Acoustic mailing tags into CiviCRM - https://phabricator.wikimedia.org/T400112#11196007 (10Lars)