[00:15:17] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1217607 [00:19:31] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1217607 (owner: 10Lars SG) [00:20:22] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1217607 (owner: 10Lars SG) [00:36:24] !log Updating civicrm from 1a5626c4 to 8a0822ef [00:36:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:03:46] ok, going to do that payments deploy now [02:08:05] !log payments-wiki upgraded from 460c2f5d to 99671dda [02:08:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:08:25] looks like about 10 web requests got an error while rsync was being performed [02:08:32] but nothing since that finished [02:18:31] (03PS3) 10Jgleeson: Add test coverage for GenericPatternFilter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1217533 (https://phabricator.wikimedia.org/T412406) [02:18:33] (03CR) 10Ejegg: [C:03+2] Add test coverage for GenericPatternFilter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1217533 (https://phabricator.wikimedia.org/T412406) (owner: 10Jgleeson) [02:18:51] (03PS6) 10Jgleeson: Add wildcard support to GenericPatternFilter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1217315 (https://phabricator.wikimedia.org/T412406) [02:18:52] (03CR) 10Ejegg: [C:03+2] Add wildcard support to GenericPatternFilter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1217315 (https://phabricator.wikimedia.org/T412406) (owner: 10Jgleeson) [02:19:37] (03PS4) 10Jgleeson: Use regex-based matching for PatternFilter wildcards. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1217536 (https://phabricator.wikimedia.org/T412406) [02:19:38] (03CR) 10Ejegg: [C:03+2] Use regex-based matching for PatternFilter wildcards. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1217536 (https://phabricator.wikimedia.org/T412406) (owner: 10Jgleeson) [02:20:44] (03Merged) 10jenkins-bot: Add test coverage for GenericPatternFilter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1217533 (https://phabricator.wikimedia.org/T412406) (owner: 10Jgleeson) [02:20:54] !log donorwiki upgraded from bbd96c00 to 99671dda [02:20:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:21:02] (03Merged) 10jenkins-bot: Add wildcard support to GenericPatternFilter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1217315 (https://phabricator.wikimedia.org/T412406) (owner: 10Jgleeson) [02:21:33] (03Merged) 10jenkins-bot: Use regex-based matching for PatternFilter wildcards. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1217536 (https://phabricator.wikimedia.org/T412406) (owner: 10Jgleeson) [02:54:29] (03CR) 10Ejegg: "Code looks good. But it looks like we'll want a small Civi maintenance window for this one maybe? I tried turning the first one into a sel" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1208460 (https://phabricator.wikimedia.org/T408141) (owner: 10Lars SG) [02:55:45] ok, i'm pretty satisfied that the security update didn't do anything to destabilize payments-wiki. gonna sign off for the night [03:01:32] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Queue consumers duplicating all 'wmf' log lines - https://phabricator.wikimedia.org/T412492 (10Ejegg) 03NEW [12:39:59] \ [12:49:08] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1217745 [12:53:14] (03CR) 10Jgleeson: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1217745 (owner: 10Jgleeson) [13:07:21] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1217745 (owner: 10Jgleeson) [13:11:19] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Error logline about Queue host on Gravy adapter - https://phabricator.wikimedia.org/T412519 (10Damilare) 03NEW [13:14:25] !log payments-wiki upgraded from 99671dda to fc18b3c0 [13:14:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [13:19:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Error logline about Queue host on Payment adapters - https://phabricator.wikimedia.org/T412519#11454547 (10Damilare) [14:55:17] fr-tech can anyone else load the monolog config page in civicrm? [14:55:19] https://civicrm.wikimedia.org/civicrm/search#/display/Monolog%20configuration/Monologs [14:55:29] I'm getting an angular error in the console [14:55:52] I think we need to change that config to keep the logs under control - queue consumers are duplicating all the log lines [14:56:41] larssandergreen: is there a more fine-grained cache clear that might help there, short of doing a whole system.flush? [15:00:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Error logline about Queue host on Payment adapters - https://phabricator.wikimedia.org/T412519#11454794 (10Ejegg) [15:13:33] fails for me too ejegg [15:16:50] thanks damilare [15:17:39] i wonder what it would take to make the new flexible forms less fragile [15:37:46] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Trustly errors - splitToken is not valid (397) - https://phabricator.wikimedia.org/T407073#11454893 (10Damilare) a:03Damilare [15:40:21] 03Fundraising Sprint: Xiaolongbao, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev, 07fr-current-sprint: Add recurring donors whose recurring donations don't yet have a donation attached to recurring segments & statuses - https://phabricator.wikimedia.org/T410432#11454902 (10Ejeg... [15:46:30] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add Searchkit with daily email notifications / dashlet for donations missing required details - https://phabricator.wikimedia.org/T412463#11454912 (10krobinson) @Lars RML donors should all have a name attached once they have complet... [15:47:41] ejegg: you can supply options to cv flush: https://github.com/civicrm/cv/blob/master/src/Command/FlushCommand.php and https://github.com/civicrm/civicrm-core/blob/master/Civi/Core/Rebuilder.php [15:48:56] but looking at that error, I'm not sure what's going on, so not sure what might help [15:49:44] ah, good to know in any case [15:50:30] I'm looking at the ticket to export pending recurrings now and wondering if we should start using template contributions [15:50:42] It would simplify our recurring charge logic for them [15:51:23] and might make it easier to get the pending recurrings into the declarative system eileen created for those statuses [15:53:57] we have this ticket for it from a few years back: https://phabricator.wikimedia.org/T291449 [15:54:33] it would be nice to get more of our systems in line with core features [15:54:33] cstone are you actively working on T409471, you brought it up yesterday on the call and its closely related to what I'm currently working on. [15:54:35] T409471: Recurring ACH looks like a success but then is actually failed - https://phabricator.wikimedia.org/T409471 [16:06:17] (03PS1) 10Damilare Adedoyin: Remove unused parameter and update phpdocs for cancelRecurRecord function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1217782 [16:29:15] damilare: I'm not at my computer is that the ach one ? [16:29:22] Oh it is can't read [16:29:49] Nope damilare why I brought it up last I had done was asked gravy about it in slack [16:29:56] Feel free to take it over [16:30:17] thanks cstone, yep it is the ach one! [16:30:18] cool [16:41:00] larssandergreen: So to create the contribution status id I think I want to do more or less what's included in BAO_ContributionRecur::ensureTemplateContributionExists [16:41:03] https://phabricator.wikimedia.org/diffusion/WFCG/browse/master/core/CRM/Contribute/BAO/ContributionRecur.php#L397 [16:41:40] but with a different amount for the pending ones [16:43:11] I see that they explicitly create the order and line items there, but I was expecting we would be able to just create the template contribution as usual with the API and it would create the line items [16:43:21] I guess there's something being overridden there [16:43:40] I think I'll skip the on-behalf processing too [16:44:05] and I'm not sure why we would need the soft credit against a template contribution [16:46:06] ejegg: I like the idea of using template contributions for recurrings. Eileen might have thoughts though? [16:46:51] But if creating them is behaving differently than creating a normal contribution, that feels a bit like a bug. [16:47:03] anyway, once new pending contributions have a corresponding template i thought i had an idea for getting them into the triggers, but now i'm suspecting it will muddy other totals [16:48:00] yes, i hadn't seen any easy path to making that one work [16:48:43] I think it would be OK to punt it to next year too [18:21:57] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add Searchkit with daily email notifications / dashlet for donations missing required details - https://phabricator.wikimedia.org/T412463#11455490 (10Lars) @krobinson You're right, they aren't RML. Looks like most of the non-recurri... [18:30:09] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add Searchkit with daily email notifications / dashlet for donations missing required details - https://phabricator.wikimedia.org/T412463#11455519 (10Cstone) @krobinson @Lars should this email should be for fr-tech to look at first?... [18:52:33] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add Searchkit with daily email notifications / dashlet for donations missing required details - https://phabricator.wikimedia.org/T412463#11455617 (10Cstone) Just expanding more on the sources/types of this missing info too: Paymen... [18:55:29] (03PS1) 10Ejegg: CurlWrapper logging fixes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1217807 [18:56:12] damilare: we could play around with ^^^ [18:57:26] locally I see the lines written AFTER the 'cURL response completed' line which seems wrong [18:58:08] oh let me fix what it does on failure [19:01:00] ah, and get rid of that maxmemory thing [19:02:39] (03PS2) 10Ejegg: CurlWrapper logging fixes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1217807 [19:14:53] cool, thanks ejegg. I'd plat with that on monday. [19:15:16] play* [19:38:13] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add Searchkit with daily email notifications / dashlet for donations missing required details - https://phabricator.wikimedia.org/T412463#11455799 (10krobinson) Thanks @Cstone for that list, and @Lars for confirming some only have o... [19:40:06] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add Searchkit with daily email notifications / dashlet for donations missing required details - https://phabricator.wikimedia.org/T412463#11455813 (10Cstone) +1 to proactive @krobinson it would save us all a lot of time [20:17:42] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Snooze activities when DR snooze a contact look like they are created by the contact - https://phabricator.wikimedia.org/T412564 (10Lars) 03NEW [21:32:08] 06Fundraising-Backlog: Recurring charge in civi from gravy without the original recurring contribution - https://phabricator.wikimedia.org/T412571 (10Cstone) 03NEW [21:32:20] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: 12/4 Gravy-PayPal contrib without PII in Civi - https://phabricator.wikimedia.org/T411811#11456143 (10Cstone) cid=68956349 haunting too that it doesn't have a name or a recurring contribution record {T412571} [21:37:44] 06Fundraising-Backlog: Recurring charge in civi from gravy without the original recurring contribution - https://phabricator.wikimedia.org/T412571#11456153 (10Cstone) 05Open→03Declined feature not bug [22:17:26] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Lots of snooze activities on one contact - https://phabricator.wikimedia.org/T392726#11456193 (10DBautista-WMF) @Cstone I was going to submit a phab but saw this one already created, so I'll just add to this task instead. We noticed multiple snooze a... [22:18:39] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Lots of snooze activities on one contact - https://phabricator.wikimedia.org/T392726#11456195 (10Cstone) @Lars might be good to look at this one combined with the other snooze weirdness? [23:16:08] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Lots of snooze activities on one contact - https://phabricator.wikimedia.org/T392726#11456240 (10Lars) Interesting, we have [[ https://civicrm.wikimedia.org/civicrm/admin/search#/create/Contact?is_template=0¶ms=%7B%22version%22:4,%22select%22:%5B... [23:16:15] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Lots of snooze activities on one contact - https://phabricator.wikimedia.org/T392726#11456241 (10Lars) a:03Lars