[00:06:04] (03CR) 10Wfan: [C:03+2] Extract getSelectContributionFields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240800 (owner: 10Eileen) [00:08:31] (03CR) 10Wfan: [C:03+2] Use false to prevent duplicate lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240798 (owner: 10Eileen) [00:17:44] (03CR) 10Wfan: Add US only phone validation to start (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240469 (https://phabricator.wikimedia.org/T380106) (owner: 10Cstone) [00:26:36] (03Merged) 10jenkins-bot: Extract getSelectContributionFields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240800 (owner: 10Eileen) [00:26:37] (03Merged) 10jenkins-bot: Use false to prevent duplicate lookups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240798 (owner: 10Eileen) [00:54:41] FIRING: [2x] CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [01:43:16] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing: Engage <> Gr4vy for Direct Mail CC and ACH - https://phabricator.wikimedia.org/T417842#11634998 (10Eileenmcnaughton) @JMando my thinking was this was akin to how we have 'Mobile Banner', 'Desktop Banner', 'Other Banner' etc - i... [01:59:14] (03CR) 10Krinkle: [C:03+2] Remove unused messages [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1237307 (owner: 10Ejegg) [02:02:48] (03Merged) 10jenkins-bot: Remove unused messages [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1237307 (owner: 10Ejegg) [02:13:48] 10fundraising-tech-ops: dkim sign internal bounce messages from civi and frmx hosts - https://phabricator.wikimedia.org/T417958 (10Dwisehaupt) 03NEW [03:26:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update `cv` to latest upstream - https://phabricator.wikimedia.org/T417959 (10Eileenmcnaughton) 03NEW [04:54:41] FIRING: [2x] CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [06:22:10] PROBLEM - check_memory on fransw2001 is CRITICAL: CRIT Memory 96% used. Largest process: trino-server-co (1560) = 95.1% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2001&service=check_memory [06:27:12] PROBLEM - check_memory on fransw2001 is CRITICAL: CRIT Memory 100% used. Largest process: trino-server-co (1560) = 99.1% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2001&service=check_memory [06:54:04] PROBLEM - check_procs on fransw2001 is CRITICAL: CRITICAL - Plugin timed out after 10 seconds https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2001&service=check_procs [06:57:10] PROBLEM - check_load on fransw2001 is CRITICAL: LOAD CRITICAL - total load average: 8.71, 82.32, 91.55 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2001&service=check_load [06:57:10] RECOVERY - check_memory on fransw2001 is OK: OK Memory 1% used https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2001&service=check_memory [06:57:12] RECOVERY - check_procs on fransw2001 is OK: PROCS OK: 602 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2001&service=check_procs [07:02:08] PROBLEM - check_load on fransw2001 is CRITICAL: LOAD CRITICAL - total load average: 0.15, 30.20, 66.28 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2001&service=check_load [07:07:10] RECOVERY - check_load on fransw2001 is OK: LOAD OK - total load average: 0.32, 11.39, 48.13 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2001&service=check_load [08:21:14] PROBLEM - check_memory on fransw2003 is CRITICAL: CRIT Memory 95% used. Largest process: trino-server-co (1550) = 94.3% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2003&service=check_memory [08:26:14] RECOVERY - check_memory on fransw2003 is OK: OK Memory 35% used https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2003&service=check_memory [08:54:41] FIRING: [2x] CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [09:01:46] 03Fundraising Sprint: Carbon Fibre Bathtub, 06Fundraising-Backlog, 06FR-donorrelations, 10Recurring-Donations, and 2 others: Localizing Recurring Upgrade Form - https://phabricator.wikimedia.org/T415682#11635386 (10TomaszGorski) It's great as it changes from formal to informal tone, which is what we use in... [09:40:24] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240549 (owner: 10L10n-bot) [09:42:27] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1240517 (owner: 10L10n-bot) [12:54:41] FIRING: [2x] CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [14:24:31] (03PS13) 10Jgleeson: Add MediaWiki donor status export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1237965 (https://phabricator.wikimedia.org/T416948) [14:35:50] (03PS1) 10Damilare Adedoyin: Fix breaking line on mobile due to limited space. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240993 (https://phabricator.wikimedia.org/T413133) [14:41:57] (03CR) 10Damilare Adedoyin: [C:03+2] Remove handling for long-deprecated currency_code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240794 (owner: 10Ejegg) [14:43:37] (03CR) 10Damilare Adedoyin: [C:03+2] Config for non-USD recurring upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240095 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [14:45:03] (03CR) 10Damilare Adedoyin: [C:03+2] Use IntlDateFormatter for DonorPortal and RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240790 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [14:46:11] (03CR) 10Jgleeson: "Thanks for the review. I agree with the points about reusing existing infrastructure and avoiding timing issues, but I think merging this " [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1237965 (https://phabricator.wikimedia.org/T416948) (owner: 10Jgleeson) [14:46:19] thanks damilare ! [14:51:04] np [14:51:32] (03CR) 10Damilare Adedoyin: [C:03+2] Spanish localization for Recurring Upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240105 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [14:59:26] (03CR) 10Damilare Adedoyin: [C:03+2] Italian localization for Recurring Upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240806 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [15:00:05] (03CR) 10Damilare Adedoyin: [C:03+2] Updated Dutch translations for Recurring Upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240808 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [15:04:32] (03PS3) 10Ejegg: Add CZ online banking to Gravy enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1240811 (https://phabricator.wikimedia.org/T392659) [15:08:39] (03CR) 10Damilare Adedoyin: [C:03+2] Remove old drupal CiviCRM URLs from URL Helper. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1240699 (owner: 10Jgleeson) [15:08:43] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Remove old drupal CiviCRM URLs from URL Helper. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1240699 (owner: 10Jgleeson) [15:08:50] thanks damilare ! [15:09:01] review machine day for you [15:09:01] np :) [15:09:05] :) [15:09:10] just small patches [15:09:24] it all helps! thank you [15:13:44] (03CR) 10Damilare Adedoyin: [V:03+2] Add tools and mediawiki-donor-export helper scripts [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1240381 (https://phabricator.wikimedia.org/T416948) (owner: 10Jgleeson) [15:14:09] ty! [15:14:16] (03PS11) 10Jgleeson: Add MediaWiki core build with Vector 2022 [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1240397 (https://phabricator.wikimedia.org/T415586) [15:15:02] np, jgleeson for that mediawiki helper script, I got this error: (ModuleNotFoundError: No module named 'mediawiki_donor_export') [15:15:24] is this something for the ps you're currently working on or is it suppose to work now [15:15:28] ah you'll need to pull this down on tools https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/1237965 damilare [15:15:37] it's a helper to help testing that one ha [15:15:51] but it's not merged yet [15:15:56] ok makes sense, because I had tools on the latest master [15:15:59] I should have added a commment [15:16:56] here's how I tested it damilare https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/1237965/comments/f9177ce4_94ccc1b6 [15:17:45] TY, that's definitely useful info, I was wondering how that worked [15:18:00] the steps were 1) creating new recurring locally 2) run scripts/silverpop-update.sh 3) run new script [15:20:49] the steps were 1) creating new recurring locally 2) ./scripts/silverpop-update.sh 3) ./scripts/mediawiki-donor-export.sh [15:20:58] I'll paste that update flow on the ticket ^ [15:22:47] (03PS14) 10Jgleeson: Add MediaWiki donor status export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1237965 (https://phabricator.wikimedia.org/T416948) [15:22:59] (03PS15) 10Jgleeson: Add MediaWiki donor status export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1237965 (https://phabricator.wikimedia.org/T416948) [15:23:15] (03PS16) 10Jgleeson: Add MediaWiki donor status export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1237965 (https://phabricator.wikimedia.org/T416948) [15:23:28] this should do it [15:23:30] Test plan: [15:23:30] 1) create new recurring donation locally and import to CiviCRM [15:23:30] 2) ./scripts/silverpop-update.sh [15:23:30] 3) ./scripts/mediawiki-donor-export.sh [15:23:30] 4) /scripts/tools.sh & then cat /tmp/mediawiki_donor_export/MediaWikiDonorStatus-*.csv [15:23:44] add to commit message. larssandergreen FYI ^ [15:23:49] added* [15:24:46] nice, TY! [15:29:13] fr-tech we've got another payment method that can only be tested in prod. :( fortunately it's an even smaller smashpig patch: https://gerrit.wikimedia.org/r/1240811 [15:29:37] just pulling that into your vendor/wikimedia/smash-pig under payments should make it possible to get the redirect at least [15:30:01] (03CR) 10Jgleeson: [C:03+2] Add CZ online banking to Gravy enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1240811 (https://phabricator.wikimedia.org/T392659) (owner: 10Ejegg) [15:30:18] looks low risk ejegg happy to +2 [15:30:35] (03Merged) 10jenkins-bot: Add CZ online banking to Gravy enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1240811 (https://phabricator.wikimedia.org/T392659) (owner: 10Ejegg) [15:30:36] thanks! [15:30:39] good luck with the live testing [15:30:55] have you got details for a CZ bank payment? [15:31:03] nope, we need in-country testers [15:31:15] figured as much [15:31:45] oh did I not push up the test link to fr/dev ? [15:32:07] jgleeson: is there an additional config for the mediawiki export [15:32:12] (03PS1) 10Ejegg: Add test link for gravy online banking CZ [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1241005 (https://phabricator.wikimedia.org/T392659) [15:32:15] I'm getting this error: Exception: No config found, [15:32:35] let me see if i put that in the readme [15:33:06] I think you can just rename mediawiki_donor_export.yaml.example to mediawiki_donor_export.yaml [15:33:08] ohh I see it [15:33:24] sweet [15:33:30] cool thanks, I should be reading the readmes [15:33:41] i never do either [15:33:46] the code should be the docs ha! [15:34:38] it never is, funny I just told claude to add comments on every function it adds to my personal project [15:34:51] we don't want it to inherit our bad habits [15:35:58] nice [15:36:11] make the machines better than us :|D [15:37:32] (03Merged) 10jenkins-bot: Remove handling for long-deprecated currency_code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240794 (owner: 10Ejegg) [15:37:33] (03Merged) 10jenkins-bot: Config for non-USD recurring upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240095 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [15:37:39] (03Merged) 10jenkins-bot: Use IntlDateFormatter for DonorPortal and RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240790 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [15:38:58] (03Merged) 10jenkins-bot: Spanish localization for Recurring Upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240105 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [15:39:46] damilare: with claude, I found this technique useful, ask it to plan the implementation, and add tests with edge cases, once it writes it, run the tests to conirm they work and make sense, THEN tell it to throw away the implementation code and leave the tests, and you end up with rapid TDD for free and you stil get to remember the implementation cause you write it quicker with the tests as guard rails. [15:43:47] nice! It'd probably catch more edge cases in the tests than a person would think of in the first run. [15:46:56] yeah it goes to town on the edge cases [15:59:04] (03PS1) 10Damilare Adedoyin: Add volume mounts to access tools exports [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1241006 [16:00:24] (03CR) 10Damilare Adedoyin: [C:03+2] "LGTM, thanks for the test instructions - I added this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1241006 to make i" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1237965 (https://phabricator.wikimedia.org/T416948) (owner: 10Jgleeson) [16:01:18] thanks damilare ! [16:01:54] np! [16:02:09] (03CR) 10Damilare Adedoyin: [C:03+2] Add test link for gravy online banking CZ [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1241005 (https://phabricator.wikimedia.org/T392659) (owner: 10Ejegg) [16:02:12] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Add test link for gravy online banking CZ [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1241005 (https://phabricator.wikimedia.org/T392659) (owner: 10Ejegg) [16:02:12] (03Merged) 10jenkins-bot: Add MediaWiki donor status export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1237965 (https://phabricator.wikimedia.org/T416948) (owner: 10Jgleeson) [16:02:16] (03CR) 10Jgleeson: [V:03+2 C:03+2] Add volume mounts to access tools exports [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1241006 (owner: 10Damilare Adedoyin) [16:02:33] helper mounts make sense to me damilare [16:04:56] (03Merged) 10jenkins-bot: Italian localization for Recurring Upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240806 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [16:05:01] (03Merged) 10jenkins-bot: Updated Dutch translations for Recurring Upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1240808 (https://phabricator.wikimedia.org/T415682) (owner: 10Ejegg) [16:08:11] jgleeson: what table is the donor status pulled from? [16:08:28] silverpop_export_view_full [16:08:34] it's a view [16:08:41] of silverpop_export_full [16:09:43] or mayve it's just silverpop_export [16:09:54] the underlying [16:10:55] 06Fundraising-Backlog, 05FY25-26 WE3.5 Donor Identification and recognition: Evaluate donor badge experiment - https://phabricator.wikimedia.org/T415918#11636742 (10AKanji-WMF) Linking to the [[ https://docs.google.com/document/d/1FaN75iUShqfuarhLJT72uyUOR5e-1F-pfKbnqW9ljbc/edit?tab=t.0 | final report ]], as p... [16:13:45] (03PS4) 10Ejegg: Send double opt-in email on email prefs opt-in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240016 (https://phabricator.wikimedia.org/T407442) [16:13:45] (03PS3) 10Ejegg: Add double opt-in activity from email change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240025 (https://phabricator.wikimedia.org/T407442) [16:13:45] (03PS1) 10Ejegg: Refactor Dbl Opt-In send into API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241008 (https://phabricator.wikimedia.org/T407442) [16:14:32] ok larssandergreen, I just fixed the email prefs qc to just send the email when opting in from an affected country ^^^ [16:14:33] yh I see donor_status_bin in silverpop_export but no donor_status_id.. [16:15:24] let me take a look [16:17:13] PROBLEM - check_memory on fransw2002 is CRITICAL: CRIT Memory 96% used. Largest process: trino-server-co (1553) = 94.5% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2002&service=check_memory [16:18:38] MariaDB [civicrm]> desc wmf_donor; [16:18:38] +-------------------------------+------------------+------+-----+---------+----------------+ [16:18:38] | Field | Type | Null | Key | Default | Extra | [16:18:38] +-------------------------------+------------------+------+-----+---------+----------------+ [16:18:38] | id | int(10) unsigned | NO | PRI | NULL | auto_increment | [16:18:39] | entity_id | int(10) unsigned | NO | UNI | NULL | | [16:18:39] | donor_segment_id | int(11) | YES | MUL | 1000 | | [16:18:40] | donor_status_id | int(11) | YES | MUL | NULL | | [16:18:42] it lives in there damilare [16:19:04] and then gets passed through the silverpop update pipeline [16:19:41] ohh cools, thanks. I was wondering why one of the donors had a id of 1000 [16:19:47] test donors* [16:21:07] I think there's some bitmask magic going on [16:21:11] which I don't fully understand [16:21:18] jgleeson: it's for the merging [16:21:31] nice ejegg [16:21:41] when you want to merge someone whose status is lybunt with another whose status is new [16:22:00] the merged contact should actually be the third status, consecutive [16:22:13] PROBLEM - check_memory on fransw2002 is CRITICAL: CRIT Memory 96% used. Largest process: trino-server-co (1553) = 94.5% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2002&service=check_memory [16:22:19] so the previous merge rule that just chose the minval was inaccurate [16:22:42] makes sense [16:23:02] pretty clever that we combine status when we detect a merge [16:23:21] power rangers [16:23:32] mighty morphin donor status [16:26:17] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing: Engage <> Gr4vy for Direct Mail CC and ACH - https://phabricator.wikimedia.org/T417842#11636769 (10Jmando-) @Eileenmcnaughton gotcha. I think the move to channel from donation type in analytics is going to cause changes no matt... [16:27:13] PROBLEM - check_memory on fransw2002 is CRITICAL: CRIT Memory 96% used. Largest process: trino-server-co (1553) = 94.5% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2002&service=check_memory [16:42:13] RECOVERY - check_memory on fransw2002 is OK: OK Memory 49% used https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2002&service=check_memory [16:47:44] (03PS2) 10Ejegg: Refactor Dbl Opt-In send into API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241008 (https://phabricator.wikimedia.org/T407442) [16:48:21] (03PS1) 10Ejegg: Verify contact ID and checksum on email prefs messages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241015 [16:48:48] damilare: ^^^ is half of it [16:49:08] we still need to check that the contribution_recur_id belongs to the contact_id [16:49:24] (and see the FIXME about logouts invalidating checksums) [16:50:56] ahh thanks I was just implementing this and got stuck on that particular scenario [16:51:05] the logout? [16:51:22] yep the logout invalidating the checksum before we get the chance to consume [16:51:51] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for skivlehan - https://phabricator.wikimedia.org/T417238#11636889 (10Dwisehaupt) certificate renewed and sent via email. password sent via sms. [16:51:57] yeah, the lame way is just to copy the validChecksum code without calling the hook that we use to invalidate it from that table [16:52:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Prevent test email addresses from being MSL-ed in Acoustic - https://phabricator.wikimedia.org/T418011 (10Lars) 03NEW [16:53:00] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Prevent test email addresses from being MSL-ed in Acoustic - https://phabricator.wikimedia.org/T418011#11636904 (10Lars) a:03Lars [16:54:41] FIRING: [2x] CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [16:56:44] damilare: ah dang [16:57:14] the contact ID might legit not match the id on the contribution_recur row [16:57:29] because we're pulling in all the rows for contacts that share an email address [16:57:45] I think we need to do some more validation on submit up in the donor portal code [16:58:11] wellllll [16:58:28] we could just use the getDonorSummary call right in the validatino [16:58:32] *validation [16:58:46] ehhh, I guess it'd work [16:59:25] ah but then we can't bypass the invalidated checksums [16:59:30] hmm hmm hmmmmmmmmm [16:59:37] we can send the specific contact id of the updated recur also with the request also [16:59:50] yeah, that would also work [17:00:02] probably with the contact's checksum [17:00:12] oh jeez, so multiple checksums?? [17:00:17] dang [17:00:21] we'd need to do that from the getDonorSummary request [17:00:30] oh meeting time [17:02:02] gmeet is not loading in FF, huh [17:07:26] (03CR) 10CI reject: [V:04-1] Verify contact ID and checksum on email prefs messages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241015 (owner: 10Ejegg) [17:13:05] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: SearchKit for Merged Contacts and Potential Duplicates by Donor Segment - https://phabricator.wikimedia.org/T418014 (10SHust) 03NEW [17:30:07] 03Fundraising Sprint: Carbon Fibre Bathtub, 06Fundraising-Backlog, 06FR-donorrelations, 10Recurring-Donations, and 2 others: Localizing Recurring Upgrade Form - https://phabricator.wikimedia.org/T415682#11637069 (10TomaszGorski) Hi everyone, [[ https://docs.google.com/document/d/1B5ozrtAmRKz5KHV4EJlCjjva5v... [17:32:29] (03PS3) 10Lars SG: Include opted out contacts in silverpop_export & silverpop_export_view_full [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1240084 (https://phabricator.wikimedia.org/T416948) [17:32:30] (03PS3) 10Lars SG: Add do_not_solicit to silverpop_export_view_full for MW export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1240818 (https://phabricator.wikimedia.org/T416948) [17:32:30] (03PS1) 10Lars SG: Add do_not_solicit MW export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1241018 (https://phabricator.wikimedia.org/T416948) [17:34:57] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-CiviCRM-Searchkit, 06FR-donorrelations: SearchKit for Merged Contacts and Potential Duplicates by Donor Segment - https://phabricator.wikimedia.org/T418014#11637076 (10Lars) [17:39:07] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07Epic: Show contact as opted out in email prefs center if they need DOI, but don't have it - https://phabricator.wikimedia.org/T417935#11637080 (10Lars) a:05Lars→03None [17:39:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Prevent test email addresses from being MSL-ed in Acoustic - https://phabricator.wikimedia.org/T418011#11637082 (10Lars) p:05Triage→03Medium [18:25:03] (03CR) 10Damilare Adedoyin: [C:03+2] When venmo username update, add activity for old one [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1237625 (https://phabricator.wikimedia.org/T416052) (owner: 10Wfan) [18:26:34] thanks dami~ [18:28:00] np wfan the location type patch is longer, I'd like to debug through it carefully to understand what's going on there. I'd do that on monday if no one else does before then. [18:28:25] sure have a great weekend~ [18:28:27] have a great weekend! [18:33:43] 03Fundraising Sprint: Carbon Fibre Bathtub, 06Fundraising-Backlog, 10FR-Adyen, 05MW-1.46-notes (1.46.0-wmf.16; 2026-02-17): Enable Vipps through Adyen - https://phabricator.wikimedia.org/T339937#11637183 (10EMartin) @Ejegg Hi Elliott, it looks like Vipps does not support recurring. We'd have to do this vi... [18:44:02] 03Fundraising Sprint: Carbon Fibre Bathtub, 06Fundraising-Backlog, 10FR-Adyen, 05MW-1.46-notes (1.46.0-wmf.16; 2026-02-17): Enable Vipps through Adyen - https://phabricator.wikimedia.org/T339937#11637227 (10Ejegg) @RKumar_WMF I deployed an update to auto-capture Vipps payments. The next time someone has a... [18:53:11] PROBLEM - check_load on frban1002 is CRITICAL: LOAD CRITICAL - total load average: 148.52, 97.64, 47.92 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1002&service=check_load [18:55:17] PROBLEM - check_load on frban2002 is CRITICAL: LOAD CRITICAL - total load average: 102.95, 97.20, 53.39 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2002&service=check_load [18:58:13] PROBLEM - check_load on frban1002 is CRITICAL: LOAD CRITICAL - total load average: 164.88, 139.68, 79.91 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1002&service=check_load [19:00:17] PROBLEM - check_load on frban2002 is CRITICAL: LOAD CRITICAL - total load average: 132.80, 120.42, 75.40 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2002&service=check_load [19:00:53] ^^ related to ddos on prod trickling down. [19:02:24] ACKNOWLEDGEMENT - check_load on frban1002 is CRITICAL: LOAD CRITICAL - total load average: 164.88, 139.68, 79.91 Dwisehaupt known - ddos trickle down https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1002&service=check_load [19:02:24] ACKNOWLEDGEMENT - check_load on frban2002 is CRITICAL: LOAD CRITICAL - total load average: 132.80, 120.42, 75.40 Dwisehaupt known - ddos trickle down https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2002&service=check_load [19:11:53] (03PS1) 10Ejegg: Common base class for donor portal recurring API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241025 [19:14:22] (03CR) 10CI reject: [V:04-1] Common base class for donor portal recurring API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241025 (owner: 10Ejegg) [19:19:49] (03PS2) 10Ejegg: Common base class for donor portal recurring API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241025 [19:39:57] (03PS1) 10Ejegg: Validate IDs passed to recurring modification APIs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 [19:40:15] ok wfan there's the validation. I just need to smoke test ^^^ [19:41:07] ok checking [19:41:14] (03CR) 10Wfan: [C:03+2] Common base class for donor portal recurring API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241025 (owner: 10Ejegg) [19:42:38] (03CR) 10CI reject: [V:04-1] Validate IDs passed to recurring modification APIs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 (owner: 10Ejegg) [19:43:26] oh look at that, phan says no generic 'Exception' [19:44:01] (03Merged) 10jenkins-bot: Common base class for donor portal recurring API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241025 (owner: 10Ejegg) [19:45:28] (03CR) 10Wfan: Validate IDs passed to recurring modification APIs (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 (owner: 10Ejegg) [19:59:22] (03PS2) 10Ejegg: Validate IDs passed to recurring modification APIs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 [19:59:32] (03CR) 10CI reject: [V:04-1] Validate IDs passed to recurring modification APIs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 (owner: 10Ejegg) [20:02:31] (03PS3) 10Ejegg: Validate IDs passed to recurring modification APIs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 [20:03:24] (03CR) 10Ejegg: "OK, I added errors for the missing session and made sure the validation is always performed first." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 (owner: 10Ejegg) [20:05:16] (03CR) 10CI reject: [V:04-1] Validate IDs passed to recurring modification APIs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 (owner: 10Ejegg) [20:10:16] ah dang, that doesn't seem to be working locally either [20:10:17] hmm [20:14:15] oh hah yes it did work i just reloaded and got my session set back [20:15:05] (03PS4) 10Ejegg: Validate IDs passed to recurring modification APIs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 [20:15:16] ok wfan ^^^ seems to be working [20:15:52] so to test locally, I loaded two different contacts donor portals into two different tabs, so the second load overwrote the first session [20:16:22] then I tried to submit some modifications from the first tab which then didn't match the IDs in session [20:17:03] ooh, pretty good snowstorm suddenly started out there [20:18:54] OK checking [20:20:53] phew, getting a V+2 as well [20:23:51] Nice I think this works. Add unit test in a new patch? [20:25:54] (03CR) 10Ejegg: [C:04-1] "Adding validation on the front end for now" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241015 (owner: 10Ejegg) [20:26:26] ok wfan, i'll think about how to do that [20:26:45] just hoping to get this safeguard deployed asap [20:26:59] (03CR) 10Wfan: [C:03+2] Validate IDs passed to recurring modification APIs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 (owner: 10Ejegg) [20:27:03] sure [20:27:12] thanks for the speedy review! [20:28:30] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1241032 [20:28:34] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1241032 (owner: 10Ejegg) [20:29:16] Np thanks for catch this security bug [20:29:21] (03Merged) 10jenkins-bot: Validate IDs passed to recurring modification APIs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1241028 (owner: 10Ejegg) [20:30:13] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1241032 (owner: 10Ejegg) [20:38:15] !log donorwiki upgraded from f7a0ee6b to f5d7179a [20:38:16] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [20:38:24] ok, that seems to be working in production too [20:42:37] 03Fundraising Sprint: Carbon Fibre Bathtub, 06Fundraising-Backlog, 06FR-donorrelations, 10Recurring-Donations, and 2 others: Localizing Recurring Upgrade Form - https://phabricator.wikimedia.org/T415682#11637474 (10Ejegg) I've deployed the config for the non-USD currencies, plus the date localization and t... [20:43:40] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 06FR-donorrelations: Feature request assessment: Zendesk macro updater - https://phabricator.wikimedia.org/T387503#11637476 (10AKanji-WMF) Rolling this into Sprint +1 (cc: @AStein-WMF ) [20:50:06] 06Fundraising-Backlog, 07Fundraising-FRUP, 07Epic: Fundraiseup sunsetting - https://phabricator.wikimedia.org/T391961#11637484 (10AKanji-WMF) @Damilare is this closeable? [20:54:41] FIRING: [2x] CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [21:05:09] guess I'll make a ticket for that security bug now that it's fixed [21:08:05] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Donor-portal: Validate IDs in donor portal API calls - https://phabricator.wikimedia.org/T418025 (10Ejegg) 03NEW [21:10:07] 03Fundraising Sprint: Carbon Fibre Bathtub, 06Fundraising-Backlog, 10FR-Donor-portal, 07fr-current-sprint, 05MW-1.46-notes (1.46.0-wmf.17; 2026-02-24): Track Donor Portal navigation (with web beacons?) - https://phabricator.wikimedia.org/T404243#11637520 (10Ejegg) The front end for this is deployed, and... [21:20:59] (03CR) 10Lars SG: "Looks good, just a couple super minor details" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241008 (https://phabricator.wikimedia.org/T407442) (owner: 10Ejegg) [21:32:49] (03PS4) 10Ejegg: Add double opt-in activity from email change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240025 (https://phabricator.wikimedia.org/T407442) [21:33:41] (03PS5) 10Ejegg: Add double opt-in activity from email change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240025 (https://phabricator.wikimedia.org/T407442) [21:34:14] (03CR) 10Ejegg: "Thanks for the review Lars. I've made the requested changes in the latest PS" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240025 (https://phabricator.wikimedia.org/T407442) (owner: 10Ejegg) [21:37:57] (03PS3) 10Ejegg: Refactor Double Opt-In send into API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241008 (https://phabricator.wikimedia.org/T407442) [21:38:39] (03CR) 10Ejegg: "Thanks, Lars. Fixed in PS3" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241008 (https://phabricator.wikimedia.org/T407442) (owner: 10Ejegg) [21:39:20] (03PS5) 10Ejegg: Send double opt-in email on email prefs opt-in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240016 (https://phabricator.wikimedia.org/T407442) [21:39:21] (03PS6) 10Ejegg: Add double opt-in activity from email change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240025 (https://phabricator.wikimedia.org/T407442) [21:50:17] RECOVERY - check_load on frban2002 is OK: LOAD OK - total load average: 2.83, 4.91, 21.69 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2002&service=check_load [21:52:39] (03PS4) 10Ejegg: Pre-fill subject when adding Double Opt-In [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1239402 (https://phabricator.wikimedia.org/T416018) [21:58:13] RECOVERY - check_load on frban1002 is OK: LOAD OK - total load average: 3.31, 3.87, 20.29 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1002&service=check_load [22:32:53] (03CR) 10Lars SG: "Few details in here, but also ideally we would not send this email if we're going to send them a confirmation email because they've change" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1240016 (https://phabricator.wikimedia.org/T407442) (owner: 10Ejegg) [22:42:53] 03Fundraising Sprint: Carbon Fibre Bathtub, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07Epic, and 2 others: Record confirmed email change in email preferences centre as double opt-in activity in CiviCRM - https://phabricator.wikimedia.org/T407442#11637629 (10Lars) I've asked legal just to con... [23:01:49] (03CR) 10Lars SG: [C:03+2] Pre-fill subject when adding Double Opt-In [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1239402 (https://phabricator.wikimedia.org/T416018) (owner: 10Ejegg) [23:02:44] (03CR) 10Lars SG: [C:03+2] Refactor Double Opt-In send into API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241008 (https://phabricator.wikimedia.org/T407442) (owner: 10Ejegg) [23:19:42] (03Merged) 10jenkins-bot: Pre-fill subject when adding Double Opt-In [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1239402 (https://phabricator.wikimedia.org/T416018) (owner: 10Ejegg) [23:26:54] (03Merged) 10jenkins-bot: Refactor Double Opt-In send into API action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1241008 (https://phabricator.wikimedia.org/T407442) (owner: 10Ejegg)