[00:58:29] <wikibugs>	 (03PS1) 10Wfan: T281493 move scripts under folder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269747
[01:14:05] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Add setting for minimum days between charges [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1268299 (https://phabricator.wikimedia.org/T413905) (owner: 10Ejegg)
[01:28:50] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07fr-payments-ACH: Recurring ACH looks like a success but then is actually failed - https://phabricator.wikimedia.org/T409471#11807125 (10Cstone) 05Resolved→03Open This one is still out there, gravy has acknowledged the issue and is working on updat...
[01:34:21] <wikibugs>	 (03Merged) 10jenkins-bot: Add setting for minimum days between charges [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1268299 (https://phabricator.wikimedia.org/T413905) (owner: 10Ejegg)
[01:34:44] <wikibugs>	 (03Merged) 10jenkins-bot: Skip retry calculations for un-retryable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1268583 (owner: 10Ejegg)
[01:35:46] <wikibugs>	 (03Merged) 10jenkins-bot: Use API4 to update contribution recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1268608 (owner: 10Ejegg)
[01:38:09] <wikibugs>	 06Fundraising-Backlog, 07fr-payments-ACH: Look into what async capture means for the smashpig recurring charge job - https://phabricator.wikimedia.org/T422863#11807157 (10Cstone)
[01:41:54] <wikibugs>	 06Fundraising-Backlog, 06FR-donorrelations: Gravy recurring CLP failing - https://phabricator.wikimedia.org/T422389#11807162 (10Cstone) I think this was due to the adyen routing rue being placed above the dlocal one in the console by accident, we switched that back and they are processing again
[01:42:07] <wikibugs>	 06Fundraising-Backlog, 06FR-donorrelations: 2026-04-06 Gravy recurring CLP failing - https://phabricator.wikimedia.org/T422389#11807163 (10Cstone)
[01:42:20] <wikibugs>	 06Fundraising-Backlog, 06FR-donorrelations: 2026-04-06 Gravy recurring CLP failing - https://phabricator.wikimedia.org/T422389#11807164 (10Cstone)
[01:42:21] <wikibugs>	 06Fundraising-Backlog, 07Epic: Gr4vy Chaos Epic - https://phabricator.wikimedia.org/T403769#11807165 (10Cstone)
[01:43:55] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07payments-orchestration: 2026-03-31 general gravy validation error as bad_request - https://phabricator.wikimedia.org/T421958#11807177 (10Cstone)
[01:44:02] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07payments-orchestration: 2026-03-31 general gravy validation error as bad_request - https://phabricator.wikimedia.org/T421958#11807178 (10Cstone)
[01:44:03] <wikibugs>	 06Fundraising-Backlog, 07Epic: Gr4vy Chaos Epic - https://phabricator.wikimedia.org/T403769#11807179 (10Cstone)
[01:45:14] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07fr-payments-ACH: Recurring ACH looks like a success but then is actually failed - https://phabricator.wikimedia.org/T409471#11807181 (10Cstone)
[01:45:15] <wikibugs>	 06Fundraising-Backlog, 07Epic: Gr4vy Chaos Epic - https://phabricator.wikimedia.org/T403769#11807182 (10Cstone)
[01:52:04] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 0725 Dec Q3 Planning, 07fr-payments-ACH, 07payments-orchestration: Update Civi Record on status Pending from Webhook - https://phabricator.wikimedia.org/T409503#11807185 (10Cstone) I'm going to fold this into  {T422863} as the work done in {T389865} got...
[01:52:43] <wikibugs>	 06Fundraising-Backlog, 07fr-payments-ACH: Look into what async capture means for the smashpig recurring charge job - https://phabricator.wikimedia.org/T422863#11807191 (10Cstone)
[01:52:44] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 0725 Dec Q3 Planning, 07fr-payments-ACH, 07payments-orchestration: Update Civi Record on status Pending from Webhook - https://phabricator.wikimedia.org/T409503#11807189 (10Cstone) →14Duplicate dup:03T422863
[01:55:31] <wikibugs>	 03Fundraising Sprint G - 2026, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-payments-ACH: Change failed ACH contributions to Failed status instead of Chargeback status - https://phabricator.wikimedia.org/T422091#11807200 (10Cstone)
[01:57:09] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations, 07fr-payments-ACH: Trustly donations stuck at authorized - https://phabricator.wikimedia.org/T404446#11807209 (10Cstone)
[02:04:35] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 0725 Dec Q3 Planning, 07fr-payments-ACH, 07payments-orchestration: Gravy Trustly renew expired token - https://phabricator.wikimedia.org/T378633#11807219 (10Cstone)
[02:18:10] <wikibugs>	 03Fundraising Sprint G - 2026, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-payments-ACH: Change failed ACH contributions to Failed status instead of Chargeback status - https://phabricator.wikimedia.org/T422091#11807223 (10Cstone) a:03Cstone
[02:39:47] <wikibugs>	 (03CR) 10Dwisehaupt: [C:03+2] Add a new recurring that will fail [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1269084 (owner: 10Cstone)
[02:40:20] <wikibugs>	 (03Merged) 10jenkins-bot: Add a new recurring that will fail [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1269084 (owner: 10Cstone)
[02:46:53] <wikibugs>	 (03PS3) 10Lars SG: Test updates to switch from lifetime_usd_total to lifetime_including_endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269669 (https://phabricator.wikimedia.org/T422533)
[02:47:47] <wikibugs>	 (03PS4) 10Lars SG: Test updates to switch from lifetime_usd_total to lifetime_including_endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269669 (https://phabricator.wikimedia.org/T422533)
[03:19:01] <wikibugs>	 (03PS1) 10Wfan: Backfill contact with special location type [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269791 (https://phabricator.wikimedia.org/T420992)
[06:21:13] <icinga-wm>	 PROBLEM - check_memory on fransw2003 is CRITICAL: CRIT Memory 96% used. Largest process: trino-server-co (3094929) = 95.5% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2003&service=check_memory
[06:26:15] <icinga-wm>	 PROBLEM - check_memory on fransw2003 is CRITICAL: CRIT Memory 96% used. Largest process: trino-server-co (3094929) = 95.5% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2003&service=check_memory
[06:31:13] <icinga-wm>	 RECOVERY - check_memory on fransw2003 is OK: OK Memory 84% used https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2003&service=check_memory
[11:27:34] <wikibugs>	 (03PS4) 10Aude: Check edit permission for insert close button and banner translation UI [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1268090 (https://phabricator.wikimedia.org/T420810)
[12:21:22] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Trim out extra space for the DonorPortal login email field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270027
[12:52:28] <ejegg|away>	 so the cadence path seems to have run all night with no problems at least :)
[12:52:41] <jgleeson>	 path?
[12:52:47] <jgleeson>	 job
[12:52:51] <jgleeson>	 nice!
[12:53:05] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Trim out extra space for the DonorPortal login email field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270027 (owner: 10Damilare Adedoyin)
[12:53:08] <ejegg>	 *patch
[12:53:33] <damilare>	 ty!
[12:53:58] <ejegg>	 i still owe you review on that bigger patch damilare 
[12:54:31] <jgleeson>	 fr-tech I can strongly recommend the new Super Mario Galaxy movie. We went to see it before and the kids loved it
[12:54:45] <jgleeson>	 lots of retro mario easter eggs
[12:54:49] <ejegg>	 I was just trying to see if there was any other way to mock i18n in tests that didn't require changes to the nontest code
[12:54:54] <ejegg>	 oh nice jgleeson 
[12:55:17] <damilare>	 ohh lemme see
[12:55:18] <wikibugs>	 (03Merged) 10jenkins-bot: Trim out extra space for the DonorPortal login email field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270027 (owner: 10Damilare Adedoyin)
[12:55:50] <ejegg>	 i'm guessing you looked for it already?
[12:56:13] <ejegg>	 but maybe we could overwrite mw.msg or something
[12:56:30] <ejegg>	 or just overwrite the core Vue i18n shim?
[12:57:52] <wikibugs>	 (03PS5) 10Lars SG: Test updates to switch from lifetime_usd_total to lifetime_including_endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269669 (https://phabricator.wikimedia.org/T422533)
[12:57:58] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Test updates to switch from lifetime_usd_total to lifetime_including_endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269669 (https://phabricator.wikimedia.org/T422533) (owner: 10Lars SG)
[12:58:18] <damilare>	 hmm, I'm not sure I understand, are you looking to have the actual strings in the tests?
[12:58:34] <wikibugs>	 (03CR) 10Jgleeson: [C:03+2] T281493 move scripts under folder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269747 (owner: 10Wfan)
[13:00:43] <ejegg>	 damilare: oh maybe I didn't understand the point of the errorMessageMapFunction
[13:03:04] <damilare>	 ohh I see, it was only for reusability across the views that make api requests so we don't have to define the same mapping all the time. 
[13:04:43] <damilare>	 I passed the i18n as a parameter because the tests were breaking as it seems it wasn't in the global context
[13:04:57] <ejegg>	 ok, got it, that explains why it goes in that apiPostAction
[13:05:34] <ejegg>	 ahhh, right, we generally call it from inside Vue components.
[13:05:42] <damilare>	 Yes, In the subsequent patch I moved it to its own file called ErrorUtils
[13:05:46] <wikibugs>	 (03CR) 10Jgleeson: [C:03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1268609 (owner: 10Ejegg)
[13:05:50] <ejegg>	 Now I'm curious exactly where that is wired in
[13:05:57] <ejegg>	 thanks jgleeson 
[13:06:07] <jgleeson>	 ejegg: you could probably inline that one now
[13:06:12] <jgleeson>	 np
[13:06:17] <ejegg>	 true
[13:06:29] <ejegg>	 there's definitely more to refactor along that chain
[13:06:39] <ejegg>	 I'd like to get it using just API4 for example
[13:07:02] <jgleeson>	 nice
[13:16:44] <damilare>	 ejegg: this is where i18n was injected as a directive to the vue components: https://github.com/wikimedia/mediawiki/blob/master/resources/src/vue/i18n.js
[13:16:46] <ejegg>	 back to the old techno today. Starting with Cybotron - Clear
[13:17:27] <ejegg>	 thanks damilare !
[13:17:47] <ejegg>	 oh, so in errorMessageMapFunction what happens if we just use mw.message ?
[13:17:50] <ejegg>	 gonna try it
[13:23:25] <wikibugs>	 (03Merged) 10jenkins-bot: Test updates to switch from lifetime_usd_total to lifetime_including_endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269669 (https://phabricator.wikimedia.org/T422533) (owner: 10Lars SG)
[13:25:07] <wikibugs>	 (03Merged) 10jenkins-bot: T281493 move scripts under folder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269747 (owner: 10Wfan)
[13:25:42] <damilare>	 I think since we didn't mock it, the keys might not show up
[13:26:04] <damilare>	 yh lemme try it again too
[13:26:09] <ejegg>	 damilare: do you understand how the i18n function is getting swapped out during tests for the one that returns $key:[$params]
[13:26:12] <ejegg>	 ?
[13:26:32] <damilare>	 yep its mocked in the jest config
[13:26:38] <damilare>	 lemme get the link
[13:26:56] <ejegg>	 oh in jest.setup.js
[13:27:05] <ejegg>	 right, and mw.message is mocked there too
[13:27:34] <damilare>	 https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/d76826353ba68255eec412b77b2c0b06c9424071/jest.setup.js#L14
[13:27:50] <ejegg>	 OK, so we coud fix the mw.message mock to return the same thing
[13:28:18] <ejegg>	 I'll keep reviewing the patch - any changes to the i18n thing can be a follow-on
[13:28:40] <damilare>	 thanks!
[13:28:43] <ejegg>	 since it changes in the next patch anyway
[13:28:57] <damilare>	 yh I'd work on the mw mocking as well
[13:34:22] <jgleeson>	 I swear css never used to be harder than backend programming 
[13:34:30] <jgleeson>	 all this flex-wrap flex stuff
[13:34:36] <jgleeson>	 hurts my head
[13:35:33] <ejegg>	 damilare: do you feel like it's still optimal to have all the submit & error handling logic for a particular function (say, cancel) on the view js while the display logic is all on the cancel component?
[13:35:49] <wikibugs>	 (03Merged) 10jenkins-bot: Remove unneeded query [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1268609 (owner: 10Ejegg)
[13:37:11] <damilare>	 yes, at the time I was trying to make the components as stateless as possible, having the views handle the api/data logic. 
[13:37:20] <damilare>	 what do you think?
[13:39:38] <ejegg>	 Feels like we've ended up passing a lot of stuff back and forth that might be easier to read if it was all in one file
[13:40:02] <ejegg>	 but I'd have to spend a little while experimenting with an alternative to see if that would actually be simpler
[13:40:55] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: More Donor Portal Android UI Fixes - https://phabricator.wikimedia.org/T422939 (10jgleeson) 03NEW
[13:41:44] <wikibugs>	 (03PS1) 10Jgleeson: Fix annual conversion radio button layout on mobile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270036 (https://phabricator.wikimedia.org/T422939)
[13:42:37] <damilare>	 yh I think overtime we have mixed some of the logic, would be good to settle on a pattern
[13:43:05] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: More Donor Portal Android UI Fixes - https://phabricator.wikimedia.org/T422939#11808675 (10jgleeson) After applying https://gerrit.wikimedia.org/r/1270036 it looks better  {F75503214, size=full}
[13:43:48] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Donor-portal, 13Patch-For-Review: More Donor Portal Android UI Fixes - https://phabricator.wikimedia.org/T422939#11808678 (10jgleeson)
[13:45:55] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Fix annual conversion radio button layout on mobile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270036 (https://phabricator.wikimedia.org/T422939) (owner: 10Jgleeson)
[13:47:21] <jgleeson>	 14:44:41 modules/css/donorPortal.less
[13:47:21] <jgleeson>	 14:44:41   1240:3  ✖  Expected shorthand property "flex-flow"  declaration-block-no-redundant-longhand-properties
[13:47:26] <jgleeson>	 you expect too much CI
[13:47:32] <jgleeson>	 I'm a dinosaur here
[13:48:30] <jgleeson>	 after googling "Flexbox crash course" the first link was helpful
[13:48:32] <wikibugs>	 (03PS8) 10Damilare Adedoyin: Show appropriate error for recurring pause failure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266308 (https://phabricator.wikimedia.org/T421917)
[13:48:47] <jgleeson>	 503 error
[13:49:34] <wikibugs>	 (03CR) 10Ejegg: "This works as advertised! I'm seeing a bit of redundancy in the tests, which will make it a bit annoying to make small changes later. And " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266308 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin)
[13:49:38] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Show appropriate error for recurring pause failure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266308 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin)
[13:50:16] <damilare>	 nice! I love how changing the flex direction just switches align and justify items too
[13:51:03] <ejegg>	 i guess front-end code had just started from a much more primitive state when I was learning everything
[13:51:21] <ejegg>	 whereas backend stuff was already pretty mature
[13:51:37] <ejegg>	 well, besides async stuff
[13:51:56] <ejegg>	 so yeah, I feel WAAAAY behind the times in CSS too
[13:52:46] <jgleeson>	 damilare: I feel like I need to go back to W3Schools
[13:53:23] <jgleeson>	 flex-basis: 100%
[13:53:35] <jgleeson>	 what is all this elvish browser magic
[13:53:40] <jgleeson>	 I miss float: left
[13:53:49] <jgleeson>	 right ejegg 
[13:55:39] <damilare>	 everytime, there's always need for a refresher. display: grid is my current obsession
[13:56:41] <wikibugs>	 (03Merged) 10jenkins-bot: Show appropriate error for recurring pause failure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266308 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin)
[13:58:43] <wikibugs>	 (03PS8) 10Damilare Adedoyin: Refactor DonorPortal components to share utility functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266398
[14:00:15] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] "I'm a little torn about putting the view-specific functions in apiUtils - it's good separation by layers, but not by functional area. Stil" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266398 (owner: 10Damilare Adedoyin)
[14:00:43] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Highlight invalid input errors on DonorPortal login page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270037
[14:01:38] <ejegg>	 damilare: I'd like to submit a patch to reduce some of the duplicate assertions in those tests, so it's easy to see which assertions are most relevant to e.g. the failure cases
[14:02:10] <ejegg>	 but I'll wait till you've gotten all the stuff you're currently working on merged
[14:02:16] <ejegg>	 since I'm sure it would conflict a lot
[14:02:38] <damilare>	 Ok thanks, that makes sense
[14:02:43] <jgleeson>	 damilare: is that related to the fancy UI on dotmdeditor?
[14:04:49] <damilare>	 nah that was mostly flex, but we used grid a lot on DonorPortal
[14:04:55] <ejegg>	 next up: Drexciya
[14:10:50] <wikibugs>	 (03Merged) 10jenkins-bot: Refactor DonorPortal components to share utility functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266398 (owner: 10Damilare Adedoyin)
[14:11:04] <ejegg>	 ehh, guess I don't want Drexciya. Maybe some jungle?
[14:11:21] <jgleeson>	 I guess I need to start running grunt locally before pushing patches to DP
[14:11:34] <jgleeson>	 jungle eh ejegg 
[14:11:52] <jgleeson>	 UK Jungle massive crowd would like that
[14:12:27] <jgleeson>	 https://www.youtube.com/watch?v=FoO_POhJNr0
[14:13:00] <wikibugs>	 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add custom fields to Direct Mail activities for segment and ask - https://phabricator.wikimedia.org/T422728#11808757 (10Lars)
[14:14:21] <jgleeson>	 did garage music make it over to the US
[14:17:37] <wikibugs>	 03Fundraising Sprint G - 2026, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Merge foundation and endowment latest fields for Acoustic export - https://phabricator.wikimedia.org/T422689#11808773 (10Lars) a:03Lars @ppenloglou For visibility, the following fields are no longer in Acoustic:  AF_late...
[14:18:45] <wikibugs>	 03Fundraising Sprint G - 2026, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Change AF_lifetime_usd_total in Acoustic to both_funds_lifetime_usd_total - https://phabricator.wikimedia.org/T422533#11808788 (10Lars) a:03Lars This is now done.  @ppenloglou For visibility, AF_lif...
[14:19:38] <jgleeson>	 TIL flex-flow: row wrap is the shorthand for flex-direction: row + flex-wrap: wrap combined into one property.
[14:23:45] <wikibugs>	 (03PS1) 10Lars SG: WIP: Add conditional donor portal link to tokensi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1270041 (https://phabricator.wikimedia.org/T419437)
[14:23:56] <wikibugs>	 (03PS2) 10Jgleeson: Fix annual conversion radio button layout on mobile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270036 (https://phabricator.wikimedia.org/T422939)
[14:36:26] <jgleeson>	 fr-tech, we're using alert() to report some errors on donor portal. https://phabricator.wikimedia.org/F75506035
[14:36:49] <jgleeson>	 iPhones do not like alert(). I had issues with this when working on storymaps.io - iphone will block them in certain cases
[14:37:19] <jgleeson>	 I'm doin the android testing now but I'll flag it on the ticket. we might want to make a custom modal error popup or just simply add an inline error showing the same
[14:38:35] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Donor-portal, 05MW-1.46-notes (1.46.0-wmf.23; 2026-04-07): Donor Portal UI Issues on Android - https://phabricator.wikimedia.org/T420983#11808852 (10jgleeson) When testing the annual donation form and submitting without a value, I get this JS ale...
[14:46:06] <wikibugs>	 (03PS1) 10Damilare Adedoyin: DonorPortal: Mock message and use proxy to ensure mocked properties are available in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270044
[14:46:32] <ejegg>	 oh yeah, alert() is def a MVP fixitlater thing
[14:47:36] <damilare>	 TIL about JS proxy, thanks to claude
[14:48:05] <jgleeson>	 ah I used Proxy damilare to avoid having to define a ton of selectors
[14:48:29] <damilare>	 nice, can you share a link to where you used it
[14:49:26] <damilare>	 I was cracking my head about how to get an object to be instantiated after the mocks have been created and not during module load time
[14:49:41] <jgleeson>	 https://github.com/jackgleeson/storymaps.io/blob/d31a1be00777f0c1f359192ac8efb525c726aa65/src/ui/dom.js#L8
[14:51:03] <damilare>	 nice, similar problems. Another one for the js treasure chest!
[14:51:19] <jgleeson>	 yeah modern JS is nice
[14:51:23] <damilare>	 and it has compatibility across browsers too
[14:51:42] <jgleeson>	 I don't feel as much of a dinosaur on that now
[14:51:47] <jgleeson>	 still behind on css tho
[14:51:49] <jgleeson>	 :D
[15:00:15] <wikibugs>	 03Fundraising Sprint G - 2026, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Merge foundation and endowment latest fields for Acoustic export - https://phabricator.wikimedia.org/T422689#11808919 (10ppenloglou) Super helpful @Lars , I'll make sure no DC Ruleset of ours uses these anymore
[15:04:49] <jgleeson>	 damilare: there's some interesting videos of folks in P&T using Claude on the #ai-prototyping Slack. Some are using it with vue.js prototyping too https://wikimedia.slack.com/archives/C0AA0DSQ8VD/p1775669327571689?thread_ts=1775665317.318359&cid=C0AA0DSQ8VD
[15:05:51] <damilare>	 cool! I'd check it out
[15:08:08] <jgleeson>	 One person is using codex in cursor too
[15:08:16] <jgleeson>	 I've not used cursor
[15:09:58] <wikibugs>	 (03PS1) 10Ejegg: Simplify donor portal error message mapping [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270050
[15:10:10] <ejegg>	 damilare: how does that look ? ^^^
[15:10:29] <ejegg>	 ends up around 50 lines lighter
[15:10:53] <ejegg>	 and with some fewer computed properties
[15:11:47] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Simplify donor portal error message mapping [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270050 (owner: 10Ejegg)
[15:12:26] <ejegg>	 oh that ErrorUtils was listed someplace
[15:12:56] <wikibugs>	 (03PS2) 10Ejegg: Simplify donor portal error message mapping [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270050
[15:17:15] <ejegg>	 oh let me fix that i18n comment
[15:17:21] <ejegg>	 still has one of the boilerplate ones
[15:18:19] <wikibugs>	 (03PS3) 10Ejegg: Simplify donor portal error message mapping [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270050
[15:18:31] <damilare>	 yh this looks good, especially since its the same component for all the flows. 
[15:19:51] <damilare>	 The error utils would be useful if we need to create dedicated error components
[15:25:54] <ejegg>	 damilare: so we actually get a string in some real failure cases, not always an object?
[15:26:15] <ejegg>	 lemme debug through it locally...
[15:27:42] <damilare>	 yes the first parameter in the catch callback is a string that maps to the code in the ApiUsageException response
[15:28:34] <damilare>	 the second parameter is the object
[15:35:00] <jgleeson>	 !log payments-wiki upgraded from c017d7e7 to dd45f867
[15:35:01] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL
[15:36:59] <ejegg>	 damilare: do you see all the warnings in the test though? seems like in a lot of the tests we're getting an object there:  https://integration.wikimedia.org/ci/job/mediawiki-node20/103411/console
[15:37:05] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+1] "Thanks for pushing this up, this is quite optimal. I added some comments at the bottom for your consideration." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270050 (owner: 10Ejegg)
[15:37:17] <ejegg>	 e.g. Invalid prop: type check failed for prop "errorCode". Expected String with value "[object Object]", got Object  
[15:38:53] <damilare>	 ohh ok, those are for tests where the code is supposed to be unknown. For example the "'Renders the cancel confirmation page and the recurring error view on failed cancel'" in cancel-donations.test.js
[15:39:07] <damilare>	 I'd update those to return a more befitting response
[15:40:23] <ejegg>	 ahh, so the mocked errors aren't quite right!
[15:40:25] <ejegg>	 thanks
[15:41:15] <wikibugs>	 (03PS4) 10Ejegg: Simplify donor portal error message mapping [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270050
[15:42:45] <wikibugs>	 (03CR) 10Ejegg: "I'd prefer to keep the error message mapping in the error component until we determine we need to split it out" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270050 (owner: 10Ejegg)
[15:54:40] <wikibugs>	 (03PS2) 10Damilare Adedoyin: DonorPortal: Mock message and use proxy to ensure mocked properties are available in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270044
[15:54:59] <wikibugs>	 (03PS3) 10Damilare Adedoyin: DonorPortal: Update mocked tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270044
[15:55:26] <wikibugs>	 (03PS1) 10Ejegg: Simplify cancel recurring tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270057
[16:08:11] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: TypeError bContact.addressLines undefined - https://phabricator.wikimedia.org/T422952 (10AnnWF) 03NEW
[16:08:19] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: TypeError bContact.addressLines undefined - https://phabricator.wikimedia.org/T422952#11809040 (10AnnWF)
[16:08:29] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: TypeError bContact.addressLines undefined - https://phabricator.wikimedia.org/T422952#11809043 (10AnnWF) a:03AnnWF
[16:16:48] <wikibugs>	 03Fundraising Sprint G - 2026, 06Fundraising-Backlog, 07payments-orchestration: Always route Gravy recurring transactions through their original connection - https://phabricator.wikimedia.org/T422416#11809081 (10jgleeson) a:03jgleeson
[16:35:40] <wikibugs>	 (03PS1) 10Wfan: Add the array check for addressLines before check length [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270059 (https://phabricator.wikimedia.org/T422952)
[16:37:31] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Add the array check for addressLines before check length [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270059 (https://phabricator.wikimedia.org/T422952) (owner: 10Wfan)
[16:38:22] <wikibugs>	 (03PS2) 10Wfan: Add the array check for addressLines before check length [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270059 (https://phabricator.wikimedia.org/T422952)
[17:07:03] <wikibugs>	 03Fundraising Sprint G - 2026, 06Fundraising-Backlog, 06FR-donorrelations: Frequency change dropdown in Civi - https://phabricator.wikimedia.org/T421937#11809219 (10AMJohnson) Thank you @Lars and will do! :)
[17:09:37] <wikibugs>	 06Fundraising-Backlog, 06FR-donorrelations: Civi using incorrect donor name - https://phabricator.wikimedia.org/T422957 (10AMJohnson) 03NEW
[17:11:23] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Simplify cancel recurring tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270057 (owner: 10Ejegg)
[17:20:22] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Simplify donor portal error message mapping [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270050 (owner: 10Ejegg)
[17:23:11] <wikibugs>	 (03Merged) 10jenkins-bot: Simplify donor portal error message mapping [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270050 (owner: 10Ejegg)
[17:23:13] <wikibugs>	 (03Merged) 10jenkins-bot: Simplify cancel recurring tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270057 (owner: 10Ejegg)
[17:26:13] <wikibugs>	 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Provide API for key CiviCRM data by email address to load in Zendesk - https://phabricator.wikimedia.org/T421245#11809295 (10Lars) It may be useful to also provide the personalized donor portal link here.
[17:32:32] <wikibugs>	 (03CR) 10Jgleeson: [C:03+2] "LGTM! nice guard." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270059 (https://phabricator.wikimedia.org/T422952) (owner: 10Wfan)
[17:34:23] <wikibugs>	 (03Merged) 10jenkins-bot: Add the array check for addressLines before check length [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270059 (https://phabricator.wikimedia.org/T422952) (owner: 10Wfan)
[19:27:44] <ejegg>	 ooh that smashpig update needs a CRM update to match
[19:27:54] <ejegg>	 just tried to do it as part of another patch
[19:30:47] <ejegg>	 ok, very minor change
[19:31:52] <wikibugs>	 (03PS1) 10Ejegg: Update SmashPig & Civi queue consumer for Throwable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1270076
[19:32:23] <ejegg>	 fr-tech anyone available to review a small patch? ^^^
[19:32:36] <cstone>	 sure ejegg 
[19:32:39] <ejegg>	 thanks!
[19:33:06] <ejegg>	 So I changed it from catching Exception to Throwable in SmashPig because Exception doesn't include e.g. TypeError
[19:33:13] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Update SmashPig & Civi queue consumer for Throwable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1270076 (owner: 10Ejegg)
[19:33:19] <ejegg>	 thanks!
[19:43:54] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: CiviCRM quicksearch: Don't return multiple rows per contact if the contact has the same email twice - https://phabricator.wikimedia.org/T422969 (10Lars) 03NEW
[19:54:18] <wikibugs>	 (03Merged) 10jenkins-bot: Update SmashPig & Civi queue consumer for Throwable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1270076 (owner: 10Ejegg)
[20:06:50] <wikibugs>	 (03CR) 10Wfan: [C:03+2] Fix annual conversion radio button layout on mobile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270036 (https://phabricator.wikimedia.org/T422939) (owner: 10Jgleeson)
[20:08:47] <wikibugs>	 (03Merged) 10jenkins-bot: Fix annual conversion radio button layout on mobile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1270036 (https://phabricator.wikimedia.org/T422939) (owner: 10Jgleeson)
[20:25:55] <wikibugs>	 (03PS4) 10Ejegg: Permissions check for refund form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1268662
[20:25:55] <wikibugs>	 (03PS4) 10Ejegg: SearchTask version of refund form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269005 (https://phabricator.wikimedia.org/T421277)
[20:26:55] <ejegg>	 hmm, maybe that list needs to be a table
[20:42:35] <wikibugs>	 (03PS5) 10Ejegg: SearchTask version of refund form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1269005 (https://phabricator.wikimedia.org/T421277)
[20:43:11] <ejegg>	 ok larssandergreen ^^^ should work under all contexts (searchkit, old search, and individual contribution tab)
[20:43:34] <ejegg>	 it will submit refunds to a coworker queue if more than 5 are selected
[20:43:55] <ejegg>	 I'm a little hazy on whether we need to change config on production to make it look for the new queue name
[20:44:04] <ejegg>	 anyway, I've got to head out
[20:44:11] <ejegg>	 have a good weekend, all!
[22:12:24] <wikibugs>	 10fundraising-tech-ops: Fundraising access request for alester - https://phabricator.wikimedia.org/T420772#11809873 (10Dwisehaupt) 05Open→03Resolved Closing. If there are issues installing the certificate they can be followed up on.
[22:15:43] <wikibugs>	 06Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Caitlin Cogdill - https://phabricator.wikimedia.org/T416399#11809876 (10Dwisehaupt) 05Open→03Resolved Closing. If there are issues installing the certificate or with access they can be followed up on.
[23:04:14] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Civi using incorrect donor name - https://phabricator.wikimedia.org/T422957#11809997 (10Lars) @AnnWF actually already has a patch ready, which I need to review, that will solve this exact problem.
[23:06:20] <wikibugs>	 10fundraising-tech-ops: Update all frack ssh keys to use ed25519 instead of rsa - https://phabricator.wikimedia.org/T368793#11810001 (10Dwisehaupt) going to try and work through the advancement users at the offsite next month. Just need them to generate an updated key and update their ssh config file. Perhaps we...