[00:21:29] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Update Metadbase chariot board for changes - https://phabricator.wikimedia.org/T428014#12143968 (10Eileenmcnaughton) [00:22:50] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: Add a way to validate Finance batches - https://phabricator.wikimedia.org/T417714#12143971 (10Eileenmcnaughton) [00:23:19] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: Add a way to validate Finance batches - https://phabricator.wikimedia.org/T417714#12143973 (10Eileenmcnaughton) [00:24:34] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-payments-general, 10FR-WMF-Audit: Settlement data visualisation - https://phabricator.wikimedia.org/T427456#12143976 (10Eileenmcnaughton) @HAhmed-WMF I guess this was really about the dash you set up in Metabase - I know you did create it... [00:32:37] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog: Chariot imports Do some name grooming - https://phabricator.wikimedia.org/T432802 (10Eileenmcnaughton) 03NEW [00:34:06] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 10FR-WMF-Audit: Chariot - investigate why still some $0 donations - https://phabricator.wikimedia.org/T432803 (10Eileenmcnaughton) 03NEW [00:35:42] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog: Chariot: Every.org - special case rule to add banking institution - https://phabricator.wikimedia.org/T432804 (10Eileenmcnaughton) 03NEW [00:47:54] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.5.5 => v1.2.5.6) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313440 [00:49:02] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.5.5 => v1.2.5.6) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1313441 [00:50:03] (03CR) 10Eileen: [C:03+2] General update [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1312615 (owner: 10Eileen) [00:50:24] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1312616 (owner: 10Eileen) [00:51:58] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1312616 (owner: 10Eileen) [00:52:03] (03PS2) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.5.5 => v1.2.5.6) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1313441 [00:52:32] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.5.5 => v1.2.5.6) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1313441 (owner: 10Eileen) [00:52:46] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.5.5 => v1.2.5.6) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313440 (owner: 10Eileen) [00:56:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Develop process to deal with damaged queue items - https://phabricator.wikimedia.org/T432805 (10Lars) 03NEW [00:59:34] FIRING: DiskSpace: Disk space WARNING for (instance fran2001.frack.codfw.wmnet:9100):/ - https://alerts.wikimedia.org/?q=alertname%3DDiskSpace [01:02:28] (03PS1) 10Lars SG: Use source_record_id for Contact::getMergedTo when merged contact has been deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313442 (https://phabricator.wikimedia.org/T431604) [01:14:27] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.5.5 => v1.2.5.6) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1313441 (owner: 10Eileen) [01:15:39] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.5.5 => v1.2.5.6) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313440 (owner: 10Eileen) [01:16:00] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Develop process to consistently retry email sends - https://phabricator.wikimedia.org/T432806 (10Lars) 03NEW [01:23:24] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Develop process to consistently retry email sends - https://phabricator.wikimedia.org/T432806#12144096 (10Lars) [01:31:21] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1313450 [01:31:37] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1313450 (owner: 10Eileen) [01:32:10] (03CR) 10CI reject: [V:04-1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1313450 (owner: 10Eileen) [01:32:30] (03PS2) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1313450 [01:33:51] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1313450 (owner: 10Eileen) [01:36:27] !log civicrm upgraded from 2eba4374 to 5a04e8a9 [01:36:28] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [01:42:27] (03PS1) 10Eileen: Chariot: audit - use getValue() function a little more, move trim [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313455 (https://phabricator.wikimedia.org/T432802) [01:42:56] (03CR) 10CI reject: [V:04-1] Chariot: audit - use getValue() function a little more, move trim [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313455 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [01:45:04] (03PS2) 10Eileen: Chariot: audit - use getValue() function a little more, move trim [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313455 (https://phabricator.wikimedia.org/T432802) [01:45:39] (03CR) 10CI reject: [V:04-1] Chariot: audit - use getValue() function a little more, move trim [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313455 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [01:46:25] (03PS3) 10Eileen: Chariot: audit - use getValue() function a little more, move trim [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313455 (https://phabricator.wikimedia.org/T432802) [02:06:45] (03PS1) 10Eileen: Chariot: Discard individual fields if they look like they are fund [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313472 (https://phabricator.wikimedia.org/T432802) [02:17:57] (03PS1) 10Eileen: CheckoutCom audit - process or ignore gz files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313478 (https://phabricator.wikimedia.org/T431240) [02:20:43] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 10FR-WMF-Audit, 13Patch-For-Review: Set up reconciliation & verification for checkout.com - https://phabricator.wikimedia.org/T431240#12144132 (10Eileenmcnaughton) I see another phab was opened for the id issue [02:21:07] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 10FR-WMF-Audit, 13Patch-For-Review: Set up reconciliation & verification for checkout.com - https://phabricator.wikimedia.org/T431240#12144134 (10Eileenmcnaughton) [02:42:51] (03CR) 10Lars SG: [C:03+2] Test for braintree fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311309 (owner: 10Eileen) [03:01:59] (03Merged) 10jenkins-bot: Test for braintree fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311309 (owner: 10Eileen) [04:34:12] (03PS1) 10Eileen: Chariot: use our name parsing library to parse full names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313548 (https://phabricator.wikimedia.org/T432802) [04:34:14] (03PS1) 10Eileen: Improve manual review message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313549 [04:38:30] (03CR) 10Isap-palir: [C:03+1] Use source_record_id for Contact::getMergedTo when merged contact has been deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313442 (https://phabricator.wikimedia.org/T431604) (owner: 10Lars SG) [04:40:51] (03CR) 10Isap-palir: [C:03+1] CheckoutCom audit - process or ignore gz files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313478 (https://phabricator.wikimedia.org/T431240) (owner: 10Eileen) [04:41:20] (03CR) 10Isap-palir: [C:03+1] Chariot: audit - use getValue() function a little more, move trim [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313455 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [04:43:02] (03CR) 10Isap-palir: [C:03+1] Chariot: Discard individual fields if they look like they are fund [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313472 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [04:46:05] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: Donation coming through stripe GiveLively not in civi or not clear - https://phabricator.wikimedia.org/T432813 (10Eileenmcnaughton) 03NEW [04:47:01] (03CR) 10Isap-palir: [C:03+1] Improve manual review message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313549 (owner: 10Eileen) [04:48:59] (03CR) 10Isap-palir: [C:03+1] Chariot: use our name parsing library to parse full names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313548 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [04:58:36] (03PS1) 10Eileen: Update Chariot Saved search from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313561 [04:59:34] FIRING: DiskSpace: Disk space WARNING for (instance fran2001.frack.codfw.wmnet:9100):/ - https://alerts.wikimedia.org/?q=alertname%3DDiskSpace [05:10:55] (03PS1) 10Eileen: Do not create /bin/bash contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313568 (https://phabricator.wikimedia.org/T432803) [05:13:21] (03PS2) 10Eileen: Do not create zero amount contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313568 (https://phabricator.wikimedia.org/T432803) [05:13:21] (03PS1) 10Eileen: Update Chariot form from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313569 [05:23:46] (03PS1) 10Eileen: Set banking_institution for every.org [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313627 (https://phabricator.wikimedia.org/T428009) [05:24:13] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog: Chariot: Every.org - special case rule to add banking institution - https://phabricator.wikimedia.org/T432804#12144287 (10Eileenmcnaughton) a:03Eileenmcnaughton [05:50:28] FIRING: OOM: OOM killer active on fransw1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DOOM [05:55:28] RESOLVED: OOM: OOM killer active on fransw1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DOOM [08:59:34] FIRING: DiskSpace: Disk space WARNING for (instance fran2001.frack.codfw.wmnet:9100):/ - https://alerts.wikimedia.org/?q=alertname%3DDiskSpace [09:35:29] (03CR) 10Laurabarluzzi: [C:03+2] Chariot: Discard individual fields if they look like they are fund [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313472 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [09:40:29] (03CR) 10Laurabarluzzi: [C:03+2] Chariot: audit - use getValue() function a little more, move trim [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313455 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [09:43:07] (03Merged) 10jenkins-bot: Chariot: audit - use getValue() function a little more, move trim [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313455 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [09:43:12] (03Merged) 10jenkins-bot: Chariot: Discard individual fields if they look like they are fund [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1313472 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [09:44:41] (03CR) 10Laurabarluzzi: [C:03+2] "RadioButtonInput.vue passed with 100s" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1312655 (https://phabricator.wikimedia.org/T429516) (owner: 10Dmiranda) [09:54:52] (03CR) 10Laurabarluzzi: [C:03+1] "Looks good. Before merging this could you please address my comment regarding the mock data?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1313269 (https://phabricator.wikimedia.org/T429516) (owner: 10Dmiranda) [10:00:54] (03Merged) 10jenkins-bot: Added new test file for radio button input, got test coverage to 100% [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1312655 (https://phabricator.wikimedia.org/T429516) (owner: 10Dmiranda) [10:53:23] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add both_funds_latest_payment_method to Acoustic export - https://phabricator.wikimedia.org/T407391#12145156 (10RKumar_WMF) Hi @Lars - https://docs.google.com/spreadsheets/d/1TXlQxTnbwqgMyHWtlC3WOecqBie56tElxIkaPLjQ7-4/edit?gid=1970228372#gid=197022... [11:27:13] (03CR) 10Laurabarluzzi: [C:03+2] CheckoutCom squash settled fee rows into the donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312783 (owner: 10Eileen) [11:31:55] (03PS2) 10Damilare Adedoyin: WIP: Gravy Payment token import scripts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313312 (https://phabricator.wikimedia.org/T418759) [12:42:30] (03CR) 10Lars SG: [C:03+2] Update Chariot form from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313569 (owner: 10Eileen) [12:43:10] (03CR) 10Lars SG: [C:03+2] Update Chariot Saved search from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313561 (owner: 10Eileen) [12:50:11] (03CR) 10Lars SG: Improve manual review message (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313549 (owner: 10Eileen) [12:55:34] (03CR) 10Lars SG: [C:03+2] Do not create zero amount contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313568 (https://phabricator.wikimedia.org/T432803) (owner: 10Eileen) [12:59:34] FIRING: DiskSpace: Disk space WARNING for (instance fran2001.frack.codfw.wmnet:9100):/ - https://alerts.wikimedia.org/?q=alertname%3DDiskSpace [13:02:05] (03PS3) 10Damilare Adedoyin: Gravy Payment token import scripts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313312 (https://phabricator.wikimedia.org/T418759) [13:35:52] 10fundraising-tech-ops, 06Data-Engineering: please add puppet job to delete old data from wmf_fr_tech.banner_activity_minutely - https://phabricator.wikimedia.org/T432051#12145985 (10Ottomata) HuH! It looks like this functionality has been migrated to Airflow. yay! https://gitlab.wikimedia.org/repos/data-engi... [13:36:01] 10fundraising-tech-ops, 06Data-Engineering, 06Data-Engineering-Radar: please add puppet job to delete old data from wmf_fr_tech.banner_activity_minutely - https://phabricator.wikimedia.org/T432051#12145987 (10Ottomata) [13:36:50] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Update getMergedTo to use source_record_id if not found in first pass - https://phabricator.wikimedia.org/T431604#12145989 (10Lars) a:03Lars [13:51:42] (03CR) 10Cstone: [C:03+2] Checkout.com, extract isFeeRow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312748 (owner: 10Eileen) [13:52:15] (03Merged) 10jenkins-bot: Checkout.com, extract isFeeRow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312748 (owner: 10Eileen) [13:52:16] (03CR) 10Cstone: [C:03+2] CheckoutCom extract getExchangeRate [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312793 (owner: 10Eileen) [13:53:01] (03Merged) 10jenkins-bot: CheckoutCom extract getExchangeRate [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312793 (owner: 10Eileen) [13:53:57] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add both_funds_latest_payment_method to Acoustic export - https://phabricator.wikimedia.org/T407391#12146095 (10Lars) Thanks @RKumar_WMF. @MSuijkerbuijk_WMF I think we might need to understand better what you would use this field for in Acoustic in order... [13:58:01] (03CR) 10Cstone: [C:03+2] CheckoutCom audit : Extract getOriginalFeeAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312794 (owner: 10Eileen) [13:58:14] (03CR) 10CI reject: [V:04-1] CheckoutCom audit : Extract getOriginalFeeAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312794 (owner: 10Eileen) [13:58:39] (03CR) 10Cstone: [C:03+2] CheckoutCom audit : Extract getOriginalNetAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312797 (owner: 10Eileen) [13:58:52] (03CR) 10CI reject: [V:04-1] CheckoutCom audit : Extract getOriginalFeeAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312794 (owner: 10Eileen) [13:58:53] (03CR) 10CI reject: [V:04-1] CheckoutCom audit : Extract getOriginalNetAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312797 (owner: 10Eileen) [13:59:04] (03PS4) 10Eileen: CheckoutCom audit : Extract getOriginalFeeAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312794 [13:59:26] (03CR) 10Cstone: [C:03+2] CheckoutCom audit : Extract getOriginalFeeAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312794 (owner: 10Eileen) [14:01:22] (03Merged) 10jenkins-bot: CheckoutCom audit : Extract getOriginalFeeAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312794 (owner: 10Eileen) [14:03:43] (03PS3) 10Eileen: CheckoutCom audit : Extract getOriginalNetAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312797 [14:04:18] (03PS1) 10Lars SG: Add / update new_recur tokens [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313956 (https://phabricator.wikimedia.org/T416435) [14:04:31] (03CR) 10Cstone: [C:03+2] CheckoutCom audit : Extract getOriginalNetAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312797 (owner: 10Eileen) [14:05:14] (03Merged) 10jenkins-bot: CheckoutCom audit : Extract getOriginalNetAmountRounded [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312797 (owner: 10Eileen) [14:06:07] (03PS5) 10Eileen: CheckoutCom audit pass row rather than line into parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312782 [14:08:37] (03CR) 10Cstone: [C:03+2] CheckoutCom audit pass row rather than line into parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312782 (owner: 10Eileen) [14:09:30] (03Merged) 10jenkins-bot: CheckoutCom audit pass row rather than line into parser [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312782 (owner: 10Eileen) [14:09:42] (03PS6) 10Eileen: CheckoutCom squash settled fee rows into the donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312783 [14:09:56] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations, 13Patch-For-Review: Content update for 1st? and 2nd recurring failure email - https://phabricator.wikimedia.org/T416435#12146218 (10Lars) [14:11:27] (03CR) 10Cstone: "recheck" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312783 (owner: 10Eileen) [14:27:02] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07fr-combowiki: Add Gravy ApplePay Vue Component - https://phabricator.wikimedia.org/T430748#12146311 (10Damilare) a:03Damilare [14:32:17] (03CR) 10Cstone: [C:03+2] CheckoutCom squash settled fee rows into the donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312783 (owner: 10Eileen) [14:32:36] (03CR) 10Cstone: [C:03+2] CheckoutCom squash settled fee rows into the donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312783 (owner: 10Eileen) [14:33:09] (03Merged) 10jenkins-bot: CheckoutCom squash settled fee rows into the donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1312783 (owner: 10Eileen) [14:34:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unset payment_submethod for dlocal via gravy results in incorrect payment method = cash in Civi - https://phabricator.wikimedia.org/T432872 (10Lars) 03NEW [14:39:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unset payment_submethod for dlocal via gravy results in incorrect payment method = cash in Civi - https://phabricator.wikimedia.org/T432872#12146431 (10Cstone) We should be mapping all of these, it looks like we have the... [14:42:44] (03CR) 10Cstone: [C:03+2] CheckoutCom audit - process or ignore gz files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313478 (https://phabricator.wikimedia.org/T431240) (owner: 10Eileen) [14:46:03] (03PS1) 10Damilare Adedoyin: Use component is to do conditional rendering of payment method forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1313970 [14:54:23] (03CR) 10Cstone: [C:03+2] Chariot: use our name parsing library to parse full names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313548 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [14:54:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unset or unmapped payment_submethod for dlocal via gravy results in incorrect payment method = cash in Civi - https://phabricator.wikimedia.org/T432872#12146531 (10Lars) [15:02:45] (03Merged) 10jenkins-bot: CheckoutCom audit - process or ignore gz files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313478 (https://phabricator.wikimedia.org/T431240) (owner: 10Eileen) [15:06:44] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add both_funds_latest_payment_method to Acoustic export - https://phabricator.wikimedia.org/T407391#12146599 (10Lars) On the question of the cash donations, most of these appear to be incorrect ({https://phabricator.wikimedia.org/T432872}), but we do have... [15:20:56] (03Merged) 10jenkins-bot: Chariot: use our name parsing library to parse full names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313548 (https://phabricator.wikimedia.org/T432802) (owner: 10Eileen) [15:45:47] (03CR) 10Ejegg: [V:03+2] build: Updating npm dependencies [extensions/DonationInterface] (REL1_46) - 10https://gerrit.wikimedia.org/r/1290535 (owner: 10Libraryupgrader) [15:45:54] (03CR) 10Ejegg: [V:03+2] build: Updating npm dependencies [extensions/DonationInterface] (REL1_44) - 10https://gerrit.wikimedia.org/r/1290534 (owner: 10Libraryupgrader) [15:46:01] (03CR) 10Ejegg: [V:03+2] build: Updating npm dependencies [extensions/DonationInterface] (REL1_45) - 10https://gerrit.wikimedia.org/r/1275151 (owner: 10Libraryupgrader) [15:46:10] (03CR) 10Ejegg: [V:03+2] build: Updating npm dependencies [extensions/DonationInterface] (REL1_43) - 10https://gerrit.wikimedia.org/r/1261876 (owner: 10Libraryupgrader) [16:25:40] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-payments-general: GoFundMe integration - https://phabricator.wikimedia.org/T432890 (10Fundraising-Task-Bot) 03NEW [16:35:10] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-Donor-portal: Payment method update for donor portal - https://phabricator.wikimedia.org/T410593#12147035 (10Lars) Further discussion about this in the context of Combowiki: Potentially, we could provide a link to Combowiki that would pass the donor's d... [16:40:45] (03PS2) 10Ejegg: Remove privatebin [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1304940 [16:41:19] (03PS3) 10Ejegg: Update civiproxy to trixie / PHP8.4 [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1288927 [16:41:35] (03PS4) 10Ejegg: Update SmashPig container to trixie [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1288928 (https://phabricator.wikimedia.org/T424774) [16:43:03] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-payments-general: GoFundMe integration - https://phabricator.wikimedia.org/T432890#12147070 (10MDemosWMF) [16:47:11] FIRING: NodeDown: Node frav1003 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=frav1003 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [16:52:11] RESOLVED: NodeDown: Node frav1003 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=frav1003 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [16:54:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unset or unmapped payment_submethod for dlocal via gravy results in incorrect payment method = cash in Civi - https://phabricator.wikimedia.org/T432872#12147122 (10Ejegg) For at least some of these, the mapping code in c... [16:55:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unset or unmapped payment_submethod for dlocal via gravy results in incorrect payment method = cash in Civi - https://phabricator.wikimedia.org/T432872#12147124 (10Ejegg) I'll fix the mapping code in civi to accept pix w... [16:58:31] 10fundraising-tech-ops: Fundraising access request for Caitlin Satchell - https://phabricator.wikimedia.org/T432894 (10RMurthy) 03NEW [16:59:34] FIRING: DiskSpace: Disk space WARNING for (instance fran2001.frack.codfw.wmnet:9100):/ - https://alerts.wikimedia.org/?q=alertname%3DDiskSpace [17:02:58] (03PS1) 10Ejegg: Map cash/pix to Bank Transfer: Pix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1314049 (https://phabricator.wikimedia.org/T432872) [17:04:54] (03PS1) 10Damilare Adedoyin: Combowiki: Use extradata not specific payload for submitDonation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1314051 [17:07:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-payments-general, 10FR-Smashpig: Failing Trustly recurring charges with No Institution ID configured - https://phabricator.wikimedia.org/T430789#12147220 (10Cstone) We need to contact trustly and have them disable the manual entry feature on our... [17:30:36] (03CR) 10CI reject: [V:04-1] build: Updating npm dependencies [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1314062 (owner: 10Libraryupgrader) [17:45:22] 10fundraising-tech-ops: Fundraising access request for Caitlin Satchell - https://phabricator.wikimedia.org/T432894#12147387 (10Dwisehaupt) [17:46:11] FIRING: NodeDown: Node payments1012 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=payments1012 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [17:51:11] RESOLVED: NodeDown: Node payments1012 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=payments1012 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [18:04:45] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Unset or unmapped payment_submethod for dlocal via gravy results in incorrect payment method = cash in Civi - https://phabricator.wikimedia.org/T432872#12147463 (10Ejegg) Looks like they are all ind... [18:50:32] (03PS1) 10Cstone: WIP Test change for combo wiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1314094 (https://phabricator.wikimedia.org/T430749) [19:00:44] (03PS2) 10Ejegg: Map cash/pix to Bank Transfer: Pix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1314049 (https://phabricator.wikimedia.org/T432872) [19:01:03] cstone / larssandergreen ^^^ should fix the pix / cash confusion [19:02:51] oh it's tech talk [19:02:58] ok, gonna lurk with camera off [19:03:22] (03CR) 10Vaughn Walters: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1312579 (https://phabricator.wikimedia.org/T429531) (owner: 10Vaughn Walters) [19:05:59] (03CR) 10CI reject: [V:04-1] Add seedTestData.php maintenance script for selenium seeding [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1312579 (https://phabricator.wikimedia.org/T429531) (owner: 10Vaughn Walters) [19:25:39] 06Fundraising-Backlog, 10FR-payments-general, 10FR-Tech onboarding task: Handle gravy moto webhooks - https://phabricator.wikimedia.org/T432672#12147693 (10SBurnett-WMF) [19:28:49] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 07payments-orchestration: Recurring Token Migrate - Adyen Ideal - https://phabricator.wikimedia.org/T432725#12147700 (10SBurnett-WMF) [19:29:58] 10fundraising-tech-ops: Fundraising access request for Caitlin Satchell - https://phabricator.wikimedia.org/T432894#12147703 (10Dwisehaupt) Access request sent. [19:30:21] 10fundraising-tech-ops: Fundraising access request for Caitlin Satchell - https://phabricator.wikimedia.org/T432894#12147706 (10Dwisehaupt) a:03Dwisehaupt [19:57:15] (03PS1) 10Damilare Adedoyin: WIP: Applepay in combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1314107 [20:02:59] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07Epic: Epic: Merge duplicative CiviCRM opt out and similar fields - https://phabricator.wikimedia.org/T426745#12147774 (10Lars) Reach out to @HAhmed-WMF to let her know the new system once this is complete, as analytics will be adding number of donors... [20:10:24] FIRING: [2x] SSLExpiryEndpoint: SSL expiry critical payments-wiki-hp expires in -20656.84004534722 days - https://alerts.wikimedia.org/?q=alertname%3DSSLExpiryEndpoint [20:14:28] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 07fr-combowiki: Add localisation strings in combo wiki - https://phabricator.wikimedia.org/T432914 (10Damilare) 03NEW [20:15:24] FIRING: [3x] SSLExpiryEndpoint: SSL expiry critical payments-wiki-hp expires in -20656.842823125 days - https://alerts.wikimedia.org/?q=alertname%3DSSLExpiryEndpoint [20:34:13] uh ^ [20:35:24] RESOLVED: [3x] SSLExpiryEndpoint: SSL expiry critical payments-wiki-hp expires in -20656.854628680554 days - https://alerts.wikimedia.org/?q=alertname%3DSSLExpiryEndpoint [20:53:36] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/SmashPig into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1314113 [20:56:19] (03PS1) 10Eileen: Updgrade brick/math [wikimedia/fundraising/SmashPig/vendor] - 10https://gerrit.wikimedia.org/r/1314114 [20:56:34] (03PS2) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/SmashPig into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1314113 [20:58:53] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/SmashPig into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1314113 (owner: 10Eileen) [20:59:21] (03CR) 10Eileen: [V:03+2 C:03+2] Updgrade brick/math [wikimedia/fundraising/SmashPig/vendor] - 10https://gerrit.wikimedia.org/r/1314114 (owner: 10Eileen) [20:59:24] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/SmashPig into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1314113 (owner: 10Eileen) [20:59:34] FIRING: DiskSpace: Disk space WARNING for (instance fran2001.frack.codfw.wmnet:9100):/ - https://alerts.wikimedia.org/?q=alertname%3DDiskSpace [20:59:49] (03PS2) 10Eileen: Update Chariot Saved search from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313561 [21:00:31] (03PS2) 10Eileen: Update Chariot form from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313569 [21:02:39] (03PS2) 10Eileen: Improve manual review message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313549 [21:02:59] (03CR) 10Eileen: Improve manual review message (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313549 (owner: 10Eileen) [21:03:19] (03PS2) 10Eileen: Set banking_institution for every.org [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313627 (https://phabricator.wikimedia.org/T428009) [21:15:12] cstone do you have a few min to review this fix for the 'Cash' dlocal payments that should be pix? [21:15:15] https://gerrit.wikimedia.org/r/1314049 [21:15:22] actually lemme smoke test that [21:15:41] I guess with a dummy message on the queue [21:30:19] (03CR) 10Lars SG: [C:03+2] Improve manual review message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313549 (owner: 10Eileen) [21:36:42] !log SmashPig upgraded from 6921d862 to 038018d4 [21:36:43] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:38:05] !log SmashPig upgraded from 6921d862 to 038018d4 [21:38:06] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:38:45] sure ejegg [21:43:21] One more minor chariot patch & then I'll get them out there https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1313627 [21:53:06] (03Merged) 10jenkins-bot: Improve manual review message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313549 (owner: 10Eileen) [22:07:21] (03CR) 10Eileen: [C:03+2] Map cash/pix to Bank Transfer: Pix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1314049 (https://phabricator.wikimedia.org/T432872) (owner: 10Ejegg) [22:10:11] (03PS3) 10Eileen: Do not create zero amount contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313568 (https://phabricator.wikimedia.org/T432803) [22:19:31] (03PS1) 10Lars SG: Add last OTG amount change and date [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1314118 (https://phabricator.wikimedia.org/T431854) [22:21:03] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Add last otg amount change fields to Acoustic export - https://phabricator.wikimedia.org/T431854#12148209 (10Lars) [22:21:33] 03Fundraising Sprint: Mediocre Ikea Kit, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Add last otg amount change fields to Acoustic export - https://phabricator.wikimedia.org/T431854#12148213 (10Lars) Will still need a backfill patch as well. [22:22:24] (03PS6) 10Lars SG: Add existing PG - Commitment Activity type and custom field group from prod to managed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311932 (https://phabricator.wikimedia.org/T430012) [22:24:29] (03Merged) 10jenkins-bot: Map cash/pix to Bank Transfer: Pix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1314049 (https://phabricator.wikimedia.org/T432872) (owner: 10Ejegg) [22:24:59] Not sure why this patch has no one listed as reviewers, but it should be a quick review, just adding existing activity type and custom fields from prod to mgds so we'll have them locally: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1311932 [22:29:34] (03CR) 10Eileen: [C:03+2] Add existing PG - Commitment Activity type and custom field group from prod to managed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311932 (https://phabricator.wikimedia.org/T430012) (owner: 10Lars SG) [22:29:58] thanks eileen [22:30:09] no worries - can you +2 this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1313627 [22:30:46] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313561 (owner: 10Eileen) [22:30:57] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313569 (owner: 10Eileen) [22:31:33] jenkins totally on it's own time frames today [22:32:40] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1314119 [22:32:50] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1314119 (owner: 10Eileen) [22:32:54] thanks eileen ! [22:33:09] for the deploy? [22:33:55] (03PS3) 10Eileen: Set banking_institution for every.org [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313627 (https://phabricator.wikimedia.org/T428009) [22:33:56] (03CR) 10Ejegg: [C:03+2] Set banking_institution for every.org [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313627 (https://phabricator.wikimedia.org/T428009) (owner: 10Eileen) [22:34:12] eileen: for the C+2 on the Pix fix too [22:34:23] hoping that backfill doesn't take too long [22:35:09] !log civicrm upgraded from 5a04e8a9 to 068b2e3c [22:35:10] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [22:35:15] oh right - I can run it I think [22:40:57] (03CR) 10Cstone: [C:03+2] Set banking_institution for every.org [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313627 (https://phabricator.wikimedia.org/T428009) (owner: 10Eileen) [22:43:32] (03CR) 10Cstone: [C:03+2] Update Chariot form from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313569 (owner: 10Eileen) [22:46:58] (03Merged) 10jenkins-bot: Add existing PG - Commitment Activity type and custom field group from prod to managed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311932 (https://phabricator.wikimedia.org/T430012) (owner: 10Lars SG) [22:47:55] (03PS1) 10Ejegg: Only assign valid UUIDs to gravy buyer_id [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1314123 (https://phabricator.wikimedia.org/T431327) [22:48:24] (03CR) 10CI reject: [V:04-1] Only assign valid UUIDs to gravy buyer_id [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1314123 (https://phabricator.wikimedia.org/T431327) (owner: 10Ejegg) [22:54:45] (03PS2) 10Ejegg: Only assign valid UUIDs to gravy buyer_id [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1314123 (https://phabricator.wikimedia.org/T431327) [22:54:59] (03CR) 10Eileen: [V:03+2] "Putting back v+2 - jenkins seems to have lost the will to live today" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313568 (https://phabricator.wikimedia.org/T432803) (owner: 10Eileen) [22:56:01] oh man, yeah, gate-n-submit is vv slow with this one too: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1313627 [22:56:41] ejegg: I think wenjun was maybe trying to do the same thing with this patch but it wasnt working as she expected https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1309698 [22:57:01] we were trying to test it on friday but my local setup was broken then so didnt get a test transaction through [22:59:52] oh yeah, validation level might be a good place for it [23:01:26] hmm, yeah, at some level that's not getting passed back [23:01:29] let me look [23:04:15] cstone: yeah, that should have caused the same test fails I got in PS1 if it was really filtering stuff out [23:04:39] (03Merged) 10jenkins-bot: Set banking_institution for every.org [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1313627 (https://phabricator.wikimedia.org/T428009) (owner: 10Eileen) [23:11:18] cstone: oh yeah, the parent validateCreatePaymentInput is not being passed its argument by reference [23:11:47] so whatever other mutation was being attempted in validateRecurringCreatePaymentInput has also been failing [23:16:28] huh, if i fix that to pass-by-ref I only get 2 test failures vs the 3 from the fix in my PS1 of a little while ago [23:17:07] VenmoPaymentProviderTest::testSuccessfulCreatePaymentFromTokenNoCreateDonorNoGetDonor [23:17:14] is the difference [23:18:28] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1314126 [23:22:20] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unset or unmapped payment_submethod for dlocal via gravy results in incorrect payment method = cash in Civi - https://phabricator.wikimedia.org/T432872#12148361 (10Ejegg) This is fixed and the data is backfilled [23:23:16] (03PS1) 10Ejegg: Fix validator mutation for buyer_id and names [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1314127 (https://phabricator.wikimedia.org/T431327) [23:23:31] cstone: ^^^ should trigger those fails [23:23:45] (03CR) 10CI reject: [V:04-1] Fix validator mutation for buyer_id and names [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1314127 (https://phabricator.wikimedia.org/T431327) (owner: 10Ejegg) [23:23:50] I'll update the tests to pass a real UUID in one place and a fake one in the other [23:24:45] ack, gotta run. Might be on again later, if not will fix it tomorrow [23:56:01] (03PS1) 10Dmiranda: Updated recurring_contribution.test.js to as close as 100% as currently possible [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1314130 (https://phabricator.wikimedia.org/T429516)