[01:09:56] FIRING: [2x] NodeDown: Node frdb2004 is down. - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [01:14:56] RESOLVED: [2x] NodeDown: Node frdb2004 is down. - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [07:36:41] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354304 (owner: 10L10n-bot) [07:48:44] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354304 (owner: 10L10n-bot) [08:09:00] (03CR) 10Laurabarluzzi: "@ejegg@ejegg.com I agree with ideally extracting some code logic here; do you have already an action plan on how to tackle it? I have idea" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1353438 (https://phabricator.wikimedia.org/T439938) (owner: 10Laurabarluzzi) [08:20:12] (03CR) 10Laurabarluzzi: [C:04-1] "@cstone@wikimedia.org sounds good. A thought that came to mind just now is that technically you could add `country` in the `Donate::FIELD" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1349501 (https://phabricator.wikimedia.org/T437335) (owner: 10Cstone) [09:05:42] (03PS1) 10Laurabarluzzi: Remove unused message key from comboWiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354378 (https://phabricator.wikimedia.org/T439191) [09:06:40] (03CR) 10Laurabarluzzi: ComboWiki: show donor fields per country and payment method configurations (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1353438 (https://phabricator.wikimedia.org/T439938) (owner: 10Laurabarluzzi) [09:42:04] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove old audience framework segment & status - https://phabricator.wikimedia.org/T432597#12420942 (10MSuijkerbuijk_WMF) Yes I understand that we cannot mix both frameworks. The date criteria solution can work - @NNg... [10:20:31] (03CR) 10Laurabarluzzi: [C:04-1] "I think this logic could be simplified and ideally should be moved to their backend classes such as `DataIntegrator` and `DataNormalizer->" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1351776 (https://phabricator.wikimedia.org/T440257) (owner: 10Cstone) [11:22:15] (03CR) 10Laurabarluzzi: [C:04-1] Handle amount and preSelect passed through url (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1351776 (https://phabricator.wikimedia.org/T440257) (owner: 10Cstone) [11:30:45] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Implement 3DS redirect, it's currently going to payments - https://phabricator.wikimedia.org/T439623#12421284 (10Laurabarluzzi) @jgleeson is there a reason why this phab is still under the review column... [11:31:30] laura: I moved that one to done a lil bit before your message [11:31:41] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Implement 3DS redirect, it's currently going to payments - https://phabricator.wikimedia.org/T439623#12421291 (10Laurabarluzzi) @jgleeson You moved it as I was writing the comment LOL I see it's now in... [11:31:47] ha [11:31:51] Yeah I just saw LOL bad timining [11:31:55] *timing [11:32:39] I was trying to review anything still in the sprint review column [11:33:55] ty [11:35:05] (03CR) 10Damilare Adedoyin: [C:03+2] Remove unused message key from comboWiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354378 (https://phabricator.wikimedia.org/T439191) (owner: 10Laurabarluzzi) [11:36:41] btw if you are workingo locally on combowiki you should rebase master since a big patch that affects a lot the frontend has been merged (formFields dynamically set from configuration files) [11:36:59] (03Merged) 10jenkins-bot: Remove unused message key from comboWiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354378 (https://phabricator.wikimedia.org/T439191) (owner: 10Laurabarluzzi) [11:45:00] thanks laura [11:48:02] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Support autocomplete in Combowiki - https://phabricator.wikimedia.org/T439300#12421375 (10Laurabarluzzi) @Ejegg can you clarify which input fields have autocomplete in the current flow but ne... [12:30:33] 10Fundraising Payments token migration 2026, 06Fundraising-Backlog: Check on adyen ideal Contract not found recurring failures - https://phabricator.wikimedia.org/T440419#12421547 (10Damilare) The underlying issue has been resolved and the affected tokens have been successfully charged. [12:30:58] 10Fundraising Payments token migration 2026, 06Fundraising-Backlog: Check on adyen ideal Contract not found recurring failures - https://phabricator.wikimedia.org/T440419#12421551 (10Damilare) 05Open→03Resolved a:03Damilare [12:31:35] 10Fundraising Payments token migration 2026, 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-current-sprint, 07payments-orchestration: Recurring Token Migrate - Adyen ACH - https://phabricator.wikimedia.org/T418762#12421562 (10Damilare) a:05Damilare→03None [12:31:41] 10Fundraising Payments token migration 2026, 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-current-sprint, 07payments-orchestration: Recurring Token Migration - Adyen SEPA - https://phabricator.wikimedia.org/T418761#12421565 (10Damilare) a:05Damilare→03None [12:31:48] 10Fundraising Payments token migration 2026, 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-current-sprint, 07payments-orchestration: Recurring Token Migrate - Adyen Ideal - https://phabricator.wikimedia.org/T432725#12421566 (10Damilare) a:05Damilare→03None [12:41:48] 10Fundraising Payments token migration 2026, 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-current-sprint, 07payments-orchestration: Recurring Token Migrate - Adyen ACH - https://phabricator.wikimedia.org/T418762#12421619 (10Damilare) For the Adyen ACH and SEPA tokens, Gravy changed thei... [12:42:18] 10Fundraising Payments token migration 2026, 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-current-sprint, 07payments-orchestration: Recurring Token Migration - Adyen SEPA - https://phabricator.wikimedia.org/T418761#12421621 (10Damilare) For the Adyen ACH and SEPA tokens, Gravy changed t... [12:42:29] 10Fundraising Payments token migration 2026, 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-current-sprint, 07payments-orchestration: Recurring Token Migrate - Adyen Ideal - https://phabricator.wikimedia.org/T432725#12421622 (10Damilare) For the Adyen ACH and SEPA tokens, Gravy changed th... [12:55:42] 10Fundraising Payments token migration 2026, 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-current-sprint, and 2 others: Recurring Token Migrate - Adyen CC - https://phabricator.wikimedia.org/T418759#12421665 (10Damilare) According to Adyen’s response to my last email, it appears that some... [13:11:35] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Field validation for combowiki - https://phabricator.wikimedia.org/T439286#12421717 (10Laurabarluzzi) I think that partly this has been setup with the merging of https://gerrit.wikimedia.org/... [13:59:57] thanks for the note laura - I've been reading into https://doc.wikimedia.org/codex/main/style-guide/constructing-forms.html#validation and it looks like we might have to rework our disabled-by-default submit button as part of this [14:01:34] specifically https://usercontent.irccloud-cdn.com/file/9q4vYua4/image.png [14:02:56] be back later [14:10:15] Yep.. I know it's a conflict design choice. If designers were ok with it we could add help-text on all fields that require a specific 'validation text'; so we could keep the form diabled until is valid behind the scene and have (optional) for optional field (already shown with codex if we add the tag and for more details info on the required field, if any, we could add an help-text like "This should be formatted like [14:10:15] XXX" [14:36:02] (03PS1) 10Damilare Adedoyin: DonateWiki: Add tests for components and views [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) [16:07:39] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13), and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12422462 (10Pcoombe) Thanks @Ejegg, I... [17:04:00] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: suggest email corrections (Mailcheck) like the legacy forms - https://phabricator.wikimedia.org/T440906 (10jgleeson) 03NEW [17:27:23] (03Abandoned) 10SarthakSingh2904: Filter out forbidden countries from country drop down [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1353470 (https://phabricator.wikimedia.org/T440661) (owner: 10SarthakSingh2904) [17:27:45] (03Abandoned) 10SarthakSingh2904: combowiki: reset payment method when not supported by frequency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1353484 (https://phabricator.wikimedia.org/T440640) (owner: 10SarthakSingh2904) [17:50:35] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1354515 [17:52:10] (03CR) 10Jgleeson: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1354515 (owner: 10Jgleeson) [17:53:23] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1354515 (owner: 10Jgleeson) [17:54:57] (03PS1) 10Jgleeson: Update SmashPig to v1.2.7 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1354517 [18:01:44] (03CR) 10Jgleeson: [C:03+2] Update SmashPig to v1.2.7 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1354517 (owner: 10Jgleeson) [18:06:00] I'll hold off on deploying that until tomorrow ^ as we have no US cover on hand if anything unexpectedly breaks after the European contingent logs off. [18:08:19] (03Merged) 10jenkins-bot: Update SmashPig to v1.2.7 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1354517 (owner: 10Jgleeson) [18:13:33] thanks jgleeson [18:16:12] 👍 [18:49:50] (03PS1) 10Jgleeson: Refactor: Extract prepareDonationDetails() in Special:Donate [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354530 [18:49:50] (03PS1) 10Jgleeson: Refactor: Rename $dataObject to $donationDetails in Special:Donate [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354531 [18:49:50] (03PS1) 10Jgleeson: Refactor: Inline request and config locals in prepareDonationDetails() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354532 [18:49:51] (03PS1) 10Jgleeson: Restructure: Move DataIntegrator work out of its constructor [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354533 [18:49:52] (03PS1) 10Jgleeson: Refactor: Rename $dataObject to $donationDetails in DataIntegrator [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354534 [18:50:33] (03PS1) 10Damilare Adedoyin: Use sentence case for monthly convert responses [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354535 [18:54:43] laurabar: I've reworked the DonationDetails preparation code in Special:Donate so it all lives in one prepareDonationDetails() method, and made some small changes to DataIntegrator. Its constructor used to fill in the donation details as a side effect, so I’ve made the flow more explicit to help readability. [18:55:20] I'll tag you on the patches and add some more info [18:57:03] (03CR) 10Jgleeson: "@lbarluzzi@wikimedia.org I've reworked the DonationDetails preparation code in Special:Donate so it all lives in one prepareDonationDetail" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354533 (owner: 10Jgleeson) [19:05:13] catch you all tomorrow [19:12:16] (03PS1) 10Damilare Adedoyin: Fix opt in value sent to API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354539 [19:13:08] (03PS1) 10Damilare Adedoyin: Use 'input-type=email' for cdx-text-input email fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354540 [19:20:02] (03PS1) 10Damilare Adedoyin: Fix Clearable should be of type boolean and onBlur is undefined in CountrySelector [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354545 [19:27:56] (03CR) 10Laurabarluzzi: [C:03+2] "While testing I am also fixing console warnings and I had this in my local branch" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354545 (owner: 10Damilare Adedoyin) [19:29:42] (03CR) 10Laurabarluzzi: [C:03+2] Use 'input-type=email' for cdx-text-input email fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354540 (owner: 10Damilare Adedoyin) [19:31:11] (03CR) 10Laurabarluzzi: [C:03+2] "I approve because I never saw 'yes' as a value for this and can be restored easily if an error is found. I wonder why it was checked again" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354539 (owner: 10Damilare Adedoyin) [19:31:27] (03CR) 10Laurabarluzzi: [C:03+2] Use sentence case for monthly convert responses [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354535 (owner: 10Damilare Adedoyin) [19:32:42] ahh thanks laurabar, the optIn select value used to be "Yes" and "No" and then its checked in the api to 1 and 0. [19:33:02] (03Merged) 10jenkins-bot: Use sentence case for monthly convert responses [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354535 (owner: 10Damilare Adedoyin) [19:33:03] (03Merged) 10jenkins-bot: Fix opt in value sent to API [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354539 (owner: 10Damilare Adedoyin) [19:33:03] (03Merged) 10jenkins-bot: Use 'input-type=email' for cdx-text-input email fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354540 (owner: 10Damilare Adedoyin) [19:33:06] (03Merged) 10jenkins-bot: Fix Clearable should be of type boolean and onBlur is undefined in CountrySelector [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354545 (owner: 10Damilare Adedoyin) [19:33:10] But the server returns 1 and 0, so it was difficult for prefilling [19:33:52] making the adjustments I'm seeing from issues that arose when writing the tests in my WIP patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1354465 [19:34:02] thanks for all the review [19:38:04] (03PS1) 10Laurabarluzzi: QA: remove console warning for missing label for and input id matching [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354547 (https://phabricator.wikimedia.org/T439191) [19:46:08] (03PS11) 10Damilare Adedoyin: DonateWiki: Add tests for components and views [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) [19:50:03] (03PS2) 10Laurabarluzzi: QA: remove console warning for missing label for and input id matching [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354547 (https://phabricator.wikimedia.org/T439191) [19:55:33] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for the fix, this patch LGTM. I'm also wondering how we can get the card icon to show in the card field like on the payments form u" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354547 (https://phabricator.wikimedia.org/T439191) (owner: 10Laurabarluzzi) [19:57:06] (03Merged) 10jenkins-bot: QA: remove console warning for missing label for and input id matching [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354547 (https://phabricator.wikimedia.org/T439191) (owner: 10Laurabarluzzi) [20:02:34] (03PS1) 10Laurabarluzzi: QA: fix warning in console for employer field and correctly capture API errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354548 (https://phabricator.wikimedia.org/T439191) [20:06:17] (03PS2) 10Laurabarluzzi: QA: fix warning in console for employer field and correctly capture API errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354548 (https://phabricator.wikimedia.org/T439191) [20:10:43] (03PS3) 10Laurabarluzzi: QA: fix warning in console for employer field and correctly capture API errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354548 (https://phabricator.wikimedia.org/T439191) [20:47:15] (03PS1) 10Laurabarluzzi: QA: stop sms-optin failed to resolve component warning [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354550