[02:34:15] 06Fundraising-Backlog, 10FR-dlocal, 10FR-Smashpig: Investigate dlocal wallet cancelation IPNs - https://phabricator.wikimedia.org/T440926 (10Ejegg) 03NEW [07:21:18] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: When you click around on the page there's a JS error in the console - https://phabricator.wikimedia.org/T440261#12423735 (10Laurabarluzzi) @Cstone I'm pretty sure this isn't related to combo wiki so I'm closing it. The reasons are: 1. `contentScript` is common... [07:22:15] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-combowiki, 07fr-current-sprint: Combowiki: When you click around on the page there's a JS error in the console - https://phabricator.wikimedia.org/T440261#12423748 (10Laurabarluzzi) a:03Laurabarluzzi [07:24:05] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: error handling check - https://phabricator.wikimedia.org/T437542#12423761 (10Laurabarluzzi) a:03Laurabarluzzi [07:36:51] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: error handling check - https://phabricator.wikimedia.org/T437542#12423795 (10Laurabarluzzi) [08:59:42] 06Fundraising-Analysis, 06Fundraising-Backlog, 06Data-Platform-SRE (2026-10-09 - 2026-10-30), 07Essential-Work: Upgrade airflow-fr-tech to 3.3.x - https://phabricator.wikimedia.org/T435479#12424007 (10atsuko) Sure, let's wait! [09:34:25] (03CR) 10Laurabarluzzi: [C:03+2] Refactor: Extract prepareDonationDetails() in Special:Donate [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354530 (owner: 10Jgleeson) [09:35:33] (03CR) 10Laurabarluzzi: [C:03+2] Refactor: Rename $dataObject to $donationDetails in Special:Donate [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354531 (owner: 10Jgleeson) [09:35:48] (03Merged) 10jenkins-bot: Refactor: Extract prepareDonationDetails() in Special:Donate [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354530 (owner: 10Jgleeson) [09:36:21] (03CR) 10Laurabarluzzi: [C:03+2] Refactor: Inline request and config locals in prepareDonationDetails() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354532 (owner: 10Jgleeson) [09:36:56] (03Merged) 10jenkins-bot: Refactor: Rename $dataObject to $donationDetails in Special:Donate [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354531 (owner: 10Jgleeson) [09:37:46] (03Merged) 10jenkins-bot: Refactor: Inline request and config locals in prepareDonationDetails() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354532 (owner: 10Jgleeson) [09:38:22] thanks laurabar ! [09:38:31] I'll see if I can fix that merge conflict [09:43:19] (03PS2) 10Jgleeson: Restructure: Move DataIntegrator work out of its constructor [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354533 [09:43:36] (03PS2) 10Jgleeson: Refactor: Rename $dataObject to $donationDetails in DataIntegrator [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354534 [09:43:43] (03CR) 10Laurabarluzzi: [C:03+2] "Copied votes on follow-up patch sets have been updated:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354533 (owner: 10Jgleeson) [09:43:53] (03CR) 10CI reject: [V:04-1] Restructure: Move DataIntegrator work out of its constructor [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354533 (owner: 10Jgleeson) [09:44:23] (03CR) 10Laurabarluzzi: [C:03+2] Refactor: Rename $dataObject to $donationDetails in DataIntegrator [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354534 (owner: 10Jgleeson) [09:45:53] (03Merged) 10jenkins-bot: Restructure: Move DataIntegrator work out of its constructor [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354533 (owner: 10Jgleeson) [09:45:55] (03Merged) 10jenkins-bot: Refactor: Rename $dataObject to $donationDetails in DataIntegrator [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354534 (owner: 10Jgleeson) [09:54:03] laurabar: how do you test the sms_optin for your patch? [09:54:57] I'm passing the parameter in the url but it isn't coming up again [09:56:53] (03PS1) 10Laurabarluzzi: QA: cast employer search ids to Number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354746 [10:04:34] I normally added &variant=SmsOptin, I'm going to test it again (I have many small patches so maybe I got confused) [10:04:46] can you first try reloading with &debug=1 on the page? [10:05:47] thanks, let me try th variant [10:06:28] mm it's not showing now, yesterday it did. I wonder if it can be a cache problem [10:06:59] ok I see it now, thanks [10:07:04] it's probably the case [10:07:28] this is the link that worked for me: https://localhost:9001/index.php?title=Special:Donate&payment_method=cc&recurring=0&language=en¤cy=USD&amount=35&country=US&debug=true&variant=smsOptin [10:11:33] I think that another thing that can come into play is if a wrong 'variant' is types at any point (e.g. once I capitalized SmsOptin) and the variant might have been stored in session. [10:11:36] I just noticed the config has sms_opt_in optional only in the US [10:11:59] Yeah, you need to put &country=US; you see in other countries? [10:12:08] damilare: did you add in that scroll-to/focus to employer field? [10:12:37] I wonder if we could focus to the top of the payment method if the field is above the fold [10:13:09] as we're currently hiding the gift matrix on load [10:13:51] right laurabar, we can probably make it case insensitive by just making it all lower case. Also you're right it only shows in US [10:14:20] if you click this link with an empty session, it scrolls to the employer field, even though no amount is set https://localhost:9001/index.php?title=Special:Donate&payment_method=cc&recurring=0&language=en¤cy=USD&country=US&debug=true&variant=smsOptin [10:14:29] jgleeson: yes it was suppose to be the first empty input field and it should start from the label. [10:14:31] Both employer + sms fields now should show up only for country=US this was enforced by my patch that translated country_fields.yaml + payment_methods.yaml fields overrides automatically wired to the frontend [10:15:14] jgleeson: that link sets the amount to 35 though [10:15:22] RE: autoscroll; while using it I thought that maybe the first required empty field should be focused instead? [10:15:23] clear your session [10:15:34] no amount in the URL [10:16:09] *required* instead of optional I mean [10:16:23] oh I see, ok jgleeson, the amount is set to 0.00 [10:16:53] let me see if that can be fixed [10:17:11] damilare: so if you arrive here with no session, it jumps straight to employer https://localhost:9001/index.php?title=Special:Donate [10:17:11] otherwise, I think we can do without it for now [10:17:27] yeah it might need some throught from a UX perspecitve [10:17:31] thought* [10:17:38] possibly ramon and others [10:17:45] Re: amount -- I noticed a thing today that since the payment method card form is automatically shown its validation doesn't check against amount (whcih is normally a requirement to render the payment method form) [10:18:26] yh jgleeson, I think we could have a fixed value and (edit beside it) for prefill. Yh I'd take it out. [10:18:54] how do you mean laurabar? [10:19:39] damilare: visit https://localhost:9001/index.php?title=Special%3ADonate&country=US and go straight to fill our your card details. You can press 'submit' without the amount being set. [10:20:51] It's not the overall expected beahvior in the app, since normally the payment method buttons are disabled until the amount is selected; the gotcha is that we render the Card component automatically on page load so it's internal validation (for the Card fields) do not check for amount (which is expected to be set already as a prerequisite) [10:21:24] ok I see, we are yet to add validations to the overall form too [10:22:56] yeah, this is why I didn't make a change yet; wanted to flat it. However we already show the general app error here but we could at least disable the submit button if the amount isn't chosen (like the other payment method). [10:23:26] *flag it [10:23:32] damilare: I'm working on validations now https://phabricator.wikimedia.org/T439286 [10:23:57] jgleeson: do you want me to flag this behavior on the phab or it is already under your radar? [10:24:04] sounds good laurabar jgleeson [10:24:44] it's worth noting laurabar just to make sure I test against it [10:24:53] feel free to paste your IRC chat on the ticket [10:24:57] ty [10:25:45] after reading https://doc.wikimedia.org/codex/main/style-guide/constructing-forms.html#validation and https://doc.wikimedia.org/codex/main/style-guide/using-links-and-buttons.html#group-of-buttons I'm thinking we might stop disabling the submit button by default [10:25:51] and rely on validation [10:26:11] to follow codex recommendations [10:26:35] +1 [10:26:52] disabling would have the user confused on what could have gone wrong [10:27:06] validation should show a useful error [10:28:29] (03PS1) 10Damilare Adedoyin: Disable auto scroll feature [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354758 [10:28:35] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Field validation for combowiki - https://phabricator.wikimedia.org/T439286#12424395 (10jgleeson) After reading https://doc.wikimedia.org/codex/main/style-guide/constructing-forms.html#validat... [10:29:36] (03CR) 10Damilare Adedoyin: [C:03+2] QA: cast employer search ids to Number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354746 (owner: 10Laurabarluzzi) [10:31:05] (03PS2) 10Damilare Adedoyin: Disable auto scroll feature [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354758 (https://phabricator.wikimedia.org/T439191) [10:31:06] (03Merged) 10jenkins-bot: QA: cast employer search ids to Number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354746 (owner: 10Laurabarluzzi) [10:31:20] (03PS12) 10Damilare Adedoyin: DonateWiki: Add tests for components and views [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) [10:31:41] (03PS2) 10Laurabarluzzi: QA: stop sms-optin failed to resolve component warning [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354550 [10:32:15] 14Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Field validation for combowiki - https://phabricator.wikimedia.org/T439286#12424433 (10Laurabarluzzi) Behavior observed today: - visit https://localhost:9001/index.php?title=Special%3ADonate... [10:32:55] !log payments-wiki upgraded from c9b9e05c to da1d88b6 [10:32:56] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [10:33:10] (03CR) 10CI reject: [V:04-1] DonateWiki: Add tests for components and views [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) (owner: 10Damilare Adedoyin) [10:35:20] jgleeson: I agree with the validation per field strategy as well; we already have all the validation messages already available from donate/payment and I think it's a more accessible experience because we clearly communicate what needs to be fixed "to enable the flow" [10:49:18] 👍 [10:49:46] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks @lbarluzzi@wikimedia.org! This looks good to me, this is similar to the initial setup. Perhaps when we have multiple Variant fields" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354550 (owner: 10Laurabarluzzi) [10:51:11] (03Merged) 10jenkins-bot: QA: stop sms-optin failed to resolve component warning [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354550 (owner: 10Laurabarluzzi) [10:55:03] laurabar: merge conflict on your employer field patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1354548 [10:59:40] (03PS13) 10Damilare Adedoyin: DonateWiki: Add tests for components and views [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) [11:01:04] (03CR) 10CI reject: [V:04-1] DonateWiki: Add tests for components and views [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) (owner: 10Damilare Adedoyin) [11:07:00] (03PS14) 10Damilare Adedoyin: DonateWiki: Add tests for components and views [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) [11:49:11] I don't see conflicts in this patch 🤔 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1354548 [11:51:38] Interesting; the preview of patches shows there is a merge conflict but if I open the patch it shows active without merge conflicts [12:01:54] (03PS4) 10Laurabarluzzi: QA: fix warning in console for employer field and correctly capture API errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354548 (https://phabricator.wikimedia.org/T439191) [12:36:41] (03CR) 10Laurabarluzzi: [C:04-1] "Looks good, I just would like to not report donorPortal coverage when we do run combowiki test. I think we can easily achieve that by tidy" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) (owner: 10Damilare Adedoyin) [13:03:11] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Restore combowiki form field values from session - https://phabricator.wikimedia.org/T440476#12425146 (10Laurabarluzzi) Maybe similar to this, although larger in scope: https://phabricator.wikimedia.org/T440877 [13:16:32] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki, 13Patch-For-Review: Make ComboWiki input fields more composable / minimize mapping names back and forth - https://phabricator.wikimedia.org/T439302#12425212 (10Laurabarluzzi) @Ejegg @jgleeson I think I have had an idea about t... [13:24:28] (03PS1) 10Laurabarluzzi: Centrilize app error handling [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354788 (https://phabricator.wikimedia.org/T437542) [13:32:42] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki, 13Patch-For-Review: Make ComboWiki input fields more composable / minimize mapping names back and forth - https://phabricator.wikimedia.org/T439302#12425311 (10jgleeson) @Laurabarluzzi The work I'm doing in {T439286} touches t... [13:36:10] (03CR) 10Jgleeson: Centrilize app error handling (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354788 (https://phabricator.wikimedia.org/T437542) (owner: 10Laurabarluzzi) [13:38:15] (03CR) 10Laurabarluzzi: Centrilize app error handling (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354788 (https://phabricator.wikimedia.org/T437542) (owner: 10Laurabarluzzi) [13:51:35] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13), and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12425383 (10Ejegg) Yes @MLechvien-WMF... [13:53:11] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13), and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12425391 (10Ejegg) And yes @pcoombe t... [13:54:32] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13), and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12425400 (10CDanis) The "Get-with-set... [13:57:59] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13), and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12425408 (10Ejegg) Thanks for the lin... [14:14:54] 06Fundraising-Backlog, 10FR-Paypal, 07payments-orchestration: Gr4vy PayPal recurrings failing with insufficient_service_permissions - https://phabricator.wikimedia.org/T440984 (10Ejegg) 03NEW [14:34:06] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354808 [14:34:58] (03PS1) 10Lars SG: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1354809 [14:37:18] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354808 (owner: 10Lars SG) [14:37:26] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1354809 (owner: 10Lars SG) [14:37:52] (03Merged) 10jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1354809 (owner: 10Lars SG) [14:38:13] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354808 (owner: 10Lars SG) [14:41:40] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12425678 (10Lars) @Dwisehaupt can you do this on silverpop: ` ALTER TABLE silverpop_export_latest ADD COLUMN latest_cy_native_total D... [14:48:01] !log civicrm upgraded from 02ccc9c7 to 69a87c76 [14:48:02] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [15:15:32] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki, 13Patch-For-Review: Make ComboWiki input fields more composable / minimize mapping names back and forth - https://phabricator.wikimedia.org/T439302#12425853 (10Laurabarluzzi) @jgleeson Sure thing, I'm not working on this. I ju... [15:20:27] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Change text in 1st and 2nd recurring failure emails when donor didn't give via card - https://phabricator.wikimedia.org/T440991 (10Lars) 03NEW [15:21:52] 06Fundraising-Backlog, 07fr-combowiki: Combowiki return from redirect on monthly donation shows monthly convert - https://phabricator.wikimedia.org/T440765#12425906 (10Laurabarluzzi) a:03Laurabarluzzi [15:26:46] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: Write a TestKitchen mixin for CentralNotice - https://phabricator.wikimedia.org/T440992 (10Ejegg) 03NEW [15:35:19] 06Fundraising-Backlog, 07fr-combowiki: Combowiki return from redirect on monthly donation shows monthly convert - https://phabricator.wikimedia.org/T440765#12426033 (10Laurabarluzzi) a:05Laurabarluzzi→03None [15:39:44] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: Write a TestKitchen mixin for CentralNotice - https://phabricator.wikimedia.org/T440992#12426049 (10Ejegg) [15:39:50] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Epic, 13Patch-For-Review: Multi-arm bandit support for fundraising campaigns - https://phabricator.wikimedia.org/T422045#12426050 (10Ejegg) [15:40:25] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen, 07Epic: Multi-arm bandit support for fundraising campaigns - https://phabricator.wikimedia.org/T422045#12426056 (10Ejegg) [15:48:24] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Support autocomplete in Combowiki - https://phabricator.wikimedia.org/T439300#12426147 (10Ejegg) All of the personal info fields should have autocomplete. You can find the correct values for... [15:58:04] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Revisit banner-preview-specific CSP in CentralNotice - https://phabricator.wikimedia.org/T441002 (10Ejegg) 03NEW [16:17:43] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen, 07Epic: [EPIC] Multi-arm bandit support for fundraising campaigns - https://phabricator.wikimedia.org/T422045#12426377 (10JVanderhoop-WMF) [16:18:18] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen, 05Goal: [GOAL] Multi-arm bandit support for fundraising campaigns - https://phabricator.wikimedia.org/T422045#12426384 (10JVanderhoop-WMF) [16:23:09] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen, 05Goal: [GOAL] Multi-arm bandit support for fundraising campaigns - https://phabricator.wikimedia.org/T422045#12426419 (10JVanderhoop-WMF) p:05Triage→03High [17:04:35] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install civi1003 - https://phabricator.wikimedia.org/T441013 (10RobH) 03NEW [17:04:57] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install civi1003 - https://phabricator.wikimedia.org/T441013#12426711 (10RobH) [17:05:44] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install civi1003 - https://phabricator.wikimedia.org/T441013#12426712 (10RobH) a:03Jgreen Jeff, Please double-check and fill out the racking details section of this racking task. Please update the site.pp file with the insetup role for... [17:13:35] !log disabled recurring charge jobs for gr4vy API credential swap [17:13:37] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [17:35:57] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.7.1 => v1.2.7.2) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354844 [17:36:27] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.7.1 => v1.2.7.2) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1354845 [17:37:19] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.7.1 => v1.2.7.2) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1354845 (owner: 10Eileen) [17:37:34] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.7.1 => v1.2.7.2) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354844 (owner: 10Eileen) [17:44:59] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.7.1 => v1.2.7.2) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1354845 (owner: 10Eileen) [17:46:17] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.7.1 => v1.2.7.2) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354844 (owner: 10Eileen) [17:48:56] (03PS1) 10Ejegg: Ignore Cancelled for duplicate charge check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354848 [17:49:36] fr-tech ^^^ is a tiny patch to stop us skipping the same 10 donations at the start of every charge_newer run [17:49:42] oh i need to re-enable jobs [17:50:30] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install civi1003 - https://phabricator.wikimedia.org/T441013#12427024 (10Jgreen) [17:51:04] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install civi1003 - https://phabricator.wikimedia.org/T441013#12427030 (10Jgreen) a:05Jgreen→03None [17:51:11] !log re-enabled recurring charge jobs [17:51:12] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [17:52:47] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install civi1003 - https://phabricator.wikimedia.org/T441013#12427038 (10Jgreen) [17:57:21] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354850 [17:58:06] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354850 (owner: 10Eileen) [17:58:21] (03CR) 10CI reject: [V:04-1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354850 (owner: 10Eileen) [17:59:18] (03CR) 10Eileen: [C:03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354850 (owner: 10Eileen) [17:59:23] (03CR) 10Ejegg: "Needs the vendor submodule update squashed in" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354850 (owner: 10Eileen) [18:00:05] (03PS2) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354850 [18:01:47] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354850 (owner: 10Eileen) [18:02:32] !log civicrm upgraded from 69a87c76 to 39b86907 [18:02:34] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [18:03:13] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12427127 (10Dwisehaupt) Updated: ` MariaDB [silverpop]> describe silverpop_export_latest; +----------------------------------+-------------... [18:05:10] !log tools upgraded from c7be1099 to b8dac67c [18:05:12] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [18:11:12] fr-tech: while working on ComboWiki validation stuff I noticed `trustly_explanation: true` in the `dd` validation block in Gravy's payment_methods.yaml. It isn't a donor field. It's there so the Mustache form sets `trustly_explanation_visible` and shows the Trustly note. Because it's `true`, it also gets treated as a required field, so ComboWiki has to skip it. Should display flags like this live somewhere other than [18:11:13] `validation`? [18:11:36] I'll work around it for now with an ignore flag for it [18:11:48] but I wanted to ask before creating a ticket to change how it works [18:12:06] this; https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/cde911b9e0cbef6c5e7bfac3d0aee9044eb837c6/gravy_gateway/config/payment_methods.yaml#L20 [18:12:49] jgleeson: that definitely seems like a pattern to ditch in combowiki [18:14:46] 👍 [18:21:45] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add AF_recurring_latest_cancel_date to Acoustic export - https://phabricator.wikimedia.org/T441023 (10Lars) 03NEW [18:23:04] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add AF_recurring_latest_cancel_date to Acoustic export - https://phabricator.wikimedia.org/T441023#12427170 (10Lars) [18:27:31] (03PS1) 10Lars SG: Add AF_recurring_latest_cancel_date to Acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1354854 (https://phabricator.wikimedia.org/T441023) [18:30:59] (03PS7) 10Jgleeson: ComboWiki: send client-side field validation rules to the page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354780 (https://phabricator.wikimedia.org/T439286) [18:45:21] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: Disable parsing dlocal from gravy audit files? - https://phabricator.wikimedia.org/T441026 (10Eileenmcnaughton) 03NEW [18:50:24] (03PS1) 10Lars SG: Prevent error if setting is not set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354859 (https://phabricator.wikimedia.org/T386031) [18:51:19] (03CR) 10Eileen: [C:03+2] Prevent error if setting is not set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354859 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [19:00:12] (03Merged) 10jenkins-bot: Prevent error if setting is not set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354859 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [19:07:37] (03PS2) 10Lars SG: Add setting for contacts to exclude from gift coding [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354095 (https://phabricator.wikimedia.org/T386031) [19:07:52] (03CR) 10Lars SG: [C:03+2] "re-applying +2" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354095 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [19:15:37] (03Merged) 10jenkins-bot: Add setting for contacts to exclude from gift coding [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354095 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [19:25:51] (03CR) 10Dmiranda: [C:03+2] "Thanks @ejegg@ejegg.com looks good to me. +2!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354848 (owner: 10Ejegg) [19:26:46] (03CR) 10Dmiranda: [C:03+2] "Thanks @lsandergreen@wikimedia.org looks good to me. Approved!" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1354854 (https://phabricator.wikimedia.org/T441023) (owner: 10Lars SG) [19:29:17] (03Merged) 10jenkins-bot: Add AF_recurring_latest_cancel_date to Acoustic export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1354854 (https://phabricator.wikimedia.org/T441023) (owner: 10Lars SG) [19:34:12] (03Merged) 10jenkins-bot: Ignore Cancelled for duplicate charge check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354848 (owner: 10Ejegg) [19:35:23] thanks danielfm ! [19:35:54] NP ejegg: :) [19:36:47] (03CR) 10Dmiranda: [C:03+1] "Thanks @dadedoyin@wikimedia.org looks good to me! Ill give it the +1 for now but am pretty much ready for the +2 when the merge conflict i" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354758 (https://phabricator.wikimedia.org/T439191) (owner: 10Damilare Adedoyin) [19:38:39] ejegg: daniel +2ed your patch, but there is exactly one that would have been affected in the last 3 years: https://civicrm.wikimedia.org/civicrm/contact/view?cid=33838014 [19:38:46] I think, at least [19:46:30] also, here's an example with a credit card from 2022: https://civicrm.wikimedia.org/civicrm/contact/view?cid=28440398 (Aug 2022 was cancelled as the first donation) [19:48:17] I guess it is OK if we throw an exception if this happens again and we can investigate, since it is rare [19:48:46] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add AF_recurring_latest_cancel_date to Acoustic export - https://phabricator.wikimedia.org/T441023#12427396 (10Lars) @Dwisehaupt one more silverpop alter for this late addition: ` ALTER TABLE silverpop_export ADD... [19:51:01] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354870 [19:52:25] (03PS1) 10Lars SG: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1354871 [19:52:42] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354870 (owner: 10Lars SG) [19:52:49] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1354871 (owner: 10Lars SG) [19:53:18] (03Merged) 10jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1354871 (owner: 10Lars SG) [19:53:28] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1354870 (owner: 10Lars SG) [19:54:38] !log civicrm upgraded from 39b86907 to 76651592 [19:54:40] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [19:55:39] !log tools upgraded from b8dac67c to ccc34c76 [19:55:40] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [19:58:39] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove old audience framework segment & status - https://phabricator.wikimedia.org/T432597#12427423 (10Lars) a:03Lars [19:58:43] (03PS15) 10Damilare Adedoyin: DonateWiki: Add tests for components and views [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) [19:59:42] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add hotkey to open recent items menu - https://phabricator.wikimedia.org/T428831#12427427 (10Lars) [20:00:00] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Redirect to contact in FormBuilder when search results return only one contact - https://phabricator.wikimedia.org/T428304#12427444 (10Lars) [20:01:44] 06Fundraising-Backlog, 07fr-current-sprint, 13Patch-For-Review, 07payments-orchestration: Recurring Token Migrate - Adyen CC - https://phabricator.wikimedia.org/T418759#12427476 (10Damilare) [20:07:52] (03PS3) 10Damilare Adedoyin: Disable auto scroll feature [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354758 (https://phabricator.wikimedia.org/T439191) [20:09:26] (03CR) 10Damilare Adedoyin: "Thanks @lbarluzzi@wikimedia.org for the suggestion and review. I've made the recommended changes." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) (owner: 10Damilare Adedoyin) [20:18:35] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-CentralNotice-Administration, 13Patch-For-Review: Provide a way to display of a banner only to users who reach a certain number of edits - https://phabricator.wikimedia.org/T269758#12427569 (10S... [20:23:49] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add AF_recurring_latest_cancel_date to Acoustic export - https://phabricator.wikimedia.org/T441023#12427579 (10Dwisehaupt) Alter complete. Limiting the output to 15 lines scrolled since it's long. `lines=15 MariaDB [si... [20:28:57] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add AF_recurring_latest_cancel_date to Acoustic export - https://phabricator.wikimedia.org/T441023#12427621 (10Lars) Thanks @Dwisehaupt [20:30:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 06Product Safety and Integrity, and 3 others: The 'centralnoticequerycampaign' API is a DoS vector because campaigns parameter has no item limit - https://phabricator.wikimedia.org/T439968#12427631 (10sbassett... [20:30:26] 06Fundraising-Backlog: Direct Integration testing - https://phabricator.wikimedia.org/T441039 (10Cstone) 03NEW [20:31:18] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 06Product Safety and Integrity, and 4 others: The 'centralnoticequerycampaign' API is a DoS vector because campaigns parameter has no item limit - https://phabricator.wikimedia.org/T439968#12427651 (10sbassett... [20:31:19] 06Fundraising-Backlog: Adyen Checkout Direct Testing - https://phabricator.wikimedia.org/T441040 (10Cstone) 03NEW [20:31:37] 06Fundraising-Backlog: Direct Integration testing - https://phabricator.wikimedia.org/T441039#12427676 (10Cstone) [20:31:38] 06Fundraising-Backlog: Adyen Checkout Direct Testing - https://phabricator.wikimedia.org/T441040#12427675 (10Cstone) [20:31:45] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 06Product Safety and Integrity, and 4 others: The 'centralnoticequerycampaign' API is a DoS vector because campaigns parameter has no item limit - https://phabricator.wikimedia.org/T439968#12427677 (10sbassett) [20:32:38] 06Fundraising-Backlog: Dlocal direct Testing - https://phabricator.wikimedia.org/T441042 (10Cstone) 03NEW [20:33:15] 06Fundraising-Backlog: Dlocal direct Testing - https://phabricator.wikimedia.org/T441042#12427707 (10Cstone) [20:33:17] 06Fundraising-Backlog: Direct Integration testing - https://phabricator.wikimedia.org/T441039#12427708 (10Cstone) [20:36:41] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 06Product Safety and Integrity, and 4 others: CentralNotice: Special:HideBanners can cause very large cookies to be set by CSRF attack from attacker website - https://phabricator.wikimedia.org/T439974#12427770 (... [20:37:07] 06Fundraising-Backlog: Paypal EC Testing - https://phabricator.wikimedia.org/T441047 (10Cstone) 03NEW [20:37:18] 06Fundraising-Backlog: Direct Integration testing - https://phabricator.wikimedia.org/T441039#12427795 (10Cstone) [20:37:19] 06Fundraising-Backlog: Paypal EC Testing - https://phabricator.wikimedia.org/T441047#12427794 (10Cstone) [20:40:04] (03CR) 10Damilare Adedoyin: "Thanks @dmiranda@wikimedia.org for the CR, merge conflict fixed." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354758 (https://phabricator.wikimedia.org/T439191) (owner: 10Damilare Adedoyin) [20:43:50] 06Fundraising-Backlog: Adyen Checkout Direct Testing - https://phabricator.wikimedia.org/T441040#12427834 (10Cstone) [20:43:53] (03CR) 10Damilare Adedoyin: [C:03+1] "Thanks @lbarluzzi@wikimedia.org, I was wondering if in addition to this, we add a debounce to the api request, to prevent the client from " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354548 (https://phabricator.wikimedia.org/T439191) (owner: 10Laurabarluzzi) [20:44:03] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: Write a TestKitchen mixin for CentralNotice - https://phabricator.wikimedia.org/T440992#12427835 (10AnnWF) [21:26:33] 10fundraising-tech-ops, 10FR-Tech-Analytics: Fundraising access request for Kadeem Khan - https://phabricator.wikimedia.org/T440658#12427935 (10Dwisehaupt) [21:28:26] 10fundraising-tech-ops, 10FR-Tech-Analytics: Fundraising access request for Kadeem Khan - https://phabricator.wikimedia.org/T440658#12427937 (10Dwisehaupt) Info added to collab contact page. SSL client cert created and sent via email. Password sent via SMS. Metabase account created and invite sent. ITS request... [21:46:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 05FY26-27 WE5.4 Donor Identification and recognition, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13): Remind me later doesn't work on email flow - https://phabricator.wikimedia.org/T438251#12427974 (10Jdlrobson-WMF) 05Open→03Resolved a:03Jdlrobs... [21:46:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 05FY26-27 WE5.4 Donor Identification and recognition, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13), 13Patch-For-Review: Users that have already consented do not get UI feedback when navigating to ca... - https://phabricator.wikimedia.org/T438248#12427976 [22:07:43] 10fundraising-tech-ops: Fundraising access request for test - https://phabricator.wikimedia.org/T441051 (10Dwisehaupt) 03NEW [22:08:13] 10fundraising-tech-ops: Fundraising access request for test - https://phabricator.wikimedia.org/T441051#12428079 (10Dwisehaupt) 05Open→03Declined Errant test [22:09:09] dwisehaupt: what are we gonna do when Mr/Mrs/Other Toni Est joins? [22:12:54] ha. yeah. i just ran the wrong script when testing. :) [22:13:36] for some bizzare reason, mailto links have started to fail in my setup. so was trying to sort out why. [23:06:45] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13), and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12428375 (10Krinkle) @Pcoombe The cac... [23:19:20] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM: Tracking donor strategies in Civi - https://phabricator.wikimedia.org/T437526#12428448 (10DBautista-WMF) @Lars That's correct, only donors with a relationship manager will have a strategy and only one plan will be in place at... [23:45:35] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM: Tracking donor strategies in Civi - https://phabricator.wikimedia.org/T437526#12428554 (10Lars) @DBautista-WMF That makes it simpler. Do we need to keep past strategies and edits to current strategies visible in the UI someho...