[02:35:20] (03PS1) 10Lars SG: Remove extra spacing between Edit button and main table for custom data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354913 (https://phabricator.wikimedia.org/T386031) [03:02:40] (03CR) 10Dmiranda: [C:03+2] "Thanks @lsandergreen@wikimedia.org, looks good to me. +2! If you need me to review/approve the upstream one as well, feel free to ping me " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354913 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [03:04:15] (03CR) 10Dmiranda: [C:03+1] "Great work @lbarluzzi@wikimedia.org! I am still having some trouble recreating this on my local, but the code looks good to me, so I will " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354548 (https://phabricator.wikimedia.org/T439191) (owner: 10Laurabarluzzi) [03:04:52] (03CR) 10Dmiranda: [C:03+2] "Thanks @dadedoyin@wikimedia.org, LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354758 (https://phabricator.wikimedia.org/T439191) (owner: 10Damilare Adedoyin) [03:06:19] (03Merged) 10jenkins-bot: Disable auto scroll feature [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354758 (https://phabricator.wikimedia.org/T439191) (owner: 10Damilare Adedoyin) [03:11:19] (03Merged) 10jenkins-bot: Remove extra spacing between Edit button and main table for custom data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354913 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [03:45:08] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Support 'mailcheck' in combowiki - https://phabricator.wikimedia.org/T439258#12428731 (10Cstone) [03:45:37] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Support 'mailcheck' in combowiki - https://phabricator.wikimedia.org/T439258#12428738 (10Cstone) [03:45:39] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: suggest email corrections (Mailcheck) like the legacy forms - https://phabricator.wikimedia.org/T440906#12428736 (10Cstone) →14Duplicate dup:03T439258 [04:05:52] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Venmo Validation error during recurring charge, in field: email - https://phabricator.wikimedia.org/T441071 (10dmiranda) 03NEW [04:56:12] (03PS1) 10Cstone: WIP: Start at having default values for the utms and take url paramteters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354916 (https://phabricator.wikimedia.org/T439981) [04:57:31] (03CR) 10CI reject: [V:04-1] WIP: Start at having default values for the utms and take url paramteters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354916 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [06:35:21] (03PS1) 10Eileen: Don't match Adyen fee/adjustment rows to the original donation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354925 [08:36:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13), and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12429419 (10MLechvien-WMF) 05Ope... [09:49:26] (03PS5) 10Laurabarluzzi: QA: fix warning in console for employer field and correctly capture API errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354548 (https://phabricator.wikimedia.org/T439191) [09:55:47] (03CR) 10Laurabarluzzi: "@dmiranda@wikimedia.org on which branch you tried to reproduce it locally? I wonder if maybe you had the `cached` value returning true for" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354548 (https://phabricator.wikimedia.org/T439191) (owner: 10Laurabarluzzi) [13:16:05] (03CR) 10Ejegg: "Thanks for the debounce! I kept planning to get to that... Maybe the reset function could just call updateEmployerIdAndName( 0, '' ) so t" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354548 (https://phabricator.wikimedia.org/T439191) (owner: 10Laurabarluzzi) [13:22:24] (03PS8) 10Jgleeson: Adyen: add support for webhook HMAC signatures [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1355029 (https://phabricator.wikimedia.org/T441097) [13:23:23] (03PS2) 10Eileen: Don't match Adyen fee/adjustment rows to the original donation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354925 [13:24:07] (03CR) 10Ejegg: [C:03+2] "Makes sense, test looks good. Here's hoping the extra fees upserted and discarded don't contribute to more deadlocks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354925 (owner: 10Eileen) [13:28:44] 10fundraising-tech-ops, 10observability: Add astein as a user for Fundraising team in VO/splunk oncall - https://phabricator.wikimedia.org/T439906#12430777 (10hnowlan) 05Open→03Resolved Invite sent and astein has been added to the Fundraising group - apologies for the delay on this. Please reopen if th... [13:32:53] (03Merged) 10jenkins-bot: Don't match Adyen fee/adjustment rows to the original donation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1354925 (owner: 10Eileen) [13:59:31] (03CR) 10Ejegg: "One question about 'return null' in getSignedData" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1355029 (https://phabricator.wikimedia.org/T441097) (owner: 10Jgleeson) [13:59:53] (03PS1) 10Jgleeson: ComboWiki: add a field validation composable [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1355069 (https://phabricator.wikimedia.org/T439286) [14:03:23] FIRING: CertAlmostExpired: gNMI TLS certificate for fasw2-e16b-eqiad.mgmt.eqiad.wmnet is going to expire in 0s - https://wikitech.wikimedia.org/wiki/Network_monitoring#CertAlmostExpired - https://grafana.wikimedia.org/d/eab73c60-a402-4f9b-a4a7-ea489b374458/gnmic?var-site=eqiad - https://alerts.wikimedia.org/?q=alertname%3DCertAlmostExpired [14:08:22] FIRING: [4x] CertAlmostExpired: gNMI TLS certificate for fasw2-e15a-eqiad.mgmt.eqiad.wmnet is going to expire in 0s - https://wikitech.wikimedia.org/wiki/Network_monitoring#CertAlmostExpired - https://grafana.wikimedia.org/d/eab73c60-a402-4f9b-a4a7-ea489b374458/gnmic?var-site=eqiad - https://alerts.wikimedia.org/?q=alertname%3DCertAlmostExpired [14:19:17] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Show name & email fields after auth when missing for wallet donations - https://phabricator.wikimedia.org/T441162 (10Ejegg) 03NEW [14:20:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Venmo Validation error during recurring charge, in field: email - https://phabricator.wikimedia.org/T441071#12431321 (10Ejegg) →14Duplicate dup:03T441162 [14:20:46] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Show name & email fields after auth when missing for wallet donations - https://phabricator.wikimedia.org/T441162#12431323 (10Ejegg) [14:28:21] ooh fr-tech we need to update nodejs on the dev images [14:29:02] getting 'unsupported engine' when trying to npm install on dev payments [14:29:56] oh right that's still bookworm [14:31:10] k, still lets me run test:unit [14:31:15] but grunt is borken [14:31:49] seeing a bunch of [Vue warn]: Missing required prop: [14:31:54] I guess that's good to surface! [14:33:08] oh and a bunch of those are in donor portal [14:34:41] ah nice, test:unit:combo-wiki is just the new ones [14:38:22] FIRING: [4x] CertAlmostExpired: gNMI TLS certificate for fasw2-e15a-eqiad.mgmt.eqiad.wmnet is going to expire in 0s - https://wikitech.wikimedia.org/wiki/Network_monitoring#CertAlmostExpired - https://grafana.wikimedia.org/d/eab73c60-a402-4f9b-a4a7-ea489b374458/gnmic?var-site=eqiad - https://alerts.wikimedia.org/?q=alertname%3DCertAlmostExpired [14:43:22] RESOLVED: [4x] CertAlmostExpired: gNMI TLS certificate for fasw2-e15a-eqiad.mgmt.eqiad.wmnet is going to expire in 0s - https://wikitech.wikimedia.org/wiki/Network_monitoring#CertAlmostExpired - https://grafana.wikimedia.org/d/eab73c60-a402-4f9b-a4a7-ea489b374458/gnmic?var-site=eqiad - https://alerts.wikimedia.org/?q=alertname%3DCertAlmostExpired [14:50:30] (03CR) 10Ejegg: [C:03+1] "I like the jest project organization! The tests are pretty comprehensive and run without warnings. However, I see that there are a lot of " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) (owner: 10Damilare Adedoyin) [14:54:38] hi laurabar ! Those were some great suggestions on the unit test organization. Thank you! [14:58:27] (03CR) 10Jgleeson: Adyen: add support for webhook HMAC signatures (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1355029 (https://phabricator.wikimedia.org/T441097) (owner: 10Jgleeson) [15:01:39] jgleeson: to be clear, that suggestion about getting the validator from config instead of using new () was for a potential follow-up, totally fine to merge with that [15:01:56] and thanks for the clarification on return null [15:05:58] the update is done now ejegg just checking tests [15:05:59] thanks [15:06:24] awesome [15:06:45] (03PS9) 10Jgleeson: Adyen: add support for webhook HMAC signatures [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1355029 (https://phabricator.wikimedia.org/T441097) [15:08:26] (03CR) 10Ejegg: [C:03+2] "Thanks, this looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1355029 (https://phabricator.wikimedia.org/T441097) (owner: 10Jgleeson) [15:09:05] (03Merged) 10jenkins-bot: Adyen: add support for webhook HMAC signatures [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1355029 (https://phabricator.wikimedia.org/T441097) (owner: 10Jgleeson) [15:10:19] thanks ejegg [15:10:31] so no need to tag the lib for that, just merge to deployment, right? [15:27:23] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1355095 [15:27:26] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1355095 (owner: 10Ejegg) [15:27:53] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1355095 (owner: 10Ejegg) [16:09:20] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Show name & email fields after auth when missing for wallet donations - https://phabricator.wikimedia.org/T441162#12432271 (10AnnWF) a:03AnnWF [16:09:39] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Show name & email fields after auth when missing for wallet donations - https://phabricator.wikimedia.org/T441162#12432276 (10AnnWF) [16:16:11] !log SmashPig upgraded from 7e3426cf to 7b7586f2 [16:16:14] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [16:33:32] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy paypal sandbox api auth missing - https://phabricator.wikimedia.org/T441198 (10AnnWF) 03NEW [16:47:40] ejegg: yep although there's some changes needed in the adyen console and testing to do before we actually switch it on [16:48:21] I documented that here https://phabricator.wikimedia.org/T441097#12430915 [16:59:25] woah ejegg you already deployed it? [17:01:33] ejegg: let's do it slowly, we need to turn on HMACs on the adyen side [17:09:05] oh, I did that at the same time [17:09:18] as I added the HMAC setting and deployed [17:10:08] I got the code out a little ahead of the settings but it just ended up with some warnings in the logs [17:10:15] as the default was permissive [17:17:29] 03Fundraising Sprint: Shelf Aware, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-CentralNotice-Administration, 13Patch-For-Review: Provide a way to display of a banner only to users who reach a certain number of edits - https://phabricator.wikimedia.org/T269758#12432882 (10Ejegg... [17:55:17] ejegg: other chan [18:04:02] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM: Tracking donor strategies in Civi - https://phabricator.wikimedia.org/T437526#12433231 (10DBautista-WMF) @Lars I would like the ability to view past strategies as a way to see how the strategy is developing over time as the r... [18:30:32] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Develop & implement retention policy for email addresses overwritten when donor provides new email address on donation form - https://phabricator.wikimedia.org/T434832#12433305 (10SHust) @Lars, adding another example, flagged by Amb... [18:43:27] (03PS1) 10Pwangai: Keep host and database name in the DSN rpow defines [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1355155 (https://phabricator.wikimedia.org/T434024) [18:46:08] (03CR) 10Pwangai: "From the test side this is the last blocker for running the suite in parallel. I verified this works as expected on a CI agent by running " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1355155 (https://phabricator.wikimedia.org/T434024) (owner: 10Pwangai) [18:54:25] relocating for call [19:08:50] (03PS1) 10Wfan: Fix l10n in some epc mustache file with var [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1355165 (https://phabricator.wikimedia.org/T441093) [19:11:30] (03PS2) 10Wfan: Fix l10n in some epc mustache file with var [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1355165 (https://phabricator.wikimedia.org/T441093) [19:32:17] 10Fundraising Payments token migration 2026, 06Fundraising-Backlog: Check on adyen ideal Contract not found recurring failures - https://phabricator.wikimedia.org/T440419#12433657 (10MBeat33) @Damilare I'm reopening this for a followup question. @AMJohnson fielded a complaint from [[ https://civicrm.wikim... [19:32:28] 10Fundraising Payments token migration 2026, 06Fundraising-Backlog: Check on adyen ideal Contract not found recurring failures - https://phabricator.wikimedia.org/T440419#12433661 (10MBeat33) 05Resolved→03Open [19:45:38] (03PS3) 10Wfan: Fix l10n in some epc mustache file with var [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1355165 [19:53:33] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Develop & implement retention policy for email addresses overwritten when donor provides new email address on donation form - https://phabricator.wikimedia.org/T434832#12433784 (10Lars) @Shust In this case we set their gmail address... [20:01:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Recurring Token deletion mismatch gravy and civi - https://phabricator.wikimedia.org/T441235 (10AnnWF) 03NEW [20:34:11] (03PS1) 10Ejegg: Updates to Special:EmailPreferences [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1355185 (https://phabricator.wikimedia.org/T441093) [20:34:14] (03CR) 10Ejegg: [C:03+2] Updates to Special:EmailPreferences [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1355185 (https://phabricator.wikimedia.org/T441093) (owner: 10Ejegg) [20:34:21] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1355186 [20:34:23] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1355186 (owner: 10Ejegg) [20:34:36] (03CR) 10Ejegg: [V:03+2 C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1355186 (owner: 10Ejegg) [20:35:07] oh right I can't V+2 DI patches [20:35:10] just crm [20:36:06] (03Merged) 10jenkins-bot: Updates to Special:EmailPreferences [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1355185 (https://phabricator.wikimedia.org/T441093) (owner: 10Ejegg) [20:36:07] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1355186 (owner: 10Ejegg) [20:36:32] !log donorwiki upgraded from 60a7b7af to da1d88b6 [20:36:36] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [20:37:32] !log donorwiki upgraded from da1d88b6 to 9e8d0c0b [20:37:34] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [20:39:14] !log payments-wiki upgraded from da1d88b6 to 9e8d0c0b [20:39:16] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:55:30] (03PS4) 10Wfan: Fix l10n in some epc mustache file with var [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1355165 [23:09:44] (03PS1) 10Lars SG: Change Gift_Data.Donor_Specified from CheckBox to Radio [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1355199 (https://phabricator.wikimedia.org/T386031) [23:09:44] (03PS1) 10Lars SG: Add MG Engagement custom fields and afform to create new activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1355200 (https://phabricator.wikimedia.org/T386031) [23:17:36] (03PS1) 10Lars SG: Add MG Engagement custom fields and afform to create new activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1355200 (https://phabricator.wikimedia.org/T386031)