[00:35:46] (03PS3) 10Dmiranda: DonorPortal: send a login link for an email address in the URL [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358286 (https://phabricator.wikimedia.org/T436801) [00:46:52] (03PS1) 10Eileen: Extract batch summary email generation into BatchSummaryMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359434 (https://phabricator.wikimedia.org/T434041) [00:46:52] (03PS1) 10Eileen: Report separately on offline batches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359435 (https://phabricator.wikimedia.org/T434041) [00:46:52] (03PS1) 10Eileen: Sanitize batch name before using it as a file path in batch generation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359436 (https://phabricator.wikimedia.org/T434041) [01:34:27] (03CR) 10Cstone: [C:03+2] Extract batch summary email generation into BatchSummaryMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359434 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:38:02] (03CR) 10Cstone: [C:03+2] Report separately on offline batches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359435 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:38:34] (03CR) 10Cstone: [C:03+2] Sanitize batch name before using it as a file path in batch generation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359436 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:41:35] (03CR) 10Dmiranda: [C:03+2] Sanitize batch name before using it as a file path in batch generation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359436 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:42:03] thanks cstone , danielfm [01:42:32] (03Merged) 10jenkins-bot: Extract batch summary email generation into BatchSummaryMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359434 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:45:11] NP! eileen: [01:45:43] (03Merged) 10jenkins-bot: Report separately on offline batches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359435 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:47:03] (03Merged) 10jenkins-bot: Sanitize batch name before using it as a file path in batch generation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359436 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:51:15] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359452 [01:54:00] (03PS1) 10Ramon Lopez: ComboWiki UI: Added an inline country-currency selector to match figma design [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359453 [02:02:29] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359452 (owner: 10Eileen) [02:03:26] !log civicrm upgraded from 1b87ea3d to 8b129c5d [02:03:29] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:03:39] (03PS2) 10Cstone: Set default utms and set up calculated contrbution tracking params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) [02:05:04] (03CR) 10CI reject: [V:04-1] Set default utms and set up calculated contrbution tracking params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [02:05:45] got every linter mad [02:09:33] (03PS3) 10Cstone: Set default utms and set up calculated contrbution tracking params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) [02:11:09] (03CR) 10CI reject: [V:04-1] Set default utms and set up calculated contrbution tracking params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [02:24:28] (03PS1) 10Eileen: Show the full batch detail table for offline batches in the offline email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359455 [02:34:25] (03PS4) 10Cstone: Set default utms and set up calculated contrbution tracking params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) [02:34:42] (03CR) 10Cstone: [C:03+2] Show the full batch detail table for offline batches in the offline email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359455 (owner: 10Eileen) [02:36:01] (03CR) 10CI reject: [V:04-1] Set default utms and set up calculated contrbution tracking params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [02:42:30] (03Merged) 10jenkins-bot: Show the full batch detail table for offline batches in the offline email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359455 (owner: 10Eileen) [02:42:54] (03PS5) 10Cstone: Set default utms and set up calculated contrbution tracking params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) [02:43:11] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359456 [02:43:22] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359456 (owner: 10Eileen) [02:44:10] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359456 (owner: 10Eileen) [02:46:40] !log civicrm upgraded from 8b129c5d to 0d103d9e [02:53:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Can't save message template due to lack of tags - https://phabricator.wikimedia.org/T442666 (10Lars) 03NEW [03:10:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Can't save message template due to lack of tags - https://phabricator.wikimedia.org/T442666#12482663 (10Lars) 05Open→03Invalid Resolved upstream, just needed to pull it in [03:10:58] (03PS1) 10Lars SG: message_admin - fix error saving a template with no tags [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359457 [03:11:30] (03PS2) 10Lars SG: message_admin - fix error saving a template with no tags [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359457 [03:11:52] eileen: can you +2 this one from upstream ^^ Panos just discovered that bug [03:12:19] (03CR) 10Eileen: [C:03+2] message_admin - fix error saving a template with no tags [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359457 (owner: 10Lars SG) [03:12:27] tks [03:12:36] done larssandergreen ... also I think the gl_code thing is gonna be hotting up [03:13:12] gl_code controversy? or just that I should get my part done soon? [03:13:24] (03PS1) 10Eileen: Add support for interest contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359458 [03:17:17] larssandergreen: the latter .... the pressure to have it is increasing [03:18:17] I think finance just blew away all the previous data so it would be good to re-populate it better ... + I talked with Omar today & he is waiting on it [03:18:45] (I also promised to do some extra stuff for him that will tie in well with us putting better data back on staging) [03:19:45] (03Merged) 10jenkins-bot: message_admin - fix error saving a template with no tags [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359457 (owner: 10Lars SG) [03:19:46] OK, I will do it as soon as I can. Is this like this week heat or next sprint heat? I also have Mariana who is very eager for me to do something for segmentation. [03:19:49] also while I have you... this is the cleanest way I can think of to cope with the need to have interest from cck in the batches https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1359458 [03:20:16] Re the level of heat - I can see after I meet with them tomorrow [03:21:10] OK. It's not a large amount of work, but I just want to get the gift coding stuff a little more stable first to make sure it fits in logically [03:23:36] eileen: I guess it has to be channel? [03:24:13] 06Fundraising-Analysis, 10FR-Tech-Analytics: Materialize export-time GL account breakdowns for Finance PSP reconciliation reporting - https://phabricator.wikimedia.org/T442668 (10Sjones-ctr) 03NEW [03:24:56] larssandergreen: well financial type comes with it's own challenges .... we use something a bit fragile for fees but that leverages fee field, we could skip straight to gl but that's not operational - so I can't think of a better option [03:25:47] -very low volume, Stann-Omar just logged https://phabricator.wikimedia.org/T442668 re the gl - which was what I discussed with him [03:26:04] (well I hope so - I haven't read what he wrote yet) [03:26:42] I guess it isn't that wild to have it as a channel [03:26:49] (03CR) 10Lars SG: [C:03+2] Add support for interest contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359458 (owner: 10Eileen) [03:27:16] so would that still be the data going through analytics to accounting? [03:27:49] or just being available to them and going straight from Civi to accounting? [03:29:36] so basically it means that at the point when we export the batches/journals to accounting we would ALSO record to a table like [03:29:37] batch_id, gl_code, is_endowment, amount [03:29:37] with a row per gl_code, is_endowment combo. [03:29:37] The alternative is them to query the donations for it - but if we have a re-assignment that gets really messy to trace back what it was at the time it was sent [03:30:57] that makes sense [03:30:59] on one level it shouldn't be needed - ie its for reconcilation & it's a bit of a closed loop / and it reflects their current way of doing things (allocating funds per psp to the gl_codes within them) - but [03:31:31] but It's easy enough to write that data at the point of calculation & hard to reverse engineer it [03:34:39] (03Merged) 10jenkins-bot: Add support for interest contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359458 (owner: 10Eileen) [03:37:32] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359459 [03:37:41] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359459 (owner: 10Lars SG) [03:38:31] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359459 (owner: 10Lars SG) [03:40:56] !log civicrm upgraded from 0d103d9e to 55c473fb [04:18:58] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-email-preferences, 13Patch-For-Review: Ensure sufficient translation coverage for launch of EPC in email footers - https://phabricator.wikimedia.org/T441902#12482732 (10Lars) Once th... [04:41:42] (03PS1) 10Eileen: Only send offline batch email on a real generateBatch run, reverse table order [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359719 [04:41:42] (03PS1) 10Eileen: Add last verified/discrepancy columns to the incomplete batches table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359720 [04:42:56] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_47) - 10https://gerrit.wikimedia.org/r/1359536 (owner: 10L10n-bot) [04:53:01] FIRING: ContextSwitchingSpike: Host context switching high (instance frnetmon1002.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [04:55:17] (03CR) 10Cstone: [C:03+2] Only send offline batch email on a real generateBatch run, reverse table order [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359719 (owner: 10Eileen) [04:55:27] (03CR) 10Eileen: [V:03+2] Only send offline batch email on a real generateBatch run, reverse table order [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359719 (owner: 10Eileen) [04:55:35] (03CR) 10Cstone: [C:03+2] Add last verified/discrepancy columns to the incomplete batches table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359720 (owner: 10Eileen) [04:56:27] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359721 [04:58:01] RESOLVED: ContextSwitchingSpike: Host context switching high (instance frnetmon1002.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [05:06:47] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359721 (owner: 10Eileen) [05:07:35] !log civicrm upgraded from 55c473fb to e42d41de [05:07:38] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [05:10:19] (03PS1) 10Eileen: whitespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359723 [05:14:24] (03Merged) 10jenkins-bot: Add last verified/discrepancy columns to the incomplete batches table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359720 (owner: 10Eileen) [05:18:20] (03CR) 10Cstone: [C:03+2] whitespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359723 (owner: 10Eileen) [05:24:26] (03PS1) 10Cstone: WIP: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [05:25:53] (03CR) 10CI reject: [V:04-1] WIP: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [05:26:37] (03Merged) 10jenkins-bot: whitespace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359723 (owner: 10Eileen) [05:51:01] FIRING: ContextSwitchingSpike: Host context switching high (instance frdb1007.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [05:51:57] (03PS4) 10Eileen: Add reverse journal handling for endowment-first gateways [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 [05:53:30] (03CR) 10Eileen: "Thanks Laura - good points - this was in a bit of an experimental state." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 (owner: 10Eileen) [05:56:01] RESOLVED: ContextSwitchingSpike: Host context switching high (instance frdb1007.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [05:57:05] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359731 [05:57:47] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359731 (owner: 10Eileen) [05:58:37] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359731 (owner: 10Eileen) [06:01:29] !log civicrm upgraded from e42d41de to 9ec2f297 [06:01:32] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [06:07:48] (03PS1) 10Eileen: For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) [06:10:01] FIRING: ContextSwitchingSpike: Host context switching high (instance frpm1002.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [06:16:07] (03CR) 10CI reject: [V:04-1] For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [06:20:01] RESOLVED: ContextSwitchingSpike: Host context switching high (instance frpm1002.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [06:53:08] (03PS1) 10Eileen: Extract shared cross-instance transfer logic in writeJournalToCsv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359735 [07:07:41] (03PS1) 10Eileen: Code CCK fees to GL 60931/60932 by endowment vs annual fund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) [07:18:18] (03CR) 10CI reject: [V:04-1] Code CCK fees to GL 60931/60932 by endowment vs annual fund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [07:21:12] (03PS2) 10Eileen: For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) [07:28:43] (03PS2) 10Eileen: Remove domain_id from civicrm_option_value triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357594 [07:44:47] (03PS2) 10Eileen: Drop ODS support from Finance Spreadsheet import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347140 (https://phabricator.wikimedia.org/T434041) [07:45:45] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359363 (owner: 10Eileen) [08:00:07] (03PS3) 10Eileen: Code CCK fees to GL 60931/60932 by endowment vs annual fund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) [08:00:07] (03PS3) 10Eileen: For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) [08:08:52] (03CR) 10CI reject: [V:04-1] Code CCK fees to GL 60931/60932 by endowment vs annual fund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [08:09:03] (03CR) 10CI reject: [V:04-1] For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [08:16:13] (03CR) 10Laurabarluzzi: Add reverse journal handling for endowment-first gateways (034 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 (owner: 10Eileen) [08:30:52] (03PS4) 10Eileen: For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) [08:30:52] (03PS4) 10Eileen: Code CCK fees to GL 60931/60932 by endowment vs annual fund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) [08:30:52] (03PS1) 10Eileen: Handle NULL trxn_id in gateway-level transaction clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359753 [09:49:41] (03PS1) 10Laurabarluzzi: Add explicit autocomplete attributes for shared payment method form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359772 (https://phabricator.wikimedia.org/T439300) [09:51:54] (03PS2) 10Laurabarluzzi: Add explicit autocomplete attributes for shared payment method form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359772 (https://phabricator.wikimedia.org/T439300) [10:01:12] (03PS3) 10Laurabarluzzi: Add explicit autocomplete attributes for phone field and shared payment method form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359772 (https://phabricator.wikimedia.org/T439300) [12:18:45] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, 07fr-combowiki: ComboWiki: Adyen 3DS - https://phabricator.wikimedia.org/T442703 (10jgleeson) 03NEW [12:22:46] (03PS2) 10Jgleeson: ComboWiki: show payment methods from more than one gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359800 (https://phabricator.wikimedia.org/T441890) [12:23:17] laurbar: that is the change I mentioned to add in the new gateway layer to payment methods in the client side ^ [12:23:33] I'll now update your patch to work with it (fix conflicts) [12:27:16] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: Adyen 3DS - https://phabricator.wikimedia.org/T442703#12484000 (10jgleeson) [12:29:46] (03PS5) 10Laurabarluzzi: ComboWiki: one-click buttons for methods without form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358214 (https://phabricator.wikimedia.org/T437335) [12:55:58] (03PS17) 10Ejegg: Convert ResultPages to service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1352568 [13:15:08] (03PS6) 10Wfan: Braintree venmo accept payment complete with default browser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1248908 (https://phabricator.wikimedia.org/T352916) [13:15:55] (03CR) 10Ejegg: [C:03+2] "Looks good. Just one string to translate but that can be in a follow-on. Let's get this up to prod to see it in action!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1248908 (https://phabricator.wikimedia.org/T352916) (owner: 10Wfan) [13:18:11] (03Merged) 10jenkins-bot: Braintree venmo accept payment complete with default browser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1248908 (https://phabricator.wikimedia.org/T352916) (owner: 10Wfan) [13:18:58] (03PS3) 10Jgleeson: ComboWiki: show payment methods from more than one gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359800 (https://phabricator.wikimedia.org/T441890) [13:20:34] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10WikimediaCustomizations, 05FY26-27 WE5.4 Donor Identification and recognition: CentralNotice should expose functions that encapsulate the structure of the hide cookie - https://phabricator.wikimedia.org/T441349#12484278 (10Ejegg) On diving into... [13:34:40] FIRING: CertAlmostExpired: gNMI TLS certificate for fasw2-e16b-eqiad.mgmt.eqiad.wmnet is going to expire in 0s - https://wikitech.wikimedia.org/wiki/Network_monitoring#CertAlmostExpired - https://grafana.wikimedia.org/d/eab73c60-a402-4f9b-a4a7-ea489b374458/gnmic?var-site=eqiad - https://alerts.wikimedia.org/?q=alertname%3DCertAlmostExpired [13:36:22] (03PS8) 10Ejegg: Encrypted blob with return URL params (SEE DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357029 (https://phabricator.wikimedia.org/T436952) [13:37:12] ah, it probably would have been better to mock the encryption component for most of those tests, huh? [13:37:17] ehh [13:37:25] (03CR) 10CI reject: [V:04-1] Encrypted blob with return URL params (SEE DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357029 (https://phabricator.wikimedia.org/T436952) (owner: 10Ejegg) [13:39:22] RESOLVED: CertAlmostExpired: gNMI TLS certificate for fasw2-e16b-eqiad.mgmt.eqiad.wmnet is going to expire in 0s - https://wikitech.wikimedia.org/wiki/Network_monitoring#CertAlmostExpired - https://grafana.wikimedia.org/d/eab73c60-a402-4f9b-a4a7-ea489b374458/gnmic?var-site=eqiad - https://alerts.wikimedia.org/?q=alertname%3DCertAlmostExpired [13:40:27] (03PS9) 10Ejegg: Encrypted blob with return URL params (SEE DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357029 (https://phabricator.wikimedia.org/T436952) [13:41:49] (03CR) 10CI reject: [V:04-1] Encrypted blob with return URL params (SEE DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357029 (https://phabricator.wikimedia.org/T436952) (owner: 10Ejegg) [13:43:25] (03PS10) 10Ejegg: Encrypted blob with return URL params (SEE DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357029 (https://phabricator.wikimedia.org/T436952) [13:43:27] FIRING: CertAlmostExpired: gNMI TLS certificate for fasw2-e15a-eqiad.mgmt.eqiad.wmnet is going to expire in 0s - https://wikitech.wikimedia.org/wiki/Network_monitoring#CertAlmostExpired - https://grafana.wikimedia.org/d/eab73c60-a402-4f9b-a4a7-ea489b374458/gnmic?var-site=eqiad - https://alerts.wikimedia.org/?q=alertname%3DCertAlmostExpired [13:45:29] (03CR) 10CI reject: [V:04-1] Encrypted blob with return URL params (SEE DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357029 (https://phabricator.wikimedia.org/T436952) (owner: 10Ejegg) [13:48:22] RESOLVED: CertAlmostExpired: gNMI TLS certificate for fasw2-e15a-eqiad.mgmt.eqiad.wmnet is going to expire in 0s - https://wikitech.wikimedia.org/wiki/Network_monitoring#CertAlmostExpired - https://grafana.wikimedia.org/d/eab73c60-a402-4f9b-a4a7-ea489b374458/gnmic?var-site=eqiad - https://alerts.wikimedia.org/?q=alertname%3DCertAlmostExpired [13:50:40] (03PS1) 10Damilare Adedoyin: Update translations for Adyen SDK v6 credit card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) [13:54:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Legacy Braintree PayPal form is broke: make it work with braintree-web 3.147.0 and the PayPal v6 script - https://phabricator.wikimedia.org/T442718 (10jgleeson) 03NEW [13:55:02] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Legacy Braintree PayPal form breaks with Braintree PayPal SDK v3.147.0 - https://phabricator.wikimedia.org/T442718#12484458 (10jgleeson) [13:57:02] (03PS2) 10Damilare Adedoyin: Update translations for Adyen SDK v6 credit card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) [14:00:22] (03PS3) 10Damilare Adedoyin: Update translations for Adyen SDK v6 credit card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) [14:05:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Legacy Braintree PayPal form breaks with Braintree PayPal SDK v3.147.0 - https://phabricator.wikimedia.org/T442718#12484555 (10jgleeson) This is simpler than I thought. The two PayPal scripts in braintree-web don't clash: the v5 file (`paypal-checkout.mi... [14:05:40] (03PS11) 10Damilare Adedoyin: Support for latest Adyen SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358435 (https://phabricator.wikimedia.org/T441954) [14:05:45] (03PS5) 10Damilare Adedoyin: Updates for ACH to support Adyen v6.47 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358835 (https://phabricator.wikimedia.org/T441954) [14:07:40] (03PS11) 10Ejegg: Encrypted blob with return URL params (SEE DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357029 (https://phabricator.wikimedia.org/T436952) [14:10:04] damilare: oh nice, so the changes needed for the Adyen SDK upgrade are purely in JS (and I guess the *base-url params in smashpig settings?) [14:10:52] yes, mostly, ACH had some backend changes too ejegg [14:11:00] cool cool [14:11:18] but cstone says we aren't bothered much about those [14:11:43] I'm testing out the 72 now to see if we can make the jump [14:11:58] Yeah we'd want to add in the ach pay by bank plaid integration [14:13:07] ok, I will pull that front end patch down too [14:13:21] and try testing with 72 in the urls [14:23:33] damilare: do you want to put up a config-private patch with the test settings changes? [14:23:49] Sure, I'd push it up now [14:23:56] thanks! [14:28:24] done ejegg, it still has v69 set as I'm testing v72. [14:33:45] thanks damilare [14:33:56] card test looks fine [14:34:34] not sure if we want to keep that new explanatory stuff below the card fields, but it's easy enough to hide with css [14:35:19] yh they don't use placeholders anymore, they call it the contextualText [14:35:39] well it seems to translate at least [14:36:50] yes I added translations for the missing pieces: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1359845/3 [14:37:33] oh i see, they show their own error messages [14:38:24] yea [14:39:19] so the combowiki form would need the same ones? [14:40:46] ohh I haven't checked combowiki yet... but if its the same config, it should. [14:41:06] k, that can be a follow-on patch [14:42:49] looks like there's some more validation in v72: https://docs.adyen.com/online-payments/release-notes?title%5B0%5D=Checkout+API#releaseNote=2026-04-14-checkout-api-72 [14:44:40] again maybe a follow-on patch? [14:44:51] with more error handling [14:46:44] yh I'm looking into that now, I can put any changes in a follow on. [14:46:56] v71 seems like less of a big change [14:47:06] https://docs.adyen.com/online-payments/release-notes?title%5B0%5D=Checkout+API&version%5B0%5D=71#releaseNote=2023-10-31-checkout-api-71 [14:47:32] v70 makes recurringProcessModel required, but I think we send that already? [14:47:43] yh we already send that [14:47:53] I checked last night [14:48:58] oh hmm, could do a little refactor to that addRecurringParams. [14:49:10] yeah, seems we always pass true to add recurringProcessingModel [14:50:45] ohh which refactor are you thinking about for addRecurringParams? [14:52:40] (03PS1) 10Ejegg: Remove unused param [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359871 [14:52:45] that ^^^ damilare [14:53:49] oh yh, its always true [14:54:00] (03CR) 10Damilare Adedoyin: [C:03+2] Remove unused param [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359871 (owner: 10Ejegg) [14:54:05] thanks! [14:54:34] (03Merged) 10jenkins-bot: Remove unused param [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359871 (owner: 10Ejegg) [14:55:51] damilare: so have you seen any changes to the format of the payment methods blob? [14:56:02] looks like maybe Credit Cards gets changed to Cards [14:56:07] yes t [14:56:12] yes its just that [14:56:14] but I don't think that should affect how the app teams uses it, right? [14:56:17] cool cool [14:56:23] no it shouldn't [14:56:45] only doubt I have is whether we should just hide those new explanatory bits [14:57:37] yhh and maybe the brands too, how about the errors? [14:58:26] we had some code to show our own errors - let's see if that could still work [14:59:37] if its our error text, using our own translations might be good for that [15:01:28] oh i see, we are still setting these errors in the config on line 561 of adyen.js [15:02:22] ah so did they add more translatable strings that we can override there? [15:02:33] lemme look at your translation patch [15:02:59] ah now i see [15:03:16] ok, I guess that makes sense [15:03:48] i imagine you looked for equivalent existing error messages before adding new ones? [15:05:04] yes well I tried to, the texts I added included context for the error that I couldn't find in the existing translations. [15:05:52] k, maybe donate_interface-error-msg-expiry-date-field-invalid could be reused instead of adding donate_interface-error-msg-expiry-date-not-valid [15:06:41] also I see placeholders for cards can be passed via config, I can remove the contextualText field with css [15:07:04] and maybe donate_interface-error-msg-unsupported-card-entered for a couple [15:07:10] will comment on the patch [15:07:16] okk thanks! [15:09:42] ohh yh, another reason I added those was because that config is shown only when the adyen does not have a supporting translation. Adding these new keys would ensure consistency in the message otherwise we should just overwrite all of the errors with our translations then. [15:10:08] ejegg: ^ [15:11:08] ah ok [15:12:22] feels like it's so hard to clean up i18n messages after introducing them though [15:12:38] can we maybe try with the existing ones first? [15:14:01] sure we can [15:17:04] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: make sure there is a way for analytics to track combowiki - https://phabricator.wikimedia.org/T438589#12484985 (10Cstone) [15:17:14] (03CR) 10Ejegg: "Let's try to minimize the number of new i18n strings for now. Suggestions for reusing a lot of existing ones inline" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [15:22:44] 10fundraising-tech-ops, 10observability: Add astein as a user for Fundraising team in VO/splunk oncall - https://phabricator.wikimedia.org/T439906#12485010 (10hnowlan) 05Open→03Resolved Account looks good, resolving - please let me know if there are other issues. [15:24:54] (03CR) 10Ejegg: [C:03+1] "Great work! Want to just hide the new explanatory text below the fields with CSS?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358435 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [15:26:20] (03PS6) 10Damilare Adedoyin: Updates for ACH to support Adyen v6.47 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358835 (https://phabricator.wikimedia.org/T441954) [15:27:23] (03PS12) 10Damilare Adedoyin: Support for latest Adyen SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358435 (https://phabricator.wikimedia.org/T441954) [15:27:32] (03PS7) 10Damilare Adedoyin: Updates for ACH to support Adyen v6.47 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358835 (https://phabricator.wikimedia.org/T441954) [15:27:34] (03CR) 10CI reject: [V:04-1] Updates for ACH to support Adyen v6.47 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358835 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [15:27:53] (03PS13) 10Damilare Adedoyin: Support for latest Adyen SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358435 (https://phabricator.wikimedia.org/T441954) [15:28:10] (03PS8) 10Damilare Adedoyin: Updates for ACH to support Adyen v6.47 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358835 (https://phabricator.wikimedia.org/T441954) [15:28:20] (03PS4) 10Damilare Adedoyin: Update translations for Adyen SDK v6 credit card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) [15:28:44] 06Fundraising-Backlog, 10FY26-27 ST6.4 - Logged-in performance, 10MediaWiki-extensions-CentralNotice, 06SRE, and 3 others: Special:HideBanners is not really cacheable - https://phabricator.wikimedia.org/T256447#12485032 (10Krinkle) [15:28:46] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FY26-27 ST6.4 - Logged-in performance, 10MediaWiki-extensions-CentralNotice, and 2 others: Warning: Cookies set on Special:HideBanners with Cache-Control "public, s-maxage=86400, max-age=0" - https://phabricator.wikimedia.org/T285210#12485033 (10Krin... [15:30:49] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FY26-27 ST6.4 - Logged-in performance, 10MediaWiki-extensions-CentralNotice, and 2 others: Warning: Cookies set on Special:HideBanners with Cache-Control "public, s-maxage=86400, max-age=0" - https://phabricator.wikimedia.org/T285210#12485046 (10Ejeg... [15:33:51] (03PS1) 10Ejegg: Remove cache headers from Special:HideBanners [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1359884 (https://phabricator.wikimedia.org/T285210) [15:34:39] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the review, I've made the recommended change." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358435 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [16:36:57] (03PS3) 10Jgleeson: ComboWiki: add the Braintree client config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358841 (https://phabricator.wikimedia.org/T441803) [16:37:07] 03Fundraising Sprint: That Rug Really Tied The Room Together: Explore latest updates on Braintree SDK - https://phabricator.wikimedia.org/T442070#12485488 (10AnnWF) for paypal onclick: https://phabricator.wikimedia.org/T442718 this added for resolve the one click with paypal-checkout-v6.min.js [16:50:46] (03CR) 10Lars SG: [C:03+2] Remove domain_id from civicrm_option_value triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357594 (owner: 10Eileen) [16:52:38] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: Adyen 3DS - https://phabricator.wikimedia.org/T442703#12485622 (10jgleeson) [16:59:43] (03Merged) 10jenkins-bot: Remove domain_id from civicrm_option_value triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357594 (owner: 10Eileen) [17:10:28] (03PS4) 10Laurabarluzzi: Add explicit autocomplete attributes for phone field and shared payment method form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359772 (https://phabricator.wikimedia.org/T439300) [17:11:08] (03CR) 10Ejegg: [C:03+2] "Thanks, these look good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359772 (https://phabricator.wikimedia.org/T439300) (owner: 10Laurabarluzzi) [17:12:42] (03Merged) 10jenkins-bot: Add explicit autocomplete attributes for phone field and shared payment method form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359772 (https://phabricator.wikimedia.org/T439300) (owner: 10Laurabarluzzi) [17:15:11] jack I suppose we can special-case focusing the state_country field [17:15:25] if we need to focus in on validation fail [17:15:48] yeah ejegg I actually found this comment from my earlier patch regarding that [17:15:49] / Only the text inputs have refs, so the state_province select isn't focused. [17:15:56] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1355867/4/modules/ext.donationInterface.comboWiki/components/GravyCardForm.vue#407 [17:16:03] so we're not focusing on it today [17:16:10] ahh, it's the same issue as laura found [17:16:34] basically the select cdx component is more complex so doesn't just pass through html attributes [17:16:59] looks like that code was copied to https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/52136cdfb93d9ab774acef90a0965072ccbeecfd/modules/ext.donationInterface.comboWiki/components/PaymentMethodFormFields.vue#L344 [17:17:20] when it was generalised [17:17:29] so we might want to update that if we've fixed it [17:17:51] ah, want to comment on the patch? [17:18:33] I'll add it to the list [17:18:40] 🫠 [17:23:08] (03PS4) 10Jgleeson: ComboWiki: add the Braintree client config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358841 (https://phabricator.wikimedia.org/T441803) [17:23:30] it looks like laurbar did remove it here https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1359772/4/modules/ext.donationInterface.comboWiki/components/PaymentMethodFormFields.vue#344 [17:23:51] and added ref="state_province" [17:24:12] to use the validation comosable focus [17:24:17] composable* [17:24:40] (03CR) 10Ejegg: [C:03+2] "The actual code looks good. Test code is just a little jarring because of the annoyance you note in having a single smashPig mock for all " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358841 (https://phabricator.wikimedia.org/T441803) (owner: 10Jgleeson) [17:26:27] (03Merged) 10jenkins-bot: ComboWiki: add the Braintree client config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358841 (https://phabricator.wikimedia.org/T441803) (owner: 10Jgleeson) [17:31:16] yeah ejegg it's not pretty [17:32:07] I'll see if I can improve that line which causes offense [17:32:55] jgleeson: wouldn't we need to mess with SmashPig testing context? [17:33:33] ideally we could set a separate test override for each provider [17:33:54] lemme see [17:34:15] exactly ejegg [17:35:14] we can probably put up with the current testing ugliness for now - i dunno [17:35:33] wary of doing something that would mean updating all the other tests that mock smashpig [17:36:47] (03PS5) 10Damilare Adedoyin: Update translations for Adyen SDK v6 credit card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) [17:36:52] I'm thinking we can just use overrideObjectInstance() in the tests so its more explict e.g. `$this->providerConfig->overrideObjectInstance( 'payment-provider/cc', $mockAdyenProvider );` [17:37:08] that way we don't need `$this->mockBraintreeClientToken( $adyenProviderConfig );` [17:37:18] it's clearer now that it's for cc [17:37:30] ah yeah [17:37:54] that is a bit less jarring [17:38:00] right [17:40:04] (03PS6) 10Damilare Adedoyin: Update translations for Adyen SDK v6 credit card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) [17:51:25] (03PS1) 10Jgleeson: ComboWiki: Tidy up smashpig mock usage in DonateTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359926 [17:51:29] ejegg: ^ [17:52:56] (03PS4) 10Jgleeson: ComboWiki: show payment methods from more than one gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359800 (https://phabricator.wikimedia.org/T441890) [17:53:04] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: CKEditor 5 doesn't open on new user-driven message templates - https://phabricator.wikimedia.org/T442745 (10Lars) 03NEW [17:53:11] ty for the review also [17:56:35] (03PS1) 10Ejegg: Let a test override multiple provider configs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359928 [17:57:01] (03CR) 10CI reject: [V:04-1] Let a test override multiple provider configs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359928 (owner: 10Ejegg) [17:57:01] jgleeson: ^^^ is a first stab at letting us do it properly in SmashPig, hopefully w/o breaking existing tests [17:57:44] lol, seems to have broken tests [17:57:54] ha, nice idea tho [17:59:01] (03CR) 10Ejegg: [C:03+2] ComboWiki: Tidy up smashpig mock usage in DonateTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359926 (owner: 10Jgleeson) [18:00:26] fr-tech I am having headaches will go to take the rest of day off. I guess I am catching cold. See you all tomorrow. [18:00:27] trying to figure out the best way of getting rid of the paymentMethod attribute on the donation object in Vue [18:00:35] aww wfan, feel better soon [18:00:35] (03Merged) 10jenkins-bot: ComboWiki: Tidy up smashpig mock usage in DonateTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359926 (owner: 10Jgleeson) [18:00:58] feel better wfan and everyone else who isnt feeling the best [18:01:28] jgleeson it seems like we could have the more standard gateway and payment_method attributes everywhere [18:01:44] let me see what that would take [18:01:56] ejegg: have you seen paymentMethodMap [18:02:03] in api.js [18:02:19] yep, just wondering how we could do without it [18:02:31] just confusing to have payment_method and paymentMethod mean different things [18:03:04] i get that we have to map to a specific component for payment_method + gateway [18:03:33] but I would be happier if that was confined to the component mapper and everywhere else was just payment_method and gateway [18:04:17] maybe a thing to do after your patch though [18:05:48] yeah I see what you mean ejegg [18:05:53] hmm [18:06:06] I think we also map it backwards somewhere [18:06:18] Thanks cstone u too. Going to sleep now just logged the sick leave request. [18:06:42] ejegg: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/b6e5364a1df8fc7d5c3ee3ab92ccf9990e38f254/modules/ext.donationInterface.comboWiki/views/PaymentForm.vue#L362 [18:07:23] we could probably make decisions earlier to avoid that [18:25:41] bah, i'd like to make the change now to avoid further entrenching it in your patch, but it's not trivial [18:26:07] and I'm wary of delaying merge on your stuff with your upcoming time off [18:28:13] if we could just rename the one of them to componentKey that would be a bit less confusing [18:29:26] ah well, I'll make a phab to fix that later [18:33:46] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Clear up confusion between payment_method and paymentMethod in Combowiki vue forms - https://phabricator.wikimedia.org/T442750 (10Ejegg) 03NEW [18:36:53] (03PS2) 10Ejegg: Let a test override multiple provider configs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359928 [18:41:40] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Backfill donor status & segment history - https://phabricator.wikimedia.org/T431586#12486172 (10SBurnett-WMF) p:05Triage→03High [18:55:43] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen and Braintree components and methods - https://phabricator.wikimedia.org/T442752 (10Cstone) 03NEW [18:56:00] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen and Braintree components and methods - https://phabricator.wikimedia.org/T442752#12486222 (10Cstone) [18:56:05] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12486223 (10Cstone) [18:56:19] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen and Braintree components and methods - https://phabricator.wikimedia.org/T442752#12486225 (10Cstone) [18:56:23] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 07fr-combowiki, and 2 others: Add Braintree PayPal Vue Component - https://phabricator.wikimedia.org/T441803#12486224 (10Cstone) [18:56:25] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12486226 (10Cstone) [18:56:55] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen and Braintree components and methods - https://phabricator.wikimedia.org/T442752#12486228 (10Cstone) [18:56:57] 06Fundraising-Backlog, 07fr-combowiki: Add Braintree Venmo Vue Component - https://phabricator.wikimedia.org/T441808#12486227 (10Cstone) [18:56:58] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12486229 (10Cstone) [18:57:10] damilare would you be able to help me deploy those adyen SDK update changes if I C+2ed them now? [18:57:21] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen and Braintree components and methods - https://phabricator.wikimedia.org/T442752#12486231 (10Cstone) [18:57:22] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: Adyen 3DS - https://phabricator.wikimedia.org/T442703#12486230 (10Cstone) [18:57:25] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12486232 (10Cstone) [18:57:34] sorry making some phab spam [19:05:30] !log SmashPig upgraded from 7b7586f2 to d446404f [19:05:32] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [19:06:27] (03PS5) 10Eileen: Add reverse journal handling for endowment-first gateways [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 [19:06:27] (03PS2) 10Eileen: Extract shared cross-instance transfer logic in writeJournalToCsv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359735 [19:06:27] (03PS2) 10Eileen: Handle NULL trxn_id in gateway-level transaction clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359753 [19:06:28] (03PS5) 10Eileen: Code CCK fees to GL 60931/60932 by endowment vs annual fund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) [19:06:29] (03PS5) 10Eileen: For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) [19:07:19] (03CR) 10Eileen: Add reverse journal handling for endowment-first gateways (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 (owner: 10Eileen) [19:08:11] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359946 [19:08:24] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359946 (owner: 10Eileen) [19:09:24] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359946 (owner: 10Eileen) [19:11:11] (03PS6) 10Eileen: Do not let case mismatches block NamePair resolution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1334162 (https://phabricator.wikimedia.org/T436878) [19:16:39] (03CR) 10CI reject: [V:04-1] Code CCK fees to GL 60931/60932 by endowment vs annual fund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [19:17:22] (03CR) 10CI reject: [V:04-1] For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [19:21:59] (03CR) 10CI reject: [V:04-1] Do not let case mismatches block NamePair resolution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1334162 (https://phabricator.wikimedia.org/T436878) (owner: 10Eileen) [19:22:28] !civicrm upgraded from 9ec2f297 to 7f775db4 [19:28:58] (03CR) 10Lars SG: [C:03+2] Update ckeditor5 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359363 (owner: 10Eileen) [19:37:24] FIRING: SystemdService: Systemd service coworker.service stopped on civi1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService [19:40:42] (03Merged) 10jenkins-bot: Update ckeditor5 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359363 (owner: 10Eileen) [19:46:08] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen and Braintree components and methods - https://phabricator.wikimedia.org/T442752#12486378 (10Cstone) [19:46:10] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen SEPA Component - https://phabricator.wikimedia.org/T441853#12486377 (10Cstone) [19:46:12] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12486379 (10Cstone) [19:46:43] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add Adyen Google Pay component - https://phabricator.wikimedia.org/T441850#12486381 (10Cstone) [19:46:45] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen and Braintree components and methods - https://phabricator.wikimedia.org/T442752#12486382 (10Cstone) [19:46:48] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12486383 (10Cstone) [19:47:27] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add Adyen Apple Pay Component - https://phabricator.wikimedia.org/T441849#12486384 (10Cstone) [19:47:28] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen and Braintree components and methods - https://phabricator.wikimedia.org/T442752#12486385 (10Cstone) [19:47:31] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12486386 (10Cstone) [19:48:28] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add Adyen Google Pay component - https://phabricator.wikimedia.org/T441850#12486389 (10Laurabarluzzi) a:03Laurabarluzzi [19:49:04] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add Adyen Apple Pay Component - https://phabricator.wikimedia.org/T441849#12486392 (10Damilare) a:03Damilare [19:49:35] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add Adyen Apple Pay Component - https://phabricator.wikimedia.org/T441849#12486393 (10Damilare) [19:49:45] (03CR) 10Lars SG: [C:03+2] Drop ODS support from Finance Spreadsheet import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347140 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [19:50:14] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add Adyen Google Pay component - https://phabricator.wikimedia.org/T441850#12486396 (10Cstone) [19:53:35] (03CR) 10Ejegg: [C:03+2] "Here's a thing we could maybe use for this test in the future: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1359928" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358841 (https://phabricator.wikimedia.org/T441803) (owner: 10Jgleeson) [19:57:24] RESOLVED: SystemdService: Systemd service coworker.service stopped on civi1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService [20:00:07] (03Merged) 10jenkins-bot: Drop ODS support from Finance Spreadsheet import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347140 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [20:03:08] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Clear up confusion between payment_method and paymentMethod in Combowiki vue forms - https://phabricator.wikimedia.org/T442750#12486526 (10Ejegg) [20:15:06] (03PS6) 10Eileen: Code CCK fees to GL 60931/60932 by endowment vs annual fund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) [20:15:06] (03PS6) 10Eileen: For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) [20:18:18] (03PS1) 10Damilare Adedoyin: Add validation error for invalid postal_code [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359962 (https://phabricator.wikimedia.org/T441954) [20:27:43] jgleeson I thought i had a handle on it but now I'm wondering how donation.paymentMethod was 'cc' in the current version of this tests; https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1359800/4/tests/jest/comboWiki/payment-form-return.test.js [20:28:22] lemme take a peek. [20:28:26] it does seem to work though [20:28:53] anyway, I'm fine merging that with the hopes of doing the method clarification later [20:28:59] it has a phab [20:29:24] (03PS5) 10Jgleeson: ComboWiki: show payment methods from more than one gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359800 (https://phabricator.wikimedia.org/T441890) [20:30:52] (03CR) 10Ejegg: [C:03+2] "This looks like it does the trick, and works in local smoke testing. The additional mapping back and forth between payment_method and paym" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359800 (https://phabricator.wikimedia.org/T441890) (owner: 10Jgleeson) [20:32:24] (03Merged) 10jenkins-bot: ComboWiki: show payment methods from more than one gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359800 (https://phabricator.wikimedia.org/T441890) (owner: 10Jgleeson) [20:35:11] (03PS18) 10Ejegg: Convert ResultPages to service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1352568 [20:35:59] (03PS12) 10Ejegg: Encrypted blob with return URL params (SEE DEPLOY NOTE) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357029 (https://phabricator.wikimedia.org/T436952) [20:36:19] ejegg: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/a52c998ff81622a85bbd2befc6e98614043231d0/special/Donate.php#L851 [20:37:03] (03PS1) 10Eileen: Civi6.20 upgrade to latest rc commit f0d69f7691 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359967 [20:37:12] right, but the mapped one was always one of the component key type things, right? [20:37:18] (03PS2) 10Eileen: Civi6.20 upgrade to latest rc commit f0d69f7691 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359967 [20:37:42] looks like it's a fallback for when we don't get a method in the return [20:39:36] ohh or did the old toFormPaymentMethod fall back to pssing the thing directly through? [20:39:51] the server-side config still sends the payment_method 'cc' [20:39:53] the old code did not map it back [20:40:02] ah got it [20:40:28] we freeze the form in the background on the return [20:40:41] right, i think laurbar had the next patch to review, right? [20:40:45] right [20:40:47] ? [20:40:51] :P [20:41:07] (realized i repeated myself so repeated myself again) [20:41:08] thanks for the review! [20:41:23] left [20:41:26] :) [20:42:12] (03PS3) 10Eileen: Civi6.20 upgrade to latest rc commit f0d69f7691 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359967 [20:43:27] oh ramon has a couple patches, probs good to review those now [20:46:24] (03PS7) 10Eileen: Do not let case mismatches block NamePair resolution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1334162 (https://phabricator.wikimedia.org/T436878) [20:46:52] (03PS3) 10Eileen: Handle NULL trxn_id in gateway-level transaction clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359753 [20:48:06] (03PS2) 10Ramon Lopez: ComboWiki UI: CSS styles and classes cleanup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359416 [20:48:11] (03CR) 10Ejegg: [C:03+2] ComboWiki UI: CSS styles and classes cleanup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359416 (owner: 10Ramon Lopez) [20:49:48] (03Merged) 10jenkins-bot: ComboWiki UI: CSS styles and classes cleanup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359416 (owner: 10Ramon Lopez) [20:50:21] (03CR) 10Lars SG: [C:03+2] Handle NULL trxn_id in gateway-level transaction clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359753 (owner: 10Eileen) [20:50:35] (03CR) 10CI reject: [V:04-1] Civi6.20 upgrade to latest rc commit f0d69f7691 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359967 (owner: 10Eileen) [20:52:49] 06Fundraising-Backlog, 13Patch-For-Review: Explore latest updates on Adyen SDK - https://phabricator.wikimedia.org/T441954#12486741 (10Damilare) I checked the changes on the Checkout API from [[ https://docs.adyen.com/online-payments/release-notes?tab=1&title%5B0%5D=Checkout+API&version%5B0%5D=69&version%5B1%5... [20:53:11] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 13Patch-For-Review: Explore latest updates on Adyen SDK - https://phabricator.wikimedia.org/T441954#12486742 (10Damilare) [20:53:42] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 13Patch-For-Review: Explore latest updates on Adyen SDK - https://phabricator.wikimedia.org/T441954#12486744 (10Damilare) a:03Damilare [20:57:04] (03CR) 10Ejegg: [C:04-1] "If donatewiki was stripping the protocol from the referrer, maybe we should be doing that in the DataNormalizer?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [20:58:24] (03Merged) 10jenkins-bot: Handle NULL trxn_id in gateway-level transaction clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359753 (owner: 10Eileen) [20:59:30] (03CR) 10Damilare Adedoyin: "Thanks for the review ejegg, I've made the changes and also updated a qqq description that seemed a bit out of place." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [20:59:43] thanks Dami! [21:00:01] I might do a quick deploy now to clear the decks for merging and deploying your stuff tomorr [21:00:04] ow [21:00:38] yea that makes sense, sounds good [21:03:13] oh lol if i change to a forbidden country then press back from the forbidden view it shows me the form with the forbidden country selected [21:11:06] (03PS2) 10Ramon Lopez: ComboWiki UI: Added an inline country-currency selector to match figma design [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359453 [21:13:19] (03CR) 10Ejegg: [C:03+2] "This is nicely polished and better matches donatewiki! I appreciate the locale-aware sorting. I'll make a follow-up to delete the other se" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359453 (owner: 10Ramon Lopez) [21:15:33] (03Merged) 10jenkins-bot: ComboWiki UI: Added an inline country-currency selector to match figma design [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359453 (owner: 10Ramon Lopez) [21:20:18] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1359973 [21:20:55] (03CR) 10Ejegg: [V:03+2 C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1359973 (owner: 10Ejegg) [21:31:31] (03PS1) 10Ejegg: Update composer.lock for new SmashPig [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1359976 [21:31:50] (03CR) 10Ejegg: [V:03+2 C:03+2] Update composer.lock for new SmashPig [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1359976 (owner: 10Ejegg) [21:36:24] !log payments-wiki upgraded from ce87dea1 to 9bfda667 [21:36:26] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:38:24] !log donorwiki upgraded from c32d227e to 9bfda667 [21:38:26] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:38:48] larssandergreen and danielfm I just deployed a few email prefs / donor portal patches ^^^ [21:39:11] listed here: https://gerrit.wikimedia.org/r/1359973 [21:40:13] Thanks ejegg: ! [21:41:25] cstone oh man the api params are all still utm_ not wmf_ [21:41:38] we need to add a new one for _key [21:42:12] i guess I'll add all new wmf_ ones? [21:45:51] thanks ejegg and those changes are looking good danielfm [21:46:14] ejegg if you have a chance, you could maybe look at the translations patch I have for EPC: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1359405 [21:46:37] thanks, let me see if I can get to that [21:46:46] kiddos are about to come home but maybe late [21:47:01] not a rush at all, just sometime before we launch it on nov 25 [21:50:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Handle host key changes for mediawiki export job - https://phabricator.wikimedia.org/T442774 (10Lars) 03NEW [21:51:29] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Handle host key changes for mediawiki export job - https://phabricator.wikimedia.org/T442774#12487018 (10Lars) [21:55:15] (03PS1) 10Ejegg: Add wmf_key (and other wmf_ params) to API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359980 [21:55:31] cstone That's to support your utm_key work ^^^ [21:55:48] I figure we should also standardize on any external source sending wmf_ [21:55:53] oop, gotta head out [21:56:56] (03CR) 10CI reject: [V:04-1] Add wmf_key (and other wmf_ params) to API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359980 (owner: 10Ejegg) [22:12:55] (03PS7) 10Eileen: For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) [22:16:57] (03PS4) 10Eileen: Civi6.20 upgrade to latest rc commit f0d69f7691 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359967 [22:16:57] (03PS1) 10Eileen: Declare iso_code unique index as a stop gap [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359984 [22:27:06] (03CR) 10CI reject: [V:04-1] Civi6.20 upgrade to latest rc commit f0d69f7691 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359967 (owner: 10Eileen) [22:31:26] (03CR) 10Lars SG: [C:03+2] Declare iso_code unique index as a stop gap [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359984 (owner: 10Eileen) [22:49:46] (03CR) 10Lars SG: [C:03+2] Civi6.20 upgrade to latest rc commit f0d69f7691 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359967 (owner: 10Eileen) [22:50:58] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10WikimediaCustomizations, 05FY26-27 WE5.4 Donor Identification and recognition: CentralNotice should expose functions that encapsulate the structure of the hide cookie - https://phabricator.wikimedia.org/T441349#12487197 (10Jdlrobson-WMF) Yes we... [22:58:20] (03CR) 10CI reject: [V:04-1] Civi6.20 upgrade to latest rc commit f0d69f7691 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359967 (owner: 10Eileen) [22:58:21] (03CR) 10CI reject: [V:04-1] Declare iso_code unique index as a stop gap [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359984 (owner: 10Eileen) [23:13:42] (03open) 10dwisehaupt: Upgrade civi to 6.19.3.1 [repos/fundraising-tech/community-civicrm] (labs_build) - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/44 [23:20:26] (03CR) 10Lars SG: [C:03+2] For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [23:21:58] (03CR) 10Lars SG: [C:03+2] "I did wonder if we still want the log to include the previous values, but not a blocker at all" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [23:27:20] (03CR) 10Eileen: "nah - this is a case where it's a data entry cycle not meaningful data" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [23:28:30] (03CR) 10Eileen: "resubmit" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359984 (owner: 10Eileen) [23:28:50] (03Merged) 10jenkins-bot: For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359733 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [23:29:22] (03CR) 10Eileen: [V:03+2] Civi6.20 upgrade to latest rc commit f0d69f7691 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359967 (owner: 10Eileen) [23:29:52] (03PS2) 10Eileen: Declare iso_code unique index as a stop gap [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359984 [23:53:48] (03merge) 10dwisehaupt: Upgrade civi to 6.19.3.1 [repos/fundraising-tech/community-civicrm] (labs_build) - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/44 [23:56:37] (03CR) 10Eileen: [V:03+2] Declare iso_code unique index as a stop gap [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359984 (owner: 10Eileen) [23:58:08] (03open) 10dwisehaupt: Upgrade civi to 6.19.3.1 [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/45 [23:59:31] (03PS1) 10Eileen: Handle NULL trxn_id in gateway-level transaction clauses [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359996