[00:00:06] (03PS1) 10Eileen: For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359997 (https://phabricator.wikimedia.org/T434041) [00:00:23] (03CR) 10Eileen: [C:03+2] For engage donations trust the donations if the fee_amount differs [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359997 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [00:00:30] (03CR) 10Eileen: [C:03+2] Handle NULL trxn_id in gateway-level transaction clauses [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359996 (owner: 10Eileen) [00:01:37] !log * civicrm upgraded from 7f775db4 to 2302bf06 [00:01:37] * config revision changed from 77f7731d to f2c4409f [00:01:39] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [00:16:55] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359998 [00:17:19] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359998 (owner: 10Eileen) [00:17:47] (03CR) 10CI reject: [V:04-1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359998 (owner: 10Eileen) [00:23:29] (03merge) 10dwisehaupt: Upgrade civi to 6.19.3.1 [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/45 [00:40:14] (03PS2) 10Ramon Lopez: Added loading animation for delayed donation submission [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359359 [00:45:13] (03PS2) 10Ejegg: Add wmf_key (and other wmf_ params) to API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359980 [00:55:07] ejegg|afk: should we be fully converted to wmf now for those? [00:56:44] (03CR) 10Cstone: [C:03+2] "this is SO CUTE!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359359 (owner: 10Ramon Lopez) [00:58:15] (03Merged) 10jenkins-bot: Added loading animation for delayed donation submission [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359359 (owner: 10Ramon Lopez) [01:07:06] (03PS1) 10Eileen: 6.20 port https://github.com/civicrm/civicrm-core/pull/37766 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360007 [01:10:11] (03PS1) 10Eileen: And go further on phpspreadsheet [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360009 [01:12:50] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen SEPA Component - https://phabricator.wikimedia.org/T441853#12487587 (10Cstone) [01:13:57] (03CR) 10Cstone: [C:03+2] And go further on phpspreadsheet [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360009 (owner: 10Eileen) [01:14:31] baby globe loading spinner!!!!! [01:14:41] amazeballs [01:15:06] cstone it would be nice to be consistent! [01:15:20] ejegg: any idea why my local just keeps saying adyen checkout is not defined [01:15:25] my other local is fine... hah [01:15:27] I guess we must still be sending utm_ [01:15:46] i got distracted making an error logger cause we arent logging any of these client errors [01:15:55] cstone no idea! My local crm on this mac is having that old tls issue [01:16:16] oh can we just copy the onError function from the old forms? [01:16:25] is that how we are getting them out of JS there? [01:16:32] yep [01:16:43] we have something only in the monthly convert code too lets see how they compare [01:20:15] (03CR) 10Cstone: [C:03+2] 6.20 port https://github.com/civicrm/civicrm-core/pull/37766 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360007 (owner: 10Eileen) [01:20:38] i'm going to delete the older country selector [01:20:54] oh and see if we can get slightly less short country names [01:21:30] ejegg: you didnt run into any adyencheckout is not defined errors on combowiki ? [01:23:09] ohhh it's the config [01:23:23] you pulled the new config-private that loads newer Adyen SDK i bet [01:23:26] i checked out master on everything i thought [01:23:34] ooh that its new is the issue then? [01:23:44] yeah we need to update the combowiki code [01:23:57] till then you need to go one step back on config-private [01:24:07] git reset --hard HEAD^ [01:24:32] hmm as long as you don't have any local modifications [01:24:58] hah ive reset everything i thought this was because i was messing around locally [01:26:00] ok cool [01:26:05] although it was nice to force a real error [01:29:04] (03PS1) 10Ejegg: Delete old country selector component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360011 [01:30:48] (03Merged) 10jenkins-bot: 6.20 port https://github.com/civicrm/civicrm-core/pull/37766 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360007 (owner: 10Eileen) [01:30:50] (03Merged) 10jenkins-bot: And go further on phpspreadsheet [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360009 (owner: 10Eileen) [01:32:13] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360012 [01:35:15] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360012 (owner: 10Eileen) [01:35:56] !log civicrm upgraded from 2302bf06 to d58bdb5c [01:35:58] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [01:54:34] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10WikimediaCustomizations, 05FY26-27 WE5.4 Donor Identification and recognition: Special:HideBanners should be able to set an expiry longer than the logical hide duration - https://phabricator.wikimedia.org/T441351#12487647 (10Ejegg) @spatton so... [01:57:26] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review our patching of CiviCRM core - https://phabricator.wikimedia.org/T442796 (10Eileenmcnaughton) 03NEW [02:10:21] (03PS3) 10Lars SG: Add translations for EPC [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359405 (https://phabricator.wikimedia.org/T441902) [02:10:25] (03CR) 10Ejegg: [C:03+2] Add translations for EPC [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359405 (https://phabricator.wikimedia.org/T441902) (owner: 10Lars SG) [02:11:53] (03Merged) 10jenkins-bot: Add translations for EPC [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359405 (https://phabricator.wikimedia.org/T441902) (owner: 10Lars SG) [03:46:44] (03PS1) 10Cstone: WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [03:48:46] (03CR) 10CI reject: [V:04-1] WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 (owner: 10Cstone) [04:04:24] (03PS2) 10Cstone: WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [04:05:46] (03CR) 10CI reject: [V:04-1] WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 (owner: 10Cstone) [04:16:03] (03PS3) 10Cstone: WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [04:17:41] (03CR) 10CI reject: [V:04-1] WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 (owner: 10Cstone) [04:44:14] (03PS6) 10Cstone: Set default utms and set up calculated contrbution tracking params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) [04:45:53] (03CR) 10CI reject: [V:04-1] Set default utms and set up calculated contrbution tracking params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [05:05:28] (03PS1) 10Eileen: Add api batch action allowing individual batches to be generated [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360227 [05:10:51] (03PS2) 10Eileen: Add api batch action allowing individual batches to be generated [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360227 [05:10:51] (03PS1) 10Eileen: Add batch action to sk for re-sending batches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360228 [05:14:28] (03PS3) 10Eileen: Add api batch action allowing individual batches to be generated [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360227 [05:14:42] (03Abandoned) 10Eileen: Add batch action to sk for re-sending batches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360228 (owner: 10Eileen) [05:17:48] (03PS7) 10Cstone: Calculate utm_key and set up default utm_campaign and medium [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) [05:18:57] (03CR) 10CI reject: [V:04-1] Calculate utm_key and set up default utm_campaign and medium [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [05:20:16] (03PS8) 10Cstone: Calculate utm_key and set up default utm_campaign and medium [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) [05:23:00] (03CR) 10Cstone: "I was not testing this correctly, Dami had added in the referrer part a while ago so we don't need it here" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [05:24:42] (03CR) 10Cstone: [C:03+2] Add api batch action allowing individual batches to be generated [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360227 (owner: 10Eileen) [05:32:00] (03Merged) 10jenkins-bot: Add api batch action allowing individual batches to be generated [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360227 (owner: 10Eileen) [05:33:11] (03PS1) 10Eileen: SK tweak - show count [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360231 [05:33:43] (03CR) 10Cstone: [C:03+2] SK tweak - show count [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360231 (owner: 10Eileen) [05:34:11] (03PS2) 10Cstone: WIP: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [05:35:37] (03CR) 10CI reject: [V:04-1] WIP: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [05:36:06] (03Abandoned) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1359998 (owner: 10Eileen) [05:43:32] (03Merged) 10jenkins-bot: SK tweak - show count [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360231 (owner: 10Eileen) [05:44:32] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360235 [05:45:41] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360235 (owner: 10Eileen) [05:46:43] !log civicrm upgraded from d58bdb5c to d1dc8124 [05:46:45] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [05:52:25] (03PS1) 10Eileen: Send validation emails to logged in user when doing batch action, optional api param for cli [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360236 [12:56:04] (03PS2) 10Laurabarluzzi: ComboWiki: Add google pay option for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360356 (https://phabricator.wikimedia.org/T441850) [12:57:04] (03PS2) 10Damilare Adedoyin: Api updates for ACH to support Adyen v6.47 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1358833 (https://phabricator.wikimedia.org/T441954) [12:57:11] (03PS2) 10Damilare Adedoyin: Add validation error for invalid postal_code [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359962 (https://phabricator.wikimedia.org/T441954) [12:57:35] (03PS14) 10Damilare Adedoyin: Support for latest Adyen SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358435 (https://phabricator.wikimedia.org/T441954) [12:57:46] (03PS7) 10Damilare Adedoyin: Update translations for Adyen SDK v6 credit card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) [12:57:57] (03PS9) 10Damilare Adedoyin: Updates for ACH to support Adyen v6.47 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358835 (https://phabricator.wikimedia.org/T441954) [13:08:23] hi damilare [13:08:34] let me take one more quick look at those before C+2 [13:09:04] heyy ejegg, thanks! [13:09:39] I'm making the updates to the combowiki adyen card form now also. [13:10:04] oh great [13:10:25] i guess we can temporarily break that while we deploy the normal form though, right? [13:11:03] yea certainly [13:11:54] I've also updated config private API version to 72, so you might need to pull that down again [13:11:56] I'm trying to test the validation error but the submit button doesn't render for me https://gerrit.wikimedia.org/r/1359962 [13:12:39] checking laurabar [13:13:23] I see the submit button on this form: https://localhost:9001/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&payment_method=cc&recurring=0&uselang=en&language=en¤cy=USD&amount=10&country=US&first_name=Jimmy&last_name=Wales&street_address=1+Montgomery+Street&city=San+Francisco&state_province=CA&postal_code=94104&email=jwales%40example.com&debug=true [13:13:56] can you share the link you are working with laurabar ? [13:16:31] ah I was on master in payments => I was in the incorrect branch in DonationInterface [13:16:59] ohh cool [13:19:12] Should the validation error being shown inline by any chance? [13:23:08] yes it should be shown at the bottom of the postal code field [13:23:38] currently it shows an alert due to an unhandled error [13:24:37] ah ok, I see the alert now so that is expected for this patch? I see the reponse to the api request having Exception caught: Unknown Adyen error code 2_020", that is the configuration mapped [13:26:22] yes, on this patch, we expect an error to be shown at the bottom of the postal code field on the payment form as the alert isn't so helpful. [13:30:59] (03CR) 10Ejegg: [C:03+2] "This looks good and works well locally for cards, google, and apple pay. Nice job wrangling all the new callbacks and promises!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358435 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [13:31:28] (03CR) 10Ejegg: [C:03+2] "Thanks for working with the existing translations!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [13:32:31] (03Merged) 10jenkins-bot: Support for latest Adyen SDK [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358435 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [13:32:54] (03Merged) 10jenkins-bot: Update translations for Adyen SDK v6 credit card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359845 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [13:41:41] nice work laurabar turning around googlepay so fast [13:49:11] (03CR) 10Laurabarluzzi: [C:03+2] Add validation error for invalid postal_code [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359962 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [13:49:17] 10fundraising-tech-ops: Reevaluate fundraising grafana proxy configuration - https://phabricator.wikimedia.org/T320560#12489661 (10Jgreen) 05Open→03Declined We disabled Grafana Live in 2024, so far nobody cares. [13:50:37] damilare: I'll prep the deploy with just the initial changes [13:50:52] and put the traffic back to 0% adyen [13:52:18] cool cool, I'd check the config and logs [13:52:57] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1360418 [13:53:23] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1360418 (owner: 10Ejegg) [13:56:04] ok, traffic diversion to direct is back to 0% [13:56:20] going to prep the settings changes [13:58:51] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1360418 (owner: 10Ejegg) [14:02:03] ok damilare I just pushed the settings change up to the localsettings repo [14:02:19] checking [14:03:38] ejegg: I don't think the pal apis changed [14:03:46] the docs still have them on 68 [14:03:55] but shouldn't we keep those up to date? [14:04:17] https://docs.adyen.com/api-explorer/Payment/68/overview [14:04:23] I guess we can hold off for now but it feels wrong to stay behing for long [14:04:31] yh I mean the latest for those is still 68 [14:04:36] ohhhh [14:04:39] got it [14:04:50] https://docs.adyen.com/api-explorer/Recurring/68/overview [14:04:51] thanks, will undo those [14:05:51] oh lol I can remove that wsdl config [14:06:23] good ol' soap [14:06:41] k, i pushed another patch [14:09:22] lgtm ejegg ! [14:11:25] k, will push out the smashpig config bit first then the payments bit with code + config [14:13:07] !log payments-wiki upgraded from 9bfda667 to 3d53577c [14:13:08] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [14:14:04] going to wait 2 min more for cached payment method responses from the app to expire [14:14:36] oh maybe we should try an actual apple payment in 2 min to double check we haven't broken it [14:14:53] cool, just tested one and it was successful ^ [14:14:58] I'd try again in 2 mins [14:15:26] from testing in the UI can we tell if I'm going through the upgrade? [14:15:44] apple pay would allow you make payments on chrome [14:16:02] :ok [14:16:04] but you can also check the console to see the sdk versions [14:16:28] ah i mean we should also check a payment via the app [14:16:52] ok I'd try one on the app now [14:16:55] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen SEPA Component - https://phabricator.wikimedia.org/T441853#12489822 (10Laurabarluzzi) a:03Laurabarluzzi [14:16:56] I should have put my work phone on to charge earlier, it's all out of battery [14:17:02] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 07fr-combowiki, and 2 others: Add Braintree PayPal Vue Component - https://phabricator.wikimedia.org/T441803#12489823 (10jgleeson) [[ https://storymaps.io/p/wtlhy0lk/y2dwlvz6#slice-manua... [14:17:55] yh I just made another successful one on the app: 254779250.1 [14:20:08] nice, i'll start to put some organic traffic back on it [14:23:41] sounds good, no failures on my test so far [14:25:46] I tried also one SEPA with order_id: 254779414.1 (still awaiting to see the contribution in Civi) [14:28:26] Processed 🆗 [14:28:45] is there more testing to do? [14:29:02] For google/apple pay? [14:30:07] awesome! yea I have tested those but feel free to run another set of tests. [14:33:15] I tried one for Google Pay (254779628.1) and one Apple Pay (254779669.1) and they both processed correctly [14:34:26] damilare: do we get any benefits bumping to the new SDK? [14:34:32] did anything stand out [14:35:00] apple pay on chrome was the most obvious jgleeson [14:35:14] yeah that's a big one [14:35:16] nice [14:35:31] oh yeah, now we can divert some web apple pay traffic too [14:35:34] will start that [14:36:03] as well as push cc/gpay traffic to 50% [14:37:05] other than that, its just the way components are initialised and a new action property [14:37:40] 👍 [14:38:12] I just pushed another routing change to localsettings. Want to take a look before it goes to payments-wiki? [14:39:21] huh, looks like we have not been stopping folks in Australia from donating with PayPal if state is empty [14:41:17] even though in the config, it's marked as required [14:42:23] oh wait, we need to change it to USD for it to kick in [14:42:48] hang on [14:42:53] what's happening on live [14:43:16] https://payments.wikimedia.org/index.php?title=Special:GravyGateway&country=AU¤cy=AUD&payment_method=paypal&amount=10&uselang=en [14:43:24] so that redirects me right to paypal without stopping [14:43:41] oh no validation on that field? [14:43:48] but locally with https://localhost:9001/index.php?title=Special:GravyGateway&country=AU¤cy=AUD&payment_method=paypal&amount=10&uselang=en I get stopped [14:43:58] due to AUD [14:44:00] But this is Gravy; are we sure it wasn't behaving like this even before? [14:44:29] ohh jgleeson its because we didn't configure AUD on gravy as a supported currency on sandbox [14:44:32] this could be a sandbox config issue [14:44:33] jgleeson is the currency config overridden? [14:44:35] right damilare [14:44:48] so the validation has never worked [14:45:00] it just gets skipped via the JS [14:45:05] I didn't realise that could happen [14:45:23] I'll enable AUD on sandbox to replicate [14:45:31] ah shoot, i forget if the aus state requirement was a payment thing or a legal thing [14:45:47] I'm unable to login to gravy sandbox [14:45:57] ^-- still not working? [14:46:19] nah "Something went wrong" [14:46:20] ejegg: looks like we got it from Adyen settings [14:47:28] I think that if it was there in the config, let's support it; during internal testing we can always ask folks to confirm everything they see for en6c is required or not. [14:48:09] ok, it looks like in AUS the regulation of fundraising is at a state level not national [14:48:22] so maybe it was a legal thing? [14:48:39] that said, we should probably often get it from the paypal billing address [14:48:57] ^-- yeah I wonder if that is what happened [14:49:07] I am pretty sure I got stopped in the past while testing [14:49:41] I'm getting "429 Too Many Requests: 47c0cd02-ff4e-4b9b-a15d-b42e0bede236" when visiting https://payments.wikimedia.org/index.php?title=Special:GravyGateway&country=AU¤cy=AUD&payment_method=paypal&amount=10&uselang=en [14:49:59] thing is, I don't see any blocks locally on state level [14:51:29] looks like we're allowing them through without state https://wikimedia.gr4vy.app/merchants/default/transactions?limit=20&paymentServiceId=b4e49424-f463-4d0d-b05a-b427a4d21c95¤cy=AUD [14:51:37] I guess we can fix that separately [14:51:44] I'll enforce it in combowiki [14:52:43] 10Fundraising analytics stack, 10fundraising-tech-ops: trino issue on fransw1003 caused failures in the trino controller and metabase - https://phabricator.wikimedia.org/T438060#12490132 (10Jgreen) I studied this a bit and I suspect we aren't going to be able to identify an obvious cause. Looking at the change... [14:52:54] ^ I think in combowiki is already enforced since we automate the required fields and that is part of validation [14:53:34] it's not atm laurabar braintree config doesn't enforce it [14:53:52] which I'm guessing also applies to venmo live [14:53:57] But braintree should use the same shared form: paymentMethodFormFields.vue [14:54:01] actually not a problem - venmo is US [14:54:06] that uses already validation [14:54:26] laurabar: what I mean is, we're not telling combowiki (or the legacy forms) to enforce it in config [14:54:38] it was only in gr4vy config [14:54:41] Ah so the yaml file aren't up-to-date? [14:54:45] so I've updated it locally [14:54:49] right laurabar [14:54:53] gotcha [14:54:56] we never launched braintree paypal [14:55:05] due to a lack of zero-click [14:55:43] jgleeson: but do we want to collect that field before redirect if we're going to get it from the address? [14:56:04] ejegg: I guess we don't know if the address will always have it [14:56:12] looks like we don't get it for a fair few gr4vy paypals [14:56:12] Yeah, I think Christine created a phab durign our call yesterday; we need to update all Adyen+Braintree config yaml files to be up to date with our current requirements (e.g. opt_in, this one etc.) [14:56:16] Let's start with paypal not requiring it, so we have parity with existing forms [14:56:21] check https://wikimedia.gr4vy.app/merchants/default/transactions?limit=20&paymentServiceId=b4e49424-f463-4d0d-b05a-b427a4d21c95¤cy=AUD [14:56:35] then clarify if it's something we need to get later [14:56:40] that works [14:56:52] might have only been for Adyen processing, i dunno [14:56:54] ejegg: what do you mean parity with existing forms? [14:57:03] I can remove the card here :) https://storymaps.io/p/wtlhy0lk/y2dwlvz6#slice-manual-click-zhx2857e [14:57:30] laurabar if we're not enforcing it for existing gravy paypal, let's not enforce it for paypal via combowiki [14:57:41] and we weren't requiring it for paypal ec either [14:59:47] sorry, i got distracted, did anyone review that last routing change I pushed to localsettings? [15:03:44] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Log client errors - https://phabricator.wikimedia.org/T442886 (10Cstone) 03NEW [15:06:12] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Update contribution tracking on submit - https://phabricator.wikimedia.org/T442888 (10Cstone) 03NEW [15:06:34] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Update contribution tracking on submit - https://phabricator.wikimedia.org/T442888#12490277 (10Cstone) [15:06:53] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Log client errors - https://phabricator.wikimedia.org/T442886#12490280 (10Cstone) [15:07:41] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Allow FR-tech to redirect traffic to old flow with a settings change - https://phabricator.wikimedia.org/T440516#12490295 (10Cstone) Discussed this a bit with Dallas that we could also redirect it at the domain level [15:09:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Legacy Gravy PayPal form lets AU donors through without a state - https://phabricator.wikimedia.org/T442890 (10jgleeson) 03NEW [15:12:12] (03PS7) 10Jgleeson: ComboWiki: add Braintree PayPal with the PayPal button (Manual) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359898 (https://phabricator.wikimedia.org/T441803) [15:20:43] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Allow FR-tech to redirect traffic to old flow with a settings change - https://phabricator.wikimedia.org/T440516#12490425 (10Ejegg) Loading the root of https://donate.wikimedia.org/ currently does 2 redirects - the first one to... [15:24:19] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Allow FR-tech to redirect traffic to old flow with a settings change - https://phabricator.wikimedia.org/T440516#12490456 (10Ejegg) @Dwisehaupt would it make sense to have the redirect logic in a new PHP script that could live a... [15:26:43] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Allow FR-tech to redirect traffic to old flow with a settings change - https://phabricator.wikimedia.org/T440516#12490467 (10Ejegg) The big drawback of redirecting from the new domain is that many emails are already out there wi... [15:34:42] 10fundraising-tech-ops: Reevaluate fundraising grafana proxy configuration - https://phabricator.wikimedia.org/T320560#12490508 (10Jgreen) 05Declined→03Resolved [15:39:18] fr-tech I'm seeing 'Apple Pay is not supported in this browser' in safari on adyen checkout [15:39:38] maybe because this mbair can't get the latest iOS? [15:39:49] huh, I'll get my mac [15:39:52] are you all able to see the apple pay button? [15:40:30] I'm using a URL from the logs grep 254781603.1 payments-adyen [15:40:59] ejegg: if you dont have latest OS apple pay will just not work [15:41:10] k, that must be it [15:41:28] so even for cross-browser flow [15:41:58] and i guess that means this machine is now useless for its original purpose as it can't go past sequoia [15:42:06] ejegg: I see it [15:42:08] on safari [15:42:11] see the button [15:42:12] and on chrome [15:42:46] if i click it on safari it triggers the wallet stuff [15:42:52] so it works on updated machines [15:43:05] hmm ejegg i see it on sequoia [15:43:11] maybe i should have said updates and not os [15:43:41] i'm fully patched, huh [15:44:06] oh i had added the card to my apple account since starting the browser, maybe I need to quit and restart [15:44:27] if you go into your settings is apple pay completely disabled ? [15:44:36] oh let me check [15:45:29] aha i must have added the card in the wrong place [15:45:33] thanks cstone [15:45:57] ive updated the work macbook multiple times to test apple pay on latest just to run into what you ran into hah [15:46:06] oh boo, 'tester' is already using Apple Pay on this Mac. Only one user can use Apple Pay on this Mac [15:46:26] whaa [15:47:00] so it's a huge pain in the butt to use one machine for prod + sandbox testing [15:48:04] I guess while I'm using this as my primary machine I won't be able to use it to test in dev anyway [15:48:09] yeah i leave the work macbook logged into the test account [15:48:15] its super annoying [16:03:41] 10Fundraising analytics stack, 10fundraising-tech-ops, 10FR-Tech-Analytics: export donation data to blackbaud sftp server - https://phabricator.wikimedia.org/T440402#12490773 (10AStein-WMF) there's now a dagster job to do this: `transfer_blackbaud_donations_to_sftp` [16:03:45] 10Fundraising analytics stack, 10fundraising-tech-ops, 10FR-Tech-Analytics: export donation data to blackbaud sftp server - https://phabricator.wikimedia.org/T440402#12490774 (10AStein-WMF) 05Open→03Resolved [16:09:54] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 06Fundraising-Tech-Roadmap, 07Epic, 07fr-combowiki: Combowiki A/B testing - https://phabricator.wikimedia.org/T427983#12490803 (10Sjones-ctr) @AKanji-WMF I'm not entirely sure but my understanding from the latest ComboWiki discussions is that we'... [16:13:02] (03PS3) 10Jgleeson: ComboWiki: send donors who chose PayPal straight to PayPal (zero-click) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360468 (https://phabricator.wikimedia.org/T441803) [16:15:58] (03PS1) 10Damilare Adedoyin: Update ComboWiki Adyen Card to support v6.47.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360471 (https://phabricator.wikimedia.org/T441954) [16:17:23] (03CR) 10CI reject: [V:04-1] Update ComboWiki Adyen Card to support v6.47.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360471 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [16:25:19] 10Fundraising analytics stack: [Trino] Recovery Plan & Documentation - https://phabricator.wikimedia.org/T377361#12490899 (10AStein-WMF) a:05Arnis.dizdari→03None [16:25:33] 10Fundraising analytics stack: [Trino] Recovery Plan & Documentation - https://phabricator.wikimedia.org/T377361#12490901 (10AStein-WMF) [16:25:36] 10Fundraising analytics stack, 06Data-Engineering, 06Data-Engineering-Radar, 07Epic: EPIC: Trino implementation - https://phabricator.wikimedia.org/T392093#12490902 (10AStein-WMF) [16:26:46] 10Fundraising analytics stack, 06Data-Engineering, 06Data-Engineering-Radar, 07Epic: EPIC: Trino implementation - https://phabricator.wikimedia.org/T392093#12490906 (10AStein-WMF) 05Open→03Resolved [16:27:17] 10Fundraising analytics stack, 10fundraising-tech-ops: trino issue on fransw1003 caused failures in the trino controller and metabase - https://phabricator.wikimedia.org/T438060#12490915 (10AStein-WMF) sounds good! [16:33:25] (03PS2) 10Damilare Adedoyin: Update ComboWiki Adyen Card to support v6.47.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360471 (https://phabricator.wikimedia.org/T441954) [16:35:26] (03CR) 10CI reject: [V:04-1] Update ComboWiki Adyen Card to support v6.47.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360471 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [16:45:41] (03PS3) 10Damilare Adedoyin: Update ComboWiki Adyen Card to support v6.47.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360471 (https://phabricator.wikimedia.org/T441954) [16:46:06] (03PS4) 10Damilare Adedoyin: Update ComboWiki Adyen Card to support v6.47.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360471 (https://phabricator.wikimedia.org/T441954) [17:06:56] FIRING: NodeDown: Node frbast1002 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=frbast1002 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [17:11:56] RESOLVED: NodeDown: Node frbast1002 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=frbast1002 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [17:15:56] FIRING: NodeDown: Node frbast1002 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=frbast1002 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [17:20:56] RESOLVED: NodeDown: Node frbast1002 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=frbast1002 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [17:30:21] (03CR) 10Dmiranda: [C:03+2] Delete old country selector component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360011 (owner: 10Ejegg) [17:31:54] (03CR) 10Dmiranda: [C:03+2] Add wmf_key (and other wmf_ params) to API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359980 (owner: 10Ejegg) [17:32:11] (03Merged) 10jenkins-bot: Delete old country selector component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360011 (owner: 10Ejegg) [17:39:29] (03Merged) 10jenkins-bot: Add wmf_key (and other wmf_ params) to API calls [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359980 (owner: 10Ejegg) [17:42:00] 06Fundraising-Backlog, 06FR-donorrelations: iDEAL recurring donation not canceled after 2 chargebacks - https://phabricator.wikimedia.org/T442626#12491362 (10SBurnett-WMF) 05Open→03Declined this is being addressed already in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1359328 [17:49:14] 14Fundraising Sprint Hermit Crab Husbandry, 14Fundraising Sprint Internet Exploring, 14Fundraising Sprint Jabberwock Slaying, 14Fundraising Sprint Killing Time, and 6 others: CentralNotice: Slurp up existing wild cookies and copy them to LocalStorage or d... - https://phabricator.wikimedia.org/T132640#12491385 [17:56:07] (03CR) 10Dmiranda: [C:03+2] "Thanks @lsandergreen@wikimedia.org!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359328 (https://phabricator.wikimedia.org/T420775) (owner: 10Lars SG) [18:01:59] (03CR) 10Dmiranda: [C:03+2] Send browser info for all form submissions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357363 (https://phabricator.wikimedia.org/T441503) (owner: 10Ejegg) [18:03:07] (03PS1) 10Eileen: Port civicrm6.21 Alter batch.name length [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360505 [18:03:44] (03Merged) 10jenkins-bot: Send browser info for all form submissions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357363 (https://phabricator.wikimedia.org/T441503) (owner: 10Ejegg) [18:05:05] (03Merged) 10jenkins-bot: Cancel SEPA recurrings after three consecutive "chargebacks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359328 (https://phabricator.wikimedia.org/T420775) (owner: 10Lars SG) [18:09:01] (03CR) 10CI reject: [V:04-1] Port civicrm6.21 Alter batch.name length [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360505 (owner: 10Eileen) [18:09:55] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360505 (owner: 10Eileen) [18:21:55] (03CR) 10Laurabarluzzi: [C:03+2] Add reverse journal handling for endowment-first gateways [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 (owner: 10Eileen) [18:22:55] (03CR) 10Ejegg: [C:03+2] "Looks good, codes seem to match up with what's described." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [18:26:51] (03CR) 10Lars SG: [C:03+2] "I find this a little difficult to follow, but I'm going to +2 and then do a quick follow up instead." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359735 (owner: 10Eileen) [18:31:35] (03Merged) 10jenkins-bot: Add reverse journal handling for endowment-first gateways [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 (owner: 10Eileen) [18:35:50] (03Merged) 10jenkins-bot: Extract shared cross-instance transfer logic in writeJournalToCsv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359735 (owner: 10Eileen) [18:39:19] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations, and 2 others: Civi: display direct mail recipients more prominently to reduce visibility gap - https://phabricator.wikimedia.org/T397976#12491706 (10SHust) 05Open→03Resolved [18:43:36] (03PS1) 10Laurabarluzzi: ComboWiki: add messages for Adyen's card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360515 (https://phabricator.wikimedia.org/T441954) [18:46:23] (03CR) 10Laurabarluzzi: [C:03+2] "@dadedoyin@wikimedia.org Looks good but I added a chained patch to add the field labels that now appears to be necessary to render these l" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360471 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [18:48:08] (03Merged) 10jenkins-bot: Update ComboWiki Adyen Card to support v6.47.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360471 (https://phabricator.wikimedia.org/T441954) (owner: 10Damilare Adedoyin) [18:52:02] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Develop & implement retention policy for email addresses overwritten when donor provides new email address on donation form - https://phabricator.wikimedia.org/T434832#12491751 (10SHust) @Lars, here's another example: https://wikime... [19:03:50] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Allow FR-tech to redirect traffic to old flow with a settings change - https://phabricator.wikimedia.org/T440516#12491857 (10Dwisehaupt) I think there are multiple things at play here. What cstone and I discussed yesterday was a... [19:07:30] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for adding this fields. LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360515 (https://phabricator.wikimedia.org/T441954) (owner: 10Laurabarluzzi) [19:14:59] (03Merged) 10jenkins-bot: ComboWiki: add messages for Adyen's card fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360515 (https://phabricator.wikimedia.org/T441954) (owner: 10Laurabarluzzi) [19:24:20] (03CR) 10Jgleeson: [C:03+1] "I processed 3 local transactions without issue. One recurring and two one-time, so functionality looks good. Will dig into the code now. " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360356 (https://phabricator.wikimedia.org/T441850) (owner: 10Laurabarluzzi) [19:39:24] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations, and 3 others: We retry failed recurring SEPA/iDeal donations forever if the reason is retryable - https://phabricator.wikimedia.org/T420775#12492061 (10Lars) I'm going... [19:41:42] FIRING: MariadbReplicationRunning: MariaDB replica thread not running on : frdb1007.frack.eqiad.wmnet:9004 - https://frmon.wikimedia.org/d/000000273/mariadb-system?orgId=1&var-server=frdb1007.frack.eqiad.wmnet - https://alerts.wikimedia.org/?q=alertname%3DMariadbReplicationRunning [19:48:00] (03PS1) 10Jgleeson: Encrypt donor export with recipient public key [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1360527 (https://phabricator.wikimedia.org/T416948) [19:52:22] (03PS1) 10Lars SG: Simplify: Extract shared cross-instance transfer logic in writeJournalToCsv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360528 [19:52:40] (03CR) 10CI reject: [V:04-1] Simplify: Extract shared cross-instance transfer logic in writeJournalToCsv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360528 (owner: 10Lars SG) [19:54:07] (03PS2) 10Lars SG: Simplify: Extract shared cross-instance transfer logic in writeJournalToCsv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360528 [19:54:26] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog: Switch mediawiki_donor_export config from age identity file to age public key - https://phabricator.wikimedia.org/T442938 (10jgleeson) 03NEW [19:54:56] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog: Switch mediawiki_donor_export config from age identity file to age public key - https://phabricator.wikimedia.org/T442938#12492133 (10jgleeson) [19:55:08] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog: Switch mediawiki_donor_export config from age identity file to age public key - https://phabricator.wikimedia.org/T442938#12492134 (10jgleeson) [19:55:21] (03PS2) 10Jgleeson: Encrypt donor export with recipient public key [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1360527 (https://phabricator.wikimedia.org/T442938) [19:57:01] (03PS7) 10Eileen: Code CCK fees to GL 60931/60932 by endowment vs annual fund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) [19:59:20] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10fundraising-tech-ops, 13Patch-For-Review: Switch mediawiki_donor_export config from age identity file to age public key - https://phabricator.wikimedia.org/T442938#12492142 (10Dwisehaupt) [20:00:13] (03CR) 10Lars SG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359736 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [20:02:41] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10Mail: mx-out* relay access denied for fundraising subnets - https://phabricator.wikimedia.org/T442940 (10Jgreen) 03NEW p:05Triage→03Unbreak! [20:06:42] FIRING: MariadbReplicationRunning: MariaDB replica thread not running on : frdb1007.frack.eqiad.wmnet:9004 for >30m - https://frmon.wikimedia.org/d/000000273/mariadb-system?orgId=1&var-server=frdb1007.frack.eqiad.wmnet - https://alerts.wikimedia.org/?q=alertname%3DMariadbReplicationRunning [20:13:25] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360532 [20:13:37] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360532 (owner: 10Eileen) [20:14:29] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360532 (owner: 10Eileen) [20:19:55] (03CR) 10Lars SG: [C:03+2] Encrypt donor export with recipient public key [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1360527 (https://phabricator.wikimedia.org/T442938) (owner: 10Jgleeson) [20:20:35] * civicrm upgraded from d1dc8124 to 3f3fbbe5 [20:20:36] * config revision changed from f2c4409f to 9e3798de [20:20:39] !log * civicrm upgraded from d1dc8124 to 3f3fbbe5 [20:20:39] * config revision changed from f2c4409f to 9e3798de [20:20:41] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [20:22:33] (03Merged) 10jenkins-bot: Encrypt donor export with recipient public key [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1360527 (https://phabricator.wikimedia.org/T442938) (owner: 10Jgleeson) [20:24:23] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10Mail: mx-out* relay access denied for fundraising subnets - https://phabricator.wikimedia.org/T442940#12492254 (10Jgreen) @jhathaway I think it could be this change? ` commit f0cd9ba04de0b7938ca9839eff14fb36d82cd109 Author: Jesse Hathaway 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Allow FR-tech to redirect traffic to old flow with a settings change - https://phabricator.wikimedia.org/T440516#12492290 (10Ejegg) I'd prefer a switch that fr-tech can control since we've got pretty wide geographic coverage. I'... [20:36:42] RESOLVED: MariadbReplicationRunning: MariaDB replica thread not running on : frdb1007.frack.eqiad.wmnet:9004 - https://frmon.wikimedia.org/d/000000273/mariadb-system?orgId=1&var-server=frdb1007.frack.eqiad.wmnet - https://alerts.wikimedia.org/?q=alertname%3DMariadbReplicationRunning [20:36:42] RESOLVED: MariadbReplicationRunning: MariaDB replica thread not running on : frdb1007.frack.eqiad.wmnet:9004 for >30m - https://frmon.wikimedia.org/d/000000273/mariadb-system?orgId=1&var-server=frdb1007.frack.eqiad.wmnet - https://alerts.wikimedia.org/?q=alertname%3DMariadbReplicationRunning [20:37:43] (03CR) 10Ejegg: "Seems fine to me too, just noting this records it as a 'cancel' not a 'fail'. But I guess we can revisit this when we decide to try to sen" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1359328 (https://phabricator.wikimedia.org/T420775) (owner: 10Lars SG) [20:40:07] (03PS2) 10Eileen: Send validation emails to logged in user when doing batch action, optional api param for cli [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360236 [20:40:11] (03CR) 10Ejegg: [C:03+2] Send validation emails to logged in user when doing batch action, optional api param for cli [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360236 (owner: 10Eileen) [20:40:17] (03PS2) 10Eileen: Port civicrm6.21 Alter batch.name length [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360505 [20:40:20] (03CR) 10Ejegg: [C:03+2] Port civicrm6.21 Alter batch.name length [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360505 (owner: 10Eileen) [20:41:17] oho, i found the country list used in the donatewiki country selector [20:41:24] https://donate.wikimedia.org/w/index.php?title=Module:Country_links/data.json&action=edit [20:41:33] that's better than the cldr list [20:41:58] I guess not quite as many languages [20:45:45] (03PS1) 10Ejegg: Add country names from donatewiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360541 [20:48:48] (03Merged) 10jenkins-bot: Send validation emails to logged in user when doing batch action, optional api param for cli [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360236 (owner: 10Eileen) [20:49:27] (03Merged) 10jenkins-bot: Port civicrm6.21 Alter batch.name length [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360505 (owner: 10Eileen) [20:49:40] (03PS1) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [20:50:32] fr-tech ok there's a sketchy version of the date encapsulation [20:50:42] maybe laurabar can take a look tomorrow [20:50:50] i need to smoke test locally [20:51:05] ah looks like CI found issues too [20:51:30] (03CR) 10CI reject: [V:04-1] Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [20:52:46] (03PS2) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [20:53:51] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10Mail: mx-out* relay access denied for fundraising subnets - https://phabricator.wikimedia.org/T442940#12492343 (10LSobanski) The CR mentioned above is https://gerrit.wikimedia.org/r/c/operations/puppet/+/1358850 and the related task is {T442063} [20:57:26] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10WikimediaCustomizations, and 2 others: CentralNotice should expose functions that encapsulate the structure of the hide cookie - https://phabricator.wikimedia.org/T441349#12492357 (10... [20:57:38] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10WikimediaCustomizations, and 2 others: CentralNotice should expose functions that encapsulate the structure of the hide cookie - https://phabricator.wikimedia.org/T441349#12492358 (10... [21:11:47] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360547 [21:11:58] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360547 (owner: 10Eileen) [21:12:51] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1360547 (owner: 10Eileen) [21:14:08] !log * civicrm upgraded from 3f3fbbe5 to 5d2a3573 [21:14:10] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:27:27] (03CR) 10Jgleeson: [C:03+1] "I spotted one minor thing, but otherwise this looks good to me! Nice job." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360356 (https://phabricator.wikimedia.org/T441850) (owner: 10Laurabarluzzi) [21:34:06] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10Mail: mx-out* relay access denied for fundraising subnets - https://phabricator.wikimedia.org/T442940#12492479 (10BCornwall) @Jgreen, I've reverted the CR due to UBN and deployed to `crm2001.codfw.wmnet,mx-in[1001,2001].wikimedia.org,mx-out[1001,2001].w... [21:34:16] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10Mail: mx-out* relay access denied for fundraising subnets - https://phabricator.wikimedia.org/T442940#12492480 (10BCornwall) 05Open→03In progress a:03BCornwall [21:57:44] (03PS1) 10Pwangai: Add a CI script to run the test suite in parallel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) [22:02:13] (03PS2) 10Pwangai: Add a CI script to run the test suite in parallel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) [22:07:11] (03CR) 10Laurabarluzzi: [C:03+1] "Thanks! The configs were updated and I could get payments in the accounts. I do a +1 so to wait if someone else can further test. An examp" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359898 (https://phabricator.wikimedia.org/T441803) (owner: 10Jgleeson) [22:11:28] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 07fr-combowiki, and 2 others: Add Braintree PayPal Vue Component - https://phabricator.wikimedia.org/T441803#12492690 (10jgleeson) [22:12:27] ty laurabar [22:12:29] signing off now [22:12:36] good luck with internal testing all! [22:12:41] bye for now o/ [22:13:57] (03PS3) 10Pwangai: Add a CI script to run the test suite in parallel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) [22:28:50] (03PS1) 10Lars SG: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1360565 [22:30:23] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1360565 (owner: 10Lars SG) [22:30:54] (03Merged) 10jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1360565 (owner: 10Lars SG) [22:31:38] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10Mail: mx-out* relay access denied for fundraising subnets - https://phabricator.wikimedia.org/T442940#12492758 (10BCornwall) 05In progress→03Resolved Confirmed with @Jgreen that the revert fixed the issue. We'll follow up with re-implementation... [22:38:03] !log tools upgraded from ccc34c76 to 1411e217 [22:38:05] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [22:51:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: CKEditor 5 doesn't open on new user-driven message templates - https://phabricator.wikimedia.org/T442745#12492895 (10Lars) A couple upstream patches for CKEditor5: https://lab.civicrm.org/extensions/ckeditor... [23:20:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: CKEditor 5 doesn't open on new user-driven message templates - https://phabricator.wikimedia.org/T442745#12492980 (10Lars) And a core patch: https://github.com/civicrm/civicrm-core/pull/37801 [23:26:41] !log donorwiki upgraded from 9bfda667 to 3d53577c [23:26:43] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [23:44:08] (03PS1) 10Damilare Adedoyin: Add Adyen ApplePay component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360570 (https://phabricator.wikimedia.org/T441849) [23:50:06] (03PS2) 10Damilare Adedoyin: Add Adyen ApplePay component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360570 (https://phabricator.wikimedia.org/T441849) [23:52:41] (03PS1) 10Eileen: Also be flexible about amount breakdown for ach, wire [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360572 (https://phabricator.wikimedia.org/T434041)