[00:01:47] (03PS1) 10Damilare Adedoyin: Share functions between Adyen Card and ApplePay Components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360573 [00:16:50] FIRING: KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [00:21:00] (03CR) 10Dmiranda: [C:03+2] "Thanks @jgleeson@wikimedia.org! Tested and approved" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360468 (https://phabricator.wikimedia.org/T441803) (owner: 10Jgleeson) [00:21:50] FIRING: [2x] KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [00:22:54] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 07fr-combowiki, and 2 others: Add Braintree PayPal Vue Component - https://phabricator.wikimedia.org/T441803#12493080 (10dmiranda) Thanks @jgleeson I've tested the zero click flow and bo... [01:00:27] 06Fundraising-Backlog, 10FR-WMF-Audit: Create adjustment process for recategorised gifts - https://phabricator.wikimedia.org/T442975 (10Eileenmcnaughton) 03NEW [01:08:51] (03PS3) 10Cstone: WIP: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [01:09:05] (03CR) 10CI reject: [V:04-1] WIP: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [01:47:07] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Read only civi access for Julie Ian-Wong - https://phabricator.wikimedia.org/T442977 (10Eileenmcnaughton) 03NEW [02:09:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: CKEditor 5 doesn't open on new user-driven message templates - https://phabricator.wikimedia.org/T442745#12493294 (10Lars) And one small improvement in core also: https://github.com/civicrm/civicrm-core/pull... [02:11:43] (03PS8) 10Jgleeson: ComboWiki: add Braintree PayPal with the PayPal button (Manual) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359898 (https://phabricator.wikimedia.org/T441803) [02:11:51] (03PS4) 10Jgleeson: ComboWiki: send donors who chose PayPal straight to PayPal (zero-click) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360468 (https://phabricator.wikimedia.org/T441803) [02:22:01] (03CR) 10Cstone: [C:03+2] "thanks!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359898 (https://phabricator.wikimedia.org/T441803) (owner: 10Jgleeson) [02:22:12] (03CR) 10Cstone: [C:03+2] "re-adding the +2 after rebase" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360468 (https://phabricator.wikimedia.org/T441803) (owner: 10Jgleeson) [02:23:54] (03Merged) 10jenkins-bot: ComboWiki: add Braintree PayPal with the PayPal button (Manual) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359898 (https://phabricator.wikimedia.org/T441803) (owner: 10Jgleeson) [02:24:29] (03Merged) 10jenkins-bot: ComboWiki: send donors who chose PayPal straight to PayPal (zero-click) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360468 (https://phabricator.wikimedia.org/T441803) (owner: 10Jgleeson) [02:45:14] (03PS1) 10Eileen: Extract GenerateBatch's per-journal Intacct push into its own method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360590 (https://phabricator.wikimedia.org/T442975) [02:45:16] (03PS1) 10Eileen: Extract the single-journal Intacct push out of pushJournalsToIntacct() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360591 (https://phabricator.wikimedia.org/T442975) [02:46:12] (03CR) 10CI reject: [V:04-1] Extract GenerateBatch's per-journal Intacct push into its own method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360590 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [02:46:28] (03CR) 10CI reject: [V:04-1] Extract the single-journal Intacct push out of pushJournalsToIntacct() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360591 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [02:50:35] (03CR) 10Sanskardubey: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1317655 (https://phabricator.wikimedia.org/T433149) (owner: 10Zaidusyy) [02:58:01] (03PS2) 10Eileen: Extract GenerateBatch's per-journal Intacct push into its own method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360590 (https://phabricator.wikimedia.org/T442975) [02:58:01] (03PS2) 10Eileen: Extract the single-journal Intacct push out of pushJournalsToIntacct() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360591 (https://phabricator.wikimedia.org/T442975) [03:01:50] (03PS2) 10Eileen: Also be flexible about amount breakdown for ach, wire [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360572 (https://phabricator.wikimedia.org/T434041) [03:19:10] (03PS1) 10Eileen: Have GenerateBatch acquire the settlement batch lock before export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360600 (https://phabricator.wikimedia.org/T442975) [03:19:37] (03PS1) 10Eileen: Add custom data group for recording GL code & endowmentiness changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360601 (https://phabricator.wikimedia.org/T442975) [03:27:32] (03CR) 10CI reject: [V:04-1] Have GenerateBatch acquire the settlement batch lock before export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360600 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [03:28:18] (03CR) 10CI reject: [V:04-1] Add custom data group for recording GL code & endowmentiness changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360601 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [03:33:43] (03CR) 10Lars SG: Also be flexible about amount breakdown for ach, wire (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360572 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [03:33:46] (03CR) 10Cstone: [C:03+2] Also be flexible about amount breakdown for ach, wire [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360572 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [03:35:48] (03CR) 10Lars SG: [C:03+2] Extract GenerateBatch's per-journal Intacct push into its own method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360590 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [03:37:15] uh oh cstone, we're overlapping [03:37:27] hah [03:37:29] LOL [03:37:33] eileen: I do have one question on https://gerrit.wikimedia.org/r/1360572 [03:37:33] same minute! [03:37:47] are you doing more? [03:38:04] no you do it [03:38:07] i just came back to the computer [03:38:32] feel free to look at the last one, I don't think I'm going to make it through the whole chain [03:38:44] hah okay ill come back to it in a bit and see whats left [03:38:56] oh, those last two are failing anyway [03:41:06] (03CR) 10Lars SG: [C:03+2] Extract the single-journal Intacct push out of pushJournalsToIntacct() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360591 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [03:41:48] (03CR) 10Lars SG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360600 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [03:44:50] (03Merged) 10jenkins-bot: Also be flexible about amount breakdown for ach, wire [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360572 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [03:47:17] (03Merged) 10jenkins-bot: Extract GenerateBatch's per-journal Intacct push into its own method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360590 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [03:51:35] (03Merged) 10jenkins-bot: Extract the single-journal Intacct push out of pushJournalsToIntacct() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360591 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [03:52:29] (03CR) 10Cstone: [C:03+2] show braintree qr instead of login for easy payment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359358 (owner: 10Wfan) [03:54:13] (03Merged) 10jenkins-bot: show braintree qr instead of login for easy payment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359358 (owner: 10Wfan) [03:54:36] (03CR) 10Cstone: [C:03+2] epc render fail page when civiproxy 500 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357918 (https://phabricator.wikimedia.org/T440660) (owner: 10Wfan) [03:56:18] (03Merged) 10jenkins-bot: epc render fail page when civiproxy 500 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1357918 (https://phabricator.wikimedia.org/T440660) (owner: 10Wfan) [04:04:26] (03PS9) 10Cstone: Calculate utm_key and set up default utm_campaign and medium [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) [04:06:16] (03PS10) 10Cstone: Calculate utm_key and set up default utm_campaign and medium [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) [04:07:23] (03PS4) 10Cstone: WIP: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [04:09:21] (03CR) 10CI reject: [V:04-1] WIP: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [04:39:34] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_46) - 10https://gerrit.wikimedia.org/r/1360654 (owner: 10L10n-bot) [04:58:54] (03PS5) 10Cstone: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [05:00:09] (03CR) 10CI reject: [V:04-1] Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [05:07:36] (03PS6) 10Cstone: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [05:39:14] (03PS2) 10Eileen: Have GenerateBatch acquire the settlement batch lock before export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360600 (https://phabricator.wikimedia.org/T442975) [05:39:14] (03PS2) 10Eileen: Add custom data group for recording GL code & endowmentiness changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360601 (https://phabricator.wikimedia.org/T442975) [05:39:14] (03PS1) 10Eileen: Record a FinancialDataAdjustment when gl_code/financial_type is corrected [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360787 (https://phabricator.wikimedia.org/T442975) [05:40:47] (03CR) 10CI reject: [V:04-1] Have GenerateBatch acquire the settlement batch lock before export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360600 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [05:41:21] (03CR) 10CI reject: [V:04-1] Add custom data group for recording GL code & endowmentiness changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360601 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [05:41:37] (03CR) 10CI reject: [V:04-1] Record a FinancialDataAdjustment when gl_code/financial_type is corrected [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360787 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [06:00:18] (03PS3) 10Eileen: Have GenerateBatch acquire the settlement batch lock before export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360600 (https://phabricator.wikimedia.org/T442975) [06:00:18] (03PS3) 10Eileen: Add custom data group for recording GL code & endowmentiness changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360601 (https://phabricator.wikimedia.org/T442975) [06:00:18] (03PS2) 10Eileen: Record a FinancialDataAdjustment when gl_code/financial_type is corrected [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360787 (https://phabricator.wikimedia.org/T442975) [06:01:39] (03CR) 10CI reject: [V:04-1] Have GenerateBatch acquire the settlement batch lock before export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360600 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [06:02:08] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360600 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [06:02:14] (03CR) 10CI reject: [V:04-1] Add custom data group for recording GL code & endowmentiness changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360601 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [06:02:31] (03CR) 10CI reject: [V:04-1] Record a FinancialDataAdjustment when gl_code/financial_type is corrected [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360787 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [06:40:39] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360600 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [09:26:44] (03CR) 10Laurabarluzzi: "The overall code looks good to me. I left some comments/questions with the scope of further understanding the usage of this value. Without" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [10:35:50] (03CR) 10Laurabarluzzi: [C:04-1] "I think we could refactor this a bit although it's a bit confusing how this flow interacts with adapter's code. I would propose mostly a c" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [13:55:13] 06Fundraising-Backlog, 07Fundraising-FRUP, 07Epic: Fundraiseup sunsetting - https://phabricator.wikimedia.org/T391961#12495258 (10SBurnett-WMF) @Damilare or @XenoRyet - can we close this? There hasn't been any new activity in more than a year and all associated tasks are resolved. [13:56:05] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: test - anil - https://phabricator.wikimedia.org/T442567#12495264 (10SBurnett-WMF) 05Open→03Resolved a:03SBurnett-WMF [13:59:49] (03CR) 10Laurabarluzzi: Add country names from donatewiki (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360541 (owner: 10Ejegg) [14:00:34] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-CentralNotice, 06SRE, 06Traffic: Set expiry time for GeoIP cookies - https://phabricator.wikimedia.org/T122097#12495291 (10SBurnett-WMF) @ssingh - would Q3 work for this? [14:08:15] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-CiviCRM-Core-Team, and 3 others: Replace Activities tab in CiviCRM with SearchKit - https://phabricator.wikimedia.org/T412251#12495314 (10SBurnett-WMF) @Lars - have the updates resolved the slow loading that would allo... [14:17:01] FIRING: HostHighCpuLoad: Host high CPU load (instance fransw1001.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostHighCpuLoad [14:22:01] RESOLVED: HostHighCpuLoad: Host high CPU load (instance fransw1001.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostHighCpuLoad [14:38:01] FIRING: HostHighCpuLoad: Host high CPU load (instance fransw1001.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostHighCpuLoad [14:48:01] RESOLVED: HostHighCpuLoad: Host high CPU load (instance fransw1001.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostHighCpuLoad [14:56:48] (03PS3) 10Laurabarluzzi: ComboWiki: Add google pay option for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360356 (https://phabricator.wikimedia.org/T441850) [14:58:30] (03CR) 10Laurabarluzzi: ComboWiki: Add google pay option for Adyen (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360356 (https://phabricator.wikimedia.org/T441850) (owner: 10Laurabarluzzi) [15:05:24] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Read only civi access for Julie Ian-Wong - https://phabricator.wikimedia.org/T442977#12495591 (10greg) [15:06:27] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikimedia-Fundraising-CiviCRM: Read only civi access for Julie Ian-Wong - https://phabricator.wikimedia.org/T442977#12495610 (10greg) > -------- Forwarded Message -------- > Subject: Re: request for approval - Civi access for Julie Ian-Wong > Date: Thu, 29 O... [15:49:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Paypal recurrings refunded via the resolution center don't cancel the recurring - https://phabricator.wikimedia.org/T442249#12495802 (10dmiranda) a:03dmiranda [15:49:32] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Paypal recurrings refunded via the resolution center don't cancel the recurring - https://phabricator.wikimedia.org/T442249#12495809 (... [16:04:19] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-CiviCRM-Core-Team, and 3 others: Replace Activities tab in CiviCRM with SearchKit - https://phabricator.wikimedia.org/T412251#12495903 (10Lars) @SBurnett-WMF Core team still has this on their list, the link above is ju... [16:24:41] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Add Braintree Venmo Vue Component - https://phabricator.wikimedia.org/T441808#12495978 (10AnnWF) [16:26:11] 06Fundraising-Backlog, 07Epic: Epic: Support retrieval of page and banner view data for FR Analytics - https://phabricator.wikimedia.org/T369773#12495982 (10SBurnett-WMF) 05Open→03Resolved [16:27:15] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic, 07FR-Audience-Dev: Adding and storing rml_source data for RML donations reporting - https://phabricator.wikimedia.org/T321163#12495983 (10Lars) @MSuijkerbuijk_WMF Is this still something we want to do? [16:28:42] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-DonationInterface, 0725 Dec Q3 Planning: DonationInterface: Combine payments-initial and contribution-tracking data to make new payments_event_log - https://phabricator.wikimedia.org/T317988#12495985 (10SBurnett-WMF) 05Open→03... [16:41:18] (03PS1) 10Lars SG: Use default SmashPig provider for forgetme data deletion [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357796 (https://phabricator.wikimedia.org/T442061) [16:47:20] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10fundraising-tech-ops: Switch mediawiki_donor_export config from age identity file to age public key - https://phabricator.wikimedia.org/T442938#12496133 (10Dwisehaupt) Config change for the public key has been pushed. Addi... [16:49:53] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10fundraising-tech-ops: Switch mediawiki_donor_export config from age identity file to age public key - https://phabricator.wikimedia.org/T442938#12496145 (10Lars) Thanks @dwisehaupt, that worked. [16:50:57] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Handle host key changes for mediawiki export job - https://phabricator.wikimedia.org/T442774#12496151 (10Lars) 05Open→03Resolved a:03Lars We've decided to just remove the host key check entirely, per @dwisehaupt. [17:21:19] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikimedia-Fundraising-CiviCRM: Read only civi access for Julie Ian-Wong - https://phabricator.wikimedia.org/T442977#12496333 (10Dwisehaupt) Julie already has a valid ssl client cert and metabase access. Civicrm account created and assigned the "View Only" role... [17:22:09] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikimedia-Fundraising-CiviCRM: Read only civi access for Julie Ian-Wong - https://phabricator.wikimedia.org/T442977#12496346 (10Dwisehaupt) [17:35:58] (03PS1) 10Umherirrender: Use const for a constant arrays in CampaignLog [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360955 [17:51:14] (03CR) 10Lars SG: "We do also write to the fredge and smashpig databases in tests. I'm guessing these are unlikely to collide based on your tests so far, but" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) (owner: 10Pwangai) [17:51:57] (03CR) 10Jdlrobson: "Before using this in WikimediaCustomizations I'd like to see this public API documented on docs.wikimedia.org" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [17:52:32] (03PS1) 10Jdlrobson: Documentation: Document public APIs for CentralNotice [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360958 [17:54:31] (03CR) 10Jdlrobson: [C:04-1] Documentation: Document public APIs for CentralNotice (0315 comments) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360958 (owner: 10Jdlrobson) [17:55:09] (03PS2) 10Jdlrobson: Documentation: Document public APIs for CentralNotice [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360958 [17:55:13] (03CR) 10Jdlrobson: [C:04-1] Documentation: Document public APIs for CentralNotice [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360958 (owner: 10Jdlrobson) [18:55:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Improve core cache clearing after Oct deploy incident - https://phabricator.wikimedia.org/T443053 (10Lars) 03NEW [18:56:13] (03CR) 10Ejegg: "Thanks for starting to document this stuff! I gave some initial feedback. When I have time to dig through the git blame for that file I ca" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [18:57:17] (03PS3) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [19:22:41] (03PS2) 10Lars SG: Remove reference to class that doesn't exist [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1357794 (https://phabricator.wikimedia.org/T442061) [19:28:19] (03PS3) 10Lars SG: Remove reference to class that doesn't exist [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1357794 (https://phabricator.wikimedia.org/T442061) [19:28:23] (03CR) 10Ejegg: [C:03+2] Remove reference to class that doesn't exist [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1357794 (https://phabricator.wikimedia.org/T442061) (owner: 10Lars SG) [19:28:54] (03Merged) 10jenkins-bot: Remove reference to class that doesn't exist [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1357794 (https://phabricator.wikimedia.org/T442061) (owner: 10Lars SG) [19:52:57] (03PS2) 10Lars SG: Use default SmashPig provider for forgetme data deletion [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357796 (https://phabricator.wikimedia.org/T442061) [19:53:10] (03CR) 10Ejegg: [C:03+2] Use default SmashPig provider for forgetme data deletion [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357796 (https://phabricator.wikimedia.org/T442061) (owner: 10Lars SG) [19:53:22] (03PS5) 10Ejegg: Use backend processor to get forgetme provider [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357818 (https://phabricator.wikimedia.org/T442061) [19:54:57] tks ejegg [20:01:48] (03Merged) 10jenkins-bot: Use default SmashPig provider for forgetme data deletion [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357796 (https://phabricator.wikimedia.org/T442061) (owner: 10Lars SG) [20:07:28] (03CR) 10Ejegg: Add country names from donatewiki (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360541 (owner: 10Ejegg) [20:22:31] (03CR) 10Jdlrobson: [C:04-1] "I'd suggest adding some tests that confirm the possible shapes of the data. You can copy the existing ones in WikimediaCustomizations" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [20:24:14] (03PS3) 10Lars SG: Don't use table locking on queue_items [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357525 (https://phabricator.wikimedia.org/T436478) [20:25:37] (03CR) 10Ejegg: [C:03+2] "Looks like a solid strategy for letting only one process claim a row." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357525 (https://phabricator.wikimedia.org/T436478) (owner: 10Lars SG) [20:33:08] (03Merged) 10jenkins-bot: Don't use table locking on queue_items [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357525 (https://phabricator.wikimedia.org/T436478) (owner: 10Lars SG) [21:09:27] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360541 (owner: 10Ejegg) [21:09:45] oh thanks laurabar [21:10:29] I might actually switch to the other JSON file you pointed to, if there is already an (abandoned) patch to parse it. Sorry, I should have indicated that with a C-1 on that patch ^^^ [21:11:11] (03CR) 10Ejegg: [C:04-1] "Sorry, it might actually be nicer to switch to using the JSON file Laura pointed to in the abandoned patch." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360541 (owner: 10Ejegg) [21:12:07] Sounds good, I built it thinking about the needs in combowiki but I don't know if it'd work well with donate wiki [21:12:35] laurabar: it looks like the names are mostly the same, or at least not so abbreviated as the ones from CLDR [21:13:11] i'm not suggesting changing donatewiki, just wanting the values in combowiki to match the ones already on donatewiki [21:14:32] Perfect, it was what I wanted to do. That filed I generated was a copy of data.json from donatewiki minus the regions. Plus, I added the mapping of country and currency codes (i was trying to join all config required for the country+currency dropdown in ComboWiki) [21:15:01] ah cool, so it was derived from the same source [21:15:07] Yes [21:16:48] The phab is a bit noisy, but in here you can read a comment behind that patch: https://phabricator.wikimedia.org/T433012#12311367 [21:19:06] ah hmm, so your patch is a trade-off between smaller initial page load but larger total bytes as it does load names for all languages [21:19:32] We still pass all the countries as params though [21:19:38] I guess I do prefer sending just the names for the current language [21:19:45] as a client variable [21:20:03] we can definitely streamline that client config, huh? [21:20:35] Yeah, I don't know. I mostly though it's a static asset we don't need to read each type and that can be heavily cached. [21:21:09] how often do country name change? Or currencies? But I think one of the issues was translations [21:21:24] (you can see the comment in the code-review of the abandoned patch) [21:23:18] If we want to have 1 way to deal wtih translations, this file looses its appeal. Keeping what we do now, we would need to load translations for each country in each language I guess. [21:24:17] ah actually we passed the translated names via config already; so that is resolved and it's nice. [21:24:38] So I think in combowiki currently it doesn't make anymore sense the countries.json mapping [21:25:21] ok, so the full initial pageload is 37kb, and the countries are 15kb of that [21:25:38] i mean, that's substantial [21:25:59] I wonder if we could store the countries into a file and have that file cached [21:26:16] you mean per-language? [21:26:28] We could do a resource loader module for them [21:26:51] that would probably be the most optimized [21:27:05] it could be bundled in the same load.php request [21:27:11] but this all seems post-MVP [21:27:14] I'll make a phab [21:27:22] load.php though changes a lot [21:28:14] In my abandoned patch I did one file with all languages and had it in its own recourse module so the cache was not busted for every code change (e.g. CSS) [21:28:27] but I dont know how it'd look like with 1 file per language [21:28:44] Agreed it's low priority now [21:29:14] we wouldn't have to break the source file apart - a RL module can serve language-specific content, I'm pretty sure [21:29:39] RL is the same component that provides the messages to the front-end, so it's already doing a bunch of language-specific caching [21:29:41] First we should reconfigure configurations in general (this could fall into that naturally) [21:29:55] right [21:30:19] the fact that validation rules aren't under the payment methods key is a bit triggering :) [21:30:35] oh i need to see what's up with my kiddo, hearing some unhappy sounds. [21:55:55] ejegg I noticed that you try to add https://donate.wikimedia.org/w/index.php?title=Module:Country_links/data.json locally, is that a reason to do beside CLDR, what do you mean clearer? [21:56:40] AI noticed that we had the paypal modal popup with out pre selected amount, could we do a fallback amount suggestions? [22:05:30] (03PS2) 10Umherirrender: Use const for constant arrays in CampaignLog [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360955 [23:06:00] (03PS5) 10Lars SG: Use backend processor to get forgetme provider [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357818 (https://phabricator.wikimedia.org/T442061) (owner: 10Ejegg) [23:06:23] (03CR) 10Lars SG: [C:03+2] Use backend processor to get forgetme provider [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357818 (https://phabricator.wikimedia.org/T442061) (owner: 10Ejegg) [23:14:05] (03Merged) 10jenkins-bot: Use backend processor to get forgetme provider [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1357818 (https://phabricator.wikimedia.org/T442061) (owner: 10Ejegg) [23:37:42] (03CR) 10Wfan: "LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360356 (https://phabricator.wikimedia.org/T441850) (owner: 10Laurabarluzzi) [23:38:50] 06Fundraising-Backlog, 07fr-combowiki: Prevent donation when amount not selected - https://phabricator.wikimedia.org/T443094#12497778 (10AnnWF) [23:39:08] (03CR) 10Wfan: [C:03+2] ComboWiki: Add google pay option for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360356 (https://phabricator.wikimedia.org/T441850) (owner: 10Laurabarluzzi) [23:40:37] (03Merged) 10jenkins-bot: ComboWiki: Add google pay option for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360356 (https://phabricator.wikimedia.org/T441850) (owner: 10Laurabarluzzi) [23:48:36] (03CR) 10Lars SG: "Sorry, one more issue here" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1334162 (https://phabricator.wikimedia.org/T436878) (owner: 10Eileen) [23:50:37] 10fundraising-tech-ops: Fundraising access request for Jayde Antonio - https://phabricator.wikimedia.org/T440206#12497785 (10Dwisehaupt) 05Open→03Resolved Closing for now. Can reopen if there are any issues with login or access. [23:50:55] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikimedia-Fundraising-CiviCRM: Read only civi access for Julie Ian-Wong - https://phabricator.wikimedia.org/T442977#12497788 (10Dwisehaupt) [23:52:33] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikimedia-Fundraising-CiviCRM: Read only civi access for Julie Ian-Wong - https://phabricator.wikimedia.org/T442977#12497789 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Some updates were needed to the `View only` role in civicrm unrelated to Juli... [23:55:48] (03PS8) 10Eileen: Do not let case mismatches block NamePair resolution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1334162 (https://phabricator.wikimedia.org/T436878)