[00:12:16] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361036 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [00:28:33] (03PS10) 10Eileen: Record a FinancialDataAdjustment when gl_code/financial_type is corrected [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360787 (https://phabricator.wikimedia.org/T442975) [00:54:08] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360787 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [01:20:16] (03PS4) 10Eileen: FinanceIntegration.pushJournal: self-record its own Batch remote fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361548 [01:23:33] (03PS7) 10Cstone: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [01:36:00] (03PS5) 10Eileen: FinanceIntegration.pushJournal: move batch update to pushJournal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361548 [01:39:19] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1361604 [01:42:36] (03CR) 10Cstone: "thanks for the review @lbarluzzi@wikimedia.org yeah we needed to add in the pass through from the url params, I added that in" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [01:44:41] (03CR) 10Dmiranda: [C:03+2] Add name check for wallet both gravy adyen and braintree for wallet payment from gpay apple venmo paypal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358243 (https://phabricator.wikimedia.org/T441162) (owner: 10Wfan) [01:46:15] (03Merged) 10jenkins-bot: Add name check for wallet both gravy adyen and braintree for wallet payment from gpay apple venmo paypal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358243 (https://phabricator.wikimedia.org/T441162) (owner: 10Wfan) [02:08:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: strtolower null check - https://phabricator.wikimedia.org/T443390 (10AnnWF) 03NEW [02:11:25] (03PS1) 10Wfan: Fix strtolower null issue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1361606 (https://phabricator.wikimedia.org/T443390) [02:12:42] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: strtolower null check - https://phabricator.wikimedia.org/T443390#12506934 (10AnnWF) https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1361606 [02:33:46] (03PS1) 10Eileen: Stop logging the account code logic into the batch summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361608 [02:33:46] (03PS1) 10Eileen: Remove dead code from GenerateBatch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361609 [02:33:46] (03PS1) 10Eileen: Extract code that calculates journals to separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361610 [02:45:25] 06Fundraising-Backlog, 10FR-WMF-Audit: Adyen Gravy/ Gr4vy donation triple captured - https://phabricator.wikimedia.org/T443391 (10Eileenmcnaughton) 03NEW [03:23:51] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1361604 (owner: 10Eileen) [03:26:52] !log config revision changed from 8c06da7a to 8c3f56d7 [03:26:53] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:27:31] !log * civicrm upgraded from a65615a7 to 6212f766 [03:27:31] * config revision changed from 8c06da7a to 8c3f56d7 [03:27:33] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:31:50] (03PS1) 10Eileen: Leave Dept ID empty for endowment batches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361614 [03:34:41] (03PS1) 10Ramon Lopez: ComboWiki UI: Added appeal components and styles [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361615 [03:35:03] (03CR) 10Ejegg: "The queueName / action / queueMethod feels confusing to me. Also I'm not sure why it would help to write donations via multiple queues - w" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311308 (https://phabricator.wikimedia.org/T419044) (owner: 10Eileen) [03:36:59] (03CR) 10Eileen: Chariot: add limited queueing support (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311308 (https://phabricator.wikimedia.org/T419044) (owner: 10Eileen) [03:44:39] !log config revision changed from 8c3f56d7 to 82cd7215 [03:44:41] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:45:09] (03PS4) 10Pwangai: Add a CI script to run the test suite in parallel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) [03:50:02] (03CR) 10Pwangai: "Smashpig is not written to by the tests. SmashPig's test config uses in-memory SQLite, and the contribution_recur_smashpig fields live in " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) (owner: 10Pwangai) [03:57:31] 06Fundraising-Backlog, 10FR-WMF-Audit: Adyen Gravy/ Gr4vy donation triple captured - https://phabricator.wikimedia.org/T443391#12506998 (10Eileenmcnaughton) From the files we see "Auto Generated duplicate capture from EPA - SXLZ6BHNFG653H69" - WTF? Some alignment issues in the table but.... | file... [04:00:49] (03CR) 10Pwangai: Add a CI script to run the test suite in parallel (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) (owner: 10Pwangai) [04:34:00] (03PS8) 10Cstone: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [04:35:25] (03CR) 10CI reject: [V:04-1] Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [04:37:15] (03PS9) 10Cstone: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [04:38:24] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_43) - 10https://gerrit.wikimedia.org/r/1361648 (owner: 10L10n-bot) [04:38:48] (03CR) 10CI reject: [V:04-1] Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [04:39:47] (03PS10) 10Cstone: Send contrbution tracking message on form submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) [04:45:34] (03PS4) 10Pwangai: Add a CI script to run the test suite in parallel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) [04:52:59] 06Fundraising-Backlog, 10FR-WMF-Audit: Adyen Gravy/ Gr4vy donation triple captured - https://phabricator.wikimedia.org/T443391#12507048 (10Cstone) Checking the consoles, gravy shows just one transaction. Adyen also just shows one transaction with the two extra settles you saw. Adyen console data: |Settled |... [04:55:26] (03CR) 10Cstone: "thanks for the review @lbarluzzi@wikimedia.org" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [04:55:58] (03PS1) 10Lars SG: Log status changes on the contribution receive_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361719 (https://phabricator.wikimedia.org/T443265) [05:03:39] (03PS6) 10Eileen: FinanceIntegration.pushJournal: move batch update to pushJournal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361548 [05:03:39] (03PS2) 10Eileen: Stop logging the account code logic into the batch summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361608 [05:03:39] (03PS2) 10Eileen: Remove dead code from GenerateBatch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361609 [05:03:40] (03PS2) 10Eileen: Extract code that calculates journals to separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361610 [05:03:41] (03PS2) 10Eileen: Leave Dept ID empty for endowment batches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361614 [05:03:42] (03PS1) 10Eileen: Add Batch.pushToFinance; move the Intacct push out of GenerateBatch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361720 [05:03:45] (03PS1) 10Eileen: Pass checkPermissions through to the finance push [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361721 [05:14:26] (03PS3) 10Lars SG: Add an as-of date to CalculatedData [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361201 (https://phabricator.wikimedia.org/T431586) [05:14:26] (03PS3) 10Lars SG: Use the recurring log for CalculatedData as-of recurring statuses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361207 (https://phabricator.wikimedia.org/T431586) [05:14:26] (03PS4) 10Lars SG: Add WMFDonor::rebuildHistory to replay wmf_donor_history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361490 (https://phabricator.wikimedia.org/T431586) [05:14:27] (03PS2) 10Lars SG: Save rebuilt history in WMFDonor::rebuildHistory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361527 (https://phabricator.wikimedia.org/T431586) [05:14:28] (03PS3) 10Lars SG: Rebuild a contact's donor history after a merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361539 (https://phabricator.wikimedia.org/T431586) [05:14:29] (03PS2) 10Lars SG: Add optional start date to rebuild donor history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361584 (https://phabricator.wikimedia.org/T431586) [05:14:33] (03PS2) 10Lars SG: Log status changes on the contribution receive_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361719 (https://phabricator.wikimedia.org/T443265) [05:18:21] (03CR) 10Eileen: [C:03+2] "that covers it - I was expecting you to use a DAO parameterised query but this also works" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361201 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [05:23:53] (03PS1) 10Eileen: Keep adjustment batches out of the settlement sweep [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361727 [05:26:36] (03Merged) 10jenkins-bot: Add an as-of date to CalculatedData [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361201 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [05:34:01] (03CR) 10Cstone: [C:03+2] FinanceIntegration.pushJournal: move batch update to pushJournal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361548 (owner: 10Eileen) [05:34:12] (03CR) 10Cstone: [C:03+2] Stop logging the account code logic into the batch summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361608 (owner: 10Eileen) [05:34:25] (03CR) 10Cstone: [C:03+2] Remove dead code from GenerateBatch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361609 (owner: 10Eileen) [05:36:51] (03CR) 10Cstone: [C:03+2] Extract code that calculates journals to separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361610 (owner: 10Eileen) [05:37:21] (03CR) 10Cstone: [C:03+2] Leave Dept ID empty for endowment batches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361614 (owner: 10Eileen) [05:42:13] (03Merged) 10jenkins-bot: FinanceIntegration.pushJournal: move batch update to pushJournal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361548 (owner: 10Eileen) [05:42:15] (03Merged) 10jenkins-bot: Stop logging the account code logic into the batch summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361608 (owner: 10Eileen) [05:42:36] (03Merged) 10jenkins-bot: Remove dead code from GenerateBatch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361609 (owner: 10Eileen) [05:44:50] (03Merged) 10jenkins-bot: Extract code that calculates journals to separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361610 (owner: 10Eileen) [05:50:12] (03Merged) 10jenkins-bot: Leave Dept ID empty for endowment batches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361614 (owner: 10Eileen) [05:53:50] (03PS2) 10Eileen: Add Batch.pushToFinance; move the Intacct push out of GenerateBatch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361720 [05:53:50] (03PS2) 10Eileen: Pass checkPermissions through to the finance push [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361721 [05:53:50] (03PS2) 10Eileen: Keep adjustment batches out of the settlement sweep [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361727 [05:55:33] (03CR) 10Cstone: [C:03+2] "Copied votes on follow-up patch sets have been updated:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361720 (owner: 10Eileen) [05:55:53] (03CR) 10CI reject: [V:04-1] Add Batch.pushToFinance; move the Intacct push out of GenerateBatch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361720 (owner: 10Eileen) [05:58:40] (03CR) 10Cstone: [C:03+2] Pass checkPermissions through to the finance push [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361721 (owner: 10Eileen) [06:12:16] (03CR) 10Cstone: [C:03+2] Keep adjustment batches out of the settlement sweep [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361727 (owner: 10Eileen) [06:15:47] 06Fundraising-Backlog, 10FR-WMF-Audit: Adyen Gravy/ Gr4vy donation triple captured - https://phabricator.wikimedia.org/T443391#12507102 (10Eileenmcnaughton) Hot take from ChatGPT - so we can't rule out this being a gravy bug {F111854893} [06:20:28] (03Merged) 10jenkins-bot: Pass checkPermissions through to the finance push [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361721 (owner: 10Eileen) [06:20:30] (03Merged) 10jenkins-bot: Keep adjustment batches out of the settlement sweep [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361727 (owner: 10Eileen) [06:36:46] (03PS4) 10Lars SG: Use the recurring log for CalculatedData as-of recurring statuses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361207 (https://phabricator.wikimedia.org/T431586) [06:47:31] (03PS1) 10Eileen: Add WMFAudit.ReserveAdjustmentBatches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361731 [06:47:31] (03PS1) 10Eileen: Lock each adjustment while it is being reserved [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361732 [07:07:08] (03PS1) 10Eileen: Rename JournalGLConstants to FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361733 [07:07:08] (03PS1) 10Eileen: Share the finance batch lock name and the competing-lock test helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361734 [07:07:08] (03PS1) 10Eileen: Lock each adjustment while it is being reserved [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361735 [07:23:23] (03PS1) 10Eileen: Rename JournalGLConstants to FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361736 [07:23:23] (03PS1) 10Eileen: Share the finance batch lock name and the competing-lock test helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361737 [07:23:23] (03PS1) 10Eileen: Add WMFAudit.ReserveAdjustmentBatches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361738 [09:21:24] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for catching this. LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358262 (https://phabricator.wikimedia.org/T441336) (owner: 10Ejegg) [09:22:51] (03Merged) 10jenkins-bot: Point thumbnails to thumb.wm.o [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358262 (https://phabricator.wikimedia.org/T441336) (owner: 10Ejegg) [09:45:35] (03CR) 10Laurabarluzzi: [C:03+2] "@cstone@wikimedia.org LGTM! Thanks for addressing the change and @ejegg@ejegg.com for the context. Now I know that it can be set in the UR" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [09:47:05] (03Merged) 10jenkins-bot: Calculate utm_key and set up default utm_campaign and medium [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358301 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [09:52:26] (03CR) 10Damilare Adedoyin: [C:03+1] "Thanks for the updates @lbarluzzi@wikimedia.org, lgtm. Just one more change and we are to go. I also responded to the submission of PII on" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358214 (https://phabricator.wikimedia.org/T437335) (owner: 10Laurabarluzzi) [09:59:39] (03CR) 10Damilare Adedoyin: [C:03+1] "Thanks @wfan@wikimedia.org for adding this, lgtm but we should add some test coverage for this change. Thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1361606 (https://phabricator.wikimedia.org/T443390) (owner: 10Wfan) [10:02:30] (03CR) 10Laurabarluzzi: [C:03+1] "@cstone@wikimedia.org Thanks for the changes, I +1 because I'd like someone else also to look into this since it's an important introduced" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1359724 (https://phabricator.wikimedia.org/T439981) (owner: 10Cstone) [10:14:40] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: polish and standardize payload for Donate API request - https://phabricator.wikimedia.org/T443412 (10Laurabarluzzi) 03NEW [10:14:57] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: polish and standardize payload for Donate API request - https://phabricator.wikimedia.org/T443412#12507642 (10Laurabarluzzi) p:05Triageβ†’03Medium [10:29:44] (03PS11) 10Laurabarluzzi: ComboWiki: one-click buttons for methods without form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358214 (https://phabricator.wikimedia.org/T437335) [10:36:41] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: polish and standardize payload for Donate API request - https://phabricator.wikimedia.org/T443412#12507766 (10Laurabarluzzi) [10:39:14] (03CR) 10Laurabarluzzi: "@dadedoyin@wikimedia.org Thanks for the quick re-review! I made the fix you spotted and also created a follow-up phab regarding the move o" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358214 (https://phabricator.wikimedia.org/T437335) (owner: 10Laurabarluzzi) [10:41:31] (03CR) 10Laurabarluzzi: "@ejegg@ejegg.com I believe we discussed in IRC that this patch should actually be dropped? I think we considered keeping the current appro" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360541 (owner: 10Ejegg) [10:45:23] (03PS7) 10Damilare Adedoyin: Add Adyen ApplePay component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360570 (https://phabricator.wikimedia.org/T441849) [10:45:35] (03CR) 10CI reject: [V:04-1] Add Adyen ApplePay component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360570 (https://phabricator.wikimedia.org/T441849) (owner: 10Damilare Adedoyin) [10:46:31] (03PS8) 10Damilare Adedoyin: Add Adyen ApplePay component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360570 (https://phabricator.wikimedia.org/T441849) [10:46:43] (03CR) 10CI reject: [V:04-1] Add Adyen ApplePay component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360570 (https://phabricator.wikimedia.org/T441849) (owner: 10Damilare Adedoyin) [10:49:52] damilare: are you fixing the CI reject on your apple pay patch? I'm reviewing it and I was about approving it but there is an ongoing merge conflict [10:50:16] yes I am, thanks! [10:50:36] What caused the merge conflicts? [10:51:16] (03PS9) 10Damilare Adedoyin: Add Adyen ApplePay component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360570 (https://phabricator.wikimedia.org/T441849) [10:51:43] laurabar: there was a change that was merged to adyen.js [10:51:47] probably last night [10:52:12] I see its the wallet fallback modal that Wfan demoed yesterday [10:52:36] πŸ‘Œ [10:54:31] So i see these change in the last diff; what is the purple section? πŸ€” green is "addition on this line" but the purple I haven't mapped it I think..https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1360570/8..9/adyen_gateway/forms/adyen.js [10:55:58] that's the change from Wenjun's patch, I'm trying to locate it [10:56:31] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1358243 [10:56:37] So it's the color of 'merged' code; I just don't understand why it caused the merge conflicts though [10:57:20] yea I think so, purple must mean it wasn't one of my changes. [10:57:29] The merge conflict was on the imports [10:57:56] Ah ok yeah [10:58:01] since I added something to the applePayHelper as well [10:58:42] yeah mapAppleNetworkToSubmethod ok [10:59:06] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360570 (https://phabricator.wikimedia.org/T441849) (owner: 10Damilare Adedoyin) [10:59:22] thanks laurabar! [11:00:11] I'm going to try to rebase master on my one-click branch to see if the apple pay works by default on it πŸ™ [11:00:43] Well I cannot do a full test locally but at least the one-click opening the QR code window etc. [11:00:49] (03Merged) 10jenkins-bot: Add Adyen ApplePay component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360570 (https://phabricator.wikimedia.org/T441849) (owner: 10Damilare Adedoyin) [11:01:03] yh I'd do the same [11:04:49] It seems to be working without merge conflicts; good sign for the approach I think [11:05:20] I managed to have the one-click patch adapt to 3 new one-click component implementations (at least on a first glace) and without merge conflicts [11:06:05] I pushed the merged master [11:06:23] (03PS12) 10Laurabarluzzi: ComboWiki: one-click buttons for methods without form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358214 (https://phabricator.wikimedia.org/T437335) [11:07:14] the merge conflicts I had to deal with were from changes in the previous chained patches and from the reconfigurations Jack added last week [11:10:30] Looks good... I'm just testing it out now. [11:20:01] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for all the work on this @lbarluzzi@wikimedia.org. Tested all the payment methods and LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358214 (https://phabricator.wikimedia.org/T437335) (owner: 10Laurabarluzzi) [11:20:44] (03Abandoned) 10Damilare Adedoyin: Suggestion: Use single row to render all payment methods to improve payment method display rendering performance and styling. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361522 (https://phabricator.wikimedia.org/T437335) (owner: 10Damilare Adedoyin) [11:21:38] (03Merged) 10jenkins-bot: ComboWiki: one-click buttons for methods without form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358214 (https://phabricator.wikimedia.org/T437335) (owner: 10Laurabarluzzi) [11:25:54] πŸ€Έβ€β™€οΈ 🎠 [11:50:52] (03PS7) 10Damilare Adedoyin: Share functions between Adyen Card and ApplePay Components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360573 [11:57:44] (03PS1) 10Damilare Adedoyin: Fix apple pay error "Cannot use 'in' operator to search for 'first_name' in undefined" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361852 (https://phabricator.wikimedia.org/T439191) [12:13:50] (03PS1) 10Damilare Adedoyin: Match Adyen Apple Pay Style with other methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361857 (https://phabricator.wikimedia.org/T441849) [12:18:01] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: Adyen 3DS - https://phabricator.wikimedia.org/T442703#12508260 (10Damilare) a:03Damilare [12:50:41] (03CR) 10Ejegg: "Feels like it would be much clearer for the AuditProcessor class to decide to call a 'Queue' or a 'Save' action and have the actions do wh" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311308 (https://phabricator.wikimedia.org/T419044) (owner: 10Eileen) [13:40:04] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_43) - 10https://gerrit.wikimedia.org/r/1361904 (owner: 10L10n-bot) [14:48:32] thanks laurabar for the reviews. I got the suggestion for the stylelintrc config on stackoverflow: https://stackoverflow.com/questions/66647592/stylelint-what-is-syntax-in-css-to-ignore-rule-with-no-option-but-keep-using-rul [15:01:31] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: SPIKE: what CentralNotice concept maps to a 'treatment' in TestKitchen - https://phabricator.wikimedia.org/T443454 (10Ejegg) 03NEW [15:02:25] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: SPIKE: what CentralNotice concept maps to a 'treatment' in TestKitchen - https://phabricator.wikimedia.org/T443454#12509171 (10Ejegg) [15:13:52] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: Write a TestKitchen mixin for CentralNotice - https://phabricator.wikimedia.org/T440992#12509250 (10Ejegg) [15:29:31] (03PS16) 10Damilare Adedoyin: DonateWiki: Add tests for components and views [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1354465 (https://phabricator.wikimedia.org/T432386) [15:47:48] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: SPIKE: what CentralNotice concept maps to a 'treatment' in TestKitchen - https://phabricator.wikimedia.org/T443454#12509587 (10phuedx) [16:01:50] (03PS5) 10Lars SG: Add WMFDonor::rebuildHistory to replay wmf_donor_history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361490 (https://phabricator.wikimedia.org/T431586) [16:01:58] (03PS3) 10Lars SG: Save rebuilt history in WMFDonor::rebuildHistory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361527 (https://phabricator.wikimedia.org/T431586) [16:02:05] (03PS4) 10Lars SG: Rebuild a contact's donor history after a merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361539 (https://phabricator.wikimedia.org/T431586) [16:02:12] (03PS3) 10Lars SG: Add optional start date to rebuild donor history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361584 (https://phabricator.wikimedia.org/T431586) [16:02:18] (03PS3) 10Lars SG: Log status changes on the contribution receive_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361719 (https://phabricator.wikimedia.org/T443265) [16:07:42] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Save ad click tracking ids to contribution tracking - https://phabricator.wikimedia.org/T443300#12509700 (10Lars) [16:14:36] (03PS4) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [16:15:45] oh maybe that should be in afterEach [16:15:50] (03CR) 10CI reject: [V:04-1] Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [16:25:06] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Save ad click tracking ids to contribution tracking - https://phabricator.wikimedia.org/T443300#12511077 (10Lars) [16:26:50] (03PS5) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [16:28:14] (03CR) 10CI reject: [V:04-1] Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [16:34:54] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Save ad click tracking ids to contribution tracking - https://phabricator.wikimedia.org/T443300#12511152 (10Ejegg) @pcoombe has already done the work to pass gclid through donatewiki to payme... [16:44:33] (03PS1) 10Lars SG: Add handling for ad clicks from contribution tracking message to table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362109 (https://phabricator.wikimedia.org/T443300) [16:44:54] (03CR) 10CI reject: [V:04-1] Add handling for ad clicks from contribution tracking message to table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362109 (https://phabricator.wikimedia.org/T443300) (owner: 10Lars SG) [16:45:48] (03PS2) 10Lars SG: Add handling for ad clicks from contribution tracking message to table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362109 (https://phabricator.wikimedia.org/T443300) [16:47:39] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Save ad click tracking ids to contribution tracking - https://phabricator.wikimedia.org/T443300#12511274 (10Lars) @Ejegg: @Pcoombe has now added the other two params in... [16:48:35] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Save ad click tracking ids to contribution tracking - https://phabricator.wikimedia.org/T443300#12511279 (10Lars) And yes, send them to contribution tracking, not the do... [16:49:36] (03PS6) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [16:50:54] (03CR) 10CI reject: [V:04-1] Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [16:54:12] (03PS7) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [16:55:27] (03CR) 10CI reject: [V:04-1] Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [16:58:43] (03PS8) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [17:00:36] (03CR) 10CI reject: [V:04-1] Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [17:09:01] (03PS9) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [17:11:57] (03PS3) 10Lars SG: Add handling for ad clicks from contribution tracking message to table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362109 (https://phabricator.wikimedia.org/T443300) [17:17:40] (03CR) 10Ejegg: "No need to ?? null then ?? ''" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1361606 (https://phabricator.wikimedia.org/T443390) (owner: 10Wfan) [17:23:27] (03PS1) 10Lars SG: Fix broken audit setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362128 (https://phabricator.wikimedia.org/T434041) [17:24:56] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: SPIKE: what CentralNotice concept maps to a 'treatment' in TestKitchen - https://phabricator.wikimedia.org/T443454#12511638 (10JVanderhoop-WMF) p:05Triageβ†’03High a:03JVanderhoop-WMF [17:30:51] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: Write a TestKitchen mixin for CentralNotice - https://phabricator.wikimedia.org/T440992#12511685 (10JVanderhoop-WMF) p:05Triageβ†’03High [17:39:11] (03PS2) 10Wfan: Fix strtolower null issue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1361606 (https://phabricator.wikimedia.org/T443390) [17:39:22] (03CR) 10Cstone: [C:03+2] Fix broken audit setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362128 (https://phabricator.wikimedia.org/T434041) (owner: 10Lars SG) [17:39:54] (03CR) 10Wfan: [V:03+2] Fix broken audit setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362128 (https://phabricator.wikimedia.org/T434041) (owner: 10Lars SG) [17:41:46] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations, and 2 others: We retry failed recurring SEPA/iDeal donations forever if the reason is retryable - https://phabricator.wikimedia.org/T420775#12511824 (10Lars) Working as... [17:43:20] 10fundraising-tech-ops: add +B bot mode to slander - https://phabricator.wikimedia.org/T443491 (10Dwisehaupt) 03NEW [17:43:45] (03PS1) 10Dwisehaupt: Add +B (bot) mode after signon [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1362136 (https://phabricator.wikimedia.org/T443491) [17:43:56] (03CR) 10Dmiranda: [C:03+2] Fix broken audit setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362128 (https://phabricator.wikimedia.org/T434041) (owner: 10Lars SG) [17:44:32] 10fundraising-tech-ops, 13Patch-For-Review: add +B bot mode to slander - https://phabricator.wikimedia.org/T443491#12511864 (10Dwisehaupt) a:03Dwisehaupt Tested live and it works. Going through the process of codifying it in gerrit and rebuilding the packages. [17:44:35] (03PS1) 10Umherirrender: Remove unused properties from CampaignLog [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1362137 [17:47:29] (03CR) 10Jgreen: [C:03+1] Add +B (bot) mode after signon [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1362136 (https://phabricator.wikimedia.org/T443491) (owner: 10Dwisehaupt) [17:48:16] (03Merged) 10jenkins-bot: Fix broken audit setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362128 (https://phabricator.wikimedia.org/T434041) (owner: 10Lars SG) [18:14:03] (03CR) 10Wfan: "Done" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1361606 (https://phabricator.wikimedia.org/T443390) (owner: 10Wfan) [18:14:34] 03Fundraising Sprint U, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Support 'mailcheck' in combowiki - https://phabricator.wikimedia.org/T439258#12512121 (10SBurnett-WMF) [18:15:31] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: polish and standardize payload for Donate API request - https://phabricator.wikimedia.org/T443412#12512123 (10SBurnett-WMF) [18:15:33] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: Standardize how we send ComboWiki Client debug and error logs to the server - https://phabricator.wikimedia.org/T438241#12512124 (10SBurnett-WMF) [18:15:34] 03Fundraising Sprint U, 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Update the list of ::fieldNames in data fetched from request and session - https://phabricator.wikimedia.org/T434803#12512125 (10SBurnett-WMF) [18:15:36] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: Reduce to the minimum all gateway dependencies in Donate.php - https://phabricator.wikimedia.org/T434827#12512127 (10SBurnett-WMF) [18:15:39] 03Fundraising Sprint U, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Show name & email fields after auth when missing for wallet donations - https://phabricator.wikimedia.org/T441162#12512126 (10SBurnett-WMF) [18:15:40] 03Fundraising Sprint U, 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: error handling check - https://phabricator.wikimedia.org/T437542#12512128 (10SBurnett-WMF) [18:15:42] 03Fundraising Sprint U, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Read combowiki variant mapping dynamically from settings - https://phabricator.wikimedia.org/T439288#12512129 (10SBurnett-WMF) [18:15:46] 03Fundraising Sprint U, 07fr-combowiki: Clarify state management when it comes to contribution_tracking_id and order_id - https://phabricator.wikimedia.org/T435541#12512130 (10SBurnett-WMF) [18:15:50] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: Clarify the types of values of fieldNames passed from DataIntegration() down the chain - https://phabricator.wikimedia.org/T434813#12512131 (10SBurnett-WMF) [18:15:54] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: Define fieldNames allowed in session - https://phabricator.wikimedia.org/T434804#12512132 (10SBurnett-WMF) [18:15:58] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: Optional: consider to have a stricter enforcement of value types in DonationDetails() - https://phabricator.wikimedia.org/T434815#12512136 (10SBurnett-WMF) [18:16:02] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: Clarify usage of DonationDetails dataSources and improve - https://phabricator.wikimedia.org/T434835#12512137 (10SBurnett-WMF) [18:16:06] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: Traffic analysis for donate wiki - https://phabricator.wikimedia.org/T436168#12512138 (10SBurnett-WMF) [18:16:42] 03Fundraising Sprint U, 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Update contribution tracking on submit - https://phabricator.wikimedia.org/T442888#12512151 (10SBurnett-WMF) [18:16:44] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: Adyen 3DS - https://phabricator.wikimedia.org/T442703#12512150 (10SBurnett-WMF) [18:16:47] 03Fundraising Sprint U, 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen SEPA Component - https://phabricator.wikimedia.org/T441853#12512152 (10SBurnett-WMF) [18:16:51] 03Fundraising Sprint U, 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki: Add Braintree Venmo Vue Component - https://phabricator.wikimedia.org/T441808#12512153 (10SBurnett-WMF) [18:28:15] 03Fundraising Sprint U, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 2 others: Show name & email fields after auth when missing for wallet donations - https://phabricator.wikimedia.org/T441162#12512237 (10Cstone) [18:29:54] 06Fundraising-Backlog, 07fr-combowiki: Traffic analysis for donate wiki - https://phabricator.wikimedia.org/T436168#12512280 (10Cstone) [18:30:41] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Read combowiki variant mapping dynamically from settings - https://phabricator.wikimedia.org/T439288#12512289 (10Cstone) [18:31:44] 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: polish and standardize payload for Donate API request - https://phabricator.wikimedia.org/T443412#12512299 (10Cstone) [18:32:03] 06Fundraising-Backlog, 07fr-combowiki: Reduce to the minimum all gateway dependencies in Donate.php - https://phabricator.wikimedia.org/T434827#12512301 (10Cstone) [18:32:15] 06Fundraising-Backlog, 07fr-combowiki: Optional: consider to have a stricter enforcement of value types in DonationDetails() - https://phabricator.wikimedia.org/T434815#12512304 (10Cstone) [18:32:22] 06Fundraising-Backlog, 07fr-combowiki: Clarify the types of values of fieldNames passed from DataIntegration() down the chain - https://phabricator.wikimedia.org/T434813#12512305 (10Cstone) [18:32:28] 06Fundraising-Backlog, 07fr-combowiki: Clarify usage of DonationDetails dataSources and improve - https://phabricator.wikimedia.org/T434835#12512306 (10Cstone) [18:32:44] 06Fundraising-Backlog, 07fr-combowiki: Define fieldNames allowed in session - https://phabricator.wikimedia.org/T434804#12512307 (10Cstone) [18:33:13] 03Fundraising Sprint U, 06Fundraising-Backlog, 07fr-combowiki: Combowiki return from redirect on monthly donation shows monthly convert - https://phabricator.wikimedia.org/T440765#12512308 (10Cstone) [18:43:03] (03PS10) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [18:55:04] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-CentralNotice-Administration, 13Patch-For-Review: Provide a way to display of a banner only to users who reach a certai... - https://phabricator.wikimedia.org/T269758#12512416 [19:02:49] (03PS1) 10Ejegg: Add conversion paramters to contribution tracking [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362158 (https://phabricator.wikimedia.org/T443300) [19:33:23] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-CentralNotice-Administration, 13Patch-For-Review: Provide a way to display of a banner only to users who reach a certai... - https://phabricator.wikimedia.org/T269758#12512618 [19:36:28] (03CR) 10Dwisehaupt: [C:03+2] Add +B (bot) mode after signon [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1362136 (https://phabricator.wikimedia.org/T443491) (owner: 10Dwisehaupt) [19:42:58] 06Fundraising-Backlog, 07fr-combowiki: Reduce to the minimum all gateway dependencies in Donate.php - https://phabricator.wikimedia.org/T434827#12512625 (10Laurabarluzzi) This is basically what "phase B" in Jack's doc requires; removing the dependencies of gateway adapters' code. [19:46:13] 06Fundraising-Backlog, 07fr-combowiki: Optional: consider to have a stricter enforcement of value types in DonationDetails() - https://phabricator.wikimedia.org/T434815#12512629 (10Laurabarluzzi) I think this can be closed since I don't think this is a high priority and we can consider this only if we encounte... [19:47:17] [19:49:46] 06Fundraising-Backlog, 07fr-combowiki: Optional: consider to have a stricter enforcement of value types in DonationDetails() - https://phabricator.wikimedia.org/T434815#12512657 (10Laurabarluzzi) 05Openβ†’03Declined [19:50:32] 06Fundraising-Backlog, 07fr-combowiki: Clarify the types of values of fieldNames passed from DataIntegration() down the chain - https://phabricator.wikimedia.org/T434813#12512670 (10Laurabarluzzi) 05Openβ†’03Declined [20:04:37] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1362172 [20:05:11] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1362172 (owner: 10Eileen) [20:06:05] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1362172 (owner: 10Eileen) [20:13:37] (03PS1) 10Wfan: add venmo to combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362174 (https://phabricator.wikimedia.org/T441808) [20:15:49] (03CR) 10CI reject: [V:04-1] add venmo to combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362174 (https://phabricator.wikimedia.org/T441808) (owner: 10Wfan) [20:17:59] !log civicrm upgraded from 6212f766 to 6fc4ee60 [20:18:01] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [20:18:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: check on Civi ingesting PayPal Resolution Center reversals - https://phabricator.wikimedia.org/T439645#12512799 (10SBurnett-WMF) p:05Mediumβ†’03High [20:18:07] 06Fundraising-Backlog, 07fr-combowiki: show name and email field after auth when missing for wallet donations - combowiki - https://phabricator.wikimedia.org/T443513 (10AnnWF) 03NEW [20:20:20] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514 (10spatton) 03NEW [20:28:27] 03Fundraising Sprint U, 06Fundraising-Backlog: Adyen Plaid Investigation - https://phabricator.wikimedia.org/T443515 (10Cstone) 03NEW [20:30:05] 03Fundraising Sprint U: Sprint U - https://phabricator.wikimedia.org/T443355#12512884 (10SBurnett-WMF) [20:32:54] 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-matching-gifts, 10MediaWiki-extensions-DonationInterface: Explore DoubleTheDonation integration - https://phabricator.wikimedia.org/T433406#12512907 (10Cstone) [20:34:11] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen (Experiment Platform Sprint 32): SPIKE: what CentralNotice concept maps to a 'treatment' in TestKitchen - https://phabricator.wikimedia.org/T443454#12512912 (10JVanderhoop-WMF) 05Openβ†’03In progress ===Context CentralNotice manag... [20:34:16] (03PS2) 10Wfan: add venmo to combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362174 (https://phabricator.wikimedia.org/T441808) [20:42:17] 06Fundraising-Backlog, 07fr-combowiki: Prevent donation when amount not selected - https://phabricator.wikimedia.org/T443094#12512969 (10AnnWF) 05Openβ†’03Resolved [20:58:28] (03CR) 10Ejegg: "OK Jon, I've added some tests (and a missing 'new' keyword in hide.js)" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [21:04:09] (03CR) 10Ejegg: [C:04-1] "Please do not change the required mediawiki version for this extension" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361169 (https://phabricator.wikimedia.org/T443153) (owner: 10Gerrit maintenance bot) [21:06:51] (03PS2) 10Ejegg: Remove "web2017-polyfills" RL module [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361169 (https://phabricator.wikimedia.org/T443153) (owner: 10Gerrit maintenance bot) [21:07:49] (03CR) 10Ejegg: [C:03+2] Remove "web2017-polyfills" RL module [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361169 (https://phabricator.wikimedia.org/T443153) (owner: 10Gerrit maintenance bot) [21:13:39] (03Merged) 10jenkins-bot: Remove "web2017-polyfills" RL module [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361169 (https://phabricator.wikimedia.org/T443153) (owner: 10Gerrit maintenance bot) [21:29:52] (03PS1) 10Laurabarluzzi: ComboWiki: Add Adyen SEPA component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362200 (https://phabricator.wikimedia.org/T441853) [21:39:38] 03Fundraising Sprint U, 03Fundraising Sprint: That Rug Really Tied The Room Together, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Adyen SEPA Component - https://phabricator.wikimedia.org/T441853#12513185 (10Laurabarluzzi) I wasn't able to see the transactions locally in civi aft... [21:43:48] (03CR) 10Eileen: [C:03+1] "lars - this seems fine. OK to +2 but that needs to be done in conjunction with plans on how to add the db columns since I expect that need" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362109 (https://phabricator.wikimedia.org/T443300) (owner: 10Lars SG) [21:44:22] (03CR) 10Eileen: [C:03+1] "although I see you found it quick on staging ... which might hold for prod...." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362109 (https://phabricator.wikimedia.org/T443300) (owner: 10Lars SG) [21:47:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Inability to cancel Venmo/Braintree recurring donations in Civi - https://phabricator.wikimedia.org/T429031#12513218 (10Laurabarluzzi) @Damilare can you confirm if this should be moved to done? Could you link to a patch, if any, or... [21:58:29] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen: CentralNotice should allow overriding campaign selection via querystring - https://phabricator.wikimedia.org/T443458#12513249 (10Pcoombe) This could be useful for the online fundraising team's QA more g... [21:59:25] (03PS5) 10Lars SG: Rebuild a contact's donor history after a merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361539 (https://phabricator.wikimedia.org/T431586) [21:59:26] (03PS4) 10Lars SG: Add optional start date to rebuild donor history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361584 (https://phabricator.wikimedia.org/T431586) [21:59:26] (03PS4) 10Lars SG: Log status changes on the contribution receive_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361719 (https://phabricator.wikimedia.org/T443265) [21:59:26] (03PS1) 10Lars SG: Don't log initial default rows ofr donor history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362206 (https://phabricator.wikimedia.org/T431586) [22:01:08] (03CR) 10CI reject: [V:04-1] Rebuild a contact's donor history after a merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361539 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [22:01:32] (03CR) 10CI reject: [V:04-1] Add optional start date to rebuild donor history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361584 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [22:01:53] (03CR) 10CI reject: [V:04-1] Log status changes on the contribution receive_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361719 (https://phabricator.wikimedia.org/T443265) (owner: 10Lars SG) [22:02:06] (03CR) 10Dmiranda: [C:03+2] Mixin to target campaigns by user edit count [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1352670 (https://phabricator.wikimedia.org/T269758) (owner: 10Ejegg) [22:02:20] (03CR) 10CI reject: [V:04-1] Don't log initial default rows ofr donor history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362206 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [22:04:17] (03Merged) 10jenkins-bot: Mixin to target campaigns by user edit count [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1352670 (https://phabricator.wikimedia.org/T269758) (owner: 10Ejegg) [22:15:38] (03PS1) 10Eileen: Latest CiviCRM-6.20 15e1d1ec8a [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362213 [22:34:26] (03CR) 10Eileen: "I've been trying to work through this - Claude has identified a situation with 2 same-second rows where it makes the valid point that it s" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361207 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [22:44:44] (03PS6) 10Lars SG: Rebuild a contact's donor history after a merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361539 (https://phabricator.wikimedia.org/T431586) [22:44:54] (03PS5) 10Lars SG: Add optional start date to rebuild donor history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361584 (https://phabricator.wikimedia.org/T431586) [22:45:01] (03PS5) 10Lars SG: Log status changes on the contribution receive_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361719 (https://phabricator.wikimedia.org/T443265) [22:45:09] (03PS2) 10Lars SG: Don't log initial default rows ofr donor history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362206 (https://phabricator.wikimedia.org/T431586) [22:45:31] (03PS3) 10Lars SG: Don't log initial default rows for donor history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362206 (https://phabricator.wikimedia.org/T431586) [22:57:26] (03PS1) 10Ejegg: WIP hide cookie stores multiple reasons [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1362223 (https://phabricator.wikimedia.org/T441351) [22:58:03] (03PS2) 10Ejegg: WIP hide cookie stores multiple reasons [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1362223 (https://phabricator.wikimedia.org/T441351) [22:59:46] (03CR) 10CI reject: [V:04-1] WIP hide cookie stores multiple reasons [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1362223 (https://phabricator.wikimedia.org/T441351) (owner: 10Ejegg) [23:04:40] (03CR) 10Dmiranda: [C:03+2] "Thanks Laura!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362200 (https://phabricator.wikimedia.org/T441853) (owner: 10Laurabarluzzi) [23:05:49] (03PS3) 10Wfan: add venmo to combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362174 (https://phabricator.wikimedia.org/T441808) [23:07:46] (03Merged) 10jenkins-bot: ComboWiki: Add Adyen SEPA component [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362200 (https://phabricator.wikimedia.org/T441853) (owner: 10Laurabarluzzi) [23:26:35] (03PS11) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [23:27:51] (03CR) 10CI reject: [V:04-1] Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) (owner: 10Ejegg) [23:32:30] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Error Handling - Handle multiple payment attempts - https://phabricator.wikimedia.org/T443538 (10Cstone) 03NEW [23:35:20] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Error Handling - Handle multiple payment attempts - https://phabricator.wikimedia.org/T443538#12513702 (10Ejegg) Return order_id from any failed API call so that we can display the correct error reference to the donor [23:35:40] (03PS4) 10Cstone: WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [23:37:15] (03CR) 10CI reject: [V:04-1] WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 (owner: 10Cstone) [23:41:35] (03PS1) 10Lars SG: Queue donor history rebuilds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362239 (https://phabricator.wikimedia.org/T443265) [23:41:38] (03CR) 10Jforrester: "check experimental" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362128 (https://phabricator.wikimedia.org/T434041) (owner: 10Lars SG) [23:42:01] (03CR) 10Jforrester: "check experimental" [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1358292 (owner: 10Lars SG) [23:43:00] (03CR) 10CI reject: [V:04-1] Queue donor history rebuilds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362239 (https://phabricator.wikimedia.org/T443265) (owner: 10Lars SG) [23:44:14] (03CR) 10Eileen: "yeah - this is a step towards that - ie we didn't have a queue mechanism - this starts to build it" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311308 (https://phabricator.wikimedia.org/T419044) (owner: 10Eileen) [23:56:48] (03PS2) 10Lars SG: Queue donor history rebuilds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362239 (https://phabricator.wikimedia.org/T443265) [23:57:07] (03PS3) 10Lars SG: Queue donor history rebuilds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362239 (https://phabricator.wikimedia.org/T443265) [23:57:28] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06Release-Engineering-Team, 10Continuous-Integration-Config, 13Patch-For-Review: Run CiviCRM tests under trixie / PHP8.4 - https://phabricator.wikimedia.org/T439483#12513743 (10Jdforrester-WMF) 05Openβ†’03Resolved a:03Jdforrester-WMF This is...