[00:59:29] (03CR) 10Dmiranda: [C:03+2] "Thanks @lsandergreen LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362362 (https://phabricator.wikimedia.org/T434024) (owner: 10Lars SG) [01:10:50] (03Merged) 10jenkins-bot: Restore the permission class after each test in WMFTestListener [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362362 (https://phabricator.wikimedia.org/T434024) (owner: 10Lars SG) [01:29:25] (03CR) 10Wfan: [C:03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363465 (https://phabricator.wikimedia.org/T443544) (owner: 10Wfan) [01:30:39] (03PS1) 10Cstone: Add the ability for force a session reset and add handling for monthly convert return [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363536 (https://phabricator.wikimedia.org/T443651) [01:31:13] (03Merged) 10jenkins-bot: Update the ui for select payment method border [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363465 (https://phabricator.wikimedia.org/T443544) (owner: 10Wfan) [01:32:04] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Way to reset the session - https://phabricator.wikimedia.org/T443651#12520472 (10AnnWF) a:05AnnWFβ†’03Cstone [01:32:13] (03CR) 10CI reject: [V:04-1] Add the ability for force a session reset and add handling for monthly convert return [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363536 (https://phabricator.wikimedia.org/T443651) (owner: 10Cstone) [01:56:14] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki: ComboWiki Testing: UI for button needs change - https://phabricator.wikimedia.org/T443695#12520562 (10dmiranda) [03:03:14] (03CR) 10Cstone: [V:03+2] Take the journal cost centre from the account, not is_major_gift [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362304 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [03:03:31] (03CR) 10Cstone: [C:03+2] Fix the restricted funding field to be gl_code based [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362339 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [03:06:08] (03CR) 10Cstone: [C:03+2] Rename JournalGLConstants to FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361736 (owner: 10Eileen) [03:06:44] (03Abandoned) 10Ejegg: WIP hide cookie stores multiple reasons [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1362223 (https://phabricator.wikimedia.org/T441351) (owner: 10Ejegg) [03:06:50] (03CR) 10Cstone: [C:03+2] Take the journal cost centre from the account, not is_major_gift [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362304 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [03:07:33] ejegg: would you have a couple of minutes to scan over this https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1363536, its what claude suggested for the session issue but i dont actually think its a session issue in what we thought [03:07:39] i think its the monthly convert issue you brought up [03:08:01] let me take a look [03:11:03] hmmm [03:12:36] oh lol [03:12:52] gateway adapter::validate sets a default payment method if one isn't set [03:12:56] booooo [03:13:14] cstone ^^^ [03:13:19] we need plan B! [03:14:07] is this hack enough while we plan B [03:16:19] (03Merged) 10jenkins-bot: Take the journal cost centre from the account, not is_major_gift [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362304 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [03:16:21] (03Merged) 10jenkins-bot: Fix the restricted funding field to be gl_code based [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362339 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [03:16:22] (03Merged) 10jenkins-bot: Rename JournalGLConstants to FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361736 (owner: 10Eileen) [03:17:42] (03PS4) 10Eileen: Share the finance batch lock name and the competing-lock test helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361737 [03:17:51] (03PS4) 10Eileen: Add WMFAudit.ReserveAdjustmentBatches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361738 [03:17:59] (03PS4) 10Eileen: Add Batch.generateAdjustmentJournals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362305 [03:21:50] (03PS1) 10Ejegg: Add source_type to end of failmail subject [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1363591 [03:25:57] ncie ejegg [03:26:11] (03PS1) 10Dmiranda: ComboWiki: Update card and PayPal button labels [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363592 (https://phabricator.wikimedia.org/T443695) [03:26:19] ejegg: would it be more helpful at the beginning? [03:27:10] (03CR) 10Cstone: Add source_type to end of failmail subject (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1363591 (owner: 10Ejegg) [04:06:11] (03PS1) 10Ejegg: Stop using adapters to get AccountInfo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 [04:07:26] cstone: there's a baby step towards plan B ^^^ [04:07:29] (03CR) 10CI reject: [V:04-1] Stop using adapters to get AccountInfo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 (owner: 10Ejegg) [04:08:06] oh phooey on you phan [04:08:09] PhanTypeArraySuspiciousNullable Suspicious array access to $firstAccount of nullable type mixed|null [04:09:45] (03PS2) 10Ejegg: Stop using adapters to get AccountInfo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 [04:11:03] maybe just maybe tomorrow I can knock out the rest of that adapter use from clientConfig [04:11:18] but that still leaves the adapter use in the getFormFields and validation [05:29:24] (03CR) 10Cstone: [C:03+2] Share the finance batch lock name and the competing-lock test helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361737 (owner: 10Eileen) [05:37:23] (03Merged) 10jenkins-bot: Share the finance batch lock name and the competing-lock test helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361737 (owner: 10Eileen) [05:44:00] (03CR) 10Cstone: [C:03+2] Add WMFAudit.ReserveAdjustmentBatches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361738 (owner: 10Eileen) [05:45:25] (03CR) 10Cstone: [C:03+2] Add Batch.generateAdjustmentJournals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362305 (owner: 10Eileen) [05:52:41] (03Merged) 10jenkins-bot: Add WMFAudit.ReserveAdjustmentBatches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1361738 (owner: 10Eileen) [05:54:19] (03Merged) 10jenkins-bot: Add Batch.generateAdjustmentJournals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362305 (owner: 10Eileen) [06:44:25] (03PS1) 10Eileen: Adjust Restricted gift logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363896 (https://phabricator.wikimedia.org/T409994) [06:45:07] (03PS1) 10Eileen: Add WMFAudit.generateAdjustmentBatch to drive the correction through [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363897 [11:34:27] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Develop & implement retention policy for email addresses overwritten when donor provides new email address on donation form - https://phabricator.wikimedia.org/T434832#12521781 (10krobinson) Hey @Lars do we have a timeline on saving... [14:44:22] (03open) 10laurabarluzzi: Update scripts to grant authentication to the isolated _claude_runner user in MacOS [repos/fundraising-tech/safe-assistant] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/safe-assistant/-/merge_requests/2 [14:45:44] (03update) 10laurabarluzzi: Update scripts to grant authentication to the isolated _claude_runner user in MacOS [repos/fundraising-tech/safe-assistant] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/safe-assistant/-/merge_requests/2 [14:55:19] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12522580 (10AStein-WMF) [14:59:29] (03CR) 10Laurabarluzzi: [C:03+2] "I could successfully test a payment following the instruction on the phab. The flow was smooth and my test email was janedoe@example.com. " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363243 (https://phabricator.wikimedia.org/T442703) (owner: 10Damilare Adedoyin) [15:00:50] (03Merged) 10jenkins-bot: Combowiki: Support for Adyen 3DS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363243 (https://phabricator.wikimedia.org/T442703) (owner: 10Damilare Adedoyin) [15:01:14] thanks larssandergreen ! [15:11:41] np [15:12:00] I was happy to see that testing 3ds was easier than expected :D [15:23:33] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12522807 (10AStein-WMF) [15:32:03] (03PS3) 10Ejegg: Stop using adapters to get AccountInfo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 [15:32:03] (03PS1) 10Ejegg: Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 [15:32:30] ok fr-tech that's another step towards plan B ^^^ [15:33:49] (03CR) 10CI reject: [V:04-1] Stop using adapters to get AccountInfo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 (owner: 10Ejegg) [15:33:50] (03CR) 10CI reject: [V:04-1] Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (owner: 10Ejegg) [15:34:08] Whoa! Victoria Oyelola is officially contracting with the banner team. That's awesome. She was the outreachy volunteer who made the WYSIWYG banner editor tool. [15:35:51] (03PS4) 10Ejegg: Stop using adapters to get AccountInfo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 [15:36:51] (03PS2) 10Ejegg: Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 [15:38:34] (03CR) 10CI reject: [V:04-1] Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (owner: 10Ejegg) [15:53:01] nice ejegg ! Was she the one at the hack in Italy? [15:54:35] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12523065 (10Ejegg) Congratulations on the contract @VOyelola-WMF ! [15:54:38] yep damilare [15:55:52] cool cool! [15:56:15] (03PS3) 10Ejegg: Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 [15:56:25] Oh I should make a phab to hang all this work on [15:58:34] (03CR) 10CI reject: [V:04-1] Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (owner: 10Ejegg) [15:59:11] ejegg: are you working towards plan B and removing adapters logic from combowiki? I think an epic/parent phab would be great for this so we track changes and can put in a place the required functionalities to β€œmigrate” [16:01:34] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Stop instantiating gateway adapters at first Combowiki page load - https://phabricator.wikimedia.org/T443802 (10Ejegg) 03NEW [16:03:03] there it is laura|kids ^^^ [16:03:26] I'll tag those gerrit patches against it [16:03:48] (03PS5) 10Ejegg: Stop using adapters to get AccountInfo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 (https://phabricator.wikimedia.org/T443802) [16:08:18] (03PS4) 10Ejegg: Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (https://phabricator.wikimedia.org/T443802) [16:11:23] (03PS1) 10Lars SG: Only query for pre-log recurrings if needed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364466 (https://phabricator.wikimedia.org/T443713) [16:11:37] (03PS2) 10Lars SG: Only query for pre-log recurrings if needed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364466 (https://phabricator.wikimedia.org/T443713) [16:12:29] (03PS3) 10Lars SG: Only query for pre-log recurrings if needed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364466 (https://phabricator.wikimedia.org/T431586) [16:14:55] (03PS2) 10Ejegg: Mark outcomes for Braintree gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363419 [16:15:35] fr-tech ^^^ should hopefully be pretty simple to review and we should have it before we send more traffic to Braintree [16:16:16] it's basically a clone of the patch to add those calls to DLocal: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1357340 [16:18:54] (03PS4) 10Lars SG: Only query for pre-log recurrings if needed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364466 (https://phabricator.wikimedia.org/T443713) [16:18:56] (03PS1) 10Lars SG: Cache excluded contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364472 (https://phabricator.wikimedia.org/T431586) [16:34:22] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Develop & implement retention policy for email addresses overwritten when donor provides new email address on donation form - https://phabricator.wikimedia.org/T434832#12523498 (10Lars) @krobinson @SHust Unfortunately, I'm not going... [16:49:42] (03PS3) 10Damilare Adedoyin: Add mailcheck composable [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363487 (https://phabricator.wikimedia.org/T439258) [16:49:59] (03CR) 10Damilare Adedoyin: "@lbarluzzi@wikimedia.org thanks for looking at the patch. The `ext.donationInterface.mailcheck` module was created specifically for the Ma" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363487 (https://phabricator.wikimedia.org/T439258) (owner: 10Damilare Adedoyin) [16:51:12] (03CR) 10Lars SG: "Yes, just adding the columns only changes metadata, so it's fast (it does need a lock, but that's fine for a few seconds). Would be differ" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362109 (https://phabricator.wikimedia.org/T443300) (owner: 10Lars SG) [16:53:57] checking the patch ejegg [17:04:15] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-CentralNotice-Administration, 05MW-1.48-notes (1.48.0-wmf.4; 2026-11-10): Provide a way to display of a banner only to users who reach a... - https://phabricator.wikimedia.org/T269758#12523675 [17:04:58] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for adding this in ejegg, LGTM. We just need to do the corresponding mapping in SmashPig for it to take effect." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363419 (owner: 10Ejegg) [17:07:14] (03Merged) 10jenkins-bot: Mark outcomes for Braintree gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363419 (owner: 10Ejegg) [17:16:36] thanks damilare [17:16:48] yeah, it will at least get the auth / declines in there [17:17:16] lemme make a phab to map isSuspectedFraud for all the other gateways [17:22:48] 06Fundraising-Backlog, 10FR-Smashpig, 07FR-Fraud: Map isSuspectedFraud for all gateways - https://phabricator.wikimedia.org/T443814 (10Ejegg) 03NEW [17:31:17] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12523827 (10VOyelola-WMF) Thank you very much!πŸ€— @Ejegg [17:33:51] (03PS1) 10Wfan: wip: braintree delete token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) [17:39:22] (03PS2) 10Wfan: braintree delete token when cancel subscription from dp [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) [17:48:26] (03CR) 10CI reject: [V:04-1] braintree delete token when cancel subscription from dp [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) (owner: 10Wfan) [18:09:46] (03CR) 10Lars SG: "The other factor that could cause it to be slow is a log table (but there is no logging for this table, so not a concern here). But I did " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362109 (https://phabricator.wikimedia.org/T443300) (owner: 10Lars SG) [18:34:14] (03CR) 10CI reject: [V:04-1] build: Updating npm dependencies [extensions/FundraisingTranslateWorkflow] (REL1_43) - 10https://gerrit.wikimedia.org/r/1157359 (owner: 10Libraryupgrader) [19:22:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic snooze_end_date is in the wrong format - https://phabricator.wikimedia.org/T443824 (10Lars) 03NEW [19:22:41] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki, 13Patch-For-Review: ComboWiki Testing: UI for button needs change - https://phabricator.wikimedia.org/T443695#12524257 (10dmiranda) Hi @AnnWF and @Laurabarluzzi thanks both for taking a look and answering my questions during stand. After taking a 2... [19:22:43] (03PS2) 10Dmiranda: ComboWiki: Update card and PayPal button labels [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363592 (https://phabricator.wikimedia.org/T443695) [19:26:25] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Check and Fix Monthly Convert session setting if needed - https://phabricator.wikimedia.org/T443701#12524270 (10Cstone) p:05Triageβ†’03High [19:26:29] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Stop instantiating gateway adapters at first Combowiki page load - https://phabricator.wikimedia.org/T443802#12524271 (10Cstone) p:05Triageβ†’03High [19:26:51] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Error Handling - Handle multiple payment attempts - https://phabricator.wikimedia.org/T443538#12524272 (10Cstone) p:05Triageβ†’03High [19:26:55] (03CR) 10Laurabarluzzi: [C:04-1] "The overall solution is approved, but I think you missed one spot that still uses the adapter and we might have some uncaught errors throw" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [19:27:48] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki, 13Patch-For-Review: ComboWiki Testing: UI for button needs change - https://phabricator.wikimedia.org/T443695#12524279 (10Cstone) p:05Triageβ†’03High [19:29:34] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki, 05MW-1.47-notes (1.47.0-wmf.24; 2026-10-13), and 2 others: Combowiki: Internal QA - https://phabricator.wikimedia.org/T439191#12524290 (10Cstone) p:05Triageβ†’03Low [19:29:40] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki return from redirect on monthly donation shows monthly convert - https://phabricator.wikimedia.org/T440765#12524291 (10Cstone) p:05Triageβ†’03High [19:30:30] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Restore combowiki form field values from session - https://phabricator.wikimedia.org/T440476#12524293 (10Cstone) p:05Triageβ†’03Medium [19:30:42] (03CR) 10Wfan: [C:03+2] ComboWiki: Update card and PayPal button labels [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363592 (https://phabricator.wikimedia.org/T443695) (owner: 10Dmiranda) [19:31:43] (03CR) 10Laurabarluzzi: [C:03+2] "Sounds good and I think is fine to keep the "Donate" word even because being a one-click button is more explicit about what it does "submi" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363592 (https://phabricator.wikimedia.org/T443695) (owner: 10Dmiranda) [19:32:04] (03Merged) 10jenkins-bot: ComboWiki: Update card and PayPal button labels [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363592 (https://phabricator.wikimedia.org/T443695) (owner: 10Dmiranda) [19:33:25] ejegg|food: FYI I reviewed your ClientConfig refactoring for accessing AccountInfo https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1363657 [19:33:37] thanks laurabar ! [19:33:47] just making those fixes now [19:42:00] (03PS6) 10Ejegg: Stop using adapters to get AccountInfo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 (https://phabricator.wikimedia.org/T443802) [19:42:19] (03CR) 10Ejegg: "Thanks, Laura. I fixed it in PS6" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [19:44:50] (03PS4) 10Damilare Adedoyin: Add mailcheck composable [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363487 (https://phabricator.wikimedia.org/T439258) [19:46:16] (03CR) 10Ejegg: [C:03+2] "Thanks, this looks pretty good! I thought maybe we would implement mailcheck as another component living where the warning is rendered, bu" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363487 (https://phabricator.wikimedia.org/T439258) (owner: 10Damilare Adedoyin) [19:46:46] (03CR) 10Ejegg: [V:03+2] build: Updating npm dependencies [extensions/DonationInterface] (REL1_43) - 10https://gerrit.wikimedia.org/r/1338862 (owner: 10Libraryupgrader) [19:46:58] (03CR) 10Ejegg: [V:03+2] build: Updating dependencies [extensions/DonationInterface] (REL1_45) - 10https://gerrit.wikimedia.org/r/1355544 (owner: 10Libraryupgrader) [19:47:00] (03CR) 10Ejegg: [V:03+2] build: Updating npm dependencies [extensions/DonationInterface] (REL1_47) - 10https://gerrit.wikimedia.org/r/1355547 (owner: 10Libraryupgrader) [19:47:51] (03Merged) 10jenkins-bot: Add mailcheck composable [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363487 (https://phabricator.wikimedia.org/T439258) (owner: 10Damilare Adedoyin) [19:49:25] (03CR) 10Laurabarluzzi: [C:03+2] "Thanks for addressing the change and answering my questions so quickly, LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [19:49:49] thanks for the review ejegg ! I was also thinking of an independent component for email initially, but decided against since the composable handles all the logic. [19:50:00] We can reconsider if we need another email component [19:50:22] if we have use for another email field * [19:50:46] (03Merged) 10jenkins-bot: Stop using adapters to get AccountInfo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363657 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [19:52:15] cool cool [19:53:02] (03PS5) 10Ejegg: Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (https://phabricator.wikimedia.org/T443802) [19:59:46] (03PS1) 10Ejegg: Remove adapter from BraintreeClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) [20:01:12] (03CR) 10CI reject: [V:04-1] Remove adapter from BraintreeClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [20:32:20] (03PS1) 10Dwisehaupt: A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 [20:33:19] (03CR) 10CI reject: [V:04-1] A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 (owner: 10Dwisehaupt) [20:37:46] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12524493 (10AStein-WMF) [20:45:20] (03PS1) 10Lars SG: Correct Acoustic snoozed_end_date format [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364767 (https://phabricator.wikimedia.org/T431586) [20:47:53] (03CR) 10Laurabarluzzi: "Thanks for starting this! I dropped some initial questions/suggestions" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [20:55:42] (03PS8) 10Dmiranda: DonorPortal: prefill the login form for checksums that dont match [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358286 (https://phabricator.wikimedia.org/T436801) [20:58:25] (03PS2) 10Dwisehaupt: A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 [20:58:42] (03CR) 10CI reject: [V:04-1] A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 (owner: 10Dwisehaupt) [20:59:45] (03PS3) 10Wfan: wip: braintree delete token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) [21:01:33] (03CR) 10Dmiranda: "Great point @lsandergreen@wikimedia.org. I've updated it to just prefill the email field in patchset 8." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1358286 (https://phabricator.wikimedia.org/T436801) (owner: 10Dmiranda) [21:06:58] (03CR) 10Eileen: [C:03+2] Correct Acoustic snoozed_end_date format [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364767 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [21:07:21] (03CR) 10Eileen: [C:03+2] Add handling for ad clicks from contribution tracking message to table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1362109 (https://phabricator.wikimedia.org/T443300) (owner: 10Lars SG) [21:09:15] (03CR) 10Eileen: [C:03+2] Only query for pre-log recurrings if needed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364466 (https://phabricator.wikimedia.org/T443713) (owner: 10Lars SG) [21:09:29] (03CR) 10Eileen: [C:03+2] Cache excluded contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364472 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [21:09:46] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic snooze_end_date is in the wrong format - https://phabricator.wikimedia.org/T443824#12524674 (10Lars) Patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1364767 [21:09:53] (03CR) 10CI reject: [V:04-1] wip: braintree delete token [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) (owner: 10Wfan) [21:16:59] (03Merged) 10jenkins-bot: Correct Acoustic snoozed_end_date format [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364767 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [21:25:14] (03Merged) 10jenkins-bot: Only query for pre-log recurrings if needed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364466 (https://phabricator.wikimedia.org/T443713) (owner: 10Lars SG) [21:25:31] (03Merged) 10jenkins-bot: Cache excluded contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364472 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [21:28:12] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove incorrectly added civi log tables - https://phabricator.wikimedia.org/T443842 (10Lars) 03NEW [21:39:35] (03PS6) 10Ejegg: Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (https://phabricator.wikimedia.org/T443802) [21:40:21] (03CR) 10Ejegg: "Thanks Laura, I've adopted all your suggestions in the next PS" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [21:47:28] (03CR) 10Ejegg: "Note this patch (if it works) would help clear up tests involving multiple SmashPig processor configs: https://gerrit.wikimedia.org/r/c/wi" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [21:51:34] (03PS2) 10Ejegg: Remove adapter from BraintreeClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) [21:52:59] (03CR) 10CI reject: [V:04-1] Remove adapter from BraintreeClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [21:54:01] (03PS3) 10Dwisehaupt: A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 [21:54:20] (03CR) 10CI reject: [V:04-1] A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 (owner: 10Dwisehaupt) [21:55:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove incorrectly added civi log tables - https://phabricator.wikimedia.org/T443842#12524927 (10Lars) a:03Dwisehaupt [21:56:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikimedia-Fundraising-CiviCRM: Remove incorrectly added civi log tables - https://phabricator.wikimedia.org/T443842#12524928 (10Dwisehaupt) [21:57:52] (03PS4) 10Dwisehaupt: A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 [22:01:10] (03PS3) 10Ejegg: Remove adapter from BraintreeClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) [22:02:38] (03CR) 10CI reject: [V:04-1] Remove adapter from BraintreeClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [22:04:21] grr why is that still failing? [22:05:25] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Investigate how to pull MW donor account data into Civi - https://phabricator.wikimedia.org/T443848 (10Lars) 03NEW [22:06:19] (03PS5) 10Dwisehaupt: A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 [22:06:29] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Investigate how to pull MW donor account data into Civi from fr data lake - https://phabricator.wikimedia.org/T443848#12524965 (10Lars) [22:08:26] avishua: ^^ if you want to start on this, feel free, but I put it in next because I'm thinking more like Dec from my end [22:09:49] i think your constraints are stronger than mine. i can put the data anywhere so lmk if you have thoughts on where you'd like to pull it in from [22:10:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic snooze_end_date is in the wrong format - https://phabricator.wikimedia.org/T443824#12524995 (10Lars) Once we verify that this works correctly, we'll want to do some kind of backfill to update at least the more r... [22:11:04] could we, in theory, run queries directly on the relevant tables on your end? [22:11:48] as in, could civi query the FR data lake? or can i query data in p&t's data lake? [22:12:22] the first [22:13:49] if you can make api calls to s3-object storage then for sure. the data lake isnt a database as much as it is pointers to files on object storage that we pretend are tables [22:14:38] or we can create a schema in the civi db/ mariadb only for this kind of thing, separate from the application db [22:15:01] it really depends on your/ civi's query capabilities. e.g. i can write the data to a mariadb table [22:16:44] happy to talk on a huddle or meet if that's easier too [22:17:19] i suppose we could also maybe spin up a different mariadb instance if that's easier to query [22:17:59] I think we could probably make calls directly, would just need to add in a library to do that [22:18:21] Let's let this simmer and we can look in more detail in a couple weeks [22:18:35] πŸ‘ [22:20:26] (03CR) 10Dwisehaupt: [C:03+2] A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 (owner: 10Dwisehaupt) [22:20:46] (03Merged) 10jenkins-bot: A bunch of pylint fixes [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364746 (owner: 10Dwisehaupt) [22:22:54] (03PS1) 10Dwisehaupt: Drop most python2 support [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364869 [22:23:07] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1364870 [22:23:09] (03CR) 10CI reject: [V:04-1] Drop most python2 support [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364869 (owner: 10Dwisehaupt) [22:23:50] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1364870 (owner: 10Eileen) [22:25:31] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1364870 (owner: 10Eileen) [22:25:59] (03PS2) 10Dwisehaupt: Drop most python2 support [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364869 [23:26:15] !log civicrm upgraded from e09e0b2b to 5ba9d8e4 [23:26:16] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [23:37:01] FIRING: ContextSwitchingSpike: Host context switching high (instance frpm1002.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [23:40:47] Going to do a school pickup, brb [23:47:01] RESOLVED: ContextSwitchingSpike: Host context switching high (instance frpm1002.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [23:51:24] (03PS4) 10Wfan: add venmo to combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362174 (https://phabricator.wikimedia.org/T441808)