[00:11:57] wfan: have you been able to get the venmo qr code to scan? [00:12:27] yep [00:12:39] hmm it wont scan for me [00:12:47] were you trying to test that on your local? Let me check I just rebased to master [00:12:53] local and prod even [00:13:05] when you did the investigation could we upgrade to a new version of the sdk or something too? [00:13:16] gravys venmo qr code is blue and looks a bit different vs this one is black [00:13:42] im gona afk to have dinner in a few but will keep looing at the patch when i get back [00:13:58] we were using the lastest braintree sdk [00:14:07] hmm i wonder why gravy has a different qr code [00:14:25] so you see qr code but not scanable? [00:14:33] yeah my app wont scan it [00:14:37] r u testing from combo? could you load the one directly? [00:15:16] from both it wouldnt let me scan, I thought it was a me thing possibly [00:16:43] But I did spot something can improve after venmo success, we do not show baby globe before we show MC so feel a bit wired [00:17:09] my venmo version on phone 26.25.0 [00:18:12] im at 26 24 [00:20:52] (03PS1) 10Lars SG: Reduce history rebuild work for recurring donors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1365071 (https://phabricator.wikimedia.org/T431586) [00:22:40] https://localhost:9001/index.php?title=Special:BraintreeGateway&appeal=JimmyQuote&payment_method=venmo&recurring=0&uselang=en&language=en¤cy=USD&amount=10&country=US&debug=true if you see from console, sdk braintree was 3.147, which is the latest I am not sure what gravy used [00:23:24] gravy was https://assets.braintreegateway.com/web/3.123.1/html/venmo-desktop-frame.html#SANDBOX_8b3d0982-bf4c-4f55-acb0-e83bdc554a5d [00:23:29] 3.123 haha [00:23:56] huh okie ill be back after i eat and test again [00:24:04] inspect element can find the version [00:24:10] ok thanks again for test! [00:24:33] https://assets.braintreegateway.com/web/3.147.0/html/venmo-desktop-frame.html#SANDBOX_5a1df2b0-7e45-478e-8bef-9a0477c5cf2f was from braintree [00:54:08] (03PS1) 10Lars SG: Cache the history segment/status query per table, financial year & has-pre-log-recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1365126 (https://phabricator.wikimedia.org/T431586) [00:55:29] (03PS2) 10Lars SG: Cache the history segment/status query per table, financial year & has-pre-log-recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1365126 (https://phabricator.wikimedia.org/T431586) [01:20:14] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations, 13Patch-For-Review: Forget me is slow - https://phabricator.wikimedia.org/T442061#12525508 (10Lars) @MBeat33 You should now see the list of which contributions weren't found at adyen at the top o... [01:28:36] eileen: I was looking at one of your patches an mistakenly asked claude to review more than I intended to, but some of this looks like it should be addressed https://www.irccloud.com/pastebin/n7Yf6t5o/ [01:36:50] (03CR) 10Lars SG: [C:03+2] Adjust Restricted gift logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363896 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [01:36:57] eileen: Also not at all a blocker to merging but this minor detail: 6. Stale getAccountClause() references after the rename: the FinanceConstants.php:75 docblock, which also still says 43428 is the only [01:36:57] restricted case, and the comments at GenerateBatchTest.php:177, :241 and :391. [01:45:01] (03Merged) 10jenkins-bot: Adjust Restricted gift logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363896 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [02:45:16] (03PS1) 10Dmiranda: WIP Record PayPal dispute reversals as chargebacks [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1365298 (https://phabricator.wikimedia.org/T442249) [03:00:30] (03PS2) 10Dmiranda: WIP Record PayPal dispute reversals as chargebacks [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1365298 (https://phabricator.wikimedia.org/T442249) [03:07:20] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Paypal recurrings refunded via the resolution center don't cancel the recurring - https://phabricator.wikimedia.org/T442249#12525726 (10dmiranda) Hi Team! I ju... [04:19:16] (03CR) 10Cstone: [C:03+2] "got the qr code to scan by using my phone camera, not the app (which is weird). But looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362174 (https://phabricator.wikimedia.org/T441808) (owner: 10Wfan) [04:20:39] (03Merged) 10jenkins-bot: add venmo to combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1362174 (https://phabricator.wikimedia.org/T441808) (owner: 10Wfan) [04:40:11] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1365596 [04:41:10] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1365596 (owner: 10Cstone) [04:42:20] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1365596 (owner: 10Cstone) [04:43:36] !log payments-wiki upgraded from e801b49c to 6d847ea1 [04:43:37] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [08:19:22] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [08:20:55] (03Merged) 10jenkins-bot: Remove adapter completely from AdyenClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [09:14:30] (03CR) 10Laurabarluzzi: "Hi @rlopez@wikimedia.org, nice to gerrit meet you! 😊" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361615 (owner: 10Ramon Lopez) [09:49:39] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_47) - 10https://gerrit.wikimedia.org/r/1362521 (owner: 10L10n-bot) [12:22:56] FIRING: NodeDown: Node frbast2002 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=frbast2002 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [12:27:56] FIRING: [2x] NodeDown: Node frbast2002 is down. - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [12:32:56] RESOLVED: [2x] NodeDown: Node frbast2002 is down. - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [13:27:27] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12527053 (10VOyelola-WMF) SSH Public Key ` ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIILCnmRwcoibPbi7/y/YZefKfNlwKbMYqaHtGZUVeSDX voyelola-ctr@wikimedia.org ` [13:40:26] (03CR) 10Laurabarluzzi: [C:04-1] "@cstone@wikimedia.org As I looked into this, I felt that there are edge cases and issues that maybe is not worth introducing only for test" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363536 (https://phabricator.wikimedia.org/T443651) (owner: 10Cstone) [14:21:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Failmail: started from Oct 31st caused by passing null to a string only func - https://phabricator.wikimedia.org/T443920 (10Laurabarluzzi) 03NEW [14:22:05] (03PS1) 10Laurabarluzzi: Make null safe check in DirectDepositPaymentProviderResponseMapper.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1366237 (https://phabricator.wikimedia.org/T443920) [14:31:18] (03PS1) 10Lars SG: Re-send all future snooze dates to Acoustic to fix date format [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1366253 (https://phabricator.wikimedia.org/T443824) [14:31:34] (03CR) 10CI reject: [V:04-1] Re-send all future snooze dates to Acoustic to fix date format [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1366253 (https://phabricator.wikimedia.org/T443824) (owner: 10Lars SG) [14:31:35] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Acoustic snooze_end_date is in the wrong format - https://phabricator.wikimedia.org/T443824#12527325 (10Lars) Working as expected, backfill patch for review. [14:31:55] (03Abandoned) 10Laurabarluzzi: Make null safe check in DirectDepositPaymentProviderResponseMapper.php [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1366237 (https://phabricator.wikimedia.org/T443920) (owner: 10Laurabarluzzi) [14:33:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Failmail: started from Oct 31st caused by passing null to a string only func - https://phabricator.wikimedia.org/T443920#12527329 (10Laurabarluzzi) 05Open→03Declined [14:33:17] (03PS2) 10Lars SG: Re-send all future snooze dates to Acoustic to fix date format [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1366253 (https://phabricator.wikimedia.org/T443824) [14:36:27] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Paypal recurrings refunded via the resolution center don't cancel the recurring - https://phabricator.wikimedia.org/T442249#12527336 (10Lars) @dmiranda I think... [16:29:35] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Investigate how to pull MW donor account data into Civi from fr data lake - https://phabricator.wikimedia.org/T443848#12528005 (10AStein-WMF) [17:01:33] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Error Handling - Handle multiple payment attempts - https://phabricator.wikimedia.org/T443538#12528139 (10Cstone) [17:07:40] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12528177 (10AStein-WMF) [17:13:40] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki: ComboWiki: Update Adyen + Braintree country_fields.yaml - https://phabricator.wikimedia.org/T443707#12528196 (10AnnWF) [17:13:51] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki: Combowiki Testing: refactor all payment page validation - https://phabricator.wikimedia.org/T443702#12528197 (10AnnWF) [17:19:45] (03PS2) 10Ramon Lopez: ComboWiki UI: Added appeal components and styles [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361615 [17:24:38] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Make the payment button text just the payment method icons - https://phabricator.wikimedia.org/T443958 (10Cstone) 03NEW [17:25:17] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Make the payment button text just the payment method icons - https://phabricator.wikimedia.org/T443958#12528297 (10Cstone) [17:29:09] (03CR) 10Ramon Lopez: "Hi @lbarluzzi@wikimedia.org nice to gerrit meet you too!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1361615 (owner: 10Ramon Lopez) [17:34:12] (03PS1) 10Ejegg: Fix fluent setters on all responses [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1366469 [18:11:06] fr-tech ^^^ should be pretty straightforward to review, just makes things more consistent [18:11:34] and this is the one I'm depending on for the DI test patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1359928 [18:12:07] will send that for review shortly but it'll fail in CI till we tag a smashpig update with ^^^ [18:18:36] ok, locally I've got all the tests passing with scripts/payments-phpunit.sh --filter=DonateTest [18:19:48] (03PS1) 10Ejegg: WIP mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 [18:20:00] If you pull down https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1359928 [18:20:18] in your payments/vendor/wikimedia/smash-pig directory you should be able to get that working too [18:20:22] oh i can take off WIP [18:20:47] (03PS2) 10Ejegg: Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 [18:22:25] (03CR) 10CI reject: [V:04-1] Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 (owner: 10Ejegg) [18:24:33] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add "chargeback_alert" to cancel reason for contribution recur - https://phabricator.wikimedia.org/T432159#12528653 (10MBeat33) [18:26:36] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Occasional failures when previewing centralnotice banners - https://phabricator.wikimedia.org/T443965 (10Pcoombe) 03NEW [18:29:44] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Occasional failures when previewing centralnotice banners - https://phabricator.wikimedia.org/T443965#12528680 (10Pcoombe) Forgot to say: when it happens I do see a request to Special:BannerLoader in the Network panel, with a 200 status and what look... [18:34:48] (03PS1) 10Lars SG: Treat "Completed" recurrings without an end or cancel date as active in rebuilt history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1366549 (https://phabricator.wikimedia.org/T431586) [18:35:38] (03PS2) 10Lars SG: Reduce history rebuild work for recurring donors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1365071 (https://phabricator.wikimedia.org/T431586) [18:35:38] (03PS3) 10Lars SG: Cache the history segment/status query per table, financial year & has-pre-log-recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1365126 (https://phabricator.wikimedia.org/T431586) [18:35:38] (03PS2) 10Lars SG: Treat "Completed" recurrings without an end or cancel date as active in rebuilt history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1366549 (https://phabricator.wikimedia.org/T431586) [18:56:45] (03PS1) 10Lars SG: Treat Cancelled recurrings that are now Failed as Failed in rebuilt history [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1366565 (https://phabricator.wikimedia.org/T431586) [19:29:17] fr-tech can I get a C+2 on at least this one to let me keep going with the clientConfic stuff? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1359928 [19:29:39] (03CR) 10Cstone: [C:03+2] Let a test override multiple provider configs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359928 (owner: 10Ejegg) [19:29:42] sure ejegg [19:29:43] Thank you! [19:29:56] pure testing patch, no change of real life side effects [19:30:14] (03Merged) 10jenkins-bot: Let a test override multiple provider configs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1359928 (owner: 10Ejegg) [19:31:19] this one is nice-to-have but if you don't want to do a quick C+2 i can tag a version without it: https://gerrit.wikimedia.org/r/1366469 [19:31:33] (03PS3) 10Dmiranda: Record PayPal dispute reversals as chargebacks [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1365298 (https://phabricator.wikimedia.org/T442249) [19:32:57] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Paypal recurrings refunded via the resolution center don't cancel the recurring - https://phabricator.wikimedia.org/T442249#12528873 (10dmiranda) Thanks @Lars,... [19:32:58] (03CR) 10Cstone: [C:03+2] Fix fluent setters on all responses [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1366469 (owner: 10Ejegg) [19:33:03] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Add "chargeback_alert" to cancel reason for contribution recur - https://phabricator.wikimedia.org/T432159#12528874 (10MBeat33) @Lars the latter suggestion of a custom field that would enable both optio... [19:33:38] (03Merged) 10jenkins-bot: Fix fluent setters on all responses [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1366469 (owner: 10Ejegg) [19:35:34] thanks cstone ! [19:36:56] (03Abandoned) 10Cstone: Add the ability for force a session reset and add handling for monthly convert return [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1363536 (https://phabricator.wikimedia.org/T443651) (owner: 10Cstone) [19:37:01] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 06FR-donorrelations: Validation for AmEx BINS for BDT currency - https://phabricator.wikimedia.org/T424465#12528879 (10MBeat33) Donors are still reporting bank rejection errors ZD [[ https://wikimedia.zendesk.com/agent/tickets/1962666 | 1962666 ]] [19:44:26] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 06FR-donorrelations: Validation for AmEx BINS for BDT currency - https://phabricator.wikimedia.org/T424465#12528889 (10MBeat33) Donors are still reporting bank rejection errors from entering AmEx numbers in countries where it is an unaccepted method, Zendesk... [19:59:36] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Paypal recurrings refunded via the resolution center don't cancel the recurring - https://phabricator.wikimedia.org/T442249#12528921 (10Lars) @Ejegg You had th... [20:02:36] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Occasional failures when previewing centralnotice banners - https://phabricator.wikimedia.org/T443965#12528925 (10SBurnett-WMF) @Ejegg could you please assess and afix priority? [20:08:16] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen (Experiment Platform Sprint 32): SPIKE: what CentralNotice concept maps to a 'treatment' in TestKitchen - https://phabricator.wikimedia.org/T443454#12528927 (10Pcoombe) Hmm, our normal practice is to run completely separate testing t... [20:17:10] (03PS3) 10Ejegg: Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 [20:18:20] (03CR) 10CI reject: [V:04-1] Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 (owner: 10Ejegg) [20:21:24] (03PS3) 10Dwisehaupt: Drop most python2 support [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364869 [20:25:41] (03CR) 10Dwisehaupt: [C:03+2] Drop most python2 support [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364869 (owner: 10Dwisehaupt) [20:25:59] (03Merged) 10jenkins-bot: Drop most python2 support [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1364869 (owner: 10Dwisehaupt) [20:26:01] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Develop queue-stopping process that stops long-running jobs first and quick ones later - https://phabricator.wikimedia.org/T443974 (10Lars) 03NEW [20:27:58] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen (Experiment Platform Sprint 32): SPIKE: what CentralNotice concept maps to a 'treatment' in TestKitchen - https://phabricator.wikimedia.org/T443454#12528949 (10Ejegg) I wonder if a limt/switch campaign with randomization would be bet... [20:29:08] (03PS1) 10Dwisehaupt: pylint ignore and add some defaults in irc.py [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1366701 [20:30:51] (03PS4) 10Dmiranda: Record PayPal dispute reversals as chargebacks [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1365298 (https://phabricator.wikimedia.org/T442249) [20:31:14] (03CR) 10Ejegg: [C:03+2] "Thanks Daniel, this looks like a good straightforward solution!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1365298 (https://phabricator.wikimedia.org/T442249) (owner: 10Dmiranda) [20:31:41] (03Merged) 10jenkins-bot: Record PayPal dispute reversals as chargebacks [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1365298 (https://phabricator.wikimedia.org/T442249) (owner: 10Dmiranda) [20:35:14] (03PS4) 10Ejegg: Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 [20:49:20] (03CR) 10Brown00: "resoc" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364447 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [20:51:43] ehhh? Gerrit spam? ^^^ [20:52:19] weird ejegg [20:52:58] (03PS5) 10Ejegg: Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 [20:53:19] cstone: would you be able to take a look at ^^^ too? [20:53:29] I'm going to continue the clientCOnfig chain on top of it [20:53:46] yeah ejegg was just going to ask if its ready [20:54:00] i think PS5 is its final form [20:54:28] (03CR) 10CI reject: [V:04-1] Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 (owner: 10Ejegg) [20:54:31] grr [20:54:53] thanks ejegg for the review! [20:55:03] yw danielfm [20:55:13] lol 1 extra space found in linting [20:55:23] (my patch not yours) [20:56:09] (03PS6) 10Ejegg: Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 [20:56:42] final_FINAL_really.patch ^^^ [20:57:31] i mostly remember to run tests before review but i still always forget to lint [20:58:21] the linter boss is real [21:00:01] (03PS4) 10Ejegg: Remove adapter from BraintreeClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) [21:00:40] (03CR) 10Cstone: [C:03+2] Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 (owner: 10Ejegg) [21:00:49] thank you cstone! [21:01:55] (03Merged) 10jenkins-bot: Mock multiple SmashPig providers for Donate tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366524 (owner: 10Ejegg) [21:02:06] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Occasional failures when previewing centralnotice banners - https://phabricator.wikimedia.org/T443965#12529021 (10Wargo) How with `force=1` and/or logged out on clean session? [21:02:16] woo, the braintree one passes when rebased over that [21:02:21] now for the gravy one [21:03:23] woo! [21:04:17] (03PS1) 10Ejegg: Remove adapter from GravyClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366739 (https://phabricator.wikimedia.org/T443802) [21:04:43] I'll do a follow-on patch to make the gravy session ID come from the clientConfig like we do with the braintree one [21:06:00] oh oops there are a couple duplicated lines in setSmashPigAdyenProviderConfiguration [21:06:56] (03PS1) 10Ejegg: Remove extra lines in test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366742 [21:30:20] ejegg: im finishing eating then i can look at these [21:38:16] (03PS2) 10Dwisehaupt: pylint ignore and add some defaults in irc.py [wikimedia/fundraising/slander] - 10https://gerrit.wikimedia.org/r/1366701 [21:47:50] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Develop queue-stopping process that stops long-running jobs first and quick ones later - https://phabricator.wikimedia.org/T443974#12529121 (10Lars) [21:49:10] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Develop queue-stopping process that stops long-running jobs first and quick ones later - https://phabricator.wikimedia.org/T443974#12529124 (10Lars) a:03Lars Added a `disable_long` script to process-control... [22:14:57] (03CR) 10Cstone: [C:03+2] "thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [22:16:27] (03CR) 10Cstone: [C:03+2] Remove adapter from GravyClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366739 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [22:16:35] (03CR) 10Cstone: [C:03+2] Remove extra lines in test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366742 (owner: 10Ejegg) [22:16:42] (03Merged) 10jenkins-bot: Remove adapter from BraintreeClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1364706 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [22:17:39] (03Merged) 10jenkins-bot: Remove adapter from GravyClientConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366739 (https://phabricator.wikimedia.org/T443802) (owner: 10Ejegg) [22:17:56] (03Merged) 10jenkins-bot: Remove extra lines in test [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366742 (owner: 10Ejegg) [22:40:36] (03PS1) 10Ramon Lopez: ComboWikiUI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 [22:42:10] (03CR) 10CI reject: [V:04-1] ComboWikiUI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [22:53:26] (03PS2) 10Ramon Lopez: ComboWikiUI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 [22:54:46] (03CR) 10CI reject: [V:04-1] ComboWikiUI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [22:57:36] (03PS3) 10Ramon Lopez: ComboWikiUI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 [22:59:15] (03CR) 10CI reject: [V:04-1] ComboWikiUI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [23:21:49] (03PS4) 10Ramon Lopez: ComboWikiUI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 [23:24:26] (03PS5) 10Ramon Lopez: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 [23:57:50] (03PS1) 10Wfan: Show another amount link in MC fit in Mobile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366904 (https://phabricator.wikimedia.org/T443972) [23:58:15] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki, 13Patch-For-Review: ComboWiki Test: fix the phone ui with long text in MC - https://phabricator.wikimedia.org/T443972#12529340 (10AnnWF) a:03AnnWF [23:58:24] FIRING: SystemdService: Systemd service coworker.service stopped on civi1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService