[00:00:29] (03PS1) 10Lars SG: Change paused recurring definition to 32/367 days until next scheduled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368410 (https://phabricator.wikimedia.org/T444407) [00:01:28] (03PS1) 10Eileen: Update Manual batch search per changes made on prod with Melanie [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368411 [00:03:50] (03PS1) 10Lars SG: Change paused recurring definition to 32/367 days until next scheduled [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368412 (https://phabricator.wikimedia.org/T444407) [00:04:12] (03PS2) 10Lars SG: Change paused recurring definition to 32/367 days until next scheduled [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368412 (https://phabricator.wikimedia.org/T444407) [00:05:08] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Change paused definition to 32/367 days in the future - https://phabricator.wikimedia.org/T444407#12542532 (10Lars) [00:05:24] (03PS2) 10Lars SG: Change paused recurring definition to 32/367 days until next scheduled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368410 (https://phabricator.wikimedia.org/T444407) [00:07:20] thanks eileen, I have one more I just pushed up which should hopefully be that last change for this donor history: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1368410 [00:12:51] (03PS3) 10Lars SG: Change paused recurring definition to 32/367 days until next scheduled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368410 (https://phabricator.wikimedia.org/T444407) [02:01:20] (03PS4) 10Ejegg: Remove Braintree post-payment recurring convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368385 [02:14:22] ok cstone ^^^ looks right finally [02:23:13] 06Fundraising-Backlog, 10FR-WMF-Audit, 07Epic: Paypal audit not resolving -> braintree paypal_ec - https://phabricator.wikimedia.org/T444253#12542953 (10Eileenmcnaughton) OK - so noting that the donation test by Amber was created "auth_id":"","capture_id"","backend_processor_txn_id":"2HM750258G829434L""... [02:44:52] (03PS1) 10Ejegg: WIP brantree / paypal rediects. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 [02:45:31] oh actually, let me stick that change in the vault: param on to the other patch [02:47:29] (03CR) 10Lars SG: [C:03+2] Update Manual batch search per changes made on prod with Melanie [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368411 (owner: 10Eileen) [02:47:39] thanks larssandergreen [02:48:49] (03CR) 10Lars SG: [C:03+2] Allow ach & wire batches to self-correct item count when totals reconcile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368400 (owner: 10Eileen) [02:52:37] (03CR) 10Lars SG: [C:03+2] Set gateway account on batches created in tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367977 (owner: 10Eileen) [02:53:31] (03CR) 10Lars SG: [C:03+2] Improve use of GatewayAccount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367978 (owner: 10Eileen) [02:56:19] (03Merged) 10jenkins-bot: Update Manual batch search per changes made on prod with Melanie [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368411 (owner: 10Eileen) [02:58:17] (03Merged) 10jenkins-bot: Allow ach & wire batches to self-correct item count when totals reconcile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368400 (owner: 10Eileen) [03:01:08] (03Merged) 10jenkins-bot: Set gateway account on batches created in tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367977 (owner: 10Eileen) [03:01:10] (03Merged) 10jenkins-bot: Improve use of GatewayAccount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367978 (owner: 10Eileen) [03:01:30] 06Fundraising-Backlog, 10FR-WMF-Audit, 07Epic: Paypal audit not resolving -> braintree paypal_ec - https://phabricator.wikimedia.org/T444253#12543006 (10Eileenmcnaughton) Also repaired 153242476 Before backend_processor_trxn_id 28D713774M4381708 auth_id capture_id After auth_id & bp_txn_id 28D713774M438... [03:05:52] (03PS5) 10Ejegg: Remove Braintree post-payment recurring convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368385 [03:06:41] (03PS1) 10Eileen: Bubble up backend_processor_id for paypal refunds [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1368432 (https://phabricator.wikimedia.org/T444253) [03:06:57] ok cstone, that gets me the right popup for non-recurring: https://gerrit.wikimedia.org/r/1368385 [03:07:10] (03CR) 10CI reject: [V:04-1] Bubble up backend_processor_id for paypal refunds [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1368432 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [03:07:23] but... is that onApprove function still doing the right thing for auths? [03:07:40] seems to have gotten something through [03:09:04] hmpf, queue consumers not running on new compy yet. haven't see this before: json_decode() getting a Predis\Transaction\MultiExec instead of a string [03:09:21] guess I'll have to solve that one tomorrow [03:09:59] ejegg: want to spot check my config change? [03:10:36] sure, gotta go get my yubikey [03:11:21] (03PS2) 10Eileen: Bubble up backend_processor_id for paypal refunds [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1368432 (https://phabricator.wikimedia.org/T444253) [03:21:18] (03PS4) 10Lars SG: Change paused recurring definition to 32/367 days until next scheduled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368410 (https://phabricator.wikimedia.org/T444407) [03:21:41] (03CR) 10Ejegg: [C:03+2] "Nice simplification!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368410 (https://phabricator.wikimedia.org/T444407) (owner: 10Lars SG) [03:23:18] 06Fundraising-Backlog, 10FR-WMF-Audit, 07Epic, 13Patch-For-Review: Paypal audit not resolving -> braintree paypal_ec - https://phabricator.wikimedia.org/T444253#12543014 (10Eileenmcnaughton) OK 2 things needed 1) we need to save auth_id, capture_id & backend procesor id correctly (unlike now) 2) refunds n... [03:23:33] (03CR) 10Ejegg: "Can we set backend_processor_txn_id too in that same clause?" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1368432 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [03:24:16] eileen: would that map to backend_processor_reversal_id in the queue consumer? ^^ [03:25:02] wait is that not a thing? not finding that precise field name in code [03:25:22] ejegg: so in ^^ we are processing a reversal & we receive the original capture_id but not the original auth_id - which is what I *think* we should be storing in the backend_processor_txn_id [03:26:35] eileen: ok, right, and it's sending a message to the refund queue [03:27:12] so ejegg first question - for braintree+paypal do we think the correct value to go in backend_processor_txn_id is auth_id or capture_id? [03:27:26] - for adyen we def use auth_id [03:27:55] second question - can we get the auth_id & capture_id & store them on the contribution? [03:28:46] eileen: Did we choose which ID to send as the backend txn id based on matching something in gravy? [03:29:10] eileen: we can get them, and I think we map them at the smashpig level [03:29:31] but they just don't get into the queue message up in donationInterface [03:29:57] I think we just didn't have anything sending those two from the front end [03:30:04] but we definitely can add it [03:30:06] (03Merged) 10jenkins-bot: Change paused recurring definition to 32/367 days until next scheduled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368410 (https://phabricator.wikimedia.org/T444407) (owner: 10Lars SG) [03:30:41] (03CR) 10Cstone: [C:03+2] "time math is hard" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368412 (https://phabricator.wikimedia.org/T444407) (owner: 10Lars SG) [03:31:14] yeah - looks like we have been preferring auth_id [03:31:14] \CRM_Core_DAO::executeQuery( [03:31:14] 'UPDATE wmf_contribution_extra [03:31:14] SET backend_processor_txn_id = %1, [03:31:15] auth_id = %1, [03:31:15] capture_id = %2 [03:31:16] WHERE backend_processor_txn_id = %2 AND backend_processor = %3 [03:31:16] ', [ [03:31:17] 1 => [$message->getAuthID(), 'String'], [03:31:17] 2 => [$message->getCaptureID(), 'String'], [03:31:18] 3 => [$message->getBackendProcessor(), 'String'], [03:31:18] ]); [03:31:29] - from our repair [03:32:08] (03Merged) 10jenkins-bot: Change paused recurring definition to 32/367 days until next scheduled [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368412 (https://phabricator.wikimedia.org/T444407) (owner: 10Lars SG) [03:32:46] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1368433 [03:33:04] if a refund queue message has backend_processor_txn_id, and backend_processor_parent_id, we look up the original by the parent_id. Then we set the status but we can also set the backend_processor_reversal_id, right? To link the refund txn? [03:33:21] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1368433 (owner: 10Lars SG) [03:34:04] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1368433 (owner: 10Lars SG) [03:36:23] (03PS1) 10Eileen: Also look up capture_id as a possible match for the backend_processor_parent_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) [03:39:33] ejegg: yeah I guess we have been migrating more & more to more specific rather than jamming multiple things in one field. backend_processor_txn_id is ambiguous for a refund whereas the backend_processor_parent_id is the parents backend_processor_txn_id (or capture_id it seems) and the backend_processor_reversal_id is the transaction ID of the refund/chargeback/reversal [03:40:49] (03PS2) 10Eileen: Also look up capture_id as a possible match for the backend_processor_parent_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) [03:41:36] !log civicrm upgraded from 3360fb3f to 4dce4590 [03:41:38] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:44:13] (03PS3) 10Eileen: Also look up capture_id as a possible match for the backend_processor_parent_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) [03:45:36] (03CR) 10Eileen: "So that is a bit ambiguous for a refund - Trying to use the fields that clearly refer to either the reversal or the parent - but I don't k" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1368432 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [03:49:01] ejegg: I think https://gerrit.wikimedia.org/r/1368434 will work as long as we ALSO have [03:49:01] 1) the smash-pig patch [03:49:01] 2) capture_id correctly populated - I've done that for the current uncleared one but the donations only cleared because I updated the contributions with auth_id & capture_id [03:52:15] (03CR) 10CI reject: [V:04-1] Also look up capture_id as a possible match for the backend_processor_parent_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [03:53:00] (03PS4) 10Eileen: Also look up capture_id as a possible match for the backend_processor_parent_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) [04:00:14] (03CR) 10CI reject: [V:04-1] Also look up capture_id as a possible match for the backend_processor_parent_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [04:02:44] ok I think ^^ fail will go away if we merge the smashpig one - passes locally [04:08:51] (03PS1) 10Ejegg: Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 [04:08:59] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Backfill missing payment_instrument_id for recurrings - https://phabricator.wikimedia.org/T444431 (10Lars) 03NEW [04:09:01] 06Fundraising-Backlog, 10FR-Adyen: Adyen having issues with lowercase currency - https://phabricator.wikimedia.org/T444432 (10Cstone) 03NEW [04:10:18] (03CR) 10CI reject: [V:04-1] Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 (owner: 10Ejegg) [04:13:37] eileen: i have to get the trash out then i can look [04:50:23] (03PS1) 10Pwangai: Run the WMFEnvironmentTrait cleanup in tests that override tearDown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368548 (https://phabricator.wikimedia.org/T434024) [05:06:37] (03PS1) 10Eileen: Import Credit Card rows from the Engage Summary report [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368550 (https://phabricator.wikimedia.org/T434041) [05:07:22] 06Fundraising-Backlog, 10FR-Adyen: Adyen having issues with lowercase currency - https://phabricator.wikimedia.org/T444432#12543091 (10Cstone) [05:20:25] (03CR) 10Cstone: [C:03+2] Bubble up backend_processor_id for paypal refunds [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1368432 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [05:20:55] (03Merged) 10jenkins-bot: Bubble up backend_processor_id for paypal refunds [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1368432 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [05:28:43] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.7.4 => v1.2.7.7) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368551 [05:28:54] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.7.4 => v1.2.7.7) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368551 (owner: 10Eileen) [05:31:41] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.7.4 => v1.2.7.7) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1368552 [05:33:03] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.7.4 => v1.2.7.7) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1368552 (owner: 10Eileen) [05:35:53] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.7.4 => v1.2.7.7) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368551 (owner: 10Eileen) [05:38:47] (03PS5) 10Eileen: Also look up capture_id as a possible match for the backend_processor_parent_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) [05:39:01] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [05:43:05] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.7.4 => v1.2.7.7) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1368552 (owner: 10Eileen) [05:51:35] (03CR) 10Cstone: [C:03+2] Also look up capture_id as a possible match for the backend_processor_parent_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [05:59:55] (03Merged) 10jenkins-bot: Also look up capture_id as a possible match for the backend_processor_parent_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368434 (https://phabricator.wikimedia.org/T444253) (owner: 10Eileen) [06:02:01] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1368554 [06:02:14] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1368554 (owner: 10Eileen) [06:03:00] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1368554 (owner: 10Eileen) [06:07:48] !log civicrm upgraded from 4dce4590 to d2ad5629 [06:07:50] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [06:11:56] FIRING: NodeDown: Node fransw1001 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=fransw1001 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [06:15:22] FIRING: FrTechFailMail: CiviCRM failmail activity exceeded 4 msg/min for the past 5 minutes. - https://alerts.wikimedia.org/?q=alertname%3DFrTechFailMail [06:15:56] !log rollback civi upgrade [06:15:57] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [06:16:15] !log civicrm rolled back from d2ad5629 to 4dce4590 (locked) [06:16:17] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [06:16:56] RESOLVED: NodeDown: Node fransw1001 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=fransw1001 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [06:20:22] RESOLVED: FrTechFailMail: CiviCRM failmail activity exceeded 8 msg/min for the past 5 minutes. - https://alerts.wikimedia.org/?q=alertname%3DFrTechFailMail [06:23:36] (03PS1) 10Eileen: Pin predis to 3.6.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368555 [06:26:14] (03PS1) 10Eileen: Downgrade predis after upgrade caused a type hint error [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1368556 [06:32:42] (03CR) 10Cstone: [C:03+2] Pin predis to 3.6.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368555 (owner: 10Eileen) [06:40:38] (03CR) 10Cstone: [C:03+2] "thanks! looks good" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368385 (owner: 10Ejegg) [06:40:45] (03PS2) 10Ejegg: Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 [06:41:42] (03Merged) 10jenkins-bot: Pin predis to 3.6.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368555 (owner: 10Eileen) [06:41:54] (03CR) 10CI reject: [V:04-1] Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 (owner: 10Ejegg) [06:42:08] (03Merged) 10jenkins-bot: Remove Braintree post-payment recurring convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368385 (owner: 10Ejegg) [06:42:31] (03PS3) 10Ejegg: Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 [06:43:43] (03CR) 10CI reject: [V:04-1] Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 (owner: 10Ejegg) [06:43:50] (03CR) 10Eileen: [C:03+2] Downgrade predis after upgrade caused a type hint error [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1368556 (owner: 10Eileen) [06:44:47] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1368560 [06:45:20] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1368560 (owner: 10Eileen) [06:46:02] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1368560 (owner: 10Eileen) [06:48:19] !log civicrm upgraded from 4dce4590 to d675b9d7 [06:48:21] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [12:03:38] (03PS15) 10Ejegg: Expose function to get donation date [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360544 (https://phabricator.wikimedia.org/T441349) [12:09:00] (03PS2) 10Jdlrobson: Documentation: Document public APIs for CentralNotice [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360958 [12:09:26] (03PS3) 10Jdlrobson: Documentation: Document public APIs for CentralNotice [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360958 [14:42:34] (03PS3) 10Damilare Adedoyin: Add form validation for amount and opt in before select payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368369 (https://phabricator.wikimedia.org/T443702) (owner: 10Wfan) [15:02:03] (03CR) 10Damilare Adedoyin: "Thanks for all the work on this @wfan@wikimedia.org. Looks good to me, but I wonder if we can reuse the useFieldValidation composable for " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368369 (https://phabricator.wikimedia.org/T443702) (owner: 10Wfan) [15:02:08] (03CR) 10Damilare Adedoyin: [C:03+2] Add form validation for amount and opt in before select payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368369 (https://phabricator.wikimedia.org/T443702) (owner: 10Wfan) [15:03:59] (03Merged) 10jenkins-bot: Add form validation for amount and opt in before select payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368369 (https://phabricator.wikimedia.org/T443702) (owner: 10Wfan) [15:22:01] (03PS4) 10Laurabarluzzi: Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 (owner: 10Ejegg) [15:23:07] (03CR) 10CI reject: [V:04-1] Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 (owner: 10Ejegg) [15:29:37] (03CR) 10Lars SG: [C:03+2] "Thanks! I'm going to merge this and then do a follow up to use @before and @after for the trait methods to make this less brittle." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368548 (https://phabricator.wikimedia.org/T434024) (owner: 10Pwangai) [15:39:30] (03PS5) 10Laurabarluzzi: Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 (owner: 10Ejegg) [15:39:31] (03Merged) 10jenkins-bot: Run the WMFEnvironmentTrait cleanup in tests that override tearDown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368548 (https://phabricator.wikimedia.org/T434024) (owner: 10Pwangai) [15:40:44] (03PS1) 10Lars SG: Use @before & @after for setUp/tearDownWMFEnvironment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368702 (https://phabricator.wikimedia.org/T434024) [15:40:58] (03PS2) 10Lars SG: Use @before & @after for setUp/tearDownWMFEnvironment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368702 (https://phabricator.wikimedia.org/T434024) [15:41:00] (03CR) 10CI reject: [V:04-1] Use @before & @after for setUp/tearDownWMFEnvironment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368702 (https://phabricator.wikimedia.org/T434024) (owner: 10Lars SG) [15:48:13] (03CR) 10Laurabarluzzi: [C:03+2] Show error code if exist than just general error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1367951 (https://phabricator.wikimedia.org/T443546) (owner: 10Wfan) [15:49:55] (03Merged) 10jenkins-bot: Show error code if exist than just general error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1367951 (https://phabricator.wikimedia.org/T443546) (owner: 10Wfan) [16:09:08] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki Testing: US (USD) and UK (USD) - https://phabricator.wikimedia.org/T444267#12545708 (10Laurabarluzzi) [16:09:41] (03PS2) 10Laurabarluzzi: ComboWiki testing: remove UK (USD) and AN (USD) from the country dropdown's options [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368253 (https://phabricator.wikimedia.org/T444267) [16:26:26] (03PS1) 10Laurabarluzzi: ComboWiki Testing: use US country specific postal code label [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368710 (https://phabricator.wikimedia.org/T444350) [16:27:11] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: US address form says "Postal code" instead of "Zip" - https://phabricator.wikimedia.org/T444350#12545762 (10Laurabarluzzi) p:05Triage→03Low a:03Laurabarluzzi [16:30:11] (03CR) 10Cstone: [C:03+2] "thanks this worked!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 (owner: 10Ejegg) [16:31:49] (03Merged) 10jenkins-bot: Uppercase country & currency in GatewayChooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368435 (owner: 10Ejegg) [16:35:54] (03PS1) 10Ejegg: Fix race condition on domready [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1368712 (https://phabricator.wikimedia.org/T443965) [16:36:46] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1368713 [16:37:51] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review: Occasional failures when previewing centralnotice banners - https://phabricator.wikimedia.org/T443965#12545830 (10Ejegg) Looks like I introduced a race condition in I43d5632d44021f47034176f26994e273ad7b630a , but hopefully only... [16:39:11] 06Fundraising-Backlog, 07fr-combowiki: Add smsoptin variant to Adyen - https://phabricator.wikimedia.org/T444268#12545834 (10Laurabarluzzi) a:03Laurabarluzzi [16:39:57] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review: Occasional failures when previewing centralnotice banners - https://phabricator.wikimedia.org/T443965#12545835 (10Ejegg) Sorry, if it was affecting Pcoombe's incognito view I guess that wasn't a posted preview as those only work... [16:56:00] (03PS1) 10Laurabarluzzi: ComboWiki: support smsOptin variant in Adyen as well [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368716 (https://phabricator.wikimedia.org/T444268) [16:56:40] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Add smsoptin variant to Adyen - https://phabricator.wikimedia.org/T444268#12545898 (10Laurabarluzzi) [16:58:22] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1368713 (owner: 10Cstone) [17:01:32] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1368713 (owner: 10Cstone) [17:09:09] !log payments-wiki upgraded from b8b21682 to 74d35d14 [17:09:10] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [17:16:40] (03PS3) 10Laurabarluzzi: ComboWiki testing: remove UK (USD) and AN (USD) from the country dropdown's options [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368253 (https://phabricator.wikimedia.org/T444267) [17:16:44] (03CR) 10Ejegg: [C:03+2] ComboWiki testing: remove UK (USD) and AN (USD) from the country dropdown's options [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368253 (https://phabricator.wikimedia.org/T444267) (owner: 10Laurabarluzzi) [17:17:59] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Some links to translations in new msg templates are wrong - https://phabricator.wikimedia.org/T444331#12545977 (10Lars) I've deleted the offending fake language translation rows (and some others for other fake languages... [17:18:24] (03Merged) 10jenkins-bot: ComboWiki testing: remove UK (USD) and AN (USD) from the country dropdown's options [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368253 (https://phabricator.wikimedia.org/T444267) (owner: 10Laurabarluzzi) [17:19:36] (03PS2) 10Laurabarluzzi: ComboWiki Testing: use US country specific postal code label [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368710 (https://phabricator.wikimedia.org/T444350) [17:20:41] (03CR) 10Ejegg: [C:03+2] "This looks like a good solution for now. Long term, we should probably implement our own i18n wrapper function which generically checks fo" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368710 (https://phabricator.wikimedia.org/T444350) (owner: 10Laurabarluzzi) [17:22:14] (03Merged) 10jenkins-bot: ComboWiki Testing: use US country specific postal code label [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368710 (https://phabricator.wikimedia.org/T444350) (owner: 10Laurabarluzzi) [17:27:47] Thanks for all the review on that CentralNotice patch laura|dinner ! [17:28:44] If you have time after dinner, would you mind looking at this much smaller CentralNotice bug fix? https://gerrit.wikimedia.org/r/1368712 [17:31:47] (03PS1) 10Thiemo Kreuz (WMDE): Don't query from cn_templates where tmp_category is null [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1368725 (https://phabricator.wikimedia.org/T444281) [17:32:19] (03CR) 10Ejegg: [C:03+2] "TODO: remove the message_replacements.yaml when old forms go away. They're not supported under combowiki yet, but combowiki adds its own '" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368716 (https://phabricator.wikimedia.org/T444268) (owner: 10Laurabarluzzi) [17:33:51] (03Merged) 10jenkins-bot: ComboWiki: support smsOptin variant in Adyen as well [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368716 (https://phabricator.wikimedia.org/T444268) (owner: 10Laurabarluzzi) [17:46:55] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog: Adyen Plaid Investigation - https://phabricator.wikimedia.org/T443515#12546043 (10Ejegg) [17:48:05] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog: Adyen Plaid Investigation - https://phabricator.wikimedia.org/T443515#12546046 (10Ejegg) [17:55:11] (03PS1) 10Lars SG: Change tests to use Acoustic endpoint instead of old IBM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368730 (https://phabricator.wikimedia.org/T434024) [17:55:24] (03PS2) 10Lars SG: Change tests to use Acoustic endpoint instead of old IBM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368730 (https://phabricator.wikimedia.org/T434024) [18:04:01] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review: Occasional failures when previewing centralnotice banners - https://phabricator.wikimedia.org/T443965#12546096 (10Pcoombe) Is a "posted preview" using the Live preview feature from the CentralNotice interface? I haven't been usi... [18:16:54] (03PS1) 10Ejegg: WIP Adyen / plaid [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368731 (https://phabricator.wikimedia.org/T443515) [19:15:49] (03PS1) 10Ejegg: Submit browserInfo for all adyen methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368737 [19:17:20] (03CR) 10CI reject: [V:04-1] Submit browserInfo for all adyen methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368737 (owner: 10Ejegg) [19:18:06] (03Abandoned) 10Ejegg: Submit browserInfo for all adyen methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368737 (owner: 10Ejegg) [19:32:17] ejegg: I'm looking into that central notice patch right now with the raise condition [19:40:02] *race 🤣 [19:50:12] (03PS1) 10Ejegg: WIP Switch Adyen/ACH to Plaid [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1368742 (https://phabricator.wikimedia.org/T443515) [19:50:40] (03CR) 10CI reject: [V:04-1] WIP Switch Adyen/ACH to Plaid [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1368742 (https://phabricator.wikimedia.org/T443515) (owner: 10Ejegg) [19:50:43] (03PS2) 10Ejegg: WIP Adyen / plaid [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368731 (https://phabricator.wikimedia.org/T443515) [19:51:16] thanks laurabar [19:51:29] it's hard to repro [19:51:40] that is, i haven't been able to [19:51:57] but the machine analysis suggested that was the likely cause [19:51:59] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1368712 (https://phabricator.wikimedia.org/T443965) (owner: 10Ejegg) [19:52:04] thank you ! [19:52:23] I'll push that straight to the deploy branch [19:53:12] I focused only on the code and how these events are registered. It was a very isolated code change [19:53:50] (03CR) 10CI reject: [V:04-1] Fix race condition on domready [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1368712 (https://phabricator.wikimedia.org/T443965) (owner: 10Ejegg) [19:53:58] huh [19:54:18] mkdir(): No space left on device [19:54:19] 19:53:37 (Phan 6.0.2 crashed when parsing/analyzing '../../vendor/ruflin/elastica/src/Query/Match.php') [19:54:22] booo [19:54:47] (03CR) 10Ejegg: [V:03+2] Fix race condition on domready [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1368712 (https://phabricator.wikimedia.org/T443965) (owner: 10Ejegg) [19:55:23] (03PS1) 10Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1368743 [19:55:25] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1368743 (owner: 10Ejegg) [19:56:18] yeah laurabar I think we should probably just create that div when we're inserting the banner but I'm not sure about that legacy code comment [19:56:37] going to spend a bit of time with the kiddo [19:56:49] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1368743 (owner: 10Ejegg) [19:56:55] ^-- we could do it only if it doesn't already exist (that should be safe) [20:02:49] ejegg|away: that no space left on device error could be related to docker's resource allocation [20:07:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Some Searchkit contact queries with joins are very slow in 6.20 because of added subqueries for ACLs - https://phabricator.wikimedia.org/T444252#12546401 (10Lars) p:05Triage→03Medium [20:11:05] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Paypal is missing in NZ - https://phabricator.wikimedia.org/T444270#12546407 (10Laurabarluzzi) this is not the case locally, so it must be a diff between local and live testing (e.g. sandbox vs prod accounts?) [20:23:21] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Paypal is missing in NZ - https://phabricator.wikimedia.org/T444270#12546433 (10Laurabarluzzi) [20:23:51] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Paypal is missing in NZ - https://phabricator.wikimedia.org/T444270#12546434 (10Laurabarluzzi) a:03Laurabarluzzi [20:48:46] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Don't gray payment buttons out to start - https://phabricator.wikimedia.org/T444260#12546461 (10Laurabarluzzi) @Cstone I'm jailed in production, but I am pretty sure all these points have been addressed by the linked phab and its patch https://phabricat... [20:52:13] (03CR) 10Eileen: [C:03+2] Change tests to use Acoustic endpoint instead of old IBM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368730 (https://phabricator.wikimedia.org/T434024) (owner: 10Lars SG) [20:56:47] (03CR) 10Eileen: [C:03+2] "huh - I didn't know about that - looks like it would be good to up our phpunit version so we can use the more forward looking attributes -" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368702 (https://phabricator.wikimedia.org/T434024) (owner: 10Lars SG) [21:07:13] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki, 05MW-1.48-notes (1.48.0-wmf.5; 2026-11-17): Combowiki Testing: US (USD) and UK (USD) - https://phabricator.wikimedia.org/T444267#12546491 (10Laurabarluzzi) @Cstone @Ejegg I'm proposing a 4th option as backup: JavaScript bui... [21:12:07] (03Merged) 10jenkins-bot: Use @before & @after for setUp/tearDownWMFEnvironment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368702 (https://phabricator.wikimedia.org/T434024) (owner: 10Lars SG) [21:12:10] (03Merged) 10jenkins-bot: Change tests to use Acoustic endpoint instead of old IBM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368730 (https://phabricator.wikimedia.org/T434024) (owner: 10Lars SG) [21:37:26] (03PS1) 10Damilare Adedoyin: Create codex fieldset for amount and optin, then use useFieldValidation for payment form validation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368761 (https://phabricator.wikimedia.org/T443702) [21:38:38] took longer than I had initially anticipated, but that patch should be ready for review ^ [21:38:49] (03PS2) 10Damilare Adedoyin: Create codex fieldset for amount and optin, then use useFieldValidation for payment form validation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368761 (https://phabricator.wikimedia.org/T443702) [22:17:04] (03PS6) 10Pwangai: Add a CI script to run the test suite in parallel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) [22:17:04] (03CR) 10Pwangai: "Thanks, I am currently running the tests again, I will confirm once done." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360558 (https://phabricator.wikimedia.org/T442953) (owner: 10Pwangai) [22:20:11] (03PS1) 10Eileen: Do not sent batch mismatch alert if not all rows parsed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368773