[00:23:41] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: New CSP warning when previewing fundraising banners - https://phabricator.wikimedia.org/T444656#12552899 (10Pcoombe) https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1366869 looks like the cause. @Ejegg can you see why centralnotice ban... [01:18:22] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Coworker claims all items in a parallel queue immediately - https://phabricator.wikimedia.org/T444736 (10Lars) 03NEW [01:18:32] dwisehaupt: eileen: ^^^ [01:32:25] (03PS9) 10Lars SG: Queue the donor history backfill on 3 regular queues [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367944 (https://phabricator.wikimedia.org/T431586) [01:38:05] (03CR) 10Eileen: [C:03+2] "what your server doesn't die from makes you stronger" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367944 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [01:43:07] (03Merged) 10jenkins-bot: Queue the donor history backfill on 3 regular queues [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367944 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [01:49:39] larssandergreen: cool. you all should have the ability to upgrade coworker as it's a project covered by frdeploy. if we need changes to the startup options then that's covered in puppet for the systemd unit. [01:50:30] larssandergreen: is that what made the failmails? [01:51:05] dwisehaupt: Does that mean we'd need a repo? [01:51:22] cstone: no, those few were recurrings with 0 start dates [01:51:49] are they just one off ones ? [01:52:08] just to respond something so chaos peeps dont look into them overnight [01:52:29] I'll respond [01:53:12] thanks larssandergreen ! [01:53:15] larssandergreen: the repo is already there. any changes pulled into https://gerrit.wikimedia.org/r/wikimedia/fundraising/coworker.git would get deployed. [01:54:33] and if there are any changes needed for cv, that can be done in https://gerrit.wikimedia.org/r/wikimedia/fundraising/cv.git (just mentioning since i know we use the two together) [01:54:56] oh perfect, I guess we should add those to our dev so they are more findable [02:03:02] dwisehaupt: are these the ones where we need to do one big commit, i.e. we can't pull in the history? [02:06:50] Oh, I get it now [02:06:57] All good [02:08:22] !log coworker upgraded from c0f5f999 to 1fafaa04 [02:08:23] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:15:01] (03PS1) 10Lars SG: Fix recurrings with 0 start date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369161 (https://phabricator.wikimedia.org/T431586) [02:15:24] FIRING: SystemdService: Systemd service coworker.service stopped on civi1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService [02:21:48] larssandergreen: ^ were they paypals with 0? [02:22:23] well, I guess we weren't ready for the latest coworker as it died [02:22:26] !log coworker rolled back from 1fafaa04 to c0f5f999 [02:22:28] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:25:24] RESOLVED: SystemdService: Systemd service coworker.service stopped on civi1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService [02:25:53] cstone: yeah, paypal, but just 33 of them [02:26:09] coworker was too powerful [02:33:17] !log coworker upgraded from c0f5f999 to f3775c85 [02:33:19] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:33:29] sure, let's blame coworker and not me [02:34:45] cstone: could you take a quick look at that recurrings fix? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1369161 [02:34:54] yep [02:40:44] our oldest donors [02:42:24] (03CR) 10Cstone: [C:03+2] Fix recurrings with 0 start date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369161 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [02:43:58] (03CR) 10Dmiranda: [C:03+2] Fix recurrings with 0 start date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369161 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [02:45:07] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Move the tax deductability link to the links block - https://phabricator.wikimedia.org/T444259#12553430 (10Cstone) [02:45:53] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Don't gray payment buttons out to start - https://phabricator.wikimedia.org/T444260#12553432 (10Cstone) →14Duplicate dup:03T443702 [02:45:54] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki, 05MW-1.48-notes (1.48.0-wmf.5; 2026-11-17), 13Patch-For-Review: Combowiki Testing: refactor all payment page validation - https://phabricator.wikimedia.org/T443702#12553434 (10Cstone) [02:46:42] thanks cstone [02:47:45] (03Merged) 10jenkins-bot: Fix recurrings with 0 start date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369161 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [02:49:27] (03CR) 10Dmiranda: [C:03+2] "Thanks @cstone@wikimedia.org, LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1369151 (owner: 10Cstone) [02:49:45] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1369166 [02:49:56] (03Merged) 10jenkins-bot: Don't log the payment token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1369151 (owner: 10Cstone) [02:50:13] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1369166 (owner: 10Lars SG) [02:50:28] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Don't gray payment buttons out to start - https://phabricator.wikimedia.org/T444260#12553437 (10Cstone) yep you are right @Laurabarluzzi ! closing this one now [02:51:03] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1369166 (owner: 10Lars SG) [02:52:12] !log civicrm upgraded from cdc8412f to 760e3b84 [02:52:13] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:52:36] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Braintree Paypal tokenization and monthly convert - always asks to set up a billing agreement - https://phabricator.wikimedia.org/T444269#12553438 (10Cstone) [02:56:43] (03CR) 10Dmiranda: [C:03+2] "Thanks @emcnaughton@wikimedia.org!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368976 (owner: 10Eileen) [03:01:37] (03Merged) 10jenkins-bot: Do not regenerate batch files once a batch has been pushed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368976 (owner: 10Eileen) [03:02:10] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: ComboWiki: UI bug (low priority) - https://phabricator.wikimedia.org/T443817#12553441 (10dmiranda) 05Open→03In progress a:03dmiranda [03:02:39] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki, 13Patch-For-Review: Consider preserving form selection if country change triggers reload - https://phabricator.wikimedia.org/T440877#12553444 (10dmiranda) [03:13:17] (03PS1) 10Lars SG: Let's try the parallel queue again [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369167 (https://phabricator.wikimedia.org/T431586) [03:14:52] (03CR) 10Dmiranda: [C:03+1] "Hi @emcnaughton@wikimedia.org this looks good to me, but I wanted to call out that at the moment it appears to be showing as the second it" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368970 (owner: 10Eileen) [03:15:25] (03CR) 10Dmiranda: [C:03+2] Fix duplication of a json & a php file for the same Form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368969 (owner: 10Eileen) [03:16:00] (03CR) 10Cstone: [C:03+2] Let's try the parallel queue again [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369167 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [03:20:15] (03Merged) 10jenkins-bot: Fix duplication of a json & a php file for the same Form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368969 (owner: 10Eileen) [03:20:47] (03CR) 10Dmiranda: [C:03+2] Leave older offline batches out of the fr-tech emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368894 (owner: 10Eileen) [03:21:51] (03Merged) 10jenkins-bot: Let's try the parallel queue again [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369167 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [03:25:11] (03Merged) 10jenkins-bot: Leave older offline batches out of the fr-tech emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368894 (owner: 10Eileen) [03:34:57] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1369168 [03:35:06] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1369168 (owner: 10Lars SG) [03:35:52] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1369168 (owner: 10Lars SG) [03:36:44] !log civicrm upgraded from 760e3b84 to bdd155c9 [03:36:46] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [04:10:10] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Pull in signature for MGFE sends based on sender from email - https://phabricator.wikimedia.org/T444649#12553480 (10Lars) @RLewis Can you send me some samples of what these signatures look like? Either some example emails in Civi or just forw... [04:28:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, and 2 others: CI build slow and timing out sometimes - https://phabricator.wikimedia.org/T434024#12553484 (10Lars) From timing out at 30 minutes, we're now running 3-5 minutes.... [04:31:02] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Coworker claims all items in a parallel queue immediately - https://phabricator.wikimedia.org/T444736#12553486 (10Lars) Turns out this was fixed by a coworker upgrade (we were a couple years out of date) and then some wr... [04:33:57] (03PS1) 10Lars SG: Make DB deadlock failure after retries a DBQueryException [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369171 (https://phabricator.wikimedia.org/T443671) [04:43:50] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 4 others: Automate some Direct Mail white mail coding - https://phabricator.wikimedia.org/T386031#12553489 (10Lars) I'm also changing, per discussion with @RLewis, so that when... [04:50:15] (03PS1) 10Lars SG: Also look for MG Engagement activities between the receive_date and now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369263 (https://phabricator.wikimedia.org/T386031) [05:02:12] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Add job to send ad click conversion tracking to ad networks - https://phabricator.wikimedia.org/T444743 (10Lars) 03NEW [05:39:59] (03PS9) 10Cstone: WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [05:41:19] (03CR) 10CI reject: [V:04-1] WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 (owner: 10Cstone) [05:42:37] (03PS10) 10Cstone: WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [05:44:05] (03CR) 10CI reject: [V:04-1] WIP: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 (owner: 10Cstone) [06:06:37] (03PS11) 10Cstone: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [06:07:55] (03CR) 10CI reject: [V:04-1] Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 (owner: 10Cstone) [06:27:16] (03PS12) 10Cstone: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [07:10:25] (03CR) 10Dmiranda: [C:03+2] "Thanks @lsandergreen@wikimedia.org! Was an interesting opportunity to look at hooks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369154 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [07:15:48] (03Merged) 10jenkins-bot: Improve MG Engagement notifications & link contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369154 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [07:23:22] (03PS13) 10Cstone: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [07:58:28] (03PS2) 10Dmiranda: ComboWiki: keep frequency and amount when changing country [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368801 (https://phabricator.wikimedia.org/T440877) [08:09:38] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki, 13Patch-For-Review: Consider preserving form selection if country change triggers reload - https://phabricator.wikimedia.org/T440877#12553658 (10dmiranda) Thanks for taking a look @Laurabarluzzi! I've investigated and can confirm that we keep the... [09:54:25] (03PS1) 10Laurabarluzzi: ComboWiki: Use Intl.DisplayNames to translate country names in the dropdown [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369351 [09:55:47] (03PS2) 10Laurabarluzzi: ComboWiki: Use Intl.DisplayNames to translate country names in the dropdown [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369351 [09:57:29] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Add minimum and maximum donation amounts - https://phabricator.wikimedia.org/T444256#12553915 (10Laurabarluzzi) a:03Laurabarluzzi [11:33:24] (03PS1) 10Laurabarluzzi: Add issuer_decline to the list of Gravy's recurring_ignore_list [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1369403 [11:40:10] (03PS1) 10Laurabarluzzi: Remove adapter dependency to get the values for wgDonationInterfaceAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) [11:41:53] (03CR) 10CI reject: [V:04-1] Remove adapter dependency to get the values for wgDonationInterfaceAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) (owner: 10Laurabarluzzi) [11:44:20] (03PS2) 10Laurabarluzzi: Remove adapter dependency to get the values for wgDonationInterfaceAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) [11:45:45] (03CR) 10CI reject: [V:04-1] Remove adapter dependency to get the values for wgDonationInterfaceAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) (owner: 10Laurabarluzzi) [11:47:27] (03PS3) 10Laurabarluzzi: Remove adapter dependency to get the values for wgDonationInterfaceAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) [11:49:44] (03CR) 10CI reject: [V:04-1] Remove adapter dependency to get the values for wgDonationInterfaceAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) (owner: 10Laurabarluzzi) [11:50:42] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363457 (https://phabricator.wikimedia.org/T441351) (owner: 10Ejegg) [11:52:44] (03Merged) 10jenkins-bot: Stash donation date in localstorage [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363457 (https://phabricator.wikimedia.org/T441351) (owner: 10Ejegg) [11:55:03] (03PS4) 10Laurabarluzzi: Remove adapter dependency to get the values for wgDonationInterfaceAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) [14:14:16] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM! Thanks for picking this up" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368801 (https://phabricator.wikimedia.org/T440877) (owner: 10Dmiranda) [14:15:57] (03Merged) 10jenkins-bot: ComboWiki: keep frequency and amount when changing country [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368801 (https://phabricator.wikimedia.org/T440877) (owner: 10Dmiranda) [14:23:19] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Pull in signature for MGFE sends based on sender from email - https://phabricator.wikimedia.org/T444649#12555490 (10Lars) @RLewis Thanks and are you sending these emails on their behalf or are they actually doing the sending themselves (or so... [14:30:39] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Pull in signature for MGFE sends based on sender from email - https://phabricator.wikimedia.org/T444649#12555501 (10RLewis) I often send them on behalf of the GOs, going from their emails but also they send as well. Rosie Lewis Senior Develo... [14:35:22] (03PS5) 10Laurabarluzzi: Remove adapter dependency to get the values for wgDonationInterfaceAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) [14:36:24] (03CR) 10Ejegg: [C:03+2] "Another step towards cleanup! A couple potential followup suggestions." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) (owner: 10Laurabarluzzi) [14:37:33] (03PS1) 10Lars SG: Queue up a weekend's worth of donor history rebuild [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369445 (https://phabricator.wikimedia.org/T431586) [14:39:25] (03Merged) 10jenkins-bot: Remove adapter dependency to get the values for wgDonationInterfaceAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) (owner: 10Laurabarluzzi) [14:54:43] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Pull in signature for MGFE sends based on sender from email - https://phabricator.wikimedia.org/T444649#12555599 (10Lars) One more question: I see in the Site From Email Addresses that we have entries that have someone's name, but a generic e... [14:56:34] (03CR) 10Lars SG: [C:03+2] Commit the Finance journals search & form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368970 (owner: 10Eileen) [15:01:27] (03Merged) 10jenkins-bot: Commit the Finance journals search & form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368970 (owner: 10Eileen) [15:17:28] (03PS2) 10Lars SG: Queue up the remainder of the donor history rebuild [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369445 (https://phabricator.wikimedia.org/T431586) [15:20:07] (03PS1) 10Lars SG: Backfill missing payment_instrument_ids for older recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369462 (https://phabricator.wikimedia.org/T444431) [15:21:27] (03PS3) 10Lars SG: Queue up the remainder of the donor history rebuild [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369445 (https://phabricator.wikimedia.org/T431586) [15:23:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Coworker claims all items in a parallel queue immediately - https://phabricator.wikimedia.org/T444736#12555751 (10Lars) a:03Lars [15:29:32] (03CR) 10Damilare Adedoyin: [C:03+2] Queue up the remainder of the donor history rebuild [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369445 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [15:34:28] thanks damilare [15:34:55] (03Merged) 10jenkins-bot: Queue up the remainder of the donor history rebuild [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369445 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [15:34:58] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369445 (https://phabricator.wikimedia.org/T431586) (owner: 10Lars SG) [15:36:09] Odd, I just reviewed that patch that 5 min after Dami approval didn't appear as approved to me 🤔 [15:36:30] maybe I actually checked the status flag, and it takes ~5 mins to be merged [15:36:43] I will take a note to look at the actual approval next time :) [15:37:02] thoroughly reviewed [15:38:52] (03PS1) 10Lars SG: Cherry-pick from 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1369467 [15:39:13] (03CR) 10Lars SG: [C:03+2] Cherry-pick from 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1369467 (owner: 10Lars SG) [15:40:08] (03Merged) 10jenkins-bot: Cherry-pick from 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1369467 (owner: 10Lars SG) [15:41:16] !log civicrm upgraded from bdd155c9 to 53d4b223 [15:41:17] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [15:45:52] (03CR) 10Ejegg: "Just checking, no need to try to skip the status recalculation and donor modified_date update?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369462 (https://phabricator.wikimedia.org/T444431) (owner: 10Lars SG) [15:46:50] ejegg: thanks for the review above! could please answer to my clarification question? I'm not sure I grasped your suggested follow-up appraoch in where to move the getSharedConfigurations https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1369406/5/includes/Configuration/GatewayConfigurationFactory.php [15:46:57] ok, i've been neglecting that db contention patch for a while but it looks pretty handy [15:47:35] laurabar: oh, I just thought it would be nice to have all the config path knowledge in the same class [15:47:43] in case we change config paths someplace [15:48:17] I was originally thinking just add a new createForSharedConfiguration static constructor right on ConfigurationReader [15:48:50] but since we have a 'Factory' class for it, maybe that's where all the instantiation and path configuration should actually go [15:49:15] does that make sense [15:49:18] ? [15:49:49] I naturally think configuration should be read by configurationReader [15:50:40] ok, then let's add another static instantiation function that just registers the shared directory [15:51:02] and call that from the GatewayConfigurationFactory [15:51:13] Ok 👌 I just do that then [15:52:06] then at some point we'll want to add variant support for shared configurations [15:53:45] right now we cannot run a variant on donation_rules.yaml? [15:53:56] correct laurabar [15:54:34] there's a comment noting it wouldn't be too hard to add, line 57 of the COnfigurationReader [15:58:39] (03PS1) 10Damilare Adedoyin: Don't show Monthly convert on unsupported adapters (e.g Braintree) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369475 [16:09:47] (03CR) 10Ejegg: [C:03+2] Add issuer_decline to the list of Gravy's recurring_ignore_list [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1369403 (owner: 10Laurabarluzzi) [16:10:24] (03Merged) 10jenkins-bot: Add issuer_decline to the list of Gravy's recurring_ignore_list [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1369403 (owner: 10Laurabarluzzi) [16:12:09] (03PS3) 10Lars SG: Improve DB contention detection & requeues in queue consumers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363468 (https://phabricator.wikimedia.org/T443671) [16:14:07] (03CR) 10Ejegg: "A distinct improvement!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363468 (https://phabricator.wikimedia.org/T443671) (owner: 10Lars SG) [16:24:19] (03PS4) 10Lars SG: Improve DB contention detection & requeues in queue consumers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363468 (https://phabricator.wikimedia.org/T443671) [16:24:52] (03CR) 10Lars SG: Improve DB contention detection & requeues in queue consumers (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363468 (https://phabricator.wikimedia.org/T443671) (owner: 10Lars SG) [17:06:09] (03PS1) 10Wfan: Update the braintree venmo loading [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369490 (https://phabricator.wikimedia.org/T443960) [17:14:49] (03PS3) 10Wfan: Show another amount link in MC fit in Mobile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366904 (https://phabricator.wikimedia.org/T443972) [17:14:51] (03CR) 10Ejegg: "This is a nice load-size optimization and comes up with better values than CLDR! Might be simpler to leave the DisplayNames object locally" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369351 (owner: 10Laurabarluzzi) [17:21:42] (03Abandoned) 10Wfan: add name check from create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1358242 (https://phabricator.wikimedia.org/T441162) (owner: 10Wfan) [17:25:41] (03PS14) 10Cstone: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [17:28:40] (03CR) 10Ejegg: [C:03+2] Improve DB contention detection & requeues in queue consumers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363468 (https://phabricator.wikimedia.org/T443671) (owner: 10Lars SG) [17:33:25] (03Merged) 10jenkins-bot: Improve DB contention detection & requeues in queue consumers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363468 (https://phabricator.wikimedia.org/T443671) (owner: 10Lars SG) [17:40:21] (03PS1) 10Lars SG: Latest 1.9.2. CKEditor 5 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369495 (https://phabricator.wikimedia.org/T442745) [18:16:22] (03PS1) 10Ejegg: Stop alerting for a CSP violation on 'inline' [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1369504 (https://phabricator.wikimedia.org/T444656) [18:17:02] fr-tech ^^^ should fix those alerts for the banner team [18:22:14] hmm, Friday the 13th CentralNotice deploy? What could possibly go wrong :P [18:22:58] itll be fine ejegg [18:24:19] (03CR) 10Wfan: [C:03+2] Stop alerting for a CSP violation on 'inline' [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1369504 (https://phabricator.wikimedia.org/T444656) (owner: 10Ejegg) [18:25:56] (03CR) 10CI reject: [V:04-1] Stop alerting for a CSP violation on 'inline' [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1369504 (https://phabricator.wikimedia.org/T444656) (owner: 10Ejegg) [18:27:42] 18:24:33 docker: Error response from daemon: failed to resolve reference "docker-registry.wikimedia.org/releng/quibble-bookworm-php85:1.22.0-s12": docker-registry.wikimedia.org/releng/quibble-bookworm-php85:1.22.0-s12: not found. [18:27:53] trying to test on a non-existent image? [18:28:13] (03CR) 10Ejegg: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1369504 (https://phabricator.wikimedia.org/T444656) (owner: 10Ejegg) [18:28:17] (03CR) 10Jforrester: [C:03+2] "I've just fixed the CI PHP 8.5 images, let's re-try this." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1369504 (https://phabricator.wikimedia.org/T444656) (owner: 10Ejegg) [18:29:03] heh, nice [18:30:19] (03Merged) 10jenkins-bot: Stop alerting for a CSP violation on 'inline' [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1369504 (https://phabricator.wikimedia.org/T444656) (owner: 10Ejegg) [18:32:14] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Back button with forbidden countries - https://phabricator.wikimedia.org/T444262#12556489 (10AnnWF) a:03AnnWF [18:32:44] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Restore combowiki form field values from session - https://phabricator.wikimedia.org/T440476#12556491 (10Cstone) a:03Cstone [18:32:45] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Move the tax deductability link to the links block - https://phabricator.wikimedia.org/T444259#12556492 (10AnnWF) a:03AnnWF [18:38:30] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07ContentSecurityPolicy: New CSP warning when previewing fundraising banners - https://phabricator.wikimedia.org/T444656#12556498 (10Ejegg) >>! In T444656#12554884, @Pcoombe wrote: > So that warning is triggered by inline event handlers like `oncli... [18:41:05] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: error handling check - https://phabricator.wikimedia.org/T437542#12556508 (10Cstone) a:03Cstone [18:41:51] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07ContentSecurityPolicy: New CSP warning when previewing fundraising banners - https://phabricator.wikimedia.org/T444656#12556509 (10Ejegg) Seems to be coming from ext.gadget.wikiMiniAtlas-script-0.js trying to set 'ondragstart' on something [18:43:01] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: prevent zooming when filling out fields on iPhone - https://phabricator.wikimedia.org/T444389#12556510 (10AnnWF) p:05Triage→03Low [18:52:53] (03PS1) 10Lars SG: Apply relationship manager MGGO appeal for DAF soft credits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369509 (https://phabricator.wikimedia.org/T406662) [18:55:32] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07ContentSecurityPolicy: New CSP warning when previewing fundraising banners - https://phabricator.wikimedia.org/T444656#12556521 (10Pcoombe) Oh, good find, thanks! Yes that makes sense: the NASA article has geocoordinates, but if I test on the "Wi... [18:59:28] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: prevent zooming when filling out fields on iPhone - https://phabricator.wikimedia.org/T444389#12556522 (10Pcoombe) [19:03:28] (03PS1) 10Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1369511 [19:03:30] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1369511 (owner: 10Ejegg) [19:05:28] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1369511 (owner: 10Ejegg) [19:09:21] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07ContentSecurityPolicy, 05MW-1.48-notes (1.48.0-wmf.5; 2026-11-17): New CSP warning when previewing fundraising banners - https://phabricator.wikimedia.org/T444656#12556532 (10Ejegg) Per @pcoombe in IRC the latin-wiki workaround is good enough t... [20:01:12] (03PS2) 10Damilare Adedoyin: Don't show Monthly convert on unsupported adapters (e.g Braintree) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369475 (https://phabricator.wikimedia.org/T444269) [20:05:53] (03PS1) 10Damilare Adedoyin: Ensure session is properly cleared after monthly convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369516 [20:07:09] (03PS1) 10Laurabarluzzi: Move shared config directory setup into ConfigurationReader [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369517 (https://phabricator.wikimedia.org/T443802) [20:07:15] 06Fundraising-Backlog, 07FR-Tech Payment Method Redundancy: dLocal Direct Connections - payment method enablement and testing - https://phabricator.wikimedia.org/T444646#12556683 (10XenoRyet) [20:07:39] 10Fundraising Sprint: Unfolded laundry pile, 07fr-combowiki: Combowiki Testing: Back button with forbidden countries - https://phabricator.wikimedia.org/T444262#12556684 (10AnnWF) [20:07:40] (03CR) 10Eileen: [C:03+2] Also look for MG Engagement activities between the receive_date and now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369263 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [20:07:55] (03CR) 10CI reject: [V:04-1] Also look for MG Engagement activities between the receive_date and now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369263 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [20:19:30] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Restore combowiki form field values from session - https://phabricator.wikimedia.org/T440476#12556710 (10Laurabarluzzi) @Cstone I passively noticed that we're getting different "states" of this page loading: we need to read or a... [20:20:41] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Restore combowiki form field values from session - https://phabricator.wikimedia.org/T440476#12556712 (10Cstone) @Laurabarluzzi I claimed this to check what was still an issue with the sessions as I know we've done a lot of work... [20:21:50] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Restore combowiki form field values from session - https://phabricator.wikimedia.org/T440476#12556722 (10Laurabarluzzi) I thought this was about preserving the form field values if, for instance, I start a card payments but some... [20:22:59] (03PS2) 10Lars SG: Also look for MG Engagement activities between the receive_date and now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369263 (https://phabricator.wikimedia.org/T386031) [20:23:18] (03CR) 10Lars SG: [C:03+2] "replacing +2 after rebase" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369263 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [20:28:08] (03Merged) 10jenkins-bot: Also look for MG Engagement activities between the receive_date and now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369263 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [20:33:04] (03PS3) 10Ejegg: WIP brantree / paypal rediects. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 [20:34:33] (03CR) 10CI reject: [V:04-1] WIP brantree / paypal rediects. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (owner: 10Ejegg) [20:34:57] ejegg: if you get time today i added on to the log client error patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1360018 [20:37:46] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Restore combowiki form field values from session - https://phabricator.wikimedia.org/T440476#12556749 (10Laurabarluzzi) Anyway I think my comment still stands; I think this is already done within the scenarios of "country reload... [20:46:49] (03CR) 10Laurabarluzzi: Remove adapter dependency to get the values for wgDonationInterfaceAmountRules (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369406 (https://phabricator.wikimedia.org/T443802) (owner: 10Laurabarluzzi) [20:56:41] 06Fundraising-Backlog, 10FR-Donation-Processing: Exploring direct connection CC + ACH one-time/recurring through Direct Mail - https://phabricator.wikimedia.org/T444838 (10MDemosWMF) 03NEW [21:16:56] cstone are you seeing the error logged twice? [21:17:08] It looks like there's something triggering emitError twice maybe [21:25:27] hmm i wasn t but it was late when i was testing [21:25:31] lemme try again [21:26:02] I'm seeing a breakpoint in onError hit twice when loading the paypal form on :9001 [21:27:09] yep i see it now ejegg [21:27:10] thanks! [21:28:21] (03PS3) 10Eileen: do not validate adjustment branches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368979 [21:28:30] looks like maybe it's the braintree component actually throwing onError twice? I'll paste the stack traces someplace [21:29:07] yeah i was using some console test errors and only saw those once [21:29:28] setTimeout( () => { throw new Error( 'test global' ); } ) [21:29:39] like that pasted into the console [21:30:22] https://phabricator.wikimedia.org/P97435 [21:32:36] (03PS2) 10Eileen: Add BatchAccount entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367934 (https://phabricator.wikimedia.org/T442668) [21:32:36] (03PS2) 10Eileen: Populate BatchAccount when generating batch journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) [21:32:36] (03PS2) 10Eileen: Record BatchAccount rows when generating adjustment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367936 (https://phabricator.wikimedia.org/T442668) [21:42:09] (03CR) 10Ejegg: [C:03+1] "Looks pretty good so far! One pre-existing var could use a rename." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 (owner: 10Cstone) [21:59:46] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Set is major gift in db triggers - https://phabricator.wikimedia.org/T444848 (10Lars) 03NEW [22:02:31] (03CR) 10Eileen: [C:03+2] Latest 1.9.2. CKEditor 5 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369495 (https://phabricator.wikimedia.org/T442745) (owner: 10Lars SG) [22:04:08] (03CR) 10Dmiranda: [C:03+2] do not validate adjustment branches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368979 (owner: 10Eileen) [22:04:48] thanks danielfm [22:05:06] NP eileen! [22:06:45] (03CR) 10Eileen: [C:03+2] Apply relationship manager MGGO appeal for DAF soft credits [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369509 (https://phabricator.wikimedia.org/T406662) (owner: 10Lars SG) [22:07:07] (03Merged) 10jenkins-bot: Latest 1.9.2. CKEditor 5 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369495 (https://phabricator.wikimedia.org/T442745) (owner: 10Lars SG) [22:07:35] (03Abandoned) 10Eileen: Simplify: Extract shared cross-instance transfer logic in writeJournalToCsv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1360528 (owner: 10Lars SG) [22:07:48] (03Merged) 10jenkins-bot: do not validate adjustment branches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368979 (owner: 10Eileen) [22:19:12] (03PS1) 10Lars SG: Update custom groups to match prod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369523 (https://phabricator.wikimedia.org/T409994) [22:45:44] (03PS15) 10Cstone: Log client errors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 [22:46:07] (03CR) 10Cstone: Log client errors (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1360018 (owner: 10Cstone) [22:47:09] (03PS2) 10Eileen: Move manually entered finance batches on to total_verified once entered [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368373 (https://phabricator.wikimedia.org/T434041) [22:52:11] (03PS3) 10Wfan: Update the braintree venmo loading [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369490 (https://phabricator.wikimedia.org/T443960) [22:52:45] (03CR) 10CI reject: [V:04-1] Move manually entered finance batches on to total_verified once entered [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1368373 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [23:11:36] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Move the tax deductability link to the links block - https://phabricator.wikimedia.org/T444259#12557719 (10AnnWF) there is reason why we have tax link not the same link block as other links, only US is show... [23:17:28] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Move the tax deductability link to the links block - https://phabricator.wikimedia.org/T444259#12557726 (10AnnWF) suggestion maybe only when US in same line otherwise new line next to links for more text: {... [23:21:49] 06Fundraising-Backlog, 10FR-WMF-Audit: DLOCAL - no SFTP reports coming in now - https://phabricator.wikimedia.org/T444883 (10Eileenmcnaughton) 03NEW [23:22:27] (03PS1) 10Wfan: WIP: (waiting for style approval)Move tax deduction link after other links [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369537 (https://phabricator.wikimedia.org/T444259) [23:23:40] 06Fundraising-Backlog, 10FR-WMF-Audit: DLOCAL - no SFTP reports coming in now - https://phabricator.wikimedia.org/T444883#12557743 (10Eileenmcnaughton) [23:24:05] (03PS1) 10Dmiranda: ComboWiki: show the one-click payment buttons together once the wallets are ready [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369538 (https://phabricator.wikimedia.org/T443817) [23:25:48] 10Fundraising Sprint: Unfolded laundry pile, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: prevent zooming when filling out fields on iPhone - https://phabricator.wikimedia.org/T444389#12557765 (10dmiranda) 05Open→03In progress a:03dmiranda [23:27:54] 06Fundraising-Backlog, 10FR-WMF-Audit: DLOCAL - no SFTP reports coming in now - https://phabricator.wikimedia.org/T444883#12557772 (10Eileenmcnaughton) p:05Triage→03High [23:44:18] (03CR) 10Eileen: [C:03+2] Update custom groups to match prod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369523 (https://phabricator.wikimedia.org/T409994) (owner: 10Lars SG) [23:51:00] (03Merged) 10jenkins-bot: Update custom groups to match prod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369523 (https://phabricator.wikimedia.org/T409994) (owner: 10Lars SG)