[00:13:11] FIRING: NodeDown: Node civi1002 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=civi1002 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [00:15:05] FIRING: KafkaJumboNoData: Kafka Broker hasn't received data from kafka-jumbo1018 in 60 minutes - https://alerts.wikimedia.org/?q=alertname%3DKafkaJumboNoData [00:18:11] RESOLVED: NodeDown: Node civi1002 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=civi1002 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [00:35:14] (03PS3) 10Lars SG: Add BatchAccount entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367934 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [00:39:06] (03CR) 10Lars SG: [C:03+2] "This seems fine but the name is perhaps a bit confusing. It's not really an account, it's a batch total per account, maybe" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367934 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [00:39:37] (03PS3) 10Eileen: Populate BatchAccount when generating batch journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) [00:40:52] (03PS1) 10Eileen: PayPal audit: don't let blank-invoice STL fee rows overwrite each other [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1370690 (https://phabricator.wikimedia.org/T445099) [00:44:16] (03Merged) 10jenkins-bot: Add BatchAccount entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367934 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [00:45:28] (03CR) 10Eileen: [C:03+2] Don't consider soft-credited excluded contacts for DAF gift coding [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370672 (https://phabricator.wikimedia.org/T406662) (owner: 10Lars SG) [00:50:59] (03Merged) 10jenkins-bot: Don't consider soft-credited excluded contacts for DAF gift coding [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370672 (https://phabricator.wikimedia.org/T406662) (owner: 10Lars SG) [00:52:28] (03PS4) 10Eileen: Populate BatchFinancialBreakdown when generating batch journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) [00:52:28] (03PS3) 10Eileen: Record BatchFinancialBreakdown rows when generating adjustment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367936 (https://phabricator.wikimedia.org/T442668) [00:52:28] (03PS1) 10Eileen: Rename BatchAccount entity to BatchFinancialBreakdown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370694 (https://phabricator.wikimedia.org/T442668) [00:54:31] (03CR) 10Lars SG: [C:03+2] Rename BatchAccount entity to BatchFinancialBreakdown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370694 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [00:59:07] (03Merged) 10jenkins-bot: Rename BatchAccount entity to BatchFinancialBreakdown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370694 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [01:18:53] (03PS5) 10Eileen: Populate BatchFinancialBreakdown when generating batch journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) [01:18:53] (03PS4) 10Eileen: Record BatchFinancialBreakdown rows when generating adjustment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367936 (https://phabricator.wikimedia.org/T442668) [01:19:06] (03CR) 10Lars SG: Populate BatchFinancialBreakdown when generating batch journals (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [01:21:23] (03CR) 10Eileen: Populate BatchFinancialBreakdown when generating batch journals (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [01:29:14] (03CR) 10Lars SG: Populate BatchFinancialBreakdown when generating batch journals (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [01:53:57] (03CR) 10Eileen: [C:03+2] "This seems OK Lars - my biggest concern is documentation - we don't have anything I could find about it on our wiki & I don't see links to" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370582 (https://phabricator.wikimedia.org/T445226) (owner: 10Lars SG) [01:58:32] (03Merged) 10jenkins-bot: Update WM-ending appeal codes when the donor or related contact has a DM activity for the original appeal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370582 (https://phabricator.wikimedia.org/T445226) (owner: 10Lars SG) [02:01:57] (03PS1) 10Dmiranda: ComboWiki: Use 16px text in form fields so iPhones don't zoom in [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370716 (https://phabricator.wikimedia.org/T444389) [02:11:06] (03PS6) 10Dmiranda: ComboWiki: show the one-click payment buttons together once the wallets are ready [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369538 (https://phabricator.wikimedia.org/T443817) [02:13:16] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki, 13Patch-For-Review: ComboWiki: UI bug (low priority) - https://phabricator.wikimedia.org/T443817#12574258 (10dmiranda) Thanks @Cstone! The patch is now ready for review for whenever anyone has a have a free moment. Thanks again! [02:14:48] (03PS1) 10Cstone: WIP: Use landing_page to track combowiki in contribution tracking [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370718 (https://phabricator.wikimedia.org/T438589) [02:16:11] (03CR) 10CI reject: [V:04-1] WIP: Use landing_page to track combowiki in contribution tracking [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370718 (https://phabricator.wikimedia.org/T438589) (owner: 10Cstone) [02:29:35] (03PS1) 10Lars SG: Add documentation links for WM appeal codes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370721 (https://phabricator.wikimedia.org/T445226) [02:31:14] eileen: yeah, I take your point on documentation. I added a couple links in the above that should help, but basically I had to figure this out in discussion with Megan - would be nice if they had better documentation, but not really our place to add [02:36:52] (03PS3) 10Lars SG: Backfill missing payment_instrument_ids for older recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369462 (https://phabricator.wikimedia.org/T444431) [02:41:53] 06Fundraising-Backlog, 10FR-Smashpig, 07FR-Fraud: Map isSuspectedFraud for all gateways - https://phabricator.wikimedia.org/T443814#12574285 (10Ejegg) We should do this for dlocal and braintree as well [02:42:15] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki, 13Patch-For-Review: Combowiki: prevent zooming when filling out fields on iPhone - https://phabricator.wikimedia.org/T444389#12574288 (10dmiranda) Hi Team! This patch is now ready for review. Attached is a video of the results. Note that the... [03:01:39] FIRING: SystemdService: Systemd service nginx.service stopped on frpm1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService [03:06:39] RESOLVED: SystemdService: Systemd service nginx.service stopped on frpm1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService [03:27:05] FIRING: KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [03:53:06] (03CR) 10Dmiranda: [C:03+2] "Thanks @lsandergreen@wikimedia.org for adding these links!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370721 (https://phabricator.wikimedia.org/T445226) (owner: 10Lars SG) [03:57:54] (03Merged) 10jenkins-bot: Add documentation links for WM appeal codes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370721 (https://phabricator.wikimedia.org/T445226) (owner: 10Lars SG) [04:01:55] (03PS1) 10Lars SG: WIP: Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) [04:27:10] (03PS6) 10Cstone: WIP: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [04:28:25] (03CR) 10CI reject: [V:04-1] WIP: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [04:33:31] (03PS7) 10Cstone: WIP: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [04:37:03] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_47) - 10https://gerrit.wikimedia.org/r/1370773 (owner: 10L10n-bot) [04:41:15] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Add amount and currency to donate button - https://phabricator.wikimedia.org/T445289 (10Cstone) 03NEW [04:41:31] 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Add amount and currency to donate button - https://phabricator.wikimedia.org/T445289#12574378 (10Cstone) p:05Triage→03High [04:53:49] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 2 others: Add appeal code to DAF donations on import - https://phabricator.wikimedia.org/T434201#12574385 (10Lars) I think we are correctly coding most of these now, but recently we have missed... [04:56:41] (03PS8) 10Cstone: WIP: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [05:03:48] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 2 others: Add appeal code to DAF donations on import - https://phabricator.wikimedia.org/T434201#12574388 (10Lars) @RLewis I think we should also change these to have MG in them, so we're captu... [06:58:15] (03PS9) 10Cstone: WIP: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [06:59:36] (03CR) 10CI reject: [V:04-1] WIP: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [06:59:53] (03PS10) 10Cstone: WIP: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [07:01:18] (03PS11) 10Cstone: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [07:05:19] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki: Combowiki Testing: Add amount and currency to donate button - https://phabricator.wikimedia.org/T445289#12574469 (10Cstone) [07:27:05] FIRING: KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [07:33:16] (03CR) 10Laurabarluzzi: [C:03+2] "👍" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1370690 (https://phabricator.wikimedia.org/T445099) (owner: 10Eileen) [07:33:41] (03Merged) 10jenkins-bot: PayPal audit: don't let blank-invoice STL fee rows overwrite each other [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1370690 (https://phabricator.wikimedia.org/T445099) (owner: 10Eileen) [07:55:44] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki: Combowiki Testing: Make the payment button text just the payment method icons - https://phabricator.wikimedia.org/T443958#12574514 (10Laurabarluzzi) [08:03:50] (03CR) 10Laurabarluzzi: [C:03+2] "@rlopez@wikimedia.org Let's get this merged to avoid further merge conflicts! @cstone@wikimedia.org showed me the Figma mocks." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [08:05:58] (03Merged) 10jenkins-bot: ComboWiki UI: Updates to PaymentMethods and Form layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1366865 (owner: 10Ramon Lopez) [10:09:55] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki, 13Patch-For-Review: ComboWiki: UI bug (low priority) - https://phabricator.wikimedia.org/T443817#12574889 (10Laurabarluzzi) @dmiranda I agree with your proposed approach, however I merged Ramon's patch (https://gerrit.wikimedia.org/r/c/media... [10:31:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-failmail, 13Patch-For-Review: Failmail: first recurring charge from monthly convert failing due to missing payment method - https://phabricator.wikimedia.org/T444620#12574944 (10Laurabarluzzi) @Damilare I marked my patch as WIP awaiting to hear y... [10:36:18] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 2 others: Add appeal code to DAF donations on import - https://phabricator.wikimedia.org/T434201#12574955 (10RLewis) That's ok with me as long as they pull into the MG revenue allocation ok. On... [11:17:43] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370716 (https://phabricator.wikimedia.org/T444389) (owner: 10Dmiranda) [11:19:07] (03Merged) 10jenkins-bot: ComboWiki: Use 16px text in form fields so iPhones don't zoom in [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370716 (https://phabricator.wikimedia.org/T444389) (owner: 10Dmiranda) [11:27:05] FIRING: KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [11:41:55] (03CR) 10Laurabarluzzi: "I did some testing that went through and I landed on a thank you page:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) (owner: 10Ejegg) [12:03:39] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-failmail, 13Patch-For-Review: Failmail: first recurring charge from monthly convert failing due to missing payment method - https://phabricator.wikimedia.org/T444620#12575388 (10Damilare) Hi @Laurabarluzzi, good question and thanks for sharing yo... [12:04:43] hi laurabar, thanks for all the thoughts in that ticket. [13:03:29] (03CR) 10Jgleeson: [C:04-1] Brantree / PayPal uses rediect flow (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) (owner: 10Ejegg) [13:05:28] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12575670 (10VOyelola-WMF) YubiKey public ID ` cccccdjbnfui ` [13:14:23] (03CR) 10Laurabarluzzi: Brantree / PayPal uses rediect flow (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) (owner: 10Ejegg) [13:43:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-failmail, 13Patch-For-Review: Failmail: first recurring charge from monthly convert failing due to missing payment method - https://phabricator.wikimedia.org/T444620#12575939 (10Laurabarluzzi) @Damilare Sounds good, so I moved the patch to being... [13:44:53] (03PS1) 10Damilare Adedoyin: Combowiki: Remove disabled button from Adyen Card [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370981 [13:45:49] (03PS2) 10Damilare Adedoyin: Combowiki: Show validation errors and remove disabled prop from Adyen Card submit button. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370981 [13:47:29] 06Fundraising-Backlog, 07Spike: Stripe Integration - https://phabricator.wikimedia.org/T445341 (10jgleeson) 03NEW [13:59:58] (03CR) 10Laurabarluzzi: Brantree / PayPal uses rediect flow (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) (owner: 10Ejegg) [14:01:53] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM - I think we might do the same in Braintree as well but I commented it in Braintree patch since you're already modifying the adapter " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370584 (https://phabricator.wikimedia.org/T445228) (owner: 10Ejegg) [14:04:08] thanks laurabar! I was just about to ask for review on that [14:06:11] (03Merged) 10jenkins-bot: Increment sequence number in Adyen adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370584 (https://phabricator.wikimedia.org/T445228) (owner: 10Ejegg) [14:07:06] np, I think also Braintree doesn't increment [14:11:26] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for all the work and conversation on this. This looks good to me, let's watch it in the logs and see how it plays out." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370923 (owner: 10Laurabarluzzi) [14:13:11] (03Merged) 10jenkins-bot: Monthly Convert: disable actions if first action isSubmitting [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370923 (owner: 10Laurabarluzzi) [14:16:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-failmail, 13Patch-For-Review: Failmail: first recurring charge from monthly convert failing due to missing payment method - https://phabricator.wikimedia.org/T444620#12576205 (10Damilare) Thanks @Laurabarluzzi, that sounds good! [14:19:42] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki: Combowiki fixes: Adyen card form validation - https://phabricator.wikimedia.org/T445349 (10Damilare) 03NEW [14:20:09] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki: Combowiki fixes: Adyen card form validation - https://phabricator.wikimedia.org/T445349#12576241 (10Damilare) a:03Damilare [14:20:27] (03PS3) 10Damilare Adedoyin: Combowiki: Show validation errors and remove disabled prop from Adyen Card submit button. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370981 (https://phabricator.wikimedia.org/T445349) [14:21:15] (03CR) 10Laurabarluzzi: [C:03+1] "@ejegg@ejegg.com This looks good, I just drop a suggestion for better readability but it's not a blocker. Would you be ok for using `start" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363459 (https://phabricator.wikimedia.org/T443637) (owner: 10Ejegg) [14:23:14] Thanks damilare [14:23:43] I'll be offline for a bit but then I'll continue reviewing patches :D [14:55:17] (03PS2) 10Jgleeson: Refactor: Use $fn in ContributionTrackingHelper log messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371010 [14:55:21] (03PS2) 10Jgleeson: Refactor: Rename $dataObject to $donationDetails [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371011 [14:59:47] fr-tech it looks like we're calculating the pay the fee bool from the utm_key URL param over in CiviCRM, and then we're faking the utm_key for mobile app payments here to do the same thing: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/36784b1c74e2ddf34f4112f9e854591eb7db2bd4/adyen_gateway/adyen_submit_payment.api.php#L277 [15:00:20] I don't want to do that for ComboWiki. It suggests the donor always came from an earlier page, and that won't be true when they land on ComboWiki directly. [15:03:20] I'm gonna look at add a new field to the contribution tracking message for `is_pay_fee` [15:03:53] ejegg: do you know if we considered that first time around and if so, why we decided against it ? [15:04:22] I'm wondering if adding new fields causes unexpected side effects I haven't thought of [15:05:04] back later! [15:27:05] FIRING: KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [15:31:49] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12576652 (10AStein-WMF) [15:40:34] (03PS1) 10Lars SG: Re-forget adyen contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371033 (https://phabricator.wikimedia.org/T443039) [15:57:24] (03CR) 10Laurabarluzzi: [C:03+2] "Thanks for doing this! I also noticed but failed at jumping on it 😄 These changes must have been reintroduced by mistake during a rebase o" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370981 (https://phabricator.wikimedia.org/T445349) (owner: 10Damilare Adedoyin) [15:59:06] (03Merged) 10jenkins-bot: Combowiki: Show validation errors and remove disabled prop from Adyen Card submit button. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370981 (https://phabricator.wikimedia.org/T445349) (owner: 10Damilare Adedoyin) [15:59:41] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki: Combowiki Testing (UI): Other Amount improvements - https://phabricator.wikimedia.org/T445024#12576903 (10Laurabarluzzi) [16:29:16] thanks laurabar! [16:52:16] FIRING: ContextSwitchingSpike: Host context switching high (instance frpm1002.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [17:04:12] 06Fundraising-Backlog, 10FR-Donation-Processing: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373 (10MDemosWMF) 03NEW [17:04:42] 06Fundraising-Backlog, 10FR-Donation-Processing: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373#12577261 (10MDemosWMF) p:05Triage→03High [17:07:16] RESOLVED: ContextSwitchingSpike: Host context switching high (instance frpm1002.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [17:33:14] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12577429 (10AStein-WMF) [17:42:34] 10fundraising-tech-ops: Fundraising access request for Victoria Oyelola - https://phabricator.wikimedia.org/T443514#12577517 (10AStein-WMF) 05Open→03Resolved [18:37:13] (03CR) 10Dmiranda: [C:03+2] "Thanks @lsandergreen@wikimedia.org LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371033 (https://phabricator.wikimedia.org/T443039) (owner: 10Lars SG) [18:41:01] Looks like danielfm beat you to it laurabar ^^ [18:41:10] (03Merged) 10jenkins-bot: Re-forget adyen contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371033 (https://phabricator.wikimedia.org/T443039) (owner: 10Lars SG) [18:42:47] Oops sorry laurabar! Was trying to start my day off with some code review 😅 [18:46:25] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371085 [18:47:29] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371085 (owner: 10Lars SG) [18:48:12] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371085 (owner: 10Lars SG) [18:49:21] !log civicrm upgraded from 051a47c6 to fd080cbb [18:49:23] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [18:56:31] (03CR) 10Dmiranda: [C:03+2] "Thanks @jgleeson@wikimedia.org! After giving the file a look, I think that updating the object's name from $dataObject to $donationDetails" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371011 (owner: 10Jgleeson) [18:57:43] danielfm: no worries! larssandergreen as I was reviewing my only concern were failmail (but you mentioned so I guess we ignore them) and I wanted to ask if the solution is limited to Adyen (as the title suggested) [18:57:50] larssandergreen: ^ [18:58:46] adyen is the only one we have implemented forget me for, so that's the only one we are doing now - but if we did add another in future, we could use the same code if needed [18:59:03] thanks danielfm ! [19:00:47] NP! Taking a look at the $fn patch now [19:00:53] larssandergreen: another thing I was looking at was if it fails, does it skip the current failing or drops the whole batch? [19:04:11] laurabar: it has actually completed now. If it fails, it would send failmail and continue to the next contact, but we didn't get any failmail, so I think all good. [19:04:27] But I don't have adyen access, so do you think you could do a little checking to confirm? [19:04:55] Here's a SK with ones that should have been forgotten: https://civicrm.wikimedia.org/civicrm/admin/search#/edit/10207 [19:05:04] Just sample a few I think [19:05:39] Ah ok, by reading the code before I thought that on 3 retries the job stopped (skipping the next ones). If it is actually continues to the next contact all good then 👌 [19:06:33] oh, like the queue abort - yes, I think it does on three in a row, but that's rare - and even then the queue items are still in the queue so we can just restart [19:06:36] So the only way we do track the 'forget me' actions is via 'activities'? [19:06:53] yes, we create the activity when we process them [19:08:46] 👌 thanks for the answering all my questions and fixing a high priority chaos bug 💪 [19:15:09] 06Fundraising-Backlog, 10FR-Donation-Processing: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373#12577928 (10SBurnett-WMF) @Lars or @Eileenmcnaughton - could you take a look, please? [19:20:58] laurabar: would you be able to check a few in adyen as mentioned above? [19:24:09] (03CR) 10Dmiranda: [C:03+1] "Hi @jgleeson@wikimedia.org thanks for taking this on! The refactoring looks good to me, however there is one small thing I wanted to bring" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371010 (owner: 10Jgleeson) [19:25:38] larssandergreen you mean if I can verify in the Adyen's account from the list in here https://civicrm.wikimedia.org/civicrm/admin/search#/edit/10207? [19:26:28] yes, all those backend or gateway transaction ids should now be "forgotten" in adyen and it would be good just to confirm a few of them [19:26:42] Ok checking [19:27:05] FIRING: KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [19:29:36] thanks danielfm I'll take a peek at that suggestion. I didn't spot it [19:32:08] larssandergreen: on a first glance they don't seem forgotten (e.g. I see the emails in the Adyen's dashboard). Could you confirm what I'm supposed to see instead? I see normal transaction pages unfortunately (IDs, email, name etc.). However, I wonder if it's even possible to delete info related to official money transaction. [19:32:57] Otherwise how can government fight fraud if all transactions can be done by anonymous people? 🤔 [19:33:26] laurabar: adyen says: Optional. To verify that the data has been redacted, check the payment in your Customer Area. The shopper data fields are shown as REDACTED, and the redaction date is shown in the Data Protection section. https://docs.adyen.com/development-resources/data-protection-api [19:38:06] The ones I see are not reducted in the Shopper Details areas (I see the email and full name). [19:38:22] I try to look into more to see if someone is redacted, so maybe you can compare [19:39:38] ok, thanks, let me check the logs. maybe try some that were forgotten in the last few days to see if those are any different (just change the activity date filter)? [19:41:28] shouldn't we target activity date today? [19:41:44] From your run? Or that didn't trigger another activity? [19:42:33] no, mine didn't add activities. I just mean some we did in the last week or so otherwise [19:44:09] Found one when I targeting Nov 2026 (nov 1st - yesterday) [19:44:15] *found one redacted [19:45:03] do you want to know the ID to compare the logs maybe? This transaction has reducted info: https://ca-live.adyen.com/ca/ui/payments/payment-list/ZWD2VV7QDKFJ8X62/ [19:46:58] backend Adyne's transaction id = ZWD2VV7QDKFJ8X62, Civi: Order Id = 97581660.35 (with this order_id, I could find the contact in civi that doesn't appear reducted: https://civicrm.wikimedia.org/civicrm/contact/view/contribution?reset=1&action=view&id=94937246) [19:49:09] Thanks, I'll see what I can figure out from the logs [19:49:50] (03PS4) 10Ejegg: Backfill missing payment_instrument_ids for older recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369462 (https://phabricator.wikimedia.org/T444431) (owner: 10Lars SG) [19:50:05] tks ejegg [19:50:07] (03CR) 10Ejegg: "PS4: rebase + renumber" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369462 (https://phabricator.wikimedia.org/T444431) (owner: 10Lars SG) [19:50:36] (03CR) 10Ejegg: [C:03+2] "Looks good! I guess the numbers aren't big enough to worry about the extra data to export." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369462 (https://phabricator.wikimedia.org/T444431) (owner: 10Lars SG) [19:50:42] Last thing; the 9 contacts in the SK results from Nov 1st - Nov 17th and have their Adyen's transactions show up as redacted. [19:51:01] yw lars [19:56:08] (03Merged) 10jenkins-bot: Backfill missing payment_instrument_ids for older recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369462 (https://phabricator.wikimedia.org/T444431) (owner: 10Lars SG) [19:57:27] (03PS1) 10Umherirrender: Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371093 [19:59:00] (03CR) 10CI reject: [V:04-1] Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371093 (owner: 10Umherirrender) [19:59:43] (03CR) 10Ejegg: [C:03+2] Update cancellation reasons mapping (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370658 (https://phabricator.wikimedia.org/T445276) (owner: 10Lars SG) [20:01:09] (03Merged) 10jenkins-bot: Update cancellation reasons mapping [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370658 (https://phabricator.wikimedia.org/T445276) (owner: 10Lars SG) [20:01:56] (03PS1) 10Ejegg: More comments to keep list in sync [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371096 [20:02:18] larssandergreen: just a followup with more pointers to other copies of that reasons list ^^^ [20:04:59] (03PS6) 10Ejegg: Add donate-recur duration, adapt getDonationDate [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363459 (https://phabricator.wikimedia.org/T443637) [20:05:00] (03PS5) 10Ejegg: Allow cookie expiration longer than functional duration [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363469 (https://phabricator.wikimedia.org/T441351) [20:05:39] (03CR) 10Ejegg: "Thanks Laura, PS6 uses startsWith()" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363459 (https://phabricator.wikimedia.org/T443637) (owner: 10Ejegg) [20:11:01] fr-tech I'm going to deploy the DonationInterface updates if nobody objects [20:11:18] thanks ejegg i was goign to do that this afternoon [20:11:21] Just want to monitor the Adyen retry code to make sure it's getting new merchant IDs [20:11:50] also tech talk ejegg [20:11:56] ahh sorry [20:12:43] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1371097 [20:12:58] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1371097 (owner: 10Ejegg) [20:14:05] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1371097 (owner: 10Ejegg) [20:14:30] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363459 (https://phabricator.wikimedia.org/T443637) (owner: 10Ejegg) [20:16:32] (03Merged) 10jenkins-bot: Add donate-recur duration, adapt getDonationDate [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363459 (https://phabricator.wikimedia.org/T443637) (owner: 10Ejegg) [20:19:17] (03PS1) 10Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1371101 [20:19:24] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1371101 (owner: 10Ejegg) [20:19:38] (03PS1) 10Ejegg: Update composer packages [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1371102 [20:20:38] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1371101 (owner: 10Ejegg) [20:21:22] (03PS2) 10Umherirrender: Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371093 [20:23:49] (03PS3) 10Umherirrender: Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371093 [20:32:23] (03CR) 10Lars SG: [C:03+2] More comments to keep list in sync [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371096 (owner: 10Ejegg) [20:33:56] (03Merged) 10jenkins-bot: More comments to keep list in sync [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371096 (owner: 10Ejegg) [20:58:58] (03PS2) 10Ejegg: Update composer packages [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1371102 [20:59:01] (03CR) 10Ejegg: [C:03+2] Update composer packages [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1371102 (owner: 10Ejegg) [21:05:37] (03Merged) 10jenkins-bot: Update composer packages [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1371102 (owner: 10Ejegg) [21:05:46] ok that should be ready to deploy [21:08:02] !log payments-wiki upgraded from 76f84609 to 1f962b4b [21:08:03] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:14:33] ok, looks like the order_id increment is working [21:17:52] will push the stuff out to donor portal too [21:19:08] !log donorwiki upgraded from 96e490ed to 1f962b4b [21:19:10] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [22:10:58] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.48.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371138 [22:12:35] (03CR) 10CI reject: [V:04-1] build: Update MediaWiki requirement to 1.48.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371138 (owner: 10Jforrester) [22:33:20] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 06Product Safety and Integrity, and 4 others: CVE-2026-132738: The 'centralnoticequerycampaign' API is a DoS vector because campaigns parameter has no item limit... - https://phabricator.wikimedia.org/T439968#12579031 [22:33:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 06Product Safety and Integrity, and 4 others: CVE-2026-132739: CentralNotice: Special:HideBanners can cause very large cookies to be set by CSRF attack from atta... - https://phabricator.wikimedia.org/T439974#12579032 [23:01:10] (03open) 10dwisehaupt: Upgrade civi to 6.20.1 [repos/fundraising-tech/community-civicrm] (labs_build) - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/46 [23:04:17] (03approved) 10dwisehaupt: Upgrade civi to 6.20.1 [repos/fundraising-tech/community-civicrm] (labs_build) - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/46 [23:04:25] (03update) 10dwisehaupt: Upgrade civi to 6.20.1 [repos/fundraising-tech/community-civicrm] (labs_build) - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/46 [23:06:35] (03merge) 10dwisehaupt: Upgrade civi to 6.20.1 [repos/fundraising-tech/community-civicrm] (labs_build) - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/46 [23:06:40] FIRING: SystemdService: Systemd service metabase.service stopped on fran2001.frack.codfw.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService [23:18:34] (03open) 10dwisehaupt: Upgrade civi to 6.20.1 [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/47 [23:25:01] (03merge) 10dwisehaupt: Upgrade civi to 6.20.1 [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/47 [23:27:05] FIRING: KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [23:32:42] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.48.0 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1371185 [23:47:30] 06Fundraising-Backlog: Overflow API integration update - https://phabricator.wikimedia.org/T445414 (10MDemosWMF) 03NEW