[00:01:54] (03PS1) 10Daimona Eaytoy: Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 [00:02:05] RESOLVED: KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [00:02:26] (03PS2) 10Jforrester: build: Update MediaWiki requirement to 1.48.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371138 [00:03:33] (03CR) 10CI reject: [V:04-1] Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (owner: 10Daimona Eaytoy) [00:04:12] (03CR) 10CI reject: [V:04-1] build: Update MediaWiki requirement to 1.48.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371138 (owner: 10Jforrester) [00:12:09] (03PS2) 10Daimona Eaytoy: Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 [00:13:25] (03CR) 10CI reject: [V:04-1] Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (owner: 10Daimona Eaytoy) [00:14:14] (03PS2) 10Laurabarluzzi: ComboWiki: standardize both min and max amount validation in AmountSelector [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370456 [00:14:44] (03PS3) 10Daimona Eaytoy: Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 [00:16:06] (03CR) 10CI reject: [V:04-1] Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (owner: 10Daimona Eaytoy) [00:17:05] FIRING: KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [00:17:40] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.48.0 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1371212 [00:18:22] (03PS4) 10Daimona Eaytoy: Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 [00:22:05] FIRING: [2x] KafkaBrokerDown: Kafka Broker kafka-jumbo1018 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [00:23:18] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.8.1 => v1.2.8.2) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1371217 [00:23:43] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.8.1 => v1.2.8.2) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371218 [00:27:16] (03PS1) 10Eileen: Composer updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371222 [00:27:48] (03CR) 10CI reject: [V:04-1] Composer updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371222 (owner: 10Eileen) [00:28:45] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.8.1 => v1.2.8.2) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1371217 (owner: 10Eileen) [00:28:59] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.8.1 => v1.2.8.2) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371218 (owner: 10Eileen) [00:33:21] (03PS2) 10Eileen: Composer updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371222 [00:36:31] (03PS1) 10Eileen: CiviCRM 6.20.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371232 [00:39:13] (03CR) 10Cstone: [C:03+2] "looks good, thanks for this!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370456 (owner: 10Laurabarluzzi) [00:42:25] (03PS7) 10Dmiranda: ComboWiki: show the one-click payment buttons together once the wallets are ready [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369538 (https://phabricator.wikimedia.org/T443817) [00:47:53] (03Merged) 10jenkins-bot: ComboWiki: standardize both min and max amount validation in AmountSelector [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370456 (owner: 10Laurabarluzzi) [00:48:34] (03CR) 10Krinkle: [C:03+2] build: Update MediaWiki requirement to 1.48.0 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1371212 (owner: 10Jforrester) [00:55:20] (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.48.0 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1371212 (owner: 10Jforrester) [00:59:43] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki, 13Patch-For-Review: ComboWiki: UI bug (low priority) - https://phabricator.wikimedia.org/T443817#12579388 (10dmiranda) Thanks @Laurabarluzzi! I have updated the patch accordingly and it's now ready for re-review . Here is a screen recording... [01:01:52] (03CR) 10Dmiranda: [C:03+2] Composer updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371222 (owner: 10Eileen) [01:03:54] (03PS1) 10Eileen: General update [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1371250 [01:04:06] (03CR) 10Eileen: [C:03+2] General update [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1371250 (owner: 10Eileen) [01:04:16] thanks danielfm [01:04:31] np eileen! [01:07:23] (03Merged) 10jenkins-bot: Composer updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371222 (owner: 10Eileen) [01:08:41] (03CR) 10Wfan: [C:03+2] CiviCRM 6.20.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371232 (owner: 10Eileen) [01:09:00] (03Merged) 10jenkins-bot: General update [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1371250 (owner: 10Eileen) [01:13:41] (03Merged) 10jenkins-bot: CiviCRM 6.20.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371232 (owner: 10Eileen) [01:23:36] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371266 [01:24:00] (03PS2) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371266 [01:24:14] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371266 (owner: 10Eileen) [01:25:30] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371266 (owner: 10Eileen) [01:26:43] !log civicrm upgraded from fd080cbb to 2aaf5a45 [01:26:45] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [01:31:26] (03CR) 10Cstone: [C:03+2] Update Benevity import mgd & tests to reflect current state [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370344 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:35:51] (03Merged) 10jenkins-bot: Update Benevity import mgd & tests to reflect current state [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370344 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:45:45] (03PS1) 10Cstone: WIP: Claude's suggestion for removing vaulting [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371283 (https://phabricator.wikimedia.org/T444269) [01:47:09] (03PS5) 10Dreamy Jazz: Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (https://phabricator.wikimedia.org/T420009) (owner: 10Daimona Eaytoy) [01:49:01] (03PS3) 10Eileen: Update Fidelity import mgd & tests to cover current state [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370348 (https://phabricator.wikimedia.org/T434041) [01:49:59] (03CR) 10Lars SG: [C:03+2] Update Fidelity import mgd & tests to cover current state [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370348 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:50:09] (03PS3) 10Eileen: Further clean up - gateway_account is now required and gateway is calculated from it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370359 (https://phabricator.wikimedia.org/T434041) [01:50:19] (03CR) 10Dreamy Jazz: Use HttpHeader instead of calling header() directly (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (https://phabricator.wikimedia.org/T420009) (owner: 10Daimona Eaytoy) [01:52:09] (03CR) 10Lars SG: [C:03+2] Further clean up - gateway_account is now required and gateway is calculated from it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370359 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:52:26] (03CR) 10Dreamy Jazz: Use HttpHeader instead of calling header() directly (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (https://phabricator.wikimedia.org/T420009) (owner: 10Daimona Eaytoy) [01:52:30] (03CR) 10Lars SG: [C:03+2] Set Overflow import templates to cleanup never [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370380 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:52:45] (03PS3) 10Eileen: Set Overflow import templates to cleanup never [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370380 (https://phabricator.wikimedia.org/T434041) [01:53:48] (03PS3) 10Jforrester: build: Update MediaWiki requirement to 1.48.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371138 [01:54:31] (03Merged) 10jenkins-bot: Update Fidelity import mgd & tests to cover current state [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370348 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:56:38] (03Merged) 10jenkins-bot: Further clean up - gateway_account is now required and gateway is calculated from it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370359 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [01:58:30] 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR, 07fr-combowiki: Combowiki Testing: Add amount and currency to donate button - https://phabricator.wikimedia.org/T445289#12579735 (10dmiranda) 05Open→03In progress a:03dmiranda [02:01:49] (03PS2) 10Cstone: WIP: Don't vault all Braintree Combowiki payments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371283 (https://phabricator.wikimedia.org/T444269) [02:01:58] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-CentralNotice, 06SRE, 06Traffic: Set expiry time for GeoIP cookies - https://phabricator.wikimedia.org/T122097#12579759 (10ssingh) >>! In T122097#12495291, @SBurnett-WMF wrote: > @ssingh - would Q3 work for this? Ouch, I am very s... [02:04:25] (03CR) 10Dreamy Jazz: [C:03+1] "This fixes the issue, but I'd prefer the comments be addressed so won't +2 (but others feel free to do that if it's blocking you)" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (https://phabricator.wikimedia.org/T420009) (owner: 10Daimona Eaytoy) [02:17:11] (03CR) 10Cstone: [C:03+2] Set Overflow import templates to cleanup never [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370380 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [02:21:29] (03Merged) 10jenkins-bot: Set Overflow import templates to cleanup never [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370380 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [02:25:13] (03CR) 10Reedy: [C:03+2] build: Update MediaWiki requirement to 1.48.0 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1371185 (owner: 10Jforrester) [02:27:50] (03PS1) 10Lars SG: Temp loggin for Re-forget adyen contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371313 (https://phabricator.wikimedia.org/T443039) [02:32:26] (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.48.0 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1371185 (owner: 10Jforrester) [02:32:34] (03CR) 10Eileen: [C:03+2] "Give it a go - although I think from memory coworker logging might be a bit odd - unless we fixed that" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371313 (https://phabricator.wikimedia.org/T443039) (owner: 10Lars SG) [02:33:08] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Eventlogging for Persistent Donor Badge - https://phabricator.wikimedia.org/T410522#12579910 (10Volker_E) @AKanji-WMF Think this could be declined, or? [02:35:45] (03CR) 10Reedy: [C:03+2] build: Update MediaWiki requirement to 1.48.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371138 (owner: 10Jforrester) [02:38:14] (03Merged) 10jenkins-bot: Temp loggin for Re-forget adyen contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371313 (https://phabricator.wikimedia.org/T443039) (owner: 10Lars SG) [02:42:45] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 2 others: Add appeal code to DAF donations on import - https://phabricator.wikimedia.org/T434201#12579940 (10Lars) @RLewis First, I updated all of the DAFDay26 to MGDAFDay26 (both the existing... [02:45:03] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371324 [02:45:15] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371324 (owner: 10Lars SG) [02:46:16] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371324 (owner: 10Lars SG) [02:46:55] !log civicrm upgraded from 2aaf5a45 to 81451b66 [02:46:57] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:16:58] (03CR) 10Daimona Eaytoy: Use HttpHeader instead of calling header() directly (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (https://phabricator.wikimedia.org/T420009) (owner: 10Daimona Eaytoy) [03:17:30] (03CR) 10Krinkle: Use HttpHeader instead of calling header() directly (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (https://phabricator.wikimedia.org/T420009) (owner: 10Daimona Eaytoy) [03:19:17] (03PS1) 10Eileen: Add GoFundme channel, fix the other 2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371349 [03:20:53] (03CR) 10Reedy: [C:03+2] "https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/1371158 We've used this in other places so far... Unblocks merging, can" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (https://phabricator.wikimedia.org/T420009) (owner: 10Daimona Eaytoy) [03:21:54] (03CR) 10Lars SG: [C:03+2] Add GoFundme channel, fix the other 2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371349 (owner: 10Eileen) [03:23:26] (03CR) 10Krinkle: [C:03+2] Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (https://phabricator.wikimedia.org/T420009) (owner: 10Daimona Eaytoy) [03:24:19] (03Merged) 10jenkins-bot: Use HttpHeader instead of calling header() directly [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371203 (https://phabricator.wikimedia.org/T420009) (owner: 10Daimona Eaytoy) [03:24:21] (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.48.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371138 (owner: 10Jforrester) [03:33:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Backfill missing payment_instrument_id for recurrings - https://phabricator.wikimedia.org/T444431#12580097 (10Lars) @TDHolland If you get check those charts again, they should have all the payment methods now. [04:27:32] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371408 [04:27:54] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371408 (owner: 10Eileen) [04:28:38] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1371408 (owner: 10Eileen) [04:30:08] !log civicrm upgraded from 81451b66 to 75af5119 [04:30:09] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [04:51:08] 06Fundraising-Backlog, 07fr-combowiki: utm_source improvements - https://phabricator.wikimedia.org/T445469 (10Cstone) 03NEW [04:51:13] 06Fundraising-Backlog, 07fr-combowiki: utm_source improvements - https://phabricator.wikimedia.org/T445469#12580189 (10Cstone) a:03Cstone [04:52:12] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Adyen and Braintree components and methods - https://phabricator.wikimedia.org/T442752#12580191 (10Cstone) 05Open→03Resolved a:03Cstone all pieces completed [04:52:58] 06Fundraising-Backlog, 07fr-combowiki: Combiwiki: Post payment monthly convert for braintree paypal - https://phabricator.wikimedia.org/T442630#12580195 (10Cstone) 05Open→03Declined this is what was implemented and we are currently removing it as it shows all donors the paypal billing agreement [05:37:09] (03PS1) 10Eileen: Bubble up new stock details for overflow gifts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1371508 (https://phabricator.wikimedia.org/T445414) [05:48:43] (03PS1) 10Cstone: Always set something for utm_source [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371513 (https://phabricator.wikimedia.org/T438589) [05:50:03] (03CR) 10CI reject: [V:04-1] Always set something for utm_source [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371513 (https://phabricator.wikimedia.org/T438589) (owner: 10Cstone) [05:51:20] (03PS1) 10Eileen: Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) [05:55:48] (03CR) 10CI reject: [V:04-1] Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) (owner: 10Eileen) [05:58:34] (03PS2) 10Cstone: Always set something for utm_source [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371513 (https://phabricator.wikimedia.org/T438589) [06:04:04] (03PS2) 10Eileen: Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) [06:06:38] (03CR) 10Cstone: [C:03+2] Bubble up new stock details for overflow gifts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1371508 (https://phabricator.wikimedia.org/T445414) (owner: 10Eileen) [06:07:05] (03Merged) 10jenkins-bot: Bubble up new stock details for overflow gifts [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1371508 (https://phabricator.wikimedia.org/T445414) (owner: 10Eileen) [06:09:26] (03CR) 10CI reject: [V:04-1] Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) (owner: 10Eileen) [06:13:42] (03Abandoned) 10Cstone: WIP: Use landing_page to track combowiki in contribution tracking [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370718 (https://phabricator.wikimedia.org/T438589) (owner: 10Cstone) [06:13:44] (03PS1) 10Eileen: Document a few more chariot fields [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1371517 [06:18:38] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371518 [06:18:52] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371518 (owner: 10Eileen) [06:21:22] (03PS3) 10Cstone: Always set something for utm_source [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371513 (https://phabricator.wikimedia.org/T438589) [06:23:22] (03CR) 10CI reject: [V:04-1] Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371518 (owner: 10Eileen) [06:26:30] (03PS1) 10Cstone: Show generic error to donors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371519 [06:27:25] (03PS3) 10Eileen: Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) [06:45:09] (03PS2) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371518 (https://phabricator.wikimedia.org/T445414) [06:45:11] (03PS4) 10Eileen: Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) [06:48:06] (03PS3) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371518 (https://phabricator.wikimedia.org/T445414) [06:48:47] (03PS5) 10Eileen: Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) [06:50:59] (03PS1) 10Eileen: Fix chariot failing to save state,country [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371526 (https://phabricator.wikimedia.org/T445373) [06:55:55] 06Fundraising-Backlog, 10FR-Donation-Processing, 13Patch-For-Review: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373#12580274 (10Eileenmcnaughton) It looks like we can fix these going forwards @MDemosWMF but the ones that are already in that state just need... [06:56:17] 06Fundraising-Backlog, 10FR-Donation-Processing, 10FR-Tech Sprint VARCHAIR, 13Patch-For-Review, 07Unplanned-Sprint-Work: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373#12580275 (10Eileenmcnaughton) [07:04:15] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Tech Sprint VARCHAIR: Endowment Fidelity Import - https://phabricator.wikimedia.org/T441913#12580277 (10Eileenmcnaughton) [07:55:50] (03PS1) 10Eileen: Add import batch number to mapping - to fill in per import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371618 (https://phabricator.wikimedia.org/T434041) [10:42:38] (03CR) 10Laurabarluzzi: [C:04-1] "Thanks for this! I left some suggestions that I think we should ideally address or at least confirm to not be breaking changes in producti" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369516 (https://phabricator.wikimedia.org/T443701) (owner: 10Damilare Adedoyin) [11:30:17] (03PS9) 10Ejegg: Brantree / PayPal uses rediect flow [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) [11:48:35] (03PS10) 10Jgleeson: Brantree / PayPal uses rediect flow [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) (owner: 10Ejegg) [12:25:32] 06Fundraising-Backlog: $wgDonationInterfaceCancelPage is not a cancel page, and is mostly not used - https://phabricator.wikimedia.org/T445511 (10jgleeson) 03NEW [12:27:27] 06Fundraising-Backlog: $wgDonationInterfaceCancelPage is not a cancel page, and is mostly not used - https://phabricator.wikimedia.org/T445511#12581706 (10jgleeson) [12:40:58] 06Fundraising-Backlog: $wgDonationInterfaceCancelPage is not a cancel page, and is mostly not used - https://phabricator.wikimedia.org/T445511#12581821 (10jgleeson) Our fail page template already has a cancellation message. It looks like this: {F115981405, size=full} We can't link to this message with a URL. T... [13:27:40] (03PS10) 10Damilare Adedoyin: RecurringConversion API refactor [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369516 (https://phabricator.wikimedia.org/T443701) [13:37:49] (03PS1) 10Lars SG: WIP: Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) [13:37:54] (03CR) 10Lars SG: "I noted that there were some that already have GL Codes. Not this fiscal, but last year and all the way back to 2009 for some reason - I'd" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) (owner: 10Lars SG) [13:45:36] (03CR) 10Damilare Adedoyin: "Thanks @lbarluzzi@wikimedia.org for the reviews, I've made the recommended change" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369516 (https://phabricator.wikimedia.org/T443701) (owner: 10Damilare Adedoyin) [14:01:03] (03CR) 10Laurabarluzzi: [C:03+2] "Thanks for making the changes, providing the context, and confirming the expected behavior. LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369516 (https://phabricator.wikimedia.org/T443701) (owner: 10Damilare Adedoyin) [14:01:49] woohoo thanks laurabar [14:02:02] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371519 (owner: 10Cstone) [14:02:31] (03Merged) 10jenkins-bot: RecurringConversion API refactor [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369516 (https://phabricator.wikimedia.org/T443701) (owner: 10Damilare Adedoyin) [14:03:27] (03Merged) 10jenkins-bot: Show generic error to donors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371519 (owner: 10Cstone) [14:14:47] (03PS16) 10Jgleeson: Braintree: PayPal uses redirect flow [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) (owner: 10Ejegg) [14:24:43] (03CR) 10Jgleeson: "This should now be ready for another round of review. I updated the following:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) (owner: 10Ejegg) [14:26:23] laurabar: ^ [14:27:43] ejegg: that paypal braintree patch is finished and ready for review [14:27:53] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Add job to send ad click conversion tracking to ad networks - https://phabricator.wikimedia.org/T444743#12582609 (10Lars) Additionally, BSD would like a CSV uploaded (they will provide SFTP creds): click id gift amount recurring amou... [14:28:18] I wrote up the updates made here https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1368430/comments/658ca773_82024563 [14:38:06] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371093 (owner: 10Umherirrender) [14:46:39] (03CR) 10Laurabarluzzi: [C:03+2] "@cstone@wikimedia.org This looks good to me! Let's maybe have a phab for the follow-up cleanup (maybe under needing more context) so that " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371513 (https://phabricator.wikimedia.org/T438589) (owner: 10Cstone) [14:53:02] thanks jgleeson [14:53:18] gotta wipe the old lappy, just making sure I got everything off. Then I'll take a look [14:56:47] thanks ejegg [14:58:25] I'm gonna grab the kids now but once I get back I'll dig into cstone's combowiki braintree paypal patch [14:59:12] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Request to change some details of the prenotification Annual Recurring Donor email for MGFE audiences - https://phabricator.wikimedia.org/T445547 (10RLewis) 03NEW [15:24:44] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM! Thanks for addressing all the changes and questions. I'm fine with doing follow-up patches for the sequence increase + potential cou" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) (owner: 10Ejegg) [15:53:29] (03PS3) 10Ejegg: WIP Adyen / plaid [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368731 (https://phabricator.wikimedia.org/T443515) [15:58:14] (03Merged) 10jenkins-bot: Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1371093 (owner: 10Umherirrender) [15:58:15] (03Merged) 10jenkins-bot: Always set something for utm_source [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371513 (https://phabricator.wikimedia.org/T438589) (owner: 10Cstone) [16:02:09] (03Merged) 10jenkins-bot: Braintree: PayPal uses redirect flow [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368430 (https://phabricator.wikimedia.org/T444633) (owner: 10Ejegg) [16:10:55] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Test Kitchen (Experiment Platform Sprint 33): SPIKE: what CentralNotice concept maps to a 'treatment' in TestKitchen - https://phabricator.wikimedia.org/T443454#12583424 (10KReid-WMF) [16:31:46] thanks for the review laura|kids ! [16:34:43] I'm having trouble finding braintree listener logs anywhere on frlog [16:35:02] or at least this one specific ID, let me search for something else [16:38:58] huh, nothing at all directly from braintree [16:39:06] do we have it configured to send us anything? [16:39:25] ooh, https://payments-listener.wikimedia.org/braintree is 404 [16:40:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add follow up Civi core patches for menu rebuild / caching deploy issues - https://phabricator.wikimedia.org/T441882#12583688 (10Lars) →14Duplicate dup:03T443053 [16:40:04] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Improve core cache clearing after Oct deploy incident - https://phabricator.wikimedia.org/T443053#12583686 (10Lars) [16:40:20] fr-tech it looks like we have an incomplete braintree listener implementation [16:40:23] the only braintree traffic I could see was in gr4vy listeners ejegg. I do also see a ton of errors in the logs [16:40:37] // we need a serializable job class here to add the payload to. [16:40:40] // for now let's just send an array. [16:41:54] I'll make a phab for that [16:42:30] ejegg: https://phabricator.wikimedia.org/T303451#9094149 [16:42:33] hah, NameMeJob https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/821295 [16:42:57] https://phabricator.wikimedia.org/T303451#9094149 [16:42:58] right [16:43:07] ooh, no webhooks? [16:43:10] looks like we shelved it and that first phab suggests we didn't get anything [16:43:11] well that's annoying [16:43:17] although that might be outdated [16:43:38] ok, we at least get some info about Braintree / PayPal from the direct PayPal listener [16:44:06] ah right, let's ask if they've added any in the last 3 years [16:44:17] well, i'll peek at the console as a first step [16:44:25] yeah makes sense [16:44:26] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE, 10FR-Tech Sprint VARCHAIR: Request to change some details of the prenotification Annual Recurring Donor email for MGFE audiences - https://phabricator.wikimedia.org/T445547#12583694 (10Lars) a:03Lars [16:44:57] also I want to rename the sprint tag so it doesn't ping us in IRC [16:45:13] now i'm curious what was in those gr4vy listener logs for gr4vy [16:45:33] ejegg: I was thinking that yesterday. why is it spamming ha [16:45:52] The usual pattern is 'Fundraising Sprint XXX' right? [16:46:03] ah with a : [16:46:21] k, renamed [16:46:44] oh wow [16:46:49] "address":{"city":"Braintree" [16:46:51] ha [16:46:53] errr [16:47:01] ohhhh [16:47:10] yeah, that's an actual city near boston [16:47:20] https://en.wikipedia.org/wiki/Braintree,_Essex [16:47:43] i live at one end of the 'Red Line' subway and the other end is in Braintree [16:48:00] (well, the other end branches so some trains go to Ashmont) [16:48:01] these hits are the UK one [16:48:10] so many braintrees! [16:48:27] hah, Essex is also a county in Massachusetts [16:48:46] but it's north of Boston while our Braintree is south of Boston [16:49:03] "we don't want your taxes but we will take the place names!!!" [16:49:07] @_@ [16:49:10] heh [16:49:35] FIRING: [2x] KafkaBrokerDown: Kafka Broker kafka-jumbo1016 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [16:50:20] ive been to liverpool new york a bunch jgleeson :P [16:50:31] haha nice [16:52:09] im reading its wikipedia page now and it needs some help hah [16:54:35] FIRING: [2x] KafkaBrokerDown: Kafka Broker kafka-jumbo1016 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [17:14:44] (03CR) 10Wfan: [C:03+2] "LGTM, let's merge this first~" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369538 (https://phabricator.wikimedia.org/T443817) (owner: 10Dmiranda) [17:15:25] (03PS4) 10Wfan: Do not go back to donate page if back from forbidden view [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370093 (https://phabricator.wikimedia.org/T444262) [17:27:08] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 07fr-combowiki: Comboiwki Testing: Contribution tracking field update and parity - https://phabricator.wikimedia.org/T445025#12583899 (10Cstone) [17:32:30] (03CR) 10Ejegg: [C:03+2] Fix chariot failing to save state,country [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371526 (https://phabricator.wikimedia.org/T445373) (owner: 10Eileen) [17:33:20] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10FR-Donation-Processing, 13Patch-For-Review, 07Unplanned-Sprint-Work: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373#12583957 (10Ejegg) a:03Eileenmcnaughton [17:35:52] (03Merged) 10jenkins-bot: ComboWiki: show the one-click payment buttons together once the wallets are ready [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369538 (https://phabricator.wikimedia.org/T443817) (owner: 10Dmiranda) [17:36:55] (03Merged) 10jenkins-bot: Fix chariot failing to save state,country [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371526 (https://phabricator.wikimedia.org/T445373) (owner: 10Eileen) [17:49:05] FIRING: KafkaJumboNoData: Kafka Broker hasn't received data from kafka-jumbo1016 in 60 minutes - https://alerts.wikimedia.org/?q=alertname%3DKafkaJumboNoData [17:54:05] FIRING: [2x] KafkaJumboNoData: Kafka Broker hasn't received data from kafka-jumbo1016 in 60 minutes - https://alerts.wikimedia.org/?q=alertname%3DKafkaJumboNoData [18:38:54] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10FR-Donation-Processing, 07Unplanned-Sprint-Work: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373#12584249 (10MDemosWMF) @Eileenmcnaughton Got it, thanks! I tried to create a new SK for contacts so I... [18:44:35] FIRING: [2x] KafkaBrokerDown: Kafka Broker kafka-jumbo1017 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [18:46:27] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1371913 [18:46:53] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1371913 (owner: 10Cstone) [18:56:30] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1371913 (owner: 10Cstone) [19:02:10] !log payments-wiki upgraded from 1f962b4b to 1614218d [19:02:12] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [19:03:11] (03PS1) 10Lars SG: Set reply-to benefactors@ for EOY receipt when segment is MG [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371928 (https://phabricator.wikimedia.org/T445547) [19:05:53] (03CR) 10CI reject: [V:04-1] build: Updating npm dependencies [extensions/FundraisingTranslateWorkflow] (REL1_43) - 10https://gerrit.wikimedia.org/r/1157359 (owner: 10Libraryupgrader) [19:09:31] (03CR) 10CI reject: [V:04-1] Set reply-to benefactors@ for EOY receipt when segment is MG [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371928 (https://phabricator.wikimedia.org/T445547) (owner: 10Lars SG) [19:13:11] (03PS1) 10Lars SG: Revert "Temp loggin for Re-forget adyen contributions" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371935 [19:13:18] (03CR) 10Lars SG: [C:03+2] Revert "Temp loggin for Re-forget adyen contributions" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371935 (owner: 10Lars SG) [19:19:03] (03Merged) 10jenkins-bot: Revert "Temp loggin for Re-forget adyen contributions" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371935 (owner: 10Lars SG) [19:22:38] ejegg: did you say you deployed the new braintree paypal code from earlier? [19:23:17] cstone: what do you want to do with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1371283 [19:23:23] do you want me to leave it alone for now [19:23:28] and let you wrap it up [19:23:34] i just deployed it jgleeson [19:23:49] for the patch it was just claudes patch, i didnt do any of it at all [19:24:00] and wanted peeps to take a look [19:24:20] if it looks good to you i can take off the wip or we can [19:24:51] (03PS1) 10Wfan: Run validation if payment method pass from url [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371945 (https://phabricator.wikimedia.org/T445277) [19:24:58] ok so braintree paypal just went out. thanks for that [19:25:06] I'll give it a production test now [19:27:41] ok so that didn't work as expected [19:27:51] I got redirected to a login page! lol [19:27:56] I'll check the logs [19:28:14] I wonder if Special:BraintreeGatewayResult needs adding to the whitelist [19:28:43] should be there for venmo no> [19:28:44] ? [19:28:51] we had to add the combowiki one [19:29:27] (03PS6) 10Wfan: Delete Recurring Payment tokens on Braintree when cancelled on CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) [19:29:49] that's it [19:29:52] the result page is missing [19:29:55] I'll add that now [19:30:50] (03PS1) 10Damilare Adedoyin: Use config to specify Adyen fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371954 [19:31:16] cstone: I just added that on frpm1002 [19:31:23] could you take a peek before I deploy [19:31:25] pls [19:31:26] thanks jgleeson [19:31:45] looks good [19:31:57] (03PS2) 10Damilare Adedoyin: Use config to specify Adyen fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371954 [19:32:06] thanks [19:32:45] ok that's out. I'll try it again [19:33:54] (03CR) 10CI reject: [V:04-1] Delete Recurring Payment tokens on Braintree when cancelled on CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) (owner: 10Wfan) [19:33:55] yay! worked [19:33:59] now recurring [19:35:21] (03PS4) 10Damilare Adedoyin: WIP Adyen / plaid [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368731 (https://phabricator.wikimedia.org/T443515) (owner: 10Ejegg) [19:35:39] ok that worked too [19:35:53] woo [19:35:57] I'll add them to the ticket and then wait for civicrm to import them [19:36:37] (03CR) 10CI reject: [V:04-1] WIP Adyen / plaid [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368731 (https://phabricator.wikimedia.org/T443515) (owner: 10Ejegg) [19:37:00] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 07FR Design, 07fr-combowiki: Combowiki Testing (UI): Other Amount improvements - https://phabricator.wikimedia.org/T445024#12584449 (10Cstone) [19:39:05] https://civicrm.wikimedia.org/civicrm/contact/view/contribution?reset=1&id=153831899&cid=9860166&action=view&context=contribution&selectedChild=contribute [19:39:14] https://civicrm.wikimedia.org/civicrm/contact/view/contribution?reset=1&id=153831975&cid=9860166&action=view&context=contribution&selectedChild=contribute [19:39:23] one-time and recurring. both completed [19:40:26] (03PS4) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371518 (https://phabricator.wikimedia.org/T445414) [19:40:38] (03CR) 10Ejegg: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371518 (https://phabricator.wikimedia.org/T445414) (owner: 10Eileen) [19:43:53] (03PS5) 10Damilare Adedoyin: WIP Adyen / plaid [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1368731 (https://phabricator.wikimedia.org/T443515) (owner: 10Ejegg) [19:44:05] FIRING: [2x] KafkaJumboNoData: Kafka Broker hasn't received data from kafka-jumbo1017 in 60 minutes - https://alerts.wikimedia.org/?q=alertname%3DKafkaJumboNoData [19:45:48] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371518 (https://phabricator.wikimedia.org/T445414) (owner: 10Eileen) [19:46:01] (03CR) 10Laurabarluzzi: [C:03+1] "I added a clarification question but the changes look good to me. I'd still like to have someone else to review this since it might affect" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371954 (owner: 10Damilare Adedoyin) [19:46:27] (03PS6) 10Eileen: Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) [19:46:35] (03CR) 10Ejegg: [C:03+2] Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) (owner: 10Eileen) [19:50:18] (03PS4) 10Jdlrobson: Documentation: Document public APIs for CentralNotice [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360958 [19:50:45] (03CR) 10Ejegg: [C:03+2] "Thanks, this is a great start at documenting it all." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360958 (owner: 10Jdlrobson) [19:51:58] (03Merged) 10jenkins-bot: Add handling for incoming stock ticker info from Overflow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371514 (https://phabricator.wikimedia.org/T445414) (owner: 10Eileen) [19:52:36] (03PS2) 10Laurabarluzzi: Move shared config directory setup into ConfigurationReader [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369517 (https://phabricator.wikimedia.org/T443802) [19:52:47] (03CR) 10Ejegg: [C:03+2] "Thanks for this follow-up!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369517 (https://phabricator.wikimedia.org/T443802) (owner: 10Laurabarluzzi) [19:57:35] jgleeson: great news for the production testing! 🎉 [20:02:13] 👍 [20:04:17] hi there! quick Q about where the ComboWiki DonationInterface code is/will run -- will donate.wikipedia.org be served from the app servers? [20:09:35] FIRING: [4x] KafkaBrokerDown: Kafka Broker kafka-jumbo1017 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [20:09:36] dwisehaupt: ^ [20:11:06] ah cjming looks like both our sres arent currently online, for app server do you mean the wikipedia app? or from where we are currenty hosting payments.wikimedia? [20:11:10] (03Merged) 10jenkins-bot: Documentation: Document public APIs for CentralNotice [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1360958 (owner: 10Jdlrobson) [20:11:11] (03Merged) 10jenkins-bot: Move shared config directory setup into ConfigurationReader [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1369517 (https://phabricator.wikimedia.org/T443802) (owner: 10Laurabarluzzi) [20:13:10] cstone: exactly - i kinda assume app server i.e. main cluster as opposed to the legacy donatewiki (donate.wikimedia.org) which forwards requests to paymentswiki on the payment cluster? just want to confirm because we're trying to figure out how to get the country code from a cookie into combowiki [20:15:55] combowki will be on the payments cluster [20:16:20] is this part of the cookie work that can't happen until the domain moves? [20:16:27] oh - gtk [20:17:11] so wait - combowiki will be served from donate.wikipedia.org right? but the DonationInterface code will be running on the payments cluster? [20:18:18] I think so but would like to talk to a SRE before I 100% confirm it with you [20:19:46] that's my understanding ^ cc ejegg [20:20:25] "Please purchase an SSL certificate for donate.wikipedia.org. Fundraising is planning to migrate payments processing to this domain, we don't expect to need to renew the payments.wikimedia.org cert when it expires in March." from the task [20:20:53] sounds good - thanks for the swift reply - I will await your response - so now it sounds like ComboWiki served from donate.wikipedia.org (on the main cluster) will forward requests to the payments cluster [20:21:49] yes cjming that's the idea [20:22:11] donate.wikipedia.org served by the payments cluster [20:23:08] so there's no forwarding to the payments cluster - the DNS for donate.wikipedia.org would be switched to resolve to the same as payments.wikimedia.org currently does [20:24:28] cool - thanks all for the info - i'm glad i asked [20:28:47] (03CR) 10Damilare Adedoyin: "Thanks @lbarluzzi@wikimedia.org for the review, I've responded to your question inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371954 (owner: 10Damilare Adedoyin) [20:40:21] (03CR) 10Dmiranda: [C:03+2] "Thanks @ejegg@ejegg.com! Tested this on my local machine and everything seems to be working as expected. One thing I noticed is we might w" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363469 (https://phabricator.wikimedia.org/T441351) (owner: 10Ejegg) [20:42:21] (03Merged) 10jenkins-bot: Allow cookie expiration longer than functional duration [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1363469 (https://phabricator.wikimedia.org/T441351) (owner: 10Ejegg) [20:42:31] thanks danielfm [20:42:50] np ejegg! [20:53:24] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface, 05MW-1.48-notes (1.48.0-wmf.6; 2026-11-24): Adyen direct integration does not increment order_id between attempts - https://phabricator.wikimedia.org/T445228#12584654 (10Ejegg) @Sjones-ctr we've d... [20:58:17] (03PS2) 10Lars SG: Set reply-to benefactors@ for EOY receipt when segment is MG [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371928 (https://phabricator.wikimedia.org/T445547) [20:59:05] FIRING: [4x] KafkaJumboNoData: Kafka Broker hasn't received data from kafka-jumbo1017 in 60 minutes - https://alerts.wikimedia.org/?q=alertname%3DKafkaJumboNoData [20:59:28] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1372037 [21:02:25] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Add follow pool custom field to Prospect - https://phabricator.wikimedia.org/T442106#12584677 (10Lars) [21:02:59] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372038 [21:03:11] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372038 (owner: 10Eileen) [21:03:28] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1372037 (owner: 10Eileen) [21:04:11] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372038 (owner: 10Eileen) [21:07:03] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.8.2 => v1.2.8.3) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1372037 (owner: 10Eileen) [21:09:53] (03PS19) 10Lars SG: WIP: Set GL codes for new contributions (and edits if batch not exported). [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369618 (https://phabricator.wikimedia.org/T409994) [21:09:57] (03PS3) 10Lars SG: WIP: Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) [21:15:59] (03PS20) 10Lars SG: Set GL codes for new contributions and edits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369618 (https://phabricator.wikimedia.org/T409994) [21:16:16] (03PS4) 10Lars SG: WIP: Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) [21:16:33] (03PS5) 10Lars SG: Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) [21:26:14] (03PS6) 10Lars SG: Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) [21:26:55] (03PS7) 10Lars SG: Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) [21:29:07] !log civicrm upgraded from 75af5119 to da8edacb [21:29:09] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:31:04] (03PS1) 10Ejegg: Merge branch 'REL1_43' into fundraising/REL1_43 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1372089 [21:31:10] (03PS1) 10Ejegg: Update packages for upstream 1_43 update [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1372090 [21:31:20] (03CR) 10Ejegg: [V:03+2 C:03+2] Merge branch 'REL1_43' into fundraising/REL1_43 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1372089 (owner: 10Ejegg) [21:31:41] (03CR) 10Ejegg: [C:03+2] Update packages for upstream 1_43 update [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1372090 (owner: 10Ejegg) [21:31:51] (03CR) 10Ejegg: [V:03+2 C:03+2] Update packages for upstream 1_43 update [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1372090 (owner: 10Ejegg) [21:45:09] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10FR-Donation-Processing, 07Unplanned-Sprint-Work: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373#12584869 (10Eileenmcnaughton) that feels like a regression ... I had a go just looking at addresses in... [21:45:30] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10FR-Donation-Processing, 07Unplanned-Sprint-Work: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373#12584871 (10Eileenmcnaughton) [21:45:36] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add MG Engagement for >$10K donations without one - https://phabricator.wikimedia.org/T445590 (10Lars) 03NEW [21:45:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Add MG Engagement for >$10K donations without one - https://phabricator.wikimedia.org/T445590#12584884 (10Lars) [21:50:09] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Add MG Engagement for >$10K donations without one - https://phabricator.wikimedia.org/T445590#12584903 (10Lars) [21:50:54] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10FR-Donation-Processing, 07Unplanned-Sprint-Work: Chariot gifts not pulling in 'State' for donor address - https://phabricator.wikimedia.org/T445373#12584908 (10MDemosWMF) Great, thanks @Eileenmcnaughton ! [21:51:58] ok, I don't see anything breaking locally with the 1_43 updates [21:52:03] going to push it out to prod [21:53:20] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Add MG Engagement for >$10K donations without one - https://phabricator.wikimedia.org/T445590#12584915 (10Lars) This will require {T441379} first to change relationship manager to a entity_ref. [21:54:04] !log payments-wiki upgraded from 1614218d to 7eb919a2 [21:54:06] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:55:04] !log donorwiki upgraded from 1f962b4b to 7eb919a2 [21:55:06] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:55:33] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Add MG Engagement for >$10K donations without one - https://phabricator.wikimedia.org/T445590#12584930 (10Lars) [22:01:58] ok, that doesn't seem to be breaking things on production [22:27:10] (03PS1) 10Ejegg: Set PayPal custom field for Braintree / paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 [22:27:38] (03CR) 10CI reject: [V:04-1] Set PayPal custom field for Braintree / paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 (owner: 10Ejegg) [22:28:59] (03PS1) 10Lars SG: Better error handling in forgetme when Smashpig config not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372160 (https://phabricator.wikimedia.org/T443039) [22:29:45] (03PS2) 10Lars SG: Better error handling in forgetme when Smashpig config not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372160 (https://phabricator.wikimedia.org/T443039) [22:58:26] 06Fundraising-Backlog, 07fr-combowiki: utm_source improvements - https://phabricator.wikimedia.org/T445469#12585215 (10Cstone) [23:33:42] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-current-sprint: Add MG Engagement Activity UI - https://phabricator.wikimedia.org/T441379#12585367 (10Lars) Once we convert the relationship manager field to a entity ref, then we can disable all the options in sol... [23:37:00] (03PS1) 10Lars SG: Change relationship manager to entity ref [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372227 (https://phabricator.wikimedia.org/T441379)