[00:04:35] RESOLVED: [4x] KafkaBrokerDown: Kafka Broker kafka-jumbo1017 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [00:07:57] FIRING: MariadbReplicationRunning: MariaDB replica thread not running on : frdb1007.frack.eqiad.wmnet:9004 - https://frmon.wikimedia.org/d/000000273/mariadb-system?orgId=1&var-server=frdb1007.frack.eqiad.wmnet - https://alerts.wikimedia.org/?q=alertname%3DMariadbReplicationRunning [00:12:57] RESOLVED: MariadbReplicationRunning: MariaDB replica thread not running on : frdb1007.frack.eqiad.wmnet:9004 - https://frmon.wikimedia.org/d/000000273/mariadb-system?orgId=1&var-server=frdb1007.frack.eqiad.wmnet - https://alerts.wikimedia.org/?q=alertname%3DMariadbReplicationRunning [00:17:05] FIRING: [3x] KafkaBrokerDown: Kafka Broker kafka-jumbo1016 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [00:22:05] FIRING: [6x] KafkaBrokerDown: Kafka Broker kafka-jumbo1016 is down: [0] - https://alerts.wikimedia.org/?q=alertname%3DKafkaBrokerDown [00:59:05] FIRING: [4x] KafkaJumboNoData: Kafka Broker hasn't received data from kafka-jumbo1017 in 60 minutes - https://alerts.wikimedia.org/?q=alertname%3DKafkaJumboNoData [01:01:56] (03CR) 10Eileen: [C:03+2] "I think this is gonna be OK - let's deploy it & watch a few!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1369618 (https://phabricator.wikimedia.org/T409994) (owner: 10Lars SG) [01:03:58] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372263 [01:05:56] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372263 (owner: 10Eileen) [01:06:56] !log civicrm upgraded from da8edacb to 8457485d [01:06:58] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [01:12:06] (03PS1) 10Eileen: Clear existing GL codes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372280 (https://phabricator.wikimedia.org/T409994) [01:12:08] (03PS1) 10Eileen: Clear all existing GL Codes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372281 (https://phabricator.wikimedia.org/T409994) [01:14:49] (03PS2) 10Eileen: Clear GL codes from fiscal year start [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372281 (https://phabricator.wikimedia.org/T409994) [01:15:07] (03Abandoned) 10Eileen: Clear existing GL codes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372280 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [01:28:16] (03CR) 10CI reject: [V:04-1] Clear GL codes from fiscal year start [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372281 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [01:33:36] FIRING: HostTotalProcs: Host high process count (instance frdb1006.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostTotalProcs [01:38:36] RESOLVED: HostTotalProcs: Host high process count (instance frdb1006.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostTotalProcs [02:08:31] (03PS8) 10Lars SG: Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) [02:16:11] (03PS1) 10Eileen: Add Contribution.backfillGLCode api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372308 (https://phabricator.wikimedia.org/T409994) [02:27:56] (03PS1) 10Eileen: Add Gateway Fee channel, set it on audit fee transactions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372320 (https://phabricator.wikimedia.org/T409994) [02:29:57] (03CR) 10Lars SG: [C:03+2] Add Gateway Fee channel, set it on audit fee transactions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372320 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [02:35:50] (03Merged) 10jenkins-bot: Add Gateway Fee channel, set it on audit fee transactions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372320 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [02:37:49] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372332 [02:38:43] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372332 (owner: 10Eileen) [02:39:27] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372332 (owner: 10Eileen) [02:40:01] !log civicrm upgraded from 8457485d to 1bf1f2a8 [02:40:02] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:51:52] (03CR) 10Lars SG: [C:03+2] Add Contribution.backfillGLCode api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372308 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [02:55:50] (03Merged) 10jenkins-bot: Add Contribution.backfillGLCode api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372308 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [02:58:48] (03PS9) 10Lars SG: Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) [03:06:40] FIRING: SystemdService: Systemd service coworker.service stopped on civi1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService [03:07:45] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372367 [03:08:34] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372367 (owner: 10Eileen) [03:09:33] (03PS2) 10Ejegg: Set PayPal custom field for Braintree / paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 [03:09:43] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372367 (owner: 10Eileen) [03:10:06] (03CR) 10CI reject: [V:04-1] Set PayPal custom field for Braintree / paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 (owner: 10Ejegg) [03:10:29] !log civicrm upgraded from 1bf1f2a8 to 95187ba7 [03:10:30] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:10:33] (03PS1) 10Dmiranda: ComboWiki: show amount, currency and padlock on the donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1372369 (https://phabricator.wikimedia.org/T445289) [03:15:03] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Paypal, 10FR-Smashpig: PayPal IPN listener should recognize and properly tag Braintree-originated donations - https://phabricator.wikimedia.org/T445609 (10Ejegg) 03NEW [03:16:40] RESOLVED: SystemdService: Systemd service coworker.service stopped on civi1002.frack.eqiad.wmnet:9100 - https://alerts.wikimedia.org/?q=alertname%3DSystemdService [03:18:31] (03PS1) 10Lars SG: Match GL Code options to prod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372374 (https://phabricator.wikimedia.org/T409994) [03:18:39] (03Abandoned) 10Eileen: Clear GL codes from fiscal year start [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372281 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [03:19:59] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki Testing: Add amount and currency to donate button - https://phabricator.wikimedia.org/T445289#12585816 (10dmiranda) Hi team! The patch is now up for this ticket and ready for review. The buttons for Card... [03:22:37] (03PS2) 10Lars SG: Match GL Code options to prod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372374 (https://phabricator.wikimedia.org/T409994) [03:22:58] (03CR) 10Eileen: [C:03+2] Match GL Code options to prod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372374 (https://phabricator.wikimedia.org/T409994) (owner: 10Lars SG) [03:28:26] (03Merged) 10jenkins-bot: Match GL Code options to prod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372374 (https://phabricator.wikimedia.org/T409994) (owner: 10Lars SG) [03:30:03] (03CR) 10Eileen: [C:03+2] Backfill gl codes from start of fiscal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1370737 (https://phabricator.wikimedia.org/T409994) (owner: 10Lars SG) [03:30:29] (03PS3) 10Ejegg: Set PayPal custom field for Braintree / paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 [03:31:00] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372377 [03:31:12] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1372377 (owner: 10Eileen) [03:31:15] (03CR) 10CI reject: [V:04-1] Set PayPal custom field for Braintree / paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 (owner: 10Ejegg) [03:33:41] !log + 849e1e7cc3fa1e02f02452026a865598503fe119 Match GL Code options to prod [03:33:41] + 0508f5f9468a4ed5aceb6320fbe8d238f500296c Backfill gl codes from start of fiscal [03:33:42] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:33:56] !log civicrm upgraded from 95187ba7 to 52e0baad [03:33:57] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:34:05] (03PS4) 10Ejegg: Set PayPal custom field for Braintree / paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 (https://phabricator.wikimedia.org/T445609) [04:07:58] (03PS1) 10Eileen: Use the stored gl_code for journal account numbers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372382 (https://phabricator.wikimedia.org/T409994) [04:09:27] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Stop default rows from being created for tables that rarely should have rows - https://phabricator.wikimedia.org/T445611 (10Lars) 03NEW [04:15:26] (03PS1) 10Eileen: Group journal rows by account only, not fund or is_major_gift [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372389 (https://phabricator.wikimedia.org/T409994) [04:19:13] (03CR) 10Lars SG: [C:03+2] Use the stored gl_code for journal account numbers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372382 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [04:20:23] (03CR) 10Lars SG: [C:03+2] Group journal rows by account only, not fund or is_major_gift [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372389 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [04:24:22] (03Merged) 10jenkins-bot: Use the stored gl_code for journal account numbers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372382 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [04:25:32] (03Merged) 10jenkins-bot: Group journal rows by account only, not fund or is_major_gift [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372389 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [04:28:04] !log revision changed from ac9cac49 to 11037045 [04:28:05] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [04:38:22] (03PS1) 10Eileen: Remap all major gifts accounts to restricted on endowment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372492 (https://phabricator.wikimedia.org/T409994) [04:45:11] (03PS1) 10Eileen: Add gl_code to the batch detail export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372494 (https://phabricator.wikimedia.org/T409994) [04:50:39] (03PS1) 10Eileen: Add item_count to journal rows rather than parsing it from MEMO [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372495 (https://phabricator.wikimedia.org/T442668) [06:24:59] (03PS2) 10Eileen: Remap all major gifts accounts to restricted on endowment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372492 (https://phabricator.wikimedia.org/T409994) [06:24:59] (03PS2) 10Eileen: Add gl_code to the batch detail export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372494 (https://phabricator.wikimedia.org/T409994) [06:24:59] (03PS2) 10Eileen: Add item_count to journal rows rather than parsing it from MEMO [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372495 (https://phabricator.wikimedia.org/T442668) [06:25:00] (03PS6) 10Eileen: Populate BatchFinancialBreakdown when generating batch journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) [06:25:01] (03PS1) 10Eileen: Define the journal csv headers in FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372521 (https://phabricator.wikimedia.org/T442668) [06:25:03] (03PS1) 10Eileen: Add row_type to journal rows rather than parsing MEMO [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372522 (https://phabricator.wikimedia.org/T442668) [06:25:07] (03PS1) 10Eileen: Refactor - Add JournalWriter and move code relevant to outputting the csv journal files to that class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372523 (https://phabricator.wikimedia.org/T442668) [07:09:02] (03PS3) 10Cstone: Don't vault all Braintree Combowiki payments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371283 (https://phabricator.wikimedia.org/T444269) [08:40:36] FIRING: HostTotalProcs: Host high process count (instance frdb1006.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostTotalProcs [08:50:36] RESOLVED: HostTotalProcs: Host high process count (instance frdb1006.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostTotalProcs [10:20:57] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372160 (https://phabricator.wikimedia.org/T443039) (owner: 10Lars SG) [10:25:42] (03Merged) 10jenkins-bot: Better error handling in forgetme when Smashpig config not available [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372160 (https://phabricator.wikimedia.org/T443039) (owner: 10Lars SG) [10:59:43] (03CR) 10Laurabarluzzi: [C:03+1] Use config to specify Adyen fields (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371954 (owner: 10Damilare Adedoyin) [12:14:20] (03CR) 10Damilare Adedoyin: "Thanks for the review @lbarluzzi@wikimedia.org, responded inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371954 (owner: 10Damilare Adedoyin) [12:19:15] (03CR) 10Damilare Adedoyin: [C:03+2] Remove CSP alert on banner previews [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1370621 (https://phabricator.wikimedia.org/T193332) (owner: 10Ejegg) [12:21:14] (03Merged) 10jenkins-bot: Remove CSP alert on banner previews [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1370621 (https://phabricator.wikimedia.org/T193332) (owner: 10Ejegg) [12:31:23] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for the catch and fix @wfan@wikimedia.org, looks good to me." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371945 (https://phabricator.wikimedia.org/T445277) (owner: 10Wfan) [12:39:24] (03Merged) 10jenkins-bot: Run validation if payment method pass from url [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371945 (https://phabricator.wikimedia.org/T445277) (owner: 10Wfan) [12:42:51] (03CR) 10Damilare Adedoyin: "Thanks @dmiranda@wikimedia.org for all the work on this, looks good to me but I added a suggestion that could help improve performance." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1372369 (https://phabricator.wikimedia.org/T445289) (owner: 10Dmiranda) [13:15:34] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM! Thanks for taking the time explaining things 😊" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371954 (owner: 10Damilare Adedoyin) [13:20:33] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10WikimediaCustomizations, and 3 others: CentralNotice should expose functions that encapsulate the structure of the hide cookie - https://phabricator.wikimedia.org/T441349#12587256 (10Laurabarluzzi) @Ejegg I see t... [13:21:25] (03Merged) 10jenkins-bot: Use config to specify Adyen fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1371954 (owner: 10Damilare Adedoyin) [13:33:35] thanks for the review laurabar ! [13:34:06] np [14:33:35] (03CR) 10Lars SG: [C:03+2] Add gl_code to the batch detail export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372494 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [14:59:15] 06Fundraising-Backlog, 10FY26-27 ST6.4 - Logged-in performance, 10MediaWiki-extensions-CentralNotice, 06SRE, and 4 others: Special:HideBanners is not really cacheable - https://phabricator.wikimedia.org/T256447#12588067 (10Krinkle) a:03Krinkle @Ejegg Yes and no. As it stand today, I think we can rely on... [15:07:30] 06Fundraising-Backlog, 10FY26-27 ST6.4 - Logged-in performance, 10MediaWiki-extensions-CentralNotice, 06SRE, and 4 others: Special:HideBanners is not really cacheable - https://phabricator.wikimedia.org/T256447#12588129 (10Ejegg) Interesting that the cookie would work for a few days at least. I guess that'... [15:09:07] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10WikimediaCustomizations, and 3 others: CentralNotice should expose functions that encapsulate the structure of the hide cookie - https://phabricator.wikimedia.org/T441349#12588140 (10Ejegg) Thanks for the nudge L... [15:10:09] (03PS1) 10Reedy: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1372724 (https://phabricator.wikimedia.org/T439935) [15:10:21] woo, it's public ^^^ [15:10:29] (03PS1) 10Reedy: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_47) - 10https://gerrit.wikimedia.org/r/1372725 (https://phabricator.wikimedia.org/T439935) [15:10:47] (03PS1) 10Reedy: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1372726 (https://phabricator.wikimedia.org/T439935) [15:10:59] (03CR) 10Ejegg: [C:03+2] SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1372724 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [15:11:04] (03PS1) 10Reedy: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1372727 (https://phabricator.wikimedia.org/T439935) [15:11:30] (03CR) 10Ejegg: [C:03+2] SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1372727 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [15:11:38] (03CR) 10Ejegg: [C:03+2] SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1372726 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [15:11:44] (03PS1) 10Reedy: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_43) - 10https://gerrit.wikimedia.org/r/1372728 (https://phabricator.wikimedia.org/T439935) [15:11:50] (03CR) 10Ejegg: [C:03+2] SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_47) - 10https://gerrit.wikimedia.org/r/1372725 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [15:13:56] (03Merged) 10jenkins-bot: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1372727 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [15:13:57] (03Merged) 10jenkins-bot: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1372726 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [15:14:10] (03Merged) 10jenkins-bot: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_47) - 10https://gerrit.wikimedia.org/r/1372725 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [15:14:30] (03CR) 10Reedy: [C:03+2] SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_43) - 10https://gerrit.wikimedia.org/r/1372728 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [15:14:56] (03Merged) 10jenkins-bot: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1372724 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [15:16:41] (03Merged) 10jenkins-bot: SECURITY: CNBanners only performs edits on POST [extensions/CentralNotice] (REL1_43) - 10https://gerrit.wikimedia.org/r/1372728 (https://phabricator.wikimedia.org/T439935) (owner: 10Reedy) [16:27:47] (03PS1) 10Lars SG: Workplace giving trumps relationship manager for gl code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372895 (https://phabricator.wikimedia.org/T409994) [16:31:30] s/trumps/overwrites/ :P [16:32:00] just jump-scare-reduction ;) [16:32:05] (I don't care, honeslty) [16:59:25] (03PS7) 10Wfan: Delete Recurring Payment tokens on Braintree when cancelled on CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) [17:03:58] (03CR) 10CI reject: [V:04-1] Delete Recurring Payment tokens on Braintree when cancelled on CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) (owner: 10Wfan) [17:09:13] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 07FR Design, 07fr-combowiki: Combowiki Testing (UI): Other Amount improvements - https://phabricator.wikimedia.org/T445024#12588680 (10Cstone) @Laurabarluzzi thanks for updating the task with the completed part. I got a FR Design tag created and tagged... [17:20:17] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 07FR Design, 07fr-combowiki: Combowiki Testing (UI): Other Amount improvements - https://phabricator.wikimedia.org/T445024#12588807 (10Pcoombe) For what it's worth we just use "Other" as the text in banners and donatewiki, assuming it's clear from the... [17:25:35] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Paypal, and 2 others: PayPal IPN listener should recognize and properly tag Braintree-originated donations - https://phabricator.wikimedia.org/T445609#12588823 (10Ejegg) a:03Ejegg [17:26:20] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 07fr-combowiki, 05MW-1.48-notes (1.48.0-wmf.6; 2026-11-24): Stop instantiating gateway adapters at first Combowiki page load - https://phabricator.wikimedia.org/T443802#12588827 (10Ejegg) a:05Ejegg→03None [17:26:55] 06Fundraising-Backlog, 07fr-combowiki: Combowiki testing (minor): missing decimal places in Other amount field - https://phabricator.wikimedia.org/T445699 (10Pcoombe) 03NEW [17:39:42] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 07fr-combowiki: Combowiki Testing: Check and Fix Monthly Convert session setting if needed - https://phabricator.wikimedia.org/T443701#12588925 (10Ejegg) [17:48:57] 06Fundraising-Backlog, 07fr-combowiki: Combowiki and possibly payments wiki: check sticky session - https://phabricator.wikimedia.org/T445703 (10Cstone) 03NEW [17:50:56] 06Fundraising-Backlog: Don't merge contact if checksum and contact is information is different from donation information - https://phabricator.wikimedia.org/T445704 (10Cstone) 03NEW [18:14:34] 06Fundraising-Backlog, 10FR-Donation-Processing: Wrong CID match to DAF's individual soft credit/relationship link - Chariot - https://phabricator.wikimedia.org/T445707 (10MDemosWMF) 03NEW [18:24:54] (03PS1) 10Ejegg: SECURITY: Drop PayPal IPNs for other receivers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372922 (https://phabricator.wikimedia.org/T441124) [18:24:58] (03CR) 10Ejegg: [C:03+2] SECURITY: Drop PayPal IPNs for other receivers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372922 (https://phabricator.wikimedia.org/T441124) (owner: 10Ejegg) [18:25:32] (03Merged) 10jenkins-bot: SECURITY: Drop PayPal IPNs for other receivers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372922 (https://phabricator.wikimedia.org/T441124) (owner: 10Ejegg) [18:26:10] 06Fundraising-Backlog, 10FR-Donation-Processing: Chariot data issue - omitting 'and' in Fidelity gifts - https://phabricator.wikimedia.org/T434155#12589118 (10MDemosWMF) This is still occurring and causing an issue for data hygiene in Civi. @Eileenmcnaughton Is there a way to fix on our end? Can't remember whe... [18:26:32] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1372923 [18:26:36] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1372923 (owner: 10Ejegg) [18:27:02] ok fr-tech ^^^ is about to go out (so we can continue with the other IPN filtering related to braintree) [18:27:04] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1372923 (owner: 10Ejegg) [18:31:58] !log standalone (IPN listener) SmashPig upgraded from d446404f to d04fbd28 [18:32:00] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [18:33:14] looks like it's working fine [18:33:28] paypal_smashpig_job_runner-20261120-183201.log was the first full run with the new code [18:34:22] ah it's all stuff that gets dropped due to being from gravy anyway [18:36:20] oh fun there are mp_signup messages with none of those reciever fields [18:36:27] do we just drop those anyway [18:36:28] ? [18:36:58] yeah, that's ok [18:37:41] I think we blocked mp_signup for gravy [18:37:45] with some config [18:37:52] yeah [18:38:45] ok I'm just going to make the PayPal listener drop all the Braintree ones for now [18:39:02] we can try to make it tag them correctly and send them to donations in a future iteration i guess [18:39:17] but for now it seems too hard to get the braintree gateway_txn_id in there [18:40:13] glad to see them all, then we can filter out rejected one later [18:41:44] we still have no way to check if gravy or braintree paypal a bit annoying haha [18:43:55] (03PS5) 10Ejegg: Set PayPal custom field for Braintree / paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 (https://phabricator.wikimedia.org/T445609) [18:48:25] (03PS8) 10Wfan: Delete Recurring Payment tokens on Braintree when cancelled on CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) [18:49:11] woo, with ^^ I get exactly 1 donation in my local Civi, and it's tagged as braintree [18:52:48] (03CR) 10Ejegg: "To test this, you need to pull the updated code in two places: payments/vendor/wikimedia/smash-pig and also smashpig/ . You will also need" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 (https://phabricator.wikimedia.org/T445609) (owner: 10Ejegg) [18:53:58] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 10FR-Braintree-Integration, 10FR-Paypal, and 2 others: PayPal IPN listener should recognize and properly tag Braintree-originated donations - https://phabricator.wikimedia.org/T445609#12589226 (10Ejegg) I'm just having the PayPal IPN listener drop the... [18:55:33] (03PS1) 10Umherirrender: Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] (REL1_47) - 10https://gerrit.wikimedia.org/r/1372928 [18:55:44] (03PS1) 10Umherirrender: Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1372929 [18:57:57] (03CR) 10Umherirrender: [C:03+2] Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] (REL1_47) - 10https://gerrit.wikimedia.org/r/1372928 (owner: 10Umherirrender) [18:58:00] (03CR) 10Umherirrender: [C:03+2] Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1372929 (owner: 10Umherirrender) [18:59:37] thanks ejegg, will test that now~ [18:59:45] (03Merged) 10jenkins-bot: Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1372929 (owner: 10Umherirrender) [18:59:46] (03Merged) 10jenkins-bot: Returning from a finally block has been deprecated in PHP 8.6 [extensions/CentralNotice] (REL1_47) - 10https://gerrit.wikimedia.org/r/1372928 (owner: 10Umherirrender) [19:14:51] ejegg: are you using the 6 endpoint? [19:15:21] cstone I was using 5 [19:15:57] https://www.sandbox.paypal.com/merchantnotification/ipn/preference?intl=0 is 6 [19:16:28] ejegg: ^ were trying to get the ipn to go to wenjuns laptop [19:17:47] oh weird [19:18:43] i see 6 when logged in as f doner [19:18:50] and 5 when logged in as facilitator [19:18:56] I think you have to log in as facilitator to change it [19:19:17] oh that's why [19:19:21] ok thanks [19:35:31] 10Fundraising Sprint: VARCHAIR, 06Fundraising-Backlog, 07FR Design, 07fr-combowiki: Combowiki Testing: Card UI improvements - https://phabricator.wikimedia.org/T444266#12589401 (10Cstone) [19:39:27] (03PS1) 10Lars SG: Escape special chars in GL code labels for summary email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372947 (https://phabricator.wikimedia.org/T409994) [19:39:41] (03CR) 10Lars SG: [C:03+2] "tiny follow up: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1372947" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372492 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [19:44:59] (03CR) 10Wfan: [C:03+2] "LGTM tested with both cstone and Daniel" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 (https://phabricator.wikimedia.org/T445609) (owner: 10Ejegg) [19:45:14] (03Merged) 10jenkins-bot: Remap all major gifts accounts to restricted on endowment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372492 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [19:45:27] (03Merged) 10jenkins-bot: Add gl_code to the batch detail export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372494 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [19:45:39] (03Merged) 10jenkins-bot: Set PayPal custom field for Braintree / paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1372159 (https://phabricator.wikimedia.org/T445609) (owner: 10Ejegg) [19:45:43] thanks wfan ! [19:51:06] (03PS3) 10Umherirrender: Replace use of setcookie() with WebResponse [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1372948 (https://phabricator.wikimedia.org/T420009) [19:51:40] (03PS4) 10Umherirrender: Replace use of setcookie() with WebResponse [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1372948 (https://phabricator.wikimedia.org/T420009) [20:00:54] (03PS5) 10Umherirrender: Replace use of setcookie() with WebResponse [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1372948 (https://phabricator.wikimedia.org/T420009) [20:04:19] (03CR) 10Umherirrender: "This was not tested via a browser, it now uses some site configs, but all should be overridden to keep the old behaviour." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1372948 (https://phabricator.wikimedia.org/T420009) (owner: 10Umherirrender) [20:12:23] (03PS3) 10Eileen: Add item_count to journal rows rather than parsing it from MEMO [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372495 (https://phabricator.wikimedia.org/T442668) [20:12:23] (03PS2) 10Eileen: Define the journal csv headers in FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372521 (https://phabricator.wikimedia.org/T442668) [20:12:23] (03PS2) 10Eileen: Add row_type to journal rows rather than parsing MEMO [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372522 (https://phabricator.wikimedia.org/T442668) [20:12:24] (03PS2) 10Eileen: Refactor - Add JournalWriter and move code relevant to outputting the csv journal files to that class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372523 (https://phabricator.wikimedia.org/T442668) [20:12:25] (03PS7) 10Eileen: Populate BatchFinancialBreakdown when generating batch journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) [20:19:58] (03CR) 10Eileen: Populate BatchFinancialBreakdown when generating batch journals (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [20:30:28] (03CR) 10Laurabarluzzi: [C:04-1] "@wfan@wikimedia.org Thanks for working on this, I think it is important to get this out after the recent conversations." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1364520 (https://phabricator.wikimedia.org/T429044) (owner: 10Wfan) [20:46:18] (03CR) 10Eileen: [C:03+2] Workplace giving trumps relationship manager for gl code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372895 (https://phabricator.wikimedia.org/T409994) (owner: 10Lars SG) [20:50:22] (03Merged) 10jenkins-bot: Workplace giving trumps relationship manager for gl code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372895 (https://phabricator.wikimedia.org/T409994) (owner: 10Lars SG) [20:53:19] (03PS1) 10Lars SG: Follow up on Define the journal csv headers in FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372957 (https://phabricator.wikimedia.org/T442668) [20:53:39] (03CR) 10Lars SG: [C:03+2] "Did a minor follow up: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1372957" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372521 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [20:55:08] (03CR) 10Lars SG: Define the journal csv headers in FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372521 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [20:55:58] (03PS1) 10Ejegg: Use location.replace when switching countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1372961 (https://phabricator.wikimedia.org/T444262) [20:56:22] wfan would that be an acceptable alternative for the back button issue? ^^^ [20:56:57] (03PS2) 10Lars SG: Follow up on Define the journal csv headers in FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372957 (https://phabricator.wikimedia.org/T442668) [20:57:12] also, is there a reason we don't have a credit card donation button any more? [20:57:19] (on combowiki) ? [20:57:40] (03CR) 10Lars SG: [C:03+2] "https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1372957" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372495 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [20:58:10] (03CR) 10CI reject: [V:04-1] Use location.replace when switching countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1372961 (https://phabricator.wikimedia.org/T444262) (owner: 10Ejegg) [20:58:47] oh weird, it shows up now [20:59:10] ah but not for US / USD [20:59:16] FIRING: HostHighCpuLoad: Host high CPU load (instance fransw1001.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostHighCpuLoad [21:00:28] huh, and canada gets a different google pay button than other countries [21:02:01] seeing a lot of vue warnings in those jest tests [21:02:35] (03Merged) 10jenkins-bot: Add item_count to journal rows rather than parsing it from MEMO [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372495 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [21:02:57] (03PS3) 10Lars SG: Follow up on Define the journal csv headers in FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372957 (https://phabricator.wikimedia.org/T442668) [21:04:16] RESOLVED: HostHighCpuLoad: Host high CPU load (instance fransw1001.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DHostHighCpuLoad [21:04:24] (03PS2) 10Ejegg: Use location.replace when switching countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1372961 (https://phabricator.wikimedia.org/T444262) [21:14:21] huh there's a jQuery effect handler happening someplace on the Vue page? [21:15:00] (03PS1) 10Lars SG: Write adjustment journals with the shared journal csv writer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372966 (https://phabricator.wikimedia.org/T442668) [21:15:13] (03CR) 10Lars SG: [C:03+2] "Little follow up: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1372966" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372521 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [21:20:03] (03Merged) 10jenkins-bot: Define the journal csv headers in FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372521 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [21:20:03] fr-tech it looks like my local gatewayByMethod has cc: dLocal [21:20:13] I think we really need to untangle that stuff [21:20:20] (03PS3) 10Eileen: Add row_type to journal rows rather than parsing MEMO [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372522 (https://phabricator.wikimedia.org/T442668) [21:20:33] are you all seeing a card button for US/USD ? [21:20:59] ah I have this: $wgDonationInterfaceComboWikiGateways = [ 'adyen', 'braintree', 'dlocal' ]; [21:21:08] but we shouldn't be preferring dlocal for cards! [21:21:14] at least in US [21:24:29] (03CR) 10Lars SG: [C:03+2] "This is a lot easier to parse!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372522 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [21:24:42] (03PS3) 10Eileen: Refactor - Add JournalWriter and move code relevant to outputting the csv journal files to that class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372523 (https://phabricator.wikimedia.org/T442668) [21:26:34] ohh i see wfan you were using replace [21:26:54] i saw that pageshow thing and I thought it was supposed to replace it [21:27:07] (03Abandoned) 10Ejegg: Use location.replace when switching countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1372961 (https://phabricator.wikimedia.org/T444262) (owner: 10Ejegg) [21:28:31] (03CR) 10Ejegg: Do not go back to donate page if back from forbidden view (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1370093 (https://phabricator.wikimedia.org/T444262) (owner: 10Wfan) [21:29:40] (03Merged) 10jenkins-bot: Add row_type to journal rows rather than parsing MEMO [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372522 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [21:29:51] (03CR) 10Lars SG: [C:03+2] Refactor - Add JournalWriter and move code relevant to outputting the csv journal files to that class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372523 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [21:32:32] (03PS4) 10Lars SG: Follow up on Define the journal csv headers in FinanceConstants [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372957 (https://phabricator.wikimedia.org/T442668) [21:32:32] (03PS2) 10Lars SG: Write adjustment journals with the shared journal csv writer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372966 (https://phabricator.wikimedia.org/T442668) [21:33:45] (03PS8) 10Eileen: Populate BatchFinancialBreakdown when generating batch journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) [21:34:43] (03Merged) 10jenkins-bot: Refactor - Add JournalWriter and move code relevant to outputting the csv journal files to that class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372523 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [21:38:48] (03PS5) 10Eileen: Record BatchFinancialBreakdown rows when generating adjustment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367936 (https://phabricator.wikimedia.org/T442668) [21:43:15] (03CR) 10Lars SG: [C:03+2] Populate BatchFinancialBreakdown when generating batch journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [21:48:52] (03Merged) 10jenkins-bot: Populate BatchFinancialBreakdown when generating batch journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367935 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [21:53:34] (03PS1) 10Lars SG: Strip the GL prefix from adjustment GL codes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372982 (https://phabricator.wikimedia.org/T442668) [21:53:47] (03CR) 10Lars SG: [C:03+2] "Small follow up: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1372982" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367936 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [22:00:16] (03Merged) 10jenkins-bot: Record BatchFinancialBreakdown rows when generating adjustment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1367936 (https://phabricator.wikimedia.org/T442668) (owner: 10Eileen) [22:07:06] (03CR) 10Lars SG: "Looks like the matching gift rows created by doBenevityWrangling wouldn't have the settlement fields, because they don't go through fixUpS" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1371618 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [22:16:38] (03PS2) 10Dmiranda: ComboWiki: show amount, currency and padlock on the donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1372369 (https://phabricator.wikimedia.org/T445289) [22:27:31] (03CR) 10Dmiranda: ComboWiki: show amount, currency and padlock on the donate button (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1372369 (https://phabricator.wikimedia.org/T445289) (owner: 10Dmiranda) [22:52:56] (03PS6) 10Eileen: Add WMFAudit.generateAdjustmentBatch to drive the correction through [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363897 (https://phabricator.wikimedia.org/T442975) [22:58:37] (03CR) 10CI reject: [V:04-1] Add WMFAudit.generateAdjustmentBatch to drive the correction through [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1363897 (https://phabricator.wikimedia.org/T442975) (owner: 10Eileen) [23:42:48] (03PS1) 10Lars SG: Don't use contact id if the donor is clearly not the contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1372991 (https://phabricator.wikimedia.org/T445701)