[02:36:31] https://youtu.be/foL0GUF_7yo [02:37:10] relevance? (re @Supun: https://youtu.be/foL0GUF_7yo) [14:54:12] Does anyone know when it is necessary to add `@wikimedia/codex` as a ResourceLoader dependency for an extension? This codesearch (https://codesearch.wmcloud.org/search/?q=%40wikimedia%2Fcodex&files=extension%5C.json&excludeFiles=&repos=) doesn't show nearly as many results as I would expect; and for most of the extensions in this search (https [14:54:12] //codesearch.wmcloud.org/search/?q=c [14:54:13] dx-mixin-css-icon&files=&excludeFiles=&repos=), it is not listed as a dependency. [14:56:28] for the second search, I think it makes some sense that they don’t all depend on codex, because less is compiled server-side anyway [14:56:55] they might need to `@import` some things in the less file but that would be independent of the resourceloader dependencies, I assume [14:59:06] any code that uses codex components at runtime has to at least call `mw.loader.using( '@wikimedia/codex' )`, I assume, as it needs to be able to access codex (it’s not registered as a global) [14:59:29] but I wouldn’t be totally surprised if there were some modules that forgot to add it to the resourceloader module definition [14:59:49] The MediaWiki.org page seems to suggest so. [14:59:51] You can loaf subsets which don't appear to need that particular loading phrase. [15:03:22] yeah, it's quite easy to forget for stuff that is loaded by many different things. also for us gadget/userscript developers, where you're suddenly like "oh, mediawiki.util isn't loaded in this or that context" (re @lucaswerkmeister: but I wouldn’t be totally surprised if there were some modules that forgot to add it to the resourceloader module definition) [15:06:21] yeah, i found that page (https://www.mediawiki.org/wiki/Codex), but it confused me more than it enlightened me 😂 (re @lcawte: The MediaWiki.org page seems to suggest when you load subsets of Codex instead of the whole lot, you can get away without that p...) [15:07:24] the context for the question is that i have a series of patches for the Translate extension to enable dark mode for it properly. And in the latest set of patches, I'm replacing icons with Codex CSS icon mixins (i.e. the second codesearch I linked), and I'm wondering whether or not i need to add a dependency [15:46:29] Wikipedia.org is not changeable by a user huh. https://gitlab.com/fdroid/fdroiddata/-/merge_requests/16068#note_2182770940 [16:09:08] yeah, fdroid doesn't like Wikipedia apps, they want MediaWiki apps. [16:09:50] well that wording needs work. anyone can edit! [16:10:27] they previously tagged the WMF Wikipedia app as having a non-free network service for that reason, but they've since created a more-specific anti-feature for it [16:14:01] I wasn't finding that app I just linked in search, mentioned something was hidden because antifeature. clicked to go to antifeature prefs and didn't take me directly there, I then had to figure which menu in prefs and then everything was already checked except the on this app uses which I guess is the same you're talking about for official app. tethered network [16:14:01] services. official [16:14:03] app uses the same language not changeable by a user. (re @wmtelegram_bot: they previously tagged the WMF Wikipedia app as having a non-free network service for that reason, but they've s...) [19:00:22] Yeah, if you're in an extension (not a gadget), and define your RL module as [19:00:22] *class*`: "MediaWiki\\ResourceLoader\\CodexModule", [19:00:24] `*codexComponents: *`["CdxButton", ..] [19:00:25] Then you `don't need a dependency. Instead, the CodexModule class takes care of copying small portions of codex into your module. (re @lcawte: The MediaWiki.org page seems to suggest when you load subsets of Codex instead of the whole lot, you can get away without that p...) [20:56:58] Ok, and specify each icon I've used there then? [20:56:58] Is it ok if i add you in cc on the relevant patch, so you can check if that part of it is correct? Not sure how to properly test those things myself, to be honest (re @Krinkle24: Yeah, if you're in an extension (not a gadget), and define your RL module as [20:57:00] class: "MediaWiki\\ResourceLoader\\CodexModule", [20:57:01] ...) [21:49:35] Sure! (re @jhsoby: Ok, and specify each icon I've used there then? [21:49:36] Is it ok if i add you in cc on the relevant patch, so you can check if that pa...)