[09:24:12] I'm having a test failure I don't quite understand in this change (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaIncubator/+/1115451?tab=checks): [09:24:14] 10:20:08 includes/WikimediaIncubator.php:516 PhanTypeMismatchArgumentNullableInternal Argument 2 ($haystack) is $wmincTestWikiNamespaces of type ?non-empty-array but \in_array() takes array (expected type to be non-nullable) [09:24:15] The variable is supposed to always be a variable (and it could be empty), so I don't understand why it says its type is "`?non-empty-array`" (which I've never come across until now). Does anyone have any pointers? [09:36:45] basically what that error message is saying that $wmincTestWikiNamespaces could be null but in_array() does not take nulls [09:38:36] which is indicated by the question mark in front of the type [09:39:38] (the rest is phan figuring out what the array contents are, here it thinks that if the variable is not null then it'll be a non-empty array) [09:41:24] taavi: mhm, makes sense. But how can i make it non-nullable? It's a global variable, so it's not defined within that function [11:00:08] `!in_array( $ns, $wmincTestWikiNamespaces ?? [] )` would probably make phan happy [11:00:19] or suppress the error [11:00:28] not sure what makes more sense here tbh [11:06:37] thanks! I'll try this one first (re @lucaswerkmeister: !in_array( $ns, $wmincTestWikiNamespaces ?? [] ) would probably make phan happy)