[08:11:59] How to solve `PhanUndeclaredClass*` errors reported by CI? [08:45:20] Is it `\Title` or `\Config` or one of the others that's recently been removed? [08:50:26] Where (re @freosam: Is it \Title or \Config or one of the others that's recently been removed?) [08:51:53] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/1134118/3 [08:52:08] Didn’t remember that I removed any (re @freosam: Is it \Title or \Config or one of the others that's recently been removed?) [09:11:49] no, ignore me! It looks like you're moving classes around the place... I'd guess it can't find them any more? [09:14:23] Instead I massively did so (re @freosam: no, ignore me! It looks like you're moving classes around the place... I'd guess it can't find them any more?) [09:14:39] Moved almost everything [09:15:04] Which file should I update (re @freosam: no, ignore me! It looks like you're moving classes around the place... I'd guess it can't find them any more?) [09:17:08] Why are you moving things from `src/` into `domains/crud/src/`? It sort of looks like you're actually trying to move to `src/Domains/Crud/` [09:17:26] Although I don't really know what your goal is, so I might not be looking at things right! [09:17:36] Look at directory structure in Wikibase extension (re @freosam: Why are you moving things from src/ into domains/crud/src/? It sort of looks like you're actually trying to move to src/Domains/...) [09:17:49] I’m implementing such structures (re @cvictorovich: Look at directory structure in Wikibase extension) [09:18:25] That’s for making my way to implement RESTful [09:19:46] Sorry, not sure where to look in Wikibase, I can't see any Crud namespace [09:21:07] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master (re @freosam: Sorry, not sure where to look in Wikibase, I can't see any Crud namespace) [09:21:48] Modeling WikibaseLexeme after this structure (re @cvictorovich: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master) [09:42:02] Which bit of it though? The repo or the client, or something else? [09:44:18] But either way, it doesn't look like you should be moving files into a `domains/` top level directory. Surely that should go in `src/`? [09:45:51] https://doc.wikimedia.org/Wikibase/master/php/repo_domains_crud_README.html describes it pretty well I think [11:00:26] Where should `includes/` be located? (re @freosam: https://doc.wikimedia.org/Wikibase/master/php/repo_domains_crud_README.html describes it pretty well I think) [11:00:48] Not documented here! [11:02:24] It uses `src/` (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseLexeme/+/refs/heads/master/src/) rather than `includes/` [11:05:06] No no I didn't make myself clear [11:05:44] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master/repo/includes/ [11:06:11] WL is repo itself [11:21:15] So Wikibase uses `includes/` and WikibaseLexeme uses `src/` β€” it's fine for them to be different. [12:01:02] But if I'm going to implement RESTful... [22:50:34] Forwarded from π“π‘π”πŒπ π€πˆπ‘πƒπ‘πŽπ: *🌐**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️** [22:50:34] γ…€ [22:50:36] **πŸ†•** **❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️** [22:50:37] **✨**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️** [22:50:39] **✨**❗️**❗️**❗️**❗️**❗️**❗️**❗️** [22:50:40] **πŸ”₯**➑️**@DropTrumpBot** [22:50:42] **πŸ”—**➑️**@DropTrumpBot** [22:50:43] **πŸ”₯**➑️**@DropTrumpBot** [22:50:45] **✨**❗️**❗️**❗️**❗️**❗️**❗️** [22:50:46] **✨**❗️**❗️**❗️**❗️**❗️**❗️**❗️**❗️*