[09:12:17] <brouberol>	 claime: I've deployed the noc envoy config and I'm now getting 503 responses from envoy. _scratches head_
[09:13:19] <brouberol>	 I wonder if I have to explicitly define the upstream to `mw-misc.discovery.wmnet`  
[09:17:57] <brouberol>	 Ok, seems like I need `sets_sni: true` AND `http_host: noc.wikimedia.org`
[09:18:02] <brouberol>	 >>> requests.get("http://envoy:6509/conf/dblists/open.dblist")
[09:18:03] <brouberol>	 <Response [200]>
[09:30:16] <claime>	 uhhhh
[09:30:18] <jayme>	 Sorry...I was wondering about that as well
[09:30:22] <claime>	 how
[09:30:40] <jayme>	 because without, envoy will not send SNI to upstream
[09:30:53] <claime>	   79   │               <%- if @listener['sets_sni'] && !@listener['http_host'] -%>
[09:31:03] <claime>	 ah so no auto_host_rewrite
[09:31:06] <jayme>	 but as you said you tested that config I refraing LD
[09:31:19] <jayme>	 *refrained
[09:31:23] <claime>	 aaaah
[09:31:40] <claime>	 ok there's another bit of the config in modules/profile/templates/services_proxy/envoy_service_cluster.yaml.erb
[09:31:49] <jayme>	 I think there is a block down somwhere where envoy set's sni: Upstream.address
[09:31:50] <claime>	 that I didn't change when testing manually
[09:38:25] <jayme>	 ah, makes sense
[10:24:41] <brouberol>	 I'm glad it makes sense for you. I feel like the labrador in the <no-idea-what-im-doing.jpg> meme
[10:24:41] <claime>	 I think we could even get away with sets_sni in the transport_socket config, and nothing in the route
[10:24:41] <claime>	 letting the caller specify the host
[10:24:55] <claime>	 (not possible right now, it's either http_host that forces you into a host, or auto_host_rewrite that rewrites the header to the sni value)
[10:28:08] <brouberol>	 unrelated, but I'm seeing the following error message when running puppet on the deployment server
[10:28:08] <brouberol>	 Error: Could not update: undefined method `strip' for nil:NilClass
[10:28:08] <brouberol>	 Error: /Stage[main]/K8s::Client/K8s::Package[kubectl-1.31]/Package[kubernetes-client131]/ensure: change from 'purged' to '>=1.31 <1.32' failed: Could not update: undefined method `strip' for nil:NilClass
[10:28:22] <brouberol>	 it does not seem to prevent puppet from running to completion
[10:32:23] <jayme>	 brouberol: that's me - revert is just coming in
[10:39:46] <brouberol>	 👍