[07:29:56] elukey: I can take care of the spark-history and superset deployment, now that you've merged the vendored modules upgrade [07:31:16] brouberol: <3 thanks! The idea is indeed that regular deployments should pick up the change [07:31:28] otherwise redeploying everything would take ages [07:31:53] yep! However, superset and spark-history are very seldomly redeployed, so I'd rather I do it now [07:38:10] oh and for growthbook, I think you need to update the vendors in each subchart, and not the chart itself, hence the CI -1 [07:41:57] yeah this is what I did :) The issue seems to be that we have "configmap.yml" vs "configmap.yaml", and the resourcechecksum template doesn't like it [07:42:00] I just fixed it [07:42:32] thanks for the deployments! [07:42:42] is growthbook something that your team manages as well? [07:42:53] I don't know what its status is to be honest [07:48:07] so, long term, yes [07:48:35] right now, it is in a state of PoC. It is the statistical analysis platform for the A/B testing Experimentation Platform tooling [07:48:50] but AFAIK, it is not used _yet_ [07:48:52] is it deployed somewhere? [07:49:17] on dse-k8s-eqiad [07:49:25] okok makes sense [07:49:41] added you to the CR then :) [07:50:02] this round of mesh upgrades involved ~45 code reviews [07:50:15] ah, it seems that the change breaks spark-history, as we rely on some app.env_from stanza in the values, that seems to not be supported anymore [07:50:20] with sextant and some git automation it wasn't super difficult, but maybe long-term we want something more streamlined [07:50:32] snap :( [07:50:32] causing some env variables to not be defined causing the JVM to crash [07:50:45] no biggie, I can adjust the chart [07:50:52] thanks a lot and sorry [07:51:21] np [07:52:41] hahaha it's not your fault it's mine [07:52:51] I _think_ I added the functionality in our vendored template at the time [07:52:56] I was young and foolish [07:53:23] I think I'm due to add it to the modules and upgrade app.generic in spark-history [07:53:31] can I assign you as reviewer? [07:56:14] heads up: Since I'm unable to reproduce locally I've merged the CI change (slightly more verbose version) again that led to some CI failures yesterday [07:56:46] so if you experience CI errors (rake tracebacks), please let me know (as I'm also unable to reproduce the issue in CI) [07:56:55] brouberol: sure! [08:02:33] there we go https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1146499 [08:09:13] {{done}} [08:12:51] aaand fixed [08:12:51] spark-history-analytics-test-hadoop-66c44d895b-jpqdf 3/3 Running 0 30s [08:14:32] thanks again [08:14:57] nice!