[17:20:05] Hello. I have created this patch for the `mesh.configuration` module: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1202755 [17:21:55] I'd appreciate any feedback. It's meant to be a minimal way to allow us to insert another reverse-proxy (e.g. oauth2-proxy) in between the envoyproxy container and the main app container. [17:47:29] btullis: totally not necessary this time, but, one note for ease of review next time -- a common idiom in deployment-charts/modules/ is to do the cp old->new in one commit, and then edit new in another commit [17:52:42] cdanis: Ah, that makes perfect sense. I can go back and redo it, if it helps. This is my first module change. [17:52:48] no it's fine :) [17:55:54] +1 [18:00:11] Nice one, thanks. [18:33:33] Ah, the first time I tried to vendor it into a chart, I got this: `sextant.dependency.DependencyError: Module mesh.configuration:1.15.0 is incompatible with module mesh.configuration:1.14.5 (required by mesh.name:1.1.0)` [18:34:51] I guess I should have updated the `mesh.name` module as well. [18:48:51] I'm out of time today and out tomorrow, but I'll pick this up on Monday. Feel free to revert if this causes any issues.