[13:46:08] inflatador: left a comment and some questions, lemme know! [14:25:34] jayme: I'd love a review on this, if you get a chance. Thanks. https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1265434 [14:26:58] I approved, as it looks good, at least to my unattuned eyes [14:31:33] brouberol: I'll take a look in a minute [14:37:57] oopsie :) [14:38:01] btullis: I took a look :D [14:39:00] Doh! Thanks. I remember doing that before, thinking that they were additive. [14:39:04] there you go. I should always wait for jayme's review before saying anything else [14:41:28] I pushed another version. [15:00:55] Uff! It's now failing CI with a seemingly unrelated error: `Listener mw-parsoid not found in the proxies` [15:01:37] ah, yes, see #-sre [15:02:48] it was just removed [15:02:54] ty [15:02:58] IIRC it needs to be removed from https://gerrit.wikimedia.org/r/plugins/gitiles/operations/deployment-charts/+/045330da430713b0ace9c568131f411d26313f28/.fixtures/service_proxy.yaml as well [15:08:48] let me submit a patch, and you'll be able to rebase onto master afterwards [15:13:53] I _think_ this should fix it https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1265452 [15:14:25] brouberol: lgtm [15:15:04] merged. btullis I rebased your patch onto master. Let's see [15:23:15] 17:22:38 Finished: SUCCESS [15:45:17] elukey very much appreciated, will take a look today