[12:57:29] <btullis>	 Would anyone from this highly-regarded group be so very kind as to help me out with a review of an upstream helm chart, please? It's for T429331 and https://wikitech.wikimedia.org/wiki/Helm/Upstream_Charts/topolvm 
[12:57:30] <stashbot>	 T429331: Import and adapt the upstream TopoLVM Helm chart - https://phabricator.wikimedia.org/T429331
[12:58:01] <btullis>	 I'll get straight on and prepare the gerrit patch stack.
[14:09:10] <jayme>	 btullis: do you have a timeline? Feel free to also add this to the aganda for the next SIG meeting if you don't have a volunteer by then
[15:12:59] <btullis>	 Thanks jayme. As usual, the timeline is just asap. It's hopefully a /strategic/ direction thing for the Data Platform, but the immediate use-case (where I'm trying to demonstrate value of the approach) is the WDQS rewrite: T424340
[15:19:47] <jayme>	 okay...I definitely dont have the capacity this week and I'm more a 'maybe' for the next 2 as well. It's the end of the FY as you know...worst possible time for a "just asap" timeline :)
[15:28:58] <btullis>	 Yes, fully understood. And thanks. I will try not to increase your workload.
[15:32:23] <cdanis>	 btullis: dare I ask, how large is the chart?
[15:37:08] <brouberol>	 cdanis: it's mostly whitespace, so very small /s
[15:38:50] <brouberol>	 and more seriously: as charts go, it's not trivial. About 30 yaml files. Pretty similar to ceph-csi
[15:40:12] <brouberol>	 _usually_ most of the review revolves around realizing that the devs were lazy and used a ClusteRole to grant access to all secrets in all namespaces because who needs an explicit list of tenant namespaces
[15:40:38] <brouberol>	 and we then re-implement this into a loop over roles and rolebindings
[15:41:11] <brouberol>	 and lo-and-behold https://github.com/topolvm/topolvm/blob/topolvm-chart-v15.7.1/charts/topolvm/templates/controller/clusterroles.yaml#L3