[02:19:30] 06Machine-Learning-Team: vscode remote ssh into ml-lab freezes - https://phabricator.wikimedia.org/T377067#10257298 (10calbon) I tested this with vscode and cursor today. Both seem to work. I wonder if the install time was just really long {F57638262} I will check once more tomorrow just to be certain and then... [05:29:28] 10Lift-Wing, 06Machine-Learning-Team, 13Patch-For-Review: [langid] fasttext only processes one line at a time - https://phabricator.wikimedia.org/T377751#10257642 (10kevinbazira) We noticed that keeping only alphanumeric characters removes spaces and punctuation marks which changes the prediction results as... [06:05:00] (03PS4) 10Kevin Bazira: langid: normalize text input [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1082438 (https://phabricator.wikimedia.org/T377751) [06:08:10] (03CR) 10CI reject: [V:04-1] langid: normalize text input [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1082438 (https://phabricator.wikimedia.org/T377751) (owner: 10Kevin Bazira) [06:11:03] (03PS5) 10Kevin Bazira: langid: normalize text input [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1082438 (https://phabricator.wikimedia.org/T377751) [06:17:57] (03CR) 10Kevin Bazira: langid: normalize text input (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1082438 (https://phabricator.wikimedia.org/T377751) (owner: 10Kevin Bazira) [07:12:39] good morning folks o/ [07:14:54] (03CR) 10Ilias Sarantopoulos: [C:03+1] langid: normalize text input (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1082438 (https://phabricator.wikimedia.org/T377751) (owner: 10Kevin Bazira) [07:41:55] kevinbazira: o/ feel free to merge and deploy the patch [07:42:23] only Tobias's comment is left but I understand that he is ok with that [07:42:47] isaranto: o/ great. thanks for the review! [07:43:49] (03CR) 10Kevin Bazira: [C:03+2] "Thanks for the reviews :)" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1082438 (https://phabricator.wikimedia.org/T377751) (owner: 10Kevin Bazira) [07:44:31] (03Merged) 10jenkins-bot: langid: normalize text input [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1082438 (https://phabricator.wikimedia.org/T377751) (owner: 10Kevin Bazira) [07:46:30] the langid is a pretty standard scenario that should be captured by a unit test. we can discuss about it next week to see how we can increase coverage and find a nice way to unit test kserve [08:06:26] agreed! I've pushed a patch that updates langid's deployment configs: https://gerrit.wikimedia.org/r/1082704 [08:18:42] I just merged it! [08:20:47] super! going to deploy now ... [08:36:46] 10Lift-Wing, 06Machine-Learning-Team: [langid] fasttext only processes one line at a time - https://phabricator.wikimedia.org/T377751#10257910 (10kevinbazira) The new langid image with a model-server that normalizes text input has been deployed : `bash # pod running in eqiad kevinbazira@deploy2002:~$ kube_env... [08:37:55] the new new langid model-server is up and running on LW --^ [08:50:26] noicee [09:16:59] 06Machine-Learning-Team, 06serviceops, 10Data-Platform-SRE (2024.10.19 - 2024.11.08), 07Security: Migrate the ownership of DPE-Owned Docker images in production-images repo to mailing lists - https://phabricator.wikimedia.org/T373534#10258028 (10BTullis) a:03BTullis [11:05:49] (03CR) 10Nik Gkountas: [C:04-1] "Looks good overall, but a fix is required. Per my testing, random `gsrsort` would be enough to randomize the results, but let's also `gsrq" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1081237 (https://phabricator.wikimedia.org/T377124) (owner: 10Sbisson) [11:14:16] (03CR) 10Nik Gkountas: [C:03+2] Filter out disambiguation pages from search API response [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1081236 (owner: 10Sbisson) [11:15:48] (03Merged) 10jenkins-bot: Filter out disambiguation pages from search API response [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1081236 (owner: 10Sbisson) [11:21:10] (03PS8) 10Nik Gkountas: Initialize campaign cache and update it every 1 hour [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1075974 [11:21:15] (03PS8) 10Nik Gkountas: Use category search to find campaign pages instead of template [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) [11:21:19] (03PS4) 10Nik Gkountas: Replace "campaign" term with "collection" or "page_collection" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1079467 [11:21:24] (03PS18) 10Nik Gkountas: Fetch campaign metadata and return them with recommendations [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1070308 (https://phabricator.wikimedia.org/T373132) [11:21:28] (03PS12) 10Nik Gkountas: Support Default collections [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1072175 (https://phabricator.wikimedia.org/T374597) (owner: 10Santhosh) [11:21:52] (03CR) 10Nik Gkountas: Support Default collections (031 comment) [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1072175 (https://phabricator.wikimedia.org/T374597) (owner: 10Santhosh) [11:34:44] 06Machine-Learning-Team, 06serviceops, 10Data-Platform-SRE (2024.10.19 - 2024.11.08), 07Security: Migrate the ownership of DPE-Owned Docker images in production-images repo to mailing lists - https://phabricator.wikimedia.org/T373534#10258290 (10BTullis) 05Open→03Resolved I have set the ownership o... [12:34:06] (03PS4) 10Sbisson: Tweak gsrqiprofile and gsrsort for better search results variety [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1081237 (https://phabricator.wikimedia.org/T377124) [12:34:19] (03CR) 10Sbisson: Tweak gsrqiprofile and gsrsort for better search results variety (031 comment) [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1081237 (https://phabricator.wikimedia.org/T377124) (owner: 10Sbisson) [12:35:43] (03CR) 10CI reject: [V:04-1] Tweak gsrqiprofile and gsrsort for better search results variety [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1081237 (https://phabricator.wikimedia.org/T377124) (owner: 10Sbisson) [12:38:40] (03CR) 10Sbisson: "recheck" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1081237 (https://phabricator.wikimedia.org/T377124) (owner: 10Sbisson) [12:39:49] 06Machine-Learning-Team, 10Add-Link, 10Growth-Scaling, 06Growth-Team: Establish processes for running the dataset pipeline - https://phabricator.wikimedia.org/T276438#10258492 (10MGerlach) >>! In T276438#10247742, @Michael wrote: > Growth is working on surfacing link-recommendations in new ways (T362584),... [13:07:57] (03CR) 10Nik Gkountas: [C:03+2] Tweak gsrqiprofile and gsrsort for better search results variety [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1081237 (https://phabricator.wikimedia.org/T377124) (owner: 10Sbisson) [13:08:35] (03Merged) 10jenkins-bot: Tweak gsrqiprofile and gsrsort for better search results variety [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1081237 (https://phabricator.wikimedia.org/T377124) (owner: 10Sbisson) [13:17:11] 06Machine-Learning-Team, 10Add-Link, 10Growth-Scaling, 06Growth-Team: Establish processes for running the dataset pipeline - https://phabricator.wikimedia.org/T276438#10258644 (10Michael) >>! In T276438#10258492, @MGerlach wrote: > [...] > @Michael I am curious to understand your use-case better: Are you... [13:39:36] (03PS9) 10Nik Gkountas: Initialize campaign cache and update it every 1 hour [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1075974 [13:39:46] FIRING: ErrorBudgetBurn: liftwing - liftwing-articlequality-latency - https://wikitech.wikimedia.org/wiki/Monitoring/ErrorBudgetBurn - https://alerts.wikimedia.org/?q=alertname%3DErrorBudgetBurn [13:56:04] ml-etcd1002 will go down for a minute or so (reboot of Ganeti node) [14:34:12] :+1: [14:56:31] 06Machine-Learning-Team, 06SRE, 10SRE-Access-Requests, 10LPL Essential (LPL Essential 2024 Jul-Sep): Access to deploy recommendation API ML service for kartik - https://phabricator.wikimedia.org/T376585#10259119 (10calbon) Approved @MoritzMuehlenhoff [15:01:11] (03PS9) 10Nik Gkountas: Use category search to find campaign pages instead of template [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) [15:05:25] (03CR) 10Sbisson: "Looks very good. Just some questions/suggestions inline." [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1075974 (owner: 10Nik Gkountas) [15:09:13] 06Machine-Learning-Team, 06SRE, 10SRE-Access-Requests, 10LPL Essential (LPL Essential 2024 Jul-Sep): Access to deploy recommendation API ML service for kartik - https://phabricator.wikimedia.org/T376585#10259181 (10isarantopoulos) From the ML side we suggest to proceed with providing @KartikMistry access s... [15:09:39] (03CR) 10Sbisson: Use category search to find campaign pages instead of template (031 comment) [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) (owner: 10Nik Gkountas) [15:40:19] 06Machine-Learning-Team: vscode remote ssh into ml-lab freezes - https://phabricator.wikimedia.org/T377067#10259483 (10calbon) I checked again this morning. Cursor and VSCode work fine. Reading the VS Code forum, I think there was an update in 0.41 that fixed the issue. [15:41:05] 06Machine-Learning-Team: vscode remote ssh into ml-lab freezes - https://phabricator.wikimedia.org/T377067#10259484 (10calbon) 05Open→03Resolved [16:21:30] going afk folks , have a nice evening o/ [17:03:57] (03CR) 10Sbisson: [C:03+2] Use category search to find campaign pages instead of template [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) (owner: 10Nik Gkountas) [17:11:40] (03CR) 10Sbisson: [C:03+2] "I will make a follow up to discuss some of the questions I have here. This is good to go. Nicely done!" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1075974 (owner: 10Nik Gkountas) [17:12:21] (03Merged) 10jenkins-bot: Initialize campaign cache and update it every 1 hour [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1075974 (owner: 10Nik Gkountas) [17:49:08] (03CR) 10Sbisson: Use category search to find campaign pages instead of template [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) (owner: 10Nik Gkountas) [17:49:19] (03PS10) 10Nik Gkountas: Use category search to find campaign pages instead of template [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) [17:49:42] (03CR) 10Sbisson: [C:03+2] Use category search to find campaign pages instead of template [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) (owner: 10Nik Gkountas) [17:51:25] (03CR) 10CI reject: [V:04-1] Use category search to find campaign pages instead of template [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) (owner: 10Nik Gkountas) [17:53:00] (03CR) 10Sbisson: "recheck" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) (owner: 10Nik Gkountas) [17:57:11] (03CR) 10Sbisson: [C:03+2] Use category search to find campaign pages instead of template [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) (owner: 10Nik Gkountas) [17:57:50] (03Merged) 10jenkins-bot: Use category search to find campaign pages instead of template [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1076020 (https://phabricator.wikimedia.org/T373132) (owner: 10Nik Gkountas) [17:59:24] (03PS5) 10Sbisson: Replace "campaign" term with "collection" or "page_collection" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1079467 (owner: 10Nik Gkountas) [18:21:21] (03CR) 10Sbisson: [C:04-1] "A whole lot of renaming done here. I could spot only 2 other things that could be updated." [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1079467 (owner: 10Nik Gkountas) [18:28:40] (03PS19) 10Nik Gkountas: Fetch campaign metadata and return them with recommendations [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1070308 (https://phabricator.wikimedia.org/T373132) [18:29:06] (03PS13) 10Nik Gkountas: Support Default collections [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1072175 (https://phabricator.wikimedia.org/T374597) (owner: 10Santhosh) [18:37:13] (03PS6) 10Sbisson: Replace "campaign" term with "collection" or "page_collection" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1079467 (owner: 10Nik Gkountas) [18:37:51] (03CR) 10Sbisson: Replace "campaign" term with "collection" or "page_collection" (032 comments) [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1079467 (owner: 10Nik Gkountas) [18:38:08] (03CR) 10Sbisson: [C:03+2] Replace "campaign" term with "collection" or "page_collection" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1079467 (owner: 10Nik Gkountas) [18:38:53] (03Merged) 10jenkins-bot: Replace "campaign" term with "collection" or "page_collection" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1079467 (owner: 10Nik Gkountas) [20:36:45] 10Lift-Wing, 06Machine-Learning-Team, 07OKR-Work: Request to host article-country model on Lift Wing - https://phabricator.wikimedia.org/T371897#10260689 (10Isaac) Hey @kevinbazira -- I just discovered a failure mode in my original code. When an item lacks a Wikidata item, an exception gets thrown that isn'...