[08:44:55] 10Lift-Wing, 06Machine-Learning-Team: Fix duplicate wikidata-related predictions and omitted category-related predictions - https://phabricator.wikimedia.org/T387275 (10kevinbazira) 03NEW [09:30:25] morning folks [09:39:30] (03PS1) 10Gkyziridis: inference-services: trigger again ci [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122903 (https://phabricator.wikimedia.org/T386100) [09:42:47] (03CR) 10Gkyziridis: [C:03+2] inference-services: trigger again ci [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122903 (https://phabricator.wikimedia.org/T386100) (owner: 10Gkyziridis) [09:43:04] (03CR) 10Gkyziridis: [V:03+2 C:03+2] inference-services: trigger again ci [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122903 (https://phabricator.wikimedia.org/T386100) (owner: 10Gkyziridis) [09:44:56] (03PS1) 10Kevin Bazira: article-country: fix duplicate wikidata-related predictions and omitted category-related predictions [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122904 (https://phabricator.wikimedia.org/T387275) [09:45:43] (03CR) 10Gkyziridis: "recheck" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122903 (https://phabricator.wikimedia.org/T386100) (owner: 10Gkyziridis) [09:48:29] (03PS2) 10Kevin Bazira: article-country: fix duplicate wikidata-related predictions and omitted category-related predictions [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122904 (https://phabricator.wikimedia.org/T387275) [09:52:20] Folks o/ [09:53:28] https://www.irccloud.com/pastebin/zFg3PcF7/ [09:53:44] Do you have any idea ? [09:56:06] georgekyz: o/ seems weird, but one suggestion that I can give is to avoid V:+2 [09:56:11] it will be done by CI when ready [09:56:33] everything should work anyway, not sure if in this case there was a race condition [09:57:12] oh ok... I just wanted to merge it quickly that's why I did V:+2 [09:57:24] I forced a restart of the same job https://integration.wikimedia.org/ci/job/inference-services-pipeline-edit-check-publish/2/console [09:57:30] and it worked [09:58:15] you should have the tag now [09:58:19] lemme know if it works [09:58:25] yes thnx a lot! [09:59:08] morning! [10:03:32] 早上好 [10:20:01] 10Lift-Wing, 06Machine-Learning-Team, 13Patch-For-Review: Fix duplicate wikidata-related predictions and omitted category-related predictions - https://phabricator.wikimedia.org/T387275#10582000 (10kevinbazira) Below is the production example response after a fix has been applied.: 1. **Double-Counting Count... [10:24:08] (03CR) 10Kevin Bazira: "this patch has been tested as shown in: https://phabricator.wikimedia.org/T387275#10582000" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122904 (https://phabricator.wikimedia.org/T387275) (owner: 10Kevin Bazira) [10:28:56] georgekyz: :D [11:26:24] (03PS1) 10Gkyziridis: inference-services: Add json lib and comment out some missing parts. [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122922 (https://phabricator.wikimedia.org/T386100) [11:31:10] (03CR) 10Gkyziridis: [C:03+1] inference-services: Add json lib and comment out some missing parts. [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122922 (https://phabricator.wikimedia.org/T386100) (owner: 10Gkyziridis) [14:16:30] hey folks! [14:16:59] I just merged https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1122636, that should be a ok-change for production, but to be super safe please ping me if you have to deploy something that contains a securityContext change [14:17:48] 10Lift-Wing, 06Machine-Learning-Team, 13Patch-For-Review: Fix duplicate wikidata-related predictions and omitted category-related predictions - https://phabricator.wikimedia.org/T387275#10583024 (10Isaac) Thanks! Looks like it should fix the first two bugs but the other two bugs (`Items that have a property... [14:25:27] very nice, there is some issue in staging (goodfaith), need to jump to a meeting but please don't deploy to prod yet, I may need to revert [14:25:44] for some reason runAsNonRoot is not set by knative [14:25:46] * elukey sigh [14:27:12] ack [15:03:56] 10Lift-Wing, 06Machine-Learning-Team, 13Patch-For-Review: Fix duplicate wikidata-related predictions and omitted category-related predictions - https://phabricator.wikimedia.org/T387275#10583367 (10kevinbazira) Yes, this aims to fix the first two bugs you reported. After it's merged and tested, we'll fix the... [15:15:25] ah! [15:15:25] https://github.com/knative/serving/pull/14363 [15:15:32] Add runAsNonRoot to secure-pod-defaults [15:15:44] all right this is the issue, a patch is missing [15:19:17] 10Lift-Wing, 06Machine-Learning-Team, 13Patch-For-Review: Fix duplicate wikidata-related predictions and omitted category-related predictions - https://phabricator.wikimedia.org/T387275#10583443 (10Isaac) Works for me - thanks @kevinbazira ! [15:20:38] ok so I think we can probably revert for the moment [15:21:25] https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1122974 [15:26:38] ack, +1'd [15:44:21] hey! Is there a way to contact the team privately? The email ml@wikimedia.org isn't accepting my message [15:46:50] probably the internal slack chan is the quickest [15:47:03] I'm not internal? [15:50:58] groceryheist: hiii! Sorry I misread the nick, it started with g and I confused it! [15:51:16] I don't recall what happened with ml@, maybe klausman knows [15:51:37] worst case you can probably send an email to Ilias or Chris [15:59:02] I'll have a look at ml@, but I am not aware of it having been disabled. [16:12:05] I got the "We're writing to let you know that the group you tried to contact (ml) may not exist, or you may not have permission to post messages to [16:12:07] the group. A few more details on why you weren't able to post: [16:12:09] " [16:12:17] message from mailer-daemon@googlemail.com [16:12:30] thank you for looking into it [16:29:56] ah, yes, so this is an "internal" group in the sense that only WMF people can post to it. I'll float the idea of allowing external posting in our next meeting (or sooner). For now raising issues here or on Phab is probably the best approach. [18:24:12] (03CR) 10AikoChou: "I only have one question to better understand the code logic" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1122904 (https://phabricator.wikimedia.org/T387275) (owner: 10Kevin Bazira)