[06:32:57] <hashar>	 Krinkle: that comes from duesene
[06:35:06] <hashar>	 well Daniel
[06:35:47] <hashar>	 the aim is/was to replace the global `$wgWikimediaJenkinsCI` I guess as part of the refactoring of MediaWiki core config
[06:37:46] <hashar>	 the counter part in mediawiki is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/764849 Allow LocalSettings.php to be loaded in function scope.
[06:38:00] <hashar>	 I guess I have discussed about using a defined versus a getenv
[06:38:28] <hashar>	 and since that is only set by Quibble which already generates a LocalSettings.php snippet it makes sense to make it a constant
[06:39:02] <hashar>	 that also mean that when pointing Apache/php-fpm to the installed MediaWiki, the constant is loaded and available to the mediawiki code
[06:39:29] <hashar>	 without having to set the environment variable in apache config
[06:40:55] <hashar>	 of course later that got also exported as an environment variable for the purpose of running MediaWiki unit tests (which don't load LocalSettings.php): https://gerrit.wikimedia.org/r/c/integration/quibble/+/896084
[06:42:31] <hashar>	 in practice the environment variable is not used anywhere
[06:42:56] <hashar>	 and `$wgWikimediaJenkinsCI` is still used :D
[21:31:36] <wikibugs>	 (03PS1) 10Subramanya Sastry: Fix Parsoid CI after changes to use phpunit directly [integration/quibble] - 10https://gerrit.wikimedia.org/r/938010 (https://phabricator.wikimedia.org/T90875)
[21:33:09] <wikibugs>	 (03CR) 10Subramanya Sastry: "Not sure if this is the right fix, but a variant of this seems to work locally." [integration/quibble] - 10https://gerrit.wikimedia.org/r/938010 (https://phabricator.wikimedia.org/T90875) (owner: 10Subramanya Sastry)
[21:35:24] <wikibugs>	 (03PS2) 10Subramanya Sastry: Fix Parsoid CI after changes to use phpunit directly [integration/quibble] - 10https://gerrit.wikimedia.org/r/938010 (https://phabricator.wikimedia.org/T90875)
[21:48:44] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Fix Parsoid CI after changes to use phpunit directly [integration/quibble] - 10https://gerrit.wikimedia.org/r/938010 (https://phabricator.wikimedia.org/T90875) (owner: 10Subramanya Sastry)
[22:10:57] <wikibugs>	 (03PS1) 10Daimona Eaytoy: Run PHPUnit unit tests after installing MediaWiki [integration/quibble] - 10https://gerrit.wikimedia.org/r/938012 (https://phabricator.wikimedia.org/T227900)
[22:13:07] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Run PHPUnit unit tests after installing MediaWiki [integration/quibble] - 10https://gerrit.wikimedia.org/r/938012 (https://phabricator.wikimedia.org/T227900) (owner: 10Daimona Eaytoy)
[22:21:58] <wikibugs>	 (03PS2) 10Daimona Eaytoy: Run PHPUnit unit tests after installing MediaWiki [integration/quibble] - 10https://gerrit.wikimedia.org/r/938012 (https://phabricator.wikimedia.org/T227900)
[22:24:14] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Run PHPUnit unit tests after installing MediaWiki [integration/quibble] - 10https://gerrit.wikimedia.org/r/938012 (https://phabricator.wikimedia.org/T227900) (owner: 10Daimona Eaytoy)
[22:25:19] <wikibugs>	 (03PS3) 10Daimona Eaytoy: Run PHPUnit unit tests after installing MediaWiki [integration/quibble] - 10https://gerrit.wikimedia.org/r/938012 (https://phabricator.wikimedia.org/T227900)
[22:38:19] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Run PHPUnit unit tests after installing MediaWiki [integration/quibble] - 10https://gerrit.wikimedia.org/r/938012 (https://phabricator.wikimedia.org/T227900) (owner: 10Daimona Eaytoy)