[00:01:34] (DatasourceError) firing: - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [00:11:34] (DatasourceError) resolved: - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [07:29:01] I have this patch: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/952209 for wikitech. We want to disable the account creation on wikitech and move users to idm.wikimedia.org. The patch has already been partially reviewed, but not okay'ed. It will also require deployment, but that completely depended on how it fits into the schedule [07:36:21] for deployment, once it has gotten a +1 you can just add it to a deployment / backport window, here: https://wikitech.wikimedia.org/wiki/Deployments You'll need to be around during the dpeloyment so that you can test the patch on a debug server and then in production, and in case of any issues. [07:38:00] slyngs: ^^ [07:40:40] That seems rather reasonable :-) [07:46:52] apergos: Practical question: Are patches merged in advance, or just right before deployment? [07:47:27] they are mreged during the window or right before it (in the case of something with CI tests that take a long time to complete) [07:47:55] Thanks [07:48:33] sure thing! [08:08:09] 10Phabricator, 10Release-Engineering-Team (Escape GoatsšŸ), 10collaboration-services, 10User-brennen: Migrate phabricator.wikimedia.org to Phorge as upstream - https://phabricator.wikimedia.org/T333885 (10valerio.bozzolan) Yeah to announce this maybe we can publish the post stub in T340223 (but I do not hav... [08:17:18] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (Priority Backlog šŸ“„), 10collaboration-services: Migrate to using new GitLab CI runner authentication scheme - https://phabricator.wikimedia.org/T344951 (10Jelto) SRE can take care of refactoring the puppet code. Thanks for bringing that up! [08:33:16] (03CR) 10Hashar: [C: 03+1] "I missed this change since it happened during my vacations and I am still catching up with the backlog. I will look at deploying it later " [integration/config] - 10https://gerrit.wikimedia.org/r/947369 (https://phabricator.wikimedia.org/T90875) (owner: 10Lucas Werkmeister (WMDE)) [09:51:35] 10GitLab (Integrations), 10Phabricator, 10Release-Engineering-Team (Escape GoatsšŸ): Get GitLab to render `T{\d}+` in MR overviews, comments, etc. as links to Phabricator - https://phabricator.wikimedia.org/T337570 (10Jelto) Usage of local gems is enabled on the [test instance](https://gitlab.devtools.wmcloud... [10:11:43] !log Rebuilding dev images for https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/51 [10:11:50] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:17:46] !log Successfully published image docker-registry.discovery.wmnet/dev/buster-swift53:0.2.0 [10:17:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:28:09] James_F: the dev/buster-swift53 image is fixed :] [10:52:03] šŸŽ‰ [11:38:58] 10GitLab (Pipeline Services MigrationšŸ¤), 10Research, 10collaboration-services: Move research webpages to gitlab - https://phabricator.wikimedia.org/T334511 (10Jelto) Onboarding to the new deployment workflow and repos has happened. @fkaelin feel free to close the task if you don't have any more questions. I... [12:04:45] (DatasourceError) firing: - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [12:19:45] (DatasourceError) resolved: - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [12:33:41] (DatasourceError) firing: - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [12:38:41] (DatasourceError) resolved: - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [12:58:00] 10Release-Engineering-Team (Priority Backlog šŸ“„), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T343726 (10Nikerabbit) https://gerrit.wikimedia.org/r/c/mediawiki/core/+/950225 might cause deprecation warnings from LiquidThreads. [13:05:36] (03PS2) 10Hashar: dockerfiles: operations-puppet: upgrade tox to 4.4.10 [integration/config] - 10https://gerrit.wikimedia.org/r/953560 (https://phabricator.wikimedia.org/T345152) [14:04:10] 10GitLab (Upstream pit of despair šŸ•³ļø), 10Release-Engineering-Team (Radar), 10Patch-For-Review, 10Upstream, 10User-brennen: Investigate whether issues, operations, wikis, etc. can be disabled globally on GitLab - https://phabricator.wikimedia.org/T264231 (10hashar) a:03hashar [14:12:28] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - operations/software - https://phabricator.wikimedia.org/T341504 (10LSobanski) [14:48:05] 10GitLab (Upstream pit of despair šŸ•³ļø), 10Release-Engineering-Team (Radar), 10Patch-For-Review, 10Upstream, 10User-brennen: Investigate whether issues, operations, wikis, etc. can be disabled globally on GitLab - https://phabricator.wikimedia.org/T264231 (10hashar) I have checked on `gitlab-prod-1002.devt... [14:48:19] 10GitLab (Upstream pit of despair šŸ•³ļø), 10Release-Engineering-Team (Radar), 10Patch-For-Review, 10Upstream, 10User-brennen: Investigate whether issues, operations, wikis, etc. can be disabled globally on GitLab - https://phabricator.wikimedia.org/T264231 (10hashar) a:05hasharā†’03None [14:54:30] 10GitLab (Upstream pit of despair šŸ•³ļø), 10Release-Engineering-Team (Radar), 10Patch-For-Review, 10Upstream, 10User-brennen: Investigate whether issues, operations, wikis, etc. can be disabled globally on GitLab - https://phabricator.wikimedia.org/T264231 (10hashar) Another thing I found is the Project API... [15:01:23] (03CR) 10Hashar: [C: 03+2] "Finally, I have updated the jobs:" [integration/config] - 10https://gerrit.wikimedia.org/r/947369 (https://phabricator.wikimedia.org/T90875) (owner: 10Lucas Werkmeister (WMDE)) [15:03:07] (03Merged) 10jenkins-bot: jjb: use composer phpunit:entrypoint in wikibase-{repo,client} [integration/config] - 10https://gerrit.wikimedia.org/r/947369 (https://phabricator.wikimedia.org/T90875) (owner: 10Lucas Werkmeister (WMDE)) [15:05:15] (03CR) 10Lucas Werkmeister (WMDE): "Thanks, letā€™s hope it works!" [integration/config] - 10https://gerrit.wikimedia.org/r/947369 (https://phabricator.wikimedia.org/T90875) (owner: 10Lucas Werkmeister (WMDE)) [15:06:47] (03CR) 10Hashar: [C: 03+2] "I gave it a try on an empty change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/767776 and the jobs are using the entr" [integration/config] - 10https://gerrit.wikimedia.org/r/947369 (https://phabricator.wikimedia.org/T90875) (owner: 10Lucas Werkmeister (WMDE)) [15:20:14] 10Continuous-Integration-Config, 10Release-Engineering-Team (Priority Backlog šŸ“„), 10MediaWiki-Core-Tests, 10Code-Health, and 8 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Daimona) [15:24:13] hashar: looks like wikibase-client-docker might be broken after all :S [15:24:17] (but -repo- is working) [15:25:21] hm, although now Iā€™m also seeing some ā€œDatabase backend disabledā€ errors (same as in wikibase-client-docker) in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/123121/console, which should not be affected [15:25:31] * Lucas_WMDE looks for suspicious recent mw merges [15:25:53] 10Phabricator, 10Release-Engineering-Team (Escape GoatsšŸ), 10collaboration-services, 10User-brennen: Migrate phabricator.wikimedia.org to Phorge as upstream - https://phabricator.wikimedia.org/T333885 (10Tacsipacsi) I have a Debian 11 with Cinnamon and Firefox. I donā€™t have Segoe UI or Helvetica/Helvetica... [15:26:13] ok, https://gerrit.wikimedia.org/r/c/mediawiki/core/+/938387 looks like a more likely culprit imho (cc Daimona_) [15:26:23] Iā€™ll go file a task where we can figure things out [15:27:35] Yeah, fallout is definitely expected from that change. But it was //not// expected in gated extensions to be fair [15:28:43] https://phabricator.wikimedia.org/T345372 [15:31:57] oh, these arenā€™t even all Wikibase tests [15:32:00] I hadnā€™t seen that before [15:32:04] two are CentralAuth [15:32:11] one SecurePoll [15:32:23] Lucas_WMDE: arghh [15:32:25] but it passed! [15:32:44] hashar: Iā€™m now pretty sure itā€™s Daimona_ā€™s change and not the jjb one [15:32:48] they just happened at almost the same time [15:32:57] I can always revert the jobs to last good state [15:33:07] Yeah, this is unrelated to the jjb change [15:33:08] it is easy (hit revert, ./jjb-update, done) [15:33:29] Iā€™d rather test a revert for the core change first, that should also be doable [15:33:32] lemme upload that [15:33:40] (not saying we necessarily have to revert the core change, but letā€™s find out if itā€™s that or not) [15:33:40] I can guarantee it's the core change [15:34:19] and the change passed CI on core cause CentralAuth is not in the gated job (wmf-quibble-*)? [15:34:23] CentralAuth and SecurePoll aren't gated I think (although I was under the impression I'd already prepared them for this change...) [15:34:23] or maybe it is [15:34:29] ah [15:34:43] yeah, CentralAuth definitely isnā€™t gated because that would disable all of coreā€™s own auth tests (known issue) [15:34:49] I'll take a look at the failure and push fixes [15:34:50] would be rad to have CentralAuth gated but last time I looked at it, it made to many changes to the auth system [15:35:00] and for many of the others I think itā€™s just that Wikibase is a big extension that pulls in many others [15:35:15] (though I should say, some of the failures *are* from Wikibase-related extensions, itā€™s not *just* everyone elseā€™s fault :P) [15:35:47] at least the phpunit:entrypoint is not at fault :] [15:35:53] weā€™re probably going to run into some circular dependencies though (e.g. between WikibaseLexeme and WikibaseQualityConstraints) [15:39:13] Daimona_: in principle, the fix is just adding ā€œ@group Databaseā€ in a bunch of places, right? [15:39:44] Yes [15:39:53] with however much investigation / justification you feel like putting into the commit message ^^ [15:39:55] Although I first check and see if an alternative fix is available [15:39:56] ok thanks [15:40:24] E.g., if a test happens to be hitting the database but it can easily be avoided by mocking some service [15:40:38] As long as the test doesn't really need the database [15:42:08] makes sense [15:43:30] I have a fix up for CentralAuth https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/954085 [15:43:54] If you're doing the Wikibase-related extensions, I can do the others [15:44:05] I uploaded WikibaseLexeme and -QualityConstraints [15:44:21] Iā€™ll look at WikibaseLexemeCirrusSearch next [15:45:02] Cool, I'll do SecurePoll [15:50:32] thank you! [15:53:42] I think all the fixes are up now. And here comes the fun part of figuring out what depends on what :P [15:56:48] I think thereā€™s actually still a bit more in Wikibase which for some reason wasnā€™t showing up in the quibble job, only in the wikibase-client-docker one [15:56:50] looking into that now [15:59:31] +2'd the SecurePoll patch [16:00:16] grmbl, thereā€™s nothing I can override in a test base class to set the DB flag for all subclasses? I need to add the group to all of them? [16:00:32] (I thought overriding needsDB() used to be possible, though Iā€™m not 100% sure) [16:00:35] Maybe setting tablesUsed? [16:01:07] Yes, adding it manually is the only way -- the reason for it is that we want to be able to run phpunit with `--group Database` [16:01:29] šŸ‘ [16:02:05] I've recently removed support for all other ways of marking a test as needing the DB [16:02:24] (That is, overriding needsDB(). Setting tablesUsed without the annotation already threw an exception) [16:02:35] Probably one way of doing something is best anyway :) [16:02:44] Less edge cases [16:03:09] well right now it means a PITA for me so Iā€™m not very inclined to see it as best :/ [16:03:15] but sure Iā€™ll upload a bunch of changes for that then [16:03:28] * Lucas_WMDE has to leave in ~10 mins btw [16:03:54] I can look after the centralauth patch [16:04:02] i.e. +2'ing it if needed [16:04:18] I can add the group where needed, what repo are we talking about? [16:04:21] I just +2'd the CA patch [16:04:25] :D [16:04:46] Unfortunately there isn't much we can do about it, running PHPUnit with `--group Database` is a strong requirement [16:04:46] Daimona: several, thatā€™s the issue :P [16:04:51] any subclass of LuaEngineTestBase [16:05:03] because SiteLibrary needs the DB (and I donā€™t think it can be stubbed out easily) [16:05:19] and all the subclasses will end up initializing SiteLibrary whether they want to or not [16:05:43] Let me take a look [16:06:28] Some workarounds I've used in other places include replacing the service with a mock in the base test class depending on the value of needsDB(), and skipping some actual code in databaseless tests as a last resort [16:09:34] Ah, and BTW, looks like this wasn't detected because Scribunto is not gated [16:10:12] Oh, and I see, it ends up hitting the database via Parser. That's really annoying [16:11:03] I've sent dozens of patches to avoid DB access in tests, I think those where Parser is causing the DB access are the hardest to fix [16:11:31] oh boy oh boy I get to touch my favorite extension! FlaggedRevs has a Scribunto_LuaEngineTestBase subclass :D :D [16:11:51] which doesnā€™t even *have* a phpdoc comment. presumably it covers nothing [16:11:52] :D [16:15:19] alright, I think Iā€™ve done all the LuaEngineTestBase subclasses I have installed [16:15:35] probably someoneā„¢ should codesearch for more but I think I have to leave now, sorry [16:17:44] Hang on [16:17:49] I think I may have a fix for them [16:19:34] Or maybe not :-/ The access from parser can be addressed by forcing a content model in getTestTitle() [16:19:59] But then it hits the DB via SiteStats. Let me see what I can do for that. [16:20:14] yeah, thatā€™s how far I got too [16:20:17] * Lucas_WMDE really off now [16:31:22] I fixed that as well, but all your patches are merged by now :D [18:16:26] 10GitLab (CI & Job Runners): Allow GitLab CI containers to connect to services - https://phabricator.wikimedia.org/T344818 (10CodeReviewBot) stran merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/44 gitlab: Build image to connect to mariadb service [19:09:19] 10Phabricator, 10Release-Engineering-Team (Escape GoatsšŸ), 10collaboration-services, 10User-brennen: Migrate phabricator.wikimedia.org to Phorge as upstream - https://phabricator.wikimedia.org/T333885 (10Aklapper) [19:09:22] 10Phabricator: Activity pane on front page no longer shows New Tasks by default after Phorge migration - https://phabricator.wikimedia.org/T344835 (10Aklapper) [19:10:30] 10Phabricator (2023-08-23), 10Upstream: Phabricator search dropdown results should open in new tab on middle-click - https://phabricator.wikimedia.org/T76812 (10Aklapper) [19:27:12] 10Release-Engineering-Team (Priority Backlog šŸ“„), 10Release, 10Train Deployments: 1.41.0-wmf.25 deployment blockers - https://phabricator.wikimedia.org/T343727 (10thcipriani) p:05Triageā†’03Medium a:03brennen [19:27:42] 10Release-Engineering-Team (Priority Backlog šŸ“„), 10Release, 10Train Deployments: 1.41.0-wmf.26 deployment blockers - https://phabricator.wikimedia.org/T343728 (10thcipriani) p:05Triageā†’03Medium a:03hashar [19:50:17] 10GitLab, 10collaboration-services: Switch visibility level to Internal for GitLab repositories - https://phabricator.wikimedia.org/T345215 (10thcipriani) This seems like a good use-case for our [[ https://www.mediawiki.org/wiki/GitLab/Hosting_a_project_on_GitLab#GitLab_private_(restricted)_repos | restricted... [19:59:17] (03PS1) 10Ahmon Dancy: Add utils/archive-repo.py for quick and easy repo archive [integration/config] - 10https://gerrit.wikimedia.org/r/954124 [20:00:30] (03CR) 10CI reject: [V: 04-1] Add utils/archive-repo.py for quick and easy repo archive [integration/config] - 10https://gerrit.wikimedia.org/r/954124 (owner: 10Ahmon Dancy) [20:03:08] 10GitLab, 10collaboration-services: Switch visibility level to Internal for GitLab repositories - https://phabricator.wikimedia.org/T345215 (10taavi) Can I ask why these cannot be public? [20:05:06] (03PS2) 10Ahmon Dancy: Add utils/archive-repo.py for quick and easy repo archive [integration/config] - 10https://gerrit.wikimedia.org/r/954124 [20:06:15] (03CR) 10CI reject: [V: 04-1] Add utils/archive-repo.py for quick and easy repo archive [integration/config] - 10https://gerrit.wikimedia.org/r/954124 (owner: 10Ahmon Dancy) [20:09:56] (03PS3) 10Ahmon Dancy: Add utils/archive-repo.py for quick and easy repo archive [integration/config] - 10https://gerrit.wikimedia.org/r/954124 [20:11:04] (03CR) 10CI reject: [V: 04-1] Add utils/archive-repo.py for quick and easy repo archive [integration/config] - 10https://gerrit.wikimedia.org/r/954124 (owner: 10Ahmon Dancy) [20:14:00] (03PS4) 10Ahmon Dancy: Add utils/archive-repo.py for quick and easy repo archive [integration/config] - 10https://gerrit.wikimedia.org/r/954124 [20:14:35] * dancy shakes a fist at Python 2 [20:18:00] 10Phabricator, 10Tools, 10Patch-For-Review: Publicly log account bans made using the phab-ban tool - https://phabricator.wikimedia.org/T200856 (10CodeReviewBot) bd808 opened https://gitlab.wikimedia.org/toolforge-repos/phab-ban/-/merge_requests/3 Log all disabled users on-wiki [20:22:55] dancy: how do you get access to WMCS project gitlab repos? Is there a sync for members or do I have to task and hope? [20:25:03] There are no automatic syncs going on for https://gitlab.devtools.wmcloud.org/ at this time. I did do a one-off sync a week or two ago for experimentation. I see that you already have an account on that gitlab server. What repos do you need access to? [20:27:50] I'm stepping afk for a bit but I can adjust access for you when I get back. [20:28:15] RhinosF1|Away: T317376 might be related to what you are asking. For any existing repo that Striker has created there should be at least one "owner" who can add others manually. [20:28:15] T317376: Update GitLab repo owners when tool maintainers change - https://phabricator.wikimedia.org/T317376 [20:32:22] dancy: the wikistats one as mutante is off [20:32:27] bd808: project not tool [20:33:36] Like a repo for deployment-prep (as an example)? If so that would all be "ask nicely" today I think. [20:34:22] * bd808 now actually reads backscroll [20:35:44] bd808: yes. I'm trying to get gitlab to load. Stupid wifi. [20:39:03] dancy: https://gitlab.wikimedia.org/cloudvps-repos/wikistats [20:39:25] No rush as I'm on holiday with no laptop until Tuesday [20:39:30] Ah, a link.. that makes things much easier [20:39:48] Yep, hotel wifi fell out with me [20:42:55] Looks like bd808 is an owner of the relevant group so I will defer to him to add you. [20:43:15] * bd808 becomes responsible... [20:45:04] RhinosF1|Away: I did confirm that you are a member of that Cloud VPS project. How about a Phab task so we can track the request and the grant and I can do the needful? [20:46:12] * bd808 contemplates how this could be made self-serve in the future [20:47:50] bd808: ye, sure [20:49:19] 10GitLab, 10VPS-project-Wikistats: Add RhinosF1 as member of gitlab cloudvps-repos/wikistats - https://phabricator.wikimedia.org/T345393 (10RhinosF1) [20:49:20] bd808: https://phabricator.wikimedia.org/T345393 [20:49:57] bd808: who can merge https://gerrit.wikimedia.org/r/c/labs/tools/wikibugs2/+/953215 too? [20:50:58] RhinosF1|Away: https://gerrit.wikimedia.org/r/admin/groups/9c00ccec122777755f924a344b9f877bb4d15ea0,members -- which... apparently includes me? [20:52:39] bd808: good guess there [20:53:05] Per https://www.mediawiki.org/wiki/Wikibugs#Deploying_changes it looks like maybe that patch can just be +2'd and it will auto-deploy [20:54:10] Should do [21:09:14] 10GitLab, 10VPS-project-Wikistats: Add RhinosF1 as member of gitlab cloudvps-repos/wikistats - https://phabricator.wikimedia.org/T345393 (10RhinosF1) Test [21:09:20] bd808: it worked [21:09:23] And good night! [21:22:58] 10GitLab, 10VPS-project-Wikistats, 10User-bd808: Add RhinosF1 as member of gitlab cloudvps-repos/wikistats - https://phabricator.wikimedia.org/T345393 (10bd808) 05Openā†’03In progress a:03bd808 Confirmed via https://openstack-browser.toolforge.org/project/wikistats that @RhinosF1 is a project member. I a... [21:30:35] Thanks bd808! [21:31:53] 10GitLab, 10VPS-project-Wikistats, 10User-bd808: Add RhinosF1 as member of gitlab cloudvps-repos/wikistats - https://phabricator.wikimedia.org/T345393 (10bd808) 05In progressā†’03Resolved https://gitlab.wikimedia.org/cloudvps-repos/wikistats/-/project_members?search=RhinosF1 {F37645318, size=full} [21:46:46] (03PS5) 10Ahmon Dancy: Add utils/archive-repo.py for quick and easy repo archive [integration/config] - 10https://gerrit.wikimedia.org/r/954124 [22:28:12] (03CR) 10Thcipriani: [C: 03+2] "Nice work! Works perfectly in the vast majority of cases." [integration/config] - 10https://gerrit.wikimedia.org/r/954124 (owner: 10Ahmon Dancy) [22:29:16] (03Merged) 10jenkins-bot: Add utils/archive-repo.py for quick and easy repo archive [integration/config] - 10https://gerrit.wikimedia.org/r/954124 (owner: 10Ahmon Dancy) [22:36:13] 10Diffusion: Point Android Wikipedia app diffusion mirror to github repo - https://phabricator.wikimedia.org/T345222 (10thcipriani) 05Openā†’03Resolved a:03thcipriani Should be update now. Reopen if you spot problems. [22:51:55] 10Gitlab-Application-Security-Pipeline: Establish a more specific policy/best practices around security include failures - https://phabricator.wikimedia.org/T342469 (10Mstyles) Draft has been reviewed by @sbassett and now just waiting on the second round of approvals