[07:07:35] 10Continuous-Integration-Infrastructure: Stop using integration/composer and then archive the repo - https://phabricator.wikimedia.org/T249949 (10hashar) [07:26:33] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata Query Builder, 10Wikidata Query UI, and 6 others: [QB] [WDQS-GUI] Move build scripts from CI to the repository - https://phabricator.wikimedia.org/T328543 (10hashar) The Jenkins job clones `wikidata/query/gui` and shells out to `scripts/set-up-git.sh`... [07:27:03] Noa_WMDE: I commented on the task , looks like some Jenkins agent have the Gerrit ssh host key available while others do not ( git -C ./src/build push origin HEAD:refs/for/production%ready [07:27:03] ) [07:27:06] it is a mystery :D [07:27:59] I'll have a look. Thank you! [07:37:04] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata Query Builder, 10Wikidata Query UI, and 6 others: [QB] [WDQS-GUI] Move build scripts from CI to the repository - https://phabricator.wikimedia.org/T328543 (10hashar) On an agent that executed a successful build: ` hashar@integration-agent-docker-1055:... [07:37:14] Noa_WMDE: the issue is on the Jenkins agent side, I thought they already had the Gerrit host key added via Puppet but that is no the case [07:39:44] !log integration: `sudo cumin --force 'name:docker' 'rm -f /mnt/home/jenkins-deploy/.ssh/config'` # T328543#9198204 [07:39:49] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:39:49] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository - https://phabricator.wikimedia.org/T328543 [07:40:03] now I gotta figure out how to add the Gerrit fingerprint to the known host :) [07:44:29] ah https://gerrit.wikimedia.org/r/c/operations/puppet/+/816715/4/modules/profile/manifests/gerrit.pp [07:44:32] puppet collects it [08:20:19] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata Query Builder, 10Wikidata Query UI, and 6 others: [QB] [WDQS-GUI] Move build scripts from CI to the repository - https://phabricator.wikimedia.org/T328543 (10hashar) I have cherry picked https://gerrit.wikimedia.org/r/c/operations/puppet/+/961025 on t... [08:20:35] Noa_WMDE: Lucas_WMDE: so I went to add the Gerrit ssh host key fingerprint to all CI agents, since the wikidata query guy build pushes directly from the Jenkins agent [08:20:41] which is done by https://gerrit.wikimedia.org/r/c/operations/puppet/+/961025/1/modules/profile/manifests/ci/slave/labs/common.pp [08:20:46] I deployed it on all hosts [08:21:00] cool, thanks! [08:21:00] so `git push ssh://gerrit.wikimedia.org:29418.....` should work now [08:21:04] * Lucas_WMDE aborts the bisect ^^ [08:21:21] I assumed it was already present since we have some over Jenkins jobs pushing to Gerrit [08:21:27] then I guess they are implemented differently [08:21:51] some hosts ignored the host fingerprint, I think it comes from one of the Jenkins plugin injecting the config automagically [08:22:03] so some hosts worked and some others did not [08:22:30] but I have now confirmed all hosts recognized the gerrit key when invoking `ssh` as the `jenkins-deploy` user (that is the unix user the Jenkins agent runs as) [08:22:33] something like that :) [08:22:44] sorry for the screw up! [08:22:48] sounds like that explains it! Thanks for looking into it [08:22:56] \o/ [08:23:18] I can't remember off hand which other job(s) is(are) pushing directly to Gerrit [08:23:23] I guess they use a slightly different command [08:25:15] * Noa_WMDE attempts running wikidata-query-gui-build referred to master [08:29:39] it fails, but for a reason we know the cause of. so that at least means it's working on the jenkins side (i think) :D [08:30:00] good news! [08:30:29] 08:27:19 remote: ERROR: commit c6b5c52: Change-Id must be in message footer [08:30:32] that is a fun one [08:30:58] I guess you can make the script which does the `git commit` to also do a `git show` [08:31:43] Noa_WMDE: that’s probably T295601 again? [08:31:44] T295601: wikidata-query-gui-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place) - https://phabricator.wikimedia.org/T295601 [08:31:51] or were you referring to something else? [08:32:17] Lucas_WMDE yeah, i think that one might not be done yet [08:32:22] ok [08:32:58] hashar it would be great if you could have a look at the wikidata-query-builder-build patches on the same task. i'm rebasing the config one atm [08:33:16] "same task" being https://phabricator.wikimedia.org/T328543 [08:35:00] ahhh [08:35:07] yeah will do later this morning :) [08:36:29] that is doing to wikidata/query-builder the same that go done for the gui repo right? [08:38:03] (03PS2) 10Noa wmde: wikidata-query-builder-build: run shell scripts in a container [integration/config] - 10https://gerrit.wikimedia.org/r/953559 (https://phabricator.wikimedia.org/T328543) [08:38:11] 10Continuous-Integration-Config, 10Math, 10User-Physikerwelt, 10ci-test-error: CI test error: already defined testUnderbrace function - https://phabricator.wikimedia.org/T347320 (10Stegmujo) [08:40:01] yeah it's the same. query builder patch: https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/953558/ config patch: https://gerrit.wikimedia.org/r/c/integration/config/+/953559/1..2 [08:40:08] i will check :) [08:42:42] thanks! [08:52:39] 10Continuous-Integration-Config, 10Math, 10User-Physikerwelt, 10ci-test-error: CI test error: already defined testUnderbrace function - https://phabricator.wikimedia.org/T347320 (10Stegmujo) a:03releng-list [08:54:49] (03CR) 10Hashar: [C: 03+2] "Job updated!" [integration/config] - 10https://gerrit.wikimedia.org/r/953559 (https://phabricator.wikimedia.org/T328543) (owner: 10Noa wmde) [08:54:54] Noa_WMDE: I have updated the jenkins job [08:55:10] 10Continuous-Integration-Config, 10Math, 10User-Physikerwelt, 10ci-test-error: CI test error: already defined testUnderbrace function - https://phabricator.wikimedia.org/T347320 (10taavi) a:05releng-list→03None [08:55:33] so I guess you can try the job against ZUUL_REF set to `refs/changes/58/953558/1` [08:56:02] (03Merged) 10jenkins-bot: wikidata-query-builder-build: run shell scripts in a container [integration/config] - 10https://gerrit.wikimedia.org/r/953559 (https://phabricator.wikimedia.org/T328543) (owner: 10Noa wmde) [09:00:22] 10Continuous-Integration-Config, 10Math, 10User-Physikerwelt, 10ci-test-error: CI test error: already defined testUnderbrace function - https://phabricator.wikimedia.org/T347320 (10Stegmujo) @taavi How can I flag this task or add a suitable assignee, it seems to be an issue with CI ? [09:08:54] 10Continuous-Integration-Config, 10Math, 10User-Physikerwelt, 10ci-test-error (WMF-deployed Build Failure): CI test error: already defined testUnderbrace function - https://phabricator.wikimedia.org/T347320 (10hashar) >>! In T347320#9198371, @Stegmujo wrote: > @taavi How can I flag this task or add a suit... [09:10:43] * Noa_WMDE trying the job [09:11:56] it's not happy... "[ssh-agent] Could not find specified credentials" [09:12:44] 10Continuous-Integration-Config, 10Math, 10User-Physikerwelt, 10ci-test-error (WMF-deployed Build Failure): CI test error: already defined testUnderbrace function - https://phabricator.wikimedia.org/T347320 (10Physikerwelt) @hashar no, any change, even empty ones, triggers the problem. Something must have... [09:13:40] dohh [09:14:17] ah cause it got changed to wdquerybuilder [09:15:20] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, 10serviceops: Serve production traffic via Kubernetes - https://phabricator.wikimedia.org/T290536 (10JMeybohm) [09:16:20] i had a couple of mw-config jobs fail due to permission errors today, for example https://integration.wikimedia.org/ci/job/operations-mw-config-php74-composer-test-docker/6390/console [09:19:32] yeah it made no sense to leave it as wdqsguibuilder [09:19:58] so we need the credential to be created in Jenkins [09:20:11] there is https://integration.wikimedia.org/ci/manage/credentials/store/system/domain/_/credential/wdqsguibuilder/ [09:20:20] but no wdquerybuilder [09:25:20] 10GitLab (Account Approval), 10Release-Engineering-Team (Priority Backlog 📥): Requesting GitLab account activation for MarcoAurelio - https://phabricator.wikimedia.org/T347294 (10Aklapper) p:05Triage→03Medium a:03Aklapper [09:25:49] 10GitLab (Account Approval), 10Release-Engineering-Team (Priority Backlog 📥): Requesting GitLab account activation for MarcoAurelio - https://phabricator.wikimedia.org/T347294 (10Aklapper) 05Open→03Resolved I didn't see any signs of a disabled account when looking at https://gitlab.wikimedia.org/admin/user... [09:26:29] taavi: `mkdir: cannot create directory ‘log’: Permission denied`: it happens from time to time and I have never figured out the root cause :-\ [09:26:58] I see, how much of a hassle is it creating the credential? assuming the scripts themselves are going to live within the query builder itself having it named after the query gui seemed out of place [09:26:59] but iirc that comes from the previous build of the same job/Jenkins agent failing due to some interruption eg https://integration.wikimedia.org/ci/job/operations-mw-config-php74-composer-test-docker/6375/console [09:27:21] which I guess leave the workspace in a wrong state, probably a `log` dir is left behind which is owned by root, but I don't know how that could happen [09:27:32] Noa_WMDE: adding a credential is straight forward :) [09:28:06] but we need a wdquerybuilder user :) [09:29:04] and where does that get created? anything i can do on our side? [09:29:06] the other user is https://ldap.toolforge.org/user/wdqsguibuilder [09:29:37] with an email registered to some list, so you can create a new user BUT the email needs to be different else Gerrit will plainly refuses to create its local version of that user [09:29:42] or we can share the user between the builds [09:29:57] eg change back to use the wdqsguibuilder credentials [09:30:06] and push to the repo with that user [09:30:26] that is less clean though [09:30:44] so there isn't really a way around using wdqsguibuilder for this right now? [09:31:05] I can revert the user to wdqsguibuilder and we can open a separate task for this to be done separately [09:31:23] so we can finish moving the scripts out of the build first [09:34:14] that sounds like the easier solution [09:34:23] I will update the job [09:34:30] I have an editor opened on the yaml file already :) [09:35:28] thanks :) i'll update the query builder patch [09:36:02] (and open a task for the relevant wikidata team to take care of creating a separate user) [09:37:14] (03PS1) 10Hashar: wikidata-query-builder-builder: use wdqsguibuilder [integration/config] - 10https://gerrit.wikimedia.org/r/961056 (https://phabricator.wikimedia.org/T328543) [09:37:28] Noa_WMDE: https://gerrit.wikimedia.org/r/c/integration/config/+/961056 :) [09:37:35] and I have updated the job so you can try again [09:37:38] and we will see what happens [09:37:54] (well you need to update the user in the shell script) [09:38:55] on it [09:39:00] (03CR) 10Hashar: "I have updated the job." [integration/config] - 10https://gerrit.wikimedia.org/r/961056 (https://phabricator.wikimedia.org/T328543) (owner: 10Hashar) [09:39:15] it is a bit painful [09:39:23] but at least once the Jenkins job is working, it would barely have any logic [09:39:36] and using a different user should be rather easy to do [09:42:26] (03PS1) 10Jbond: Revert "operations-puppet-catalog-compiler: add support for Change-Private" [integration/config] - 10https://gerrit.wikimedia.org/r/960738 [09:46:19] yeah it makes sense to do it separately, i was not aware of the process [09:47:10] (03CR) 10Noa wmde: [C: 03+1] wikidata-query-builder-builder: use wdqsguibuilder [integration/config] - 10https://gerrit.wikimedia.org/r/961056 (https://phabricator.wikimedia.org/T328543) (owner: 10Hashar) [09:49:13] jbond: Change-Private is broken? :-\ [09:49:18] (03CR) 10Hashar: [C: 03+2] wikidata-query-builder-builder: use wdqsguibuilder [integration/config] - 10https://gerrit.wikimedia.org/r/961056 (https://phabricator.wikimedia.org/T328543) (owner: 10Hashar) [09:49:27] Noa_WMDE: congratulations :) [09:50:10] hashar: yes, well just the `check experimental` part [09:50:28] (03Merged) 10jenkins-bot: wikidata-query-builder-builder: use wdqsguibuilder [integration/config] - 10https://gerrit.wikimedia.org/r/961056 (https://phabricator.wikimedia.org/T328543) (owner: 10Hashar) [09:50:37] :) can I now retest with the change id ref? [09:50:51] (03PS2) 10Hashar: Revert "operations-puppet-catalog-compiler: add support for Change-Private" [integration/config] - 10https://gerrit.wikimedia.org/r/960738 (owner: 10Jbond) [09:51:21] jbond: I have amended your the commit message to remove the link to the build log since that iwll vanish in a few days [09:51:35] hashar: ack thanks [09:52:01] jbond: I must say I blindly CR+2/ deployed the job and haven't really reviewed the shell magic [09:52:46] it is possible to have the shell script extracted in a standalone shell script such as jjb/pcc-parse-commit.sh [09:52:56] then include it in the yaml `- shell` [09:53:28] - shell: [09:53:33] hashar: ack thanks, its probably worth doing that, this is not a big priority il;l take another look on friday [09:53:37] !include-raw: pcc-parse-commit.sh [09:53:54] which might make it easier to test it out locally [09:54:06] yes definetly [09:54:13] regardless, all the shell snippets are extracted from the rendered yaml and passed through shellcheck via some dark magic [09:54:47] (jjb is run, the resulting XML is parsed to find any shell tasks, their content extracted to flat files and shellcheck is run against those) [09:54:51] something like that [09:55:23] ack [09:56:18] (03CR) 10Hashar: [C: 03+2] "I have updated the `operations-puppet-catalog-compiler-test` job." [integration/config] - 10https://gerrit.wikimedia.org/r/960738 (owner: 10Jbond) [09:57:28] (03Merged) 10jenkins-bot: Revert "operations-puppet-catalog-compiler: add support for Change-Private" [integration/config] - 10https://gerrit.wikimedia.org/r/960738 (owner: 10Jbond) [10:29:38] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata Query Builder, 10Wikidata Query UI, and 6 others: [QB] [WDQS-GUI] Move build scripts from CI to the repository - https://phabricator.wikimedia.org/T328543 (10noarave) 05Stalled→03Open [10:34:32] 10GitLab (Pipeline Services Migration🐤), 10Metrics Platform Backlog, 10Data Products (Sprint 01), 10Patch-For-Review: Migrate metrics-platform repo to GitLab - https://phabricator.wikimedia.org/T344733 (10phuedx) >>! In T344733#9192434, @Krinkle wrote: > I've reconfigured the `wikimedia/metrics-platform` p... [10:35:16] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Migrate internal traffic to k8s - https://phabricator.wikimedia.org/T333120 (10Joe) [10:36:35] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Migrate all eventgate installations to mw-api-int - https://phabricator.wikimedia.org/T346448 (10Joe) 05Open→03Resolved a:03Joe [10:36:46] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Migrate internal traffic to k8s - https://phabricator.wikimedia.org/T333120 (10Joe) [11:02:16] 10Gerrit: Merge Conflict shown in "Work in progress" section on Gerrit - https://phabricator.wikimedia.org/T347388 (10xSavitar) [11:03:03] 10Gerrit: All patch sets show "Merge Conflict" in "Work in progress" section on Gerrit - https://phabricator.wikimedia.org/T347388 (10xSavitar) [11:04:27] 10Gerrit, 10Wikidata, 10Wikidata Query UI, 10wdwb-tech, and 2 others: wikidata-query-gui-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place) - https://phabricator.wikimedia.org/T295601 (10Lucas_Werkmeister_WMDE) 05Stalled→03Open Unstalling – in [build... [11:05:11] 10GitLab (Infrastructure), 10Release-Engineering-Team (Radar), 10collaboration-services: Add GitLab upgrades and maintenance to deployment calendar - https://phabricator.wikimedia.org/T336470 (10LSobanski) 05Open→03Resolved I added a note to the GitLab Upgrade page, resolving. [11:05:48] (03CR) 10Noa wmde: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/961075 (https://phabricator.wikimedia.org/T328543) (owner: 10Noa wmde) [11:17:37] hashar I spotted an error of mine on the query-builder job here's the fix https://gerrit.wikimedia.org/r/c/integration/config/+/961075 [11:20:06] easy :) [11:20:52] (03CR) 10Hashar: [C: 03+2] "Job updated :)" [integration/config] - 10https://gerrit.wikimedia.org/r/961075 (https://phabricator.wikimedia.org/T328543) (owner: 10Noa wmde) [11:22:03] (03Merged) 10jenkins-bot: Fix wrong deploy dir for wikidata-query-builder-build [integration/config] - 10https://gerrit.wikimedia.org/r/961075 (https://phabricator.wikimedia.org/T328543) (owner: 10Noa wmde) [11:22:29] perfect, thank you [11:27:58] 10Phabricator: RuntimeException: Array to string conversion at [/src/error/PhutilErrorHandler.php:261] - https://phabricator.wikimedia.org/T347354 (10Aklapper) Uhm, it loops forever... https://phabricator.wikimedia.org/daemon/task/172445230/ shows a Failure Count of > 200000 about changes in `M321` two... [12:06:02] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥): Phabricator Two-factor Authentication reset for Tommy_Kronkvist - https://phabricator.wikimedia.org/T346513 (10Aklapper) 05Open→03Resolved p:05Triage→03Low `a6edd6d2fdbf82621f0cda4e5525c71f8da9b5dfd308242c3c63365e998c32c5406b75448380903265... [12:20:58] 10GitLab (Infrastructure), 10collaboration-services, 10Patch-For-Review: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10Arnoldokoth) [12:22:54] 10GitLab (Infrastructure), 10collaboration-services, 10Patch-For-Review: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10Arnoldokoth) [12:34:15] 10GitLab (Pipeline Services Migration🐤), 10Release-Engineering-Team (Priority Backlog 📥), 10Toolforge, 10cloud-services-team: Move Toolforge PipelineLib repositories to GitLab - https://phabricator.wikimedia.org/T334399 (10dcaro) [12:44:16] 10Gerrit, 10Release-Engineering-Team (Seen), 10SRE: Create Gerrit Administrator right policy - https://phabricator.wikimedia.org/T218686 (10LSobanski) [12:45:24] 10Release-Engineering-Team (Seen), 10Abstract Wikipedia team, 10MW-on-K8s, 10SRE, and 4 others: Migrate functions-orchestrator service to mw-api-int - https://phabricator.wikimedia.org/T347397 (10Jdforrester-WMF) [12:49:56] 10Release-Engineering-Team (Deployment-Blockers), 10Reference Previews, 10WMDE-TechWish, 10Patch-For-Review, 10WMDE-TechWish-Maintenance-2023: ReferencePreviews: Final round of manual tests before full rollout - https://phabricator.wikimedia.org/T345833 (10WMDE-Fisch) [12:54:05] (03PS2) 10Hashar: Require tox v4 and remove skipsdist/use_develop [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/960086 (https://phabricator.wikimedia.org/T346238) [12:54:49] 10GitLab (Infrastructure), 10collaboration-services, 10Patch-For-Review: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10ops-monitoring-bot) Cookbook cookbooks.sre.gitlab.failover (Failover of gitlab from gitlab2002.wikimedia.org to gitlab1... [12:55:30] 10GitLab (Infrastructure), 10collaboration-services, 10Patch-For-Review: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10ops-monitoring-bot) Cookbook cookbooks.sre.gitlab.failover (Failover of gitlab from gitlab2002.wikimedia.org to gitlab1... [13:10:02] (03CR) 10Hashar: [C: 03+2] Require tox v4 and remove skipsdist/use_develop [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/960086 (https://phabricator.wikimedia.org/T346238) (owner: 10Hashar) [13:12:09] 10Release-Engineering-Team, 10collaboration-services: Agree on GitLab settings management guidelines - https://phabricator.wikimedia.org/T347399 (10LSobanski) [13:12:43] (03Merged) 10jenkins-bot: Require tox v4 and remove skipsdist/use_develop [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/960086 (https://phabricator.wikimedia.org/T346238) (owner: 10Hashar) [13:14:22] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Migrate wikifeeds to mw-api-int - https://phabricator.wikimedia.org/T346447 (10Joe) 05Open→03Resolved a:03Joe [13:14:38] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Migrate internal traffic to k8s - https://phabricator.wikimedia.org/T333120 (10Joe) [13:15:04] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Migrate internal traffic to k8s - https://phabricator.wikimedia.org/T333120 (10Joe) [13:18:27] 10GitLab (Infrastructure), 10collaboration-services, 10Patch-For-Review: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10ops-monitoring-bot) Cookbook cookbooks.sre.gitlab.failover (Failover of gitlab from gitlab2002.wikimedia.org to gitlab1... [13:18:55] 10Phabricator (Upstream), 10Upstream: RuntimeException: Array to string conversion at [/src/error/PhutilErrorHandler.php:261] - https://phabricator.wikimedia.org/T347354 (10Aklapper) 05Open→03Stalled p:05Triage→03Low a:03Aklapper * Ran `sudo /srv/phab/phabricator/bin/worker cancel --id 1724... [13:31:00] 10Continuous-Integration-Config, 10Math, 10Patch-For-Review, 10User-Physikerwelt, 10ci-test-error (WMF-deployed Build Failure): CI test error: already defined testUnderbrace function - https://phabricator.wikimedia.org/T347320 (10Stegmujo) This is fixed by renaming testUnderbrace function to testUnder. [13:40:40] 10Continuous-Integration-Config, 10Math, 10Patch-For-Review, 10User-Physikerwelt, 10ci-test-error (WMF-deployed Build Failure): CI test error: already defined testUnderbrace function - https://phabricator.wikimedia.org/T347320 (10Physikerwelt) 05Open→03Resolved a:03Stegmujo [14:10:36] (03CR) 10Hashar: "I did a bit of refactoring which highlight the differences between the two jobs. The CI generated diff has an unrelated change cause the " [integration/config] - 10https://gerrit.wikimedia.org/r/961109 (owner: 10Hashar) [14:36:21] 10Release-Engineering-Team (Priority Backlog 📥), 10collaboration-services: Migrate SRE repositories to GitLab - Archiving unused Gerrit repositories - https://phabricator.wikimedia.org/T343707 (10LSobanski) operations/software/wmfmariadbpy operations/software/wmfdb [14:46:18] 10Phabricator, 10Patch-For-Review, 10Voice & Tone: Improve error message about Edit Policy when creating objects when Edit Policy is hidden in form - https://phabricator.wikimedia.org/T333955 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/8 Do not... [14:48:21] 10Phabricator, 10Release-Engineering-Team (Escape Goats🐐), 10Patch-For-Review: Uninstall Packages (Phabricator application) - https://phabricator.wikimedia.org/T336906 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/11 Remove unused "Packages" prot... [14:48:34] 10Phabricator, 10Release-Engineering-Team (Escape Goats🐐), 10Patch-For-Review: Uninstall Phrequent (Phabricator application) - https://phabricator.wikimedia.org/T337606 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/12 Remove "Phrequent" prototype... [14:57:33] 10Phabricator, 10Release-Engineering-Team (Escape Goats🐐), 10Patch-For-Review: Uninstall Multimeter (Phabricator application) - https://phabricator.wikimedia.org/T337650 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/13 Remove "Multimeter" prototy... [15:03:46] 10Phabricator, 10Release-Engineering-Team (Escape Goats🐐), 10collaboration-services, 10User-brennen: Migrate phabricator.wikimedia.org to Phorge as upstream - https://phabricator.wikimedia.org/T333885 (10ops-monitoring-bot) Icinga downtime and Alertmanager silence (ID=98876a84-36a0-444b-8998-f6e6693c8597)... [15:10:28] 10Release-Engineering-Team, 10collaboration-services: Agree on GitLab settings management guidelines - https://phabricator.wikimedia.org/T347399 (10LSobanski) [15:18:37] 10Phabricator, 10Release-Engineering-Team: Clarify GPL 2.0 or later license on Phabricator - https://phabricator.wikimedia.org/T338762 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/17 Clarify GPL 2.0 or later license [15:19:37] 10Phabricator, 10Release-Engineering-Team: Clarify GPL 2.0 or later license on Phabricator - https://phabricator.wikimedia.org/T338762 (10brennen) 05Stalled→03Resolved [15:23:33] 10Diffusion, 10Phabricator, 10Release-Engineering-Team: Replace dead git-ssh.wikimedia.org service in diffusion.ssh-host setting - https://phabricator.wikimedia.org/T347408 (10Aklapper) p:05Triage→03Low [15:26:56] 10Phabricator, 10Release-Engineering-Team (Escape Goats🐐), 10VPS-project-Phabricator, 10Patch-For-Review, 10User-brennen: After a deployment, Phabricator errors out with `Unable to load the "Arcanist" library. Put "arcanist/" next to "phabricator/" on disk.` - https://phabricator.wikimedia.org/T314460 (10... [15:28:28] 10GitLab (Infrastructure), 10Release-Engineering-Team (Radar), 10collaboration-services, 10Patch-For-Review, 10User-brennen: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10brennen) [16:11:04] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10Documentation, 10SecTeam-Processed, 10Security: Update on-wiki documentation for the AppSec Pipeline for phase 2 work - https://phabricator.wikimedia.org/T346802 (10sbassett) 05Open→03In progress p:05Triage→03Medium a:05sbassett→03mmar... [16:11:10] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10sbassett) [16:24:10] 10Release-Engineering-Team, 10collaboration-services, 10User-brennen: Agree on GitLab settings management guidelines - https://phabricator.wikimedia.org/T347399 (10brennen) [16:27:33] (03Abandoned) 10Ejegg: Remove fundraising jobs for ParserFunctions and cldr [integration/config] - 10https://gerrit.wikimedia.org/r/959251 (https://phabricator.wikimedia.org/T328240) (owner: 10Ejegg) [16:28:01] 10GitLab (Infrastructure), 10Release-Engineering-Team (Radar), 10collaboration-services, 10Patch-For-Review, 10User-brennen: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10ops-monitoring-bot) Cookbook cookbooks.sre.gitlab.failover (Fai... [16:32:37] 10Phabricator, 10Release-Engineering-Team (Seen): Switch phabricator production to codfw - https://phabricator.wikimedia.org/T164810 (10brennen) 05Stalled→03Invalid Closing as 6 years out of date with reality. [16:46:33] 10Diffusion, 10Release-Engineering-Team, 10collaboration-services: Make https://git.wikimedia.org not redirect to Phabricator Diffusion - https://phabricator.wikimedia.org/T323073 (10brennen) > Given the situation I'd propose a disambiguation page +1 for a brief static disambiguation page. If that's creati... [17:16:33] (03PS1) 10Jforrester: Zuul: Drop browser test jobs on REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/961169 [17:18:32] (03CR) 10Jforrester: [C: 03+2] Zuul: Drop browser test jobs on REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/961169 (owner: 10Jforrester) [17:18:43] (03CR) 10Reedy: [C: 03+1] "LTS means LTS." [integration/config] - 10https://gerrit.wikimedia.org/r/961169 (owner: 10Jforrester) [17:19:45] (03Merged) 10jenkins-bot: Zuul: Drop browser test jobs on REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/961169 (owner: 10Jforrester) [17:20:01] !log Zuul: Drop browser test jobs on REL1_35 branches [17:20:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:20:55] (03CR) 10Reedy: [C: 03+1] "See also: {T345500}" [integration/config] - 10https://gerrit.wikimedia.org/r/961169 (owner: 10Jforrester) [17:27:12] 10Gerrit, 10Wikidata, 10Wikidata Query UI, 10wdwb-tech, and 2 others: wikidata-query-gui-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place) - https://phabricator.wikimedia.org/T295601 (10ItamarWMDE) @HasanAkgun_WMDE Seems like there's more work to be done... [18:39:30] (03CR) 10Hashar: "I finally took a pick at reducing the amount of repetition between node16, node18 and node20 jobs. The copy paste can be reduced by using" [integration/config] - 10https://gerrit.wikimedia.org/r/961118 (owner: 10Hashar) [18:40:13] (03CR) 10Hashar: "Note the diff stats: adding 70 lines to and removing 274 \o/" [integration/config] - 10https://gerrit.wikimedia.org/r/961118 (owner: 10Hashar) [18:41:37] (03CR) 10Jforrester: "<3" [integration/config] - 10https://gerrit.wikimedia.org/r/961118 (owner: 10Hashar) [19:28:38] James_F: I noticed you copy pasted the nodejs JJB jobs and felt like converting them to template :) [19:28:56] hashar: Yeah, it was on my mental TODO list, but never had the time. Thank you! [19:28:57] looks like the diff is good. If using templates instead of repeating job definition works for you I will +2 it :) [19:29:01] ah good [19:29:01] +2. [19:29:06] \o/ [19:29:36] I have somewhere in my long list of things: "find a solution to avoid repeating the docker images version everywhere :D " [19:29:42] :-D [19:29:56] function selectrandomdockerimage: [19:30:42] Speaking of TODO items for CI, I really love how docker-pkg whines that we don't have a test.sh file in our docker images to verify they work. [19:37:07] yeah [19:37:22] we have some example-run.sh [19:47:08] then I am not sure how to write the tests :D [19:47:20] anyway I am off, feel free to CR+2 the node job-template change :) [22:02:35] 10GitLab (Account Approval), 10Release-Engineering-Team (Priority Backlog 📥): Requesting GitLab account activation for MarcoAurelio - https://phabricator.wikimedia.org/T347294 (10MarcoAurelio) Thanks @Aklapper - I could access now, but for some reason now my account is now `maurelio1` and not `maurelio`, which... [22:11:48] 10GitLab (Account Approval), 10Release-Engineering-Team (Priority Backlog 📥): Requesting GitLab account activation for MarcoAurelio - https://phabricator.wikimedia.org/T347294 (10MarcoAurelio) >>! In T347294#9201430, @MarcoAurelio wrote: > Thanks @Aklapper - I could access now, but for some reason now my accou... [23:07:29] 10GitLab (Account Approval), 10Release-Engineering-Team (Priority Backlog 📥): Requesting GitLab account activation for MarcoAurelio - https://phabricator.wikimedia.org/T347294 (10dancy) I deleted the `maurelio1` gitlab account. [23:36:17] Project beta-scap-sync-world build #122407: 04FAILURE in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-sync-world/122407/ [23:46:15] Yippee, build fixed! [23:46:15] Project beta-scap-sync-world build #122408: 09FIXED in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-sync-world/122408/