[00:17:08] 10Release-Engineering-Team (Priority Backlog πŸ“₯): gitlab-cloud-runner: Roll back pending helm releases before running terraform apply - https://phabricator.wikimedia.org/T354787 (10Sandeeps) Hi all, I wanted to update regarding the issue. As, I tried reproducing the error and doing Atomic = true setting didn't re... [02:28:16] 10Release-Engineering-Team (Onboarding πŸš€), 10Scap: scap backport check prevents using it to fix an about-to-be-live branch - https://phabricator.wikimedia.org/T317795 (10CodeReviewBot) sandeeps updated https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/208 Bug: T317795 [08:39:19] 10Gerrit, 10Upstream: Gerrit likes to replace tabs with spaces - https://phabricator.wikimedia.org/T355816 (10hashar) p:05Triageβ†’03Low When looking at the [[ https://issues.gerritcodereview.com/ | upstream bug tracker ]], I found [[ https://issues.gerritcodereview.com/issues/40006891 | 40006891 ]] which in... [09:16:13] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Projects-Cleanup, 10collaboration-services: Migrate SRE repositories to GitLab - Archiving unused Gerrit repositories - https://phabricator.wikimedia.org/T343707 (10LSobanski) operations/debs/phalerts [09:49:08] 10Continuous-Integration-Infrastructure, 10translatewiki.net, 10Regression, 10User-DannyS712: l10n-bot not self-approving patches - https://phabricator.wikimedia.org/T355857 (10DannyS712) [09:50:22] 10Continuous-Integration-Infrastructure, 10translatewiki.net, 10Regression, 10User-DannyS712: l10n-bot not self-approving patches - https://phabricator.wikimedia.org/T355857 (10DannyS712) p:05Triageβ†’03High Sorry if I didn't tag the right projects, wasn't sure where this should go [09:52:43] 10Continuous-Integration-Infrastructure, 10translatewiki.net, 10Regression, 10User-DannyS712: l10n-bot not self-approving patches - https://phabricator.wikimedia.org/T355857 (10DannyS712) Because its not giving its own +2 the full tests for the gate-and-submit pipeline are running instead of the dedicated... [10:21:09] 10Release-Engineering-Team (Radar), 10Tech-Docs-Team, 10Documentation: Improve deployment pipeline documentation structure - https://phabricator.wikimedia.org/T352264 (10KBach) With the [[ https://www.mediawiki.org/wiki/GitLab/Workflows/Deployment_pipeline | first version of deployment pipeline overview publ... [10:21:40] 10Release-Engineering-Team (Radar), 10Tech-Docs-Team, 10Documentation: Improve deployment pipeline documentation structure - https://phabricator.wikimedia.org/T352264 (10KBach) p:05Lowβ†’03Medium [11:34:12] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), 10Release, 10Train Deployments: 1.42.0-wmf.15 deployment blockers - https://phabricator.wikimedia.org/T354433 (10hashar) [11:59:51] hashar: looks like gate-and-submit is stuck [12:30:56] hmm, I guess it is moving forward, but very slowly. Some items in the queue are at 2+ hours. [12:33:15] kostajh: maybe due to https://phabricator.wikimedia.org/T355857#9487669 ? [12:35:14] could be [12:39:52] 10Release-Engineering-Team, 10Temporary accounts, 10Trust and Safety Product Team: MediaWiki unit and integration tests should pass when temp account feature flag is enabled - https://phabricator.wikimedia.org/T355879 (10kostajh) [12:41:41] 10Release-Engineering-Team, 10Temporary accounts, 10Trust and Safety Product Team, 10Patch-For-Review: MediaWiki PHPUnit tests should pass when temp account feature flag is enabled - https://phabricator.wikimedia.org/T355879 (10kostajh) [12:47:14] 10Gerrit, 10Upstream: Gerrit likes to replace tabs with spaces - https://phabricator.wikimedia.org/T355816 (10Reedy) I'm not sure either. I know we've had a few upgrades recently, and I'm not sure if there's been some different handling in those versions, and as such, the behaviour in the videos seems to be ne... [12:53:11] 10Release-Engineering-Team, 10Temporary accounts, 10Trust and Safety Product Team: Temp accounts deployment and the release train - https://phabricator.wikimedia.org/T355882 (10kostajh) [12:53:48] 10Release-Engineering-Team, 10Temporary accounts, 10Trust and Safety Product Team: Temp accounts deployment and the release train - https://phabricator.wikimedia.org/T355882 (10kostajh) @thcipriani who can work with us from #release-engineering-team to clarify this task and document its outcomes? [12:53:55] 10Release-Engineering-Team, 10Temporary accounts, 10Trust and Safety Product Team: Temp accounts deployment and the release train - https://phabricator.wikimedia.org/T355882 (10kostajh) [12:54:39] 10Release-Engineering-Team, 10Temporary accounts, 10Trust and Safety Product Team: Temp accounts deployment and the release train - https://phabricator.wikimedia.org/T355882 (10kostajh) [12:58:49] gate-and-submit cleared up now btw [13:16:42] 10Beta-Cluster-Infrastructure, 10DBA, 10MediaWiki-libs-Rdbms, 10SRE-Sprint-Week-Sustainability-March2023, 10Epic: Enable MariaDB/MySQL's Strict Mode - https://phabricator.wikimedia.org/T108255 (10Reedy) [15:19:22] https://integration.wikimedia.org/ci/job/mwext-php74-phan-docker/93369/console : SUCCESS in 1m 07s [15:19:23] AHAH [15:19:34] I have managed to send a patch for LiquidThreads WITHOUT breaking phan [15:19:36] I am happy [15:57:26] 10GitLab (Pipeline Services Migration🐀), 10AQS2.0, 10Thumbor: Migrate former Platform team service to GitLab - https://phabricator.wikimedia.org/T344739 (10WDoranWMF) @thcipriani We're reviewing tasks for #aqs2.0 - we're trying to figure out a priority for migrating the AQS 2 services to gitlab. Is there an... [16:24:38] (03PS1) 10Jforrester: Docker: Install php-ldap in top-level images for simplicity [integration/config] - 10https://gerrit.wikimedia.org/r/992976 [16:28:44] (03CR) 10Jforrester: [C: 03+2] Docker: Install php-ldap in top-level images for simplicity [integration/config] - 10https://gerrit.wikimedia.org/r/992976 (owner: 10Jforrester) [16:31:52] (03Merged) 10jenkins-bot: Docker: Install php-ldap in top-level images for simplicity [integration/config] - 10https://gerrit.wikimedia.org/r/992976 (owner: 10Jforrester) [16:32:35] !log Docker: Install php-ldap in top-level images for simplicity [16:32:57] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:49:03] 10Phabricator (Upstream), 10Release-Engineering-Team, 10Infrastructure-Foundations, 10Upstream, 10User-brennen: Ensure that phabricator.wikimedia.org adheres to Google's sender guidelines - https://phabricator.wikimedia.org/T355691 (10LSobanski) [16:49:33] 10Release-Engineering-Team, 10collaboration-services: Ensure that gitlab.wikimedia.org adheres to Google's sender guidelines - https://phabricator.wikimedia.org/T355776 (10LSobanski) [16:49:42] 10Release-Engineering-Team, 10collaboration-services: Ensure that gerrit.wikimedia.org adheres to Google's sender guidelines - https://phabricator.wikimedia.org/T355784 (10LSobanski) [16:51:54] (03PS1) 10Jforrester: jjb: Update all images to consolidated ones with LDAP extension at the top level [integration/config] - 10https://gerrit.wikimedia.org/r/992979 [16:54:28] (03CR) 10Jforrester: [C: 04-1] "Not for a while (CI will be building the images for another hour)" [integration/config] - 10https://gerrit.wikimedia.org/r/992979 (owner: 10Jforrester) [17:00:32] (03CR) 10Jforrester: [C: 03+2] "Successfully published image docker-registry.discovery.wmnet/releng/php83-compile:0.0.2" [integration/config] - 10https://gerrit.wikimedia.org/r/992976 (owner: 10Jforrester) [17:13:40] (03CR) 10Jforrester: [C: 03+2] "Deployed. All seems well." [integration/config] - 10https://gerrit.wikimedia.org/r/992979 (owner: 10Jforrester) [17:15:17] (03Merged) 10jenkins-bot: jjb: Update all images to consolidated ones with LDAP extension at the top level [integration/config] - 10https://gerrit.wikimedia.org/r/992979 (owner: 10Jforrester) [17:25:44] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), 10Release, 10Train Deployments: 1.42.0-wmf.15 deployment blockers - https://phabricator.wikimedia.org/T354433 (10hashar) 05Openβ†’03Resolved I am claiming 1.42.0-wmf.15 to be a success. Thank you for all the pat... [17:26:14] (03PS1) 10Pwangai: Zuul: [mediawiki/extensions/Wikisource] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/992984 (https://phabricator.wikimedia.org/T321837) [17:27:44] (03PS1) 10Pwangai: Zuul: [mediawiki/extensions/XAnalytics] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/992985 (https://phabricator.wikimedia.org/T321837) [17:29:02] (03PS1) 10Pwangai: Zuul: [mediawiki/extensions/CodeMirror] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/993006 (https://phabricator.wikimedia.org/T321837) [17:30:13] (03PS1) 10Pwangai: Zuul: [mediawiki/extensions/GuidedTour] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/993007 (https://phabricator.wikimedia.org/T321837) [18:27:57] 10GitLab (Project Migration), 10Traffic: Migrate DNS repository from Gerrit to Gitlab - https://phabricator.wikimedia.org/T355906 (10BCornwall) [18:28:55] 10GitLab (Project Migration), 10Traffic: Migrate DNS repository from Gerrit to Gitlab - https://phabricator.wikimedia.org/T355906 (10ssingh) [18:31:15] 10GitLab (Project Migration), 10Traffic: Migrate DNS repository from Gerrit to Gitlab - https://phabricator.wikimedia.org/T355906 (10BCornwall) [19:15:58] (03PS1) 10Jforrester: Docker: [quibble*] Re-install php-ldap, mistakenly dropped [integration/config] - 10https://gerrit.wikimedia.org/r/993018 [19:16:16] (03CR) 10Jforrester: [C: 03+2] Docker: [quibble*] Re-install php-ldap, mistakenly dropped [integration/config] - 10https://gerrit.wikimedia.org/r/993018 (owner: 10Jforrester) [19:17:29] (03Merged) 10jenkins-bot: Docker: [quibble*] Re-install php-ldap, mistakenly dropped [integration/config] - 10https://gerrit.wikimedia.org/r/993018 (owner: 10Jforrester) [19:17:46] !log Docker: [quibble*] Re-install php-ldap, mistakenly dropped [19:17:49] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:24:26] James_F: why did you need php-ldap in the base image? Afaik that is only needed for the related MediaWiki extensions [19:24:32] aka for wikitech stuff [19:24:43] hashar: We had it in almost every image, but not actually every image. [19:24:51] ahhh [19:25:00] hashar: So I thought I'd simplify (e.g. mediawiki-phan had it but composer didn't). [19:25:05] one day I'd like the base images to have all extensions installed but disabled [19:25:08] But then I screwed up because I forgot quibble doesn't inherit. [19:25:14] Yes. [19:25:22] then use a wrapper that looks at which extension are actually required in `composer.json` and solely activate those [19:25:35] then run whatever php command [19:25:37] Magic. [19:25:49] You're going to do that once we've moved to GitLab, right? ;-) [19:25:50] yeah [19:25:56] no [19:25:57] ah [19:25:58] wait [19:26:06] releng/gitlab-ci/php-magic-environment-runner [19:26:10] ;-) [19:26:39] * hashar lean at Github actions [19:26:44] who knows really [19:27:31] * James_F shudders. [19:29:23] (03PS1) 10Jforrester: jjb: Update quibble jobs to images with ldap again [integration/config] - 10https://gerrit.wikimedia.org/r/993021 [19:30:30] 10GitLab (Project Migration), 10Traffic: Migrate DNS repository from Gerrit to Gitlab - https://phabricator.wikimedia.org/T355906 (10ssingh) I think we should do this once the GitLab workflow has been established and tested, given the critical nature of this repository. That said, the transition should look li... [19:33:29] (03CR) 10Jforrester: [C: 03+2] jjb: Update quibble jobs to images with ldap again [integration/config] - 10https://gerrit.wikimedia.org/r/993021 (owner: 10Jforrester) [19:34:55] (03Merged) 10jenkins-bot: jjb: Update quibble jobs to images with ldap again [integration/config] - 10https://gerrit.wikimedia.org/r/993021 (owner: 10Jforrester) [19:39:32] 10GitLab (Integrations), 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Code-Health, 10Developer Productivity, 10User-brennen: Investigate whether we can/should integrate Git/Reviewers with GitLab - https://phabricator.wikimedia.org/T289712 (10dancy) The [[https://docs.gitlab.com/ee/user/profile/noti... [19:50:51] 10GitLab (Project Migration), 10Traffic: Migrate DNS repository from Gerrit to Gitlab - https://phabricator.wikimedia.org/T355906 (10ssingh) I wanted to add: I haven't looked at and don't understand GitLab permissions but we should make sure that the folks in fr-tech (Fundraising) can also commit to this repos... [20:37:15] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/CodeMirror] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/993006 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [20:37:18] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/GuidedTour] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/993007 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [20:37:20] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/Wikisource] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/992984 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [20:37:22] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/XAnalytics] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/992985 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [20:38:48] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/CodeMirror] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/993006 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [20:38:50] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/GuidedTour] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/993007 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [20:38:53] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/Wikisource] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/992984 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [20:38:55] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/XAnalytics] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/992985 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [20:39:49] !log Reloaded Zuul to enable Sonar Codehealth on CodeMirror, GuidedTour, Wikisource and XAnalytics # T321837 [20:39:52] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:39:53] T321837: Repositories integrated into Codehealth Pipeline (Production) - https://phabricator.wikimedia.org/T321837 [20:40:43] paladox: the Gerrit commentlink for commits is off by one somehow :) [20:40:53] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/LiquidThreads/+/992939 [20:41:00] the link enclose an extra space [20:41:30] link seems to still work [20:41:42] (space isn't included) but is in the title text [20:41:47] yeah but it captures the space before [20:45:04] cause the space is part of the match I guess [20:46:35] ah eay [20:46:38] ah easy [20:55:08] paladox: https://gerrit.wikimedia.org/r/c/operations/puppet/+/993029 gerrit: use finer groups for commit commentlink [20:55:08] :) [20:55:54] ohhhh. I don't think that's supported on 3.7 but is on 3.8 [20:55:57] err [20:56:04] whoops ignore the second part. [20:56:11] I just checked and forgot to remove it lol [20:56:14] ah maybe I have read the wrong doc [20:56:22] https://github.com/GerritCodeReview/gerrit/commit/2971ae3941bf02f07b2f951aae7e1ebb76a96639 [20:56:56] 3.7 aware! [20:56:57] ;) [20:58:44] hashar: works [21:01:12] paladox: may you +1 thechange stating you hvae tested it please? That would help Daniel merging it I guess [21:01:12] :) [21:01:26] done [21:01:30] \o/ [21:04:08] paladox: oh and Reedy filed a task about the code editor which for indentation uses spaces or tabs based on the user preference [21:04:28] so dependending on the project/file, that is the wrong indentation being picked up and one has to go to their user preference to change it [21:04:29] https://phabricator.wikimedia.org/T355816 [21:05:17] maybe the indentation can be detected from the file (typically if has some leading tabs, it is probably tabs indented) [21:05:31] but that is tricky to set [21:05:36] oh, you mean you want to auto check if the file has tabs and if so use that [21:05:42] maybe? [21:05:54] I don't think git has a way to indicate the preferred indentation :] [21:07:06] I wonder how it'd work with the preference. I guess "auto" could be added and default to that. [21:07:50] maybe [21:08:41] anyway that is merely an idea [21:08:49] 10Gerrit, 10Upstream: Gerrit likes to replace tabs with spaces - https://phabricator.wikimedia.org/T355816 (10Paladox) I think a potential fix is detecting if there's tabs in the file and using that but also adding "auto" to the preference. So the preference will indicated what to do whether to check the file... [21:10:24] patch deployed. gerrit config reloaded. [21:10:31] Applied configuration changes: [21:10:31] + commentlink.commit.prefix = $1 [21:10:31] + commentlink.commit.text = $2 [21:15:31] 10Gerrit, 10Upstream: Gerrit likes to replace tabs with spaces - https://phabricator.wikimedia.org/T355816 (10Paladox) Seems the REST API is "indent_with_tabs" so it's true / false. So we would have to either create a new option to allow the three options above or if indent_with_tabs is true then always indent... [22:56:26] 10GitLab (Integrations), 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Code-Health, 10Developer Productivity, 10User-brennen: Investigate whether we can/should integrate Git/Reviewers with GitLab - https://phabricator.wikimedia.org/T289712 (10dancy) @valhallasw Can you explain this section of `Revi... [23:24:53] 10Release-Engineering-Team, 10collaboration-services: Ensure that gerrit.wikimedia.org adheres to Google's sender guidelines - https://phabricator.wikimedia.org/T355784 (10Dzahn) confirmed SPF is "PASS with IP 208.80.154.76 " in mail header of a mail from Gerrit [23:26:27] 10Release-Engineering-Team, 10collaboration-services: Ensure that gerrit.wikimedia.org adheres to Google's sender guidelines - https://phabricator.wikimedia.org/T355784 (10Dzahn)