[05:33:46] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar), 10Code-Stewardship-Reviews: deployment-prep (beta cluster): Code stewardship request - https://phabricator.wikimedia.org/T215217#10009317 (10Joe) @bd808 to add to your point: We're near another inflection point for deployment-prep: soon the... [06:42:50] 10Release-Engineering-Team (Seen), 06collaboration-services, 10Data Pipelines, 06Data-Engineering, and 2 others: Upgrade Airflow to 2.9.3 - https://phabricator.wikimedia.org/T365449#10009338 (10Jelto) >>! In T365449#10006084, @Stevemunene wrote: > We need to look into getting the build working on the [[ ht... [08:48:43] vibe check: is it okay for extensions to assume that temporary accounts are enabled in CI? or can I consider it a bug if I find some tests that fail if temporary accounts are disabled? [08:49:47] (context is T356148 – EntitySchema CI fails due to temp accounts, and to be able to fix it in several separate commits I’d like to temporarily disable temp accounts in EntitySchema CI again, but it turns out that breaks some CheckUser tests) [08:49:47] T356148: Adjust EntitySchema Special Pages to not leak IPs when editing and IP masking is enabled - https://phabricator.wikimedia.org/T356148 [09:28:48] Lucas_WMDE: kostajh would know for sure, I am sorry I haven't followed the trend of how IP masking is enabled or not [09:29:24] I had a chat some weeks ago with Kosta in which I recommended always enabling it via includes/DevelopmentSettings.php [09:32:03] yes, IIUC DS.php currently enables it only in Quibble, and the plan was to remove that check (always make DS.php enable it) a bit later, with the testwiki rollout [09:34:47] yeah [09:34:59] Kosta point was to do a gradual rollout to avoid affecting everything [09:35:16] so I think on a local dev environment it is still disable [09:35:22] but Quibble and hence CI enforces it [09:35:53] then you get the usual chicken and egg problem that enabling the setting only broke the extensions that are tested when a patch is sent to mediawiki/core [09:36:20] (the wmf-quibble-* jobs) [09:36:31] and EntitySchema is not part of that and thus ends up broken [09:37:11] yeah :/ [09:37:26] so [09:37:46] ho and that was only turned on recently! [09:39:04] maybe the tests can be made to optout with something like `$this->setMwGlobals( 'wgAutoCreateTempUser', ['enabled' => true] );` [09:39:07] errr [09:39:13] `false` [09:39:15] :D [09:40:41] well yes, I tried that in “our” extension that’s broken *with* temp accounts, only to discover that our CI pulls in another extension that’s broken *without* temp accounts ^^ [09:40:51] hence my question whether that can be considered a bug in the other extension [09:41:04] or whether turning off temp accounts in any CI is just a non-starter [09:41:09] can it be made at the test level? [09:41:20] then ,of course if your test run mixed code ... that is a dead end :/ [09:41:24] but Dreamy_Jazz already +2ed https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1056449 and I found a solution for the other test that failed, so I’m optimistic [09:41:40] hashar: at least some of the test failures seemed to be in browser tests, I think [09:41:43] (though I’m not 100% sure) [09:41:53] but that might still be an option to consider, yeah [09:42:57] I think the idea is that every test that specifically depends on temporary accounts being enabled should specifically say so by enabling the config [09:43:05] and for browser tests it is even more complicated cause afaiik we don't have a way to set mw settings on a per test basis [09:43:39] This is because local environments may still have this disabled, but we don't want the tests to fail just because someone is not using temporary accounts on their local wiki. [09:49:09] *nods* sounds good to me [09:49:49] hashar: yeah, QUnit.newMwEnvironment() has a useful-looking `config` feature but that only sets client-side mw.config values [09:49:57] yup [09:49:58] :/ [09:52:57] I need to head out for some grocery shopping [09:53:01] + lunch with kids [10:15:51] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 06serviceops, 06SRE, and 2 others: Spin down api_appserver and appserver clusters - https://phabricator.wikimedia.org/T367949#10009738 (10ops-monitoring-bot) Icinga downtime and Alertmanager silence (ID=52c5c269-d4e9-4489-a397-00874b75eb1c) set by cgoubert@cu... [13:13:56] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10SonarQube Bot, 07Code-Health, 10Quality-and-Test-Engineering-Team (SonarCloud Admin): Improve speed of codehealth checks - https://phabricator.wikimedia.org/T351561#10010336 (10pwangai) I did a few optimizations, and they seem to have positively... [14:42:45] (03CR) 10Kosta Harlan: [C:03+2] Parallel PHPUnit: fix DatabaseLess result cache file name [integration/quibble] - 10https://gerrit.wikimedia.org/r/1055946 (owner: 10Hashar) [14:46:40] 10Release-Engineering-Team (Seen), 06cloud-services-team, 10Release Pipeline (Blubber): Intermittent package download failures during jenkins/pipeline tests - https://phabricator.wikimedia.org/T291135#10010891 (10joanna_borun) 05Open→03Invalid [14:57:13] Project beta-scap-sync-world build #164949: 04FAILURE in 2 min 5 sec: https://integration.wikimedia.org/ci/job/beta-scap-sync-world/164949/ [14:59:32] (03Merged) 10jenkins-bot: Parallel PHPUnit: fix DatabaseLess result cache file name [integration/quibble] - 10https://gerrit.wikimedia.org/r/1055946 (owner: 10Hashar) [15:02:30] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar), 10Code-Stewardship-Reviews: deployment-prep (beta cluster): Code stewardship request - https://phabricator.wikimedia.org/T215217#10010991 (10bd808) >>! In T215217#10009317, @Joe wrote: > @bd808 to add to your point: We're near another inflec... [15:07:12] Yippee, build fixed! [15:07:12] Project beta-scap-sync-world build #164950: 09FIXED in 2 min 6 sec: https://integration.wikimedia.org/ci/job/beta-scap-sync-world/164950/ [15:12:09] 10GitLab (Pipeline Services Migration🐤), 10Release-Engineering-Team (Priority Backlog 📥), 06cloud-services-team, 10Toolforge: Move Toolforge PipelineLib repositories to GitLab - https://phabricator.wikimedia.org/T334399#10011021 (10dcaro) 05Open→03Resolved a:03dcaro This is done [15:52:00] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar), 10Code-Stewardship-Reviews: deployment-prep (beta cluster): Code stewardship request - https://phabricator.wikimedia.org/T215217#10011197 (10Ottomata) > In theory we could then get folks to add config for this new environment to their Helm ch... [16:20:26] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar), 10Code-Stewardship-Reviews: deployment-prep (beta cluster): Code stewardship request - https://phabricator.wikimedia.org/T215217#10011380 (10Joe) >>! In T215217#10010991, @bd808 wrote: > I have been thinking about this general problem as well... [16:24:30] 10Beta-Cluster-Infrastructure, 06cloud-services-team, 10Cloud-VPS (Debian Buster Deprecation), 13Patch-For-Review: Remove or replace deployment-sessionstore04.deployment-prep.eqiad1.wikimedia.cloud (Buster deprecation) - https://phabricator.wikimedia.org/T370461#10011405 (10Southparkfan) 05Open→03Re... [16:25:54] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Buster Deprecation): Migrate deployment-prep away from Debian Buster to Bullseye/Bookworm - https://phabricator.wikimedia.org/T327742#10011411 (10Southparkfan) [16:49:24] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar), 10Code-Stewardship-Reviews: deployment-prep (beta cluster): Code stewardship request - https://phabricator.wikimedia.org/T215217#10011649 (10Ottomata) > We'll need to build a new image building pipeline (including a docker registry) beta cou... [16:50:42] 06Release-Engineering-Team, 06Data Products, 06Data-Platform-SRE, 10Dumps-Generation, and 2 others: Migrate current-generation dumps to run from our containerized images - https://phabricator.wikimedia.org/T352650#10011671 (10Ottomata) I think it will be quite a while before we are fully able to decom Dump... [16:51:00] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar), 10Code-Stewardship-Reviews: deployment-prep (beta cluster): Code stewardship request - https://phabricator.wikimedia.org/T215217#10011672 (10bd808) >>! In T215217#10011649, @Ottomata wrote: >> We'll need to build a new image building pipeline... [16:53:05] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar), 10Code-Stewardship-Reviews: deployment-prep (beta cluster): Code stewardship request - https://phabricator.wikimedia.org/T215217#10011665 (10bd808) >>! In T215217#10011380, @Joe wrote: > I think the problem is larger, especially if you talk a... [16:59:51] debug stuff https://phabricator.wikimedia.org/T370573#10002662 , in which I have learned Firefox has a rate limit for interaction with the browser history [16:59:52] get a developer to fix it (by mocking the browser API): https://gerrit.wikimedia.org/r/c/mediawiki/extensions/RevisionSlider/+/1056238/2/tests/qunit/RevisionSlider.DiffPage.test.js [16:59:59] WMDE-Fisch ^ congratulation on that fix ;) [17:02:09] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥), 06collaboration-services, 10Wikimedia-Apache-configuration, and 3 others: Apache 2.4.61 throws a 403 Forbidden for links containing %3F - https://phabricator.wikimedia.org/T370110#10011792 (10hashar) >>! In T370110#10007941, @Dzahn wrote: >>>!... [17:36:38] 10Deployments, 10Release-Engineering-Team (Priority Backlog 📥), 07Kubernetes: Build and publish multiple MediaWiki production images for a given set of PHP versions - https://phabricator.wikimedia.org/T370934 (10dduvall) 03NEW [17:37:48] 10Deployments, 10Release-Engineering-Team (Priority Backlog 📥), 07Kubernetes: Build and publish multiple MediaWiki production images for a given set of PHP versions - https://phabricator.wikimedia.org/T370934#10012048 (10dduvall) [18:08:38] 10Phabricator: Maintenance_bot removing patch-for-review cause archived projects to be removed from task - https://phabricator.wikimedia.org/T370940 (10hashar) 03NEW [18:10:56] 10Release-Engineering-Team (Radar), 06collaboration-services, 06SRE, 06Traffic, 13Patch-For-Review: implement anti-abuse features for GitLab (Move GitLab behind the CDN) - https://phabricator.wikimedia.org/T366882#10012178 (10Dzahn) gitlab1003 and gitlab1004 are unchanged. gitlab2002 now has the new fil... [18:12:28] 10Phabricator: Maintenance_bot removing patch-for-review cause archived projects to be removed from task - https://phabricator.wikimedia.org/T370940#10012184 (10hashar) [18:42:45] 10Phabricator: Maintenance_bot removing patch-for-review cause archived projects to be removed from task - https://phabricator.wikimedia.org/T370940#10012344 (10matmarex) They were probably removed not because they're archived, but because https://phabricator.wikimedia.org/tag/wmf-deploy-2016-06-28_1.28.0-wmf.8/... [18:46:51] 06Release-Engineering-Team: Update SQL output - https://phabricator.wikimedia.org/T370947 (10ARamirez_WMF) 03NEW [18:50:19] 10Phabricator, 06Release-Engineering-Team, 06collaboration-services: Update SQL output - https://phabricator.wikimedia.org/T370947#10012409 (10Dzahn) [18:51:00] 10Phabricator, 06Release-Engineering-Team, 06collaboration-services: Update SQL output for Phabricator WMF QLS report mails - https://phabricator.wikimedia.org/T370947#10012414 (10Dzahn) [18:51:38] 10Phabricator, 06Release-Engineering-Team, 06collaboration-services: Update SQL output for Phabricator WMF QLS report mails - https://phabricator.wikimedia.org/T370947#10012415 (10Dzahn) [19:05:28] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for Taychemu - https://phabricator.wikimedia.org/T370949 (10Taychemu) 03NEW [19:16:20] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for [mirji] - https://phabricator.wikimedia.org/T370744#10012496 (10Pppery) I've added you to #trusted-contributors. If you connect your LDAP account to your Phabricator account at https://phabricator.wikimedia.org/se... [19:41:02] (03PS2) 10Matěj Suchánek: Add AbuseFilter as dependency for Thanks extensions [integration/config] - 10https://gerrit.wikimedia.org/r/1056591 [19:41:11] (03PS3) 10Matěj Suchánek: Add AbuseFilter as dependency for Thanks [integration/config] - 10https://gerrit.wikimedia.org/r/1056591 [19:47:46] 10Deployments, 10Release-Engineering-Team (Priority Backlog 📥), 07Kubernetes: Build and publish multiple MediaWiki production images for a given set of PHP versions - https://phabricator.wikimedia.org/T370934#10012596 (10bd808) [19:49:30] 10Deployments, 10Release-Engineering-Team (Priority Backlog 📥), 07Kubernetes: Build and publish multiple MediaWiki production images for a given set of PHP versions - https://phabricator.wikimedia.org/T370934#10012601 (10bd808) [20:06:43] :sad_trombone: I was going to play with the temporary account stuff on testwii, but I forgot that I am IP range blocked from editing all wikis because the stewards decided the he.net 6in4 service is an anon-proxy. [20:39:47] hey releng, I'm having issues running https://gitlab.wikimedia.org/repos/data-engineering/git-sync/-/blob/main/.gitlab-ci.yml?ref_type=heads on the trusted runners...I'm probably missing something obvious, but do you mind taking a look? [21:13:40] (03open) 10dancy: Container image build system mods [repos/releng/release] - 10https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/96 [21:26:22] (03update) 10dancy: Container image build system mods [repos/releng/release] - 10https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/96 [21:33:50] (03update) 10dancy: Draft: Container image build system mods [repos/releng/release] - 10https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/96 [22:07:48] [non-urgent] would anyone here be able to point me to the source of truth that populates [0]? I can't seem to find that documented anywhere, but I'm probably overlooking something :) [22:07:48] [0] https://wikitech.wikimedia.org/wiki/Deployments/Yearly_calendar [22:10:14] swfrench-wmf: to the best of my knowledge, that calendar is hand-curated. [22:11:28] ah! that would explain it, then [22:11:40] brennen: thank you! [22:12:19] mainly by thcipriani as a best-effort sort of thing, i think. wmf holidays, release engineering specific stuff, and things like data center switchovers probably feed in. [22:12:50] https://office.wikimedia.org/wiki/People_Corner/Holiday_List would be one feed of data used [22:13:30] got it, that makes sense - thank you both [22:13:33] ^ hand rolled, me + others (Jam.es_F beats me to it often) [22:14:37] cool, I'll just go ahead and hand edit (the September DC switchover dates need updated) [22:15:11] (03PS1) 10Krinkle: Review access change [php] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/1056611 [22:15:45] (03CR) 10Krinkle: [V:03+2 C:03+2] Review access change [php] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/1056611 (owner: 10Krinkle) [22:16:16] (03Abandoned) 10Krinkle: Review access change [php] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/1056611 (owner: 10Krinkle) [22:16:39] inflatador: still having trouble? [23:30:16] 10Phabricator: Maintenance_bot removing patch-for-review cause archived projects to be removed from task - https://phabricator.wikimedia.org/T370940#10013288 (10Aklapper) 05Open→03Invalid Phabricator does not remove archived projects (as that would destroy valid information). The screenshot shows that "M...