[00:00:54] FIRING: DatasourceError: Queue (Jenkins jobs + Zuul functions) alert - https://grafana.wikimedia.org/alerting/grafana/iS0FSjJ4z/view - https://wikitech.wikimedia.org/wiki/Monitoring/DatasourceError - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [00:05:54] RESOLVED: DatasourceError: Queue (Jenkins jobs + Zuul functions) alert - https://grafana.wikimedia.org/alerting/grafana/iS0FSjJ4z/view - https://wikitech.wikimedia.org/wiki/Monitoring/DatasourceError - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [00:19:35] (03open) 10dduvall: jobs: Clean up l10n files using docker and copy all private settings [repos/releng/jenkins-deploy] - 10https://gitlab.wikimedia.org/repos/releng/jenkins-deploy/-/merge_requests/84 (https://phabricator.wikimedia.org/T369115) [00:19:36] (03update) 10dduvall: jobs: Clean up l10n files using docker and copy all private settings [repos/releng/jenkins-deploy] - 10https://gitlab.wikimedia.org/repos/releng/jenkins-deploy/-/merge_requests/84 (https://phabricator.wikimedia.org/T369115) [00:19:55] (03update) 10dduvall: jobs: Clean up l10n files using docker and copy all private settings [repos/releng/jenkins-deploy] - 10https://gitlab.wikimedia.org/repos/releng/jenkins-deploy/-/merge_requests/84 (https://phabricator.wikimedia.org/T369115) [00:19:56] (03update) 10dduvall: jobs: Clean up l10n files using docker and copy all private settings [repos/releng/jenkins-deploy] - 10https://gitlab.wikimedia.org/repos/releng/jenkins-deploy/-/merge_requests/84 (https://phabricator.wikimedia.org/T369115) [00:38:50] (03CR) 10Subramanya Sastry: Workaround for bug T375822 (031 comment) [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076036 (owner: 10Jdlrobson) [01:02:33] (03PS2) 10Jdlrobson: Workaround for bug T375822 [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076036 [01:02:46] (03CR) 10Jdlrobson: Workaround for bug T375822 (031 comment) [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076036 (owner: 10Jdlrobson) [01:36:27] (03PS1) 10Brian Wolff: Enable coverage for Hashtags extension [integration/config] - 10https://gerrit.wikimedia.org/r/1076055 [02:20:45] (03PS3) 10Subramanya Sastry: MFE: Workaround for bug T375822 [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076036 (owner: 10Jdlrobson) [02:20:48] (03CR) 10Subramanya Sastry: [C:03+2] MFE: Workaround for bug T375822 [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076036 (owner: 10Jdlrobson) [02:21:17] (03Merged) 10jenkins-bot: MFE: Workaround for bug T375822 [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076036 (owner: 10Jdlrobson) [08:45:38] (03PS1) 10Kosta Harlan: zuul: Re-enable parallel PHPUnit for 7.4 jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1076148 (https://phabricator.wikimedia.org/T50217) [08:46:30] 10GitLab (Infrastructure), 06collaboration-services: Add visualizations to GitLab logstash dashboard - https://phabricator.wikimedia.org/T375849 (10Jelto) 03NEW [09:09:37] 10GitLab (Infrastructure), 06collaboration-services: Add visualizations to GitLab logstash dashboard - https://phabricator.wikimedia.org/T375849#10182262 (10Jelto) [09:53:30] (03PS1) 10QChris: Zuul: [design/codex-php] Add CI [integration/config] - 10https://gerrit.wikimedia.org/r/1076164 [09:58:27] 06Project-Admins: Proposal for the creation of a 'ceph' tag in phabricator - https://phabricator.wikimedia.org/T375856 (10BTullis) 03NEW [10:06:33] (03CR) 10QChris: Zuul: [design/codex-php] Add CI (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/1076164 (owner: 10QChris) [10:15:36] GitLab needs a short maintenance at 11:00 UTC (in 45 minutes) [10:31:10] <_Gerges> Hi [10:31:17] <_Gerges> Ping [10:34:09] <_Gerges> I'm thinking of making a JavaScript tool to display Wikipedia campaign ads by country, but I would like to know if there is an API from Wikimedia that can get the country of visitors? [11:08:25] GitLab maintenance finished [11:11:28] (03open) 10jelto: gitlab-runner: bump image version to alpine-v17.2.1 [repos/releng/gitlab-cloud-runner] - 10https://gitlab.wikimedia.org/repos/releng/gitlab-cloud-runner/-/merge_requests/413 (https://phabricator.wikimedia.org/T375710) [11:14:30] 10GitLab (Infrastructure), 06collaboration-services: Add visualizations to GitLab logstash dashboard - https://phabricator.wikimedia.org/T375849#10182647 (10Jelto) p:05Triage→03Medium a:03Jelto [11:23:25] 06Release-Engineering-Team, 10MediaWiki-Core-Tests, 07Developer Productivity, 10MediaWiki-Platform-Team (Radar): Create a daily job running core + extension PHPUnit tests serially - https://phabricator.wikimedia.org/T372618#10182669 (10kostajh) >>! In T372618#10170375, @hashar wrote: > Note: the `wmf-quibb... [11:46:52] 10GitLab (Infrastructure), 06collaboration-services: Add visualizations to GitLab logstash dashboard - https://phabricator.wikimedia.org/T375849#10182713 (10Jelto) 05Open→03Resolved [11:47:15] 10GitLab (Infrastructure), 06collaboration-services: Add visualizations to GitLab logstash dashboard - https://phabricator.wikimedia.org/T375849#10182711 (10Jelto) I was able to mostly replicate the Gerrit ESC logstash dashboard for GitLab: https://logstash.wikimedia.org/app/dashboards#/view/38dc4c50-7cae-... [12:03:25] 10Release-Engineering-Team (Radar), 06collaboration-services, 06SRE, 06Traffic, 13Patch-For-Review: implement anti-abuse features for GitLab (Move GitLab behind the CDN) - https://phabricator.wikimedia.org/T366882#10182766 (10Jelto) I added a summary of the rate limiting and abuse tooling (including nfta... [13:00:43] 10GitLab (Administration, Settings & Policy), 10Release-Engineering-Team (Priority Backlog 📥), 06collaboration-services, 06Java-Scala-Standardization, 10Data-Platform-SRE (2024.09.28 - 2024.10.18): Create a Maven package registry in Gitlab - https://phabricator.wikimedia.org/T367322#10183085 (10Gehel) [13:02:24] 10GitLab (Pipeline Services Migration🐤), 06collaboration-services, 10Wikidata, 10Wikidata Query UI, and 3 others: move commons-query.wikimedia.org and query.wikidata.org to kubernetes - https://phabricator.wikimedia.org/T350793#10183083 (10Gehel) [14:03:14] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T373643#10183347 (10thcipriani) 05Open→03Resolved [14:59:58] (03merge) 10dancy: gitlab-runner: bump image version to alpine-v17.2.1 [repos/releng/gitlab-cloud-runner] - 10https://gitlab.wikimedia.org/repos/releng/gitlab-cloud-runner/-/merge_requests/413 (https://phabricator.wikimedia.org/T375710) (owner: 10jelto) [15:02:38] (03approved) 10dancy: jobs: Clean up l10n files using docker and copy all private settings [repos/releng/jenkins-deploy] - 10https://gitlab.wikimedia.org/repos/releng/jenkins-deploy/-/merge_requests/84 (https://phabricator.wikimedia.org/T369115) (owner: 10dduvall) [15:36:37] (03PS1) 10Umherirrender: Zuul: [mediawiki/skins/TuleapSkin] Add TuleapIntegration phan dep [integration/config] - 10https://gerrit.wikimedia.org/r/1076221 [15:48:41] 10Continuous-Integration-Config, 06Abstract Wikipedia team, 10ci-test-error (WMF-deployed Build Failure): Dependency list for WikiLambda has suddenly expanded, including gate which doesn't pass (AbuseFilter/CheckUser/Flow/Linter/Echo/Thank/VisualEditor don't pass) - https://phabricator.wikimedia.org/T375894 (... [15:50:29] 10Continuous-Integration-Config, 06Abstract Wikipedia team, 10ci-test-error (WMF-deployed Build Failure): Dependency list for WikiLambda has suddenly expanded, including gate which doesn't pass (AbuseFilter/CheckUser/Flow/Linter/Echo/Thank/VisualEditor don't... - https://phabricator.wikimedia.org/T375894#10183767 [15:54:14] 10Continuous-Integration-Config, 06Abstract Wikipedia team, 10ci-test-error (WMF-deployed Build Failure): Dependency list for WikiLambda has suddenly expanded, including gate which doesn't pass (AbuseFilter/CheckUser/Flow/Linter/Echo/Thank/VisualEditor don't... - https://phabricator.wikimedia.org/T375894#10183781 [15:55:38] (03PS1) 10Jforrester: Zuul: [mediawiki/extensions/WikimediaMessages] Drop MobileFrontend dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1076223 (https://phabricator.wikimedia.org/T375894) [16:07:03] 10Release-Engineering-Team (Seen), 10ci-test-error (WMF-deployed Build Failure): Various CI jobs failing with: Could not resolve host: gerrit.wikimedia.org - https://phabricator.wikimedia.org/T374830#10183838 (10thcipriani) [16:07:27] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Seen), 10ci-test-error (WMF-deployed Build Failure): Various CI jobs failing with: Could not resolve host: gerrit.wikimedia.org - https://phabricator.wikimedia.org/T374830#10183839 (10thcipriani) [16:09:14] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Seen), 10ci-test-error (WMF-deployed Build Failure): Various CI jobs failing with: Could not resolve host: gerrit.wikimedia.org - https://phabricator.wikimedia.org/T374830#10183843 (10thcipriani) As a simple reproduction case, I tried `whil... [16:12:28] (03CR) 10Bartosz Dziewoński: "I thought the dependencies were not supposed to be transitive?" [integration/config] - 10https://gerrit.wikimedia.org/r/1076223 (https://phabricator.wikimedia.org/T375894) (owner: 10Jforrester) [16:13:45] James_F: hi. ugh, sorry about that [16:13:52] MatmaRex: I forgot too. [16:14:04] MatmaRex: Long-term we need to fix AbuseFilter's tests' assumptions. [16:14:05] But… [16:14:29] James_F: i thought the dependencies were not supposed to be transitive. is that expected that they are? [16:14:42] phan-deps are non-transitive. Regular deps are. [16:15:01] So e.g. if you depend on EventLogging and EventLogging starts depending on EventBus you don't need to add EventBus to ~200 extensions. [16:15:59] hmm. okay [16:16:21] But it's not obvious that adding MF adds half of production. [16:16:25] it also surprises me that WikiLambda depends on WikimediaMessages. doesn't that make it impossible to use outside of our deployment? :/ [16:16:49] MatmaRex: Yes, that's intentional. It's the Wikifunctions.org extension, we don't expect and don't support third party use. [16:17:02] hmm. [16:17:06] is that dependency just for those copyrightwarning messages? [16:17:13] Yes. [16:17:24] Structure i18n message existence check will fail without it. [16:17:56] And Legal wanted the legal messages defined in the standard place so they could monitor. [16:20:07] i think usually we'd have a default message for this defined in the extension, and a hook with a handler in WikimediaMessages to replace it. but that it definitely more complex [16:20:09] (03update) 10dduvall: jobs: Clean up l10n files using docker and copy all private settings [repos/releng/jenkins-deploy] - 10https://gitlab.wikimedia.org/repos/releng/jenkins-deploy/-/merge_requests/84 (https://phabricator.wikimedia.org/T369115) [16:20:18] there are examples of that in DiscussionTools and in Flow [16:21:02] Yeah, replacing the message is "standard" but then we'll end up with a message in WikiLambda saying "this is just a test message, if you see this in prod call Legal right now". [16:21:46] Legal barely cared when i found a couple years ago that we had the wrong copyright messages on a bunch of wikis [16:21:48] anyway [16:21:54] James_F: okay, so i guess we should go with your revert, and i'll write some patch to make WikimediaMessages PHPUnit pass without MobileFrontend [16:21:55] :-( [16:22:21] MatmaRex: OK for now, but we should actually fix the tests and re-enable some time soonish. [16:22:26] (03CR) 10Jforrester: [C:03+2] Zuul: [mediawiki/extensions/WikimediaMessages] Drop MobileFrontend dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1076223 (https://phabricator.wikimedia.org/T375894) (owner: 10Jforrester) [16:23:29] MatmaRex: And thank you! [16:23:50] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/WikimediaMessages] Drop MobileFrontend dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1076223 (https://phabricator.wikimedia.org/T375894) (owner: 10Jforrester) [16:24:00] !log Zuul: [mediawiki/extensions/WikimediaMessages] Drop MobileFrontend dependency for now, for T375894 [16:24:00] James_F: my WikiLambda patch is probably still useful… i'm not sure if that code still fails without the extra dependencies, but it looks like it should fail [16:24:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:24:04] T375894: Dependency list for WikiLambda has suddenly expanded, including gate which doesn't pass (AbuseFilter/CheckUser/Flow/Linter/Echo/Thank/VisualEditor don't pass) - https://phabricator.wikimedia.org/T375894 [16:24:10] MatmaRex: It looks good, yes. [16:24:15] (it didn't fail for me locally) [16:26:05] Clone list on https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-phpunit-standalone/4896/console is back to "normal". [16:28:22] Yup, only failures are in MediaWiki\Extension\WikimediaMessages\Tests\Unit\HooksTest ("Unrecognized parameter type MobileContext") [16:29:23] MatmaRex: Are you just going to do an inline @phan-var annotation? [16:30:05] James_F: Phan should pass, it's a PHPUnit test failure [16:30:29] James_F: it's something that tries to magically mock a MobileContext without knowing what it is. i think i almost have it working [16:30:39] Ha. [16:31:59] (03CR) 10Bartosz Dziewoński: "(explanation: Phan dependencies are not, but the others are)" [integration/config] - 10https://gerrit.wikimedia.org/r/1076223 (https://phabricator.wikimedia.org/T375894) (owner: 10Jforrester) [16:32:18] James_F: let's see if this works: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaMessages/+/1076230 it passed locally [16:35:40] (03open) 10dduvall: build-images: Skip JSON/MD5 l10n generation [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/461 (https://phabricator.wikimedia.org/T369115) [16:35:40] (03update) 10dduvall: build-images: Skip JSON/MD5 l10n generation [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/461 (https://phabricator.wikimedia.org/T369115) [16:35:49] (03update) 10dduvall: build-images: Skip JSON/MD5 l10n generation [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/461 (https://phabricator.wikimedia.org/T369115) [16:35:52] (03update) 10dduvall: build-images: Skip JSON/MD5 l10n generation [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/461 (https://phabricator.wikimedia.org/T369115) [16:39:21] (03approved) 10dancy: build-images: Skip JSON/MD5 l10n generation [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/461 (https://phabricator.wikimedia.org/T369115) (owner: 10dduvall) [16:54:32] (03PS1) 10QChris: Zuul: [design/codex-php] Add CI [integration/config] - 10https://gerrit.wikimedia.org/r/1076164 [17:15:19] James_F: looks good. want to +2 them? https://gerrit.wikimedia.org/r/q/topic:"WikimediaMessages-MobileFrontend" [17:15:39] Done. [17:57:14] (03PS1) 10Jdlrobson: DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 [17:57:39] (03CR) 10CI reject: [V:04-1] DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 (owner: 10Jdlrobson) [18:00:14] (03PS2) 10Jdlrobson: DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 [18:00:20] (03CR) 10CI reject: [V:04-1] DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 (owner: 10Jdlrobson) [18:01:51] 10Continuous-Integration-Config, 06Abstract Wikipedia team, 10ci-test-error (WMF-deployed Build Failure), 10MW-1.43-notes (1.43.0-wmf.25; 2024-10-01): Dependency list for WikiLambda has suddenly expanded, including gate which doesn't pass (AbuseFilter/Che... - https://phabricator.wikimedia.org/T375894#10184238 [18:03:10] (03PS3) 10Jdlrobson: DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 [18:03:22] (03CR) 10CI reject: [V:04-1] DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 (owner: 10Jdlrobson) [18:09:26] (03PS4) 10Jdlrobson: DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 [18:10:01] (03CR) 10CI reject: [V:04-1] DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 (owner: 10Jdlrobson) [18:17:45] (03PS5) 10Jdlrobson: DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 [18:28:47] (03PS2) 10Eric Gardner: Zuul: [design/codex-php] Add CI [integration/config] - 10https://gerrit.wikimedia.org/r/1076164 (https://phabricator.wikimedia.org/T373940) (owner: 10QChris) [18:30:16] (03CR) 10CI reject: [V:04-1] Zuul: [design/codex-php] Add CI [integration/config] - 10https://gerrit.wikimedia.org/r/1076164 (https://phabricator.wikimedia.org/T373940) (owner: 10QChris) [18:33:31] (03PS3) 10Eric Gardner: Zuul: [design/codex-php] Add CI [integration/config] - 10https://gerrit.wikimedia.org/r/1076164 (https://phabricator.wikimedia.org/T373940) (owner: 10QChris) [18:54:09] (03CR) 10Subramanya Sastry: "the adaptor code already does p-br-p cleanups, so I am going to abandon this patch. I'll tweak the adaptor code if necessary for future vi" [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 (owner: 10Jdlrobson) [18:54:17] (03Abandoned) 10Subramanya Sastry: DRY up clean BR tags code and do not apply to P without children [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1076245 (owner: 10Jdlrobson) [18:55:40] (03open) 10swfrench: kubernetes: generalize deployments configuration [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/462 (https://phabricator.wikimedia.org/T370934) [18:59:07] (03update) 10swfrench: kubernetes: generalize deployments configuration [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/462 (https://phabricator.wikimedia.org/T370934) [19:40:27] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.25 deployment blockers - https://phabricator.wikimedia.org/T375656#10184573 (10thcipriani) p:05Triage→03Medium a:03hashar [20:07:08] (03CR) 10Abaris: Zuul: [design/codex-php] Add CI [integration/config] - 10https://gerrit.wikimedia.org/r/1076164 (https://phabricator.wikimedia.org/T373940) (owner: 10QChris) [20:12:25] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.26 deployment blockers - https://phabricator.wikimedia.org/T375657#10184644 (10thcipriani) p:05Triage→03Medium a:03Aklapper [20:12:55] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T375658#10184649 (10thcipriani) p:05Triage→03Medium a:03jeena [20:13:41] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T375659#10184654 (10thcipriani) p:05Triage→03Medium a:03dancy [20:14:12] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.44.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T375660#10184661 (10thcipriani) p:05Triage→03Medium a:03dduvall [20:14:46] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.44.0-wmf.2 deployment blockers - https://phabricator.wikimedia.org/T375661#10184667 (10thcipriani) p:05Triage→03Medium a:03jnuche [20:16:30] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.44.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T375662#10184672 (10thcipriani) p:05Triage→03Medium a:03brennen [20:32:26] 10Release-Engineering-Team (Priority Backlog 📥), 10Scap: Separate scap client and server distributions - https://phabricator.wikimedia.org/T374983#10184747 (10thcipriani) [20:56:09] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T373643#10184806 (10thcipriani) Stats: - [[ https://www.mediawiki.org/wiki/MediaWiki_1.43/wmf.24 | 314 Changes ]] █▃▄▁▂ (📈 +15% vs last week) -- in 84 re...