[00:02:47] 06Release-Engineering-Team, 10MW-on-K8s, 06serviceops, 13Patch-For-Review: Refactor scap's kubernetes DeploymentsConfig to support selection of image kinds - https://phabricator.wikimedia.org/T389499#10672055 (10Scott_French) [00:05:27] 10Continuous-Integration-Infrastructure, 10CampaignEvents, 10Campaigns-Product-Team (Campaign-Tools-Current-Sprint), 07ci-test-error: api-testing CI failure: Timeout of 5000ms exceeded in "before all" hook in "POST /campaignevents/v0/event_registration" - https://phabricator.wikimedia.org/T389863#10672056 (... [00:21:35] (03PS2) 10Jeena Huneidi: Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 [00:21:35] (03PS9) 10Jeena Huneidi: WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [00:22:49] (03CR) 10CI reject: [V:04-1] Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 (owner: 10Jeena Huneidi) [00:23:20] (03CR) 10CI reject: [V:04-1] WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [00:32:58] (03PS3) 10Jeena Huneidi: Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 [00:32:58] (03PS10) 10Jeena Huneidi: WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [00:34:14] (03CR) 10CI reject: [V:04-1] WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [00:34:14] (03CR) 10CI reject: [V:04-1] Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 (owner: 10Jeena Huneidi) [00:37:44] (03PS4) 10Jeena Huneidi: Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 [00:37:44] (03PS11) 10Jeena Huneidi: WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [00:38:59] (03CR) 10CI reject: [V:04-1] Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 (owner: 10Jeena Huneidi) [00:39:01] (03CR) 10CI reject: [V:04-1] WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [00:40:51] 10Continuous-Integration-Infrastructure, 06Test-Platform, 07ci-test-error, 10MinervaNeue (Tracking): Minerva test builds are failing after recent Selenium upgrades - https://phabricator.wikimedia.org/T389889#10672103 (10Daimona) I'm not sure at first glance what might be wrong, but one thing worth emphasiz... [00:54:54] 10Continuous-Integration-Infrastructure, 06Test-Platform, 07ci-test-error, 10MinervaNeue (Tracking): Minerva test builds are failing after recent Selenium upgrades - https://phabricator.wikimedia.org/T389889#10672113 (10Daimona) >>! In T389889#10672103, @Daimona wrote: > Sure enough, it cannot login: the p... [01:17:05] (03PS5) 10Jeena Huneidi: Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 [01:17:05] (03PS12) 10Jeena Huneidi: WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [01:18:17] (03CR) 10CI reject: [V:04-1] WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [01:18:17] (03CR) 10CI reject: [V:04-1] Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 (owner: 10Jeena Huneidi) [01:26:34] (03PS6) 10Jeena Huneidi: Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 [01:26:34] (03PS13) 10Jeena Huneidi: WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [01:33:24] (03PS7) 10Jeena Huneidi: Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 [01:34:13] (03PS14) 10Jeena Huneidi: WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [01:37:39] (03CR) 10Jeena Huneidi: "I need to merge and publish the dockerfile before I can test in Jenkins, but if you have any comments before then please lmk." [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [02:53:57] (03CR) 10Thcipriani: [C:03+1] Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 (owner: 10Jeena Huneidi) [02:56:03] 10Phabricator, 10WMF-General-or-Unknown: Create phorge.wikimedia.org as a redirect to Phab - https://phabricator.wikimedia.org/T389907 (10Rexogamer) 03NEW [02:59:20] 10Phabricator, 10WMF-General-or-Unknown: Create phorge.wikimedia.org as a redirect to Phab - https://phabricator.wikimedia.org/T389907#10672255 (10Reedy) p:05Triageβ†’03Low [03:21:01] 10Phabricator, 10WMF-General-or-Unknown: Create phorge.wikimedia.org as a redirect to Phab - https://phabricator.wikimedia.org/T389907#10672272 (10Pppery) β†’14Duplicate dup:03T370778 [03:21:02] 10Phabricator: Make phorge.wikimedia.org a redirect to phabricator.wikimedia.org - https://phabricator.wikimedia.org/T370778#10672274 (10Pppery) [03:21:03] 10Phabricator, 10WMF-General-or-Unknown: Create phorge.wikimedia.org as a redirect to Phab - https://phabricator.wikimedia.org/T389907#10672277 (10Pppery) Sorry. [03:25:40] lol [03:44:46] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for Paul26 - https://phabricator.wikimedia.org/T389875#10672314 (10Pppery) [03:47:20] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for davidcoronel - https://phabricator.wikimedia.org/T389444#10672319 (10Pppery) 05Openβ†’03Resolved a:03glaab https://wikitech.wikimedia.org/w/index.php?title=Tool:Gitlab-account-approval/Log&diff=prev&oldid=... [04:13:33] (03CR) 10Jeena Huneidi: [C:03+2] Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 (owner: 10Jeena Huneidi) [04:14:49] (03Merged) 10jenkins-bot: Add catalyst dockerfile [integration/config] - 10https://gerrit.wikimedia.org/r/1130729 (owner: 10Jeena Huneidi) [04:18:15] !log Updating docker-pkg files on contint primary for https://gerrit.wikimedia.org/r/1130729 [04:18:16] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:57:19] (03PS15) 10Jeena Huneidi: WIP: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [05:00:37] (03PS16) 10Jeena Huneidi: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [05:06:34] (03CR) 10Jeena Huneidi: "I manually triggered a test run and the environment creation succeeded, but the selenium test had a problem: https://integration.wikimedia" [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [05:08:47] (03CR) 10Jeena Huneidi: "The post build script for environment deletion also didn't run." [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [07:11:44] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for Paul26 - https://phabricator.wikimedia.org/T389875#10672505 (10Aklapper) @Paul26: Please connect your LDAP account to your Phabricator account on https://phabricator.wikimedia.org/settings/panel/external/ under "A... [07:47:57] 10Scap, 13Patch-For-Review: Scap seemingly doesn't fully/properly clean backup deployment server - https://phabricator.wikimedia.org/T389830#10672570 (10hashar) The weekly train cleaning task did find the old branches and deleted them all: ` 04:00:08 Cleaning branches: 1.43.0-wmf.22, 1.43.0-wmf.23, 1.43.0-wmf.... [09:10:41] (03PS1) 10Krinkle: zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 [09:11:14] hashar: the inheritence is worse than I thought, the chains never end, it's so much unexpected [09:11:33] Math > Wikibase > ArticlePlaceholder > WikibaseCirrusSearch > CirrusSearch > WikibaseLexeme [09:12:14] Each of these steps makes sense if the patch is submitted to the one right before it. E.g. CirrusSearch picks WikibaseLexeme as downstream partner, and WikibaseCirrusSearch picks Cirrus as upstream partner [09:12:25] but none of these are of interest to ArticlePlaceholder or Math. [09:13:22] I think I would recommend option 1, but let me know what you think. I've implemented your suggestion to detect hard dependencies that we neglected to list and incldue those above the # marker [09:24:19] I'll do a version later with the extra omitted. Then PS1..2 can be reviewed as the actual change [09:36:49] 10Phabricator, 10Release-Engineering-Team (Doing 😎): Upstream src/herald/SetSubtypeHeraldAction.php - https://phabricator.wikimedia.org/T389686#10672865 (10Aklapper) [09:36:56] 10Phabricator, 10Release-Engineering-Team (Doing 😎): Upstream src/herald/SetSubtypeHeraldAction.php - https://phabricator.wikimedia.org/T389686#10672866 (10Aklapper) [09:36:57] 10Phabricator, 10Release-Engineering-Team (Priority Backlog πŸ“₯): Update to Phorge upstream 2025.xx release - https://phabricator.wikimedia.org/T386558#10672867 (10Aklapper) [09:38:08] 10Phabricator, 10Release-Engineering-Team (Priority Backlog πŸ“₯): Upstream src/herald/SetSubtypeHeraldAction.php - https://phabricator.wikimedia.org/T389686#10672869 (10Aklapper) [09:59:27] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for KMontalva-WMF - https://phabricator.wikimedia.org/T389930 (10KMontalva-WMF) 03NEW [10:08:28] 10Continuous-Integration-Infrastructure, 10Testing Support, 07ci-test-error, 10MinervaNeue (Tracking): Minerva test builds are failing after recent Selenium upgrades - https://phabricator.wikimedia.org/T389889#10673021 (10zeljkofilipin) [10:12:05] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for KMontalva-WMF - https://phabricator.wikimedia.org/T389930#10673032 (10Aklapper) @KMontalva-WMF: Hi, please request adding https://ldap.toolforge.org/user/kmontalva-wmf to the `ldap/wmf` group instead in IDM. See... [10:26:52] 10Gerrit, 07Upstream: Gerrit's syntax highlighting for PHP code breaks when encountering an apostrophe in a // comment in a function call - https://phabricator.wikimedia.org/T372404#10673082 (10hashar) p:05Triageβ†’03Low I have further amended the pull request in order to support PHP8 attributes and to add a... [10:59:03] 06Release-Engineering-Team: Investigate moving from Digital Ocean to WMF infrastructure - https://phabricator.wikimedia.org/T389936 (10Aklapper) 03NEW [10:59:12] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (Priority Backlog πŸ“₯), 06collaboration-services: Jobs on Digital Ocean Cloud Runners are being OOM killed - https://phabricator.wikimedia.org/T387886#10673498 (10Aklapper) >>! In T387886#10606843, @Dzahn wrote: > Sure that we want Digital Ocean to be the... [11:01:13] 06Release-Engineering-Team, 06collaboration-services: Investigate moving from Digital Ocean to WMF infrastructure - https://phabricator.wikimedia.org/T389936#10673506 (10Jelto) [11:18:52] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for KMontalva-WMF - https://phabricator.wikimedia.org/T389930#10673583 (10KMontalva-WMF) Thanks @Aklapper ! I just requested access. I will make sure we add to our onboarding checklist. [11:18:59] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for KMontalva-WMF - https://phabricator.wikimedia.org/T389930#10673584 (10KMontalva-WMF) 05Openβ†’03Resolved [12:02:42] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 10Testing Support, and 3 others: CI jobs failing with various timeouts (March 2025) - https://phabricator.wikimedia.org/T388416#10673708 (10zeljkofilipin) [12:55:24] 10Gerrit, 06Release-Engineering-Team, 06collaboration-services, 13Patch-For-Review, 07User-notice: Enable browser notifications system in Gerrit - https://phabricator.wikimedia.org/T389327#10673884 (10Jelto) >>! In T389327#10670189, @Dzahn wrote: > If Gerrit was to move behind the CDN in the future this... [13:16:05] 10Gerrit, 06Release-Engineering-Team, 06collaboration-services, 13Patch-For-Review, 07User-notice: Enable browser notifications system in Gerrit - https://phabricator.wikimedia.org/T389327#10673965 (10Paladox) Gerrit isn’t using web sockets for this I believe. It uses service workers https://github.com/G... [13:25:54] (03CR) 10Hashar: [C:03+2] "I did the +2 in another window and removed it when I posted my message πŸ˜„" [integration/quibble] - 10https://gerrit.wikimedia.org/r/1129916 (owner: 10Dduvall) [13:45:04] (03Merged) 10jenkins-bot: Avoid success cache key data collisions using null separator [integration/quibble] - 10https://gerrit.wikimedia.org/r/1129916 (owner: 10Dduvall) [13:45:13] (03PS1) 10Elukey: Review access change [maps/kartotherian/deploy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/1131009 [13:45:27] (03Abandoned) 10Elukey: Review access change [maps/kartotherian/deploy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/1131009 (owner: 10Elukey) [14:24:08] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Doing 😎), 06collaboration-services: Deploy Phabricator/Phorge 2025-03-25 - https://phabricator.wikimedia.org/T389953 (10brennen) 03NEW [14:28:12] 10GitLab (Infrastructure), 10Ceph, 06collaboration-services, 10Data-Persistence-Backup, and 2 others: Migrate gitlab storage to apus (also: backups from S3?) - https://phabricator.wikimedia.org/T378922#10674281 (10Jelto) >>! In T378922#10624358, @jcrespo wrote: > > Can we setup a meeting (E.g Jelto, Matth... [14:42:06] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team: Add some integration executors to spread the load - https://phabricator.wikimedia.org/T389554#10674373 (10hashar) I have checked Jenkins built in graph for the {nav Docker} label and I can barely see a raise in number of executors. The g... [15:13:22] 10Continuous-Integration-Infrastructure, 10Testing Support, 10ci-test-error (WMF-deployed Build Failure), 10MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), and 2 others: Selenium timeouts can cause the job to remain stuck until the build times out - https://phabricator.wikimedia.org/T389536#10674542 (10Daimona)... [15:14:09] Another day, another hour of CI time wasted. [15:14:45] bleh [15:41:41] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Doing 😎), 06collaboration-services, 13Patch-For-Review: Deploy Phabricator/Phorge 2025-03-25 - https://phabricator.wikimedia.org/T389953#10674717 (10Dzahn) please note the SRE collab office hours have been moved to 30 minutes later [15:42:41] Another one: https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php81/5611/console [15:43:36] dancy: Would you be willing to SSH into the agent and strace the hanging process please? [15:43:43] Sure [15:43:57] Thank you ^_^ [15:44:26] OK. I'm in. [15:45:18] So, there should be some active node process... Let me see what that might look like [15:45:32] Here's the process list inside of the container: https://phabricator.wikimedia.org/P74415 [15:46:24] What is 6721 doing? [15:49:12] Hmmmm let me test one thing locally [15:49:28] Looks like it's blocked waiting for activity on fd 10 or 14, both of which are eventpoll type. [15:50:17] The end of /tmp/lighthouse.HHgKUrw/chrome-err.log has: [15:50:17] [7067:7123:0325/152545.497018:ERROR:command_buffer_proxy_impl.cc(127)] ContextResult::kTransientFailure: Failed to send GpuControl.CreateCommandBuffer. [15:50:17] [0325/152613.263289:ERROR:file_io_posix.cc(145)] open /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq: No such file or directory (2) [15:50:17] [0325/152613.263393:ERROR:file_io_posix.cc(145)] open /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq: No such file or directory (2) [15:50:17] [0325/152613.266640:ERROR:crash_handler.cc(101)] Detected GWP-ASan crash for allocation at 0x39f800c94000 (malloc) of type heap-use-after-free [15:52:47] Those do seem to match the time of the test failure [15:53:18] Actually, exactly 60 seconds before we fail due to a 60s timeout [15:55:18] 10Phabricator, 10Release-Engineering-Team (Priority Backlog πŸ“₯): Update to Phorge upstream 2024.35 release - https://phabricator.wikimedia.org/T370266#10674747 (10brennen) Picking this thread back up after some discussion in last week's Collaboration Services office hours. > > Would there be interest in gettin... [15:55:51] I think I figured it out. Uncaught exceptions don't terminate the ffmpeg processes. [15:56:39] So that would answer why the process hangs if we get an uncaught exception. Obviously there's the question of why we're getting an uncaught exception in the first place, and whether it has to do with the use after free, but that is not the #1 question right now [15:58:11] Hmmmm or maybe not. I still had an uncaughtException listener in my test code. [16:01:57] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Doing 😎), 06collaboration-services, 13Patch-For-Review: Deploy Phabricator/Phorge 2025-03-25 - https://phabricator.wikimedia.org/T389953#10674767 (10brennen) > please note the SRE collab office hours have been moved to 30 minutes later Ack. Wil... [16:09:03] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 10Testing Support, and 3 others: CI jobs failing with various timeouts (March 2025) - https://phabricator.wikimedia.org/T388416#10674832 (10SDunlap) [16:16:03] 06Project-Admins, 07Tracking-Neverending: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706#10674881 (10NBaca-WMF) Hello - Can you add @HSwan-WMF , @DLin-WMF , @Maryana , @derenrich , and @etz as members of #acl_project-admins ? These are members of t... [16:19:24] 10Continuous-Integration-Infrastructure, 10Testing Support, 10ci-test-error (WMF-deployed Build Failure), 10MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), and 2 others: Selenium timeouts can cause the job to remain stuck until the build times out - https://phabricator.wikimedia.org/T389536#10674900 (10SDunlap) [16:32:46] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Doing 😎), 06collaboration-services, 13Patch-For-Review: Deploy Phabricator/Phorge 2025-03-25 - https://phabricator.wikimedia.org/T389953#10674983 (10ops-monitoring-bot) Icinga downtime and Alertmanager silence (ID=06f7cc21-adc2-4898-bcc5-2486f67... [16:33:17] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Doing 😎), 06collaboration-services, 13Patch-For-Review: Deploy Phabricator/Phorge 2025-03-25 - https://phabricator.wikimedia.org/T389953#10674986 (10ops-monitoring-bot) Icinga downtime and Alertmanager silence (ID=07e6d819-fc6d-4d1a-885e-8fb4e94... [16:51:33] 10Phabricator (2025-03-25), 10Release-Engineering-Team (Doing 😎), 10Wikimedia-Phabricator-Extensions, 07Technical-Debt: Remove "Burnup Graph" project menu item and custom ProjectBurnupGraphProfileMenuItem code - https://phabricator.wikimedia.org/T388664#10675072 (10Aklapper) 05Openβ†’03Resolved Custo... [16:52:31] 10Phabricator (2025-03-25), 10Release-Engineering-Team (Doing 😎): Unable to preview MP4 video in Phabricator task comments and descriptions - https://phabricator.wikimedia.org/T309222#10675077 (10Aklapper) 05Openβ†’03Resolved Should work now (phamous last words). I hope. Crossing fingers. [16:53:04] 10Phabricator (2025-03-25), 10Release-Engineering-Team (Doing 😎), 06collaboration-services, 13Patch-For-Review: Deploy Phabricator/Phorge 2025-03-25 - https://phabricator.wikimedia.org/T389953#10675080 (10Aklapper) 05Openβ†’03Resolved a:03brennen [17:12:15] 10Beta-Cluster-Infrastructure, 10CirrusSearch, 06Discovery-Search: Migrate deployment-prep elasticsearch cluster to opensearch - https://phabricator.wikimedia.org/T389971 (10dcausse) 03NEW [17:12:44] 10Gerrit, 07Upstream: Gerrit editor replaces tabs with spaces - https://phabricator.wikimedia.org/T355816#10675171 (10hashar) [17:12:45] 10Gerrit: Gerrit's "indent with tabs" option is seemingly ignored - https://phabricator.wikimedia.org/T389878#10675174 (10hashar) β†’14Duplicate dup:03T355816 [17:12:58] 10Gerrit, 07Upstream: Gerrit editor replaces tabs with spaces - https://phabricator.wikimedia.org/T355816#10675175 (10hashar) [17:13:19] 10Beta-Cluster-Infrastructure, 10CirrusSearch, 10Discovery-Search (2025.03.22 - 2025.04.11): Migrate deployment-prep elasticsearch cluster to opensearch - https://phabricator.wikimedia.org/T389971#10675177 (10dcausse) p:05Triageβ†’03High [17:19:25] 10Gerrit, 06Release-Engineering-Team, 06collaboration-services, 13Patch-For-Review, 07User-notice: Enable browser notifications system in Gerrit - https://phabricator.wikimedia.org/T389327#10675193 (10hashar) I can confirm the client browser is polling (every 5 minutes afaik). I did mention to upstream t... [17:28:46] 10Gerrit, 07Upstream: Gerrit editor replaces tabs with spaces - https://phabricator.wikimedia.org/T355816#10675228 (10Paladox) Fixed with https://gerrit-review.googlesource.com/c/plugins/codemirror-editor/+/462842 [17:29:01] hashar: James_F Daimona Fixed it ^ [17:29:34] Neat! [17:29:47] Yeeeeeeee thank you! \o/ [17:30:07] Hopefully it will be merged and released soon-ish, then we "just" have to update. [17:42:01] 06Release-Engineering-Team, 10MW-on-K8s, 06serviceops, 13Patch-For-Review: Refactor scap's kubernetes DeploymentsConfig to support selection of image kinds - https://phabricator.wikimedia.org/T389499#10675294 (10Scott_French) The patch series starting at https://gerrit.wikimedia.org/r/1131058 is mainly for... [18:24:11] (03PS17) 10Jeena Huneidi: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [18:31:18] 10Phabricator, 10Edit-Review-Improvements, 06Growth-Team, 07PM: Clean up #edit-review-improvements project - https://phabricator.wikimedia.org/T389982 (10Pppery) 03NEW [18:31:28] 06Project-Admins, 10Edit-Review-Improvements, 06Growth-Team, 07PM: Clean up #edit-review-improvements project - https://phabricator.wikimedia.org/T389982#10675598 (10Pppery) [18:31:55] (03PS18) 10Jeena Huneidi: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [18:32:59] 06Project-Admins, 10Edit-Review-Improvements, 06Growth-Team, 06Moderator-Tools-Team, 07PM: Clean up #edit-review-improvements project - https://phabricator.wikimedia.org/T389982#10675630 (10Pppery) (Tagging #moderator-tools-team for awareness as the current owner of this codebase since Herald tagged the... [18:35:54] (03PS19) 10Jeena Huneidi: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [18:45:55] (03PS20) 10Jeena Huneidi: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [18:48:59] 10Continuous-Integration-Infrastructure, 10Testing Support, 10ci-test-error (WMF-deployed Build Failure), 10MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), and 2 others: Selenium timeouts can cause the job to remain stuck until the build times out - https://phabricator.wikimedia.org/T389536#10675707 (10Daimona)... [18:58:03] (03PS1) 10Daimona Eaytoy: LocalSettings: explicitly configure CirrusSearch to do nothing [integration/quibble] - 10https://gerrit.wikimedia.org/r/1131078 (https://phabricator.wikimedia.org/T389895) [19:27:12] (03PS21) 10Jeena Huneidi: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) [19:28:52] 10Gerrit: *accounts Google One wallets - https://phabricator.wikimedia.org/T389993 (10iCHRISTI.gov) 03NEW [19:30:41] (03CR) 10Jeena Huneidi: "Fixed." [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [19:56:17] 10Beta-Cluster-Infrastructure, 10CirrusSearch, 10Discovery-Search (2025.03.22 - 2025.04.11): Migrate deployment-prep elasticsearch cluster to opensearch - https://phabricator.wikimedia.org/T389971#10675974 (10bking) [20:06:27] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10SonarQube Bot, 06Test-Platform, and 2 others: Improve speed of codehealth checks - https://phabricator.wikimedia.org/T351561#10676004 (10SDunlap) [20:15:43] (03CR) 10Thcipriani: [C:03+1] "I've seen this change run WikiLambda selenium tests via Catalyst. Shouldn't be disruptive in the experimental pipeline." [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [20:23:10] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team: Add some integration executors to spread the load - https://phabricator.wikimedia.org/T389554#10676046 (10bd808) >>! In T389554#10674373, @hashar wrote: > Am I confused and those new instances were created as replacement of old instances... [20:34:27] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10SonarQube Bot, 06Test-Platform, and 2 others: Improve speed of codehealth checks - https://phabricator.wikimedia.org/T351561#10676082 (10SDunlap) 05In progressβ†’03Stalled p:05Triageβ†’03Medium [20:38:02] 06Release-Engineering-Team, 06collaboration-services: Investigate moving from Digital Ocean to WMF infrastructure - https://phabricator.wikimedia.org/T389936#10676089 (10bd808) [20:44:41] 10GitLab (Infrastructure), 06Release-Engineering-Team, 06collaboration-services: Investigate moving from Digital Ocean to WMF infrastructure - https://phabricator.wikimedia.org/T389936#10676110 (10bd808) I believe the historical issue here has mostly been that the #release-engineering-team folks did not want... [20:49:19] 10Continuous-Integration-Config, 10Math, 10MediaWiki-Platform-Team (Radar): Allow control over which extra extensions are installed (Math REL1_43 jobs exceed 60min timeout) - https://phabricator.wikimedia.org/T389998 (10Krinkle) 03NEW [21:03:52] (03CR) 10Jeena Huneidi: [C:03+2] Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [21:04:34] (03PS4) 10Krinkle: zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) [21:05:03] (03Merged) 10jenkins-bot: Add wikilamba end-to-end selenium testing [integration/config] - 10https://gerrit.wikimedia.org/r/1130722 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [21:05:43] (03CR) 10CI reject: [V:04-1] zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) (owner: 10Krinkle) [21:05:47] (03CR) 10Krinkle: zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) (owner: 10Krinkle) [21:09:45] merged :D [21:09:54] and back ported to 3.10 + 3.11 [21:10:00] 3.10: https://gerrit-review.googlesource.com/c/plugins/codemirror-editor/+/462843 [21:10:29] 3.11: https://gerrit-review.googlesource.com/c/gerrit/+/463081 [21:11:38] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/1130722 [21:11:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:19:49] (03PS1) 10Jeena Huneidi: Update wikilambda e2e test parameters [integration/config] - 10https://gerrit.wikimedia.org/r/1131097 (https://phabricator.wikimedia.org/T383065) [21:20:52] 06Release-Engineering-Team, 10MW-on-K8s, 06serviceops, 13Patch-For-Review: Refactor scap's kubernetes DeploymentsConfig to support selection of image kinds - https://phabricator.wikimedia.org/T389499#10676284 (10bd808) > Here, an image "kind" represents the specific type of an image (e.g., the debug image)... [21:21:47] (03CR) 10Jeena Huneidi: "passes after updating job: https://integration.wikimedia.org/ci/view/All/job/wikilambda-catalyst-end-to-end/12/console" [integration/config] - 10https://gerrit.wikimedia.org/r/1131097 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [21:24:30] (03PS2) 10Jeena Huneidi: Update wikilambda e2e test parameters [integration/config] - 10https://gerrit.wikimedia.org/r/1131097 (https://phabricator.wikimedia.org/T383065) [21:28:06] 10Beta-Cluster-Infrastructure, 10CirrusSearch, 10Discovery-Search (2025.03.22 - 2025.04.11), 13Patch-For-Review: Migrate deployment-prep elasticsearch cluster to opensearch - https://phabricator.wikimedia.org/T389971#10676315 (10bking) Per IRC conversation, I've been requested to publicize these changes as... [21:32:59] (03PS5) 10Krinkle: zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) [21:35:26] 10Beta-Cluster-Infrastructure, 10CirrusSearch, 10Discovery-Search (2025.03.22 - 2025.04.11), 13Patch-For-Review: Migrate deployment-prep elasticsearch cluster to opensearch - https://phabricator.wikimedia.org/T389971#10676350 (10bking) We also need to update the mediawiki config labservices file to point t... [21:37:12] James_F: aprt from Bluespice only 1 extension relied on recursion. [21:37:41] It's hard to believe? I'll need to double check my logic (check the paste) and add some verbosity in case I missed something [21:38:31] ok yes, I must have missed some. At the very least WikibaseCirrusSearch needs Elastica. [21:41:56] hm.. yes and no. I'm correctly including all hard deps of the listed repo, and WikibaseCirrusSearch in fact has no direct or indirect deps. Nothing in extension.json [21:42:10] but given a declared extra dep CirrusSearch we then should include that one [21:42:11] * Krinkle fixes [21:42:18] and from there discover Elastica [21:42:20] fair enough [21:59:10] (03CR) 10Thcipriani: [C:03+1] Update wikilambda e2e test parameters [integration/config] - 10https://gerrit.wikimedia.org/r/1131097 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [22:00:29] (03CR) 10Thcipriani: [C:03+2] "Job updated and deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/1131097 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [22:01:46] (03Merged) 10jenkins-bot: Update wikilambda e2e test parameters [integration/config] - 10https://gerrit.wikimedia.org/r/1131097 (https://phabricator.wikimedia.org/T383065) (owner: 10Jeena Huneidi) [22:01:50] 10Gerrit, 07Upstream: Gerrit editor replaces tabs with spaces - https://phabricator.wikimedia.org/T355816#10676430 (10hashar) @Paladox you are really a jewel to the wikis movements. Thank you! The fix is backported to 3.11 by https://gerrit-review.googlesource.com/c/gerrit/+/463081 [22:05:18] (03PS6) 10Krinkle: zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) [22:05:25] done :) [22:07:06] (03PS7) 10Krinkle: zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) [22:11:23] Krinkle: for a dict, instead of `dict.get('key') or "fallback"` you can pass the fallback value as the second parameter of the get: [22:11:23] `dict.get('key', "fallback")`. So that if key does not exist, "fallback" is returned. [22:11:42] dict.get('key') would return None if key does not exist [22:12:32] anyway that is nice progress on that patch and the list of dependencies looks less intimidiating [22:14:21] * hashar sleeps [22:14:43] hashar: thx, I initially tried [] or but that throws KeyError of course, given Python :) [22:15:19] I had not considered there might be a built-in fallback. We just recently started removing that pattern in both RL JS and in MW PHP, but I suppoe this is typical in python so best to follow [22:16:02] e.g. mw.config.get(key, default) is discouraged since default is therefor fully computed but likely unused, and same in PHP WebRequest->getVal(key, $def) vs getVal(key) ?? $def. [22:16:07] for type analysis as well [22:16:43] (03PS8) 10Krinkle: zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) [22:17:14] (03CR) 10Krinkle: "Switched from `.get() or def` to `.get(, def)` as idiomatic python, per hashar tip in #wikimedia-releng." [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) (owner: 10Krinkle) [22:17:45] (03CR) 10CI reject: [V:04-1] zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) (owner: 10Krinkle) [22:19:05] (03PS9) 10Krinkle: zuul: Remove uncontrolled recursion of extra-dependencies in MW jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1130957 (https://phabricator.wikimedia.org/T389998) [22:19:49] `dict.get(key, default)` is very pythonic [22:24:03] ref T376245 [22:24:03] T376245: Deprecate parameter $default in MediaWiki\Request\WebRequest::getRawVal - https://phabricator.wikimedia.org/T376245 [22:24:32] feel free to review more of my Python code, always happy to learn more. I don't get to practice very often :) [22:25:30] 10Continuous-Integration-Infrastructure, 10Testing Support, 10ci-test-error (WMF-deployed Build Failure), 10MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), and 2 others: Selenium timeouts can cause the job to remain stuck until the build times out - https://phabricator.wikimedia.org/T389536#10676487 (10Daimona)... [22:25:31] although with https://phabricator.wikimedia.org/P74370 beware I applied https://xkcd.com/1205/ so I deliberately did not try to look for a good way given it's one-off, but it certainly shows what I intuitively know and don't, so happy to hear about that as well, although I probalby won't edit it further [22:26:20] good enough is good enough :) [22:30:05] 10Continuous-Integration-Config, 10Math, 10MediaWiki-Platform-Team (Radar), 13Patch-For-Review: Allow control over which extra extensions are installed (Math REL1_43 jobs exceed 60min timeout) - https://phabricator.wikimedia.org/T389998#10676492 (10Krinkle) [22:33:00] 10Continuous-Integration-Config, 10Math, 10MediaWiki-Platform-Team (Radar), 13Patch-For-Review: Allow control over which extra extensions are installed (Math REL1_43 jobs exceed 60min timeout) - https://phabricator.wikimedia.org/T389998#10676498 (10Krinkle) [23:34:25] 10Continuous-Integration-Infrastructure, 10Testing Support, 10ci-test-error (WMF-deployed Build Failure), 10MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), and 2 others: Selenium timeouts can cause the job to remain stuck until the build times out - https://phabricator.wikimedia.org/T389536#10676577 (10bd808) >... [23:43:42] 06Release-Engineering-Team, 10MW-on-K8s, 06serviceops, 13Patch-For-Review: Refactor scap's kubernetes DeploymentsConfig to support selection of image kinds - https://phabricator.wikimedia.org/T389499#10676584 (10Scott_French) >>! In T389499#10676284, @bd808 wrote: > I am having a bit of trouble understandi...