[00:17:12] (03approved) 10swfrench: kubernetes: Add deployment scopes and check supervision rules [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/1218 (https://phabricator.wikimedia.org/T428971) (owner: 10dancy) [03:41:16] 10Phabricator Translations Extension, 06translatewiki.net: Add NotEmpty validator to Phabricator - https://phabricator.wikimedia.org/T431779 (10Pppery) 03NEW [08:18:34] (03PS1) 10Hslater: Zuul: [mediawiki/extensions/BlueSpiceInterwikiSearch] Add BlueSpiceExtendedSearch [integration/config] - 10https://gerrit.wikimedia.org/r/1309594 [08:20:15] (03CR) 10CI reject: [V:04-1] Zuul: [mediawiki/extensions/BlueSpiceInterwikiSearch] Add BlueSpiceExtendedSearch [integration/config] - 10https://gerrit.wikimedia.org/r/1309594 (owner: 10Hslater) [08:31:25] (03CR) 10Hashar: [C:03+2] Zuul: [mediawiki/extensions/BlueSpiceNSFileRepoConnector] Add VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/1308645 (owner: 10Hslater) [08:33:39] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/BlueSpiceNSFileRepoConnector] Add VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/1308645 (owner: 10Hslater) [08:34:15] (03CR) 10Hashar: [C:03+2] "deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/1308645 (owner: 10Hslater) [08:40:58] (03PS2) 10Hashar: Zuul: [BlueSpiceInterwikiSearch] Add BlueSpiceExtendedSearch [integration/config] - 10https://gerrit.wikimedia.org/r/1309594 (owner: 10Hslater) [09:01:35] (03PS1) 10Jforrester: Docker: [commit-message-validator] Update to 2.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/1309607 [09:02:35] (03CR) 10Hashar: [C:03+2] Zuul: [BlueSpiceInterwikiSearch] Add BlueSpiceExtendedSearch [integration/config] - 10https://gerrit.wikimedia.org/r/1309594 (owner: 10Hslater) [09:05:19] (03PS1) 10Jforrester: jjb: Switch commit-message-validator users to 2.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/1309609 [09:05:47] (03CR) 10CI reject: [V:04-1] Zuul: [BlueSpiceInterwikiSearch] Add BlueSpiceExtendedSearch [integration/config] - 10https://gerrit.wikimedia.org/r/1309594 (owner: 10Hslater) [09:07:31] (03CR) 10Hashar: [C:03+2] Zuul: [BlueSpiceInterwikiSearch] Add BlueSpiceExtendedSearch [integration/config] - 10https://gerrit.wikimedia.org/r/1309594 (owner: 10Hslater) [09:09:25] (03Merged) 10jenkins-bot: Zuul: [BlueSpiceInterwikiSearch] Add BlueSpiceExtendedSearch [integration/config] - 10https://gerrit.wikimedia.org/r/1309594 (owner: 10Hslater) [09:09:46] 10Continuous-Integration-Infrastructure, 10commit-message-validator: Migrate to a newer Python than 3.9 so CI doesn't have a bullseye-based image still. - https://phabricator.wikimedia.org/T431799 (10Jdforrester-WMF) 03NEW [09:11:20] (03PS1) 10Jforrester: tox: Pin our version of commit-message-validator explicitly [integration/config] - 10https://gerrit.wikimedia.org/r/1309611 [09:12:05] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Migrate all CI jobs from Bullseye to Bookworm or later and drop Bullseye testing support - https://phabricator.wikimedia.org/T383337#12108201 (10Jdforrester-WMF) [09:12:10] 10Continuous-Integration-Infrastructure, 10commit-message-validator: Migrate to a newer Python than 3.9 so CI doesn't have a bullseye-based image still. - https://phabricator.wikimedia.org/T431799#12108205 (10Jdforrester-WMF) [09:12:15] (03CR) 10Jforrester: [C:03+2] Docker: [commit-message-validator] Update to 2.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/1309607 (owner: 10Jforrester) [09:12:15] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Migrate all CI jobs from Bullseye to Bookworm or later and drop Bullseye testing support - https://phabricator.wikimedia.org/T383337#12108204 (10Jdforrester-WMF) [09:14:14] (03CR) 10Hashar: [C:03+2] "deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/1309594 (owner: 10Hslater) [09:14:33] (03Merged) 10jenkins-bot: Docker: [commit-message-validator] Update to 2.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/1309607 (owner: 10Jforrester) [09:16:18] !log Docker: [commit-message-validator] Update to 2.3.0 [09:16:19] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:18:40] (03PS2) 10Jforrester: jjb: [commit-message-validator] Switch users to 2.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/1309609 [09:18:44] (03CR) 10Jforrester: [C:03+2] jjb: [commit-message-validator] Switch users to 2.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/1309609 (owner: 10Jforrester) [09:18:48] (03CR) 10Jforrester: [C:03+2] tox: Pin our version of commit-message-validator explicitly [integration/config] - 10https://gerrit.wikimedia.org/r/1309611 (owner: 10Jforrester) [09:20:23] (03Merged) 10jenkins-bot: jjb: [commit-message-validator] Switch users to 2.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/1309609 (owner: 10Jforrester) [09:20:59] (03PS2) 10Jforrester: tox: Pin our version of commit-message-validator explicitly [integration/config] - 10https://gerrit.wikimedia.org/r/1309611 [09:21:04] (03CR) 10Jforrester: [V:03+2 C:03+2] tox: Pin our version of commit-message-validator explicitly [integration/config] - 10https://gerrit.wikimedia.org/r/1309611 (owner: 10Jforrester) [09:21:10] (03CR) 10Jforrester: [V:03+2] "…" [integration/config] - 10https://gerrit.wikimedia.org/r/1309611 (owner: 10Jforrester) [09:24:32] (03Merged) 10jenkins-bot: tox: Pin our version of commit-message-validator explicitly [integration/config] - 10https://gerrit.wikimedia.org/r/1309611 (owner: 10Jforrester) [09:49:28] (03PS5) 10Jforrester: tox: introduce yamllint [integration/config] - 10https://gerrit.wikimedia.org/r/1303970 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [09:52:03] (03CR) 10Jforrester: [C:03+2] tox: introduce yamllint [integration/config] - 10https://gerrit.wikimedia.org/r/1303970 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [09:52:44] hashar: Are you OK with my tweaks to https://gerrit.wikimedia.org/r/c/integration/config/+/1303971/ to make it pass? If so I'd like to land it and avoid further regressions. :-) [09:54:05] (03Merged) 10jenkins-bot: tox: introduce yamllint [integration/config] - 10https://gerrit.wikimedia.org/r/1303970 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [09:54:24] (03PS1) 10Jforrester: tox: Explicitly print the Python version being used, like in Quibble [integration/config] - 10https://gerrit.wikimedia.org/r/1309629 [09:57:58] (03CR) 10Jforrester: [C:03+2] tox: Explicitly print the Python version being used, like in Quibble [integration/config] - 10https://gerrit.wikimedia.org/r/1309629 (owner: 10Jforrester) [10:00:30] (03Merged) 10jenkins-bot: tox: Explicitly print the Python version being used, like in Quibble [integration/config] - 10https://gerrit.wikimedia.org/r/1309629 (owner: 10Jforrester) [10:07:52] (03PS2) 10Jforrester: tox: Upgrade editorconfig-checker 2.4.0..3.6.1 [integration/config] - 10https://gerrit.wikimedia.org/r/1304116 (owner: 10Hashar) [10:07:52] (03CR) 10Jforrester: tox: Upgrade editorconfig-checker 2.4.0..3.6.1 (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/1304116 (owner: 10Hashar) [10:08:22] (03CR) 10Jforrester: [C:03+2] tox: Upgrade editorconfig-checker 2.4.0..3.6.1 [integration/config] - 10https://gerrit.wikimedia.org/r/1304116 (owner: 10Hashar) [10:10:08] (03Merged) 10jenkins-bot: tox: Upgrade editorconfig-checker 2.4.0..3.6.1 [integration/config] - 10https://gerrit.wikimedia.org/r/1304116 (owner: 10Hashar) [10:30:23] (03PS6) 10Kosta Harlan: Provide a secondary database for multi-DB tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/1309235 (https://phabricator.wikimedia.org/T342763) [10:30:23] (03PS5) 10Kosta Harlan: DNM: verify Special:UserRights interwiki test via a 2nd DB [integration/quibble] - 10https://gerrit.wikimedia.org/r/1309252 (https://phabricator.wikimedia.org/T342763) [10:31:14] (03CR) 10CI reject: [V:04-1] DNM: verify Special:UserRights interwiki test via a 2nd DB [integration/quibble] - 10https://gerrit.wikimedia.org/r/1309252 (https://phabricator.wikimedia.org/T342763) (owner: 10Kosta Harlan) [10:32:28] (03CR) 10Kosta Harlan: "recheck" [integration/quibble] - 10https://gerrit.wikimedia.org/r/1309252 (https://phabricator.wikimedia.org/T342763) (owner: 10Kosta Harlan) [10:33:51] (03PS1) 10VadymTS1: Add Chuiimuii_ofc to CI allow list [integration/config] - 10https://gerrit.wikimedia.org/r/1309637 [10:36:41] (03PS6) 10Kosta Harlan: DNM: verify Special:UserRights interwiki test via a 2nd DB [integration/quibble] - 10https://gerrit.wikimedia.org/r/1309252 (https://phabricator.wikimedia.org/T342763) [10:48:12] James_F: thank you for the yamllint/commit-message-validator/editorconfig-checker fixes on integration/config ! [10:48:30] I completely forgot I had sent some of those patches :b [10:48:44] :-) [10:49:25] hashar: Note that I don't think there's any way to make yamllint happy with our indenting. [10:49:29] what I am missing is a framework that would let us mass rollout those utilities accross python repos [10:49:30] So I disabled it for now. [10:49:44] It's called "keen junior devs"? :-) [10:49:56] possibly yes [10:50:31] back in the days we established https://www.mediawiki.org/wiki/Continuous_integration/Entry_points [10:50:34] with list of recommendations [10:50:51] Yeah, but we never enforced it automatically, just via code review. [10:50:54] but it is quite outdated and I am not sure it is well known/enforced/recommended [10:50:56] yeah [10:51:13] which brings me to a long overdue project to have a job that gauge how a repo matches a set of recommendation [10:51:21] kind of a meta linter [10:51:46] aka is your repo using the recommended best practices [10:51:47] We talked about needing that in the GitLab world (where repos could be changed locally). [10:52:02] But when that migration was junked I stopped thinking about it so much. [10:52:16] from what I have heard of Gitlab, it sounds like a free-for-all party :b [10:52:48] anyway food for later [10:53:03] hashar: +1 on my yamllint fixes and I'll deploy. [10:53:04] for yamlllint you said you disabled it, I imagine by amending https://gerrit.wikimedia.org/r/c/integration/config/+/1303970 ? [10:53:19] No, amending 1303971. [10:54:10] ah yeah I did it in multiple passes: A) introduce yamllint as a noop B) fix bunch of things C) enforce it [10:54:45] Yup. [10:55:32] OHH NO [10:55:53] you amended to upgrade the set of rules (relaxed > default) AND fix up stuff [10:56:09] err "just" fixed stuff [10:57:11] (03PS4) 10Hashar: tox: yamllint: use default ruleset, with some over-rides to pass [integration/config] - 10https://gerrit.wikimedia.org/r/1303971 (https://phabricator.wikimedia.org/T429576) [10:57:11] (03CR) 10Hashar: [C:03+1] "Thank you so much for having added fix and overrides :-] Ready to get merged imho" [integration/config] - 10https://gerrit.wikimedia.org/r/1303971 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [10:57:31] James_F: +1 thx so much, I am letting you apply the CR+2 seal of approval [10:57:35] <3 [10:57:46] (03CR) 10Jforrester: [C:03+2] tox: yamllint: use default ruleset, with some over-rides to pass [integration/config] - 10https://gerrit.wikimedia.org/r/1303971 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [10:59:23] the last one is to have warning to fail the build, https://gerrit.wikimedia.org/r/c/integration/config/+/1303972/ [10:59:27] but well it is a bit noisy [10:59:34] so maybe I should abandon that and revisit later [10:59:45] (03Merged) 10jenkins-bot: tox: yamllint: use default ruleset, with some over-rides to pass [integration/config] - 10https://gerrit.wikimedia.org/r/1303971 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [10:59:50] or fix them progressively one rule at a time [11:21:07] (03PS1) 10Jforrester: yaml: Use lowercase booleans to satisfy yamllint truthy rule [integration/config] - 10https://gerrit.wikimedia.org/r/1309647 (https://phabricator.wikimedia.org/T429576) [11:21:09] (03PS1) 10Jforrester: yaml: Add a space after "#" in comments for yamllint [integration/config] - 10https://gerrit.wikimedia.org/r/1309648 (https://phabricator.wikimedia.org/T429576) [11:21:12] (03PS1) 10Jforrester: yaml: Add document-start marker to satisfy yamllint [integration/config] - 10https://gerrit.wikimedia.org/r/1309649 (https://phabricator.wikimedia.org/T429576) [11:23:12] (03CR) 10Jforrester: [C:03+2] yaml: Use lowercase booleans to satisfy yamllint truthy rule [integration/config] - 10https://gerrit.wikimedia.org/r/1309647 (https://phabricator.wikimedia.org/T429576) (owner: 10Jforrester) [11:23:23] (03CR) 10Jforrester: [C:03+2] yaml: Add a space after "#" in comments for yamllint [integration/config] - 10https://gerrit.wikimedia.org/r/1309648 (https://phabricator.wikimedia.org/T429576) (owner: 10Jforrester) [11:25:04] (03Merged) 10jenkins-bot: yaml: Use lowercase booleans to satisfy yamllint truthy rule [integration/config] - 10https://gerrit.wikimedia.org/r/1309647 (https://phabricator.wikimedia.org/T429576) (owner: 10Jforrester) [11:25:33] (03Merged) 10jenkins-bot: yaml: Add a space after "#" in comments for yamllint [integration/config] - 10https://gerrit.wikimedia.org/r/1309648 (https://phabricator.wikimedia.org/T429576) (owner: 10Jforrester) [11:27:15] (03CR) 10Jforrester: [C:03+2] yaml: Add document-start marker to satisfy yamllint [integration/config] - 10https://gerrit.wikimedia.org/r/1309649 (https://phabricator.wikimedia.org/T429576) (owner: 10Jforrester) [11:27:20] (03PS5) 10Jforrester: tox: yamllint: report and fail on warnings [integration/config] - 10https://gerrit.wikimedia.org/r/1303972 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [11:27:30] (03PS6) 10Jforrester: tox: yamllint: Report and fail on warnings [integration/config] - 10https://gerrit.wikimedia.org/r/1303972 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [11:27:34] (03CR) 10Jforrester: [C:03+2] tox: yamllint: Report and fail on warnings [integration/config] - 10https://gerrit.wikimedia.org/r/1303972 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [11:28:54] (03Merged) 10jenkins-bot: yaml: Add document-start marker to satisfy yamllint [integration/config] - 10https://gerrit.wikimedia.org/r/1309649 (https://phabricator.wikimedia.org/T429576) (owner: 10Jforrester) [11:29:31] (03Merged) 10jenkins-bot: tox: yamllint: Report and fail on warnings [integration/config] - 10https://gerrit.wikimedia.org/r/1303972 (https://phabricator.wikimedia.org/T429576) (owner: 10Hashar) [11:32:41] 10Continuous-Integration-Config, 06Release-Engineering-Team (Doing 😎): Introduce yamlllint to the integration/config repository - https://phabricator.wikimedia.org/T429576#12108684 (10Jdforrester-WMF) 05In progress→03Resolved a:03hashar [11:44:02] (03PS1) 10Matthias Mullie: Add skins/MinervaNeue phan dependency for ReaderExperiments [integration/config] - 10https://gerrit.wikimedia.org/r/1309657 (https://phabricator.wikimedia.org/T428680) [11:50:29] James_F: ihurbain mentioned browser tests are failing MW release branches (ex: dummy patch to parsoid https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1309652 ) [11:50:47] hashar: Yes, they always break and no-one ever fixes them. [11:50:53] hashar: I proposed disabling them. [11:50:55] which somehow bubbled up in my brain a patch you did and i must have forgotten https://gerrit.wikimedia.org/r/c/integration/config/+/1307374 [11:50:57] yeah [11:51:10] Let's do it? [11:52:38] Note that it probably won't fully fix the issue, due to WMDE's browser tests for Wikidata-related things (which touches almost every repo ihurbain would care about). [11:52:49] I guess nobody will quite bother if those tests are not running any more [11:52:56] and frankly I am not sure what they cover on release branches [11:52:56] They don't bother now. [11:52:58] So… [11:53:06] {{DEAL}} [11:53:21] (03CR) 10Jforrester: [C:03+2] Zuul: Disable all browser tests on release branches except Wikibase's [integration/config] - 10https://gerrit.wikimedia.org/r/1307374 (https://phabricator.wikimedia.org/T430415) (owner: 10Jforrester) [11:54:08] (03CR) 10Hashar: [C:03+2] "Thank you James, I agree they are quite an annoyance and as far as I understand it they don't cover much for backports to release branches" [integration/config] - 10https://gerrit.wikimedia.org/r/1307374 (https://phabricator.wikimedia.org/T430415) (owner: 10Jforrester) [11:54:45] wunderbar. thank you :D [11:54:50] I think I postponed reviewing it until some other people get involved saying "yes that is a good idea" [11:54:59] I AM NOT BOLD ENOUGH [11:55:06] ihurbain: If you're still blocked, we'll have to take an axe to the WMDE ones too. [11:55:12] * ihurbain throws a few asterisks at hashar [11:55:27] (03Merged) 10jenkins-bot: Zuul: Disable all browser tests on release branches except Wikibase's [integration/config] - 10https://gerrit.wikimedia.org/r/1307374 (https://phabricator.wikimedia.org/T430415) (owner: 10Jforrester) [11:55:50] you can also fork Parsoid to Github, release it and published it on packagist.org under isabelle/parsoid fork then get composer.json to point to it [11:56:00] * hashar sneakily escapes the room to take the door [11:56:08] !log Zuul: Disable all browser tests on release branches except Wikibase's, for T430415 [11:56:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:56:11] T430415: More flaky browser tests in MW 1.43 - https://phabricator.wikimedia.org/T430415 [11:56:12] {{done}} [11:56:12] OR I can not do that. [11:56:15] 🥳 [11:56:19] yay! [11:56:20] OR [11:56:22] even better [11:56:34] disable parsoid entirely on release branches and solely rely on legacy parser! [11:56:57] visualeditor would like a word [11:57:09] Let's re-write the legacy Parser in Rust cross-compiled into a PHP extension. [11:57:18] That'd make everyone sad in one go. [11:57:28] it's friday. [11:57:30] RELEASE-NOTES-1.43.txt:37: dropped support for VisualEditor, use source editor instead [11:57:48] I am confused [11:57:52] go or rust? [11:57:58] "sad in one **go**" [11:58:06] i'll allow it [11:58:23] Yes, you're right, we should write it half in Rust and half in Go to make it harder. [11:58:33] * hashar starts MW 2.0 vibe coded RiiR project [11:58:57] Rust in instances (of) Rails? [11:59:30] more seriously, it is not necessarily a problem to have two bricks written in different language, you can just stick an Enterprise Bus System using SOAP in between (nice proven stable tech) [12:00:11] James_F: would you mark resolve https://phabricator.wikimedia.org/T430415 with a summary or shall I? [12:00:38] hashar: I was going to wait a little to see if it's actually fixed now. [12:06:52] * hashar nods [13:20:01] parsoid build does pass [14:36:04] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10BlueSpice: BlueSpice force merging to branches and messing up mediawiki/extensions.git - https://phabricator.wikimedia.org/T431845 (10Reedy) 03NEW [14:36:10] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10BlueSpice: BlueSpice force merging to branches and messing up mediawiki/extensions.git - https://phabricator.wikimedia.org/T431845#12109553 (10Reedy) p:05Triage→03Unbreak! [14:36:12] I've had enough of thos [14:36:13] this [14:42:37] * taavi is still tempted to remove the force merge permission by default [14:44:18] heh [15:10:07] 10Phabricator Translations Extension: scripts/ and support/ paths have broken link to code - https://phabricator.wikimedia.org/T429078#12109751 (10Pppery) 05Open→03Resolved [15:10:29] 10Phabricator Translations Extension: Deal with "AM"/"PM" messages - https://phabricator.wikimedia.org/T428957#12109752 (10Pppery) 05Open→03Resolved [15:15:59] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10BlueSpice: BlueSpice force merging to branches and messing up mediawiki/extensions.git - https://phabricator.wikimedia.org/T431845#12109762 (10brennen) [15:19:26] 10Continuous-Integration-Config, 10CirrusSearch, 10Wikidata, 10Wikidata Lexicographical data, and 4 others: LexemeFullTextQueryBuilderTest::testSearchElastic CI test errors - https://phabricator.wikimedia.org/T428975#12109782 (10karapayneWMDE) [15:34:55] (03update) 10dancy: kubernetes: Add deployment scopes and check supervision rules [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/1218 (https://phabricator.wikimedia.org/T428971) [15:35:27] (03update) 10dancy: kubernetes: Add deployment scopes and check supervision rules [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/1218 (https://phabricator.wikimedia.org/T428971) [16:39:14] 10Continuous-Integration-Infrastructure, 10commit-message-validator: Migrate to a newer Python than 3.9 so CI doesn't have a bullseye-based image still. - https://phabricator.wikimedia.org/T431799#12109983 (10bd808) The current code will work with python3.12 and earlier, so we should be able to switch to a boo... [20:08:54] 06Release-Engineering-Team (Doing 😎): [FY26-27 ST5.1.2] Automated supervision - https://phabricator.wikimedia.org/T427968#12110691 (10bd808)