[17:07:19] jhathaway: already done! [17:07:29] thanks! [17:08:21] jhathaway: ah wait, the only missing bit is my update for log_entries :D [17:08:31] do you want me to send a separate code review tomorrow? [17:10:15] after the hw_model patch is merged, I think the log_entries patch can be reworked in a similar way, should just take a moment, I can push a new version now if you like? [17:10:26] or rather make a suggestion on the path [17:10:28] *patch [17:11:56] as you prefer, I can update it tomorrow or abandon and check yours, it is really easy now with the new property :) [17:12:19] I have a bit of a busy schedule late in my afternoon tomorrow, otherwise I'd have asked you if you wanted to cut the spicerack release [17:12:31] to see how it is done etc.. [17:12:45] let's chat about it tomorrow if you are interested! [17:14:40] elukey: replied with suggestion, I think that logic is correct [17:15:01] sounds good [17:58:40] FIRING: SystemdUnitFailed: dnsmasq.service on ganeti7001:9100 - https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state - https://grafana.wikimedia.org/d/g-AaZRFWk/systemd-status - https://alerts.wikimedia.org/?q=alertname%3DSystemdUnitFailed [18:53:22] 10SRE-tools, 10Spicerack: Spicerack's `Discovery.resolve_with_client_ip` should set a timeout on `udp_with_fallback` - https://phabricator.wikimedia.org/T405397 (10Scott_French) 03NEW [19:03:37] 10SRE-tools, 06Infrastructure-Foundations, 10Spicerack: Spicerack's `Discovery.resolve_with_client_ip` should set a timeout on `udp_with_fallback` - https://phabricator.wikimedia.org/T405397#11207520 (10Scott_French) For completeness, another option might be to do pretty much exactly what https://gerrit.wiki... [21:37:25] 10SRE-tools, 06Infrastructure-Foundations, 10Spicerack, 13Patch-For-Review: Spicerack's `Discovery.resolve_with_client_ip` should set a timeout on `udp_with_fallback` - https://phabricator.wikimedia.org/T405397#11208037 (10Scott_French) While we should not need this for Day 2 of the switchover tomorrow (se... [21:38:05] 10SRE-tools, 06Infrastructure-Foundations, 06serviceops, 10Spicerack, 13Patch-For-Review: Spicerack's `Discovery.resolve_with_client_ip` should set a timeout on `udp_with_fallback` - https://phabricator.wikimedia.org/T405397#11208038 (10Scott_French) p:05Triage→03Medium [21:58:40] FIRING: SystemdUnitFailed: dnsmasq.service on ganeti7001:9100 - https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state - https://grafana.wikimedia.org/d/g-AaZRFWk/systemd-status - https://alerts.wikimedia.org/?q=alertname%3DSystemdUnitFailed