[09:35:14] <Emperor>	 why is CI falling over with "Hosts: auto" and failing to find any hosts? https://integration.wikimedia.org/ci/job/operations-puppet-catalog-compiler-puppet7-test/5077/console
[09:36:50] <Emperor>	 I'd previously tried "Hosts: P:swift::storage::configure_disks" which failed likewise, but I'd assumed that was just me Doing It Rong
[09:38:14] <volans>	 the change is on a ruby file for a custom facter, so not directly included in any catalog, that's probably why auto is failing
[09:38:53] <volans>	 for the explicit syntax puppet complier supports only a subset of cumin-like syntax
[09:39:13] <volans>	 see https://wikitech.wikimedia.org/wiki/Help:Puppet-compiler#Host_variable_override
[09:41:24] <Emperor>	 Yeah, I never seem to get that right, but I thought given I wanted hosts with 'profile::swift::storage::configure_disks' I could use P:swift... 
[09:41:56] <volans>	 it seems it should be supported
[09:42:31] <volans>	 but also it will probably run it for all 54 matching hosts
[09:43:09] <Emperor>	 volans: https://integration.wikimedia.org/ci/job/operations-puppet-catalog-compiler-puppet7-test/5076/console is it failing to work
[09:44:23] <Emperor>	 all> yeah, I wouldn't normally, but I there are so many different hardware/controller combinations in the swift/thanos backends I really want to be sure...
[09:48:28] <volans>	 Emperor: one colon after P
[09:48:32] <volans>	 you had 2
[09:48:36] <volans>	 https://gerrit.wikimedia.org/r/c/operations/puppet/+/1193797/1..2//COMMIT_MSG#b37
[09:53:11] <Emperor>	 🤦
[09:54:49] <Emperor>	 sigh, thanks for spotting that
[09:56:20] <volans>	 no prob
[10:00:03] <Emperor>	 Hm, in practice it only ran it on 2 nodes, not all 54
[10:00:13] <Emperor>	 https://puppet-compiler.wmflabs.org/output/1193797/5078/
[10:01:52] <volans>	 according to the docs it seems that if you want all of that you need cumin:P:swift::storage::configure_disks
[10:20:40] <Emperor>	 volans: the docs note "however please keep in mind that the puppetdb on the pcc workers only has a subset of hosts." what subset?
[10:23:03] <volans>	 that you have to ask to its maintainers, I don't know, sorry :)
[10:24:18] <Emperor>	 heh
[10:32:17] <_joe_>	 we can't regenerate a full db of all hosts we have, so we pick 1 per definition in site.pp IIRC
[10:33:48] <volans>	 Emperor: btw re-looking at your patch, you can't test it via PCC, the facts are executed on the actual hosts, pcc uses the existing facts already stored in puppetdb
[10:53:56] <volans>	 Emperor: you would need something like this: https://phabricator.wikimedia.org/P83603
[10:55:34] <Emperor>	 volans: heh, thanks, I was working some something similar :)
[11:48:52] * Emperor reminded of the utility of diff <( ) <( )
[11:56:34] * Lucas_WMDE loves diff [-u] <() <() as well
[15:33:16] <andrewbogott>	 does Observability have a manager  right now? Or an interim?
[15:33:39] <cdanis>	 andrewbogott: it's h.nowlan
[15:33:45] <andrewbogott>	 thanks!