[13:42:26] <jelto>	 GitLab needs a short maintenance break at 14:30 UTC
[16:53:31] <jynus>	 could I get a review for https://gerrit.wikimedia.org/r/c/operations/puppet/+/1217562 I think there is noone from my team around to help me
[16:54:01] <jynus>	 it should be quite noop unless I had a syntax error
[16:54:06] <inflatador>	 jynus 👀
[16:55:05] <jynus>	 for context, backup1015 does not exist (yet), latest host is backup1014
[17:00:56] <inflatador>	 jynus you're not using UEFI on any of the new hosts? You might need a different recipe if so
[17:02:17] <jynus>	 oh
[17:02:35] <jynus>	 uff, this is complicated, because I would set it up, but I am going on vacations tomorrow
[17:02:50] <jynus>	 so I was just trying to prepare things for colleagues to have it ready
[17:03:09] <inflatador>	 No worries, I'll give a +1 and add a comment if you like
[17:03:09] <jynus>	 is is hard to setup and test without the host? is it posible to setup afterwards?
[17:03:24] <jynus>	 I don't mind to reimage it later
[17:03:38] <jynus>	 but I would want to have it ready for my colleagues
[17:03:51] <inflatador>	 nah, it's not hard. You basically just add one more partition for UEFI, there are plenty of examples in the repo
[17:04:19] <jynus>	 ok, but without the actual hardware, that will be hard to test
[17:04:30] <jynus>	 I prefer to have this now and modify and test the new recipe later
[17:04:44] <jynus>	 as technically it is a separate scope
[17:04:51] <inflatador>	 yeah, probably should make a note of that in the ticket. I had an untested recipe in T405964 and just told DC Ops to escalate to me if it didn't work
[17:04:52] <stashbot>	 T405964: Q2:rack/setup/install ganeti-jumbo200[1-3] - https://phabricator.wikimedia.org/T405964
[17:04:56] <jynus>	 and I can do that work myself next year
[17:05:13] <jynus>	 the thing is, we don't even have a task yet
[17:05:31] <jynus>	 I have been asked to get this ready while I am out, so I think you would undestand my constraints
[17:05:44] <jynus>	 but not worries to work on that next year
[17:06:22] <inflatador>	 NP. I added my +1 with a comment about the UEFI. I've written a bunch of UEFI recipes, if you need a review feel free to ping me
[17:06:54] <jynus>	 this is why I am bothering you for the +1
[17:07:07] <jynus>	 normally this would have no urgency, but I am going away in a few hours
[17:07:21] <jynus>	 and want to unblock my colleagues
[17:08:35] <inflatador>	 You can pass along my offer to your colleagues, I'll be here until next Thursday and I'm happy to review
[17:08:47] <jynus>	 yeah, I am doing a sumary by email
[17:08:51] <jynus>	 and will include that
[17:09:32] <jynus>	 sorry this is so not great, we are in a bit of a schedule nightmare
[17:10:00] <inflatador>	 NP, it's that time of year ;)
[17:10:23] <jynus>	 but I think something merged would be better than everything merged
[17:11:50] <jynus>	 I also think telling them: BTW, you have to do the the UEFI migration and testin on your own would be unfair
[17:12:01] <inflatador>	 ACK, I'm headed to lunch but I gave my +1, I'll be back in about an hour if you feel like doing the recipe thing today before you leave. 
[17:12:13] <jynus>	 but ideally would be done before the next batch of installs indeed
[17:12:17] <jynus>	 thanks for pointing it out
[17:12:33] <inflatador>	 Although I guess it's not possible to test unless you have identical HW ready that can be reimaged
[17:12:36] <jynus>	 not today, as I sould be gone in -1 hours :-D
[17:12:48] <jynus>	 I don't even know what hardware will be bought!
[17:13:09] <jynus>	 that why I expect I will be able to work on that next year, after racking but before install
[17:13:38] <inflatador>	 Oh OK, if the hardware isn't even purchased yet I think you'll have time ;)
[17:13:44] <jynus>	 yep
[17:13:58] <jynus>	 I called them hypothetical backup hosts for a reason
[17:14:00] <jynus>	 :-D
[17:14:00] <inflatador>	 <o/
[17:14:06] <inflatador>	 have a great holiday!
[17:14:40] <jynus>	 sorry for the missunderstanding, I will aroun tomorrow
[17:14:57] <jynus>	 otherwise I would merge anything on puppet
[17:15:01] <jynus>	 n't
[17:15:20] <jynus>	 vacations after tomorrow