[17:17:05] small CR to fix Puppet on the alert servers if anyone has time to look: https://gerrit.wikimedia.org/r/c/operations/puppet/+/1354041 [17:22:13] confirmed that file you reference does not exist [17:23:49] whether something elses uses ['python3-requests', 'python3-dateutil'] i dont know but if it does the code should not be in this other plugin only [17:24:24] Yeah, I think we're OK on that front but will check when I run puppet again (although honestly that might not be immediately obvious) [17:24:58] yea.. maybe the real test would only be to manually remove the packages [17:26:00] but would not do that. better in the unlikely event it does pop up it does so in the future when there is a new icinga host [17:27:14] nevermind, if you'd remove it then the next puppet run would put it back [17:27:24] elasticsearch/base_plugin.pp: stdlib::ensure_packages(['python3-requests', 'python3-dateutil']) [17:27:29] seems fine [17:27:43] base_plugin does the same thing [17:31:32] Cool, everything looks good post-merge [17:35:06] great