[10:57:38] hello, i have a favour to ask for someone with MediaWiki shell access (if possible) -- if you're comfortable with doing so, please could you check the effective value of the `$wgFlaggedRevsHandleIncludes` on `enwikinews`? [10:58:42] the context is https://phabricator.wikimedia.org/T423512#11827347 & https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1271839 -- I'm not sure, but - given that other overrides for `$wgFlaggedRevsHandleIncludes` seem to be set in InitialiseSettings rather than flaggedrevs.php, I wonder if the IS.php default for that config variable might be overriding the custom value set for it in flaggedrevs.php [12:00:14] A_smart_kitten: it seems to be 2 [12:00:23] (`mw-debug-repl enwikinews` on deploy1003) [12:01:25] so IIUC, I think you’re correct that https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1271839 has no effect [12:01:45] *insert obligatory bash quip about FlaggedRevs here* [12:03:06] hm, though the headers of IS.php and CS.php seem to say that IS.php is loaded before CS.php? [12:03:10] *confused* [12:04:01] Lucas_WMDE: yeah, i also wondered about something like that since posting here, but for a different reason -- FWICS, that flaggedrevs.php config setting is set within a MediaWikiServices hook handler [12:04:11] but,,, if that's what a prod shell is saying... [12:04:29] also, thank you for checking that out!! [12:05:05] I added a call to load MediaWikiServices just to be sure, but $wgFlaggedRevsHandleIncludes is still 2 afterwards [12:05:10] so no idea why that code is behaving weirdly [12:05:30] I guess I could try moving the assignment to IS.php in mw-experimental [12:05:36] Lucas_WMDEfor the obligatory bash quip, both the ones at https://bash.toolforge.org/search?q=flaggedrevs seem to fit :p [12:05:52] yeah :P [12:06:16] Lucas_WMDE: i'm not gonna say you have to do that (it's up to you), but i am also now _insanely_ curious regarding whether that would do anything :p [12:06:43] flaggedrevs https://wikis.world/@LucasWerkmeister/116262429520403607 [12:09:37] bah, I forgot how tedious it is to run a shell script in there [12:09:40] * Lucas_WMDE looks up the right task [12:11:18] hm. still says the value is 2 [12:11:25] huuh [12:11:43] bnwiki is 0 though [12:11:49] so at least some of the IS.php overrides work [12:12:14] oh [12:12:19] it helps if I use the same dbname everywhere [12:12:29] ;p [12:12:40] yeah ok with enwiki*news* instead of -source it does return 0 [12:12:48] so yeah, move the config override to IS.php [12:12:54] do you want to comment on the task or should I? ^^ [12:13:25] (I came so close to reenacting https://bash.toolforge.org/quip/AU7VT58p6snAnmqnK_qP!) [12:13:35] (or https://bash.toolforge.org/quip/Sj3KapEBKFqumxvtIHYX) [12:13:38] i was about to say "will do, i'll comment on that patch/task", but i kinda think you might actually do a better job than me of explaining what you've found [12:13:54] i can get a patch up, though [12:13:55] ok, then I can paste terminal output there [12:13:58] sounds good [12:17:31] A_smart_kitten: commented [12:19:13] Lucas_WMDE: apologies if i'm missing something, did you meant to copy the bnwiki result? [12:19:51] uh [12:19:53] did I copy the wrong black [12:19:55] *block [12:19:58] * Lucas_WMDE has already closed the wrong terminal [12:20:12] *the terminal [12:20:17] * Lucas_WMDE brain no worky good anymore apparently [12:20:37] real [12:21:14] fixed, thanks [12:22:52] np :) thanks for the comment. patch incoming probably in ($how-long-it-takes-me-to-type-a-reasonable-commit-message + 2) minutes [12:28:53] Lucas_WMDE: it appears that this may be the second time that I'm uploading a patch to move around some FlaggedRevs config in order to fix what the config variables' effective values are in production; which isn't a lot, but it's weird that it happened twice. (TM) [12:28:54] the first being https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1227385 [12:29:41] watch out, you don’t want to look like you’re responsible for FlaggedRevs ;) [12:30:12] AAAAAAAAAAAAAAAAA [12:30:35] i should start prefixing my flaggedrevs-related commits with a disclaimer or something huh [12:31:13] "by uploading this patch, i am not claiming responsiblity for things to do with flaggedrevs in general" [12:31:43] A_smart_kitten: we're working on making that the default :D [12:32:24] that's what the ownership talk is about, I can find the email if you're curious (was sent to wikitech-l@ iirc)\ [12:32:58] Raine: oh yeah! i actually want to reply to that email with some thoughts but i haven't got around to doing it yet. i am cautiously very optimistic about it though :) [12:33:34] A_smart_kitten: <3 very happy to hear that [12:34:07] and more feedback more better ^_^ [12:52:34] pfft Lucas_WMDE I edit-conflicted with you while adding you as a reviewer. you had already +1ed it before my edit to add you went through :p [12:52:42] >:D [12:53:01] A_smart_kitten: I was wondering if it might qualify for an emergency deploy [12:53:07] it’s not clear to me how urgent / “bad” the task is [12:53:10] but probably not tbh [12:54:26] Lucas_WMDE: tbh I guess that might be a question for the enwikinews folks. 'normally' i'd probably be inclined to say that this change would be non-urgent, but enwikinews is working against a deadline for closure [12:55:34] i guess the impact of the current config might be as described at https://phabricator.wikimedia.org/T423512#11827523 [12:56:58] with the current information, i would probably be _inclined_ to say that it might not qualify as wiki-breaking enough [12:57:55] hm, they have 2½ weeks left, if the deploy waits until monday then it’s 2 weeks [12:58:33] I’ll ask, doesn’t hurt [12:58:37] ack [13:12:51] [discussion moved to #wikimedia-operations]