[00:14:23] Yeah, I fixed that 👍 (re @Toby: Don't you want to check the sign too? Z19897 Or do we need a separate one that checks everything.) [01:10:07] https://music.youtube.com/watch?v=NSUZZXyJmWo&si=gEhBWH5bmme_T4Zu [01:10:41] Oops [01:28:05] I don't understand why this implementation Z19924 is failing the last 2 tests. The debugs suggest that it stops on a return 0 (between "here" and "still here"), which would be correct. But the actual return seems to come from the "finally" section, which IMO shouldn't run after a return??? [01:33:35] The python converter for sign seems to be fine (re @Toby: I don't understand why this implementation Z19924 is failing the last 2 tests. The debugs suggest that it stops on a return 0 (b...) [01:33:53] “Normally” the finally-block always runs 🤷‍♂️ (re @Toby: I don't understand why this implementation Z19924 is failing the last 2 tests. The debugs suggest that it stops on a return 0 (b...) [01:39:17] I liked it so much that I composed five implementations 😏 (re @Al: Okay, I’ll pick that one up now.) [01:39:46] Even after a return?? (re @Al: “Normally” the finally-block always runs 🤷‍♂️) [01:40:30] Yep. It’s a housekeeping thing… (re @Toby: Even after a return??) [01:48:08] Thanks, I obviously don't do enough housekeeping! Now fixed. (re @Al: Yep. It’s a housekeeping thing…) [01:48:32] “8.4.4. `finally` clause¶ [01:48:33] If `finally` is present, it specifies a ‘cleanup’ handler. The `try` clause is executed, including any `except` and `else` clauses. If an exception occurs in any of the clauses and is not handled, the exception is temporarily saved. The `finally` clause is executed. If there is a saved exception it is re-raised at the end of the `finally` clause…. [01:48:34] “When a `return`, (https://docs.python.org/3/reference/simple_stmts.html#return) `break` or `continue` statement is executed in the `try` suite of a `try`…`finally` statement, the `finally` clause is also executed ‘on the way out.’…” [01:48:36] https://docs.python.org/3/reference/compound_stmts.html (re @Al: Yep. It’s a housekeeping thing…) [02:34:30] I think Z19911 is an interesting pattern to follow for documentation and navigation reasons. Two lists are compared. The first extracts each of the object keys using Z803 whilst the second does the same using key-specific functions (where available… so it’s also a todo list when any are missing). Not the best performer, but worth thinking about. [02:42:09] ✅ Z19892 (re @Al: Okay, I’ll pick that one up now.) [02:45:15] Z19928 will give false positive results when the numerators are zero and the denominators differ, so I’ve disconnected it. [13:20:41] It looks like implementations of Z19866 need a Z801 wrapper… But is leaving the function calls unresolved “expected behaviour”? : https://tools-static.wmflabs.org/bridgebot/ee60a8d2/file_66480.jpg [13:25:36] (echoed result) : https://tools-static.wmflabs.org/bridgebot/7e26551b/file_66483.jpg [13:37:23] Introducing Z20000. Let's make this one great! [14:33:41] @vrandecic this should be mentioned in the next newsletter. 10000 user-created objects is a notable accomplishment. (re @Toby: Introducing Z20000. Let's make this one great!) [15:52:35] I'll consider it 🙂 Lydia always scolds me when I celebrate numbers 🙂 [16:04:12] Why celebrating numbers is unacceptable for Lydia? (re @vrandecic: I'll consider it 🙂 Lydia always scolds me when I celebrate numbers 🙂) [16:04:26] That’s also what I like! [16:06:09] (Wait, Lydia is NOT Lymantria, right? Sometimes these names are confusing for me… [16:15:12] Not that I know, I was referring to @Nightrose -- it's just about celebrating random numbers instead of substance [16:15:49] 10000 objects is of substance imo (re @vrandecic: Not that I know, I was referring to @Nightrose -- it's just about celebrating random numbers instead of substance) [16:31:08] I've created a sample JS converter from Gregorian Year if you want to use it, Z20012. It outputs as described in the type proposal. (re @vrandecic: Newsletter 180: [16:31:08] * New type: Rational numbers [16:31:09] * Recent Changes in the software [16:31:11] * Natural numbers have a renderer and parser again...) [16:34:22] Also, maybe Python's datetime.date and JavaScript's Date should be used? [18:06:52] Still will! 😆 (re @vrandecic: I'll consider it 🙂 Lydia always scolds me when I celebrate numbers 🙂) [18:08:18] It tends to very quickly devolve into people just chasing numbers instead of being focused on the ultimate goal of the project unfortunately. (re @cvictorovich: Why celebrating numbers is unacceptable for Lydia?) [18:08:50] This is fair (re @Nightrose: It tends to very quickly devolve into people just chasing numbers instead of being focused on the ultimate goal of the project u...) [18:08:56] Leading to all kinds of bad side-effects like a lot of low-quality edits [18:09:11] 1 function and implementation is much better than 10 test cases [18:09:14] And this (re @Nightrose: Leading to all kinds of bad side-effects like a lot of low-quality edits) [18:10:18] That being said... I get it. I like to celebrate as well :P It's just about finding the right things to celebrate. [20:53:10] My method was to choose the right thing in advance then make sure it was the one that got the milestone. I decided on Bayes' about 30 objects earlier. Otherwise it could have been something dull like Z19991. (re @Nightrose: That being said... I get it. I like to celebrate as well :P It's just about finding the right things to celebrate.) [20:55:07] …dull but not “low quality” 😏 (re @Toby: My method was to choose the right thing in advance then make sure it was the one that got the milestone. I decided on Bayes' abo...) [20:56:10] Toby all 3 of the implementations you have listed as broken on your user page are fixed [20:59:16] Thanks. (re @Feeglgeef: Toby all 3 of the implementations you have listed as broken on your user page are fixed) [21:01:59] *T375972 *is now mostly fixed so I removed the Z801 (re @Toby: I've fixed the composition at Z19529. It looks like you were blocked by T375972, and then needed to add a case to handle single-...) [21:04:58] This also appears on the main create object form, when the only thing I'm likely to create when I open said form is a function (though, I guess this only really affects me, because I have it in my navigation) (re @amire80: Another issue with the function creation form: The types dropdown lists two suggested types and doesn't clearly hint that more m...) [21:07:23] Ah good. There is a bit of a task to look through all the "what links here" for Z801 (re @Al: T375972 is now mostly fixed so I removed the Z801) [21:07:51] Doing it already 😏 (re @Toby: Ah good. There is a bit of a task to look through all the "what links here" for Z801) [21:11:20] Toby Related to this, *technically*, the code you took from my common.js is under the CC Attribution Share-Alike :) (re @Feeglgeef: This also appears on the main create object form, when the only thing I'm likely to create when I open said form is a function (...) [21:33:20] Bored with that now, sorry 😏 (re @Toby: Ah good. There is a bit of a task to look through all the "what links here" for Z801) [22:14:46] Just so you guys know, I'm going to be running a script that requests the Wikifunctions API fairly frequently. I'm not sure how much the API can tolerate, but I'm pretty sure it should be fine. If you need me to stop, I will. [22:21:02] make sure you're setting a useful user agent https://foundation.wikimedia.org/wiki/Policy:User-Agent_policy [22:26:20] It should be set to "feeglgeef-bot" (re @wmtelegram_bot: make sure you're setting a useful user agent https://foundation.wikimedia.org/wiki/Policy:User-Agent_policy) [22:27:41] ideally you should have at least a link to a wikimedia user page, preferably also an email address [22:28:44] like "[[WF:User:Feeglgeef]]-bot"? [22:29:35] f:User:Feeglgeef* [23:00:56] Toby? (re @Feeglgeef: Toby Related to this, *technically*, the code you took from my common.js is under the CC Attribution Share-Alike :)) [23:20:24] The idea is to transform the data into a better format for a userscript that shows what compositions use a function and such (re @Feeglgeef: Just so you guys know, I'm going to be running a script that requests the Wikifunctions API fairly frequently. I'm not sure how ...)