[12:27:03] [coretasks.py] Received an apparently useless MODE message: :ZppixBot MODE ZppixBot :+i [17:32:17] .help [17:32:17] Hang on, I'm creating a list. [17:32:19] I've posted a list of my commands at https://clbin.com/JzUnw - You can see more info about any of these commands by doing .help (e.g. .help time) [17:36:06] 10Tool-Zppixbot, 10User-Zppix: Create a URL blacklist for the URL module - https://phabricator.wikimedia.org/T201234 (10TheVoidwalker) p:05High→03Normal The bot config already has a url blacklist built in (bot.config.url.exclude and bot.memory['url_exclude']). I'd say all we need to do is allow for it to b... [19:02:25] Voidwalker: you can feel free to attempt to do ^ if you want [19:02:42] oh, that's what I'm doing [19:03:13] Voidwalker: you forked the repo then i take it? [19:03:52] yeah [19:04:06] currently playing with urls.py [19:05:16] Voidwalker: make sure you use protection xD [19:06:06] :O [19:23:06] Pix1234/ZppixBot-Source/master/ae1de2f - Devin/Zppix The build was broken. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/586214061 [19:23:27] Voidwalker: also fyi we tend to ignore travis, but if you want to do the right thing you can fix it if you want [19:23:46] I mainly have travis so we can see if something will go very wrong [21:39:33] 10Tool-Zppixbot, 10User-Zppix: Create a URL blacklist for the URL module - https://phabricator.wikimedia.org/T201234 (10TheVoidwalker) a:03TheVoidwalker [21:40:52] Pix1234/ZppixBot-Source/master/7ff1a0a - The-Voidwalker The build is still failing. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/586266476 [21:41:34] [irc.py] Exception from Voidwalker: AttributeError: '_sre.SRE_Pattern' object has no attribute 'matches' (file "/data/project/zppixbot/.sopel/modules/urls.py", line 258, in url_command) (:Voidwalker!~Voidwalke@wikipedia/The-Voidwalker PRIVMSG ZppixBot :.url match https://publictestwiki.org) [21:41:46] rip [21:42:39] nixe [21:42:40] nice [21:42:43] Voidwalker: what is wrong? [21:45:44] [irc.py] Exception from Voidwalker: AttributeError: '_sre.SRE_Pattern' object has no attribute 'matches' (file "/data/project/zppixbot/.sopel/modules/urls.py", line 258, in url_command) (:Voidwalker!~Voidwalke@wikipedia/The-Voidwalker PRIVMSG ZppixBot :.url match https://publictestwiki.org) [21:45:54] that :P [21:47:39] just made a mistake in the regex objects [21:47:45] nice [21:48:11] now for some testing [21:48:14] https://publictestwiki.com/wiki/Special:RecentChanges?hidebots=1&translations=filter&limit=50&days=7&urlversion=2 [21:48:19] [ Recent changes - TestWiki ] - publictestwiki.com [21:52:10] apparently regex is being annoying and python won't match the regex "publictestwiki" with "publictestwiki.com" [21:52:37] hmm [21:53:59] wait [21:54:07] .url ban publictestwiki.com [21:54:07] Voidwalker: Successfully added ban: publictestwiki.com [21:54:10] https://publictestwiki.com/wiki/Special:RecentChanges?hidebots=1&translations=filter&limit=50&days=7&urlversion=2 [21:54:25] seems that works [21:54:30] whack [21:54:37] publictestwiki.com/wiki/User:Zppix [21:54:44] cool [21:54:44] .url allow publictestwiki.com [21:54:46] Voidwalker: Successfully removed ban on: publictestwiki.com [21:54:56] https://publictestwiki.com/wiki/Special:RecentChanges?hidebots=1&translations=filter&limit=50&days=7&urlversion=2 [21:54:57] [ Recent changes - TestWiki ] - publictestwiki.com [21:55:20] Voidwalker: only bot admins are able to .url ban and allow right? [21:55:43] not yet [21:55:44] whoops [21:56:03] that should just be a simple if statement and i think sopel has a param that gets the admin list from config Voidwalker [21:56:22] Voidwalker: bot.config.core.admins [21:58:23] .reload [21:58:36] ZppixBot reload [21:58:40] ZppixBot: reload [21:58:41] [irc.py] Exception from #ZppixBot: NameError: name 'require_admin' is not defined (file "/data/project/zppixbot/.sopel/modules/urls.py", line 241, in ) (:Voidwalker!~Voidwalke@wikipedia/The-Voidwalker PRIVMSG #ZppixBot :ZppixBot reload) [21:58:43] [irc.py] Exception from #ZppixBot: AttributeError: 'function' object has no attribute 'priority' (file "/data/project/zppixbot/lib/python3.5/site-packages/sopel/bot.py", line 216, in unregister) (:Voidwalker!~Voidwalke@wikipedia/The-Voidwalker PRIVMSG #ZppixBot :ZppixBot: reload) [21:58:51] oof [21:59:37] Voidwalker: i dont think it liked that [21:59:44] [irc.py] Exception from Voidwalker: AttributeError: 'function' object has no attribute 'priority' (file "/data/project/zppixbot/lib/python3.5/site-packages/sopel/bot.py", line 216, in unregister) (:Voidwalker!~Voidwalke@wikipedia/The-Voidwalker PRIVMSG ZppixBot :.reload) [22:00:13] what does that even mean? [22:00:19] hell if i know [22:00:39] probably the change you did [22:00:55] Pix1234/ZppixBot-Source/master/bd55bcc - The-Voidwalker The build is still failing. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/586273218 [22:01:38] Pix1234/ZppixBot-Source/master/3beda92 - The-Voidwalker The build is still failing. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/586273964 [22:02:28] [irc.py] Exception from Voidwalker: AttributeError: 'function' object has no attribute 'priority' (file "/data/project/zppixbot/lib/python3.5/site-packages/sopel/bot.py", line 216, in unregister) (:Voidwalker!~Voidwalke@wikipedia/The-Voidwalker PRIVMSG ZppixBot :.reload) [22:02:39] .url [22:02:59] looks like it doesn't even know how to unload it if it fails [22:03:49] what if you use bot.config.core.admins instead of @requireadmin [22:03:52] Voidwalker: [22:04:22] Pix1234/ZppixBot-Source/master/efac8d9 - The-Voidwalker The build is still failing. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/586274933 [22:06:15] it should be @require_admin, and it needs to be imported [22:06:29] Voidwalker: did you import it? [22:06:33] [coretasks.py] Received an apparently useless MODE message: :ZppixBot MODE ZppixBot :+i [22:06:37] I tried reverting, but I think I have to restart [22:06:46] the bot that is [22:06:47] Pix1234/ZppixBot-Source/master/3beda92 - The-Voidwalker The build is still failing. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/586275578 [22:06:51] .url [22:06:51] Voidwalker: I don't know how to do what you're asking! [22:06:55] .url list [22:06:56] Voidwalker: I don't know how to do what you're asking! [22:07:00] .url match [22:07:00] Voidwalker: I don't know how to do what you're asking! [22:07:03] .url match ' [22:07:03] Voidwalker: Could not find ' [22:07:08] .url match a [22:07:08] Voidwalker: Could not find a [22:07:12] .url match c [22:07:12] Voidwalker: Could not find c [22:07:31] .help url [22:07:32] Voidwalker: Allow a bot admin to modify the url blacklist. Accepts `ban`, `allow` and `match` as parameters. [22:07:33] Voidwalker: e.g. .url ban http://google.com [22:07:53] don't know of any way to test, but it should work [22:08:01] .url ban google.com [22:08:01] Zppix: Successfully added ban: google.com [22:08:06] .url match google.com [22:08:06] Zppix: Found google.com: google.com [22:08:12] .url allow google.com [22:08:12] Zppix: Successfully removed ban on: google.com [22:09:56] bbl [22:10:31] k [22:10:42] 10Tool-Zppixbot, 10User-Zppix: Create a URL blacklist for the URL module - https://phabricator.wikimedia.org/T201234 (10TheVoidwalker) 05Open→03Resolved Few more tweaks to go, but the functionality should all be there. [22:58:32] Pix1234/ZppixBot-Source/master/2ced91f - The-Voidwalker The build is still failing. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/586290896 [22:58:48] ahh, fixed the last issue I was having [23:21:50] Voidwalker: which was? [23:28:30] usinge .match instead of .search [23:28:55] .match only checks to see if the checked string starts with the search terms [23:30:28] oh [23:30:31] .url search [23:30:31] Zppix: I don't know how to do what you're asking! [23:30:34] .help url [23:30:36] Zppix: Allow a bot admin to modify the url blacklist. Accepts `ban`, `allow` and `match` as parameters. [23:30:36] Zppix: e.g. .url ban http://google.com [23:33:12] yeah, the problem was that using .url match https://example.com wouldn't discover the entry for example.com [23:33:12] [ Example Domain ] - example.com [23:34:26] also note that the .url ban target has to be valid regex [23:35:04] so .url ban example.com matches example.com and examplexcom [23:35:23] where as .url ban example\.com only matches example.com [23:36:50] I also want to add a .url list function to give you the whole list, but I'd have to setup a pastebin posting thing, and that's work I don't want to do for now :P [23:37:53] Voidwalker: you could also just have it write to a file and then have it pm a list [23:38:51] that could be a long list, and I don't want the bot killed for spam [23:39:21] true [23:39:41] (although it probably has anti flood, getting a line by line set of regex expressions would be annoying as hell) [23:39:48] Voidwalker: it does have antiflood [23:40:19] Voidwalker: did you see .discord? [23:41:37] pretty sure, yeah [23:43:04] nice and simple :) [23:43:57] yes