[10:44:49] [02ZppixBot-Source] 07RhinosF1 opened pull request 03#98: Bug fixes - 13https://git.io/Jegzm [10:46:08] Zppix, Reception123: % [10:46:15] s/%/^ [10:46:15] RhinosF1 meant to say: Zppix, Reception123: ^ [11:20:32] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [11:23:42] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [11:26:03] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [11:28:15] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [11:29:14] Reception123: ^ if you understand python please check I haven't broke something [11:30:16] 10Tool-Zppixbot: Support multi word status messages - https://phabricator.wikimedia.org/T236592 (10RhinosF1) https://github.com/Pix1234/ZppixBot-Source/pull/95 should include this [11:30:31] 10Tool-Zppixbot: Properly configure sulgroup option - https://phabricator.wikimedia.org/T235106 (10RhinosF1) https://github.com/Pix1234/ZppixBot-Source/pull/95 [11:32:55] Zppix, Reception123: please let me know what line travis is moaning about indents on [11:36:55] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [11:37:30] Zppix: you can sort line lengths out [11:40:49] not sure rather leave Zppix to it [11:42:13] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [11:44:56] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [11:47:43] ^ not sure auto format worked so leaving to Zppix [11:47:54] Reception123: ok [11:48:07] I’ve either made mass improvements or broke it [11:48:14] heh [11:48:58] Reception123: CI only moans about code style so I’m hoping it’s the first one [11:49:44] I just hope toolforge read/write is good [13:28:26] RhinosF1: R/W isnt a problem, ill look at it either tomorrow or after work [13:28:39] Zppix: ok [13:28:53] The new code should fix bugs and be a bit nicer [13:29:12] As main() handles more now [14:02:02] [02ZppixBot-Source] 07Pix1234 closed pull request 03#98: Bug fixes - 13https://git.io/Jegzm [14:02:04] [02ZppixBot-Source] 07Pix1234 pushed 032 commits to 03master [+0/-0/±2] 13https://git.io/JegVq [14:02:05] [02ZppixBot-Source] 07RhinosF1 03e53b23e - Bug fixes Use trigger.nick for chanops rather than trigger.sender [14:02:07] [02ZppixBot-Source] 07Pix1234 03f2da96c - Merge pull request #98 from RhinosF1/patch-28 Bug fixes [22:28:59] Voidwalker, Zppix: any chance you can review/merge my PR [22:29:48] oh, hadn't seen it [22:30:05] Voidwalker: it’s an old one I’ve updated and finished [22:33:03] looks like there's a syntax error (according to travis), let me see what's up [22:33:35] ah, pass is a reserved word [22:34:42] Voidwalker: it's moaning at line length I think [22:35:03] nope, pass is a reserved word, and you are trying to use it like a variable [22:35:05] Travis being happy with me and ZppixBot is unusual [22:35:12] Voidwalker: hmm [22:35:20] What line? [22:35:56] uh, it's used repeatedly throughout the function main [22:36:12] first on 49 though [22:36:12] * RhinosF1 will look [22:36:15] .source [22:36:21] RhinosF1: My code can be found here: https://github.com/Pix1234/ZppixBot-Source [22:36:40] also, line 83 doesn't look right [22:38:19] Voidwalker: I'm mobile and lazy so I think 83 is wrong indent level and pass can be changed to continue or something [22:38:29] If not I'll do it tommorow [22:38:52] no, 83 doesn't look right because it's an assignment operation inside an if statement [22:38:56] :P [22:39:15] It should be == [22:39:31] That's one of my very classic mistakes that I need to not do [22:41:45] [02ZppixBot-Source] 07The-Voidwalker synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [22:43:11] Voidwalker: let's see what travis says [22:43:20] * Voidwalker watches travis closely [22:44:47] [02ZppixBot-Source] 07The-Voidwalker synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [22:48:34] Voidwalker: for line in cloakfile [22:51:58] [02ZppixBot-Source] 07The-Voidwalker synchronize pull request 03#95: reorder code - 13https://git.io/JeW1j [22:52:58] Voidwalker: nice commit msg [22:53:15] :P [22:54:36] Voidwalker: it worked! [22:54:52] gonna squash that in [22:55:10] Good idea [22:55:23] [02ZppixBot-Source] 07The-Voidwalker closed pull request 03#95: reorder code - 13https://git.io/JeW1j [22:55:25] [02ZppixBot-Source] 07The-Voidwalker pushed 031 commit to 03master [+1/-0/±1] 13https://git.io/JegDW [22:55:26] [02ZppixBot-Source] 07RhinosF1 03f9b54bf - reorder code (#95) * reorder code DO NOT MERGE - Will be used to add SUL_GROUP config * Update status.py * Update status.py * Create cloaks.csv * Update status.py * Update status.py * PEP8 using https://codebeautify.org/python-formatter-beautifier * revert * fixes * clean misplaced character * this better be the last thing [22:55:27] [ Attention Required! | Cloudflare ] - codebeautify.org [22:56:15] * RhinosF1 hopes the logic is better than the syntax [22:58:31] Voidwalker: don't forget to reload the module and deploy [22:58:52] ZppixBot, reload [22:59:00] Voidwalker: done [22:59:16] .status mhtest testing [22:59:16] RhinosF1: Syntax: .mh wikicode status [22:59:32] Ffs [23:01:16] How the hell have I broke code that shouldn't have changed [23:01:55] * RhinosF1 will have to look later [23:02:07] .status mhtest testing testing [23:02:20] I know what I've done [23:03:13] [02ZppixBot-Source] 07RhinosF1 opened pull request 03#99: Bug fix - 13https://git.io/JegDK [23:03:37] I mean it didnt output anything so thag cant be amazing [23:04:43] * RhinosF1 will investigate later tommorow [23:08:37] I need to sleep [23:10:02] [02ZppixBot-Source] 07The-Voidwalker closed pull request 03#99: Bug fix - 13https://git.io/JegDK [23:10:04] [02ZppixBot-Source] 07The-Voidwalker pushed 032 commits to 03master [+0/-0/±2] 13https://git.io/JegD9 [23:10:05] [02ZppixBot-Source] 07RhinosF1 03fd7b2e4 - Bug fix [23:10:07] [02ZppixBot-Source] 07The-Voidwalker 03e8b9fe6 - Merge pull request #99 from RhinosF1/patch-29 Bug fix [23:10:30] ZppixBot, reload [23:10:31] Voidwalker: done