[08:41:20] Reception123: ^ looking [08:43:46] 10Tool-Zppixbot, 10User-RhinosF1: ZppixBot-test restarting due to memory not saving ping/pong - not loaded? - https://phabricator.wikimedia.org/T248960 (10RhinosF1) This is likely a race condition but the whole start/stop sequence is broken. I've filled https://github.com/sopel-irc/sopel/issues/1868 and https... [08:44:03] 10Tool-Zppixbot, 10Upstream, 10User-RhinosF1: ZppixBot-test restarting due to memory not saving ping/pong - not loaded? - https://phabricator.wikimedia.org/T248960 (10RhinosF1) 05Open→03Stalled p:05Medium→03Lowest [08:49:28] 10Tool-Zppixbot, 10Upstream, 10User-RhinosF1: Multiple race conditions causing ZppixBot(-test) to disconnect and poorly restart - https://phabricator.wikimedia.org/T248960 (10RhinosF1) [08:51:01] .version [08:51:01] RhinosF1: Sopel v7.0.3 (Python 3.5.3) [09:34:10] ^ that's me rebooting to keep the memory sane [10:02:42] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03master [+0/-1/±0] 13https://git.io/Jfg1S [10:02:43] [02ZppixBot-Source] 07RhinosF1 03814bafb - Delete reminders.py Use the deafult reminders script and move cancel to custom responses [10:03:28] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03master [+1/-0/±0] 13https://git.io/Jfg1F [10:03:30] [02ZppixBot-Source] 07RhinosF1 03d47234b - Create reminders.py [10:04:51] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03RhinosF1-patch-1 [+0/-1/±0] 13https://git.io/Jfg1N [10:04:53] [02ZppixBot-Source] 07RhinosF1 03b9fe870 - update reminders [10:04:56] [02ZppixBot-Source] 07RhinosF1 opened pull request 03#136: update reminders - 13https://git.io/Jfg1x [10:06:06] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03RhinosF1-patch-1 [+0/-0/±1] 13https://git.io/Jfg1j [10:06:08] [02ZppixBot-Source] 07RhinosF1 030399fe9 - move cancelreminder to responses and update [10:06:09] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#136: update reminders - 13https://git.io/Jfg1x [10:06:34] Pix1234/ZppixBot-Source/RhinosF1-patch-1/b9fe870 - RhinosF1 The build was fixed. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/689586196 [10:09:59] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03RhinosF1-patch-1 [+0/-0/±1] 13https://git.io/JfgMq [10:10:01] [02ZppixBot-Source] 07RhinosF1 03c69d042 - Update responses.py [10:10:02] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#136: update reminders - 13https://git.io/Jfg1x [10:12:34] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03RhinosF1-patch-1 [+0/-0/±1] 13https://git.io/JfgMc [10:12:35] [02ZppixBot-Source] 07RhinosF1 03910ae71 - Update responses.py [10:12:37] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#136: update reminders - 13https://git.io/Jfg1x [10:14:43] [02ZppixBot-Source] 07RhinosF1 closed pull request 03#136: update reminders - 13https://git.io/Jfg1x [10:14:45] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03dev [+0/-1/±1] 13https://git.io/JfgMB [10:14:46] [02ZppixBot-Source] 07RhinosF1 0392c68fe - update reminders (#136) * update reminders * move cancelreminder to responses and update * Update responses.py * Update responses.py [10:15:33] Reception123: ^ [10:16:32] RhinosF1: oh so we can finally cancel stuff now? [10:16:44] Reception123: no [10:16:51] still needs the db I think [10:17:08] I just moved the command to custom responses and use sopel's default remind.py [10:18:00] ah [10:20:39] Reception123: rebooting again to test that fixed a bug [10:21:07] ok [10:31:53] Reception123: do you think it's fine to deploy https://git.io/JfgMB to prod [10:31:53] [ Comparing cfd3e7b8889f...92c68fe953ec · Pix1234/ZppixBot-Source · GitHub ] - git.io [10:32:57] seems fine [10:34:46] [02ZppixBot-Source] 07RhinosF1 opened pull request 03#137: Update reminders - 13https://git.io/JfgDR [10:35:11] [02ZppixBot-Source] 07RhinosF1 closed pull request 03#137: Update reminders - 13https://git.io/JfgDR [10:35:58] Reception123: doing then [10:38:46] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/JfgDK [10:38:48] [02ZppixBot-Source] 07RhinosF1 03ff4c47b - update reminders (#136) * update reminders * move cancelreminder to responses and update * Update responses.py * Update responses.py [10:39:06] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03master [+0/-1/±0] 13https://git.io/JfgD6 [10:39:07] [02ZppixBot-Source] 07RhinosF1 035463ee6 - Delete reminders.py [10:39:18] [02ZppixBot-Source] 07RhinosF1 deleted branch 03RhinosF1-patch-1 [10:41:31] Reception123: ^ not me [10:41:46] hm :( [10:42:09] Reception123: I've restarted to apply the update so it might take it a while as it has to do a db upgrade [10:42:22] test took 56s tbh [10:44:46] Reception123: ^ back, There seems to be an issue when they start up with it erroring [10:44:54] but it recovers after 4 attempts [10:45:36] sopel.bot-7bd9cf6678-xpfhf 0/1 CrashLoopBackOff 3 2m [10:48:09] k [10:50:13] Reception123: I don’t know whether to change how it’s set up or what to [10:51:13] Or at least make it git pull on start up [10:52:13] but I’m too lazy to move everything [10:55:59] yeah I don't know [11:07:59] Reception123: we should wait while zppix is around [11:08:09] Before breaking too much [11:09:22] i do want to try and get as much of our code up to date with sopel though and actually make our hacks plugins [11:10:00] that means void looking at urls [11:10:04] yeah [11:10:41] .ask Voidwalker can you evacuate the custom code from urls to its own plugin asap? [11:10:41] RhinosF1: I'll pass that on when Voidwalker is around. [11:10:43] .source [11:10:43] RhinosF1: My code can be found here: https://github.com/Pix1234/ZppixBot-Source [11:11:32] Reception123: we need to streamline a lot of our code [11:12:00] Why don’t you try merging adminlist and responses as they can probably go together? [11:12:30] * RhinosF1 is going to look at some stuff [11:13:22] Pyver can merge as wel [11:37:39] .version [11:37:39] RhinosF1: Sopel v7.0.3 (Python 3.5.3) [11:37:52] Why does pyver exist [11:43:28] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) [11:43:44] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) [11:44:45] 10Tool-Zppixbot, 10User-RhinosF1, 10User-Zppix: Code review for ZppixBot's mhphab.py - https://phabricator.wikimedia.org/T253111 (10RhinosF1) [11:44:49] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) [11:46:27] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) [11:46:53] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) [11:52:27] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03stop-core-hacks [+0/-1/±0] 13https://git.io/Jfg9L [11:52:29] [02ZppixBot-Source] 07RhinosF1 033abaac0 - use sopel core where we can [11:52:54] [02ZppixBot-Source] 07RhinosF1 opened pull request 03#138: use sopel core where we can - 13https://git.io/Jfg9q [11:53:42] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03botver-to-response [+0/-1/±0] 13https://git.io/Jfg9m [11:53:44] [02ZppixBot-Source] 07RhinosF1 03bc36e4a - move to responses [11:53:51] [02ZppixBot-Source] 07RhinosF1 opened pull request 03#139: move to responses - 13https://git.io/Jfg9Y [11:54:24] Pix1234/ZppixBot-Source/stop-core-hacks/3abaac0 - RhinosF1 The build passed. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/689612100 [11:54:40] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03botver-to-response [+0/-0/±1] 13https://git.io/Jfg9O [11:54:42] [02ZppixBot-Source] 07RhinosF1 031af1389 - + source and botver [11:54:43] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#139: move to responses - 13https://git.io/Jfg9Y [11:55:07] [02ZppixBot-Source] 07RhinosF1 edited pull request 03#139: move botver to responses - 13https://git.io/Jfg9Y [11:56:09] 10Tool-Zppixbot, 10User-RhinosF1: Merge response-only plugins with responses.py - https://phabricator.wikimedia.org/T253298 (10RhinosF1) [11:56:45] 10Tool-Zppixbot, 10User-RhinosF1: Merge response-only plugins with responses.py - https://phabricator.wikimedia.org/T253298 (10RhinosF1) p:05Triage→03High [11:57:54] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Replace Core-Overrides with addon plugins - https://phabricator.wikimedia.org/T253299 (10RhinosF1) [11:58:06] [02ZppixBot-Source] 07RhinosF1 ready_for_review pull request 03#139: move botver to responses - 13https://git.io/Jfg9Y [11:58:14] [02ZppixBot-Source] 07RhinosF1 closed pull request 03#139: move botver to responses - 13https://git.io/Jfg9Y [11:58:15] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03stop-core-hacks [+0/-1/±1] 13https://git.io/Jfg9s [11:58:17] [02ZppixBot-Source] 07RhinosF1 030467325 - move botver to responses (#139) [11:58:18] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#138: use sopel core where we can - 13https://git.io/Jfg9q [11:58:43] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03stop-core-hacks [+0/-1/±0] 13https://git.io/Jfg9G [11:58:44] [02ZppixBot-Source] 07RhinosF1 0374d5346 - Delete pyver.py .version does this fine [11:58:46] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#138: use sopel core where we can - 13https://git.io/Jfg9q [12:00:59] [02ZppixBot-Source] 07RhinosF1 deleted branch 03botver-to-response [12:01:43] 10Tool-Zppixbot, 10User-RhinosF1: Merge response-only plugins with responses.py - https://phabricator.wikimedia.org/T253298 (10RhinosF1) https://github.com/Pix1234/ZppixBot-Source/pull/138 [12:01:54] [02ZppixBot-Source] 07RhinosF1 review_requested pull request 03#138: use sopel core where we can - 13https://git.io/Jfg9q [12:01:55] [02ZppixBot-Source] 07RhinosF1 review_requested pull request 03#138: use sopel core where we can - 13https://git.io/Jfg9q [12:01:57] [02ZppixBot-Source] 07RhinosF1 review_requested pull request 03#138: use sopel core where we can - 13https://git.io/Jfg9q [12:02:11] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) p:05Triage→03High [12:10:50] 10Tool-Zppixbot, 10User-RhinosF1: Consider whether url.py can be made to addon to core - https://phabricator.wikimedia.org/T253300 (10RhinosF1) [12:12:44] 10Tool-Zppixbot, 10User-RhinosF1: Consider whether url.py can be made to addon to core - https://phabricator.wikimedia.org/T253300 (10RhinosF1) [12:14:52] 10Tool-Zppixbot, 10User-RhinosF1: Consider whether url.py can be made to addon to core - https://phabricator.wikimedia.org/T253300 (10RhinosF1) [12:21:00] 10Tool-Zppixbot: Evaluate join.py - https://phabricator.wikimedia.org/T253301 (10RhinosF1) [13:31:14] [02ZppixBot-Source] 07RhinosF1 edited pull request 03#135: Rebuild mhphab script - 13https://git.io/JfuH3 [13:37:59] Reception123: ^ we should have a new high priority task alert script thingy soon [13:38:13] great [13:38:49] Reception123: it's down massively in terms of lines [13:39:04] nice [13:40:38] Reception123: I think it will end up being 30-40% of the size [13:40:49] not bad [13:43:09] 10Tool-Zppixbot, 10User-RhinosF1, 10User-Zppix: Code review for ZppixBot's mhphab.py - https://phabricator.wikimedia.org/T253111 (10RhinosF1) Using requests, my current code is 67 lines & 1 file compared to 342 lines + 2 files but is only about half done. I may split bits into 2 files over time but in total... [14:02:39] [02ZppixBot-Source] 07RhinosF1 ready_for_review pull request 03#135: Rebuild mhphab script - 13https://git.io/JfuH3 [14:03:50] [02ZppixBot-Source] 07RhinosF1 pushed 0311 commits to 03mhphab-rewrite [+0/-2/±12] 13https://git.io/JfgFE [14:03:51] [02ZppixBot-Source] 07RhinosF1 036551eda - Merge branch 'dev' into mhphab-rewrite [14:03:53] [02ZppixBot-Source] 07RhinosF1 synchronize pull request 03#135: Rebuild mhphab script - 13https://git.io/JfuH3 [14:05:35] Pix1234/ZppixBot-Source/mhphab-rewrite/6551eda - RhinosF1 The build is still failing. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/689664331 [14:06:27] Reception123: I removed our only test coverage [14:06:42] And I’m not sure how we rewrite them [14:06:44] k [14:06:48] no idea either [14:07:30] Reception123: they were built by the GCI student so maybe zppix could put it back up for GCI. [14:08:05] yeah, I remember him he was really good [14:09:01] Reception123: it’s his code I’m ripping out [14:09:36] RhinosF1: yeah, though I remember he did a good job back then and really quickly too [14:10:42] Reception123: it’s good code, just a long way round it [14:10:58] yeah [14:18:10] Reception123: tbh, Status.py probably does that. I could do with fixing mwclient [14:18:23] ah [14:23:38] Reception123: there’s a decepration warning so now’s probably a good time to replace it [14:23:51] If you can find it in the raw logs again then create a task [14:23:52] yeah [14:24:18] Reception123: can you have a look in the logs for the error (try sopel.raw.log) and file a task [15:54:24] is the .reload still broken? [15:55:36] Voidwalker: it’s never worked properly or being advised by sopel [15:55:47] It’s highly unreliable [15:55:57] unfortunate [15:56:45] [02ZppixBot-Source] 07The-Voidwalker pushed 031 commit to 03master [+0/-0/±1] 13https://git.io/Jfgpc [15:56:47] [02ZppixBot-Source] 07The-Voidwalker 03f9b5d3e - drop #miraheze-meetings [15:59:13] Voidwalker: can that not read from default.cfg anyway? [15:59:38] possibly, I forget why it didn't [16:00:20] Voidwalker: it really should. Tbh, most of that can be moved upstream. [16:00:54] .joinall is a basic plugin and the join wait should have been fixed upstream [16:02:33] wouldn't know, I haven't touched in ages [16:02:59] Voidwalker: We need to re-test that and try and fix it as well [16:03:14] Urls should be priority as that’s bigger [16:03:22] I did remind.py today [21:10:45] [02ZppixBot-Source] 07RhinosF1 pushed 031 commit to 03replace-join [+1/-1/±0] 13https://git.io/Jf2tI [21:10:46] [02ZppixBot-Source] 07RhinosF1 038e6361e - Update and rename join.py to forcejoin.py [21:11:07] [02ZppixBot-Source] 07RhinosF1 opened pull request 03#140: Update and rename join.py to forcejoin.py - 13https://git.io/Jf2tt